On Tue, Oct 24, 2017 at 5:02 PM, Lorenzo Pieralisi <lorenzo.pieral...@arm.com> wrote: > The PSCI checker suspend_test_thread() function (ie executed for the > suspend test) requires an on-stack timer to carry out the test it > executes; it sets it up through the setup_timer_on_stack() API. > > setup_timer_on_stack() requires its counterpart destroy_timer_on_stack() > to be called when the timer is disposed of but the PSCI checker code is > currently missing that call, leaving the timer object in an incosistent > state when the PSCI checker stops the thread executing the suspend > test. > > Add the missing destroy_timer_on_stack() call to fix the omission. > > Fixes: ea8b1c4a6019 ("drivers: psci: PSCI checker module") > Signed-off-by: Lorenzo Pieralisi <lorenzo.pieral...@arm.com> > Reported-by: Kees Cook <keesc...@chromium.org> > Cc: Kees Cook <keesc...@chromium.org> > Cc: Mark Rutland <mark.rutl...@arm.com>
Hi Lorenzo, You addressed the patch 'To: a...@kernel.org', but I'm not entirely sure what to do with it, it would be nice to be a little more explicit whether you want us to apply the patch directly or just review it, and which trees you want it to get merged into. As you are fixing a regression against v4.10, I would assume you want it merged into v4.14 with a 'cc: stable' tag to have it backported into v4.13, correct? Arnd