Re: EBPF-triggered WARNING at mm/percpu.c:1361 in v4-14-rc2

2017-09-28 Thread Tejun Heo
Hello, On Thu, Sep 28, 2017 at 03:45:38PM +0100, Mark Rutland wrote: > > Perhaps the pr_warn() should be ratelimited; or could there be an > > option where we only return NULL, not triggering a warn at all (which > > would likely be what callers might do anyway when checking against > > PCPU_MIN_U

Re: EBPF-triggered WARNING at mm/percpu.c:1361 in v4-14-rc2

2017-09-28 Thread Daniel Borkmann
On 09/28/2017 04:45 PM, Mark Rutland wrote: On Thu, Sep 28, 2017 at 04:37:46PM +0200, Daniel Borkmann wrote: On 09/28/2017 01:27 PM, Mark Rutland wrote: Hi, While fuzzing v4.14-rc2 with Syzkaller, I found it was possible to trigger the warning at mm/percpu.c:1361, on both arm64 and x86_64. Thi

Re: [PATCH v4 for 4.14 1/3] membarrier: Provide register expedited private command

2017-09-28 Thread Nicholas Piggin
On Thu, 28 Sep 2017 13:31:36 + (UTC) Mathieu Desnoyers wrote: > - On Sep 27, 2017, at 9:04 AM, Nicholas Piggin npig...@gmail.com wrote: > > > On Tue, 26 Sep 2017 20:43:28 + (UTC) > > Mathieu Desnoyers wrote: > > > >> - On Sep 26, 2017, at 1:51 PM, Mathieu Desnoyers > >> mathi

Re: [PATCH v3 5/5] mtd: spi-nor: cadence-quadspi: Add runtime PM support

2017-09-28 Thread matthew . gerlach
Hi Vignesh, I tried this patch on an Arria10 SOCFPGA devkit against the 4.1.33-ltsi kernel, and it did not go well. Commands to the flash chip timedout resulting in the probe function failing. I ran into other problems, not related to cadence-quadspi, that prevented me from testing against

Re: [PATCH 1/2 v2] fdmap(2)

2017-09-28 Thread Andy Lutomirski
On Thu, Sep 28, 2017 at 3:55 AM, Alexey Dobriyan wrote: > On 9/28/17, Michael Kerrisk (man-pages) wrote: >> On 27 September 2017 at 17:03, Andy Lutomirski wrote: > The idea is to start process. In ideal world, only bynary system calls would exist and shells could emulate /proc/* same w

Re: [PATCH] uio/uio_pci_generic: Add SR-IOV support

2017-09-28 Thread Don Dutile
On 09/28/2017 09:46 AM, David Woodhouse wrote: On Thu, 2017-09-28 at 08:22 -0400, Don Dutile wrote: After reading Alex's response, I now understand Dave's question better and why the patch won't work in general. UIO doesn't work "in general". It requires a very *specific* userspace driver for

Re: [PATCH 2/3] sched/fair: Introduce scaled capacity awareness in select_idle_sibling code path

2017-09-28 Thread Rohit Jain
Hi Joel, On 09/28/2017 05:53 AM, joelaf wrote: Hi Rohit, On Tue, Sep 26, 2017 at 12:48 PM, Rohit Jain wrote: [...] } - if (idle) - return core; + if (idle) { + if (rcpu == -1) +

Re: [PATCH v2 2/3] ARM: dts: sun8i: Add board dts file for Banana Pi M2 Ultra

2017-09-28 Thread Maxime Ripard
On Thu, Sep 28, 2017 at 09:25:42AM +, Icenowy Zheng wrote: > +&mmc2 { > + vmmc-supply = <®_dcdc1>; > + bus-width = <8>; > + non-removable; > + status = "okay"; > +}; I guess it's an emmc, it doesn't have a vqmmmc regulator? Looks good otherwise, thanks! Maxime -- Maxime Ripa

Re: [PATCH v2 1/3] ARM: dts: sun8i: Add basic dtsi file for Allwinner R40

2017-09-28 Thread Maxime Ripard
Hi, On Thu, Sep 28, 2017 at 09:25:41AM +, Icenowy Zheng wrote: > + /* > + * The max-frequency properties in all MMC controller nodes > + * are conservative values proven to work on Banana Pi M2 > + * Ultra (the first community available R40 bo

Re: [PATCH V3] r8152: add Linksys USB3GIGV1 id

2017-09-28 Thread Doug Anderson
Hi, On Wed, Sep 27, 2017 at 5:07 PM, Grant Grundler wrote: >>> #define DELL_VENDOR_ID 0x413C >>> #define REALTEK_VENDOR_ID 0x0bda >>> #define SAMSUNG_VENDOR_ID 0x04e8 >>> +#define LINKSYS_VENDOR_ID 0x13b1 >>> #define LENOVO_VENDOR_ID 0x17ef >> >> Slight nit that "

Re: linux-next: Signed-off-by missing for commit in the gpio tree

2017-09-28 Thread Nik Nyby
On 09/27/2017 06:47 PM, Linus Walleij wrote: On Wed, Sep 27, 2017 at 11:37 PM, Stephen Rothwell wrote: Hi Linus, Commit 937a0df4f4ea ("gpio: amd8111 Kconfig typo fix (trivial)") is missing a Signed-off-by from its author. OMG! How could I miss that. The patch is so trivial that I jus

Re: [lkp-robot] [selftests] 26e500fe62: kernel_selftests.mqueue.mq_open_tests.fail

2017-09-28 Thread Shuah Khan
On 09/28/2017 01:58 AM, kernel test robot wrote: > > FYI, we noticed the following commit: > > commit: 26e500fe628e28f2e93d397014beeb9c213d91e9 ("selftests: mqueue: Use > full path to run tests from Makefile") > https://git.kernel.org/cgit/linux/kernel/git/shuah/linux-kselftest.git fixes > > in

[PATCH] [IA64] sn: make sn_screen_info const, static and __initconst

2017-09-28 Thread Bhumika Goyal
Make this structure static as it is only used in the file in which it is defined. Make it const as it is only used during a copy operation. Make it __initconst as this usage is during the init phase. Structure found using Coccinelle and changes done by hand. Signed-off-by: Bhumika Goyal --- arc

Re: [PATCH] Documentation: fix little inconsistencies

2017-09-28 Thread Jonathan Corbet
On Sat, 16 Sep 2017 13:48:37 +0200 Pavel Machek wrote: > Fix little inconsistencies in Documentation: make case and spacing > match surrounding text. Applied to the docs tree, thanks. jon

Re: [PATCH 09/10] scripts: kernel-doc: parse next structs/unions

2017-09-28 Thread Jonathan Corbet
On Tue, 26 Sep 2017 17:29:47 -0300 Mauro Carvalho Chehab wrote: > This patch actually need a fixup, in order to handle pointer, > array and bitmask IDs. Can you send a new series with the fixed patch? I sure do like the shrinking of kernel-doc that comes with this series! Thanks, jon

Re: [PATCH] Documentation: kernel-api: drop "Data Types" section

2017-09-28 Thread Jonathan Corbet
On Sun, 17 Sep 2017 15:19:10 -0700 Randy Dunlap wrote: > In the kernel-api chapter, the section for Data Types only > contains "Doubly Linked Lists" and all of the function interfaces > for list management. There are no other data types in this section, > so collapse this section into "List Mana

Re: [PATCH] docs: clean up and add rest of CRC functions to kernel-api.rst

2017-09-28 Thread Jonathan Corbet
On Fri, 8 Sep 2017 16:35:55 -0700 Randy Dunlap wrote: > Add the rest of the CRC library functions to kernel-api. > > - try to clarify crc32() by adding '@' to a function parameter > - reorder kernel-api CRC functions to be less random > - add more CRC functions to kernel-api > - correct the func

Re: [lkp-robot] [selftests] 26e500fe62: kernel_selftests.mqueue.mq_open_tests.fail

2017-09-28 Thread Shuah Khan
On 09/28/2017 09:15 AM, Shuah Khan wrote: > On 09/28/2017 01:58 AM, kernel test robot wrote: >> >> FYI, we noticed the following commit: >> >> commit: 26e500fe628e28f2e93d397014beeb9c213d91e9 ("selftests: mqueue: Use >> full path to run tests from Makefile") >> https://git.kernel.org/cgit/linux/ke

Re: [PATCH] Documentation: kernel-api: add bitmap operations from linux/bitmap.h

2017-09-28 Thread Jonathan Corbet
On Sun, 17 Sep 2017 19:07:10 -0700 Randy Dunlap wrote: > Add to kernel-api Bitmap Operations section. > Fix kernel-doc nitpicks in . Applied, thanks. jon

Re: [PATCH] docs: highres: fix broken urls

2017-09-28 Thread Jonathan Corbet
On Tue, 29 Aug 2017 10:42:24 +0800 stephen lu wrote: > Some urls is invalid. I find alternative urls. > > Signed-off-by: stephen lu > --- > Documentation/timers/highres.txt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) I have, rather belatedly, applied this; working URLs are bet

Re: [PATCH RFC 3/5] Add KSZ8795 switch driver

2017-09-28 Thread Pavel Machek
> > > > Similar code will be needed by other drivers, right? > > > > > > Although KSZ8795 and KSZ8895 may use the same code, the other > > > chips will have different code. > > > > Ok, please make sure code is shared between these two. > > The exact function probably cannot be shared between KSZ8

Re: [PATCH RFC 0/6] Modify KSZ9477 DSA driver in preparation to add other KSZ switch drivers.

2017-09-28 Thread Pavel Machek
Hi! > > > drivers/net/dsa/microchip/Makefile |2 +- > > > drivers/net/dsa/microchip/ksz9477.c| 1317 > > > > > > We already have ksz_9477_reg.h. So should this be ksz_9477.c for > > consistency? > > The product name is KSZ9477 and other switches are a

Re: [PATCH 02/12] buffer: grow_dev_page() should use __GFP_NOFAIL for all cases

2017-09-28 Thread Nikolay Borisov
On 27.09.2017 23:13, Jens Axboe wrote: > We currently it it for find_or_create_page(), which means that it nit: Perhaps you wanted to write "We currently use it for find_..." otherwise: Reviewed-by: Nikolay Borisov > cannot fail. Ensure we also pass in 'retry == true' to > alloc_page_buffers

Re: [PATCH v4 00/11] dmaengine: sun6i: Fixes for H3/A83T, enable A64

2017-09-28 Thread Maxime Ripard
On Thu, Sep 28, 2017 at 01:49:17AM +, Stefan Brüns wrote: > Commit 3a03ea763a67 ("dmaengine: sun6i: Add support for Allwinner A83T > (sun8i) variant") and commit f008db8c00c1 ("dmaengine: sun6i: Add support for > Allwinner H3 (sun8i) variant") added support for the A83T resp. H3, but missed > s

Re: [PATCH 01/12] buffer: have alloc_page_buffers() use __GFP_NOFAIL

2017-09-28 Thread Nikolay Borisov
On 27.09.2017 23:13, Jens Axboe wrote: > Instead of adding weird retry logic in that function, utilize > __GFP_NOFAIL to ensure that the vm takes care of handling any > potential retries appropriately. This means we don't have to > call free_more_memory() from here. > > Signed-off-by: Jens Axboe

Re: [PATCH v4 for 4.14 1/3] membarrier: Provide register expedited private command

2017-09-28 Thread Mathieu Desnoyers
- On Sep 28, 2017, at 11:01 AM, Nicholas Piggin npig...@gmail.com wrote: > On Thu, 28 Sep 2017 13:31:36 + (UTC) > Mathieu Desnoyers wrote: > >> - On Sep 27, 2017, at 9:04 AM, Nicholas Piggin npig...@gmail.com wrote: >> >> > On Tue, 26 Sep 2017 20:43:28 + (UTC) >> > Mathieu Desno

[PATCH net-next RFC 1/9] net: dsa: mv88e6xxx: add accessors for PTP/TAI registers

2017-09-28 Thread Brandon Streiff
This patch implements support for accessing PTP/TAI registers through the AVB register interface in the Global 2 register. The register interface differs slightly between different models; older models use a 3-bit operations field, while newer models use a 2-bit field. The operations values and th

[PATCH net-next RFC 9/9] net: dsa: mv88e6xxx: add workaround for 6341 timestamping

2017-09-28 Thread Brandon Streiff
88E6341 devices default to timestamping at the PHY, but due to a hardware issue, timestamps via this component are unreliable. For this family, configure the PTP hardware to force the timestamping to occur at the MAC. Signed-off-by: Brandon Streiff --- drivers/net/dsa/mv88e6xxx/hwtstamp.c | 13 +

[PATCH net-next RFC 3/9] net: dsa: mv88e6xxx: add support for GPIO configuration

2017-09-28 Thread Brandon Streiff
The Scratch/Misc register is a windowed interface that provides access to the GPIO configuration. Provide a new method for configuration of GPIO functions. Signed-off-by: Brandon Streiff --- drivers/net/dsa/mv88e6xxx/chip.c| 13 +++ drivers/net/dsa/mv88e6xxx/chip.h| 8 + drivers

[PATCH net-next RFC 6/9] net: dsa: forward timestamping callbacks to switch drivers

2017-09-28 Thread Brandon Streiff
Forward the rx/tx timestamp machinery from the dsa infrastructure to the switch driver. On the rx side, defer delivery of skbs until we have an rx timestamp. This mimicks the behavior of skb_defer_rx_timestamp. The implementation does have to thread through the tagging protocol handlers because it

[PATCH net-next RFC 4/9] net: dsa: mv88e6xxx: add support for event capture

2017-09-28 Thread Brandon Streiff
This patch adds support for configuring mv88e6xxx GPIO lines as PTP pins, so that they may be used for time stamping external events or for periodic output. Signed-off-by: Brandon Streiff --- drivers/net/dsa/mv88e6xxx/chip.h | 4 + drivers/net/dsa/mv88e6xxx/ptp.c | 317 +++

[PATCH net-next RFC 5/9] net: dsa: forward hardware timestamping ioctls to switch driver

2017-09-28 Thread Brandon Streiff
This patch adds support to the dsa slave network device so that switch drivers can implement the SIOC[GS]HWTSTAMP ioctls and the ethtool timestamp-info interface. Signed-off-by: Brandon Streiff --- include/net/dsa.h | 15 +++ net/dsa/slave.c | 39 +++

[PATCH net-next RFC 7/9] ptp: add offset for reserved field to header

2017-09-28 Thread Brandon Streiff
There is a four-byte "reserved" field at octet 16 in PTPv2. Signed-off-by: Brandon Streiff --- include/linux/ptp_classify.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/ptp_classify.h b/include/linux/ptp_classify.h index a079656..b9b0073 100644 --- a/include/linux/ptp_classi

[PATCH net-next RFC 2/9] net: dsa: mv88e6xxx: expose switch time as a PTP hardware clock

2017-09-28 Thread Brandon Streiff
This patch adds basic support for exposing the 32-bit timestamp counter inside the mv88e6xxx switch code as a ptp_clock. Signed-off-by: Brandon Streiff --- drivers/net/dsa/mv88e6xxx/Kconfig | 10 +++ drivers/net/dsa/mv88e6xxx/Makefile | 1 + drivers/net/dsa/mv88e6xxx/chip.c | 20 + dr

[PATCH net-next RFC 0/9] net: dsa: PTP timestamping for mv88e6xxx

2017-09-28 Thread Brandon Streiff
This patch series adds support for PTP timestamping through the DSA framework, as well as an implementation for mv8e6xxx switches. This implementation was targeted at a National Instruments platform that uses the Marvell 88E6341 (Topaz). I've tried to enable support on other Marvell switches where

Re: [PATCH 03/12] buffer: eliminate the need to call free_more_memory() in __getblk_slow()

2017-09-28 Thread Nikolay Borisov
On 27.09.2017 23:13, Jens Axboe wrote: > Since the previous commit removed any case where grow_buffers() > would return failure due to memory allocations, we can safely > remove the case where we have to call free_more_memory() in > this function. > > Since this is also the last user of free_mor

[PATCH net-next RFC 8/9] net: dsa: mv88e6xxx: add rx/tx timestamping support

2017-09-28 Thread Brandon Streiff
This patch implements RX/TX timestamping support. The Marvell PTP hardware supports RX timestamping individual message types, but for simplicity we only support the EVENT receive filter since few if any clients bother with the more specific filter types. We also utilize a feature of the "generati

[PATCH v5 4/4] ARM: configs: stm32: Add MDMA support in STM32 defconfig

2017-09-28 Thread Pierre-Yves MORDRET
This patch adds MDMA support in STM32 defconfig file Signed-off-by: Pierre-Yves MORDRET --- Version history: v5: v4: v3: * None v2: * Add MDMA support in STM32 defconfig --- --- arch/arm/configs/stm32_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/

[PATCH v5 1/4] dt-bindings: Document the STM32 MDMA bindings

2017-09-28 Thread Pierre-Yves MORDRET
This patch adds documentation of device tree bindings for the STM32 MDMA controller. Signed-off-by: M'boumba Cedric Madianga Signed-off-by: Pierre-Yves MORDRET Acked-by: Rob Herring --- Version history: v5: v4: v3: * None v2: * change compatible into st,s

[PATCH v5 3/4] ARM: dts: stm32: Add MDMA support for STM32H743 SoC

2017-09-28 Thread Pierre-Yves MORDRET
This patch adds MDMA support for STM32H743 SoC. Signed-off-by: Pierre-Yves MORDRET --- Version history: v5: v4: v3: * None v2: * Add MDMA support in DT for H7 --- --- arch/arm/boot/dts/stm32h743.dtsi | 10 ++ 1 file changed, 10 insertions(+) diff --git a

[PATCH v5 2/4] dmaengine: Add STM32 MDMA driver

2017-09-28 Thread Pierre-Yves MORDRET
This patch adds the driver for the STM32 MDMA controller. Master Direct memory access (MDMA) is used in order to provide high-speed data transfer between memory and memory or between peripherals and memory. MDMA controller provides a master AXI interface for main memory and peripheral registers a

[PATCH v5 0/4] Add STM32 MDMA driver

2017-09-28 Thread Pierre-Yves MORDRET
This patchset adds support for the STM32 MDMA controller. The Master Direct memory access (MDMA) provides high-speed data transfer between memory and memory or between peripherals and memory. Contrary to STM32 DMA, the STM32 MDMA controller supports hardware LLI and uses a larger integrated FIFO (1

Re: [PATCH v2 2/3] ARM: dts: sun8i: Add board dts file for Banana Pi M2 Ultra

2017-09-28 Thread Icenowy Zheng
于 2017年9月28日 GMT+08:00 下午11:12:25, Maxime Ripard 写到: >On Thu, Sep 28, 2017 at 09:25:42AM +, Icenowy Zheng wrote: >> +&mmc2 { >> +vmmc-supply = <®_dcdc1>; >> +bus-width = <8>; >> +non-removable; >> +status = "okay"; >> +}; > >I guess it's an emmc, it doesn't have a vqmmmc reg

Re: [PATCH v3 tip/core/rcu 40/40] rcu: Make non-preemptive schedule be Tasks RCU quiescent state

2017-09-28 Thread Levin, Alexander (Sasha Levin)
On Thu, Sep 28, 2017 at 05:30:55AM -0700, Paul E. McKenney wrote: >On Thu, Sep 28, 2017 at 02:37:20AM -0700, Sasha Levin wrote: >> On Wed, Apr 19, 2017 at 9:58 AM, Paul E. McKenney >> wrote: >> > Currently, a call to schedule() acts as a Tasks RCU quiescent state >> > only if a context switch actu

[PATCH net] net: mvpp2: Fix clock resource by adding an optional bus clock

2017-09-28 Thread Gregory CLEMENT
On Armada 7K/8K we need to explicitly enable the bus clock. The bus clock is optional because not all the SoCs need them but at least for Armada 7K/8K it is actually mandatory. The binding documentation is updating accordingly. Signed-off-by: Gregory CLEMENT --- Documentation/devicetree/binding

[PATCH v2 2/3] params: Fix an overflow in param_attr_show

2017-09-28 Thread Jean Delvare
Function param_attr_show could overflow the buffer it is operating on. The buffer size is PAGE_SIZE, and the string returned by attribute->param->ops->get is generated by scnprintf(buffer, PAGE_SIZE, ...) so it could be PAGE_SIZE - 1 long, with the terminating '\0' at the very end of the buffer. Ca

Re: [PATCH 2/3] early_printk: Add force_early_printk kernel parameter

2017-09-28 Thread Randy Dunlap
On 09/28/17 05:18, Peter Zijlstra wrote: Hi Peter, Please add that kernel parameter to Documentation/admin-guide/kernel-parameters.txt. thanks, -- ~Randy

[PATCH v2 0/3] params: Fix potential buffer overflows

2017-09-28 Thread Jean Delvare
[PATCH 1/3] params: Fix the maximum length in param_get_string [PATCH 2/3] params: Fix an overflow in param_attr_show [PATCH 3/3] params: Improve STANDARD_PARAM_DEF readability -- Jean Delvare SUSE L3 Support

Re: [PATCH v3] tun: bail out from tun_get_user() if the skb is empty

2017-09-28 Thread David Miller
From: Alexander Potapenko Date: Thu, 28 Sep 2017 11:32:37 +0200 > KMSAN (https://github.com/google/kmsan) reported accessing uninitialized > skb->data[0] in the case the skb is empty (i.e. skb->len is 0): ... > Make sure tun_get_user() doesn't touch skb->data[0] unless there is > actual data. .

[PATCH v2 1/3] params: Fix the maximum length in param_get_string

2017-09-28 Thread Jean Delvare
The length parameter of strlcpy() is supposed to reflect the size of the target buffer, not of the source string. Harmless in this case as the buffer is PAGE_SIZE long and the source string is always much shorter than this, but conceptually wrong, so let's fix it. Signed-off-by: Jean Delvare ---

Re: [RFC PATCH 1/2] arm64: mm: Use READ_ONCE/WRITE_ONCE when accessing page tables

2017-09-28 Thread Paul E. McKenney
On Thu, Sep 28, 2017 at 09:45:35AM +0100, Will Deacon wrote: > On Thu, Sep 28, 2017 at 10:38:01AM +0200, Peter Zijlstra wrote: > > On Wed, Sep 27, 2017 at 04:49:28PM +0100, Will Deacon wrote: > > > In many cases, page tables can be accessed concurrently by either another > > > CPU (due to things li

[PATCH v2 3/3] params: Improve STANDARD_PARAM_DEF readability

2017-09-28 Thread Jean Delvare
Align the parameters passed to STANDARD_PARAM_DEF for clarity. Suggested-by: Ingo Molnar Signed-off-by: Jean Delvare --- Changes since v1: * Patch added kernel/params.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) --- linux-4.13.orig/kernel/params.c 2017-09-28

Re: [PATCH net] net: mvpp2: Fix clock resource by adding an optional bus clock

2017-09-28 Thread Thomas Petazzoni
Hello, On Thu, 28 Sep 2017 17:39:23 +0200, Gregory CLEMENT wrote: > diff --git a/Documentation/devicetree/bindings/net/marvell-pp2.txt > b/Documentation/devicetree/bindings/net/marvell-pp2.txt > index 7e2dad08a12e..49e1be6bb6ba 100644 > --- a/Documentation/devicetree/bindings/net/marvell-pp2.txt

Re: [RFC PATCH 1/2] arm64: mm: Use READ_ONCE/WRITE_ONCE when accessing page tables

2017-09-28 Thread Will Deacon
On Thu, Sep 28, 2017 at 08:43:54AM -0700, Paul E. McKenney wrote: > On Thu, Sep 28, 2017 at 09:45:35AM +0100, Will Deacon wrote: > > On Thu, Sep 28, 2017 at 10:38:01AM +0200, Peter Zijlstra wrote: > > > On Wed, Sep 27, 2017 at 04:49:28PM +0100, Will Deacon wrote: > > > > In many cases, page tables

Re: [RFC PATCH 1/3] fs: define new read_iter rwf flag

2017-09-28 Thread Linus Torvalds
On Thu, Sep 28, 2017 at 6:54 AM, Matthew Wilcox wrote: > > I don't like adding a bool parameter everywhere. Why not add a flag > to the kiocb ki_flags? > > #define IOCB_RWSEM_HELD (1 << 8) Yeah, I think that would be a nicer approach, with filesystems that don't care being able to just i

Re: [PATCH v4 for 4.14 1/3] membarrier: Provide register expedited private command

2017-09-28 Thread Peter Zijlstra
On Fri, Sep 29, 2017 at 01:01:12AM +1000, Nicholas Piggin wrote: > That's fine. If a user is not bound to a subset of CPUs, they could > also cause disturbances with other syscalls and faults, taking locks, > causing tlb flushes and IPIs and things. So on the big SGI class machines we've had troub

Re: [PATCH net] net: mvpp2: Fix clock resource by adding an optional bus clock

2017-09-28 Thread Gregory CLEMENT
Hi Thomas, On jeu., sept. 28 2017, Thomas Petazzoni wrote: >> /* List of pointers to port structures */ >> struct mvpp2_port **port_list; >> @@ -7963,6 +7964,16 @@ static int mvpp2_probe(struct platform_device *pdev) >> err = clk_prepare_enable(priv->mg_clk); >>

Re: [PATCH] uio/uio_pci_generic: Add SR-IOV support

2017-09-28 Thread David Woodhouse
On Thu, 2017-09-28 at 11:05 -0400, Don Dutile wrote: > ah, nickel summary: no in-kernel driver w/.sriov-configure method. > if so, now I'm up to speed with you > h > so, that would imply we need an in-kernel, pcie-common, .sriov- > configure method > that's invoked if a driver isn't bou

Re: [RFC 1/3] PCI: pci-driver: Introduce pci device delete list

2017-09-28 Thread Jon Derrick
Hi Greg, On 09/28/2017 03:09 AM, Greg Kroah-Hartman wrote: > On Wed, Sep 27, 2017 at 04:40:20PM -0400, Jon Derrick wrote: >> This patch introduces a new kernel command line parameter to mask pci >> device ids from pci driver id tables. This prevents masked devices from >> automatically binding to

Re: [PATCH v2 0/3] params: Fix potential buffer overflows

2017-09-28 Thread Ingo Molnar
* Jean Delvare wrote: > [PATCH 1/3] params: Fix the maximum length in param_get_string > [PATCH 2/3] params: Fix an overflow in param_attr_show > [PATCH 3/3] params: Improve STANDARD_PARAM_DEF readability It all looks sensible to me, so FWIIW: Acked-by: Ingo Molnar (but I have not tested i

Re: [RFC 2/3] module: Ignore delete_id parameter

2017-09-28 Thread Jon Derrick
On 09/28/2017 03:02 AM, Greg Kroah-Hartman wrote: > On Wed, Sep 27, 2017 at 04:40:21PM -0400, Jon Derrick wrote: >> The PCI driver delete_id parameter is handled in each individual driver >> registration callback. >> >> Signed-off-by: Jon Derrick >> --- >> kernel/module.c | 7 +++ >> 1 file c

Re: [RFC 2/3] module: Ignore delete_id parameter

2017-09-28 Thread Jon Derrick
On 09/28/2017 12:03 AM, Dan Williams wrote: > On Wed, Sep 27, 2017 at 1:40 PM, Jon Derrick > wrote: >> The PCI driver delete_id parameter is handled in each individual driver >> registration callback. >> >> Signed-off-by: Jon Derrick >> --- >> kernel/module.c | 7 +++ >> 1 file changed, 7 i

Re: [RFC 1/3] PCI: pci-driver: Introduce pci device delete list

2017-09-28 Thread Dan Williams
On Thu, Sep 28, 2017 at 2:09 AM, Greg Kroah-Hartman wrote: > On Wed, Sep 27, 2017 at 04:40:20PM -0400, Jon Derrick wrote: >> This patch introduces a new kernel command line parameter to mask pci >> device ids from pci driver id tables. This prevents masked devices from >> automatically binding to

Re: Detecting page cache trashing state

2017-09-28 Thread Ruslan Ruslichenko -X (rruslich - GLOBALLOGIC INC at Cisco)
Hi Johannes, Hopefully I was able to rebase the patch on top v4.9.26 (latest supported version by us right now) and test a bit. The overall idea definitely looks promising, although I have one question on usage. Will it be able to account the time which processes spend on handling major page

[PATCH] KVM: VMX: use cmpxchg64

2017-09-28 Thread Paolo Bonzini
This fixes a compilation failure on 32-bit systems. Signed-off-by: Paolo Bonzini --- arch/x86/kvm/vmx.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c index b9d2140eb212..7f62c94196d1 100644 --- a/arch/x86/kvm/vmx.c +++ b/

Re: [PATCH] params: Fix an overflow in param_attr_show

2017-09-28 Thread Jean Delvare
On Thu, 28 Sep 2017 10:38:27 +0200, Ingo Molnar wrote: > * Jean Delvare wrote: > > Or... I could append the \n inside the STANDARD_PARAM_DEF macro, so the > > calls are unchanged. Makes my patch smaller, and addresses your concern > > just as well, I suppose. > > Yeah, that would be even better

Re: DMA error when sg->offset value is greater than PAGE_SIZE in Intel IOMMU

2017-09-28 Thread Raj, Ashok
Thanks for trying that Harsh. sp_off turns of super page support. Which this mode, do you still see offsets greater than 4k? On Thu, Sep 28, 2017 at 07:08:21PM +0530, Harsh Jain wrote: > > > Today I tried with "Intel_iommu=sp_off" boot option. Traffic runs without any > error for more than 1

Re: [PATCH 1/3] srcu: use cpu_online() instead custom check

2017-09-28 Thread Sebastian Andrzej Siewior
On 2017-09-22 11:43:14 [-0700], Paul E. McKenney wrote: > On Fri, Sep 22, 2017 at 05:28:04PM +0200, Sebastian Andrzej Siewior wrote: > > The current check via srcu_online is slightly racy because after looking > > at srcu_online there could be an interrupt that interrupted us long > > enough until

Re: [PATCH 0/3] printk: Add force_early_printk boot param

2017-09-28 Thread Sergey Senozhatsky
On (09/28/17 14:18), Peter Zijlstra wrote: > Most all printk() bits are terminally broken because they rely on the > scheduler > and blocking locks to function, making them unsuitable for debugging the > scheduler and NMI context things. hold on... wait a second... the scheduler is not lockless y

Re: [PATCH 2/3] srcu: queue work without holding the lock

2017-09-28 Thread Sebastian Andrzej Siewior
On 2017-09-22 11:46:10 [-0700], Paul E. McKenney wrote: > On Fri, Sep 22, 2017 at 05:28:05PM +0200, Sebastian Andrzej Siewior wrote: > > On RT we can't invoke queue_delayed_work() within an atomic section > > (which is provided by raw_spin_lock_irqsave()). > > srcu_reschedule() invokes queue_delaye

Re: [PATCH 1/2] clk/ux500: Delete an error message for a failed memory allocation in three functions

2017-09-28 Thread Ulf Hansson
On 27 September 2017 at 20:46, SF Markus Elfring wrote: > From: Markus Elfring > Date: Wed, 27 Sep 2017 20:23:58 +0200 > > Omit extra messages for a memory allocation failure in these functions. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring Acke

Re: [PATCH 2/2] clk/ux500: Improve a size determination in three functions

2017-09-28 Thread Ulf Hansson
On 27 September 2017 at 20:47, SF Markus Elfring wrote: > From: Markus Elfring > Date: Wed, 27 Sep 2017 20:30:53 +0200 > > Replace the specification of data structures by pointer dereferences > as the parameter for the operator "sizeof" to make the corresponding size > determination a bit safer a

Re: [PATCH v3 tip/core/rcu 40/40] rcu: Make non-preemptive schedule be Tasks RCU quiescent state

2017-09-28 Thread Paul E. McKenney
On Thu, Sep 28, 2017 at 03:38:16PM +, Levin, Alexander (Sasha Levin) wrote: > On Thu, Sep 28, 2017 at 05:30:55AM -0700, Paul E. McKenney wrote: > >On Thu, Sep 28, 2017 at 02:37:20AM -0700, Sasha Levin wrote: > >> On Wed, Apr 19, 2017 at 9:58 AM, Paul E. McKenney > >> wrote: > >> > Currently, a

Re: intel-dmar: possible circular locking dependency detected

2017-09-28 Thread Joerg Roedel
Hey Jan, On Wed, Sep 27, 2017 at 04:19:15PM +0200, Jan Kiszka wrote: > On 2017-09-27 15:21, Jan Kiszka wrote: > > On 2017-09-27 14:14, Jan Kiszka wrote: > >> while I'm triggering this with a still out-of-tree module from the > >> Jailhouse project, the potential deadlock appears to me being unrela

Re: [PATCH 2/3] early_printk: Add force_early_printk kernel parameter

2017-09-28 Thread Peter Zijlstra
On Thu, Sep 28, 2017 at 08:41:37AM -0700, Randy Dunlap wrote: > Please add that kernel parameter to > Documentation/admin-guide/kernel-parameters.txt. Something like so? --- a/Documentation/admin-guide/kernel-parameters.txt +++ b/Documentation/admin-guide/kernel-parameters.txt @@ -1165,6 +1165,

Re: [RFC PATCH 1/2] arm64: mm: Use READ_ONCE/WRITE_ONCE when accessing page tables

2017-09-28 Thread Paul E. McKenney
On Thu, Sep 28, 2017 at 04:49:54PM +0100, Will Deacon wrote: > On Thu, Sep 28, 2017 at 08:43:54AM -0700, Paul E. McKenney wrote: > > On Thu, Sep 28, 2017 at 09:45:35AM +0100, Will Deacon wrote: > > > On Thu, Sep 28, 2017 at 10:38:01AM +0200, Peter Zijlstra wrote: > > > > On Wed, Sep 27, 2017 at 04:

Re: [PATCH v3 tip/core/rcu 40/40] rcu: Make non-preemptive schedule be Tasks RCU quiescent state

2017-09-28 Thread Peter Zijlstra
On Thu, Sep 28, 2017 at 03:38:16PM +, Levin, Alexander (Sasha Levin) wrote: > On Thu, Sep 28, 2017 at 05:30:55AM -0700, Paul E. McKenney wrote: > >Hmmm... kernel/rcu/tree_plugin.h:329 thinks that someone slept (as opposed > >to was preempted) in an RCU read-side critical section. Sasha, was

Re: [PATCH net-next 0/3] support changing steering policies in tuntap

2017-09-28 Thread Willem de Bruijn
On Thu, Sep 28, 2017 at 3:23 AM, Jason Wang wrote: > > > On 2017年09月28日 07:25, Willem de Bruijn wrote: In the future, both simple and sophisticated policy like RSS or other guest driven steering policies could be done on top. >>> >>> IMHO there should be a more practical exampl

Re: [PATCH 1/4] pci: introduce __pci_walk_bus for caller with pci_bus_sem held

2017-09-28 Thread Sinan Kaya
On 9/27/2017 5:42 PM, Govindarajulu Varadarajan wrote: > +void __pci_walk_bus(struct pci_bus *top, int (*cb)(struct pci_dev *, void *), > + void *userdata); pci_walk_bus_locked would be a better name as you are assuming that caller is holding the lock. -- Sinan Kaya Qualcomm Dat

Re: [PATCH for-next 8/9] RDMA/hns: Remove unused struct members in hns-abi.h

2017-09-28 Thread Wei Hu (Xavier)
On 2017/9/28 21:04, Leon Romanovsky wrote: On Thu, Sep 28, 2017 at 07:56:40PM +0800, Wei Hu (Xavier) wrote: On 2017/9/28 17:02, Leon Romanovsky wrote: On Thu, Sep 28, 2017 at 12:57:33PM +0800, Wei Hu (Xavier) wrote: From: Lijun Ou This patch mainly deletes some unused struct members for h

Re: [PATCH v4 for 4.14 1/3] membarrier: Provide register expedited private command

2017-09-28 Thread Nicholas Piggin
On Thu, 28 Sep 2017 15:29:50 + (UTC) Mathieu Desnoyers wrote: > - On Sep 28, 2017, at 11:01 AM, Nicholas Piggin npig...@gmail.com wrote: > > > On Thu, 28 Sep 2017 13:31:36 + (UTC) > > Mathieu Desnoyers wrote: > > > >> - On Sep 27, 2017, at 9:04 AM, Nicholas Piggin npig...@gma

Re: [PATCH 0/3] printk: Add force_early_printk boot param

2017-09-28 Thread Peter Zijlstra
On Fri, Sep 29, 2017 at 01:02:30AM +0900, Sergey Senozhatsky wrote: > but what's up with that scheduler thing I keep hearing about, must be > something new, can I disable it in kconfig? it seems to be conflicting > with CONFIG_PRINTK. Its not new, its been there for a very long time :-) The probl

Re: [PATCH v1 4/5] dmaengine: Add driver for NVIDIA Tegra AHB DMA controller

2017-09-28 Thread Vinod Koul
On Thu, Sep 28, 2017 at 05:06:03PM +0300, Dmitry Osipenko wrote: > On 28.09.2017 12:29, Vinod Koul wrote: > >> + default: > >> + return -EINVAL; > >> + } > >> + > >> + ahb_seq = burst << TEGRA_AHBDMA_CHANNEL_AHB_BURST_SHIFT; > >> + ahb_seq |= TEGRA_AHBDMA_CHANNEL_ADDR_WRAP; > >> + ah

Re: [PATCH] iommu/vt-d: Fix scatterlist offset handling

2017-09-28 Thread Casey Leedom
Thanks Robin. Harsh can certainly test your latest patch as soon as he's back in the office tomorrow morning India time. If your patch works and is accepted, it sounds like the commit would be important enough to consider backporting into various Long-Term Support releases and the affected dist

Re: [PATCH v3 tip/core/rcu 40/40] rcu: Make non-preemptive schedule be Tasks RCU quiescent state

2017-09-28 Thread Peter Zijlstra
On Thu, Sep 28, 2017 at 09:05:14AM -0700, Paul E. McKenney wrote: > > do_async_page_fault+0x72/0x90 arch/x86/kernel/kvm.c:271 > > async_page_fault+0x22/0x30 arch/x86/entry/entry_64.S:1069 > > RIP: 0010:format_decode+0x240/0x830 lib/vsprintf.c:1996 > > RSP: 0018:88003b2df520 EFLAGS: 00010283 >

Re: [PATCH v1 4/5] dmaengine: Add driver for NVIDIA Tegra AHB DMA controller

2017-09-28 Thread Vinod Koul
On Thu, Sep 28, 2017 at 05:35:59PM +0300, Dmitry Osipenko wrote: > On 28.09.2017 17:06, Dmitry Osipenko wrote: > > On 28.09.2017 12:29, Vinod Koul wrote: > >>> + default: > >>> + return -EINVAL; > >>> + } > >>> + > >>> + ahb_seq = burst << TEGRA_AHBDMA_CHANNEL_AHB_BURST_SHIFT; > >>> + ahb_

Re: [lkp-robot] [x86/asm] f5caf621ee: PANIC:double_fault

2017-09-28 Thread Linus Torvalds
On Thu, Sep 28, 2017 at 12:47 AM, kernel test robot wrote: > > [ 10.587519] RIP: 0010:compat_sock_ioctl+0xfea/0x103e > [ 10.587974] RSP: :00277d78 EFLAGS: 00010283 > [ 10.588448] RAX: 00277d78 RBX: 8933 RCX: > 8800141a8000 > [ 10.589103] RDX: 00

[Part1 PATCH v5.1 05/17] x86/mm: Use encrypted access of boot related data with SEV

2017-09-28 Thread Brijesh Singh
From: Tom Lendacky When Secure Encrypted Virtualization (SEV) is active, boot data (such as EFI related data, setup data) is encrypted and needs to be accessed as such when mapped. Update the architecture override in early_memremap to keep the encryption attribute when mapping this data. Cc: Tho

Re: [Part1 PATCH v5 10/17] x86/mm, resource: Use PAGE_KERNEL protection for ioremap of memory pages

2017-09-28 Thread Borislav Petkov
On Wed, Sep 27, 2017 at 10:13:22AM -0500, Brijesh Singh wrote: > From: Tom Lendacky > > In order for memory pages to be properly mapped when SEV is active, we > need to use the PAGE_KERNEL protection attribute as the base protection. > This will insure that memory mapping of, e.g. ACPI tables, re

Re: dm-crypt: Fix memory leak in crypt_ctr_cipher_old()

2017-09-28 Thread Mike Snitzer
On Wed, Sep 27 2017 at 8:28am -0400, Jeffy Chen wrote: > Fix memory leak of cipher_api. > > Fixes: 33d2f09fcb35 (dm crypt: introduce new format of cipher with "capi:" > prefix) > Signed-off-by: Jeffy Chen Thanks, I've picked this up and it'll go upstream in my next pull request for 4.14-rc

Re: [PATCH] iommu/vt-d: Fix scatterlist offset handling

2017-09-28 Thread Raj, Ashok
Hi Casey On Thu, Sep 28, 2017 at 04:17:59PM +, Casey Leedom wrote: > Thanks Robin. Harsh can certainly test your latest patch as soon as he's > back in the office tomorrow morning India time. If your patch works and is > accepted, it sounds like the commit would be important enough to cons

Re: [PATCH v3 tip/core/rcu 40/40] rcu: Make non-preemptive schedule be Tasks RCU quiescent state

2017-09-28 Thread Levin, Alexander (Sasha Levin)
On Thu, Sep 28, 2017 at 06:08:56PM +0200, Peter Zijlstra wrote: >On Thu, Sep 28, 2017 at 03:38:16PM +, Levin, Alexander (Sasha Levin) wrote: >> On Thu, Sep 28, 2017 at 05:30:55AM -0700, Paul E. McKenney wrote: > >> >Hmmm... kernel/rcu/tree_plugin.h:329 thinks that someone slept (as opposed >>

Re: [PATCH v4 1/2] x86/unwind: add ORC unwinder

2017-09-28 Thread Juergen Gross
On 28/09/17 15:55, Josh Poimboeuf wrote: > On Thu, Sep 28, 2017 at 08:03:26AM +0200, Juergen Gross wrote: >> On 27/09/17 23:08, Josh Poimboeuf wrote: >>> On Tue, Aug 08, 2017 at 01:09:08PM -0700, Andy Lutomirski wrote: On Tue, Aug 8, 2017 at 12:13 PM, Josh Poimboeuf wrote: > On Tue,

Re: [PATCH v4 for 4.14 1/3] membarrier: Provide register expedited private command

2017-09-28 Thread Nicholas Piggin
On Thu, 28 Sep 2017 17:51:15 +0200 Peter Zijlstra wrote: > On Fri, Sep 29, 2017 at 01:01:12AM +1000, Nicholas Piggin wrote: > > That's fine. If a user is not bound to a subset of CPUs, they could > > also cause disturbances with other syscalls and faults, taking locks, > > causing tlb flushes and

Re: [PATCH v3 tip/core/rcu 40/40] rcu: Make non-preemptive schedule be Tasks RCU quiescent state

2017-09-28 Thread Paul E. McKenney
On Thu, Sep 28, 2017 at 06:18:50PM +0200, Peter Zijlstra wrote: > On Thu, Sep 28, 2017 at 09:05:14AM -0700, Paul E. McKenney wrote: > > > do_async_page_fault+0x72/0x90 arch/x86/kernel/kvm.c:271 > > > async_page_fault+0x22/0x30 arch/x86/entry/entry_64.S:1069 > > > RIP: 0010:format_decode+0x240/0x8

Re: [PATCH net-next RFC 1/9] net: dsa: mv88e6xxx: add accessors for PTP/TAI registers

2017-09-28 Thread Vivien Didelot
Hi Brandon, Brandon Streiff writes: > + .port_ptp_read = mv88e6352_port_ptp_read, > + .port_ptp_write = mv88e6352_port_ptp_write, > + .ptp_read = mv88e6352_ptp_read, > + .ptp_write = mv88e6352_ptp_write, > + .tai_read

Re: [PATCH] isdn/eicon: do integrity check on cmd->adapter == a->controller early

2017-09-28 Thread David Miller
From: Meng Xu Date: Sun, 24 Sep 2017 11:14:41 -0400 > + /* do the integrity check early */ > + if(((diva_xdi_um_cfg_cmd_t *)data)->adapter != a->controller){ > + DBG_ERR(("A: A(%d) write, invalid controller=%d != %d", > +

Re: [PATCH net v2 0/3] net: mvpp2: various fixes

2017-09-28 Thread David Miller
From: Antoine Tenart Date: Mon, 25 Sep 2017 14:59:45 +0200 > This series contains 3 fixes for the Marvell PPv2 driver. Series applied, thanks.

Re: [PATCH v1 4/5] dmaengine: Add driver for NVIDIA Tegra AHB DMA controller

2017-09-28 Thread Dmitry Osipenko
On 28.09.2017 19:22, Vinod Koul wrote: > On Thu, Sep 28, 2017 at 05:35:59PM +0300, Dmitry Osipenko wrote: >> On 28.09.2017 17:06, Dmitry Osipenko wrote: >>> On 28.09.2017 12:29, Vinod Koul wrote: > + default: > + return -EINVAL; > + } > + > + ahb_seq = burst << TEGRA_AH

Re: [lkp-robot] [x86/asm] f5caf621ee: PANIC:double_fault

2017-09-28 Thread Josh Poimboeuf
On Thu, Sep 28, 2017 at 09:21:07AM -0700, Linus Torvalds wrote: > On Thu, Sep 28, 2017 at 12:47 AM, kernel test robot > wrote: > > > > [ 10.587519] RIP: 0010:compat_sock_ioctl+0xfea/0x103e > > [ 10.587974] RSP: :00277d78 EFLAGS: 00010283 > > [ 10.588448] RAX: 00277d78 RBX

<    1   2   3   4   5   6   7   8   >