Re: [PATCH v2] ALSA: x86: fix error return code in hdmi_lpe_audio_probe()

2017-06-30 Thread Takashi Iwai
On Fri, 30 Jun 2017 22:18:41 +0200, Gustavo A. R. Silva wrote: > > Also, > notice that platform_get_irq() no longer returns 0 on error. There is no change by your patch in this regard, right? Takashi > Print error message and propagate the return value of platform_get_irq > on failure. > > Si

Re: [PATCH v2 0/2] Add usb2 nodes on RK3328 SoCs and enable usb2 on RK3328 evb

2017-06-30 Thread Heiko Stuebner
Am Freitag, 16. Juni 2017, 18:34:13 CEST schrieb William Wu: > This series adds support for usb2 on RK3328 SoCs. > Tested on RK3328 evaluation board. > > William Wu (2): > arm64: dts: rockchip: add usb2 nodes for RK3328 SoCs > arm64: dts: rockchip: enable usb2 for RK3328 evaluation board appl

Re: [PATCH v2] ALSA: x86: fix error return code in hdmi_lpe_audio_probe()

2017-06-30 Thread Gustavo A. R. Silva
Hi Takashi, Quoting Takashi Iwai : On Fri, 30 Jun 2017 22:18:41 +0200, Gustavo A. R. Silva wrote: Also, notice that platform_get_irq() no longer returns 0 on error. There is no change by your patch in this regard, right? You are correct. I just pointing it out. This is the commit that

Re: [PATCH 3/3] livepatch: add shadow variable sample program

2017-06-30 Thread Josh Poimboeuf
On Mon, Jun 19, 2017 at 06:56:37PM +0200, Miroslav Benes wrote: > > > > > I often wonder whether it's really a good idea to even allow the > > > > unloading of patch modules at all. It adds complexity to the livepatch > > > > code. Is it worth it? I don't have an answer but I'd be interested in

Re: [PATCH] sata_rcar: fix error return code in sata_rcar_probe()

2017-06-30 Thread Gustavo A. R. Silva
Quoting Sergei Shtylyov : On 06/30/2017 10:46 PM, Gustavo A. R. Silva wrote: Print error message and propagate the return value of platform_get_irq on failure. You should have probably mentioned that this function no longer returns 0 on error. Yeah, the patches looks good to me but I'

Re: [PATCH v2 8/8] iio: counter: Add support for STM32 LPTimer

2017-06-30 Thread Benjamin Gaignard
2017-06-30 20:19 GMT+02:00 Jonathan Cameron : > On Tue, 27 Jun 2017 10:21:43 +0200 > Benjamin Gaignard wrote: > >> 2017-06-26 22:29 GMT+02:00 William Breathitt Gray : >> > On Sat, Jun 24, 2017 at 09:35:39PM +0100, Jonathan Cameron wrote: >> >>On Wed, 21 Jun 2017 16:30:15 +0200 >> >>Fabrice Gasnier

Re: [PATCH v2] ALSA: x86: fix error return code in hdmi_lpe_audio_probe()

2017-06-30 Thread Takashi Iwai
On Fri, 30 Jun 2017 22:31:32 +0200, Gustavo A. R. Silva wrote: > > Hi Takashi, > > Quoting Takashi Iwai : > > > On Fri, 30 Jun 2017 22:18:41 +0200, > > Gustavo A. R. Silva wrote: > >> > >> Also, > >> notice that platform_get_irq() no longer returns 0 on error. > > > > There is no change by your

Re: [PATCH] vmalloc: respect the GFP_NOIO and GFP_NOFS flags

2017-06-30 Thread Michal Hocko
On Fri 30-06-17 14:11:57, Mikulas Patocka wrote: > > > On Fri, 30 Jun 2017, Michal Hocko wrote: > > > On Thu 29-06-17 22:25:09, Mikulas Patocka wrote: > > > The __vmalloc function has a parameter gfp_mask with the allocation flags, > > > however it doesn't fully respect the GFP_NOIO and GFP_NOFS

Re: arm64: dts: rockchip: add SdioAudio pd control for rk3399

2017-06-30 Thread Heiko Stuebner
Hi Caesar, Am Freitag, 30. Juni 2017, 14:01:53 CEST schrieb Caesar Wang: subject was missing the "[PATCH]" prefix. While not necessary for applying, having it makes it easier to find stuff in an inbox :-) . > The SdioAudio power domain includes the i2s/spdif/spi5/sdio. > > So this patch adds t

Re: [PATCH v2] ALSA: x86: fix error return code in hdmi_lpe_audio_probe()

2017-06-30 Thread Gustavo A. R. Silva
Quoting Takashi Iwai : On Fri, 30 Jun 2017 22:31:32 +0200, Gustavo A. R. Silva wrote: Hi Takashi, Quoting Takashi Iwai : > On Fri, 30 Jun 2017 22:18:41 +0200, > Gustavo A. R. Silva wrote: >> >> Also, >> notice that platform_get_irq() no longer returns 0 on error. > > There is no change by y

[PATCH] ASoC: spear: fix error return code in spdif_in_probe()

2017-06-30 Thread Gustavo A. R. Silva
platform_get_irq() returns an error code, but the spdif_in driver ignores it and always returns -EINVAL. This is not correct, and prevents -EPROBE_DEFER from being propagated properly. Notice that platform_get_irq() no longer returns 0 on error: https://git.kernel.org/pub/scm/linux/kernel/git/torv

Re: [PATCH] hashtable: remove repeated phrase from a comment

2017-06-30 Thread Linus Torvalds
On Wed, Jun 28, 2017 at 9:25 PM, Jakub Kicinski wrote: > > I'm not sure who would take this :S I took it directly. Thanks. Linus

Re: [PATCH] platform/x86: sony-laptop: revert 'const' on keymap

2017-06-30 Thread Andy Shevchenko
On Fri, Jun 30, 2017 at 9:21 PM, Darren Hart wrote: > On Fri, Jun 30, 2017 at 06:58:24PM +0300, Andy Shevchenko wrote: >> On Fri, Jun 30, 2017 at 6:45 PM, Arnd Bergmann wrote: > Will you squash it, or shall I? Please, handle this, thanks! -- With Best Regards, Andy Shevchenko

Re: [PATCH 1/1] MAINTAINERS: Add entry for Whiskey Cove PMIC GPIO driver

2017-06-30 Thread Andy Shevchenko
On Fri, Jun 30, 2017 at 10:20 PM, wrote: > From: Kuppuswamy Sathyanarayanan > +F: drivers/gpio/gpio-wcove.c If we are going to rename (which I personally consider as a good idea), this should follow it, and not otherwise. -- With Best Regards, Andy Shevchenko

[PATCH RESEND] staging: sm750fb: avoid conflicting vesafb

2017-06-30 Thread Sudip Mukherjee
From: Teddy Wang If vesafb is enabled in the config then /dev/fb0 is created by vesa and this sm750 driver gets fb1, fb2. But we need to be fb0 and fb1 to effectively work with xorg. So if it has been alloted fb1, then try to remove the other fb0. Cc: # v4.4+ Signed-off-by: Teddy Wang Signed-o

Re: [RFC] tracing: Add support for critical section event tracing

2017-06-30 Thread Joel Fernandes
Hi Steven, Thanks a lot for the comments, I agree with all of them and had a comment about one of them: On Fri, Jun 30, 2017 at 5:51 AM, Steven Rostedt wrote: [..] > Are you not worried about recursion here? There's no protection. > Wouldn't it be better to have: > > if (!this_cpu_read(t

Re: [RFC] tracing: Add support for critical section event tracing

2017-06-30 Thread Steven Rostedt
On Fri, 30 Jun 2017 14:03:14 -0700 Joel Fernandes wrote: > Hi Steven, > > Thanks a lot for the comments, I agree with all of them and had a > comment about one of them: > > On Fri, Jun 30, 2017 at 5:51 AM, Steven Rostedt wrote: > [..] > > Are you not worried about recursion here? There's no pr

Re: [PATCH 1/1] MAINTAINERS: Add entry for Whiskey Cove PMIC GPIO driver

2017-06-30 Thread sathyanarayanan kuppuswamy
Hi Andy, On 06/30/2017 01:51 PM, Andy Shevchenko wrote: If we are going to rename (which I personally consider as a good idea), this should follow it, and not otherwise. I am having second thoughts about the rename. After going through the spec documents, I found that there are two main differ

[PATCH v2] sata_rcar: fix error return code in sata_rcar_probe()

2017-06-30 Thread Gustavo A. R. Silva
platform_get_irq() returns an error code, but the sata_rcar driver ignores it and always returns -EINVAL. This is not correct, and prevents -EPROBE_DEFER from being propagated properly. Also, notice that platform_get_irq() no longer returns 0 on error. Print error message and propagate the return

Re: [PATCH v2] sata_rcar: fix error return code in sata_rcar_probe()

2017-06-30 Thread Sergei Shtylyov
On 07/01/2017 12:08 AM, Gustavo A. R. Silva wrote: platform_get_irq() returns an error code, but the sata_rcar driver ignores it and always returns -EINVAL. This is not correct, and prevents -EPROBE_DEFER from being propagated properly. Also, notice that platform_get_irq() no longer returns 0 on

Re: [PATCH v2] sata_rcar: fix error return code in sata_rcar_probe()

2017-06-30 Thread Gustavo A. R. Silva
Quoting Sergei Shtylyov : On 07/01/2017 12:08 AM, Gustavo A. R. Silva wrote: platform_get_irq() returns an error code, but the sata_rcar driver ignores it and always returns -EINVAL. This is not correct, and prevents -EPROBE_DEFER from being propagated properly. Also, notice that platform_get

Re: [PATCH] sata_highbank: fix error return code in ahci_highbank_probe()

2017-06-30 Thread Sergei Shtylyov
On 06/30/2017 08:03 AM, Gustavo A. R. Silva wrote: Propagate the return value of platform_get_irq on failure. Needs the same explanations as the sata_rcar patch. Signed-off-by: Gustavo A. R. Silva [...] MBR, Sergei

[PATCH v2] sata_highbank: fix error return code in ahci_highbank_probe()

2017-06-30 Thread Gustavo A. R. Silva
platform_get_irq() returns an error code, but the sata_highbank driver ignores it and always returns -EINVAL. This is not correct, and prevents -EPROBE_DEFER from being propagated properly. Also, notice that platform_get_irq() no longer returns 0 on error. Print error message and propagate the ret

Re: [PATCH] sata_highbank: fix error return code in ahci_highbank_probe()

2017-06-30 Thread Gustavo A. R. Silva
Quoting Sergei Shtylyov : On 06/30/2017 08:03 AM, Gustavo A. R. Silva wrote: Propagate the return value of platform_get_irq on failure. Needs the same explanations as the sata_rcar patch. Yep, I already sent v2 a minute ago. Thanks! -- Gustavo A. R. Silva

Re: [RFC] tracing: Add support for critical section event tracing

2017-06-30 Thread Joel Fernandes
On Fri, Jun 30, 2017 at 2:07 PM, Steven Rostedt wrote: > On Fri, 30 Jun 2017 14:03:14 -0700 > Joel Fernandes wrote: > >> Hi Steven, >> >> Thanks a lot for the comments, I agree with all of them and had a >> comment about one of them: >> >> On Fri, Jun 30, 2017 at 5:51 AM, Steven Rostedt wrote: >

Re: [PATCH] leds: lp55xx: make various arrays static const

2017-06-30 Thread Jacek Anaszewski
Hi, On 06/29/2017 10:48 PM, Pavel Machek wrote: > Hi! > >> Thanks for the patch. >> >> Do you have some profiling results showing the benefit of these changes? >> It seems that these functions are called only on driver initialization. >> Making the local arrays static will prevent releasing this

[PATCH v2] pata_imx: print error message on platform_get_irq failure

2017-06-30 Thread Gustavo A. R. Silva
Print error message on platform_get_irq failure before return. Signed-off-by: Gustavo A. R. Silva --- Changes in v2: Print the return value of platform_get_irq on failure. drivers/ata/pata_imx.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/ata/pata_imx.c b/d

Re: [PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data

2017-06-30 Thread Arend van Spriel
On 23-06-17 23:53, Luis R. Rodriguez wrote: > On Tue, May 16, 2017 at 10:41:08AM +0200, Arend Van Spriel wrote: >> On 16-5-2017 1:13, Luis R. Rodriguez wrote: >>> Since no upstream delta is needed for firmwared I'd like to first encourage >>> evaluating the above. While distributions don't carry

Re: [PATCH] bcma: gpio: Correct number of GPIOs for BCM53573

2017-06-30 Thread Rafał Miłecki
On 30 June 2017 at 21:02, Florian Fainelli wrote: > Broadcom BCM53573 SoCs actually have 32 GPIOs, and not 16. > > Fixes: 3f37ec79dd21 ("bcma: support BCM53573 series of wireless SoCs") > Signed-off-by: Florian Fainelli Looks good.

Re: [PATCH v2] pata_imx: print error message on platform_get_irq failure

2017-06-30 Thread Sergei Shtylyov
On 07/01/2017 12:30 AM, Gustavo A. R. Silva wrote: Print error message on platform_get_irq failure before return. Signed-off-by: Gustavo A. R. Silva --- Changes in v2: Print the return value of platform_get_irq on failure. drivers/ata/pata_imx.c | 5 +++-- 1 file changed, 3 insertions(+), 2

[PATCH 1/4] staging: vt6656: Add spaces between operators

2017-06-30 Thread Simon Sandström
Fixes checkpatch.pl warnings "spaces preferred around that ". Signed-off-by: Simon Sandström --- drivers/staging/vt6656/device.h | 2 +- drivers/staging/vt6656/firmware.c | 2 +- drivers/staging/vt6656/rf.c | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/

[PATCH 3/4] staging: vt6656: Align function parameters

2017-06-30 Thread Simon Sandström
Fixes checkpatch.pl warnings "Alignment should match open parenthesis". Signed-off-by: Simon Sandström --- drivers/staging/vt6656/key.h | 2 +- drivers/staging/vt6656/rf.c | 2 +- drivers/staging/vt6656/usbpipe.c | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/d

[PATCH 4/4] staging: vt6656: Use variable instead of its type in sizeof(...)

2017-06-30 Thread Simon Sandström
Use sizeof(variable) instead of sizeof(type) in memory allocations to prevent problems if the variable type changes in the future. Signed-off-by: Simon Sandström --- drivers/staging/vt6656/main_usb.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/vt6656/

[PATCH 2/4] staging: vt6656: Remove unnecessary blank lines

2017-06-30 Thread Simon Sandström
Fixes checkpatch.pl warning "Blank lines aren't necessary after an open brace". Also adds braces to balance if-else statement. Signed-off-by: Simon Sandström --- drivers/staging/vt6656/power.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/vt6656/power.

[PATCH 0/4] staging: vt6656: Correct checkpatch.pl warnings

2017-06-30 Thread Simon Sandström
Here are some minor checkpatch.pl corrections to staging/vt6656. I was about to ask before sending these in if you rather see commits grouped on file or on type of warning, e.g. each commit fixes multiple types of warnings in a single file versus each commit fixes one type of warning in multiple f

[PATCH] ASoC: kirkwood-i2s: fix error return code in kirkwood_i2s_dev_probe()

2017-06-30 Thread Gustavo A. R. Silva
platform_get_irq() returns an error code, but the kirkwood-i2s driver ignores it and always returns -ENXIO. This is not correct, and prevents -EPROBE_DEFER from being propagated properly. Notice that platform_get_irq() no longer returns 0 on error. Print and propagate the return value of platform_

Re: [PATCH v2] pata_imx: print error message on platform_get_irq failure

2017-06-30 Thread Gustavo A. R. Silva
Quoting Sergei Shtylyov : On 07/01/2017 12:30 AM, Gustavo A. R. Silva wrote: Print error message on platform_get_irq failure before return. Signed-off-by: Gustavo A. R. Silva --- Changes in v2: Print the return value of platform_get_irq on failure. drivers/ata/pata_imx.c | 5 +++-- 1 file c

Re: [PATCH] tracing: Add saved_tgids file to show cached pid to tgid mappings

2017-06-30 Thread Steven Rostedt
On Fri, 30 Jun 2017 11:17:50 -0600 Michael Sartain wrote: > Export the cached pid / tgid mappings to userspace. This allows user > apps to translate the pids from a trace to their respective thread > group. > > Example saved_tgids file with pid / tgid values separated by ' ': > > # cat saved_

Re: [PATCH v2] ARM: fix randomized task_struct

2017-06-30 Thread Kees Cook
On Fri, Jun 30, 2017 at 11:27 AM, Kees Cook wrote: > On Fri, Jun 30, 2017 at 9:03 AM, Arnd Bergmann wrote: >> With the new task struct randomization, we can run into a build >> failure for certain random seeds: >> >> arch/arm/kernel/entry-armv.S: Assembler messages: >> arch/arm/kernel/entry-armv.

[PATCH] selftests: kcmp: convert to TAP13 output

2017-06-30 Thread Shuah Khan
Convert to TAP13 output using ksft_ api. Child runs tests, increments test counters, and prints test results. Signed-off-by: Shuah Khan --- tools/testing/selftests/kcmp/kcmp_test.c | 46 1 file changed, 17 insertions(+), 29 deletions(-) diff --git a/tools/testin

Re: [PATCH] PM / AVS: rockchip-io: add io selectors and supplies for rk3228

2017-06-30 Thread Heiko Stuebner
Am Freitag, 9. Juni 2017, 12:45:46 CEST schrieb Heiko Stuebner: > Am Freitag, 9. Juni 2017, 17:36:14 CEST schrieb David Wu: > > This adds the necessary data for handling io voltage domains on the rk3228. > > > > Signed-off-by: David Wu > > matches the manual, so > Reviewed-by: Heiko Stuebner K

[PATCH 2/2] tracing/kprobes: Allow to create probe with a module name starting with a digit

2017-06-30 Thread Steven Rostedt
From: Sabrina Dubroca Always try to parse an address, since kstrtoul() will safely fail when given a symbol as input. If that fails (which will be the case for a symbol), try to parse a symbol instead. This allows creating a probe such as: p:probe/vlan_gro_receive 8021q:vlan_gro_receive+0

[PATCH v3] pata_imx: print error message on platform_get_irq failure

2017-06-30 Thread Gustavo A. R. Silva
Print error message on platform_get_irq failure before return. Cc: Sergei Shtylyov Signed-off-by: Gustavo A. R. Silva --- Changes in v2: Print the return value of platform_get_irq on failure. Changes in v3: Put back the blank line after the IF closing brace, which was accidentally removed in

[PATCH 1/2] ftrace: Fix regression with module command in stack_trace_filter

2017-06-30 Thread Steven Rostedt
From: "Steven Rostedt (VMware)" When doing the following command: # echo ":mod:kvm_intel" > /sys/kernel/tracing/stack_trace_filter it triggered a crash. This happened with the clean up of probes. It required all callers to the regex function (doing ftrace filtering) to have ops->private be a

[PATCH 0/2] [GIT PULL] tracing: Last minute fixes for 4.12

2017-06-30 Thread Steven Rostedt
Linus, Two fixes: One is for a crash when using the :mod: trace probe command into stack_trace_filter. This bug was introduced during the last merge window. The other was there forever. It's a small bug that makes it impossible to name a module function for kprobes when the module starts w

Re: [PATCH 4/4] arm64: dts: add RK3399-Q7 (Puma) SoM

2017-06-30 Thread Heiko Stuebner
Hi Klaus, Am Montag, 26. Juni 2017, 21:18:54 CEST schrieb Klaus Goger: > The RK3399-Q7 SoM is a Qseven-compatible (70mm x 70mm, MXM-230 > connector) system-on-module from Theobroma Systems, featuring the > Rockchip RK3399. > > It provides the following feature set: > * up to 4GB DDR3 > * on-mod

Re: [PATCH RFC 08/26] locking: Remove spin_unlock_wait() generic definitions

2017-06-30 Thread Paul E. McKenney
On Fri, Jun 30, 2017 at 02:13:39PM +0100, Will Deacon wrote: > On Fri, Jun 30, 2017 at 05:38:15AM -0700, Paul E. McKenney wrote: > > On Fri, Jun 30, 2017 at 10:19:29AM +0100, Will Deacon wrote: > > > On Thu, Jun 29, 2017 at 05:01:16PM -0700, Paul E. McKenney wrote: > > > > There is no agreed-upon d

[GIT PULL 00/30] perf/core improvements and fixes

2017-06-30 Thread Arnaldo Carvalho de Melo
linux into perf/core (2017-06-21 20:11:53 +0200) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-4.13-20170630 for you to fetch changes up to 644e0840ad4615e032d67adec6ee60f821b669fe: perf auxtrace: Add CPU filt

[PATCH 03/30] perf help: Elliminate dup code for reporting

2017-06-30 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo And switch from warning() to pr_warning(), to elliminate another duplication: too many error reporting facilities. Cc: Adrian Hunter Cc: David Ahern Cc: Jiri Olsa Cc: Namhyung Kim Cc: Wang Nan Link: http://lkml.kernel.org/n/tip-pkzcjrhek3uuqc4i5i9ea...@git.ker

[PATCH 01/30] perf tests: Add platform dependency to test 15

2017-06-30 Thread Arnaldo Carvalho de Melo
From: Thomas Richter This patch adds platform dependency into the test case 15 (perf_event_attr). It is based on a suggestion from Jiri Olsa. Add a new optional attribute named 'arch' in the [config] section of the test case file. It is a comma separated list of architecture names this test can

[PATCH 05/30] perf config: Use pr_warning()

2017-06-30 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo warning() is going away, consolidating error reporting. Cc: Adrian Hunter Cc: David Ahern Cc: Jiri Olsa Cc: Namhyung Kim Cc: Wang Nan Link: http://lkml.kernel.org/n/tip-5r3636cwl4z1varo90mer...@git.kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- tools

[PATCH 11/30] perf jit: fix typo: "incalid" -> "invalid"

2017-06-30 Thread Arnaldo Carvalho de Melo
From: Colin Ian King Trivial fix to typo in jvmti_close() warnx warning message. Signed-off-by: Colin King Cc: Alexander Shishkin Cc: Dan Carpenter Cc: Peter Zijlstra Cc: Stephane Eranian Link: http://lkml.kernel.org/r/20170627124917.19151-1-colin.k...@canonical.com Signed-off-by: Arnaldo C

[PATCH 12/30] x86/insn: perf tools: Add new ptwrite instruction

2017-06-30 Thread Arnaldo Carvalho de Melo
From: Adrian Hunter Add ptwrite to the op code map and the perf tools new instructions test. To run the test: $ tools/perf/perf test "x86 ins" 39: Test x86 instruction decoder - new instructions : Ok Or to see the details: $ tools/perf/perf test -v "x86 ins" 2>&1 | grep ptwrite

[PATCH 06/30] perf event-parse: Use pr_warning()

2017-06-30 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo Convert sole user of warning() in this file to pr_warning(), consolidating error reporting facilities. Cc: Adrian Hunter Cc: David Ahern Cc: Jiri Olsa Cc: Namhyung Kim Cc: Wang Nan Link: http://lkml.kernel.org/n/tip-3y7yf6v673ujl2rcs34tz...@git.kernel.org Sign

[PATCH 19/30] perf intel-pt: Factor out common code synthesizing event samples

2017-06-30 Thread Arnaldo Carvalho de Melo
From: Adrian Hunter Factor out common code in functions synthesizing event samples i.e. intel_pt_synth_branch_sample(), intel_pt_synth_instruction_sample() and intel_pt_synth_transaction_sample(). Signed-off-by: Adrian Hunter Cc: Andi Kleen Link: http://lkml.kernel.org/r/1495786658-18063-27-g

[PATCH 08/30] perf tools: Replace error() with pr_err()

2017-06-30 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo To consolidate the error reporting facility. Cc: Adrian Hunter Cc: David Ahern Cc: Jiri Olsa Cc: Namhyung Kim Cc: Wang Nan Link: http://lkml.kernel.org/n/tip-b41iot1094katoffdf19w...@git.kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/built

[PATCH 29/30] perf intel-pt: Do not use TSC packets for calculating CPU cycles to TSC

2017-06-30 Thread Arnaldo Carvalho de Melo
From: Adrian Hunter CBR (core-to-bus ratio) packets provide an indication of CPU frequency. A more accurate measure can be made by counting the cycles (given by CYC packets) in between other timing packets (either MTC or TSC). Using TSC packets has at least 2 issues: 1) timing might have stopped

[PATCH] ASoC: twl6040: fix error return code in twl6040_probe()

2017-06-30 Thread Gustavo A. R. Silva
platform_get_irq() returns an error code, but the twl6040 driver ignores it and always returns -EINVAL. This is not correct, and prevents -EPROBE_DEFER from being propagated properly. Notice that platform_get_irq() no longer returns 0 on error. Print and propagate the return value of platform_get_

[PATCH 26/30] perf intel-pt: Synthesize new power and "ptwrite" events

2017-06-30 Thread Arnaldo Carvalho de Melo
From: Adrian Hunter Synthesize new power and ptwrite events. Power events report changes to C-state but I have also added support for the existing CBR (core-to-bus ratio) packet and included that when outputting power events. The PTWRITE packet is associated with the new "ptwrite" instruction,

[PATCH 28/30] perf intel-pt: Update documentation to include new ptwrite and power events

2017-06-30 Thread Arnaldo Carvalho de Melo
From: Adrian Hunter Update documentation to include new ptwrite and power events. Signed-off-by: Adrian Hunter Cc: Andi Kleen Link: http://lkml.kernel.org/r/1495786658-18063-36-git-send-email-adrian.hun...@intel.com Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/Documentation/intel-

[PATCH 30/30] perf auxtrace: Add CPU filter support

2017-06-30 Thread Arnaldo Carvalho de Melo
From: Adrian Hunter Decoding auxtrace data can take a long time. To avoid decoding unnecessarily, filter auxtrace data that is collected per-cpu before it is decoded. Signed-off-by: Adrian Hunter Cc: Andi Kleen Link: http://lkml.kernel.org/r/1495786658-18063-38-git-send-email-adrian.hun...@in

[PATCH 25/30] perf intel-pt: Move code in intel_pt_synth_events() to simplify attr setting

2017-06-30 Thread Arnaldo Carvalho de Melo
From: Adrian Hunter intel_pt_synth_events() uses the same attr structure to create each event. Move the code around a bit to simplify that. Signed-off-by: Adrian Hunter Cc: Andi Kleen Link: http://lkml.kernel.org/r/1495786658-18063-33-git-send-email-adrian.hun...@intel.com Signed-off-by: Arna

[PATCH 21/30] perf intel-pt: Join needlessly wrapped lines

2017-06-30 Thread Arnaldo Carvalho de Melo
From: Adrian Hunter Join needlessly wrapped lines. Signed-off-by: Adrian Hunter Cc: Andi Kleen Link: http://lkml.kernel.org/r/1495786658-18063-29-git-send-email-adrian.hun...@intel.com Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/util/intel-pt.c | 6 ++ 1 file changed, 2 inser

[PATCH 24/30] perf intel-pt: Factor out intel_pt_set_event_name()

2017-06-30 Thread Arnaldo Carvalho de Melo
From: Adrian Hunter Factor out intel_pt_set_event_name() so it can be reused. Signed-off-by: Adrian Hunter Cc: Andi Kleen Link: http://lkml.kernel.org/r/1495786658-18063-32-git-send-email-adrian.hun...@intel.com Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/util/intel-pt.c | 24 +++

[PATCH 27/30] perf intel-pt: Add example script for power events and PTWRITE

2017-06-30 Thread Arnaldo Carvalho de Melo
From: Adrian Hunter Add script intel-pt-events.py that provides an example of how to unpack the raw data for power events and PTWRITE. Signed-off-by: Adrian Hunter Cc: Andi Kleen Link: http://lkml.kernel.org/r/1495786658-18063-35-git-send-email-adrian.hun...@intel.com Signed-off-by: Arnaldo C

[PATCH 23/30] perf intel-pt: Tidy messages into called function intel_pt_synth_event()

2017-06-30 Thread Arnaldo Carvalho de Melo
From: Adrian Hunter Tidy print messages into called function intel_pt_synth_event(). Signed-off-by: Adrian Hunter Cc: Andi Kleen Link: http://lkml.kernel.org/r/1495786658-18063-31-git-send-email-adrian.hun...@intel.com Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/util/intel-pt.c |

[PATCH 20/30] perf intel-pt: Remove unused instructions_sample_period

2017-06-30 Thread Arnaldo Carvalho de Melo
From: Adrian Hunter Remove unused struct intel_pt member instructions_sample_period. Signed-off-by: Adrian Hunter Cc: Andi Kleen Link: http://lkml.kernel.org/r/1495786658-18063-28-git-send-email-adrian.hun...@intel.com Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/util/intel-pt.c |

[PATCH 22/30] perf intel-pt: Tidy Intel PT evsel lookup into separate function

2017-06-30 Thread Arnaldo Carvalho de Melo
From: Adrian Hunter Tidy the lookup of the Intel PT selected event (perf_evsel) into a separate function. Signed-off-by: Adrian Hunter Cc: Andi Kleen Link: http://lkml.kernel.org/r/1495786658-18063-30-git-send-email-adrian.hun...@intel.com Signed-off-by: Arnaldo Carvalho de Melo --- tools/p

[PATCH 15/30] perf auxtrace: Add itrace option to output ptwrite events

2017-06-30 Thread Arnaldo Carvalho de Melo
From: Adrian Hunter Add itrace option to output ptwrite events. Signed-off-by: Adrian Hunter Cc: Andi Kleen Link: http://lkml.kernel.org/r/1495786658-18063-24-git-send-email-adrian.hun...@intel.com Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/Documentation/itrace.txt | 7 ---

[PATCH 18/30] perf script: Add synthesized Intel PT power and ptwrite events

2017-06-30 Thread Arnaldo Carvalho de Melo
From: Adrian Hunter Add definitions for synthesized Intel PT events for power and ptwrite. Signed-off-by: Adrian Hunter Cc: Andi Kleen Link: http://lkml.kernel.org/r/1498811802-2301-1-git-send-email-adrian.hun...@intel.com Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/builtin-scrip

[PATCH 16/30] perf auxtrace: Add itrace option to output power events

2017-06-30 Thread Arnaldo Carvalho de Melo
From: Adrian Hunter Add itrace option to output power events. Signed-off-by: Adrian Hunter Cc: Andi Kleen Link: http://lkml.kernel.org/r/1495786658-18063-25-git-send-email-adrian.hun...@intel.com Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/Documentation/itrace.txt | 5 +++-- tool

[PATCH 14/30] tools include: Add byte-swapping macros to kernel.h

2017-06-30 Thread Arnaldo Carvalho de Melo
From: Adrian Hunter Add byte-swapping macros to kernel.h Signed-off-by: Adrian Hunter Cc: Andi Kleen Link: http://lkml.kernel.org/r/1495786658-18063-23-git-send-email-adrian.hun...@intel.com Signed-off-by: Arnaldo Carvalho de Melo --- tools/include/linux/kernel.h | 35 ++

[PATCH 13/30] perf script: Add 'synth' event type for synthesized events

2017-06-30 Thread Arnaldo Carvalho de Melo
From: Adrian Hunter Instruction trace decoders such as Intel PT may have additional information recorded in the trace. For example, Intel PT has power information and a there is a new instruction 'ptwrite' that can write a value into a PTWRITE trace packet. Such information may be associated wit

[PATCH 17/30] perf script: Add 'synth' field for synthesized event payloads

2017-06-30 Thread Arnaldo Carvalho de Melo
From: Adrian Hunter Add a field to display the content the raw_data of a synthesized event. Signed-off-by: Adrian Hunter Cc: Andi Kleen Link: http://lkml.kernel.org/r/1495786658-18063-22-git-send-email-adrian.hun...@intel.com [ Resolved conflict with 106dacd86f04 ("perf script: Support -F br

[PATCH 09/30] perf config: Do not die when parsing u64 or int config values

2017-06-30 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo Just warn the user and ignore those values. Cc: Adrian Hunter Cc: David Ahern Cc: Jiri Olsa Cc: Namhyung Kim Cc: Wang Nan Link: http://lkml.kernel.org/n/tip-tbf60nj3ierm6hrkhpoth...@git.kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/builti

[PATCH 10/30] perf tools: Kill die()

2017-06-30 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo Finally can nuke this function, no more users. Cc: Adrian Hunter Cc: David Ahern Cc: Jiri Olsa Cc: Namhyung Kim Cc: Wang Nan Link: http://lkml.kernel.org/n/tip-eivvvzn8ie6w42gy3batx...@git.kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/tes

[PATCH 04/30] perf help: Use pr_warning()

2017-06-30 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo Complete the switch to using te pr_{warning,error,etc} error reporting facilities. Cc: Adrian Hunter Cc: David Ahern Cc: Jiri Olsa Cc: Namhyung Kim Cc: Wang Nan Link: http://lkml.kernel.org/n/tip-3l9gr6237b4aqyo0rsspi...@git.kernel.org Signed-off-by: Arnaldo C

[PATCH 07/30] perf tools: Remove warning()

2017-06-30 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo Now everything uses pr_warning(), so ditch it. Cc: Adrian Hunter Cc: David Ahern Cc: Jiri Olsa Cc: Namhyung Kim Cc: Wang Nan Link: http://lkml.kernel.org/n/tip-hv8r0mgdhk73wtfq3zrha...@git.kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/tes

[PATCH 02/30] perf help: Introduce exec_failed() to avoid code duplication

2017-06-30 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo The warning(str_error_r(errno)) pattern can be replaced with a function, do it. And while at it use pr_warning(), we have way too many error reporting facilities, time to drop some, starting with the one we got from the git sources. Cc: Adrian Hunter Cc: David Ah

[PATCH] ALSA: atmel: ac97c: fix error return code in atmel_ac97c_probe()

2017-06-30 Thread Gustavo A. R. Silva
platform_get_irq() returns an error code, but the ac97c driver ignores it and always returns -ENXIO. This is not correct, and prevents -EPROBE_DEFER from being propagated properly. Notice that platform_get_irq() no longer returns 0 on error. Print and propagate the return value of platform_get_irq

[PATCH] ASoC: imx-ssi: add check on platform_get_irq return value

2017-06-30 Thread Gustavo A. R. Silva
Check return value from call to platform_get_irq(), so in case of failure print error message and propagate the return value. Signed-off-by: Gustavo A. R. Silva --- sound/soc/fsl/imx-ssi.c | 4 1 file changed, 4 insertions(+) diff --git a/sound/soc/fsl/imx-ssi.c b/sound/soc/fsl/imx-ssi.c i

Re: linux-next: manual merge of the akpm-current tree with the kselftest tree

2017-06-30 Thread Luis R. Rodriguez
On Thu, Jun 29, 2017 at 12:35:27PM -0700, Andrew Morton wrote: > On Wed, 28 Jun 2017 18:31:11 +1000 Stephen Rothwell > wrote: > > > Hi all, > > > > Today's linux-next merge of the akpm-current tree got conflicts in: > > > > tools/testing/selftests/sysctl/common_tests > > tools/testing/self

[PATCH v2 4/6] test_sysctl: add simple proc_dointvec() case

2017-06-30 Thread Luis R. Rodriguez
Test against a simple proc_dointvec() case. While at it, add a test against INT_MAX. Make sure INT_MAX works, and INT_MAX+1 will fail. Also test negative values work. Cc: Kees Cook Cc: "Eric W. Biederman" Cc: Shuah Khan Signed-off-by: Luis R. Rodriguez --- lib/test_sysctl.c

[PATCH v2 0/6] test_sysctl: fix up merge conflicts

2017-06-30 Thread Luis R. Rodriguez
ound. I've made Orson's check a function, and integrated his exit strategy to restore the production sysctl writes_strict setting. To do this I've also added a PROD_SYCTL, which now users can also override through an environment variable. These changes are also present on my linux-ne

[PATCH v2 2/6] test_sysctl: add generic script to expand on tests

2017-06-30 Thread Luis R. Rodriguez
This adds a generic script to let us more easily add more tests cases. Since we really have only two types of tests cases just fold them into the one file. Each test unit is now identified into its separate function: # ./sysctl.sh -l Test ID list: TEST_ID x NUM_TEST TEST_ID: Test ID NUM_TEST

[PATCH v2 3/6] test_sysctl: test against PAGE_SIZE for int

2017-06-30 Thread Luis R. Rodriguez
Add the following tests to ensure we do not regress: o Test using a buffer full of space (PAGE_SIZE-1) followed by a single digit works o Test using a buffer full of spaces (PAGE_SIZE or over) will fail As tests increase instead of unloading the module and reloading it we can just do a s

[PATCH v2 6/6] test_sysctl: test against int proc_dointvec() array support

2017-06-30 Thread Luis R. Rodriguez
Add a few initial respective tests for an array: o Echoing values separated by spaces works o Echoing only first elements will set first elements o Confirm PAGE_SIZE limit still applies even if an array is used Cc: Kees Cook Cc: "Eric W. Biederman" Cc: Shuah Khan Signed-off-by: Luis R. R

[PATCH v2 5/6] test_sysctl: add simple proc_douintvec() case

2017-06-30 Thread Luis R. Rodriguez
Test against a simple proc_douintvec() case. While at it, add a test against UINT_MAX. Make sure UINT_MAX works, and UINT_MAX+1 will fail and that negative values are not accepted. Cc: Kees Cook Cc: "Eric W. Biederman" Cc: Shuah Khan Signed-off-by: Luis R. Rodriguez --- lib/test_sysctl.c

[PATCH v2 1/6] test_sysctl: add dedicated proc sysctl test driver

2017-06-30 Thread Luis R. Rodriguez
The existing tools/testing/selftests/sysctl/ tests include two test cases, but these use existing production kernel sysctl interfaces. We want to expand test coverage but we can't just be looking for random safe production values to poke at, that's just insane! Instead just dedicate a test driver

[PATCH] serial: 8250: fix error handling in of_platform_serial_probe()

2017-06-30 Thread Alexey Khoroshilov
clk_disable_unprepare(info->clk) is missed in of_platform_serial_probe(), while irq_dispose_mapping(port->irq) is missed in of_platform_serial_setup(). Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov --- drivers/tty/serial/8250/8250_of.c | 20 +++

Re: [PATCH] kmod: add dependencies for test module

2017-06-30 Thread Luis R. Rodriguez
On Fri, Jun 30, 2017 at 05:47:44PM +0200, Arnd Bergmann wrote: > When we try to 'select' drivers whose dependencies are not met, > we get a kconfig warning and undefined behavior as further 'select' > statements in those drivers can not be honored: > > warning: (TEST_KMOD) selects TUN which has un

[PATCH] kbuild: modpost: Warn about references from rodata to __init text

2017-06-30 Thread Stephen Boyd
If we have a structure that's marked const it will be placed into the .rodata section but it could reference an init section function. Include the read only data section in the check we have for read/write data sections referencing init sections so we can find this class of problems. This exposes q

[PATCH] w1: omap-hdq: fix error return code in omap_hdq_probe()

2017-06-30 Thread Gustavo A. R. Silva
platform_get_irq() returns an error code, but the omap_hdq driver ignores it and always returns -ENXIO. This is not correct, and prevents -EPROBE_DEFER from being propagated properly. Notice that platform_get_irq() no longer returns 0 on error. Print error message and propagate the return value of

did vfs_read or something related to it get broken?

2017-06-30 Thread David F.
Hi, I have a driver that reads data from a file that has worked from kernel 3.x up to 4.9.13. I haven't tried all the other 4.9's or 4.10, or 4.11.6 or earlier, but in 4.11.7 it's now broken and an error is returned. It's based on http://krishnamohanlinux.blogspot.com/2013/12/how-to-write-to-fi

Pattern of black screens with Linux on newer laptops.

2017-06-30 Thread David F.
Using up to and including 4.11.7 getting reports coming in of black screens on new laptops (includes booting to console only). The solution is to use kernel parameter acpi=off. The newer include Dell Latitude 5289 and Lenovo e-560. (although searching Internet even older system affected like HP

Re: [HMM 12/15] mm/migrate: new memory migration helper for use with device memory v4

2017-06-30 Thread Evgeny Baskakov
On 6/26/17 5:07 PM, Evgeny Baskakov wrote: > Hi Jerome, > > The documentation shown above doesn't tell what the alloc_and_copy callback should do for source pages that have not been allocated yet. Instead, it unconditionally suggests checking if the MIGRATE_PFN_VALID and MIGRATE_PFN_MIGRATE fl

Re: [RFC] tracing: Add support for critical section event tracing

2017-06-30 Thread Joel Fernandes
Hi Steven, On Jun 30, 2017 5:32 AM, "Steven Rostedt" wrote: [..] >> Did you have any comments about this patch? It was sent a while ago >> and if you can provide me your initial thoughts on it, I would >> appreciate it. (Sorry to ping you about it during the busy merge >> window time, but I was t

Re: [PATCH][scsi-next] scsi: qla2xxx: fix a bunch of typos and spelling mistakes

2017-06-30 Thread Madhani, Himanshu
> On Jun 30, 2017, at 6:47 AM, Colin King wrote: > > From: Colin Ian King > > Fix the following typos/spelling mistakes: > > "attribure" -> "attribute" > "suppored" -> "supported" > "Symobilic" -> "Symbolic" > "iteself" -> "itself" > "reqeust" -> "request" > "nvme_wait_on_comand" -> "nvme_wai

[PATCH] doc: Update memory-barriers.txt for read-to-write dependencies

2017-06-30 Thread Paul E. McKenney
The memory-barriers.txt document contains an obsolete passage stating that smp_read_barrier_depends() is required to force ordering for read-to-write dependencies. We now know that this is not required, even for DEC Alpha. This commit therefore updates this passage to state that read-to-write depe

Re: [PATCH] tracing: Add saved_tgids file to show cached pid to tgid mappings

2017-06-30 Thread Joel Fernandes
On Fri, Jun 30, 2017 at 2:50 PM, Steven Rostedt wrote: > On Fri, 30 Jun 2017 11:17:50 -0600 [..] >> >> Signed-off-by: Michael Sartain >> --- >> kernel/trace/trace.c | 60 >> +++- >> 1 file changed, 59 insertions(+), 1 deletion(-) >> >> diff --git

<    2   3   4   5   6   7   8   >