Re: [criu] 1M guard page ruined restore

2017-06-21 Thread Oleg Nesterov
(add Adrian) On 06/21, Cyrill Gorcunov wrote: > > The patches for criu are on the fly. Still one of the test case > start failing with the new kernels. Basically the test does > the following: Cyrill, please read the last email I sent you in another (private) discussion. Most probably you should

Re: [PATCH v5 0/6] Add support for the ICU unit in Marvell Armada 7K/8K

2017-06-21 Thread Thomas Petazzoni
Hello, On Wed, 21 Jun 2017 16:14:21 +0100, Marc Zyngier wrote: > > Thomas Petazzoni (6): > > dt-bindings: interrupt-controller: add DT binding for the Marvell GICP > > dt-bindings: interrupt-controller: add DT binding for the Marvell ICU > > irqchip: irq-mvebu-gicp: new driver for Marvell G

Re: [PATCH] pinctrl/amd: Use regular interrupt instead of chained

2017-06-21 Thread Linus Walleij
On Tue, Jun 20, 2017 at 2:28 PM, Borislav Petkov wrote: > On Mon, May 29, 2017 at 01:55:57PM +0200, Linus Walleij wrote: >> Patch applied for fixes. > > Btw, any chance you can add the CC:stable tag to it or would you prefer > for me to backport it once it hits mainline? This is sent to Torvalds,

Re: [PATCH 2/6] drivers base/arch_topology: frequency-invariant load-tracking support

2017-06-21 Thread Dietmar Eggemann
On 20/06/17 07:17, Viresh Kumar wrote: > On Thu, Jun 8, 2017 at 1:25 PM, Dietmar Eggemann > wrote: > >> diff --git a/drivers/base/arch_topology.c b/drivers/base/arch_topology.c > >> static int >> init_cpu_capacity_callback(struct notifier_block *nb, >> @@ -185,6 +192,7 @@ init_cpu_capacity_cal

Re: [PATCH v3 04/11] x86/mm: Give each mm TLB flush generation a unique ID

2017-06-21 Thread Andy Lutomirski
On Wed, Jun 21, 2017 at 3:33 AM, Borislav Petkov wrote: > On Tue, Jun 20, 2017 at 10:22:10PM -0700, Andy Lutomirski wrote: >> +#define INIT_MM_CONTEXT(mm) \ >> + .context = {\ >> + .ctx_id

Re: [PATCH 2/6] drivers base/arch_topology: frequency-invariant load-tracking support

2017-06-21 Thread Dietmar Eggemann
On 14/06/17 14:08, Vincent Guittot wrote: > On 14 June 2017 at 09:55, Dietmar Eggemann wrote: >> >> On 06/12/2017 04:27 PM, Vincent Guittot wrote: >>> On 8 June 2017 at 09:55, Dietmar Eggemann wrote: [...] >> >> Yes, we should free cpus_to_visit if the policy notifier registration >> fails. But

Re: [PATCH net-next v3 0/4] ipmr/ip6mr: add Netlink notifications on cache reports

2017-06-21 Thread David Miller
From: Julien Gomes Date: Tue, 20 Jun 2017 13:54:14 -0700 > Currently, all ipmr/ip6mr cache reports are sent through the > mroute/mroute6 socket only. > This forces the use of a single socket for mroute programming, cache > reports and, regarding ipmr, IGMP messages without Router Alert option > r

Re: [PATCH] futex: avoid undefined behaviour when shift exponent is negative

2017-06-21 Thread Ingo Molnar
* zhong jiang wrote: > when shift expoment is negative, left shift alway zero. therefore, we > modify the logic to avoid the warining. > > Signed-off-by: zhong jiang > --- > arch/x86/include/asm/futex.h | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/arch/x86

[PATCH] perf probe: Fix probe definition for inlined functions

2017-06-21 Thread Björn Töpel
From: Björn Töpel In commit 613f050d68a8 ("perf probe: Fix to probe on gcc generated functions in modules"), the offset from symbol is, incorrectly, added to the trace point address. This leads to incorrect probe trace points for inlined functions and when using relative line number on symbols.

Re: [PATCH] BUG-REPORT: snd-hda: hacked-together EPROBE_DEFER support

2017-06-21 Thread Chris Wilson
Quoting Daniel Vetter (2017-06-21 16:08:54) > So back when the i915 power well support landed in > > commit 99a2008d0b32d72dfc2a54e7be1eb698dd2e3bd6 > Author: Wang Xingchao > Date: Thu May 30 22:07:10 2013 +0800 > > ALSA: hda - Add power-welll support for haswell HDA > > the logic to hand

Re: [PATCH] BUG-REPORT: snd-hda: hacked-together EPROBE_DEFER support

2017-06-21 Thread Takashi Iwai
On Wed, 21 Jun 2017 17:23:57 +0200, Chris Wilson wrote: > > Quoting Daniel Vetter (2017-06-21 16:08:54) > > So back when the i915 power well support landed in > > > > commit 99a2008d0b32d72dfc2a54e7be1eb698dd2e3bd6 > > Author: Wang Xingchao > > Date: Thu May 30 22:07:10 2013 +0800 > > > >

Re: [RFC PATCH v3 3/6] ARM/arm64: dts: enable wakeup for cros-ec-spi devices

2017-06-21 Thread Krzysztof Kozlowski
On Wed, Jun 21, 2017 at 11:33:29PM +0800, jeffy wrote: > Hi Krzysztof, > > thanx for your comment. > > On 06/21/2017 06:45 PM, Krzysztof Kozlowski wrote: > > On Wed, Jun 21, 2017 at 12:01 PM, Jeffy Chen > > wrote: > > > We used to enable wakeup for cros-ec-spi devices unconditionally. > > > Now

Re: [v2] mwifiex: fixes the unexpected be printed log by default

2017-06-21 Thread Kalle Valo
Caesar Wang wrote: > This patch uses WARN level is not printed by default. > > In some cases, some boards have always met the unused log be printed as > follows. > ... > [23193.523182] mwifiex_pcie :01:00.0: mwifiex_get_cfp: > cannot find cfp by band 2& channel=13 freq=0 > [23378.633684]

Re: [criu] 1M guard page ruined restore

2017-06-21 Thread Cyrill Gorcunov
On Wed, Jun 21, 2017 at 06:22:56PM +0300, Cyrill Gorcunov wrote: > This start failing because > > | static inline int check_stack_guard_page(struct vm_area_struct *vma, > unsigned long address) > > function get dropped off. Hugh, it is done on intent and > userspace programs have to extend stac

Re: [PATCH 0/4] some scheduler code movements and small cleanup

2017-06-21 Thread Ingo Molnar
* Nicolas Pitre wrote: > Ping. I've applied the first patch to the scheduler tree yesterday, but the other changes unfortunately conflicted with other pending scheduler work - could you please re-post the other 3 patches on top of tip:sched/core? Thanks, Ingo

Re: [PATCH V3 20/37] perf script: Add 'synth' event type for synthesized events

2017-06-21 Thread Adrian Hunter
On 06/21/2017 04:51 PM, Arnaldo Carvalho de Melo wrote: > Em Wed, Jun 21, 2017 at 01:17:19PM +0300, Adrian Hunter escreveu: >> +++ b/tools/perf/util/event.h >> @@ -252,6 +252,9 @@ enum auxtrace_error_type { >>PERF_AUXTRACE_ERROR_MAX >> }; > >> +/* Attribute type for custom synthesized even

Re: [PATCH v4 0/5] Add support for the ARMv8.2 Statistical Profiling Extension

2017-06-21 Thread Will Deacon
On Thu, Jun 15, 2017 at 10:57:35AM -0500, Kim Phillips wrote: > On Mon, 12 Jun 2017 11:20:48 -0500 > Kim Phillips wrote: > > > On Mon, 12 Jun 2017 12:08:23 +0100 > > Mark Rutland wrote: > > > > > On Mon, Jun 05, 2017 at 04:22:52PM +0100, Will Deacon wrote: > > > > This is the sixth posting of t

Re: [PATCH v4 20/28] ARM: owl: Implement CPU enable-method for S500

2017-06-21 Thread Andreas Färber
Am 21.06.2017 um 12:25 schrieb Arnd Bergmann: > On Wed, Jun 21, 2017 at 10:16 AM, Arnd Bergmann wrote: >> On Tue, Jun 6, 2017 at 2:54 AM, Andreas Färber wrote: >>> Allow to bring up CPU1. >>> >>> Based on LeMaker linux-actions tree. >>> >>> Signed-off-by: Andreas Färber >>> --- >>> v3 -> v4: Un

Re: [PATCH 0/2] swait: add idle to make idle-hacks on kthreads explicit

2017-06-21 Thread Paul E. McKenney
On Tue, Jun 20, 2017 at 02:45:45PM -0700, Luis R. Rodriguez wrote: > In this proper patch form I've made the non-timeout idle swait void. > I've also integrated Paul's comment / ident changes, and added documentation > as suggested by Boqun. > > Let me know if there are issue, otherwise, Paul feel

Re: [PATCH net-next] r8152: correct the definition

2017-06-21 Thread David Miller
From: Hayes Wang Date: Wed, 21 Jun 2017 11:25:18 +0800 > Replace VLAN_HLEN and CRC_SIZE with ETH_FCS_LEN. > > Signed-off-by: Hayes Wang Applied.

[tip:perf/urgent] perf/aux: Correct return code of rb_alloc_aux() if !has_aux(ev)

2017-06-21 Thread tip-bot for Hendrik Brueckner
Commit-ID: 8a1898db51a3390241cd5fae267dc8aaa9db0f8b Gitweb: http://git.kernel.org/tip/8a1898db51a3390241cd5fae267dc8aaa9db0f8b Author: Hendrik Brueckner AuthorDate: Tue, 20 Jun 2017 12:26:39 +0200 Committer: Ingo Molnar CommitDate: Wed, 21 Jun 2017 11:58:30 +0200 perf/aux: Correct retu

[PATCH v2] fs: Reorder inode_owner_or_capable() to avoid needless

2017-06-21 Thread Kees Cook
Checking for capabilities should be the last operation when performing access control tests so that PF_SUPERPRIV is set only when it was required for success (implying that the capability was needed for the operation). Reported-by: Solar Designer Signed-off-by: Kees Cook Acked-by: Serge Hallyn

Re: [PATCH 2/6] drivers base/arch_topology: frequency-invariant load-tracking support

2017-06-21 Thread Morten Rasmussen
On Wed, Jun 21, 2017 at 11:07:35AM +0530, Viresh Kumar wrote: > On 20-06-17, 17:31, Saravana Kannan wrote: > > On 06/19/2017 11:17 PM, Viresh Kumar wrote: > > >On Thu, Jun 8, 2017 at 1:25 PM, Dietmar Eggemann > > > wrote: > > > > > >>diff --git a/drivers/base/arch_topology.c b/drivers/base/arch_top

Re: [PATCH 1/2] dt-bindings: spi: Document the STM32 SPI bindings

2017-06-21 Thread Neil Armstrong
On 06/21/2017 04:32 PM, Amelie Delaunay wrote: > This patch adds the documentation of device tree bindings > for the STM32 SPI controller. > > Signed-off-by: Amelie Delaunay > --- > .../devicetree/bindings/spi/spi-stm32.txt | 60 > ++ > 1 file changed, 60 insertions

Re: [PATCH v4 4/5] drivers/perf: Add support for ARMv8.2 Statistical Profiling Extension

2017-06-21 Thread Will Deacon
Hi Mark, Thanks for the extensive review. Replies inline. On Thu, Jun 15, 2017 at 03:57:29PM +0100, Mark Rutland wrote: > On Mon, Jun 05, 2017 at 04:22:56PM +0100, Will Deacon wrote: > > +/* ID registers */ > > +#define PMSIDR_EL1 sys_reg(3, 0, 9, 9, 7) > > Nit: could we please g

Re: [PATCH] net/sctp/ulpevent.c: Deinline sctp_ulpevent_set_owner, save 1616 bytes

2017-06-21 Thread Marcelo Ricardo Leitner
On Wed, Jun 21, 2017 at 06:28:09PM +0200, Denys Vlasenko wrote: > This function compiles to 147 bytes of machine code. 13 callsites. > > I'm no expert on SCTP events, but quick reading of SCTP docs tells me that > SCTP events are not happening on every packet. > They are ASSOC_CHANGE, PEER_ADDR_CH

Re: [PATCH 2/2] kbuild: clang: Disable the 'duplicate-decl-specifier' warning

2017-06-21 Thread Matthias Kaehlcke
El Wed, Jun 21, 2017 at 12:11:55PM +0200 Arnd Bergmann ha dit: > On Wed, Jun 21, 2017 at 11:11 AM, Masahiro Yamada > wrote: > > 2017-05-24 17:21 GMT+09:00 Arnd Bergmann : > >> On Wed, May 24, 2017 at 2:04 AM, Matthias Kaehlcke > >> wrote: > >>> El Wed, May 17, 2017 at 11:45:29AM -0700 Matthias

1,650,000,00 Euros

2017-06-21 Thread Marcelo Dantas Teixeira
E-postvarsling! E-posten ble valgt og har 1,650,000,00 Euro som ble registrert og forsikret på ditt navn. Hvis du vil ha mer informasjon om penger, kontakt: onuw...@qq.com MFG Marcelo Dontas Teixeira

Re: [PATCH v6 26/34] iommu/amd: Allow the AMD IOMMU to work with memory encryption

2017-06-21 Thread Borislav Petkov
On Wed, Jun 21, 2017 at 05:37:22PM +0200, Joerg Roedel wrote: > > Do you mean this is like the last exception case in that document above: > > > > " > > - Pointers to data structures in coherent memory which might be modified > > by I/O devices can, sometimes, legitimately be volatile. A ri

Re: [PATCH] cifs: remove redundant return in cifs_creation_time_get

2017-06-21 Thread Steve French
merged into cifs-2.6.git for-next On Wed, Jun 7, 2017 at 8:00 AM, Aurélien Aptel wrote: > > Looks good to me. > > -- > Aurélien Aptel / SUSE Labs Samba Team > GPG: 1839 CB5F 9F5B FB9B AA97 8C99 03C8 A49B 521B D5D3 > SUSE Linux GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany > GF: Felix Imendörffe

Re: [PATCH] CIFS: check if pages is null rather than bv for a failed allocation

2017-06-21 Thread Steve French
meged into cifs-2.6.git for-next On Wed, May 17, 2017 at 1:24 PM, Colin King wrote: > From: Colin Ian King > > pages is being allocated however a null check on bv is being used > to see if the allocation failed. Fix this by checking if pages is > null. > > Detected by CoverityScan, CID#1432974 (

[PATCH v4 1/4] perf/core: addressing 4x slowdown during per-process profiling of STREAM benchmark on Intel Xeon Phi

2017-06-21 Thread Alexey Budankov
perf/core: use rb trees for pinned/flexible groups By default, the userspace perf tool opens per-cpu task-bound events when sampling, so for N logical events requested by the user, the tool will open N * NR_CPUS events. In the kernel, we mux events with a hrtimer, periodically rotating the flexi

Re: [criu] 1M guard page ruined restore

2017-06-21 Thread Oleg Nesterov
On 06/21, Cyrill Gorcunov wrote: > > On Wed, Jun 21, 2017 at 05:57:30PM +0200, Oleg Nesterov wrote: > > > > > > p = fake_grow_down; > > > *p-- = 'c'; > > > > I guess this works? I mean, *p-- = 'c' should not fail... > > It fails. Hmm. Impossible ;) could you add the additional printf's to re-c

Re: [PATCH] pinctrl/amd: Use regular interrupt instead of chained

2017-06-21 Thread Borislav Petkov
On Wed, Jun 21, 2017 at 06:37:09PM +0200, Linus Walleij wrote: > This is sent to Torvalds, but you can simply suggest to Greg to pick > this for stable according to the process in: > Documentation/process/stable-kernel-rules.rst Yeah, I saw your pull request after hitting send. I'll send it to Gre

Re: [PATCH] CIFS: Fix some return values in case of error in 'crypt_message'

2017-06-21 Thread Steve French
merged into cifs-2.6.git for-next On Sun, Jun 11, 2017 at 2:12 AM, Christophe JAILLET wrote: > 'rc' is known to be 0 at this point. So if 'init_sg' or 'kzalloc' fails, we > should return -ENOMEM instead. > > Also remove a useless 'rc' in a debug message as it is meaningless here. > > Fixes: 026e9

Re: [PATCH v2]: perf/core: addressing 4x slowdown during per-process, profiling of STREAM benchmark on Intel Xeon Phi

2017-06-21 Thread Alexey Budankov
Hi, On 15.06.2017 20:42, Alexey Budankov wrote: On 29.05.2017 14:45, Alexey Budankov wrote: On 29.05.2017 14:23, Peter Zijlstra wrote: On Mon, May 29, 2017 at 01:56:05PM +0300, Alexey Budankov wrote: On 29.05.2017 13:43, Peter Zijlstra wrote: Why can't the tree do both? Well, indeed, t

[PATCH v2] net/sctp/ulpevent.c: Deinline sctp_ulpevent_set_owner, save 1616 bytes

2017-06-21 Thread Denys Vlasenko
This function compiles to 147 bytes of machine code. 13 callsites. I'm no expert on SCTP events, but quick reading of SCTP docs tells me that SCTP events are not happening on every packet. They are ASSOC_CHANGE, PEER_ADDR_CHANGE, REMOTE_ERROR and such. Does not look performance critical. Signed-o

Re: [PATCH v3 04/11] x86/mm: Give each mm TLB flush generation a unique ID

2017-06-21 Thread Borislav Petkov
On Wed, Jun 21, 2017 at 08:23:07AM -0700, Andy Lutomirski wrote: > It's stated explicitly in the comment where it's declared in the same file. Doh, it says "zero" there. I should learn how to read. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply

Re: [PATCH V2] kernel/watchdog: fix spurious hard lockups

2017-06-21 Thread Andi Kleen
On Wed, Jun 21, 2017 at 05:12:06PM +0200, Thomas Gleixner wrote: > On Wed, 21 Jun 2017, kan.li...@intel.com wrote: > > > > #ifdef CONFIG_HARDLOCKUP_DETECTOR > > +/* > > + * The NMI watchdog relies on PERF_COUNT_HW_CPU_CYCLES event, which > > + * can tick faster than the measured CPU Frequency du

Re: [PATCH] fs: buffer: Modify alloc_page_buffers.

2017-06-21 Thread Sean Fu
On Mon, Jun 19, 2017 at 05:03:16PM +0100, Al Viro wrote: > On Mon, Jun 19, 2017 at 09:01:36PM +0800, Sean Fu wrote: > > Make alloc_page_buffers support circular buffer list and initialise > > b_state field. > > Optimize the performance by removing the buffer list traversal to create > > circular bu

Re: [PATCH 2/6] drivers base/arch_topology: frequency-invariant load-tracking support

2017-06-21 Thread Dietmar Eggemann
On 21/06/17 01:31, Saravana Kannan wrote: > On 06/19/2017 11:17 PM, Viresh Kumar wrote: >> On Thu, Jun 8, 2017 at 1:25 PM, Dietmar Eggemann >> wrote: >> >>> diff --git a/drivers/base/arch_topology.c b/drivers/base/arch_topology.c >> >>> static int __init register_cpufreq_notifier(void) >>> { >

Re: [PATCH 35/51] rtc: pm8xxx: stop using rtc deprecated functions

2017-06-21 Thread kbuild test robot
-functions/20170621-044455 base: https://git.kernel.org/pub/scm/linux/kernel/git/abelloni/linux.git rtc-next config: i386-allmodconfig (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce: # save the attached .config to linux build tree make ARCH=i386 All

RE: [PATCH V2] kernel/watchdog: fix spurious hard lockups

2017-06-21 Thread Liang, Kan
> On Wed, 21 Jun 2017, kan.li...@intel.com wrote: > > > > #ifdef CONFIG_HARDLOCKUP_DETECTOR > > +/* > > + * The NMI watchdog relies on PERF_COUNT_HW_CPU_CYCLES event, > which > > + * can tick faster than the measured CPU Frequency due to Turbo mode. > > + * That can lead to spurious timeouts. >

[PATCH v1] ARM: dts: sun7i: provide ramoops region on BananaPi

2017-06-21 Thread Oleksij Rempel
This should help provide useful debug information on remote targets without UART. Signed-off-by: Oleksij Rempel --- arch/arm/boot/dts/sun7i-a20-bananapi.dts | 16 1 file changed, 16 insertions(+) diff --git a/arch/arm/boot/dts/sun7i-a20-bananapi.dts b/arch/arm/boot/dts/sun7i-a

Re: [criu] 1M guard page ruined restore

2017-06-21 Thread Dmitry Safonov
On 06/21/2017 08:01 PM, Oleg Nesterov wrote: On 06/21, Cyrill Gorcunov wrote: On Wed, Jun 21, 2017 at 05:57:30PM +0200, Oleg Nesterov wrote: p = fake_grow_down; *p-- = 'c'; I guess this works? I mean, *p-- = 'c' should not fail... It fails. Hmm. Impossible ;) could you a

Re: [criu] 1M guard page ruined restore

2017-06-21 Thread Willy Tarreau
Hi Oleg, On Wed, Jun 21, 2017 at 07:01:29PM +0200, Oleg Nesterov wrote: > Ah. I forgot about another kernel "feature" ;) not related to the recent guard > page changes... > > Could you test the patch below? FWIW, I've just checked here on 3.10.107-rc and while I observe the same regression as Cy

Re: [PATCHv2 1/3] x86/mm: Provide pmdp_establish() helper

2017-06-21 Thread Kirill A. Shutemov
On Wed, Jun 21, 2017 at 08:49:03AM -0700, Vineet Gupta wrote: > On 06/21/2017 04:27 AM, Catalin Marinas wrote: > > On Wed, Jun 21, 2017 at 12:53:03PM +0300, Kirill A. Shutemov wrote: > > > > > > > > On Thu, Jun 15, 2017 at 05:52:22PM +0300, Kirill A. Shutemov > > > > > > > > wrote: > > > > > > > >

Re: [criu] 1M guard page ruined restore

2017-06-21 Thread Oleg Nesterov
On 06/21, Oleg Nesterov wrote: > > On 06/21, Cyrill Gorcunov wrote: > > > > On Wed, Jun 21, 2017 at 05:57:30PM +0200, Oleg Nesterov wrote: > > > > > > > > p = fake_grow_down; > > > > *p-- = 'c'; > > > > > > I guess this works? I mean, *p-- = 'c' should not fail... > > > > It fails.

Re: [criu] 1M guard page ruined restore

2017-06-21 Thread Dmitry Safonov
On 06/21/2017 08:15 PM, Dmitry Safonov wrote: On 06/21/2017 08:01 PM, Oleg Nesterov wrote: On 06/21, Cyrill Gorcunov wrote: On Wed, Jun 21, 2017 at 05:57:30PM +0200, Oleg Nesterov wrote: p = fake_grow_down; *p-- = 'c'; I guess this works? I mean, *p-- = 'c' should not fail... It

Re: [PATCHv2 1/3] x86/mm: Provide pmdp_establish() helper

2017-06-21 Thread Vineet Gupta
On 06/21/2017 10:16 AM, Kirill A. Shutemov wrote: On Wed, Jun 21, 2017 at 08:49:03AM -0700, Vineet Gupta wrote: On 06/21/2017 04:27 AM, Catalin Marinas wrote: On Wed, Jun 21, 2017 at 12:53:03PM +0300, Kirill A. Shutemov wrote: On Thu, Jun 15, 2017 at 05:52:22PM +0300, Kirill A. Shutemov wrote:

Re: [kernel-hardening] [PATCH] [RFC] binfmt_elf: Use ELF_ET_DYN_BASE only for PIE

2017-06-21 Thread Kees Cook
On Wed, Jun 21, 2017 at 5:07 AM, Rik van Riel wrote: > On Tue, 2017-06-20 at 22:58 -0700, Kees Cook wrote: >> +/* This is the base location for PIE (ET_DYN with INTERP) loads. */ >> +#define ELF_ET_DYN_BASE 0x40UL > > This value is good for 32 bit binaries, but for 64 > bit binari

Re: [kernel-hardening] [PATCH] [RFC] binfmt_elf: Use ELF_ET_DYN_BASE only for PIE

2017-06-21 Thread Daniel Micay
On Wed, 2017-06-21 at 10:23 -0700, Kees Cook wrote: > On Wed, Jun 21, 2017 at 5:07 AM, Rik van Riel wrote: > > On Tue, 2017-06-20 at 22:58 -0700, Kees Cook wrote: > > > +/* This is the base location for PIE (ET_DYN with INTERP) loads. > > > */ > > > +#define ELF_ET_DYN_BASE 0x40UL

Re: [kernel-hardening] [PATCH] [RFC] binfmt_elf: Use ELF_ET_DYN_BASE only for PIE

2017-06-21 Thread Kees Cook
On Wed, Jun 21, 2017 at 10:27 AM, Daniel Micay wrote: > On Wed, 2017-06-21 at 10:23 -0700, Kees Cook wrote: >> On Wed, Jun 21, 2017 at 5:07 AM, Rik van Riel wrote: >> > On Tue, 2017-06-20 at 22:58 -0700, Kees Cook wrote: >> > > +/* This is the base location for PIE (ET_DYN with INTERP) loads. >>

Re: [PATCH V3 20/37] perf script: Add 'synth' event type for synthesized events

2017-06-21 Thread Arnaldo Carvalho de Melo
Em Wed, Jun 21, 2017 at 07:41:04PM +0300, Adrian Hunter escreveu: > On 06/21/2017 04:51 PM, Arnaldo Carvalho de Melo wrote: > > Em Wed, Jun 21, 2017 at 01:17:19PM +0300, Adrian Hunter escreveu: > >> +++ b/tools/perf/util/event.h > >> @@ -252,6 +252,9 @@ enum auxtrace_error_type { > >>PERF_A

Re: [PATCH v3 06/11] x86/mm: Rework lazy TLB mode and TLB freshness tracking

2017-06-21 Thread Borislav Petkov
On Wed, Jun 21, 2017 at 09:04:48AM -0700, Andy Lutomirski wrote: > I'll look at the end of the whole series and see if I can come up with > something good. ... along with the logic what we flush when, please. I.e., the text in struct flush_tlb_info. Thanks. -- Regards/Gruss, Boris. Good ma

Re: [criu] 1M guard page ruined restore

2017-06-21 Thread Oleg Nesterov
On 06/21, Dmitry Safonov wrote: > > The only question I have - how is it connected to guard page? Because with stack guard page do_page_fault() almost never needs to call expand_stack(), thus this check was almost never tested, I guess. Probably it should go away now. I'll write the changelog and

[PATCH v2] binfmt_elf: Use ELF_ET_DYN_BASE only for PIE

2017-06-21 Thread Kees Cook
The ELF_ET_DYN_BASE position was originally intended to keep loaders away from ET_EXEC binaries. (For example, running "/lib/ld-linux.so.2 /bin/cat" might cause the subsequent load of /bin/cat into where the loader had been loaded.) With the advent of PIE (ET_DYN binaries with an INTERP Program Hea

Re: [kernel-hardening] [PATCH] [RFC] binfmt_elf: Use ELF_ET_DYN_BASE only for PIE

2017-06-21 Thread Daniel Micay
On Wed, 2017-06-21 at 10:28 -0700, Kees Cook wrote: > On Wed, Jun 21, 2017 at 10:27 AM, Daniel Micay > wrote: > > On Wed, 2017-06-21 at 10:23 -0700, Kees Cook wrote: > > > On Wed, Jun 21, 2017 at 5:07 AM, Rik van Riel > > > wrote: > > > > On Tue, 2017-06-20 at 22:58 -0700, Kees Cook wrote: > > >

Re: [kernel-hardening] [PATCH] [RFC] binfmt_elf: Use ELF_ET_DYN_BASE only for PIE

2017-06-21 Thread Kees Cook
On Wed, Jun 21, 2017 at 10:32 AM, Daniel Micay wrote: > On Wed, 2017-06-21 at 10:28 -0700, Kees Cook wrote: >> On Wed, Jun 21, 2017 at 10:27 AM, Daniel Micay >> wrote: >> > On Wed, 2017-06-21 at 10:23 -0700, Kees Cook wrote: >> > > On Wed, Jun 21, 2017 at 5:07 AM, Rik van Riel >> > > wrote: >> >

[PATCH] kernel/sched/fair.c: Deinline update_load_avg, save 8720 bytes

2017-06-21 Thread Denys Vlasenko
This function compiles to 1378 bytes of machine code. 8 callsites. Signed-off-by: Denys Vlasenko CC: Peter Zijlstra CC: linux-kernel@vger.kernel.org --- kernel/sched/fair.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index d71109

Re: [PATCH v3 4/6] Fix read / write data offsets in read / write loops

2017-06-21 Thread Michael Sartain
On Wed, Jun 21, 2017 at 09:29:14AM -0400, Steven Rostedt wrote: > On Wed, 14 Jun 2017 18:27:59 -0600 > Michael Sartain wrote: > > > The tot variable in __do_write and do_read is incremented with the amount > > read > > / written, but subsequent times through the loop the calls continue to use >

Re: [PATCH] scripts/spelling.txt: add a bunch more spelling mistakes

2017-06-21 Thread Kees Cook
On Wed, Jun 21, 2017 at 7:26 AM, Colin King wrote: > From: Colin Ian King > > Here are some of the more spelling mistakes and typos that I've > found while fixing up spelling mistakes in kernel error message > text over the past several weeks. > > Signed-off-by: Colin Ian King Acked-by: Kees Co

Re: [PATCH V2] PM / OPP: Add dev_pm_opp_{set|put}_clkname()

2017-06-21 Thread Stephen Boyd
On 06/21, Viresh Kumar wrote: > In order to support OPP switching, OPP layer needs to get pointer to the > clock for the device. Simple cases work fine without using the routines > added by this patch (i.e. by passing connection-id as NULL), but for a > device with multiple clocks available, the O

Re: [criu] 1M guard page ruined restore

2017-06-21 Thread Dmitry Safonov
On 06/21/2017 08:31 PM, Oleg Nesterov wrote: On 06/21, Dmitry Safonov wrote: The only question I have - how is it connected to guard page? Because with stack guard page do_page_fault() almost never needs to call expand_stack(), thus this check was almost never tested, I guess. Probably it sho

Re: [PATCH] x86/uaccess: use unrolled string copy for short strings

2017-06-21 Thread Kees Cook
On Wed, Jun 21, 2017 at 4:09 AM, Paolo Abeni wrote: > The 'rep' prefix suffers for a relevant "setup cost"; as a result > string copies with unrolled loops are faster than even > optimized string copy using 'rep' variant, for short string. > > This change updates __copy_user_generic() to use the u

Re: [PATCH V2] kernel/watchdog: fix spurious hard lockups

2017-06-21 Thread Prarit Bhargava
On 06/21/2017 11:47 AM, Liang, Kan wrote: > > >> On Wed, 21 Jun 2017, kan.li...@intel.com wrote: >>> >>> #ifdef CONFIG_HARDLOCKUP_DETECTOR >>> +/* >>> + * The NMI watchdog relies on PERF_COUNT_HW_CPU_CYCLES event, >> which >>> + * can tick faster than the measured CPU Frequency due to Turbo mo

Re: [PATCH v5 27/28] ext4: xattr inode deduplication

2017-06-21 Thread Andreas Dilger
On Jun 20, 2017, at 3:49 AM, Tahsin Erdogan wrote: > > Thanks Andreas for the feedback. Please see my responses below: > >> It would be preferable to allow a mount option like "no_mbcache" to disable >> the use of shared xattrs. In the Lustre case at least, there will never be >> shared large x

Re: [PATCH v3 04/11] x86/mm: Give each mm TLB flush generation a unique ID

2017-06-21 Thread Borislav Petkov
On Tue, Jun 20, 2017 at 10:22:10PM -0700, Andy Lutomirski wrote: > - * The x86 doesn't have a mmu context, but > - * we put the segment information here. > + * x86 has arch-specific MMU state beyond what lives in mm_struct. > */ > typedef struct { > + /* > + * ctx_id uniquely identifies

Re: [PATCH v2 23/31] mbcache: make mbcache naming more generic

2017-06-21 Thread Andreas Dilger
On Jun 20, 2017, at 3:01 AM, Tahsin Erdogan wrote: > > Make names more generic so that mbcache usage is not limited to > block sharing. In a subsequent patch in the series > ("ext4: xattr inode deduplication"), we start using the mbcache code > for sharing xattr inodes. With that patch, old mb_ca

Re: [PATCH] s390/crash: Fix KEXEC_NOTE_BYTES definition

2017-06-21 Thread Michael Holzheu
Am Fri, 9 Jun 2017 10:17:05 +0800 schrieb Xunlei Pang : > S390 KEXEC_NOTE_BYTES is not used by note_buf_t as before, which > is now defined as follows: > typedef u32 note_buf_t[CRASH_CORE_NOTE_BYTES/4]; > It was changed by the CONFIG_CRASH_CORE feature. > > This patch gets rid of all the old

Re: [PATCH v2 6/6] ima: Support module-style appended signatures for appraisal

2017-06-21 Thread Thiago Jung Bauermann
Hello Mimi, Thanks for your review, and for queuing the other patches in this series. Mimi Zohar writes: > On Wed, 2017-06-07 at 22:49 -0300, Thiago Jung Bauermann wrote: >> This patch introduces the modsig keyword to the IMA policy syntax to >> specify that a given hook should expect the file

Re: [PATCH 1/5] clk: hisilicon: add usb2 clocks for hi3798cv200 SoC

2017-06-21 Thread Stephen Boyd
On 06/21, Jiancheng Xue wrote: > Add usb2 clocks for hi3798cv200 SoC. > > Signed-off-by: Jiancheng Xue > Reviewed-by: Daniel Thompson > --- Applied to clk-next -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project

[PATCH] minix: Deinline get_block, save 2691 bytes

2017-06-21 Thread Denys Vlasenko
This function compiles to 1402 bytes of machine code. It has 2 callsites, and also a not-inlined copy gets created by compiler anyway since its address gets passed as a parameter to block_truncate_page(). Signed-off-by: Denys Vlasenko CC: Al Viro CC: linux-fsde...@vger.kernel.org CC: linux-kern

Re: [PATCH] mm/hwpoison: Clear PRESENT bit for kernel 1:1 mappings of poison pages

2017-06-21 Thread Luck, Tony
On Mon, Jun 19, 2017 at 08:01:47PM +0200, Borislav Petkov wrote: > (drop stable from CC) > > You could use git's --suppress-cc= option when sending. I would if I could work out how to use it. From reading the manual page there seem to be a few options to this, but none of them appear to just drop

Re: [PATCH RFC] KVM: VMX: drop vmm_exclusive module parameter

2017-06-21 Thread Arnaldo Carvalho de Melo
Em Fri, Mar 10, 2017 at 12:47:13PM +0100, David Hildenbrand escreveu: > vmm_exclusive=0 leads to KVM setting X86_CR4_VMXE always and calling > VMXON only when the vcpu is loaded. X86_CR4_VMXE is used as an > indication in cpu_emergency_vmxoff() (called on kdump) if VMXOFF has to be > called. This i

Re: [PATCH 05/14] mwifiex: re-register wiphy across reset

2017-06-21 Thread Brian Norris
Hi Kalle (and Johannes; I'll reply to Johannes response separately too), On Mon, Jun 05, 2017 at 06:54:18PM +0300, Kalle Valo wrote: > Brian Norris writes: > > That's not to say that there aren't such bugs out there. I'd still be > > willing to bet there are. And IMO, it seems wise to just do the

Re: [PATCH] clk: uniphier: provide NAND controller clock rate

2017-06-21 Thread Stephen Boyd
On 06/21, Masahiro Yamada wrote: > This allows the NAND driver to get the clock rate via clk_get_rate(). > > Signed-off-by: Masahiro Yamada > --- Applied to clk-next -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project

Re: [PATCHv2 1/3] x86/mm: Provide pmdp_establish() helper

2017-06-21 Thread Kirill A. Shutemov
On Wed, Jun 21, 2017 at 10:20:47AM -0700, Vineet Gupta wrote: > On 06/21/2017 10:16 AM, Kirill A. Shutemov wrote: > > On Wed, Jun 21, 2017 at 08:49:03AM -0700, Vineet Gupta wrote: > > > On 06/21/2017 04:27 AM, Catalin Marinas wrote: > > > > On Wed, Jun 21, 2017 at 12:53:03PM +0300, Kirill A. Shutem

Re: net/ipv6: GPF in rt6_ifdown

2017-06-21 Thread Andrey Konovalov
On Wed, Jun 21, 2017 at 3:09 PM, Andrey Konovalov wrote: > On Wed, Jun 21, 2017 at 2:08 PM, Andrey Konovalov > wrote: >> Hi, >> >> I've got the following error report while fuzzing the kernel with syzkaller. >> >> On commit 9705596d08ac87c18aee32cc97f2783b7d14624e (4.12-rc6+). >> >> It might be

[PATCH 1/1] percpu: fix early calls for spinlock in pcpu_stats

2017-06-21 Thread Dennis Zhou
>From 2c06e795162cb306c9707ec51d3e1deadb37f573 Mon Sep 17 00:00:00 2001 From: Dennis Zhou Date: Wed, 21 Jun 2017 10:17:09 -0700 Commit 30a5b5367ef9 ("percpu: expose statistics about percpu memory via debugfs") introduces percpu memory statistics. pcpu_stats_chunk_alloc takes the spin lock and dis

Re: [criu] 1M guard page ruined restore

2017-06-21 Thread Dmitry Safonov
On 06/21/2017 08:31 PM, Oleg Nesterov wrote: On 06/21, Dmitry Safonov wrote: The only question I have - how is it connected to guard page? Because with stack guard page do_page_fault() almost never needs to call expand_stack(), thus this check was almost never tested, I guess. Probably it sho

Re: [criu] 1M guard page ruined restore

2017-06-21 Thread Cyrill Gorcunov
On Wed, Jun 21, 2017 at 07:15:45PM +0200, Oleg Nesterov wrote: > On 06/21, Oleg Nesterov wrote: > > > > On 06/21, Cyrill Gorcunov wrote: > > > > > > On Wed, Jun 21, 2017 at 05:57:30PM +0200, Oleg Nesterov wrote: > > > > > > > > > > p = fake_grow_down; > > > > > *p-- = 'c'; > > > > > > >

Re: [PATCH] mm/hwpoison: Clear PRESENT bit for kernel 1:1 mappings of poison pages

2017-06-21 Thread Luck, Tony
On Wed, Jun 21, 2017 at 02:12:27AM +, Naoya Horiguchi wrote: > We had better have a reverse operation of this to cancel the unmapping > when unpoisoning? When we have unpoisoning, we can add something. We don't seem to have an inverse function for "set_memory_np" to just flip the _PRESENT bi

Re: [PATCH 1/1] percpu: fix early calls for spinlock in pcpu_stats

2017-06-21 Thread Tejun Heo
On Wed, Jun 21, 2017 at 01:52:46PM -0400, Dennis Zhou wrote: > From 2c06e795162cb306c9707ec51d3e1deadb37f573 Mon Sep 17 00:00:00 2001 > From: Dennis Zhou > Date: Wed, 21 Jun 2017 10:17:09 -0700 > > Commit 30a5b5367ef9 ("percpu: expose statistics about percpu memory via > debugfs") introduces perc

Re: [PATCH 0/2] swait: add idle to make idle-hacks on kthreads explicit

2017-06-21 Thread Luis R. Rodriguez
On Wed, Jun 21, 2017 at 09:48:46AM -0700, Paul E. McKenney wrote: > On Tue, Jun 20, 2017 at 02:45:45PM -0700, Luis R. Rodriguez wrote: > > In this proper patch form I've made the non-timeout idle swait void. > > I've also integrated Paul's comment / ident changes, and added documentation > > as sug

[PATCH net-next 1/2] ipmr: restrict mroute "queue full" warning to related error values

2017-06-21 Thread Julien Gomes
When sending a cache report on mroute_sk, mroute will emit a "pending queue full" warning for every error value returned by sock_queue_rcv_skb(). This warning can be misleading, for example on the EPERM error value that sk_filter() can return. Restricting this warning to only ENOMEM or ENOBUFS see

[PATCH net-next 2/2] ip6mr: restrict mroute6 "queue full" warning to related error values

2017-06-21 Thread Julien Gomes
When sending a cache report on mroute6_sk, mroute6 will emit a "pending queue full" warning for every error value returned by sock_queue_rcv_skb(). This warning can be misleading, for example on the EPERM error value that sk_filter() can return. Restricting this warning to only ENOMEM or ENOBUFS s

Re: simple repro case

2017-06-21 Thread Tejun Heo
Hello, Steven. On Wed, Jun 21, 2017 at 10:24:57AM -0400, Steven Rostedt wrote: > On Sat, 17 Jun 2017 08:11:49 -0400 > Tejun Heo wrote: > > > Here's a simple rerpo. The test code runs whenever a CPU goes > > off/online. The test kthread is created on a different CPU and > > migrated to the targ

Re: [PATCH 2/2] kbuild: clang: Disable the 'duplicate-decl-specifier' warning

2017-06-21 Thread Arnd Bergmann
On Wed, Jun 21, 2017 at 6:58 PM, Matthias Kaehlcke wrote: > El Wed, Jun 21, 2017 at 12:11:55PM +0200 Arnd Bergmann ha dit: >> I see that container_of() has been modified in linux-next and no longer adds >> the 'const' keyword, do we actually still need the patch? > > There is still (at least) the

Re: [PATCH v4 20/28] ARM: owl: Implement CPU enable-method for S500

2017-06-21 Thread Arnd Bergmann
On Wed, Jun 21, 2017 at 6:48 PM, Andreas Färber wrote: > Am 21.06.2017 um 12:25 schrieb Arnd Bergmann: >> On Wed, Jun 21, 2017 at 10:16 AM, Arnd Bergmann wrote: >>> On Tue, Jun 6, 2017 at 2:54 AM, Andreas Färber wrote: Allow to bring up CPU1. Based on LeMaker linux-actions tree. >

[PATCH 02/25] perf tools: Do parameter validation earlier on fetch_kernel_version()

2017-06-21 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo While trying to reduce util.[ch] I noticed that fetch_kernel_version() and fetch_ubuntu_kernel_version() do lots of operations only to check if they are needed, i.e. it checks if the pointer where to return the kernel version is NULL only after obtaining the kernel

[PATCH 01/25] perf evsel: Adopt find_process()

2017-06-21 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo And make it static, nobody else uses it, if we ever need it in more places we can carve a new source file for process related methods, for now lets reduce util.{c,h} a tad more. Link: http://lkml.kernel.org/n/tip-zgb28rllvypjibw52aaz9...@git.kernel.org Signed-off-b

[GIT PULL 00/25] perf/core improvements and fixes

2017-06-21 Thread Arnaldo Carvalho de Melo
linux into perf/core (2017-06-20 10:49:08 +0200) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-4.13-20170621 for you to fetch changes up to 701516ae3dec801084bc913d21e03fce15c61a0b: perf script: Fix message bec

[PATCH 04/25] tools lib api fs: Add sysfs__write_int function

2017-06-21 Thread Arnaldo Carvalho de Melo
From: Kan Liang Add sysfs__write_int() to ease up writing int to sysfs. New interface is: int sysfs__write_int(const char *entry, int value); Also, introducing filename__write_int() which is useful for new helpers to write sysctl values. Signed-off-by: Kan Liang Acked-by: Jiri Olsa Cc: An

[PATCH 05/25] perf stat: Add support to measure SMI cost

2017-06-21 Thread Arnaldo Carvalho de Melo
From: Kan Liang Implementing a new --smi-cost mode in perf stat to measure SMI cost. During the measurement, the /sys/device/cpu/freeze_on_smi will be set. The measurement can be done with one counter (unhalted core cycles), and two free running MSR counters (IA32_APERF and SMI_COUNT). In prac

[PATCH 06/25] perf unwind: Support for powerpc

2017-06-21 Thread Arnaldo Carvalho de Melo
From: Paolo Bonzini Porting PPC to libdw only needs an architecture-specific hook to move the register state from perf to libdw. The ARM and x86 architectures already use libdw, and it is useful to have as much common code for the unwinder as possible. Mark Wielaard has contributed a frame-base

[PATCH 03/25] perf tools: Remove unused _ALL_SOURCE define

2017-06-21 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo Curious as to what this was for I looked at /usr/include/ and only some python headers define this, and it ends up being to enable "extensions" on some old OSes: /* Enable extensions on AIX 3, Interix */ I guess we can remove this one safely. Cc: Adrian Hunter

[PATCH 11/25] perf intel-pt: Fix last_ip usage

2017-06-21 Thread Arnaldo Carvalho de Melo
From: Adrian Hunter Intel PT uses IP compression based on the last IP. For decoding purposes, 'last IP' is considered to be reset to zero whenever there is a synchronization packet (PSB). The decoder wasn't doing that, and was treating the zero value to mean that there was no last IP, whereas com

[PATCH 19/25] perf intel-pt: Add decoder support for ptwrite and power event packets

2017-06-21 Thread Arnaldo Carvalho de Melo
From: Adrian Hunter Add decoder support for PTWRITE, MWAIT, PWRE, PWRX and EXSTOP packets. This patch only affects the decoder, so the tools still do not select or consume the new information. That is added in subsequent patches. Signed-off-by: Adrian Hunter Cc: Andi Kleen Link: http://lkml.k

[PATCH 12/25] perf intel-pt: Ensure never to set 'last_ip' when packet 'count' is zero

2017-06-21 Thread Arnaldo Carvalho de Melo
From: Adrian Hunter Intel PT uses IP compression based on the last IP. For decoding purposes, 'last IP' is not updated when a branch target has been suppressed, which is indicated by IPBytes == 0. IPBytes is stored in the packet 'count', so ensure never to set 'last_ip' when packet 'count' is zer

<    1   2   3   4   5   6   7   8   9   10   >