From: Adrian Hunter <adrian.hun...@intel.com>

Intel PT uses IP compression based on the last IP. For decoding purposes,
'last IP' is not updated when a branch target has been suppressed, which is
indicated by IPBytes == 0. IPBytes is stored in the packet 'count', so
ensure never to set 'last_ip' when packet 'count' is zero.

Signed-off-by: Adrian Hunter <adrian.hun...@intel.com>
Cc: Andi Kleen <a...@linux.intel.com>
Cc: sta...@vger.kernel.org
Link: 
http://lkml.kernel.org/r/1495786658-18063-7-git-send-email-adrian.hun...@intel.com
Signed-off-by: Arnaldo Carvalho de Melo <a...@redhat.com>
---
 tools/perf/util/intel-pt-decoder/intel-pt-decoder.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/tools/perf/util/intel-pt-decoder/intel-pt-decoder.c 
b/tools/perf/util/intel-pt-decoder/intel-pt-decoder.c
index 62e2c2ad3f1d..72b9dc8135a2 100644
--- a/tools/perf/util/intel-pt-decoder/intel-pt-decoder.c
+++ b/tools/perf/util/intel-pt-decoder/intel-pt-decoder.c
@@ -1470,7 +1470,8 @@ static int intel_pt_walk_psbend(struct intel_pt_decoder 
*decoder)
 
                case INTEL_PT_FUP:
                        decoder->pge = true;
-                       intel_pt_set_last_ip(decoder);
+                       if (decoder->packet.count)
+                               intel_pt_set_last_ip(decoder);
                        break;
 
                case INTEL_PT_MODE_TSX:
@@ -1756,8 +1757,9 @@ static int intel_pt_walk_trace(struct intel_pt_decoder 
*decoder)
 
 static inline bool intel_pt_have_ip(struct intel_pt_decoder *decoder)
 {
-       return decoder->have_last_ip || decoder->packet.count == 0 ||
-              decoder->packet.count == 3 || decoder->packet.count == 6;
+       return decoder->packet.count &&
+              (decoder->have_last_ip || decoder->packet.count == 3 ||
+               decoder->packet.count == 6);
 }
 
 /* Walk PSB+ packets to get in sync. */
-- 
2.9.4

Reply via email to