Re: [kernel-hardening] Re: [PATCH v9 1/4] syscalls: Verify address limit before returning to user-mode

2017-05-12 Thread Ingo Molnar
* Andy Lutomirski wrote: > On Tue, May 9, 2017 at 1:56 AM, Christoph Hellwig wrote: > > On Tue, May 09, 2017 at 08:45:22AM +0200, Ingo Molnar wrote: > >> We only have ~115 code blocks in the kernel that set/restore KERNEL_DS, it > >> would > >> be a pity to add a runtime check to every system

Re: [PATCH v3 1/6] drm: Add crtc/encoder/bridge->mode_valid() callbacks

2017-05-12 Thread Daniel Vetter
On Thu, May 11, 2017 at 10:05:57AM +0100, Jose Abreu wrote: > This adds a new callback to crtc, encoder and bridge helper functions > called mode_valid(). This callback shall be implemented if the > corresponding component has some sort of restriction in the modes > that can be displayed. A NULL ca

Re: [PATCH v2 2/3] sched/deadline: Throttle the task when missing its deadline

2017-05-12 Thread luca abeni
Hi, On Fri, 12 May 2017 14:53:33 +0800 Xunlei Pang wrote: > On 05/12/2017 at 01:57 PM, luca abeni wrote: > > Hi again, > > > > (sorry for the previous email; I replied from gmail and I did not > > realize I was sending it in html). > > > > > > On Fri, 12 May 2017 11:32:08 +0800 > > Xunlei Pang

Re: [alsa-devel] future of sounds/oss

2017-05-12 Thread Geert Uytterhoeven
Hi Iwai-san, On Thu, May 11, 2017 at 10:21 PM, Takashi Iwai wrote: > From: Takashi Iwai > Subject: [PATCH] sound: Disable the build of OSS drivers > > OSS drivers are left as badly unmaintained, and now we're facing a > problem to clean up the hackish set_fs() usage in their codes. Since > most

Re: [PATCH v2] sound: Disable the build of OSS drivers

2017-05-12 Thread Geert Uytterhoeven
Hi Iwai-san, On Thu, May 11, 2017 at 10:58 PM, Takashi Iwai wrote: > OSS drivers are left as badly unmaintained, and now we're facing a > problem to clean up the hackish set_fs() usage in their codes. Since > most of drivers have been covered by ALSA, and the others are dead old > and inactive,

[GIT PULL] Thermal management updates for v4.12-rc1

2017-05-12 Thread Zhang Rui
Hi, Linus, Please pull from   git://git.kernel.org/pub/scm/linux/kernel/git/rzhang/linux.git next to receive the latest Thermal Management updates for v4.12-rc1 with top-most commit cb15c81a0c1c1f7829b9809a209ecacc77f5aa63:   Merge branch 'thermal-soc' into next (2017-05-06 19:31:19 +0800) on t

Re: [PATCH] omapfb: Use devm_kcalloc() in vrfb_probe()

2017-05-12 Thread Geert Uytterhoeven
On Thu, May 11, 2017 at 5:22 PM, Bartlomiej Zolnierkiewicz wrote: > On Thursday, May 11, 2017 04:27:19 PM Bartlomiej Zolnierkiewicz wrote: > >> > @@ -358,11 +358,7 @@ static int __init vrfb_probe(struct platform_device >> > *pdev) >> > return PTR_ERR(vrfb_base); >> > >> > num_ctxs

[PATCH RFC] mnt: umount mounts one by one in umount_tree()

2017-05-12 Thread Andrei Vagin
With this patch, we don't try to umount all mounts of a tree together. Instead of this we umount them one by one. In this case, we see a significant improvement in performance for the worsе case. The reason of this optimization is that umount() can hold namespace_sem for a long time, this semaphor

Re: [PATCH 2/4] vmbus: Delete an error message for a failed memory allocation in vmbus_device_create()

2017-05-12 Thread Dan Carpenter
On Thu, May 11, 2017 at 09:30:15AM -0700, Stephen Hemminger wrote: > > diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c > > index 6802d74f162c..96328aebae5a 100644 > > --- a/drivers/hv/vmbus_drv.c > > +++ b/drivers/hv/vmbus_drv.c > > @@ -1149,7 +1149,5 @@ struct hv_device *vmbus_device_

Re: [alsa-devel] future of sounds/oss

2017-05-12 Thread Takashi Iwai
On Fri, 12 May 2017 09:03:07 +0200, Geert Uytterhoeven wrote: > > Hi Iwai-san, > > On Thu, May 11, 2017 at 10:21 PM, Takashi Iwai wrote: > > From: Takashi Iwai > > Subject: [PATCH] sound: Disable the build of OSS drivers > > > > OSS drivers are left as badly unmaintained, and now we're facing a

Re: [PATCH] parisc: fix spelling mistake: "page_tye" -> "page_type"

2017-05-12 Thread Helge Deller
On 12.05.2017 07:50, Colin King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in a pr_warn message. Thanks Colin, Interestingly, your patch is against my for-next git tree which I haven't pushed upstream yet. I'll fix it before pushing. Btw, your patch title is wrong, it sh

Re: [RFC] fix race in drivers/char/random.c:get_reg()

2017-05-12 Thread Geert Uytterhoeven
On Sun, Apr 30, 2017 at 9:49 AM, Michael Schmitz wrote: > get_reg() can be reentered on architectures with prioritized interrupts > (m68k in this case), causing f->reg_index to be incremented after the > range check. Out of bounds memory access past the pt_regs struct results. > This will go mostl

Re: [alsa-devel] future of sounds/oss

2017-05-12 Thread Geert Uytterhoeven
Hi Iwai-san, On Fri, May 12, 2017 at 9:10 AM, Takashi Iwai wrote: > On Fri, 12 May 2017 09:03:07 +0200, > Geert Uytterhoeven wrote: >> On Thu, May 11, 2017 at 10:21 PM, Takashi Iwai wrote: >> > From: Takashi Iwai >> > Subject: [PATCH] sound: Disable the build of OSS drivers >> > >> > OSS driver

Re: [PATCH v2 2/3] sched/deadline: Throttle the task when missing its deadline

2017-05-12 Thread Xunlei Pang
On 05/12/2017 at 03:01 PM, luca abeni wrote: > Hi, > > On Fri, 12 May 2017 14:53:33 +0800 > Xunlei Pang wrote: > >> On 05/12/2017 at 01:57 PM, luca abeni wrote: >>> Hi again, >>> >>> (sorry for the previous email; I replied from gmail and I did not >>> realize I was sending it in html). >>> >>> >>

Re: [kernel-hardening] Re: [PATCH v9 1/4] syscalls: Verify address limit before returning to user-mode

2017-05-12 Thread Al Viro
On Fri, May 12, 2017 at 09:00:12AM +0200, Ingo Molnar wrote: > > How about trying to remove all of them? If we could actually get rid > > of all of them, we could drop the arch support, and we'd get faster, > > simpler, shorter uaccess code throughout the kernel. > > I'm all for that! Oh, for..

Re: [PATCH] powerpc/modules: If mprofile-kernel is enabled add it to vermagic

2017-05-12 Thread Jessica Yu
+++ Michael Ellerman [10/05/17 16:57 +1000]: On powerpc we can build the kernel with two different ABIs for mcount(), which is used by ftrace. Kernels built with one ABI do not know how to load modules built with the other ABI. The new style ABI is called "mprofile-kernel", for want of a better n

Re: [PATCH 1/1] ARM: compressed/head.S: fix __nop macro rept number for ARMv7M

2017-05-12 Thread Patrice CHOTARD
Hi all It's a gentle reminder to not forgot this patch. Thanks Patrice On 04/25/2017 11:01 AM, patrice.chot...@st.com wrote: > From: Patrice Chotard > > In zImage, _magic_sig is located at offset 0x24. > But for ARMv7M architecture which enable CPU_THUMBONLY > and !EFI_STUB kernel flag, _magic

Re: [alsa-devel] future of sounds/oss

2017-05-12 Thread Takashi Iwai
On Fri, 12 May 2017 09:17:35 +0200, Geert Uytterhoeven wrote: > > Hi Iwai-san, > > On Fri, May 12, 2017 at 9:10 AM, Takashi Iwai wrote: > > On Fri, 12 May 2017 09:03:07 +0200, > > Geert Uytterhoeven wrote: > >> On Thu, May 11, 2017 at 10:21 PM, Takashi Iwai wrote: > >> > From: Takashi Iwai > >

[GIT PULL] core kernel fix

2017-05-12 Thread Ingo Molnar
Linus, Please pull the latest core-urgent-for-linus git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git core-urgent-for-linus # HEAD: 5ea30e4e58040cfd6434c2f33dc3ea76e2c15b05 stackprotector: Increase the per-task stack canary's random range from 32 bits to 64 bits on

Re: [alsa-devel] future of sounds/oss

2017-05-12 Thread Geert Uytterhoeven
Hi Iwai-san, On Fri, May 12, 2017 at 9:27 AM, Takashi Iwai wrote: > On Fri, 12 May 2017 09:17:35 +0200, > Geert Uytterhoeven wrote: >> On Fri, May 12, 2017 at 9:10 AM, Takashi Iwai wrote: >> > On Fri, 12 May 2017 09:03:07 +0200, >> > Geert Uytterhoeven wrote: >> >> On Thu, May 11, 2017 at 10:21

[GIT PULL] perf fixes

2017-05-12 Thread Ingo Molnar
Linus, Please pull the latest perf-urgent-for-linus git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git perf-urgent-for-linus # HEAD: 88b0193d9418c00340e45e0a913a0813bc6c8c96 perf/callchain: Force USER_DS when invoking perf_callchain_user() Mostly tooling updates, b

Re: [PATCH v3 0/6] Introduce new mode validation callbacks

2017-05-12 Thread Daniel Vetter
On Thu, May 11, 2017 at 10:05:56AM +0100, Jose Abreu wrote: > This series is a follow up from the discussion at [1]. We start by > introducing crtc->mode_valid(), encoder->mode_valid() and > bridge->mode_valid() callbacks which will be used in followup > patches and also by cleaning the documentati

Re: vmbus: Delete an error message for a failed memory allocation in vmbus_device_create()

2017-05-12 Thread SF Markus Elfring
>> Just because an automated tool says that this needs to change does not >> mean it has to. > > Checkpatch.pl is correct here. This message is useless. It's during > init so it's unlikely to fail ever. In current kernels small kmallocs > are quaranteed to succeed so it can't actually fail curr

Re: [PATCH v2 1/7] drm/bridge: Refactor out the panel wrapper from the lvds-encoder bridge.

2017-05-12 Thread Boris Brezillon
On Thu, 11 May 2017 11:31:22 -0700 Eric Anholt wrote: > Many DRM drivers have common code to make a stub connector > implementation that wraps a drm_panel. By wrapping the panel in a DRM > bridge, all of the connector code (including calls during encoder > enable/disable) goes away. > > v2: Fix

[GIT PULL] timer fix

2017-05-12 Thread Ingo Molnar
Linus, Please pull the latest timers-urgent-for-linus git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git timers-urgent-for-linus # HEAD: f63d947c1673930bfc5f2f9bd1073a02c179a890 clocksource/arm_arch_timer: Fix arch_timer_mem_find_best_frame() A single ARM Juno cloc

[GIT PULL] xen: fixes for 4.12-rc0

2017-05-12 Thread Juergen Gross
Linus, Please git pull the following tag: git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-4.12b-rc0c-tag xen: fixes for 4.12-rc0 It contains 2 fixes for booting under Xen introduced in 4.12 and 2 fixes for older problems, where one is just much more probable due to another

Re: [PATCH v2 7/7] drm/atmel-hlcdc: Replace the panel usage with drm_panel_bridge.

2017-05-12 Thread Daniel Vetter
On Thu, May 11, 2017 at 09:15:23PM +0200, Boris Brezillon wrote: > Hi Eric, > > On Thu, 11 May 2017 11:31:28 -0700 > Eric Anholt wrote: > > > This cuts 135 lines of boilerplate, at the cost of losing the > > filtering of get_modes() using atmel_hlcdc_dc_mode_valid(). The > > atomic check will s

[PATCH] brcmfmac: btcoex: replace init_timer with setup_timer

2017-05-12 Thread Xie Qirong
version: 4.11.0 (localversion-next is next-20170512) drivers/net/wireless/broadcom/brcm80211/brcmfmac/btcoex.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/btcoex.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/btcoex.c

Re: [kernel-hardening] Re: [PATCH v9 1/4] syscalls: Verify address limit before returning to user-mode

2017-05-12 Thread Christoph Hellwig
On Fri, May 12, 2017 at 08:15:49AM +0100, Al Viro wrote: > And converting everything to ->read_iter()/->write_iter() means an insane > amount of code churn, not to mention coping with random bogosities in > semantics. ->read() and ->write() are going to stay around, pretty > much indefinitely. Bu

Re: [PATCH 2/2] KVM: nVMX: fix nEPT handling of guest page table accesses

2017-05-12 Thread Xiao Guangrong
CC Kevin as i am not sure if Intel is aware of this issue, it breaks other hypervisors, e.g, Xen, as swell. On 05/11/2017 07:23 PM, Paolo Bonzini wrote: The new ept_access_test_paddr_read_only_ad_disabled testcase caused an infinite stream of EPT violations because KVM did not find anything bad

[GIT PULL] x86 fixes

2017-05-12 Thread Ingo Molnar
Linus, Please pull the latest x86-urgent-for-linus git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86-urgent-for-linus # HEAD: fb8fb46c56289b3f34b5d90a4ec65e9e4e4544a5 x86/intel_rdt: Fix a typo in Documentation It's mostly misc fixes: - two boot crash fixes

Re: [PATCH v7 4/5] i2c: aspeed: added driver for Aspeed I2C

2017-05-12 Thread Cédric Le Goater
Hello Brendan, [ ... ] > +static bool aspeed_i2c_master_irq(struct aspeed_i2c_bus *bus) > +{ > + u32 irq_status, status_ack = 0, command = 0; > + struct i2c_msg *msg; > + u8 recv_byte; > + > + spin_lock(&bus->lock); > + irq_status = readl(bus->base + ASPEED_I2C_INTR_STS_REG);

Re: Is there an recommended way to refer to bitkeepr commits?

2017-05-12 Thread Thomas Gleixner
On Fri, 12 May 2017, Michael Ellerman wrote: > Fixes: BKrev: 3e8e57a1JvR25MkFRNzoz85l2Gzccg ("[PATCH] > linux-2.5.66-signal-cleanup.patch") > > In your tree that is c3c107051660 ("[PATCH] > linux-2.5.66-signal-cleanup.patch"), > but you don't have the 3e8e57a1JvR25MkFRNzoz85l2Gzccg revision re

Re: [kernel-hardening] Re: [PATCH v9 1/4] syscalls: Verify address limit before returning to user-mode

2017-05-12 Thread Arnd Bergmann
On Fri, May 12, 2017 at 9:15 AM, Al Viro wrote: > On Fri, May 12, 2017 at 09:00:12AM +0200, Ingo Molnar wrote: > >> > How about trying to remove all of them? If we could actually get rid >> > of all of them, we could drop the arch support, and we'd get faster, >> > simpler, shorter uaccess code t

Re: [PATCH v3] KVM: x86: Fix potential preemption when get the current kvmclock timestamp

2017-05-12 Thread Paolo Bonzini
On 12/05/2017 03:12, Wanpeng Li wrote: > From: Wanpeng Li > > BUG: using __this_cpu_read() in preemptible [] code: > qemu-system-x86/2809 > caller is __this_cpu_preempt_check+0x13/0x20 > CPU: 2 PID: 2809 Comm: qemu-system-x86 Not tainted 4.11.0+ #13 > Call Trace: > dump_stack+0x9

Re: vmbus: Delete an error message for a failed memory allocation in vmbus_device_create()

2017-05-12 Thread Joe Perches
On Fri, 2017-05-12 at 09:32 +0200, SF Markus Elfring wrote: > Will patches be picked up also from contributors who got a special > development reputation anyhow? Yes. Developer reputation matters for somewhat controversial patches being applied as well as non-controversial and obviously correct p

Re: [PATCH v3 04/29] x86: assembly, use ENDPROC for functions

2017-05-12 Thread Jiri Slaby
On 04/26/2017, 03:42 AM, Josh Poimboeuf wrote: >> @@ -323,7 +323,7 @@ ENTRY(resume_userspace) >> movl%esp, %eax >> callprepare_exit_to_usermode >> jmp restore_all >> -END(ret_from_exception) >> +ENDPROC(ret_from_exception) > > What exactly is the motivation of this patch

Re: [PATCH 1/4] drm/vc4: Adjust modes in DSI to work around the integer PLL divider.

2017-05-12 Thread Daniel Vetter
On Thu, May 11, 2017 at 04:56:22PM -0700, Eric Anholt wrote: > BCM2835's PLLD_DSI1 divider doesn't give us many choices for our pixel > clocks, so to support panels on the Raspberry Pi we need to set a > higher pixel clock rate than requested and adjust the mode we program > to extend out the HFP s

[PATCH v3 4/9] dt-bindings: arm: mediatek: add bindings for mediatek MT7623a SoC Platform

2017-05-12 Thread sean.wang
From: Sean Wang This adds DT binding documentation for Mediatek MT7623a Signed-off-by: Sean Wang --- Documentation/devicetree/bindings/arm/mediatek.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/arm/mediatek.txt b/Documentation/devicetree/bindings/ar

[PATCH v3 0/9] arm: dts: extend mt7623 support

2017-05-12 Thread sean.wang
From: Sean Wang Changes since v2: - exclude those patches already queued into v4.11-next/dts32 - exclude those patches already sent in separation - add mt7623a SoC basic support - update binding SoC for mt7623n and relevant boards Changes since v1: Continue the upstream journey based on the prev

[PATCH v3 1/9] arm: dts: mt7623: add mt7623-mt6323.dtsi file

2017-05-12 Thread sean.wang
From: John Crispin MediaTek produces various PMICs. Which one is used depends on the actual circuit design. Instead of adding the correct PMIC node to every dts file we instead add a new intermediate dtsi file which adds the PMIC node. Additionally we also add the phandles for the regulators to v

[PATCH v3 3/9] dt-bindings: arm: mediatek: update for MT7623n SoC and relevant boards

2017-05-12 Thread sean.wang
From: Sean Wang Because there are two versions of MT7623 SoC that is MT7623a and MT7623n respectively. So update the part of MT7623n bindings to allow that people tend to differentiate which MT7623 SoC the boards applies. Signed-off-by: John Crispin Signed-off-by: Sean Wang --- Documentation/

[PATCH v3 8/9] arm: dts: mt7623: enable the nand device on the mt7623n nand rfb

2017-05-12 Thread sean.wang
From: John Crispin Enable the nand device and setup pinmux on the mt7632m rfb with nand support. Signed-off-by: John Crispin Signed-off-by: Sean Wang --- arch/arm/boot/dts/mt7623n-rfb-nand.dts | 88 ++ 1 file changed, 88 insertions(+) diff --git a/arch/arm/boo

[PATCH v3 2/9] arm: dts: mt7623: rename mt7623-evb.dts to arch/arm/boot/dts/mt7623n-rfb.dtsi

2017-05-12 Thread sean.wang
From: Sean Wang There are 2 versions of the MT7623 SoC, the one is MT7623n and the other is MT7623a. MT7623n is almost identical to MT7623a but has some additional multimedia features. The reference boards are available as NAND or MMC and might have a different ethernet setup. In order to reduce

[PATCH v3 9/9] arm: dts: mt7623: add dts file for Bananapi R2 (BPI-R2) board

2017-05-12 Thread sean.wang
From: Sean Wang Add support for the Bananapi R2 (BPI-R2) development board from BIPAI KEJI. Detailed hardware information for BPI-R2 which could be found on http://www.banana-pi.org/r2.html The patch currently only adds Mediatek GMAC, MT7530 Switch, the crypto engine, USB, IR, I2S, I2C, UART, SP

[PATCH v3 6/9] arm: dts: mt7623: cleanup the mt7623n rfb uart nodes

2017-05-12 Thread sean.wang
From: John Crispin This patch does a cleanup of the uart nodes in the dts file of the RFB. It adds aliases, enables 2 more uarts and explicitly sets the uart mode of the console. Signed-off-by: John Crispin Signed-off-by: Sean Wang --- arch/arm/boot/dts/mt7623n-rfb.dtsi | 16 +++-

[PATCH v3 5/9] ARM: mediatek: add MT7623a smp bringup code

2017-05-12 Thread sean.wang
From: Sean Wang Add support for booting secondary CPUs on MT7623a. Signed-off-by: Sean Wang --- arch/arm/mach-mediatek/mediatek.c | 2 ++ arch/arm/mach-mediatek/platsmp.c | 1 + 2 files changed, 3 insertions(+) diff --git a/arch/arm/mach-mediatek/mediatek.c b/arch/arm/mach-mediatek/mediatek

Re: [PATCH v2 0/3] irqchip/mbigen: bugfixs

2017-05-12 Thread Marc Zyngier
On 12/05/17 04:55, Hanjun Guo wrote: > From: Hanjun Guo > > Here are 3 bugfixes for mbigen: > > Patch 1 is a critical bugfix which to fix the mbigen probe failure, > commit 216646e4d82e ("irqchip/mbigen: Fix return value check in > mbigen_device_probe()") introduced this breakage; > > Patch 2 f

[PATCH v3 7/9] arm: dts: mt7623: enable the usb device on the mt7623n rfb

2017-05-12 Thread sean.wang
From: John Crispin All versions of the mt7623n RFB have an USB port so enable the device. There is a gpio that gets used to power up the port supply. Add support for this gpio using the fixed-regulator driver. Signed-off-by: John Crispin Signed-off-by: Sean Wang --- arch/arm/boot/dts/mt7623n-

Re: [alsa-devel] future of sounds/oss

2017-05-12 Thread Takashi Iwai
On Fri, 12 May 2017 09:30:04 +0200, Geert Uytterhoeven wrote: > > Hi Iwai-san, > > On Fri, May 12, 2017 at 9:27 AM, Takashi Iwai wrote: > > On Fri, 12 May 2017 09:17:35 +0200, > > Geert Uytterhoeven wrote: > >> On Fri, May 12, 2017 at 9:10 AM, Takashi Iwai wrote: > >> > On Fri, 12 May 2017 09:0

Re: [PATCH v2 2/7] drm/vc4: Switch DSI to the panel-bridge layer, and support bridges.

2017-05-12 Thread Boris Brezillon
On Thu, 11 May 2017 11:31:23 -0700 Eric Anholt wrote: > The newer version of the RPi panel driver is going to be a combination > of a bridge and a panel, but we should also support panels without a > bridge, so the panel-bridge layer lets us do that cleanly. > > v2: Drop "dev" argument. > > Sig

Re: [PATCH v2 3/7] drm/vc4: Switch DPI to using the panel-bridge helper.

2017-05-12 Thread Boris Brezillon
On Thu, 11 May 2017 11:31:24 -0700 Eric Anholt wrote: > Another 100 lines of boilerplate gone, while allowing for bridges to > be connected in the display chain. > > Signed-off-by: Eric Anholt Reviewed-by: Boris Brezillon > --- > drivers/gpu/drm/vc4/vc4_dpi.c | 164 > --

Re: [Bridge] [PATCH v2 1/2] net: Added mtu parameter to dev_forward_skb calls

2017-05-12 Thread Teco Boot
IP MTU and L2 MTU are different animals. IMHO IP MTU is for fragmentation at sender of a link. There is no need dropping IP packets at receiver with size > configured IP MTU. IP packets with size > receiver L2 MTU will be dropped at sub-IP layer. For this patch: if veth has some notion on L2 MT

[RFC v2 PATCH] x86/boot: Add the secdata section to the setup header

2017-05-12 Thread Gary Lin
A new section, secdata, in the setup header is introduced to store the distro-specific security version which is designed to help the bootloader to warn the user when loading a less secure or vulnerable kernel. The secdata section can be presented as the following: struct sec_hdr { __u16 h

[PATCH 1/1] sisusb_con: fix coccinelle warning

2017-05-12 Thread Jiri Slaby
After commit d705ff3818 (tty: vt, cleanup and document con_scroll), in the coccinelle output, we can see: drivers/usb/misc/sisusbvga/sisusb_con.c:852:8-9: WARNING: return of 0/1 in function 'sisusbcon_scroll_area' with return type bool Return true instead of 1 in the function returning bool which

Re: [PATCH v2 4/7] drm/mediatek: Use the panel-bridge helper.

2017-05-12 Thread Boris Brezillon
On Thu, 11 May 2017 11:31:25 -0700 Eric Anholt wrote: > Avoids a bunch of connector boilerplate. Note that this causes panel > prepare() to be moved before mtk_dsi_poweron() and unprepare() to be > after poweroff(). I think this is the expected usage of the panel API > (enable should be when yo

Re: [PATCH] drivers:staging:wlan-ng:hfa384x_usb: Fixing sparse warnings.

2017-05-12 Thread Greg KH
First off, why the "Re:" in the subject? Second, your subject sucks :) Try making it a bit more descriptive as to what you are doing, "fixing sparse warnings" is very vague. On Wed, May 10, 2017 at 03:15:38PM +0200, Karim Eshapa wrote: > Change the types of capture header, finally we need the he

[PATCH 1/3] mdacon: align code in mda_detect properly

2017-05-12 Thread Jiri Slaby
This is just a whitespace cleanup. The code was a mess having multiple commands on one line like: scr_writew(0xAA55, p); if (scr_readw(p) == 0xAA55) count++; Indent that properly and make it nicer for reading. Signed-off-by: Jiri Slaby Cc: Tomi Valkeinen Cc: --- drivers/video/console/mdacon.c

Re: [PATCH v3 3/3] drivers:power:twl4030-charger: remove nonstandard max_current sysfs attribute

2017-05-12 Thread H. Nikolaus Schaller
Hi Pavel, > Am 12.05.2017 um 00:35 schrieb Pavel Machek : > > On Fri 2017-04-14 20:25:57, H. Nikolaus Schaller wrote: >> Signed-off-by: H. Nikolaus Schaller > > You should explain how to obtain equivalent functionality without that > attribute. By using the standard attribute as defined here:

Re: [PATCH 1/2] PCI: dwc: kirin: add PCIe Driver for HiSilicon Kirin SoC

2017-05-12 Thread Niklas Cassel
Hello Song On 05/12/2017 03:51 AM, Song Xiaowei wrote: > From: songxiaowei > > Hisilicon PCIe Driver shares the common functions fo PCIe dw-host > > The poweron functions is developed on hi3660 SoC, while Others Functions > are common for Kirin series SoCs. > > Lowpower(L1ss and SR), hotplug a

[PATCH 2/3] mdacon: make mda_vram_base u16 *

2017-05-12 Thread Jiri Slaby
Given every user of mda_vram_base expects a pointer, let mda_vram_base be a pointer to u16. The offset calculation in mda_detect had to be adjusted by / 2 (due to different pointer arithmetic now). We introduce a cast to a value returned from VGA_MAP_MEM. But I will change VGA_MAP_MEM to return a

Re: [PATCH] staging: rtl8192u: Convert __le16 to cpu before casting to u32

2017-05-12 Thread Greg Kroah-Hartman
On Sun, May 07, 2017 at 02:56:36PM +0200, Guillaume Brogi wrote: > On Sat, Apr 08, 2017 at 08:32:36PM +0200, Guillaume Brogi wrote: > > On Sat, Apr 08, 2017 at 12:31:25PM +0200, Greg Kroah-Hartman wrote: > > > On Sun, Mar 26, 2017 at 12:24:14AM +0100, Guillaume Brogi wrote: > > > > > > > > This pa

[PATCH 3/3] mdacon: replace MDA_ADDR macro by inline function

2017-05-12 Thread Jiri Slaby
MDA_ADDR is one of those macros which could be an inline function. So convert MDA_ADDR to mda_addr. Note that we take x and y as unsigned now. But they are absolute coordinates, so this is no problem. Signed-off-by: Jiri Slaby Cc: Tomi Valkeinen Cc: --- drivers/video/console/mdacon.c | 19 +++

Re: [PATCH] mm/madvise: Dont poison entire HugeTLB page for single page errors

2017-05-12 Thread Naoya Horiguchi
On Thu, Apr 20, 2017 at 04:36:27PM +0530, Anshuman Khandual wrote: > Currently soft_offline_page() migrates the entire HugeTLB page, then > dequeues it from the active list by making it a dangling HugeTLB page > which ofcourse can not be used further and marks the entire HugeTLB > page as poisoned.

Re: [PATCH] mfd: intel_quark_i2c_gpio: Add support for SIMATIC IOT2000 platform

2017-05-12 Thread Lee Jones
On Tue, 09 May 2017, Andy Shevchenko wrote: > On Tue, 2017-05-09 at 06:40 +0200, Jan Kiszka wrote: > > The SIMATIC IOT2000 is derived from the Galileo Gen2 board and shares > > its I2C frequency. > > > > Signed-off-by: Jan Kiszka > > > Signed-off-by: Sascha Weisenberger > > Hmm... I thought t

Re: [kernel-hardening] Re: [PATCH v9 1/4] syscalls: Verify address limit before returning to user-mode

2017-05-12 Thread Christoph Hellwig
On Fri, May 12, 2017 at 09:43:40AM +0200, Arnd Bergmann wrote: > How realistic and how useful would it be to first completely eliminate > the ones that are in loadable modules and then wrapping the definition > in #ifndef MODULE (or even make it an extern function)? Should be fairly doable and mig

Re: [kernel-hardening] Re: [PATCH v9 1/4] syscalls: Verify address limit before returning to user-mode

2017-05-12 Thread Al Viro
On Fri, May 12, 2017 at 09:43:40AM +0200, Arnd Bergmann wrote: > How realistic and how useful would it be to first completely eliminate > the ones that are in loadable modules and then wrapping the definition > in #ifndef MODULE (or even make it an extern function)? Eliminate _what_? ->read() an

Re: [PATCH 3/9] VFS: Introduce a mount context

2017-05-12 Thread Miklos Szeredi
On Wed, May 10, 2017 at 3:48 PM, Jeff Layton wrote: > I was thinking that you'd need some well-defined way to tell whether the > string should be replaced. If the thing just hangs out across syscalls, > then you don't know when it got put there. Is it a leftover from a > previous syscall or did a

Re: [PATCH v2 5/7] drm/ltdc: Use the panel-bridge helper.

2017-05-12 Thread Boris Brezillon
On Thu, 11 May 2017 11:31:26 -0700 Eric Anholt wrote: > Another 100 lines of boilerplate gone. Bridges aren't supported yet, > but will be trivial to add later. > > Signed-off-by: Eric Anholt > --- > [...] > @@ -1082,28 +993,13 @@ int ltdc_load(struct drm_device *ddev) > > DRM_INFO(

Re: [kernel-hardening] Re: [PATCH v9 1/4] syscalls: Verify address limit before returning to user-mode

2017-05-12 Thread Al Viro
On Fri, May 12, 2017 at 01:11:26AM -0700, Christoph Hellwig wrote: > But it won't help against exploits modifying addr_limit manually. Or the ones setting current->cred to that of init. Your point being?

Re: [PATCH] brcmfmac: btcoex: replace init_timer with setup_timer

2017-05-12 Thread Kalle Valo
IG_BRCMFMAC_USB=y + CONFIG_BRCMFMAC_PCIE=y + CONFIG_BRCM_TRACING=y + > CONFIG_BRCMDBG=y > > Kernel version: 4.11.0 (localversion-next is next-20170512) How is this different from the first version? https://patchwork.kernel.org/patch/9709467/ Always add patch version "[PATCH v2]" and a ch

Re: [PATCH] pinctrl: when claiming hog, skip maps not served by same device

2017-05-12 Thread Nikita Yushchenko
>> +/* >> + * If pctldev is not null, we are claiming hog for it, >> + * that means, setting that is served by pctldev by itself. >> + * >> + * Thus we must skip map that is for this device but is served >> + * by other device.

Re: [kernel-hardening] Re: [PATCH v9 1/4] syscalls: Verify address limit before returning to user-mode

2017-05-12 Thread Arnd Bergmann
On Fri, May 12, 2017 at 10:11 AM, Al Viro wrote: > Anyway, what's special about modules? IDGI... One of the arguments that came up earlier was code in external modules being mostly unaudited, sometimes without any source code available at all but still used in devices. If modules can't do set_f

Re: [PATCH v2 1/8] drm: Add crtc/encoder/bridge->mode_valid() callbacks

2017-05-12 Thread Laurent Pinchart
Hi Daniel, On Wednesday 10 May 2017 10:03:37 Daniel Vetter wrote: > On Tue, May 09, 2017 at 06:00:08PM +0100, Jose Abreu wrote: > > This adds a new callback to crtc, encoder and bridge helper functions > > called mode_valid(). This callback shall be implemented if the > > corresponding component h

Re: Clarification for general change acceptance

2017-05-12 Thread SF Markus Elfring
> Developer reputation matters for somewhat controversial > patches being applied as well as non-controversial and > obviously correct patches being ignored. I am aware that there are more factors involved. > Your reputation means most all of your patches fall into > the latter category. I hope

Re: [RFC PATCH v1 00/30] fs: inode->i_version rework and optimization

2017-05-12 Thread Jan Kara
On Thu 11-05-17 14:59:43, J. Bruce Fields wrote: > On Wed, Apr 05, 2017 at 02:14:09PM -0400, J. Bruce Fields wrote: > > On Wed, Apr 05, 2017 at 10:05:51AM +0200, Jan Kara wrote: > > > 1) Keep i_version as is, make clients also check for i_ctime. > > > > That would be a protocol revision, which we'

Re: [alsa-devel] future of sounds/oss

2017-05-12 Thread John Paul Adrian Glaubitz
On Fri, May 12, 2017 at 09:27:56AM +0200, Takashi Iwai wrote: > But, looking at the tree again, I noticed that ALSA isn't built yet at > all for m68k. I don't remember why it's disabled. > Jaroslav, do you know the reason behind it? Might also just be because the m68k port had been dead in Debian

[tip:irq/urgent] irqchip/mbigen: Fix memory mapping code

2017-05-12 Thread tip-bot for Hanjun Guo
Commit-ID: 5ba9b0a14132d0b8d97affe909f324045a968d03 Gitweb: http://git.kernel.org/tip/5ba9b0a14132d0b8d97affe909f324045a968d03 Author: Hanjun Guo AuthorDate: Fri, 12 May 2017 11:55:26 +0800 Committer: Thomas Gleixner CommitDate: Fri, 12 May 2017 10:25:37 +0200 irqchip/mbigen: Fix memor

Re: [PATCH] brcmfmac: btcoex: replace init_timer with setup_timer

2017-05-12 Thread Arend van Spriel
+ CONFIG_BRCMFMAC_PCIE=y + CONFIG_BRCM_TRACING=y + CONFIG_BRCMDBG=y Kernel version: 4.11.0 (localversion-next is next-20170512) How is this different from the first version? https://patchwork.kernel.org/patch/9709467/ Hi Kalle, This is actually the third version. You are referring to the not

[tip:irq/urgent] irqchip/mbigen: Fix potential NULL dereferencing

2017-05-12 Thread tip-bot for Hanjun Guo
Commit-ID: ad7cc3c0c57d77b442db323056354d0e49833569 Gitweb: http://git.kernel.org/tip/ad7cc3c0c57d77b442db323056354d0e49833569 Author: Hanjun Guo AuthorDate: Fri, 12 May 2017 11:55:27 +0800 Committer: Thomas Gleixner CommitDate: Fri, 12 May 2017 10:25:37 +0200 irqchip/mbigen: Fix poten

Re: Clarification for general change acceptance

2017-05-12 Thread Julia Lawall
> But I will come along source code places where I am going to update details > which are also trivial. When you make a patch, you are not obliged to eliminate all of the other checkpatch warnings on the file. I don't know where you got this idea from. The submitting patch guidelines don't say t

[tip:irq/urgent] irqchip/mbigen: Fix the clear register offset calculation

2017-05-12 Thread tip-bot for MaJun
Commit-ID: 9459a04b6a5a09967eec94a1b66f0a74312819d9 Gitweb: http://git.kernel.org/tip/9459a04b6a5a09967eec94a1b66f0a74312819d9 Author: MaJun AuthorDate: Fri, 12 May 2017 11:55:28 +0800 Committer: Thomas Gleixner CommitDate: Fri, 12 May 2017 10:25:38 +0200 irqchip/mbigen: Fix the clear

Re: [kernel-locking] question about structure field initialization

2017-05-12 Thread Chris Wilson
On Thu, May 11, 2017 at 03:00:02PM -0500, Gustavo A. R. Silva wrote: > > Hello everybody, > > While looking into Coverity ID 1402035 I ran into the following > piece of code at kernel/locking/test-ww_mutex.c:197: > > 197static int test_abba(bool resolve) > 198{ > 199struct test_abba abba

Re: [PATCH 2/2] KVM: nVMX: fix nEPT handling of guest page table accesses

2017-05-12 Thread Paolo Bonzini
On 12/05/2017 09:38, Xiao Guangrong wrote: > CC Kevin as i am not sure if Intel is aware of this issue, it > breaks other hypervisors, e.g, Xen, as swell. It's actually more complicated. When EPT A/D bits are disabled, reads of the page tables behave as described in the manual; writes have both b

Attn, view attach and get back to me

2017-05-12 Thread DAVID
--- This email has been checked for viruses by Avast antivirus software. https://www.avast.com/antivirus

Re: handle_bad_irq and locking

2017-05-12 Thread Thomas Gleixner
On Thu, 11 May 2017, Gregory Fong wrote: > Hi Thomas, > > I noticed that when you changed arm irq handling to use the generic > implementation back in 2006 that you changed do_bad_IRQ() to the > following: > > +#define do_bad_IRQ(irq,desc,regs) \ > +do {

[PATCH 2/2] frv, mn10300, s390, sh: remove empty vga.h

2017-05-12 Thread Jiri Slaby
Provided the architectures do not need any special handling (they seem not to support vga at all, actually), there is no need to have an empty vga.h. Let them refer to the generic one instead. Signed-off-by: Jiri Slaby Acked-by: Geert Uytterhoeven Acked-by: Martin Schwidefsky Cc: David Howells

[PATCH 1/2] m32r, microblaze, x86, xtensa: use generic vga.h

2017-05-12 Thread Jiri Slaby
What these architectures declare is the same as what can be found in asm-generic/vga.h. So use that header instead. Signed-off-by: Jiri Slaby Acked-by: Max Filippov Cc: Michal Simek Cc: Thomas Gleixner Cc: Ingo Molnar Cc: "H. Peter Anvin" Cc: Chris Zankel Cc: x...@kernel.org Cc: linux-xte..

Re: Clarification for general change acceptance

2017-05-12 Thread SF Markus Elfring
> When you make a patch, you are not obliged to eliminate all of the other > checkpatch warnings on the file. Your view is generally fine. > I don't know where you got this idea from. I got used as a professional software developer to some approaches for reducing development warnings to some de

Re: [PATCH v5 3/3] phy: Group vendor specific phy drivers

2017-05-12 Thread Kishon Vijay Abraham I
Hi Vivek, On Thursday 11 May 2017 12:17 PM, Vivek Gautam wrote: > Adding vendor specific directories in phy to group > phy drivers under their respective vendor umbrella. > > Also updated the MAINTAINERS file to reflect the correct > directory structure for phy drivers. > > Signed-off-by: Vivek

Re: [PATCH] brcmfmac: btcoex: replace init_timer with setup_timer

2017-05-12 Thread Kalle Valo
.c:383:1-11: Use >>> setup_timer function for function on line 384. >>> >>> Patch was compile checked with: x86_64_defconfig + CONFIG_BRCMFMAC=y + >>> CONFIG_BRCMFMAC_USB=y + CONFIG_BRCMFMAC_PCIE=y + CONFIG_BRCM_TRACING=y + >>>

Re: [PATCH 1/2] staging: ccree: Fix indentation of driver_hash[] initializers

2017-05-12 Thread Greg Kroah-Hartman
On Sun, May 07, 2017 at 09:53:29PM +0200, Geert Uytterhoeven wrote: > Closing braces should match the first characters of the opening. > > Signed-off-by: Geert Uytterhoeven > --- > drivers/staging/ccree/ssi_hash.c | 28 ++-- > 1 file changed, 14 insertions(+), 14 deletion

Re: [PATCH] staging: ccree: ssi_aead.c: Fix blank lines coding style issue

2017-05-12 Thread Greg KH
On Tue, May 09, 2017 at 07:53:30PM +0300, Alex wrote: > Checkpatch emits CHECK: Please don't use multiple blank lines. > > Remove multiple blank lines. > > Signed-off-by: Alexander Mazyrin This name doesn't match your "From:" name :(

Re: [PATCH] staging: ccree: remove trailing whitespace. switch spaces to tabs

2017-05-12 Thread Greg KH
On Tue, May 09, 2017 at 11:39:56AM -0700, Connor Kelleher wrote: > ssi_fips.c: > > fixing checkpatch.pl errors: > > ERROR: trailing whitespace > + * $ > > ERROR: trailing whitespace > + * $ > > ERROR: trailing whitespace > + * $ > > ERROR: trailing whitespace > +This function returns the REE F

Re: [PATCH v5 01/10] pinctrl: generic: Add bi-directional and output-enable

2017-05-12 Thread Linus Walleij
On Tue, May 9, 2017 at 12:54 PM, Geert Uytterhoeven wrote: > The question I'm asking myself is: are these settings related to pin > configuration (i.e. depending on the use of the pin, and several settings > are valid, depending on the use case), or are they related to pinmux > (i.e. defined by t

Re: [PATCH v5 01/10] pinctrl: generic: Add bi-directional and output-enable

2017-05-12 Thread Linus Walleij
On Tue, May 9, 2017 at 12:54 PM, Geert Uytterhoeven wrote: Oops missed this: > Hence I think we should not use generic pin properties, but consider these > settings to be part of pinmux configuration. > As having large tables in the driver is undesirable, I think storing the > settings in the "p

Re: [PATCH] staging: rtl8192u: Fix type mismatch warnings reported by sparse

2017-05-12 Thread Greg KH
On Mon, May 01, 2017 at 01:19:24PM +0530, suniel.spar...@gmail.com wrote: > From: Suniel Mahesh > > The function Mk16_le() is calling le16_to_cpu() internally. > le16_to_cpu() takes an argument of type (__le *) but the argument > passed is of type (u16 *). Fixed it by passing the correct argument

Re: [PATCH] staging: rtl8192u: Fix type mismatch warnings reported by sparse

2017-05-12 Thread Greg KH
On Tue, May 09, 2017 at 03:17:56PM +0530, suniel.spar...@gmail.com wrote: > From: Suniel Mahesh > > The function Mk16_le() is calling le16_to_cpu() > internally. le16_to_cpu() takes an argument of type (__le *) > but the argument passed is of type (u16 *). Fixed it by passing > the correct argume

Re: [PATCH v2] Staging: rtl8192u: ieee80211: ieee80211_module.c: fix style issue

2017-05-12 Thread Greg KH
On Sun, May 07, 2017 at 11:01:07AM +0200, Riccardo Marotti wrote: > Fixed a brace coding style issue, found via checkpatch. > > Signed-off-by: Riccardo Marotti > --- > drivers/staging/rtl8192u/ieee80211/ieee80211_module.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) What changed fr

Re: [PATCH] staging: rtl8188eu: Fix one coding style problem

2017-05-12 Thread Greg Kroah-Hartman
On Tue, May 09, 2017 at 05:07:51PM -0700, Remco Verhoef wrote: > Fix code indent should use tabs where possible coding style > error. Your subject should be a bit better, why, "one"? please fix and resend. thanks, greg k-h

  1   2   3   4   5   6   7   >