Re: [PATCH] backlight: report error on failure

2017-02-19 Thread Daniel Thompson
On Wed, Jan 18, 2017 at 09:23:50PM +, Sudip Mukherjee wrote: > It is possible to update the backlight power and the brightness using > the sysfs and on writing it either returns the count or if the callback > function does not exist then returns the error code 'ENXIO'. > > We have a situation

[PATCH] make.cross: Update openrisc toolchain to fix builds

2017-02-19 Thread Stafford Horne
The latest openrisc kernel patchs in linux-next are failing to build due to old toolchains at the crosstool website. Update to point the the toolchain binaries released the OpenRISC team. Signed-off-by: Stafford Horne --- sbin/make.cross | 21 - 1 file changed, 20 insertions

Re: Crosstool/kbuild-all toolchain updates

2017-02-19 Thread Stafford Horne
Ping? On Wed, Feb 01, 2017 at 07:44:38AM +0900, Stafford Horne wrote: > Hi Fengguang/All, > > I am working as the OpenRISC linux kernel maintainer. Currently in > linux-next our patches are causing kbuild test robot to fail. > > This is because the patches are taking advantage of 2 'new' (2 yea

Re: [PATCH] backlight: report error on failure

2017-02-19 Thread Daniel Thompson
On Sat, Feb 18, 2017 at 04:31:43PM +, Sudip Mukherjee wrote: > On Monday 30 January 2017 11:04 PM, Sudip Mukherjee wrote: > > On Wednesday 18 January 2017 09:23 PM, Sudip Mukherjee wrote: > > > It is possible to update the backlight power and the brightness using > > > the sysfs and on writing

Re: [PATCH] proc/sysctl: prune stale dentries during unregistering

2017-02-19 Thread Al Viro
On Sat, Feb 18, 2017 at 09:55:28PM +0300, Konstantin Khlebnikov wrote: > This patch has locking problem. I've got lockdep splat under LTP. > > d_lock nests inside i_lock > sysctl_lock nests inside d_lock in d_compare > > This patch adds i_lock nesting inside sysctl_lock. Once ->unregistering is

Re: [PATCH] make.cross: Update openrisc toolchain to fix builds

2017-02-19 Thread Fengguang Wu
Applied, thank you! On Sun, Feb 19, 2017 at 05:14:36PM +0900, Stafford Horne wrote: The latest openrisc kernel patchs in linux-next are failing to build due to old toolchains at the crosstool website. Update to point the the toolchain binaries released the OpenRISC team. Signed-off-by: Staffor

Re: [PATCH 4/9] vfs: intercept reads to overlay files

2017-02-19 Thread Al Viro
On Fri, Feb 17, 2017 at 05:09:33PM +0100, Miklos Szeredi wrote: > ...in order to handle the corner case when the file is copyied up after > being opened read-only. > --- /dev/null > +++ b/fs/overlay_util.c > @@ -0,0 +1,39 @@ > +/* > + * Copyright (C) 2017 Red Hat, Inc. > + * > + * This program is

Re: [PATCH 0/9] overlay: fix inconsistency of ro file after copy-up

2017-02-19 Thread Al Viro
On Fri, Feb 17, 2017 at 05:09:29PM +0100, Miklos Szeredi wrote: > A file is opened for read-only, opened read-write (resulting in a copy up) > and modified. The data read back from the the read-only fd will be stale > in this case (the read-only file descriptor still refers to the lower, > unmodif

RE: [RFC 1/5] iwlwifi: fix drv cleanup on opmode registration failure

2017-02-19 Thread Grumbach, Emmanuel
Hi Luis, > > The firmware async callback handles the device's opmode start call, but > optionally also allows opmode registration to take care of its opmode start. > If > the firmware callback handles it its error path in case of opmode start > failure > has a few pieces of code missing from th

Re: [PATCH 4/9] vfs: intercept reads to overlay files

2017-02-19 Thread Miklos Szeredi
On Sun, Feb 19, 2017 at 10:05 AM, Al Viro wrote: > On Fri, Feb 17, 2017 at 05:09:33PM +0100, Miklos Szeredi wrote: >> ...in order to handle the corner case when the file is copyied up after >> being opened read-only. > >> --- /dev/null >> +++ b/fs/overlay_util.c >> @@ -0,0 +1,39 @@ >> +/* >> + * C

[PATCH] net: mvpp2: Fix a memory leak in error handling path

2017-02-19 Thread Christophe JAILLET
if 'devm_kzalloc()' fails, we should release resources allocated so far, just as done a few lines below. Signed-off-by: Christophe JAILLET --- drivers/net/ethernet/marvell/mvpp2.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/marvell/mvpp2.c b/dr

[PATCH] qlcnic: Fix a memory leak in error handling path

2017-02-19 Thread Christophe JAILLET
If 'dma_alloc_coherent()' fails, we should release resources allocated so far, just as done in all other cases in this function. Signed-off-by: Christophe JAILLET --- checkpatch.pl complains about '== NULL'. I have left it as-is because both '== NULL' and '!' are already used in the file. --- dr

[PATCH] fs/pstore: constify pstore_zbackend structures

2017-02-19 Thread Bhumika Goyal
The references of pstore_zbackend structures are stored into the pointer zbackend of type struct pstore_zbackend. The pointer zbackend can be made const as it is only dereferenced. After making this change the pstore_zbackend structures whose references are stored into the pointer zbackend can be m

RE: [RFC 2/5] iwlwifi: fix request_module() use

2017-02-19 Thread Grumbach, Emmanuel
> > The return value of request_module() being 0 does not mean that the driver > which was requested has loaded. To properly check that the driver was > loaded each driver can use internal mechanisms to vet the driver is now > present. The helper try_then_request_module() was added to help with >

[PATCH] mm/gup: Check for protnone only if it is a PTE entry.

2017-02-19 Thread Aneesh Kumar K.V
Do the prot_none/FOLL_NUMA check after we are sure this is a THP pte. Archs can implement prot_none such that it can return true for regular pmd entries. Signed-off-by: Aneesh Kumar K.V --- mm/gup.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/mm/gup.c b/mm/gup.c inde

[PATCH] NFC: st21nfca: Fix potential memory leak

2017-02-19 Thread Christophe JAILLET
If all bits of 'dev_mask' are already set, there is a memory leak because 'info' should be freed before returning. While fixing it, 'return -ENOMEM' directly if the first kzalloc fails. This makes the code more readable. Signed-off-by: Christophe JAILLET --- drivers/nfc/st21nfca/core.c | 12 +++

[PATCH] mm/thp/autonuma: Use TNF flag instead of vm fault.

2017-02-19 Thread Aneesh Kumar K.V
We are using wrong flag value in task_numa_falt function. This can result in us doing wrong numa fault statistics update, because we update num_pages_migrate and numa_fault_locality etc based on the flag argument passed. Signed-off-by: Aneesh Kumar K.V --- mm/huge_memory.c | 2 +- 1 file changed

Re: [PATCH 4/4] iio: accel: adxl345: Add ACPI support

2017-02-19 Thread Lars-Peter Clausen
On 02/16/2017 11:02 AM, Eva Rachel Retuya wrote: [...] > @@ -54,9 +55,17 @@ static const struct i2c_device_id adxl345_i2c_id[] = { > > MODULE_DEVICE_TABLE(i2c, adxl345_i2c_id); > > +static const struct acpi_device_id adxl345_acpi_id[] = { > + { "ADX0345", 0 }, Who allocated this ID? ADX d

[PATCH 0/7] introduce __ro_mostly_after_init section marker

2017-02-19 Thread Hoeun Ryu
After `__ro_after_init` marker is included in kernel, many kernel data objects can be read-only-after-init. But there are many other places that would be good to read-only-after-init but `__ro_after_init` can not be simply applicable to them because they should be writable at some points, which ar

[PATCH V3 3/3] powerpc/mm/autonuma: Switch ppc64 to its own implementeation of saved write

2017-02-19 Thread Aneesh Kumar K.V
With this our protnone becomes a present pte with READ/WRITE/EXEC bit cleared. By default we also set _PAGE_PRIVILEGED on such pte. This is now used to help us identify a protnone pte that as saved write bit. For such pte, we will clear the _PAGE_PRIVILEGED bit. The pte still remain non-accessible

[RFC 1/7] arch: add __ro_mostly_after_init section marker

2017-02-19 Thread Hoeun Ryu
After `__ro_after_init` marker is included in kernel, many kernel data objects can be read-only-after-init. But there are many other places that would be good to read-only-after-init but `__ro_after_init` can not be simply applicable to them because they should be writable at some points, which ar

[PATCH V3 1/3] mm/autonuma: Let architecture override how the write bit should be stashed in a protnone pte.

2017-02-19 Thread Aneesh Kumar K.V
Autonuma preserves the write permission across numa fault to avoid taking a writefault after a numa fault (Commit: b191f9b106ea " mm: numa: preserve PTE write permissions across a NUMA hinting fault"). Architecture can implement protnone in different ways and some may choose to implement that by cl

[PATCH V3 0/3] Numabalancing preserve write fix

2017-02-19 Thread Aneesh Kumar K.V
This patch series address an issue w.r.t THP migration and autonuma preserve write feature. migrate_misplaced_transhuge_page() cannot deal with concurrent modification of the page. It does a page copy without following the migration pte sequence. IIUC, this was done to keep the migration simpler an

[RFC 4/7] selinux: mark __ro_mostly_after_init for selinux_hooks/selinux_nf_ops

2017-02-19 Thread Hoeun Ryu
It would be good that selinux hooks objects are marked as `__ro_mostly_after_init`. They can not be simply marked as `__ro_after_init' because they should be writable during selinux_disable procedure. `__ro_mostly_after_init` section is temporarily read-write during selinux_disable procedure via s

[PATCH V3 2/3] mm/ksm: Handle protnone saved writes when making page write protect

2017-02-19 Thread Aneesh Kumar K.V
Without this KSM will consider the page write protected, but a numa fault can later mark the page writable. This can result in memory corruption. Signed-off-by: Aneesh Kumar K.V --- include/asm-generic/pgtable.h | 8 mm/ksm.c | 9 +++-- 2 files changed, 15 inser

[RFC 3/7] module: modify memory attrs for __ro_mostly_after_init during module_init/exit

2017-02-19 Thread Hoeun Ryu
`__ro_mostly_after_init` is almost like `__ro_after_init`. The section is read-only as same as `__ro_after_init` after kernel init. This patch makes `__ro_mostly_after_init` section read-write temporarily only during module_init/module_exit. Signed-off-by: Hoeun Ryu --- kernel/module.c | 10 +++

[RFC 5/7] cpu: mark ro_mostly_after_init for cpuhp_ap/bp_states

2017-02-19 Thread Hoeun Ryu
It would be good that `__ro_mostly_after_init` is marked to cpuhp state objects. They can not be simply marked as `__ro_after_init` because they should be writable during module_init/exit. Now that they can be read-only except during module_init/exit Signed-off-by: Hoeun Ryu --- kernel/cpu.c | 4

[RFC 2/7] init: add set_ro_mostly_after_init_rw/ro function

2017-02-19 Thread Hoeun Ryu
Add set_ro_mostly_after_init_rw/ro pair to modify memory attributes for memory marked as `ro_mostly_after_init`. I am doubtful that this is the right place where these functions reside and these functions are suitable for all architectures for memory attributes modification. Please comment. Sig

[RFC 7/7] arm64: map seperately rodata sections for __ro_mostly_after_init section

2017-02-19 Thread Hoeun Ryu
Map rodata sections seperately for the new __ro_mostly_after_init section. Attribute of memory for __ro_mostly_after_init section can be changed later so we need a dedicated vmalloced region for set_memory_rw/ro api. Signed-off-by: Hoeun Ryu --- arch/arm64/mm/mmu.c | 30 +

[RFC 6/7] arm64: add __map_kernel_segment to accept additional vm flags

2017-02-19 Thread Hoeun Ryu
Memory attribute for `__ro_mostly_after_init` section should be changed via set_memory_rw/ro that doesn't work against vm areas which don't have VM_ALLOC. Add this function to map `__ro_mostly_after_init` section with VM_ALLOC flag set in map_kernel. Signed-off-by: Hoeun Ryu --- arch/arm64/mm/m

[PATCH] ASLA: emu10k1: constify snd_emux_operators structure

2017-02-19 Thread Bhumika Goyal
Declare snd_emux_operators structure as const as it is only copied into another structure. So, snd_emux_operators structures having this property can be made const. Signed-off-by: Bhumika Goyal --- sound/pci/emu10k1/emu10k1_callback.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -

Re: [PATCH v7 2/2] mtd: nand: Add support for Arasan NAND Flash Controller

2017-02-19 Thread Boris Brezillon
Hi Punnaiah, Sorry for the late reply. On Mon, 9 Jan 2017 08:28:54 +0530 Punnaiah Choudary Kalluri wrote: > Added the basic driver for Arasan NAND Flash Controller used in > Zynq UltraScale+ MPSoC. It supports only Hw ECC and upto 24bit > correction. > > Signed-off-by: Punnaiah Choudary Kallur

[PATCH] staging: bcm2835: Fix a memory leak in error handling path

2017-02-19 Thread Christophe JAILLET
If 'kzalloc()' fails, we should release resources allocated so far, just as done in all other cases in this function. Signed-off-by: Christophe JAILLET --- Not sure that the error handling path is correct. Is 'gdev[0]' freed? Should it be? --- drivers/staging/media/platform/bcm2835/bcm2835-camer

Re: [PATCH] Staging: iio: impedance-analyzer: ad5933.c - style fix

2017-02-19 Thread Jonathan Cameron
On 12/02/17 07:22, Derek Robson wrote: > Change permissions to octal style. > Found using checkpatch > > Signed-off-by: Derek Robson Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with it. Jonathan > --- > drivers/staging/iio/impedance-analyzer/a

Re: [kernel-hardening] [PATCH 0/7] introduce __ro_mostly_after_init section marker

2017-02-19 Thread Ard Biesheuvel
Hi Hoeun, On 19 February 2017 at 10:03, Hoeun Ryu wrote: > After `__ro_after_init` marker is included in kernel, many kernel data > objects can be read-only-after-init. But there are many other places that > would be good to read-only-after-init but `__ro_after_init` can not be simply > applicab

Re: [RFC 6/7] arm64: add __map_kernel_segment to accept additional vm flags

2017-02-19 Thread Ard Biesheuvel
On 19 February 2017 at 10:04, Hoeun Ryu wrote: > Memory attribute for `__ro_mostly_after_init` section should be changed > via set_memory_rw/ro that doesn't work against vm areas which don't have > VM_ALLOC. This is for a good reason: VMALLOC regions are guaranteed to be mapped down to pages, wh

Re: [PATCH v2 1/2] staging: iio: isl29028: change sampling frequencies available to use decimals

2017-02-19 Thread Jonathan Cameron
On 12/02/17 10:55, Brian Masney wrote: > The sysfs attribute in_proximity_sampling_frequency_available currently > shows the values 1 3 5 10 13 20 83 100. These values are supposed to > correspond to the sleep values 800 400 200 100 75 50 12 0 (all in ms). > When passing in a sampling frequency of

Re: [kernel-hardening] [RFC 1/7] arch: add __ro_mostly_after_init section marker

2017-02-19 Thread Ard Biesheuvel
On 19 February 2017 at 10:04, Hoeun Ryu wrote: > After `__ro_after_init` marker is included in kernel, many kernel data > objects can be read-only-after-init. But there are many other places that > would be good to read-only-after-init but `__ro_after_init` can not be simply > applicable to them

Re: [PATCH v2 2/2] staging: iio: isl29028: move out of staging

2017-02-19 Thread Jonathan Cameron
On 12/02/17 11:04, Brian Masney wrote: > On Sun, Feb 12, 2017 at 05:55:34AM -0500, Brian Masney wrote: >> Move ISL29028 ALS / Proximity Sensor out of staging and into mainline. >> >> Signed-off-by: Brian Masney > > Sorry, Jonathan, I forgot to run git format-patch with --no-renames and > didn't r

Re: g_NCR5380 PDMA, was Re: [PATCH 0/6] ncr5380: Miscellaneous minor patches

2017-02-19 Thread Ondrej Zary
On Sunday 19 February 2017 00:27:55 Finn Thain wrote: > On Sat, 18 Feb 2017, Ondrej Zary wrote: > > On Friday 17 February 2017 23:38:12 Finn Thain wrote: > > > On Thu, 16 Feb 2017, Ondrej Zary wrote: > > > > On Tuesday 31 January 2017 02:31:45 Finn Thain wrote: > > > > [...] > > > > > > > > > Are y

Re: [PATCHv3,4/4] MAINTAINERS: Remove powerpc's opal match

2017-02-19 Thread Michael Ellerman
On Thu, 2017-02-16 at 00:37:15 UTC, Stewart Smith wrote: > Remove OPAL regex in powerpc to avoid false match > > Signed-off-by: Stewart Smith > Reviewed-by: Andrew Donnellan Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/a42715830d552d7c0e3be709383ece cheers

Re: [RFC 7/7] arm64: map seperately rodata sections for __ro_mostly_after_init section

2017-02-19 Thread Ard Biesheuvel
On 19 February 2017 at 10:04, Hoeun Ryu wrote: > Map rodata sections seperately for the new __ro_mostly_after_init section. > Attribute of memory for __ro_mostly_after_init section can be changed later > so we need a dedicated vmalloced region for set_memory_rw/ro api. > > Signed-off-by: Hoeun Ryu

RE: [PATCH] RDMA/qedr: Fix some error handling

2017-02-19 Thread Amrani, Ram
> 'qedr_alloc_pbl_tbl()' can not return NULL. > > In qedr_init_user_queue(): > - simplify the test for the return value, no need to test for NULL > - propagate the error pointer if needed, otherwise 0 (success) is returned. >This is spurious. > > In init_mr_info(): > - test the return valu

Re: [PATCH v9 1/8] drivers:input:tsc2007: add new common binding names, pre-calibration, flipping and rotation

2017-02-19 Thread H. Nikolaus Schaller
Hi Pavel, > Am 18.02.2017 um 23:54 schrieb Pavel Machek : > > On Sat 2017-02-18 20:17:09, H. Nikolaus Schaller wrote: >> >>> Am 18.02.2017 um 19:08 schrieb Pavel Machek : >>> > And I agree that kernel should _not_ attempt rescaling itself, as it > would lose precision. With a

Re: [PATCH v9 1/8] drivers:input:tsc2007: add new common binding names, pre-calibration, flipping and rotation

2017-02-19 Thread H. Nikolaus Schaller
Hi Sebastian, > Am 19.02.2017 um 00:44 schrieb Sebastian Reichel : > > Hi, > > On Sat, Feb 18, 2017 at 12:33:34PM +0100, H. Nikolaus Schaller wrote: >> Hi Sebastian, >> >>> Am 18.02.2017 um 04:22 schrieb Sebastian Reichel : >>> >>> Hi, >>> >>> On Fri, Feb 17, 2017 at 12:40:41PM -0800, Dmitry

Re: [PATCH 2/2] iio: adc: stm32: add dt option to set resolution

2017-02-19 Thread Jonathan Cameron
On 15/02/17 16:55, Fabrice Gasnier wrote: > stm32 adc supports several resolution. Add 'st,adc-res' dt optional > property to set it. Default to maximum resolution in case it isn't set. > > Signed-off-by: Fabrice Gasnier Implementation looks fine, just waiting on the binding review. Thanks, Jon

Re: [PATCH 1/2] dt-bindings: iio: stm32-adc: add option to set resolution

2017-02-19 Thread Jonathan Cameron
On 15/02/17 16:55, Fabrice Gasnier wrote: > Add documentation for 'st,adc-res' dt optional property. > > Signed-off-by: Fabrice Gasnier I'm happy with this, but would like to leave time for a device tree review. Ultimately we may well want to make this a generic property and call it something l

Re: [PATCH 4/4] iio: accel: adxl345: Add ACPI support

2017-02-19 Thread Eva Rachel Retuya
On Sun, Feb 19, 2017 at 11:01:23AM +0100, Lars-Peter Clausen wrote: > On 02/16/2017 11:02 AM, Eva Rachel Retuya wrote: > [...] > > @@ -54,9 +55,17 @@ static const struct i2c_device_id adxl345_i2c_id[] = { > > > > MODULE_DEVICE_TABLE(i2c, adxl345_i2c_id); > > > > +static const struct acpi_devic

Re: [PATCH] ASLA: emu10k1: constify snd_emux_operators structure

2017-02-19 Thread Takashi Iwai
On Sun, 19 Feb 2017 11:21:30 +0100, Bhumika Goyal wrote: > > Declare snd_emux_operators structure as const as it is only copied into > another structure. So, snd_emux_operators structures having this property > can be made const. > > Signed-off-by: Bhumika Goyal Applied now (with a typo fix in

[PATCH] HID: i2c-hid: Fix error handling

2017-02-19 Thread Christophe JAILLET
According to error handling in this function, it is likely that some resources should be freed before returning. Replace 'return ret', with 'goto err'. While at it, remove some spaces at the beginning of the lines to be more consistent. Fixes: ead0687fe304a ("HID: i2c-hid: support regulator powe

Re: [PATCH] ASLA: emu10k1: constify snd_emux_operators structure

2017-02-19 Thread Takashi Sakamoto
On Feb 19 2016 19:21, Bhumika Goyal wrote: Declare snd_emux_operators structure as const as it is only copied into another structure. So, snd_emux_operators structures having this property can be made const. Signed-off-by: Bhumika Goyal Reviewed-by: Takashi Sakamoto ...The 'ASLA' reminds me

Re: [PATCH v3 04/18] iio: adc: add support for X-Powers AXP20X and AXP22X PMICs ADCs

2017-02-19 Thread Jonathan Cameron
On 14/02/17 09:40, Quentin Schulz wrote: > The X-Powers AXP20X and AXP22X PMICs have multiple ADCs. They expose the > battery voltage, battery charge and discharge currents, AC-in and VBUS > voltages and currents, 2 GPIOs muxable in ADC mode and PMIC temperature. > > This adds support for most of

Re: [PATCH v2 4/5] iio: trigger: add support for STM32 EXTI triggers

2017-02-19 Thread Jonathan Cameron
On 17/02/17 16:05, Fabrice Gasnier wrote: > On 02/11/2017 11:29 AM, Jonathan Cameron wrote: >> On 06/02/17 16:01, Fabrice Gasnier wrote: >>> On 02/04/2017 12:39 PM, Jonathan Cameron wrote: On 03/02/17 19:40, Linus Walleij wrote: > On Mon, Jan 30, 2017 at 3:33 PM, Fabrice Gasnier > wr

Re: [Intel-wired-lan] [PATCH] e1000e: fix timing for 82579 Gigabit Ethernet controller

2017-02-19 Thread Neftin, Sasha
On 2/16/2017 20:42, Bernd Faust wrote: After an upgrade to Linux kernel v4.x the hardware timestamps of the 82579 Gigabit Ethernet Controller are different than expected. The values that are being read are almost four times as big as before the kernel upgrade. The difference is that after the up

Re: [PATCH 1/4] iio: accel: adxl345: Use I2C regmap instead of direct I2C access

2017-02-19 Thread Jonathan Cameron
On 16/02/17 10:02, Eva Rachel Retuya wrote: > Convert the driver to use regmap instead of I2C-specific functions. This > is done in preparation for splitting this driver into core and > I2C-specific code as well as introduction of SPI driver. > > Signed-off-by: Eva Rachel Retuya One minor point i

[PATCH] phy: qcom-usb-hsic: Fix error handling

2017-02-19 Thread Christophe JAILLET
According to error handling in this function, it is likely that going to 'err_ulpi' was expected here. Fixes: 605b8652f7f0 ("phy: Add support for Qualcomm's USB HSIC phy") Signed-off-by: Christophe JAILLET --- drivers/phy/phy-qcom-usb-hsic.c | 6 -- 1 file changed, 4 insertions(+), 2 delet

[PATCH] saa7134: constify nxt200x_config structures

2017-02-19 Thread Bhumika Goyal
Declare nxt200x_config structures as const as they are only passed as an argument to the function dvb_attach. dvb_attach calls its first argument on the rest of its arguments. The first argument of dvb_attach in the changed cases is nxt200x_attach and the parameter of this function to which the obj

[PATCH] b2c2: constify nxt200x_config structure

2017-02-19 Thread Bhumika Goyal
Declare nxt200x_config structure as const as it is only passed as an argument to the function dvb_attach. dvb_attach calls its first argument on the rest of its arguments. The first argument of dvb_attach in the changed case is nxt200x_attach and the parameter of this function to which the object r

Re: [PATCH 2/4] iio: accel: adxl345: Split driver into core and I2C

2017-02-19 Thread Jonathan Cameron
On 16/02/17 10:02, Eva Rachel Retuya wrote: > Move I2C-specific code into its own file and rely on regmap to access > registers. The core code provides access to x, y, z and scale readings. > > Signed-off-by: Eva Rachel Retuya A few minor comment inline. This unwound the comment about client->de

Re: [PATCH 3/4] iio: accel: adxl345: Add SPI support

2017-02-19 Thread Jonathan Cameron
On 16/02/17 10:02, Eva Rachel Retuya wrote: > Add SPI driver for initializing spi regmap for the adxl345 core driver. > The driver supports the same functionality as I2C namely the x, y, z and > scale readings. > > Signed-off-by: Eva Rachel Retuya Looks nice. I didn't know about the readmask stu

[PATCH] soc: mediatek: PMIC wrap: Fix error handling

2017-02-19 Thread Christophe JAILLET
According to error handling in this function, it is likely that going to 'err_out2' was expected here. Signed-off-by: Christophe JAILLET --- drivers/soc/mediatek/mtk-pmic-wrap.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/d

[PATCH] spi: spi-fsl-dspi: Fix error handling

2017-02-19 Thread Christophe JAILLET
According to error handling in this function, it is likely that going to 'out_master_put' was expected here. Signed-off-by: Christophe JAILLET --- drivers/spi/spi-fsl-dspi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/spi/spi-fsl-dspi.c b/drivers/spi/spi-fsl-dsp

Re: [PATCH V3 0/3] Numabalancing preserve write fix

2017-02-19 Thread Aneesh Kumar K.V
I am not sure whether we want to merge this debug patch. This will help us in identifying wrong pte_wrprotect usage in the kernel. >From a0fb302fd204159a1327b67decb8f14ffa21 Mon Sep 17 00:00:00 2001 From: "Aneesh Kumar K.V" Date: Sat, 18 Feb 2017 10:39:47 +0530 Subject: [PATCH] powerpc/auton

[PATCH] Add model data for Dell Precision 3510 trackpad.

2017-02-19 Thread John L. Preston
--- drivers/input/mouse/alps.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/input/mouse/alps.c b/drivers/input/mouse/alps.c index 328edc8c8786..c0a4edefe54d 100644 --- a/drivers/input/mouse/alps.c +++ b/drivers/input/mouse/alps.c @@ -139,6 +139,7 @@ static const struct alps_model_in

Re: Crosstool/kbuild-all toolchain updates

2017-02-19 Thread Fengguang Wu
Hi Stafford, On Wed, Feb 01, 2017 at 07:44:38AM +0900, Stafford Horne wrote: Hi Fengguang/All, I am working as the OpenRISC linux kernel maintainer. Currently in linux-next our patches are causing kbuild test robot to fail. This is because the patches are taking advantage of 2 'new' (2 year o

Re: [PATCH] tools/vm: Fix possible resource leak in page_owner_sort.c

2017-02-19 Thread walter harms
Am 19.02.2017 06:49, schrieb Saurabh Badhwar: > Fix possible resource leak in tools/vm/page_owner_sort.c > Signed-off-by: Saurabh Badhwar > --- > tools/vm/page_owner_sort.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/tools/vm/page_owner_sort.c b/tools/vm/page_o

Re: [PATCH 0/2] efi: Enhance capsule loader to support signed Quark images

2017-02-19 Thread Jan Kiszka
On 2017-02-18 13:48, Ard Biesheuvel wrote: > On 16 February 2017 at 07:29, Jan Kiszka wrote: >> On 2017-02-16 04:00, Kweh, Hock Leong wrote: -Original Message- From: Jan Kiszka [mailto:jan.kis...@siemens.com] Sent: Thursday, February 16, 2017 3:00 AM To: Andy Shevchenko

Re: [PATCH] Add model data for Dell Precision 3510 trackpad.

2017-02-19 Thread Pali Rohár
On Sunday 19 February 2017 13:16:34 John L. Preston wrote: > --- > drivers/input/mouse/alps.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/input/mouse/alps.c b/drivers/input/mouse/alps.c > index 328edc8c8786..c0a4edefe54d 100644 > --- a/drivers/input/mouse/alps.c > +++ b/drive

Re: [PATCH -v1.1] x86: Optimize clear_page()

2017-02-19 Thread Borislav Petkov
On Wed, Feb 15, 2017 at 12:19:27PM +0100, Borislav Petkov wrote: > Here's a fixed version of the breakage the 0day bot reported: > > --- > From: Borislav Petkov > Date: Thu, 9 Feb 2017 01:34:49 +0100 > Subject: [PATCH -v1.1] x86: Optimize clear_page() > > Currently, we CALL clear_page() which th

Re: [clear_page] 0ad07c8104 BUG: unable to handle kernel NULL pointer dereference at 0000000000000040

2017-02-19 Thread Borislav Petkov
On Sun, Feb 19, 2017 at 09:06:51AM +0800, Fengguang Wu wrote: > Yes if we add it as a line below the branch URL, it could be a time saver. Right. > Since it's hard to teach ALL people about the rule, it'd be best if we > can work w/o any rules -- unless you want to be accurate&helpful or to > cus

Re: [PATCH] IB/hfi1: use size_t for passing array length

2017-02-19 Thread Doug Ledford
On Tue, 2017-02-14 at 22:23 +0100, Arnd Bergmann wrote: > gcc-7 produces a mysterious warning about the size argument being > potentially out > of range: > > drivers/infiniband/hw/hfi1/verbs.c: In function 'init_cntr_names': > drivers/infiniband/hw/hfi1/verbs.c:1644:2: error: 'memcpy': specified >

Re: [PATCH] IB/hns: include linux/module.h

2017-02-19 Thread Doug Ledford
On Fri, 2017-02-17 at 15:38 +0100, Arnd Bergmann wrote: > I ran into a build error on arm64 randconfig testing: > > infiniband/hw/hns/hns_roce_main.c:539:1: error: data definition has > no type or storage class [-Werror] > infiniband/hw/hns/hns_roce_main.c:539:1: error: type defaults to > 'int' in

Re: [PATCH] RDMA/bnxt_re: add DCB dependency

2017-02-19 Thread Doug Ledford
On Fri, 2017-02-17 at 15:40 +0100, Arnd Bergmann wrote: > When CONFIG_DCB is disabled, we get a link error: > > drivers/infiniband/built-in.o: In function `bnxt_re_setup_qos': > trace.c:(.text+0x155774): undefined reference to > `dcb_ieee_getapp_mask' > trace.c:(.text+0x155774): relocation truncat

Re: [PATCH] RDMA/qedr: Fix some error handling

2017-02-19 Thread Doug Ledford
On Sat, 2017-02-18 at 12:28 +0100, Christophe JAILLET wrote: > 'qedr_alloc_pbl_tbl()' can not return NULL. > > In qedr_init_user_queue(): >  - simplify the test for the return value, no need to test for NULL >  - propagate the error pointer if needed, otherwise 0 (success) is > returned. >    This

next-20170217 boot on POWER8 LPAR : WARNING @kernel/jump_label.c:287

2017-02-19 Thread Sachin Sant
While booting next-20170217 on a POWER8 LPAR following warning is displayed. Reverting the following commit helps boot cleanly. commit 3821fd35b5 : jump_label: Reduce the size of struct static_key [ 11.393008] [ cut here ] [ 11.393031] WARNING: CPU: 5 PID: 2890 at ker

[PATCH] lightnvm: Fix error handling

2017-02-19 Thread Christophe JAILLET
According to error handling in this function, it is likely that going to 'out' was expected here. Signed-off-by: Christophe JAILLET --- drivers/lightnvm/rrpc.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/lightnvm/rrpc.c b/drivers/lightnvm/rrpc.c index e00b1d

Re: [PATCH v9 1/8] drivers:input:tsc2007: add new common binding names, pre-calibration, flipping and rotation

2017-02-19 Thread Pavel Machek
Hi! > About loosing precision: there is already noise (jitter) in > real-world devices so that you can't achieve subpixel precision > anyways (unless your panel has a very low resolution). Please see my > answer to Dmitry some mails ago. Maybe you can achieve better precision with averaging. Any

Re: Trying to understand OOM killer

2017-02-19 Thread Michal Hocko
On Sun 12-02-17 14:47:13, Paul Menzel wrote: > Dear Linux folks, > > > since some time, at Linux 4.8, 4.9, and 4.10-rc6, the OOM kicks in on a > 8 GB machine. > > ``` > Feb 12 08:21:50 asrocke350m1 kernel: updatedb.mlocat invoked oom-killer: > gfp_mask=0x16040d0(GFP_TEMPORARY|__GFP_COMP|__GFP_N

[PATCH 3/3] DT: i2c: add sht21 to trivial-devices

2017-02-19 Thread Tomasz Duszynski
Add binding for Sensirion sht21 relative humidity and temperature sensor driver. Signed-off-by: Tomasz Duszynski --- Documentation/devicetree/bindings/i2c/trivial-devices.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/i2c/trivial-devices.txt b/Document

Re: [RFC 7/8] fpga-region: add sysfs interface

2017-02-19 Thread Alan Tull
On Sat, Feb 18, 2017 at 2:45 PM, Moritz Fischer wrote: > On Sat, Feb 18, 2017 at 02:10:43PM -0600, Alan Tull wrote: >> On Sat, Feb 18, 2017 at 6:45 AM, Nadathur, Sundar >> wrote: >> >> > Hi all, >> >Interesting discussion. The discussion so far has brought out many >> > concerns such as OS i

[PATCH 1/3] iio: humidity: add sht21 relative humidity and temperature sensor driver

2017-02-19 Thread Tomasz Duszynski
Add sht21 relative humidity and temperature sensor driver. There already exists an in-kernel driver under hwmon but with limited functionality like humidity and temperature always measured together at predefined resolutions, etc. New iio driver comes without limitations of predecessor, uses non-bl

[PATCH 2/3] of: add vendor prefix for Sensirion company

2017-02-19 Thread Tomasz Duszynski
This patch adds prefix for Sensirion company. Signed-off-by: Tomasz Duszynski --- Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.t

Re: [PATCH 1/3] iio: humidity: add sht21 relative humidity and temperature sensor driver

2017-02-19 Thread Jonathan Cameron
On 19/02/17 14:58, Tomasz Duszynski wrote: > Add sht21 relative humidity and temperature sensor driver. There already > exists an in-kernel driver under hwmon but with limited functionality > like humidity and temperature always measured together at predefined > resolutions, etc. > > New iio drive

Re: [PATCH v2 1/2] iio: Allow triggers to be used as parent of others triggers

2017-02-19 Thread Jonathan Cameron
On 16/02/17 14:23, Benjamin Gaignard wrote: > Add "parent_trigger" sysfs attribute to iio trigger to be able > to set a parent to the current trigger. > Parent trigger edges or levels could be used to control current > trigger status for example to start, stop or reset it. Reset needs a description

Re: [PATCH] Add model data for Dell Precision 3510 trackpad.

2017-02-19 Thread John Preston
On 2017-02-19 13:35, Pali Rohár wrote: On Sunday 19 February 2017 13:16:34 John L. Preston wrote: --- drivers/input/mouse/alps.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/input/mouse/alps.c b/drivers/input/mouse/alps.c index 328edc8c8786..c0a4edefe54d 100644 --- a/drivers/inpu

Re: [PATCH] [RFC] drm: Nerf DRM_CONTROL nodes

2017-02-19 Thread Thomas Hellstrom
So I think we need a quick revert of this commit or a quick stable follow-up to unbreak things on our side. /Thomas On 02/19/2017 03:54 PM, Thomas Hellstrom wrote: > Hi! > > This patch breaks the vmwgfx resolutionKMS daemon which opens a control > node to tell DRM about the monitor layout... > >

Re: [Outreachy kernel] Re: [PATCH] Staging: ks7010: There should be no spaces at the start of a line

2017-02-19 Thread Julia Lawall
On Sun, 19 Feb 2017, Arushi Singhal wrote: > > Hi Greg > I think we cannot indent the text otherwise, the print statement will be > different as it should be There are newlines in the printed string. I suspect that there is no need to print them all at once. Actually, your change removed spac

Re: Hard-coding PTY device node numbers in userspace

2017-02-19 Thread Florian Weimer
* Greg KH: > On Fri, Feb 17, 2017 at 12:02:52PM +0100, Florian Weimer wrote: >> We want to reject PTY devices from other namespaces as valid input to >> the ttyname and ttyname_r functions, while still providing a hint to >> callers that the device is, in fact, a PTY. Christian Brauner wrote a >>

[PATCH] arch/x86/kernel/tsc.c : set X86_FEATURE_ART for TSC on CPUs like i7-4910MQ : bug #194609

2017-02-19 Thread Jason Vas Dias
Patch to make tsc.c set X86_FEATURE_ART and setup the TSC_ADJUST MSR correctly on my "i7-4910MQ" CPU, which reports ( boot_cpu_data.cpuid_level==0x13 && boot_cpu_data.extended_cpuid_level==0x8008 ), so the code didn't think it supported CPUID:15h, but it does . Patch: diff --git a/arch/x86

Re: [RESEND PATCH 1/1] can: m_can: fix bitrate setup on latest silicon

2017-02-19 Thread Oliver Hartkopp
Hi all, On 02/15/2017 03:08 PM, Quentin Schulz wrote: From: Florian Vallee According to the m_can user manual changelog the BTP register layout was updated with core revision 3.1.0 This change is not backward-compatible and using the current driver along with a recent IP results in an incorre

[ANNOUNCE] v4.9.11-rt9

2017-02-19 Thread Sebastian Andrzej Siewior
Dear RT folks! I'm pleased to announce the v4.9.11-rt9 patch set. Changes since v4.9.11-rt8: - rt_mutex_destroy() is EXPORT_SYMBOL_GPL again. As pointed by Peter Zijlstra, the removal of _GPL is not required. - Added a rescheduling point so we don't forget to run a runnable task at

Re: [PATCH v2 2/2] iio: stm32 trigger: Implement parent trigger feature

2017-02-19 Thread Jonathan Cameron
Hi All, Would be really helpful to get some other input on this. It's fiddly to put it lightly but if we get it right I think the interface will be useful in all sorts of common cases. On 16/02/17 14:23, Benjamin Gaignard wrote: > Add validate_trigger function in iio_trigger_ops and > dev_attr_pa

Re: Crosstool/kbuild-all toolchain updates

2017-02-19 Thread Guenter Roeck
On 02/19/2017 05:26 AM, Fengguang Wu wrote: Hi Stafford, On Wed, Feb 01, 2017 at 07:44:38AM +0900, Stafford Horne wrote: Hi Fengguang/All, I am working as the OpenRISC linux kernel maintainer. Currently in linux-next our patches are causing kbuild test robot to fail. This is because the patc

[PATCH] ocfs2: Add const to various occurrences of struct ocfs2_lock_res_ops

2017-02-19 Thread Bhumika Goyal
The field l_ops of structure ocfs2_lock_res can be made const as it never modified after getting initialized. After making this change the parameter struct ocfs2_lock_res_ops *ops of function ocfs2_lock_res_init_common can be made const as ops is only stored in l_ops. Now the structures of type ocf

Re: [PATCH 1/3] iio: humidity: add sht21 relative humidity and temperature sensor driver

2017-02-19 Thread Jonathan Cameron
On 19/02/17 15:04, Jonathan Cameron wrote: > On 19/02/17 14:58, Tomasz Duszynski wrote: >> Add sht21 relative humidity and temperature sensor driver. There already >> exists an in-kernel driver under hwmon but with limited functionality >> like humidity and temperature always measured together at p

Re: [PATCH 1/3] iio: humidity: add sht21 relative humidity and temperature sensor driver

2017-02-19 Thread Guenter Roeck
On 02/19/2017 07:04 AM, Jonathan Cameron wrote: On 19/02/17 14:58, Tomasz Duszynski wrote: Add sht21 relative humidity and temperature sensor driver. There already exists an in-kernel driver under hwmon but with limited functionality like humidity and temperature always measured together at pred

Applied "ASoC: fix ES8328_I2C/SPI dependencies" to the asoc tree

2017-02-19 Thread Mark Brown
The patch ASoC: fix ES8328_I2C/SPI dependencies has been applied to the asoc tree at git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus dur

Applied "spi: spi-ti-qspi: Fix error handling" to the spi tree

2017-02-19 Thread Mark Brown
The patch spi: spi-ti-qspi: Fix error handling has been applied to the spi tree at git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during

Applied "spi: spi-ti-qspi: Fix error handling" to the spi tree

2017-02-19 Thread Mark Brown
The patch spi: spi-ti-qspi: Fix error handling has been applied to the spi tree at git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during

Applied "ASoC: sun4i-spdif: drop unnessary snd_soc_unregister_component()" to the asoc tree

2017-02-19 Thread Mark Brown
The patch ASoC: sun4i-spdif: drop unnessary snd_soc_unregister_component() has been applied to the asoc tree at git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 h

  1   2   3   4   >