[PATCH 26/46] selinux: Improve another size determination in sens_read()

2017-01-15 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 14 Jan 2017 21:52:55 +0100 Replace the specification of a data type by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus E

[PATCH 27/46] selinux: Move an assignment for the variable "rc" in sens_read()

2017-01-15 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 14 Jan 2017 22:02:14 +0100 A local variable was set to an error code in one case before a concrete error situation was detected. Thus move the corresponding assignment into an if branch to indicate a software failure there. Signed-off-by: Markus Elfring --- secu

[PATCH 28/46] selinux: Return directly after a failed kzalloc() in user_read()

2017-01-15 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 14 Jan 2017 22:08:22 +0100 Return directly after a call of the function "kzalloc" failed at the beginning. Signed-off-by: Markus Elfring --- security/selinux/ss/policydb.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/security/selinux/ss/

[PATCH 29/46] selinux: Return directly after a failed kzalloc() in type_read()

2017-01-15 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 14 Jan 2017 22:15:54 +0100 Return directly after a call of the function "kzalloc" failed at the beginning. Signed-off-by: Markus Elfring --- security/selinux/ss/policydb.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/security/selinux/ss/

[PATCH 30/46] selinux: Return directly after a failed kzalloc() in role_read()

2017-01-15 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 14 Jan 2017 22:20:25 +0100 Return directly after a call of the function "kzalloc" failed at the beginning. Signed-off-by: Markus Elfring --- security/selinux/ss/policydb.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/security/selinux/ss/

[PATCH 31/46] selinux: Move an assignment for the variable "rc" in role_read()

2017-01-15 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 14 Jan 2017 22:25:20 +0100 A local variable was set to an error code in one case before a concrete error situation was detected. Thus move the corresponding assignment into an if branch to indicate a software failure there. Signed-off-by: Markus Elfring --- secu

[PATCH 32/46] selinux: Return directly after a failed kzalloc() in class_read()

2017-01-15 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 14 Jan 2017 22:30:51 +0100 Return directly after a call of the function "kzalloc" failed at the beginning. Signed-off-by: Markus Elfring --- security/selinux/ss/policydb.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/security/selinux/ss/

[PATCH 33/46] selinux: Move an assignment for the variable "rc" in class_read()

2017-01-15 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 15 Jan 2017 11:10:39 +0100 A local variable was set to an error code in one case before a concrete error situation was detected. Thus move the corresponding assignment into an if branch to indicate a software failure there. Signed-off-by: Markus Elfring --- secu

[PATCH 34/46] selinux: Return directly after a failed kzalloc() in common_read()

2017-01-15 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 15 Jan 2017 11:15:19 +0100 Return directly after a call of the function "kzalloc" failed at the beginning. Signed-off-by: Markus Elfring --- security/selinux/ss/policydb.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/security/selinux/ss/

[PATCH 35/46] selinux: Return directly after a failed kzalloc() in perm_read()

2017-01-15 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 15 Jan 2017 11:20:13 +0100 Return directly after a call of the function "kzalloc" failed at the beginning. Signed-off-by: Markus Elfring --- security/selinux/ss/policydb.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/security/selinux/ss/

[PATCH 36/46] selinux: Move an assignment for the variable "rc" in mls_read_range_helper()

2017-01-15 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 15 Jan 2017 11:22:23 +0100 A local variable was set to an error code in one case before a concrete error situation was detected. Thus move the corresponding assignment into an if branch to indicate a software failure there. Signed-off-by: Markus Elfring --- secu

[PATCH 37/46] selinux: Move an assignment for the variable "rc" in policydb_load_isids()

2017-01-15 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 15 Jan 2017 11:24:51 +0100 A local variable was set to an error code in one case before a concrete error situation was detected. Thus move the corresponding assignment into an if branch to indicate a software failure there. Signed-off-by: Markus Elfring --- secu

[PATCH 38/46] selinux: One function call less in five functions after null pointer detection

2017-01-15 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 15 Jan 2017 11:28:02 +0100 Call the function "kfree" at the end only after it was determined that the passed parameter contained a non-null pointer. Signed-off-by: Markus Elfring --- security/selinux/ss/policydb.c | 10 +- 1 file changed, 5 insertions(+)

[PATCH 39/46] selinux: Move two assignments for the variable "rc" in ocontext_read()

2017-01-15 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 15 Jan 2017 11:30:12 +0100 One local variable was set to an error code in two cases before a concrete error situation was detected. Thus move the corresponding assignments into if branches to indicate a software failure there. Signed-off-by: Markus Elfring --- s

[PATCH 40/46] selinux: Return directly after a failed kzalloc() in roles_init()

2017-01-15 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 15 Jan 2017 12:10:09 +0100 Return directly after a call of the function "kzalloc" failed at the beginning. Signed-off-by: Markus Elfring --- security/selinux/ss/policydb.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/security/selinux/ss/

Re: [PATCH v9 2/3] serial: exar: split out the exar code from 8250_pci

2017-01-15 Thread Andy Shevchenko
On Sun, Jan 15, 2017 at 12:50 AM, Sudip Mukherjee wrote: > From: Sudip Mukherjee > > Add the serial driver for the Exar chips. And also register the > platform device for the GPIO provided by the Exar chips. Thanks! Still v10 is needed for my opinion. See my comments below. (Telling ahead, I li

[PATCH 41/46] selinux: Move two assignments for the variable "rc" in roles_init()

2017-01-15 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 15 Jan 2017 12:40:35 +0100 One local variable was set to an error code in two cases before a concrete error situation was detected. Thus move the corresponding assignments into if branches to indicate a software failure there. Signed-off-by: Markus Elfring --- s

[PATCH 42/46] selinux: One function call less in roles_init() after error detection

2017-01-15 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 15 Jan 2017 12:56:54 +0100 The kfree() function was called in up to two cases by the roles_init() function during error handling even if the passed variable contained a null pointer. * Adjust a jump target according to the Linux coding style convention. * Delete

[PATCH 43/46] selinux: Use kmalloc_array() in sidtab_init()

2017-01-15 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 15 Jan 2017 13:13:19 +0100 A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "kmalloc_array". This issue was detected by using the Coccinelle software.

Re: [RFT PATCH] ARM64: dts: meson-gxbb: Add reserved memory zone and usable memory range

2017-01-15 Thread Andreas Färber
Am 23.12.2016 um 10:42 schrieb Heinrich Schuchardt: > it really makes a difference if we write > > memory@0 { > device_type = "memory"; > linux,usable-memory = <0x0 0x100 0x0 0x7f00>; > }; > > or > > memory@0 { > device_type = "

[PATCH 44/46] selinux: Adjust two checks for null pointers

2017-01-15 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 15 Jan 2017 13:30:20 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The script "checkpatch.pl" pointed information out like the following. Comparison to NULL could be written !… Thus fix affected source code places

[PATCH 45/46] selinux: Use common error handling code in sidtab_insert()

2017-01-15 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 15 Jan 2017 13:45:45 +0100 Add a jump target so that a bit of exception handling can be better reused at the end of this function. Signed-off-by: Markus Elfring --- security/selinux/ss/sidtab.c | 18 -- 1 file changed, 8 insertions(+), 10 deletio

Re: [PATCH v9 3/3] serial: 8250_pci: remove exar code

2017-01-15 Thread Andy Shevchenko
On Sun, Jan 15, 2017 at 12:50 AM, Sudip Mukherjee wrote: > From: Sudip Mukherjee > > Remove the Exar specific codes from 8250_pci and blacklist those chips > so that the new Exar serial driver binds to the devices. > #define UART_EXAR_MPIOINT_7_0 0x8f/* MPIOINT[7:0] */ > #define UART_EXAR

[PATCH 46/46] selinuxfs: Use seq_puts() in sel_avc_stats_seq_show()

2017-01-15 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 15 Jan 2017 14:04:53 +0100 A string which did not contain data format specifications should be put into a sequence. Thus use the corresponding function "seq_puts". This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- secur

Re: [PATCH v9 3/3] serial: 8250_pci: remove exar code

2017-01-15 Thread Andy Shevchenko
On Sun, Jan 15, 2017 at 12:50 AM, Sudip Mukherjee wrote: > From: Sudip Mukherjee > > Remove the Exar specific codes from 8250_pci and blacklist those chips > so that the new Exar serial driver binds to the devices. > Reviewed-by: Andy Shevchenko > Signed-off-by: Sudip Mukherjee > --- > drive

Re: [PATCHSET v6] blk-mq scheduling framework

2017-01-15 Thread Jens Axboe
On 01/15/2017 03:12 AM, Paolo Valente wrote: > >> Il giorno 11 gen 2017, alle ore 22:39, Jens Axboe ha scritto: >> >> Another year, another posting of this patchset. The previous posting >> was here: >> >> https://www.spinics.net/lists/kernel/msg2406106.html >> >> (yes, I've skipped v5, it was fi

Dropping device tree pinmux nodes for GPIO usage (Was: [PATCH 3/5] arm64: dts: sun50i: add MMC nodes)

2017-01-15 Thread Rask Ingemann Lambertsen
On Tue, Jan 03, 2017 at 10:52:12AM +0800, Chen-Yu Tsai wrote: > On Tue, Jan 3, 2017 at 7:03 AM, Andre Przywara wrote: > > + > > + mmc0_default_cd_pin: mmc0_cd_pin@0 { > > + pins = "PF6"; > > + function = "gpio_in"; >

Re: [PATCH] Revert "scsi: mpt3sas: Fix secure erase premature termination"

2017-01-15 Thread James Bottomley
On Sun, 2017-01-15 at 10:19 +0100, Ingo Molnar wrote: > So there's a new mpt3sas SCSI driver boot regression, introduced in > this merge window, which made one of my servers unbootable. We're not reverting a fix that would cause regressions for others. However, The fix was manifestly wrong, so

Re: [PATCH] scsi: mpt3sas: fix hang on ata passthru commands

2017-01-15 Thread James Bottomley
On Tue, 2017-01-03 at 15:46 -0500, Jason Baron wrote: > On 01/01/2017 12:39 PM, James Bottomley wrote: > > + /* > > +* Bug work around for firmware SATL handling > > +*/ > > + if (sas_device_priv_data->ata_command_pending) { > > + scmd->result = SAM_STAT_BUSY; > > +

Re: kvm: use-after-free in process_srcu

2017-01-15 Thread Dmitry Vyukov
On Fri, Jan 13, 2017 at 10:19 AM, Dmitry Vyukov wrote: > On Fri, Jan 13, 2017 at 4:30 AM, Steve Rutherford > wrote: >> I'm not that familiar with the kernel's workqueues, but this seems >> like the classic "callback outlives the memory it references" >> use-after-free, where the process_srcu call

[tip:timers/core 1/1] arch/tile/include/asm/div64.h:5:1: error: unknown type name 'u64'

2017-01-15 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git timers/core head: 9e3d6223d2093a8903c8f570a06284453ee59944 commit: 9e3d6223d2093a8903c8f570a06284453ee59944 [1/1] math64, timers: Fix 32bit mul_u64_u32_shr() and friends config: tile-allmodconfig (attached as .config) compiler:

Re: [PATCH net-next v3 07/10] net: Relocate dev_to_net_device() into core

2017-01-15 Thread Florian Fainelli
On 01/15/2017 03:07 AM, Greg KH wrote: > On Sat, Jan 14, 2017 at 01:47:10PM -0800, Florian Fainelli wrote: >> dev_to_net_device() is moved from net/dsa/dsa.c to net/core/dev.c since >> it going to be used by net/dsa/dsa2.c and the namespace of the function >> justifies making it available to othe

Re: [PATCH net-next v3 06/10] net: dsa: Migrate to device_find_class()

2017-01-15 Thread Florian Fainelli
On 01/15/2017 03:06 AM, Greg KH wrote: > On Sat, Jan 14, 2017 at 01:47:09PM -0800, Florian Fainelli wrote: >> Now that the base device driver code provides an identical >> implementation of dev_find_class() utilize device_find_class() instead >> of our own version of it. >> >> Signed-off-by: Flor

sctp: kernel memory overwrite attempt detected in sctp_getsockopt_assoc_stats

2017-01-15 Thread Dmitry Vyukov
Hello, I've enabled CONFIG_HARDENED_USERCOPY_PAGESPAN on syzkaller fuzzer and now I am seeing lots of: usercopy: kernel memory overwrite attempt detected to 8801a74f6f10 () (256 bytes) kernel BUG at mm/usercopy.c:75! invalid opcode: [#1] SMP KASAN Dumping ftrace buffer: (ftrace buffe

Re: [PATCH net-next v3 05/10] drivers: base: Add device_find_class()

2017-01-15 Thread Florian Fainelli
On 01/15/2017 03:04 AM, Greg KH wrote: > On Sat, Jan 14, 2017 at 01:47:08PM -0800, Florian Fainelli wrote: >> Add a helper function to lookup a device reference given a class name. >> This is a preliminary patch to remove adhoc code from net/dsa/dsa.c and >> make it more generic. >> >> Signed-off

[PATCH] ASoC: tegra: constify tegra30_ahub_soc_data structures

2017-01-15 Thread Bhumika Goyal
The tegra30_ahub_soc_data structures are only stored in the data field of of_device_id structures. This field is of type const, so tegra30_ahub_soc_data structures having the same property can be declared const too. File size before: sound/soc/tegra/tegra30_ahub.o textdata bss dec

Re: [PATCH net-next v3 06/10] net: dsa: Migrate to device_find_class()

2017-01-15 Thread Greg KH
On Sun, Jan 15, 2017 at 09:27:22AM -0800, Florian Fainelli wrote: > > > On 01/15/2017 03:06 AM, Greg KH wrote: > > On Sat, Jan 14, 2017 at 01:47:09PM -0800, Florian Fainelli wrote: > >> Now that the base device driver code provides an identical > >> implementation of dev_find_class() utilize devi

Re: [PATCH net-next v3 00/10] net: dsa: Support for pdata in dsa2

2017-01-15 Thread Florian Fainelli
On 01/15/2017 03:08 AM, Greg KH wrote: > On Sat, Jan 14, 2017 at 01:47:03PM -0800, Florian Fainelli wrote: >> Hi all, >> >> This is not exactly new, and was sent before, although back then, I did not >> have an user of the pre-declared MDIO board information, but now we do. Note >> that I have addi

Re: [PATCH net-next v3 07/10] net: Relocate dev_to_net_device() into core

2017-01-15 Thread Greg KH
On Sun, Jan 15, 2017 at 09:20:06AM -0800, Florian Fainelli wrote: > > > On 01/15/2017 03:07 AM, Greg KH wrote: > > On Sat, Jan 14, 2017 at 01:47:10PM -0800, Florian Fainelli wrote: > >> dev_to_net_device() is moved from net/dsa/dsa.c to net/core/dev.c since > >> it going to be used by net/dsa/dsa

Re: [PATCH resend] swiotlb: ensure that page-sized mappings are page-aligned

2017-01-15 Thread Konrad Rzeszutek Wilk
On Wed, Jan 11, 2017 at 09:56:31PM +0300, Nikita Yushchenko wrote: > Some drivers do depend on page mappings to be page aligned. > > Swiotlb already enforces such alignment for mappings greater than page, > extend that to page-sized mappings as well. > > Without this fix, nvme hits BUG() in nvme_

Re: [PATCH net-next v3 00/10] net: dsa: Support for pdata in dsa2

2017-01-15 Thread Greg KH
On Sun, Jan 15, 2017 at 09:40:24AM -0800, Florian Fainelli wrote: > On 01/15/2017 03:08 AM, Greg KH wrote: > > On Sat, Jan 14, 2017 at 01:47:03PM -0800, Florian Fainelli wrote: > >> Hi all, > >> > >> This is not exactly new, and was sent before, although back then, I did not > >> have an user of th

Re: [PATCH net-next v3 06/10] net: dsa: Migrate to device_find_class()

2017-01-15 Thread Florian Fainelli
On 01/15/2017 09:39 AM, Greg KH wrote: > On Sun, Jan 15, 2017 at 09:27:22AM -0800, Florian Fainelli wrote: >> >> >> On 01/15/2017 03:06 AM, Greg KH wrote: >>> On Sat, Jan 14, 2017 at 01:47:09PM -0800, Florian Fainelli wrote: Now that the base device driver code provides an identical imple

Re: [PATCH v3 0/5] MIPS: Add per-cpu IRQ stack

2017-01-15 Thread Jason A. Donenfeld
FYI, LEDE/OpenWRT is shipping this patchset now: https://github.com/lede-project/source/commit/1708644f1915eb7587a904d81da0ef0b559d1567

Re: [PATCH linux v2 5/6] hwmon: occ: Add hwmon implementation for the P8 OCC

2017-01-15 Thread Guenter Roeck
On 01/11/2017 10:10 AM, eajames@gmail.com wrote: From: "Edward A. James" Add code to tie the hwmon sysfs code and the POWER8 OCC code together, as well as probe the entire driver from the I2C bus. I2C is the communication method between the BMC and the P8 OCC. Signed-off-by: Edward A. Jame

Re: [PATCH linux v2 2/6] hwmon: occ: Add sysfs interface

2017-01-15 Thread Guenter Roeck
On 01/11/2017 10:10 AM, eajames@gmail.com wrote: From: "Edward A. James" Add a generic mechanism to expose the sensors provided by the OCC in sysfs. Signed-off-by: Edward A. James Signed-off-by: Andrew Jeffery --- Documentation/hwmon/occ | 62 ++ drivers/hwmon/occ/Makefil

[RFC for GIT] pull-request: add praise to people doing QA

2017-01-15 Thread Wolfram Sang
Asking for opinions on lkml and git... Getting enough quality assurance is likely one of the bigger upcoming tasks in the near future. To improve the situation, praise the people already doing that by adding their names to pull requests in the same manner that patch authors are credited. Here is a

Re: [PATCH linux v2 5/6] hwmon: occ: Add hwmon implementation for the P8 OCC

2017-01-15 Thread Guenter Roeck
On 01/11/2017 10:10 AM, eajames@gmail.com wrote: From: "Edward A. James" Add code to tie the hwmon sysfs code and the POWER8 OCC code together, as well as probe the entire driver from the I2C bus. I2C is the communication method between the BMC and the P8 OCC. Signed-off-by: Edward A. Jame

Re: [PATCH linux v2 0/6] drivers: hwmon: Add On-Chip Controller driver

2017-01-15 Thread Guenter Roeck
On 01/11/2017 10:10 AM, eajames@gmail.com wrote: From: "Edward A. James" This patchset adds a hwmon driver to support the OCC (On-Chip Controller) on the IBM POWER8 and POWER9 processors, from a BMC (Baseboard Management Controller). The OCC is an embedded processor that provides real time

[PATCH] drm: etnaviv: constify etnaviv_iommu_ops structures

2017-01-15 Thread Bhumika Goyal
Declare etnaviv_iommu_ops structure as const as it is only used when the reference of one of its field is stored in the ops field of a iommu_domain structure. This ops field is of type const, so etnaviv_iommu_ops structures having similar properties can be declared const too. Done using Coccinell

Re: [PATCH] Revert "scsi: mpt3sas: Fix secure erase premature termination"

2017-01-15 Thread Linus Torvalds
On Sun, Jan 15, 2017 at 8:11 AM, James Bottomley wrote: > > We're not reverting a fix that would cause regressions for others. Oh HELL YES we are. The rule is that we never break old stuff. Some new fix that fixes something that never used to work, but breaks something else, gets reverted very a

Re: Nokia N900: mixers changed between 4.9 and 4.10-rc3, no longer can use in-call speaker

2017-01-15 Thread Jarkko Nikula
On 01/15/2017 12:05 PM, Pavel Machek wrote: >>> So regression seems to be between v4.9 and v4.10. Any ideas? >> >> Interesting... seems there are no sound relevant changes after v4.9. >> >> Looks like there are only three commits after v4.9 for sound/soc which >> are built for Nokia N900: >> >> e4

Re: [PATCH linux v1 2/2] drivers: hwmon: hwmon driver for ASPEED AST2400/2500 PWM and Fan tach controller

2017-01-15 Thread Guenter Roeck
On 01/09/2017 01:59 PM, Jaghathiswari Rankappagounder Natarajan wrote: The ASPEED AST2400/2500 PWM controller supports 8 PWM output ports. The ASPEED AST2400/2500 Fan tach controller supports 16 tachometer inputs. PWM clock types M, N and 0 are three types just to have three independent PWM sourc

Re: [PATCH] Revert "scsi: mpt3sas: Fix secure erase premature termination"

2017-01-15 Thread James Bottomley
On Sun, 2017-01-15 at 10:54 -0800, Linus Torvalds wrote: > On Sun, Jan 15, 2017 at 8:11 AM, James Bottomley > wrote: > > > > We're not reverting a fix that would cause regressions for others. > > Oh HELL YES we are. > > The rule is that we never break old stuff. Some new fix that fixes > someth

[PATCH] char: ipmi: constify ipmi_smi_handlers structures

2017-01-15 Thread Bhumika Goyal
Declare ipmi_smi_handlers structures as const as they are only passed as an argument to the function ipmi_register_smi. This argument is of type const, so ipmi_smi_handlers structures having similar properties can be declared const too. Done using Coccinelle: @r1 disable optional_qualifier@ identi

Re: [PATCH net-next v3 06/10] net: dsa: Migrate to device_find_class()

2017-01-15 Thread Andrew Lunn
> > What exactly is the relationship between these devices (a ascii-art tree > > or sysfs tree output might be nice) so I can try to understand what is > > going on here. Hi Greg, Florian A few diagrams and trees which might help understand what is going on. The first diagram comes from the 2008

Re: [PATCH 1/1] ASoC: fsl_asrc: use dma_transfer_direction enum when calling dmaengine_prep_dma_cyclic

2017-01-15 Thread Nicolin Chen
On Sun, Jan 15, 2017 at 01:43:31PM +0100, Nicolas Iooss wrote: > When fsl_asrc_dma_prepare_and_submit() calls > dmaengine_prep_dma_cyclic(), it uses either DMA_TO_DEVICE or > DMA_FROM_DEVICE. These values are both items of dma_data_direction enum, > not of dma_data_direction enum, which is the type

Re: [PATCH] KVM: VMX: downgrade warning on unexpected exit code

2017-01-15 Thread Dmitry Vyukov
On Fri, Jan 13, 2017 at 6:59 PM, Radim Krčmář wrote: > 2017-01-02 11:23+0100, Dmitry Vyukov: >> Hello, >> >> I've got the following warning while running syzkaller fuzzer: >> >> WARNING: CPU: 2 PID: 13257 at arch/x86/kvm/vmx.c:8633 >> vmx_handle_exit+0x262b/0x38b0 arch/x86/kvm/vmx.c:8633 >> vmx: u

Re: [PATCH v6 0/5] x86: Cleanup and simplify cpu-specific data

2017-01-15 Thread Borislav Petkov
Sorry for top-posting but I'm reviving an old thread so I'm excused :-) So looking at those in my mbox, they look like nice cleanup and are not upstream. What's the story, was there a "we don't want them because ..." argument somewhere or what's up? If not, we probably should redo them and get th

Re: [PATCH] Revert "scsi: mpt3sas: Fix secure erase premature termination"

2017-01-15 Thread Linus Torvalds
On Sun, Jan 15, 2017 at 11:13 AM, James Bottomley wrote: > > Can we compromise on "try not to revert a fix ...". No. It's about timing, and about how serious the regression is. For example, if this happened in rc7, I would have reverted immediately. No questions asked. In this case, the "fix"

Re: [PATCH tip/core/rcu 2/3] srcu: Force full grace-period ordering

2017-01-15 Thread Paul E. McKenney
On Sun, Jan 15, 2017 at 10:40:58AM +0100, Ingo Molnar wrote: > > * Paul E. McKenney wrote: > > > > [sounds of rummaging around in the Git tree] > > > > > > I found this commit of yours from ancient history (more than a year ago!): > > > > > > commit 12d560f4ea87030667438a169912380be00cea4b >

Re: [PATCH] Revert "scsi: mpt3sas: Fix secure erase premature termination"

2017-01-15 Thread James Bottomley
On Sun, 2017-01-15 at 11:41 -0800, Linus Torvalds wrote: > On Sun, Jan 15, 2017 at 11:13 AM, James Bottomley > wrote: > > > > Can we compromise on "try not to revert a fix ...". > > No. > > It's about timing, and about how serious the regression is. > > For example, if this happened in rc7, I

[PATCH v5 1/8] PCI: Recognize Thunderbolt devices

2017-01-15 Thread Lukas Wunner
We're about to allow runtime PM on Thunderbolt ports in pci_bridge_d3_possible() and unblock runtime PM for Thunderbolt host hotplug ports in pci_dev_check_d3cold(). In both cases we need to uniquely identify if a PCI device belongs to a Thunderbolt controller. We also have the need to detect pre

[PATCH v5 0/8] Runtime PM for Thunderbolt on Macs

2017-01-15 Thread Lukas Wunner
Power down Thunderbolt controllers on Macs when nothing is plugged in to save around 2W per controller. For background info please see the cover letter of v3: https://lkml.org/lkml/2016/12/17/56 Patches [1/8] to [3/8] need an ack from Bjorn and/or Rafael. Patches [4/8] to [6/8] need an ack from

[PATCH v5 2/8] PCI: Allow runtime PM on Thunderbolt ports

2017-01-15 Thread Lukas Wunner
Currently PCIe ports are only allowed to go to D3 if the BIOS is dated 2015 or newer to avoid potential issues with old chipsets. However for Thunderbolt we know that even the oldest controller, Light Ridge (2010), is able to suspend its ports to D3 just fine. We're about to add runtime PM for Th

[PATCH v5 3/8] PCI: Don't block runtime PM for Thunderbolt host hotplug ports

2017-01-15 Thread Lukas Wunner
Hotplug ports generally block their parents from suspending to D3hot as otherwise their interrupts couldn't be delivered. An exception are Thunderbolt host controllers: They have a separate GPIO pin to side-band signal plug events even if the controller is powered down or its parent ports are sus

[PATCH v5 4/8] Revert "PM / Runtime: Remove the exported function pm_children_suspended()"

2017-01-15 Thread Lukas Wunner
This reverts commit 62006c1702b3b1be0c0726949e0ee0ea2326be9c which removed pm_children_suspended() because it had only a single caller. We're about to add a second caller, so establish the status quo ante. Cc: Ulf Hansson Cc: Rafael J. Wysocki Signed-off-by: Lukas Wunner --- drivers/base/power

[PATCH v5 5/8] PM: Make requirements of dev_pm_domain_set() more precise

2017-01-15 Thread Lukas Wunner
Since commit 989561de9b51 ("PM / Domains: add setter for dev.pm_domain") a PM domain may only be assigned to unbound devices. The motivation was not made explicit in the changelog other than "in the general case that can cause problems and also [...] we can simplify code quite a bit if we can alwa

[PATCH v5 6/8] PM / sleep: Define constant for direct_complete

2017-01-15 Thread Lukas Wunner
From: Chen Yu The PM core introduced the ability to keep devices runtime suspended during the entire system sleep process with commit aae4518b3124 ("PM / sleep: Mechanism to avoid resuming runtime-suspended devices unnecessarily"). Drivers opt in to this so-called "direct_complete" mechanism by

[PATCH v5 7/8] thunderbolt: Power down controller when idle

2017-01-15 Thread Lukas Wunner
Document and implement Apple's ACPI-based (but nonstandard) pm mechanism for Thunderbolt. Briefly, an ACPI method provided by Apple is used to cut power to the controller. A GPE is enabled while the controller is powered down which sideband-signals a plug event, whereupon we reinstate power using

[PATCH v5 8/8] thunderbolt: Runtime suspend NHI when idle

2017-01-15 Thread Lukas Wunner
Runtime suspend the NHI when no Thunderbolt devices have been plugged in for 10 sec (user-configurable via autosuspend_delay_ms in sysfs). The NHI is not able to detect plug events while suspended, it relies on the GPE handler to resume it on hotplug. After the NHI resumes, it takes about 700 ms

Re: [PATCH] char: ipmi: constify ipmi_smi_handlers structures

2017-01-15 Thread Corey Minyard
On 01/15/2017 01:15 PM, Bhumika Goyal wrote: Declare ipmi_smi_handlers structures as const as they are only passed as an argument to the function ipmi_register_smi. This argument is of type const, so ipmi_smi_handlers structures having similar properties can be declared const too. Done using Cocc

[GIT RFC PULL rcu/urgent] Make RCU synchronous grace periods work throughout boot

2017-01-15 Thread Paul E. McKenney
Hello, Ingo, This series contains a pair of commits that permit RCU synchronous grace periods (synchronize_rcu() and friends) to work correctly throughout boot. This eliminates the current "dead time" starting when the scheduler spawns its first taks and ending when the last of RCU's kthreads is s

Re: [PATCH] rcu: Narrow early boot window of illegal synchronous grace periods

2017-01-15 Thread Paul E. McKenney
On Sun, Jan 15, 2017 at 11:09:31AM +0100, Borislav Petkov wrote: > On Sat, Jan 14, 2017 at 09:24:43PM -0800, Paul E. McKenney wrote: > > > Which means, you probably should tag your fix CC:stable and add > > > > > > Fixes: 8b355e3bc140 ("rcu: Drive expedited grace periods from workqueue") > > > >

Re: sctp: kernel memory overwrite attempt detected in sctp_getsockopt_assoc_stats

2017-01-15 Thread Neil Horman
On Sun, Jan 15, 2017 at 06:29:59PM +0100, Dmitry Vyukov wrote: > Hello, > > I've enabled CONFIG_HARDENED_USERCOPY_PAGESPAN on syzkaller fuzzer and > now I am seeing lots of: > If I'm not mistaken, its because thats specifically what that option does. From the Kconfig: onfig HARDENED_USERCOPY_PAG

Re: [PATCH] iommu/dma: Add support for DMA_ATTR_FORCE_CONTIGUOUS

2017-01-15 Thread Laurent Pinchart
Hi Robin, On Friday 13 Jan 2017 12:17:24 Robin Murphy wrote: > On 13/01/17 11:59, Geert Uytterhoeven wrote: > > On Fri, Jan 13, 2017 at 12:32 PM, Robin Murphy wrote: > >> On 13/01/17 11:07, Geert Uytterhoeven wrote: > >>> Add support for DMA_ATTR_FORCE_CONTIGUOUS to the generic IOMMU DMA code. > >

llist code relies on undefined behaviour, upsets llvm/clang

2017-01-15 Thread Anton Blanchard
Hi, I was debugging a hang on a ppc64le kernel built with clang, and it looks to be undefined behaviour with pointer wrapping in the llist code. A test case is below. llist_for_each_entry() does container_of() on a NULL pointer, which wraps our pointer negative, then adds the same offset back in

Re: [PATCH v3 2/2] mmc: pwrseq: add support for Marvell SD8787 chip

2017-01-15 Thread Matt Ranostay
On Thu, Jan 12, 2017 at 11:16 PM, Shawn Lin wrote: > On 2017/1/13 13:29, Matt Ranostay wrote: >> >> Allow power sequencing for the Marvell SD8787 Wifi/BT chip. >> This can be abstracted to other chipsets if needed in the future. >> >> Cc: Tony Lindgren >> Cc: Ulf Hansson >> Signed-off-by: Matt R

[PATCH 2/2] ARM: dts: imx6qdl: Fix "ERROR: code indent should use tabs where possible"

2017-01-15 Thread Jagan Teki
From: Jagan Teki Fixed code indent tabs in respetcive imx6qdl dtsi files and also add space on imx6qdl-icore-rqs.dtsi on usdhc bus-width nodes. Cc: Shawn Guo Signed-off-by: Jagan Teki --- arch/arm/boot/dts/imx6qdl-gw52xx.dtsi| 2 +- arch/arm/boot/dts/imx6qdl-gw53xx.dtsi| 2 +- arch/ar

[PATCH 1/2] ARM: dts: imx6ul-isiot: Add eMMC node

2017-01-15 Thread Jagan Teki
From: Jagan Teki Add usdhc2 node, which is eMMC for Engicam Is.IoT MX6UL modules. dmesg: - mmc1: SDHCI controller on 2194000.usdhc [2194000.usdhc] using ADMA mmc1: new DDR MMC card at address 0001 mmcblk1: mmc1:0001 M62704 3.53 GiB Cc: Matteo Lisi Cc: Michael Trimarchi Cc: Signed-off-by:

Re: [PATCH] Revert "scsi: mpt3sas: Fix secure erase premature termination"

2017-01-15 Thread Bart Van Assche
On Sun, 2017-01-15 at 11:49 -0800, James Bottomley wrote: > On Sun, 2017-01-15 at 11:41 -0800, Linus Torvalds wrote: > > On Sun, Jan 15, 2017 at 11:13 AM, James Bottomley > > wrote: > > > > > > Can we compromise on "try not to revert a fix ...". > > > > No. > > > > It's about timing, and about

[PATCH] net: jme: use new api ethtool_{get|set}_link_ksettings

2017-01-15 Thread Philippe Reynes
The ethtool api {get|set}_settings is deprecated. We move this driver to new api {get|set}_link_ksettings. As I don't have the hardware, I'd be very pleased if someone may test this patch. Signed-off-by: Philippe Reynes --- drivers/net/ethernet/jme.c | 34 +- d

Re: [PATCH 0/2] Style fixes: open code obfuscating macros

2017-01-15 Thread jmrodriguezhw88
On Monday, January 2, 2017 at 5:31:15 PM UTC-8, Logan Gunthorpe wrote: > Hi, > > I had copied some poor code style from the NTB drivers into an unrelated > driver. Upon review of my new code, I learned it was not a good idea > to sweep dirty things under the rug^W macro. See [1], where Gregg k-h >

[PATCH tip/core/rcu v2 0/3] SRCU updates for 4.11

2017-01-15 Thread Paul E. McKenney
Hello! This series provides updates to SRCU: 1. This is a rewrite of the algorithm simplifying reader-count tracking. Algorithm courtesy of Mathieu Desnoyers, implementation courtesy of Lance Roy. 2. Force full grace-period ordering in SRCU. 3. Add CBMC-based for

[PATCH v2 tip/core/rcu 1/3] srcu: Implement more-efficient reader counts

2017-01-15 Thread Paul E. McKenney
From: Lance Roy SRCU uses two per-cpu counters: a nesting counter to count the number of active critical sections, and a sequence counter to ensure that the nesting counters don't change while they are being added together in srcu_readers_active_idx_check(). This patch instead uses per-cpu lock

[PATCH v2 tip/core/rcu 2/3] srcu: Force full grace-period ordering

2017-01-15 Thread Paul E. McKenney
If a process invokes synchronize_srcu(), is delayed just the right amount of time, and thus does not sleep when waiting for the grace period to complete, there is no ordering between the end of the grace period and the code following the synchronize_srcu(). Similarly, there can be a lack of orderi

[PATCH v2 tip/core/rcu 3/3] rcutorture: Add CBMC-based formal verification for SRCU

2017-01-15 Thread Paul E. McKenney
From: Lance Roy This commit creates a formal/srcu-cbmc directory containing scripts that pull SRCU in from the source code, filter it to remove things that CBMC cannot handle, and run a series of verifications on it. This has a number of shortcomings: 1. It does not yet hook into the upper

[PATCH] partitions/efi: Fix integer overflow in GPT size calculation

2017-01-15 Thread Alden Tondettar
If a GUID Partition Table claims to have more than 2**25 entries, the calculation of the partition table size in alloc_read_gpt_entries() will overflow a 32-bit integer and not enough space will be allocated for the table. Nothing seems to get written out of bounds, but later efi_partition() will

Re: [tip:sched/core] locking/mutex, sched/wait: Fix the mutex_lock_io_nested() define

2017-01-15 Thread Tejun Heo
On Sun, Jan 15, 2017 at 01:26:16AM -0800, tip-bot for Ingo Molnar wrote: > Commit-ID: f21860bac05b609d71757338361d26209ff0759b > Gitweb: http://git.kernel.org/tip/f21860bac05b609d71757338361d26209ff0759b > Author: Ingo Molnar > AuthorDate: Sat, 14 Jan 2017 17:11:36 +0100 > Committer: Ing

Re: [PATCH 04/10] sata: hardreset: retry if phys link is down

2017-01-15 Thread Tejun Heo
Hello, On Fri, Jan 13, 2017 at 01:37:58PM +0100, Bartosz Golaszewski wrote: > The sata core driver already retries to resume the link because some > controllers ignore writes to the SControl register. > > We have a use case with the da850 SATA controller where at PLL0 > frequency of 456MHz (neede

Re: [PATCH 06/10] sata: ahci_da850: implement a softreset quirk

2017-01-15 Thread Tejun Heo
On Fri, Jan 13, 2017 at 01:38:00PM +0100, Bartosz Golaszewski wrote: > +static int ahci_da850_softreset(struct ata_link *link, > + unsigned int *class, unsigned long deadline) > +{ > + int pmp, ret; > + > + pmp = sata_srst_pmp(link); > + > + ret = ahci_do_sof

Re: [PATCH] Input: cyapa_gen3: use msleep() for long delay

2017-01-15 Thread Dmitry Torokhov
On Sun, Jan 15, 2017 at 12:13:07PM +0100, Nicholas Mc Guire wrote: > ulseep_range() uses hrtimers and provides no advantage over msleep() > for larger delays. Fix up the 50ms delays here to use msleep() and > reduce the load on the hrtimer subsystem. > > Signed-off-by: Nicholas Mc Guire Applied

Re: [PATCH RFC V2] Input: cyapa: use time based retry loop

2017-01-15 Thread Dmitry Torokhov
On Sun, Jan 15, 2017 at 12:12:38PM +0100, Nicholas Mc Guire wrote: > Using counter based retry loops for peripherals results in the delay > being significantly overrun during high-load situations where delay > functions tend to be vary imprecise and overrun there timeouts. So > condition the termin

Re: [PATCH] Input: synaptics-rmi4 - make F03 a tristate symbol

2017-01-15 Thread Dmitry Torokhov
On Sat, Jan 14, 2017 at 01:09:57PM +0100, Arnd Bergmann wrote: > On Jan 13, 2017 10:42 PM, "Dmitry Torokhov" wrote: > > On Fri, Jan 13, 2017 at 10:34:32PM +0100, Arnd Bergmann wrote: > > > config RMI4_F03_SERIO > > >tristate > > >depends on RMI4_CORE > > >depends on RMI4_F0

Re: [PATCH 0/3] ti,ads7950 device tree bindings

2017-01-15 Thread David Lechner
On 01/15/2017 07:58 AM, Jonathan Cameron wrote: On 11/01/17 17:52, David Lechner wrote: This series adds device tree bindings for the TI ADS7950 family of A/DC chips. The series includes the bindings documentation and some fixes to the iio driver to make it work with the device tree bindings. F

[PATCH 0/6] ncr5380: Miscellaneous minor patches

2017-01-15 Thread Finn Thain
This series removes some unused code and related comments, addresses the warnings generated by 'make W=1' and 'make C=1' and fixes a theoretical bug in the bus reset method in atari_scsi. There's also a patch to add a missing error check during target selection. The only target I tested was a QUAN

[PATCH 4/6] ncr5380: Resolve various static checker warnings

2017-01-15 Thread Finn Thain
Avoid various warnings from "make C=1" by annotating a couple of unlock-then-lock sequences, replacing a zero with NULL and correcting some type casts. Also avoid a warning from "make W=1" by adding braces. Signed-off-by: Finn Thain --- These are the warning messages referred to above: drivers/

[PATCH 2/6] ncr5380: Clean up dead code and redundant macro usage

2017-01-15 Thread Finn Thain
Remove dead code inside #if 0 conditionals. Remove the #ifdef __KERNEL__ test, since NCR5380.h has no definitions that relate to userspace code. Remove two redundant macro definitions which were overlooked in commit e9db3198e08b ("sun3_scsi: Adopt NCR5380.c core driver"). Signed-off-by: Finn Tha

[PATCH 6/6] atari_scsi: Reset DMA during bus reset only under ST-DMA lock

2017-01-15 Thread Finn Thain
The atari_scsi driver should not access Falcon DMA chip registers unless it has acquired exclusive access to that chip. If the driver doesn't have exclusive access then there's no need for a DMA reset as there are no scsi commands in progress. Signed-off-by: Finn Thain --- drivers/scsi/atari_scs

[PATCH 5/6] ncr5380: Improve target selection robustness

2017-01-15 Thread Finn Thain
Handle timeout or bus phase change errors that could occur when sending the IDENTIFY message. Signed-off-by: Finn Thain --- drivers/scsi/NCR5380.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/NCR5380.c b/drivers/scsi/NCR5380.c index 518d101..acc3344

[PATCH 1/6] ncr5380: Shorten host info string by removing unused option macros

2017-01-15 Thread Finn Thain
The DIFFERENTIAL and PARITY option macros are unused: no supported hardware uses differential signalling and the core driver never implemented parity checking. These options just waste space in the host info string. While we are here, fix a typo in the NCR5380_info() kernel-doc comment. Signed-of

<    1   2   3   4   >