Re: [PATCH v2] audit: use proper refcount locking on audit_sock

2016-12-12 Thread Paul Moore
On Mon, Dec 12, 2016 at 5:03 AM, Richard Guy Briggs wrote: > Resetting audit_sock appears to be racy. > > audit_sock was being copied and dereferenced without using a refcount on > the source sock. > > Bump the refcount on the underlying sock when we store a refrence in > audit_sock and release it

Re: [PATCH 3/5] perf tools: Add thread_map__remove function

2016-12-12 Thread Arnaldo Carvalho de Melo
Em Mon, Dec 12, 2016 at 05:08:26PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Mon, Dec 12, 2016 at 11:35:41AM +0100, Jiri Olsa escreveu: > > Adding thread_map__remove function to remove thread > > from thread map. Adding automated test also. > > I'm fixing this, caught on debian:experimental-x

Re: [PATCH] infiniband: hw: hfi1: constify mmu_notifier_ops structure

2016-12-12 Thread Doug Ledford
On 11/19/2016 4:47 AM, Bhumika Goyal wrote: > Declare the structure mmu_notifier_ops as const as it is only stored in > the ops field of a mmu_notifier structure. The ops field is of type > const struct mmu_notifier_ops *, so mmu_notifier_ops structures having > this property can be declared as con

Re: [PATCH v2 2/2] drm/panel: simple: Add support BOE nv101wxmn51

2016-12-12 Thread Stéphane Marchesin
On Wed, Dec 7, 2016 at 11:26 PM, Caesar Wang wrote: > 10.1WXGA is a color active matrix TFT LCD module using amorphous silicon > TFT's as an active switching devices. It can be supported by the > simple-panel driver. > > Read the panel edid information; > > EDID MODE DETAILS > name

Re: [PATCH 1/1] Fixed to BUG_ON to WARN_ON def

2016-12-12 Thread Ozgur Karatas
12.12.2016, 20:18, "Leon Romanovsky" : > On Mon, Dec 12, 2016 at 03:04:28PM +0200, Ozgur Karatas wrote: >>  Dear Romanovsky; > > Please avoid top-posting in your replies. > Thanks Dear Leon; thanks for the information., I will pay attention. >>  I'm trying to learn english and I apologize for

Re: [PATCH 00/31] scripts/spelling.txt: add more patterns with actual typo fixes

2016-12-12 Thread Joe Perches
On Tue, 2016-12-13 at 05:04 +0900, Masahiro Yamada wrote: > This series fixes typos that > > - have no entry in scripts/spelling.txt > - have 2 or more typo instances in the kernel tree > > This series can be cleanly applied to linux-next 20161212. > > Stephen Rot

memory_hotplug: zone_can_shift() returns boolean value

2016-12-12 Thread Yasuaki Ishimatsu
online_{kernel|movable} is used to change the memory zone to ZONE_{NORMAL|MOVABLE} and online the memory. To check that memory zone can be changed, zone_can_shift() is used. Currently the function returns minus integer value, plus integer value and 0. When the function returns minus or plus integ

Re: [PATCH 1/1] Fixed to codestyle

2016-12-12 Thread Ozgur Karatas
12.12.2016, 20:35, "Eric Sandeen" : > On 12/12/16 12:14 PM, Joe Perches wrote: >>  On Mon, 2016-12-12 at 07:49 -0600, Eric Sandeen wrote: >>>  On 12/12/16 4:53 AM, Ozgur Karatas wrote:  Hello,  I have error to use uuid and I think the functions should be used when -i'm eye-catc

Re: [PATCH 1/1] Fixed to codestyle

2016-12-12 Thread Ozgur Karatas
12.12.2016, 20:14, "Joe Perches" : > On Mon, 2016-12-12 at 07:49 -0600, Eric Sandeen wrote: >>  On 12/12/16 4:53 AM, Ozgur Karatas wrote: >>  > >>  > Hello, >>  > >>  > I have error to use uuid and I think the functions should be used when >> -i'm eye-catching- "(* uuid)". >>  > I tested it. >>  >

usb/gadget: warning in ep_write_iter/__alloc_pages_nodemask

2016-12-12 Thread Andrey Konovalov
Hi! While running the syzkaller fuzzer I've got the following error report. The issue is that the len argument is not checked for being too big. WARNING: CPU: 1 PID: 9935 at mm/page_alloc.c:3511 __alloc_pages_nodemask+0x159c/0x1e20 Kernel panic - not syncing: panic_on_warn set ... CPU: 1 PID: 9

Re: usb/gadget: warning in ep_write_iter/__alloc_pages_nodemask

2016-12-12 Thread Andrey Konovalov
On Mon, Dec 12, 2016 at 9:31 PM, Andrey Konovalov wrote: > Hi! > > While running the syzkaller fuzzer I've got the following error report. > > The issue is that the len argument is not checked for being too big. > > WARNING: CPU: 1 PID: 9935 at mm/page_alloc.c:3511 > __alloc_pages_nodemask+0x159c/

[GIT PULL] dlm fixes for 4.10

2016-12-12 Thread David Teigland
Hi Linus, Please pull dlm fixes from tag: git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm.git dlm-4.10 This set fixes error reporting for dlm sockets, removes the unbound property on the dlm callback workqueue to improve performance, and includes a couple trivial changes. Thank

Re: [PATCH 1/1] Fixed to codestyle

2016-12-12 Thread Eric Sandeen
On 12/12/16 2:34 PM, Ozgur Karatas wrote: > 12.12.2016, 20:35, "Eric Sandeen" : >> On 12/12/16 12:14 PM, Joe Perches wrote: ... > { > xfs_uu_t *uup = (xfs_uu_t *)uuid; > > @@ -51,8 +51,8 @@ uuid_is_nil(uuid_t *uuid) > if (uuid == NULL) >

Re: [PATCH] tags: honor COMPILED_SOURCE with apart output directory

2016-12-12 Thread Michal Marek
Dne 12.12.2016 v 18:13 Robert Jarzmik napsal(a): > Michal Marek writes: >> Please use the KBUILD_OUTPUT variable and not O. > Well, I can't as far as I know. I tried, see below ... > > Explanation : > - if I add just below the line "j=${i/\.[cS]/\.o}" the following : > k="$O/${j#$tree}" >

Re: [PATCH] drm/msm: return fence_fd = -1 if gem_submit fails

2016-12-12 Thread Chris Wilson
On Mon, Dec 12, 2016 at 05:41:08PM -0200, Gustavo Padovan wrote: > From: Gustavo Padovan > > Previously we were returning garbage here, fix it by setting it to -1 > before the first possible point of failure. The convention is that on error paths you do not modify user inputs. In particular, con

linux-kernel@vger.kernel.org

2016-12-12 Thread Peter Korsgaard
> "Afzal" == Afzal Mohammed writes: > Hi, > On Sun, Dec 11, 2016 at 06:40:28PM +0530, Afzal Mohammed wrote: >> Kernel reached the stage of invoking user space init & panicked, though >> it could not reach till prompt for want of user space executables >> >> So far i have not come acro

usb/core: warning in usb_create_ep_devs/sysfs_create_dir_ns

2016-12-12 Thread Andrey Konovalov
Hi! While running the syzkaller fuzzer I've got the following error report. On commit 3c49de52d5647cda8b42c4255cf8a29d1e22eff5 (Dev 2). WARNING: CPU: 2 PID: 865 at fs/sysfs/dir.c:31 sysfs_warn_dup+0x8a/0xa0 gadgetfs: disconnected sysfs: cannot create duplicate filename '/devices/platform/dummy_h

[RFC 4/5] drm/virtio: add out-fences support for explicit synchronization

2016-12-12 Thread Gustavo Padovan
From: Gustavo Padovan On the out-fence side we get fence returned by the submitted draw call and attach it to a sync_file and send the sync_file fd to userspace. On error -1 is returned to userspace. Signed-off-by: Gustavo Padovan --- drivers/gpu/drm/virtio/virtgpu_ioctl.c | 51 +++

[RFC 1/5] drm/virtio: add virtio_gpu_alloc_fence()

2016-12-12 Thread Gustavo Padovan
From: Gustavo Padovan Refactor fence creation to remove the potential allocation failure from the cmd_submit and atomic_commit paths. Now the fence should be allocated first and just after we should proceed with the rest of the execution. Signed-off-by: Gustavo Padovan --- drivers/gpu/drm/virt

[RFC 5/5] drm/virtio: bump driver version after explicit synchronization addition

2016-12-12 Thread Gustavo Padovan
From: Gustavo Padovan To reflect the (backward compatible) changes in the uabi we are bumping the driver's version. Signed-off-by: Gustavo Padovan --- drivers/gpu/drm/virtio/virtgpu_drv.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_drv

[RFC 3/5] drm/virtio: add in-fences support for explicit synchronization

2016-12-12 Thread Gustavo Padovan
From: Gustavo Padovan When the execbuf call receives an in-fence it will get the dma_fence related to that fence fd and wait on it before submitting the draw call. Signed-off-by: Gustavo Padovan --- drivers/gpu/drm/virtio/virtgpu_ioctl.c | 41 ++ 1 file changed,

[RFC 2/5] drm/virtio: add uapi for in and out explicit fences

2016-12-12 Thread Gustavo Padovan
From: Gustavo Padovan Add a new field called fence_fd that will be used by userspace to send in-fences to the kernel and receive out-fences created by the kernel. This uapi enables virtio to take advantage of explicit synchronization of dma-bufs. There are two new flags: * VIRTGPU_EXECBUF_FENC

[PATCH] cpumask: avoid WARN in prefill_possible_map()

2016-12-12 Thread Dmitry Safonov
With CONFIG_DEBUG_PER_CPU_MAPS and CONFIG_CPUMASK_OFFSTACK enabled fixes the following WARN_ON_ONCE() for booting with nr_cpus=1: [0.00] Linux version 4.9.0 (dsafonov@localhost.localdomain) (gcc version 4.8.5 20150623 (Red Hat 4.8.5-4) (GCC) ) #36 SMP Mon Dec 12 18:05:46 MSK 2016 [0.

Re: [PATCH 1/1] Fixed to codestyle

2016-12-12 Thread Ozgur Karatas
12.12.2016, 22:41, "Eric Sandeen" : > Well, rule #1 for newbies is "code style patches aren't > very useful, and usually are not welcomed by the project." > > Making style changes just because checkpatch told you to is > not particularly helpful. If it were important, it would have > been done by n

Re: [PATCH] btrfs: limit async_work allocation and worker func duration

2016-12-12 Thread Maxim Patlasov
On 12/12/2016 06:54 AM, David Sterba wrote: On Fri, Dec 02, 2016 at 05:51:36PM -0800, Maxim Patlasov wrote: Problem statement: unprivileged user who has read-write access to more than one btrfs subvolume may easily consume all kernel memory (eventually triggering oom-killer). Reproducer (./mkr

Re: [PATCH 1/1] Fixed to codestyle

2016-12-12 Thread Joe Perches
On Mon, 2016-12-12 at 14:41 -0600, Eric Sandeen wrote: > On 12/12/16 2:34 PM, Ozgur Karatas wrote: [] > > Can you tell me the true code style? should use to (* uuid)? > > I'm learn to new and I'm newbies :) > > Well, rule #1 for newbies is "code style patches aren't > very useful, and usually are

[PATCH] wusbcore: Fix one more crypto-on-the-stack bug

2016-12-12 Thread Andy Lutomirski
The driver put a constant buffer of all zeros on the stack and pointed a scatterlist entry at it. This doesn't work with virtual stacks. Make the buffer static to fix it. Cc: sta...@vger.kernel.org # 4.9 only Reported-by: Eric Biggers Signed-off-by: Andy Lutomirski --- drivers/usb/wusbcore/cr

[PATCH] keys/encrypted: Fix two crypto-on-the-stack bugs

2016-12-12 Thread Andy Lutomirski
The driver put a constant buffer of all zeros on the stack and pointed a scatterlist entry at it in two places. This doesn't work with virtual stacks. Use a static 16-byte buffer of zeros instead. Cc: sta...@vger.kernel.org # 4.9 only Reported-by: Eric Biggers Signed-off-by: Andy Lutomirski --

Re: [PATCH 1/1] Fixed to codestyle

2016-12-12 Thread Ozgur Karatas
12.12.2016, 22:50, "Joe Perches" : > On Mon, 2016-12-12 at 14:41 -0600, Eric Sandeen wrote: >>  On 12/12/16 2:34 PM, Ozgur Karatas wrote: > > [] >>  > Can you tell me the true code style? should use to (* uuid)? >>  > I'm learn to new and I'm newbies :) >> >>  Well, rule #1 for newbies is "code sty

[PATCH] cifs: Fix smbencrypt() to stop pointing a scatterlist at the stack

2016-12-12 Thread Andy Lutomirski
smbencrypt() points a scatterlist to the stack, which is breaks if CONFIG_VMAP_STACK=y. Fix it by switching to crypto_cipher_encrypt_one(). The new code should be considerably faster as an added benefit. This code is nearly identical to some code that Eric Biggers suggested. Cc: sta...@vger.ker

[PATCH] crypto: Make a few drivers depend on !VMAP_STACK

2016-12-12 Thread Andy Lutomirski
Eric Biggers found several crypto drivers that point scatterlists at the stack. These drivers should never load on x86, but, for future safety, make them depend on !VMAP_STACK. No -stable backport should be needed as no released kernel configuration should be affected. Reported-by: Eric Biggers

[PATCH] orinoco: Use shash instead of ahash for MIC calculations

2016-12-12 Thread Andy Lutomirski
Eric Biggers pointed out that the orinoco driver pointed scatterlists at the stack. Fix it by switching from ahash to shash. The result should be simpler, faster, and more correct. Cc: sta...@vger.kernel.org # 4.9 only Reported-by: Eric Biggers Signed-off-by: Andy Lutomirski --- Compile-teste

Re: [PATCH 0/2] Add maintainers to the admin guide

2016-12-12 Thread Joe Perches
On Mon, 2016-12-12 at 11:00 -0700, Jonathan Corbet wrote: > On Fri, 2 Dec 2016 10:15:13 -0200 > Mauro Carvalho Chehab wrote: > > > On the past approaches, was planning to keep the documentation > > about what's at the MAINTAINERS file inside it, but that would > > require running an external scr

Re: usb/gadget: warning in ep_write_iter/__alloc_pages_nodemask

2016-12-12 Thread Alan Stern
On Mon, 12 Dec 2016, Andrey Konovalov wrote: > On Mon, Dec 12, 2016 at 9:31 PM, Andrey Konovalov > wrote: > > Hi! > > > > While running the syzkaller fuzzer I've got the following error report. > > > > The issue is that the len argument is not checked for being too big. > > > > WARNING: CPU: 1 P

[RFC][PATCH 2/5 v3] drm/bridge: adv7511: Switch to using drm_kms_helper_hotplug_event()

2016-12-12 Thread John Stultz
In chasing down a previous issue with EDID probing from calling drm_helper_hpd_irq_event() from irq context, Laurent noticed that the DRM documentation suggests that drm_kms_helper_hotplug_event() should be used instead. Thus this patch replaces drm_helper_hpd_irq_event() with drm_kms_helper_hotpl

Re: [PATCH 1/2] mm/thp/pagecache: Only withdraw page table after a successful deposit

2016-12-12 Thread Kirill A. Shutemov
On Mon, Dec 12, 2016 at 10:04:27PM +0530, Aneesh Kumar K.V wrote: > The current code wrongly called withdraw in the error path. But we > haven't depoisted the page table yet in the only error path in that > function. So for now remove that withdraw completely. If we take > that "out:" branch, we sh

[RFC][PATCH 3/5 v3] drm/bridge: adv7511: Enable HPD interrupts to support hotplug and improve monitor detection

2016-12-12 Thread John Stultz
From: Archit Taneja On some adv7511 implementations, we can get some spurious disconnect signals which can cause monitor probing to fail. This patch enables HPD (hot plug detect) interrupt support which allows the monitor to be properly re-initialized when the spurious disconnect signal goes awa

[RFC][PATCH 4/5 v3] drm/bridge: adv7511: Rework adv7511_power_on/off() so they can be reused internally

2016-12-12 Thread John Stultz
In chasing down issues with EDID probing, I found some duplicated but incomplete logic used to power the chip on and off. This patch refactors the adv7511_power_on/off functions, so they can be used for internal needs. Cc: David Airlie Cc: Archit Taneja Cc: Wolfram Sang Cc: Lars-Peter Clausen

[RFC][PATCH 0/5 v3] adv7511 EDID probing improvements

2016-12-12 Thread John Stultz
Wanted to send out v3 of this patch set improving the EDID probing on the adv7511 used on HiKey. The first three patches are fixups that are hopefully straight forward, integrating feedback I got from Laurant. The last two patches try to clean up and resue code to avoid an issue I'm seeing where

[RFC][PATCH 1/5 v3] drm/bridge: adv7511: Use work_struct to defer hotplug handing to out of irq context

2016-12-12 Thread John Stultz
I was recently seeing issues with EDID probing, where the logic to wait for the EDID read bit to be set by the IRQ wasn't happening and the code would time out and fail. Digging deeper, I found this was due to the fact that IRQs were disabled as we were running in IRQ context from the HPD signal.

[RFC][PATCH 5/5 v3] drm/bridge: adv7511: Reuse __adv7511_power_on/off() when probing EDID

2016-12-12 Thread John Stultz
I've found that by just turning the chip on and off via the POWER_DOWN register, I end up getting i2c_transfer errors on HiKey. Investigating further, it seems some of the register state in the regmap cache is somehow getting lost. Using the logic in __adv7511_power_on/off() which syncs and dirtys

Re: Clarification for acceptance statistics?

2016-12-12 Thread Daniele Nicolodi
On 12/12/16 11:03 AM, SF Markus Elfring wrote: >> Have you proposed a similar patch that was accepted? > > Yes. - It happened a few times. The question was: have you ever had a patch changing code in the form { a = kmalloc(...); b = kmalloc(...); if (!a || !b)

Re: [PATCH 2/2] mm/thp/pagecache/collapse: Free the pte page table on collapse for thp page cache.

2016-12-12 Thread Kirill A. Shutemov
On Mon, Dec 12, 2016 at 10:04:28PM +0530, Aneesh Kumar K.V wrote: > With THP page cache, when trying to build a huge page from regular pte pages, > we just clear the pmd entry. We will take another fault and at that point we > will find the huge page in the radix tree, thereby using the huge page t

Re: usb/gadget: warning in ep_write_iter/__alloc_pages_nodemask

2016-12-12 Thread Michal Hocko
On Mon 12-12-16 21:32:35, Andrey Konovalov wrote: > On Mon, Dec 12, 2016 at 9:31 PM, Andrey Konovalov > wrote: > > Hi! > > > > While running the syzkaller fuzzer I've got the following error report. > > > > The issue is that the len argument is not checked for being too big. Well, the value is c

Re: usb/core: warning in usb_create_ep_devs/sysfs_create_dir_ns

2016-12-12 Thread Alan Stern
On Mon, 12 Dec 2016, Andrey Konovalov wrote: > Hi! > > While running the syzkaller fuzzer I've got the following error report. > > On commit 3c49de52d5647cda8b42c4255cf8a29d1e22eff5 (Dev 2). > > WARNING: CPU: 2 PID: 865 at fs/sysfs/dir.c:31 sysfs_warn_dup+0x8a/0xa0 > gadgetfs: disconnected > sy

[PATCH v2 2/9] NTB: Add indexed ports NTB API

2016-12-12 Thread Serge Semin
There are some NTB hardware, which can combine more than just two domains over NTB. For instance, some IDT PCIe-switches can have NTB-functions activated on more than two-ports. The different domains are distinguished by ports they are connected to. So the new port-related methods are added to the

[PATCH v2 7/9] NTB: Add new Memory Windows API documentation

2016-12-12 Thread Serge Semin
Since the new API slightly changes the way a typical NTB client driver works, the documentation file needs to be appropriately updated. Signed-off-by: Serge Semin --- Documentation/ntb.txt | 99 ++- 1 file changed, 91 insertions(+), 8 deletions(-)

[PATCH v2 0/9] NTB: Alter kernel API to support multi-port devices

2016-12-12 Thread Serge Semin
There are devices, like IDT PCIe-switches, which have more than just two ports. Particularly one device can have up to eight ports with NTB-function activated. In order to support such devices, NTB kernel API should be altered since currently it's optimized to work with two-ports devices only. Cha

[PATCH v2 5/9] NTB: Alter Scratchpads API to support multi-ports devices

2016-12-12 Thread Serge Semin
Even though there is no any real NTB hardware, which would have both more than two ports and Scratchpad registers, it is logically correct to have Scratchpad API accepting a peer port index as well. Intel/AMD drivers utilize Primary and Secondary topology to split Scratchpad between connected root

[PATCH v2 6/9] NTB: Add Messaging NTB API

2016-12-12 Thread Serge Semin
Some IDT NTB-capable PCIe-switches have message registers to communicate with peer devices. This patch adds new NTB API callback methods, which can be used to utilize these registers functionality: ntb_msg_count(); - get number of message registers ntb_msg_inbits(); - get bitfield of inbound mess

[PATCH v2 8/9] NTB: Add PCIe Gen4 link speed

2016-12-12 Thread Serge Semin
Signed-off-by: Serge Semin --- include/linux/ntb.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/linux/ntb.h b/include/linux/ntb.h index 90746df..fe0437c 100644 --- a/include/linux/ntb.h +++ b/include/linux/ntb.h @@ -108,6 +108,7 @@ static inline char *ntb_topo_string(enum ntb_to

Re: [RFC PATCH net-next v3 1/2] macb: Add 1588 support in Cadence GEM.

2016-12-12 Thread Richard Cochran
On Mon, Dec 12, 2016 at 10:22:43AM +, andrei.pistir...@microchip.com wrote: > Richard, are you agree with this? Yes, but please trim your replies next time. Scrolling through pages of quoted headers and stale content in order to read one line is very annoying. Thanks, Richard

[PATCH v2 9/9] NTB: Add ntb.h comments

2016-12-12 Thread Serge Semin
Signed-off-by: Serge Semin --- include/linux/ntb.h | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/include/linux/ntb.h b/include/linux/ntb.h index fe0437c..c5a369c 100644 --- a/include/linux/ntb.h +++ b/include/linux/ntb.h @@ -312,13 +312,18 @@ static inlin

[PATCH v2 1/9] NTB: Make link-state API being declared first

2016-12-12 Thread Serge Semin
Since link operations are usually performed before memory window access operations, it's logically better to declared link-related API before any other methods. Additionally it's good practice for readability to declare NTB device callback methods of hadrware drivers with the same order as it's don

Re: usb/gadget: warning in ep_write_iter/__alloc_pages_nodemask

2016-12-12 Thread Alan Stern
On Mon, 12 Dec 2016, Michal Hocko wrote: > On Mon 12-12-16 21:32:35, Andrey Konovalov wrote: > > On Mon, Dec 12, 2016 at 9:31 PM, Andrey Konovalov > > wrote: > > > Hi! > > > > > > While running the syzkaller fuzzer I've got the following error report. > > > > > > The issue is that the len argume

[PATCH v2 4/9] NTB: Alter MW API to support multi-ports devices

2016-12-12 Thread Serge Semin
Multi-port NTB devices permit to share a memory between all accessible peers. Memory Windows API is altered to correspondingly initialize and map memory windows for such devices: ntb_mw_count(pidx); - number of inbound memory windows, which can be allocated for shared buffer with specified peer de

[PATCH v2 3/9] NTB: Alter link-state API to support multi-port devices

2016-12-12 Thread Serge Semin
Multi-port devices permit the NTB connections between multiple domains, so a local device can have NTB link being up with one peer and being down with another. NTB link-state API is appropriately altered to return a bitfield of the link-states between the local device and possible peers. Signed-of

Re: CVE-2016-7097 causes acl leak

2016-12-12 Thread Cong Wang
On Mon, Dec 12, 2016 at 2:46 AM, Jan Kara wrote: > So I agree with you the mentioned commit didn't change anything. I took > care to keep the previous behavior wrt NULLing the acl pointer (obviously I > could have made mistake somewhere but I don't see where). However your > patch is definitely wr

Re: [PATCH v4 4/4] regulator: Prevent falling too fast

2016-12-12 Thread Matthias Kaehlcke
El Fri, Oct 28, 2016 at 07:15:21PM +0100 Mark Brown ha dit: > On Mon, Sep 26, 2016 at 10:41:59AM -0700, Doug Anderson wrote: > > > I guess I think of the whole network of components as the PWM > > regulator and not the individual discreet BUCK. I'm also not quite > > sure how you would model it

Re: WARNING: kernel stack frame pointer at ffffffff82e03f40 in swapper:0 has bad value (null)

2016-12-12 Thread Josh Poimboeuf
On Mon, Dec 12, 2016 at 12:10:25PM -0600, Josh Poimboeuf wrote: > On Mon, Dec 12, 2016 at 06:50:23PM +0100, Borislav Petkov wrote: > > [0.00] bce03f40: ... > > [0.00] bce03f48: bc0001b5 (start_cpu+0x5/0x14) > > [0.00] bce03f50

Re: usb/core: warning in usb_create_ep_devs/sysfs_create_dir_ns

2016-12-12 Thread Dmitry Vyukov
On Mon, Dec 12, 2016 at 10:05 PM, Alan Stern wrote: > On Mon, 12 Dec 2016, Andrey Konovalov wrote: > >> Hi! >> >> While running the syzkaller fuzzer I've got the following error report. >> >> On commit 3c49de52d5647cda8b42c4255cf8a29d1e22eff5 (Dev 2). >> >> WARNING: CPU: 2 PID: 865 at fs/sysfs/dir

Re: [PATCH v2] siphash: add cryptographically secure hashtable function

2016-12-12 Thread Jason A. Donenfeld
Hey Eric, Lots of good points; thanks for the review. Responses are inline below. On Mon, Dec 12, 2016 at 6:42 AM, Eric Biggers wrote: > Maybe add to the help text for CONFIG_TEST_HASH that it now tests siphash too? Good call. Will do. > This assumes the key and message buffers are aligned to

Re: [PATCH 1/1] Fixed to codestyle

2016-12-12 Thread Eric Sandeen
On 12/12/16 2:50 PM, Joe Perches wrote: > On Mon, 2016-12-12 at 14:41 -0600, Eric Sandeen wrote: >> On 12/12/16 2:34 PM, Ozgur Karatas wrote: > [] >>> Can you tell me the true code style? should use to (* uuid)? >>> I'm learn to new and I'm newbies :) >> >> Well, rule #1 for newbies is "code sty

Re: [RFT PATCH] ARM64: dts: meson-gxbb: Add reserved memory zone and usable memory range

2016-12-12 Thread Heinrich Schuchardt
On 12/12/2016 11:18 AM, Neil Armstrong wrote: > The Amlogic Meson GXBB secure monitor uses part of the memory space, this > patch adds these reserved zones and redefines the usable memory range for > each boards. > > Signed-off-by: Neil Armstrong > --- > arch/arm64/boot/dts/amlogic/meson-gx-p23x

Re: [PATCH v8 3/8] drivers:input:tsc2007: add iio interface to read external ADC input and temperature

2016-12-12 Thread H. Nikolaus Schaller
Hi, > Am 27.11.2016 um 16:47 schrieb H. Nikolaus Schaller : > > Hi Jonathan, > >> Am 27.11.2016 um 12:02 schrieb Jonathan Cameron : >> >> On 24/11/16 18:05, H. Nikolaus Schaller wrote: >>> Am 24.11.2016 um 18:38 schrieb Jonathan Cameron : On 22 November 2016

Re: [PATCH] drm/msm: return fence_fd = -1 if gem_submit fails

2016-12-12 Thread Gustavo Padovan
2016-12-12 Chris Wilson : > On Mon, Dec 12, 2016 at 05:41:08PM -0200, Gustavo Padovan wrote: > > From: Gustavo Padovan > > > > Previously we were returning garbage here, fix it by setting it to -1 > > before the first possible point of failure. > > The convention is that on error paths you do n

Re: [PATCH] IB/rxe: avoid putting a large struct rxe_qp on stack

2016-12-12 Thread Doug Ledford
On 9/19/2016 9:28 AM, Leon Romanovsky wrote: > On Mon, Sep 19, 2016 at 01:57:26PM +0200, Arnd Bergmann wrote: >> A race condition fix added an rxe_qp structure to the stack in order >> to be able to perform rollback in rxe_requester(), but the structure >> is large enough to trigger the warning for

Re: WARNING: kernel stack frame pointer at ffffffff82e03f40 in swapper:0 has bad value (null)

2016-12-12 Thread Borislav Petkov
On Mon, Dec 12, 2016 at 03:16:27PM -0600, Josh Poimboeuf wrote: > I still can't figure out what could cause this, nor can I recreate it. Want my .config? > Andy, any idea? I'm trying to figure out why a stack trace of the > initial task, early in start_kernel(), would show start_cpu() on the > s

Re: [PATCH v2] siphash: add cryptographically secure hashtable function

2016-12-12 Thread Linus Torvalds
On Sun, Dec 11, 2016 at 9:48 PM, Jason A. Donenfeld wrote: > I modified the test to hash data of size 0 through 7 repeatedly > 1 times, and benchmarked that a few times on a Skylake laptop. > The `load_unaligned_zeropad & bytemask_from_count` version was > consistently 7% slower. > > I the

Re: [PATCH] wusbcore: Fix one more crypto-on-the-stack bug

2016-12-12 Thread Greg KH
On Mon, Dec 12, 2016 at 12:52:45PM -0800, Andy Lutomirski wrote: > The driver put a constant buffer of all zeros on the stack and > pointed a scatterlist entry at it. This doesn't work with virtual > stacks. Make the buffer static to fix it. > > Cc: sta...@vger.kernel.org # 4.9 only > Reported-b

Re: [PATCH v2] siphash: add cryptographically secure hashtable function

2016-12-12 Thread Jason A. Donenfeld
Hi Linus, > I guess you could try to just remove the "if (left)" test entirely, if > it is at least partly the mispredict. It should do the right thing > even with a zero count, and it might schedule the code better. Code > size _should_ be better with the byte mask model (which won't matter > in

Re: usb/core: warning in usb_create_ep_devs/sysfs_create_dir_ns

2016-12-12 Thread Alan Stern
On Mon, 12 Dec 2016, Dmitry Vyukov wrote: > On Mon, Dec 12, 2016 at 10:05 PM, Alan Stern > wrote: > > On Mon, 12 Dec 2016, Andrey Konovalov wrote: > > > >> Hi! > >> > >> While running the syzkaller fuzzer I've got the following error report. > >> > >> On commit 3c49de52d5647cda8b42c4255cf8a29d1e

Re: usb/core: warning in usb_create_ep_devs/sysfs_create_dir_ns

2016-12-12 Thread Greg Kroah-Hartman
On Mon, Dec 12, 2016 at 10:16:50PM +0100, Dmitry Vyukov wrote: > On Mon, Dec 12, 2016 at 10:05 PM, Alan Stern > wrote: > > On Mon, 12 Dec 2016, Andrey Konovalov wrote: > > > >> Hi! > >> > >> While running the syzkaller fuzzer I've got the following error report. > >> > >> On commit 3c49de52d5647c

Re: [PATCH 1/2] crypto: asymmetric_keys: set error code on failure

2016-12-12 Thread James Morris
On Mon, 12 Dec 2016, David Howells wrote: > From: Pan Bian > > In function public_key_verify_signature(), returns variable ret on > error paths. When the call to kmalloc() fails, the value of ret is 0, > and it is not set to an errno before returning. This patch fixes the > bug. > > Bugzilla: h

Re: [PATCH v3 2/3] perf tool: add PERF_RECORD_NAMESPACES to include namespaces related info

2016-12-12 Thread Eric W. Biederman
Hari Bathini writes: > This patch updates perf tool to examine PERF_RECORD_NAMESPACES events > emitted by the kernel when fork, clone, setns or unshare are invoked. > Also, it synthesizes PERF_RECORD_NAMESPACES events for processes that > were running prior to invocation of perf record, the data

Re: [GIT PULL] Openrisc changes for 4.10 merge

2016-12-12 Thread Stafford Horne
On Mon, Dec 12, 2016 at 09:50:50AM -0800, Guenter Roeck wrote: > On Mon, Dec 12, 2016 at 09:05:36AM -0800, Linus Torvalds wrote: > > On Mon, Dec 12, 2016 at 6:38 AM, Stafford Horne wrote: > > > > > > - This is my first pull request as the new OpenRISC architecture > > >maintainer. I hope I ha

Re: [PATCH v2] siphash: add cryptographically secure hashtable function

2016-12-12 Thread Jason A. Donenfeld
On Mon, Dec 12, 2016 at 10:44 PM, Jason A. Donenfeld wrote: > #if defined(CONFIG_DCACHE_WORD_ACCESS) && BITS_PER_LONG == 64 >switch (left) { >case 0: break; >case 1: b |= data[0]; break; >case 2: b |= get_unaligned_le16(data); break; >case 4: b |= get_unalig

Re: usb/core: warning in usb_create_ep_devs/sysfs_create_dir_ns

2016-12-12 Thread Alan Stern
On Mon, 12 Dec 2016, Alan Stern wrote: > On Mon, 12 Dec 2016, Dmitry Vyukov wrote: > > > On Mon, Dec 12, 2016 at 10:05 PM, Alan Stern > > wrote: > > > On Mon, 12 Dec 2016, Andrey Konovalov wrote: > > > > > >> Hi! > > >> > > >> While running the syzkaller fuzzer I've got the following error repo

Re: WARNING: CPU: 3 PID: 1568 at kernel/sched/core.c:7738 __might_sleep+0x69/0x7e

2016-12-12 Thread Tejun Heo
Hello, Michal. On Fri, Dec 09, 2016 at 04:12:29PM +0100, Michal Hocko wrote: > Hi Tejun, > I am seeing the following warning during boot in my kvm testing > environment: > [3.549649] WARNING: CPU: 3 PID: 1568 at kernel/sched/core.c:7738 > __might_sleep+0x69/0x7e > [3.551279] do not call b

Re: [PATCH v6 2/2] crypto: add virtio-crypto driver

2016-12-12 Thread Michael S. Tsirkin
On Mon, Dec 12, 2016 at 06:54:07PM +0800, Herbert Xu wrote: > On Mon, Dec 12, 2016 at 06:25:12AM +, Gonglei (Arei) wrote: > > Hi, Michael & Herbert > > > > Because the virtio-crypto device emulation had been in QEMU 2.8, > > would you please merge the virtio-crypto driver for 4.10 if no other

Re: [PATCH v3 3/3] perf tool: add cgroup identifier entry in perf report

2016-12-12 Thread Eric W. Biederman
Hari Bathini writes: > This patch introduces a cgroup identifier entry field in perf report to > identify or distinguish data of different cgroups. It uses the unique > inode number of cgroup namespace, included in perf data with the new > PERF_RECORD_NAMESPACES event, as cgroup identifier. With

Re: [PATCH V3 for-next 00/11] Code improvements & fixes for HNS RoCE driver

2016-12-12 Thread Doug Ledford
On 11/23/2016 2:40 PM, Salil Mehta wrote: > This patchset introduces some code improvements and fixes > for the identified problems in the HNS RoCE driver. > > Lijun Ou (4): > IB/hns: Add the interface for querying QP1 > IB/hns: add self loopback for CM > IB/hns: Modify the condition of noti

Re: [PATCH for-next 0/6] IB/hns: Bug Fixes for HNS RoCE Driver

2016-12-12 Thread Doug Ledford
On 11/29/2016 6:10 PM, Salil Mehta wrote: > This patch-set contains bug fixes for the HNS RoCE driver. > > Lijun Ou (1): > IB/hns: Fix the IB device name > > Shaobo Xu (2): > IB/hns: Fix the bug when free mr > IB/hns: Fix the bug when free cq > > Wei Hu (Xavier) (3): > IB/hns: Fix the bu

Re: WARNING: kernel stack frame pointer at ffffffff82e03f40 in swapper:0 has bad value (null)

2016-12-12 Thread Josh Poimboeuf
On Mon, Dec 12, 2016 at 10:34:46PM +0100, Borislav Petkov wrote: > On Mon, Dec 12, 2016 at 03:16:27PM -0600, Josh Poimboeuf wrote: > > I still can't figure out what could cause this, nor can I recreate it. > > Want my .config? Yes, please. > > Andy, any idea? I'm trying to figure out why a stac

Re: Clarification for acceptance statistics?

2016-12-12 Thread SF Markus Elfring
> The question was: have you ever had a patch changing code in the form > > { > a = kmalloc(...); > b = kmalloc(...); > > if (!a || !b) > goto out; > > ... > > out: > kfree(a); > kfree(b); > } > > to something else, accepted? It seems that thi

Re: [ext4] e2ae766c1b: BUG:sleeping_function_called_from_invalid_context_at_kernel/locking/rwsem.c

2016-12-12 Thread Ross Zwisler
On Mon, Dec 12, 2016 at 05:35:18PM +0100, Jan Kara wrote: > On Mon 12-12-16 18:13:21, kernel test robot wrote: > > FYI, we noticed the following commit: > > > > commit: e2ae766c1b030271b5099b25674e2131d1d1e8c1 ("ext4: convert DAX faults > > to iomap infrastructure") > > https://git.kernel.org/pub

[GIT PULL] f2fs update for 4.10

2016-12-12 Thread Jaegeuk Kim
Hi Linus, Could you please consider this pull request? Thanks, The following changes since commit ded9b5dd205ef04aa095c3b731c635b201191a59: Merge branch 'perf-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip (2016-11-23 08:09:21 -0800) are available in the git rep

Re: Remaining crypto API regressions with CONFIG_VMAP_STACK

2016-12-12 Thread Gary R Hook
On 12/12/2016 12:34 PM, Andy Lutomirski wrote: <...snip...> I have a patch to make these depend on !VMAP_STACK. drivers/crypto/ccp/ccp-crypto-aes-cmac.c:105,119,142 drivers/crypto/ccp/ccp-crypto-sha.c:95,109,124 drivers/crypto/ccp/ccp-crypto-aes-xts.c:162 driv

Re: [PATCH 1/6] ext4: Move is_32bit_api() to generic code

2016-12-12 Thread Richard Weinberger
On Thu, Dec 1, 2016 at 11:02 PM, Richard Weinberger wrote: > Since UBIFS will also use this function, move it to compat.h. > > Signed-off-by: Richard Weinberger > --- > fs/ext4/dir.c | 9 - > include/linux/compat.h | 2 ++ > 2 files changed, 2 insertions(+), 9 deletions(-) > > d

Re: [patch] mm, compaction: add vmstats for kcompactd work

2016-12-12 Thread David Rientjes
On Thu, 8 Dec 2016, Vlastimil Babka wrote: > > A "compact_daemon_wake" vmstat exists that represents the number of times > > kcompactd has woken up. This doesn't represent how much work it actually > > did, though. > > > > It's useful to understand how much compaction work is being done by > > k

[PATCH v3] siphash: add cryptographically secure hashtable function

2016-12-12 Thread Jason A. Donenfeld
SipHash is a 64-bit keyed hash function that is actually a cryptographically secure PRF, like HMAC. Except SipHash is super fast, and is meant to be used as a hashtable keyed lookup function. SipHash isn't just some new trendy hash function. It's been around for a while, and there really isn't any

Re: [PATCH] ACPI: small formatting fixes

2016-12-12 Thread Pavel Machek
On Mon 2016-12-12 10:39:15, Joe Perches wrote: > On Mon, 2016-12-12 at 09:56 -0800, Nick Desaulniers wrote: > > A quick cleanup that passes scripts/checkpatch.pl -f . > > You might use the --strict option for acpi files. Please... don't encourage people more, we have enough cleanup patches as is.

[PATCH] treewide: Make remaining source files non-executable

2016-12-12 Thread Joe Perches
.c and .h source files should not be executable, change the permissions to 0644. Signed-off-by: Joe Perches Acked-by: David Howells --- Linus, Andrew Morton suggested privately that you apply this directly as his toolchain doesn't support rename/permission only patches. Apparently, Andrew hasn

Re: [PATCH] keys/encrypted: Fix two crypto-on-the-stack bugs

2016-12-12 Thread David Howells
Andy Lutomirski wrote: > +static const char zero_pad[16] = {0}; Isn't there a global page of zeros or something that we can share? Also, you shouldn't explicitly initialise it so that it stays in .bss. > - sg_set_buf(&sg_out[1], pad, sizeof pad); > + sg_set_buf(&sg_out[1], zero_pad, si

[PATCH] net: cirrus: ep93xx: use new api ethtool_{get|set}_link_ksettings

2016-12-12 Thread Philippe Reynes
The ethtool api {get|set}_settings is deprecated. We move this driver to new api {get|set}_link_ksettings. Signed-off-by: Philippe Reynes --- drivers/net/ethernet/cirrus/ep93xx_eth.c | 14 -- 1 files changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/cirrus

Re: [PATCH] vfio/pci: Support error recovery

2016-12-12 Thread Michael S. Tsirkin
On Mon, Dec 12, 2016 at 12:12:16PM -0700, Alex Williamson wrote: > On Mon, 12 Dec 2016 21:49:01 +0800 > Cao jin wrote: > > > Hi, > > I have 2 solutions(high level design) came to me, please see if they are > > acceptable, or which one is acceptable. Also have some questions. > > > > 1. block gue

Re: [PATCH 1/6] ext4: Move is_32bit_api() to generic code

2016-12-12 Thread Andreas Dilger
On Dec 1, 2016, at 3:02 PM, Richard Weinberger wrote: > > Since UBIFS will also use this function, move it to compat.h. > > Signed-off-by: Richard Weinberger Looks fine, could have minor improvement as mentioned below. Reviewed-by: Andreas Dilger > --- > fs/ext4/dir.c | 9 -

Re: WARNING: CPU: 3 PID: 1568 at kernel/sched/core.c:7738 __might_sleep+0x69/0x7e

2016-12-12 Thread Cong Wang
On Mon, Dec 12, 2016 at 2:03 PM, Tejun Heo wrote: > Hello, Michal. > > On Fri, Dec 09, 2016 at 04:12:29PM +0100, Michal Hocko wrote: >> At first I thought this would be related to you recent work >> http://lkml.kernel.org/r/1477673892-28940-1-git-send-email...@kernel.org >> but that doesn't seem t

[GIT PULL] Power management updates for v4.10-rc1

2016-12-12 Thread Rafael J. Wysocki
Hi Linus, Please pull from the tag git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git \ pm-4.10-rc1 with top-most commit bbc17bb8a89b3eb31520abf3a9b362d5ee54f908 Merge branch 'pm-devfreq' on top of commit 69973b830859bc6529a7a0468ba0d80ee5117826 Linux 4.9 to receive power

Re: [PATCH] ACPI: small formatting fixes

2016-12-12 Thread Joe Perches
On Mon, 2016-12-12 at 23:22 +0100, Pavel Machek wrote: > On Mon 2016-12-12 10:39:15, Joe Perches wrote: > > On Mon, 2016-12-12 at 09:56 -0800, Nick Desaulniers wrote: > > > A quick cleanup that passes scripts/checkpatch.pl -f . [] > > > diff --git a/arch/x86/kernel/acpi/cstate.c b/arch/x86/kernel/a

<    1   2   3   4   5   6   7   8   >