On 9/19/2016 9:28 AM, Leon Romanovsky wrote:
> On Mon, Sep 19, 2016 at 01:57:26PM +0200, Arnd Bergmann wrote:
>> A race condition fix added an rxe_qp structure to the stack in order
>> to be able to perform rollback in rxe_requester(), but the structure
>> is large enough to trigger the warning for possible stack overflow:
>>
>> drivers/infiniband/sw/rxe/rxe_req.c: In function 'rxe_requester':
>> drivers/infiniband/sw/rxe/rxe_req.c:757:1: error: the frame size of 2064
>> bytes is larger than 1024 bytes [-Werror=frame-larger-than=]
>>
>> This changes the rollback function to only save the psn inside
>> the qp, which is the only field we access in the rollback_qp
>> anyway.
>>
>> Fixes: 3050b9985024 ("IB/rxe: Fix race condition between requester and
>> completer")
>> Signed-off-by: Arnd Bergmann <a...@arndb.de>
>
> Thanks Arnd,
> It is much cleaner approach.
> Reviewed-by: Leon Romanovsky <leo...@mellanox.com>
>
Thanks, applied.
--
Doug Ledford <dledf...@redhat.com>
GPG Key ID: 0E572FDD
signature.asc
Description: OpenPGP digital signature
