Re: [PATCH] net-libertas: Better exception handling in if_spi_host_to_card_worker()

2016-01-02 Thread SF Markus Elfring
>> Move the jump label directly before the desired log statement >> so that the variable "err" will not be checked once more >> after it was determined that a function call failed. >> Use the identifier "report_failure" instead of the label "err". > >Why? I suggest to reconsider the places wi

Re: [PATCH] net-libertas: Better exception handling in if_spi_host_to_card_worker()

2016-01-02 Thread Julia Lawall
On Sat, 2 Jan 2016, SF Markus Elfring wrote: > >> Move the jump label directly before the desired log statement > >> so that the variable "err" will not be checked once more > >> after it was determined that a function call failed. > >> Use the identifier "report_failure" instead of the label "e

Re: [PATCH] net-brcmfmac: Delete an unnecessary variable initialisation in brcmf_sdio_download_firmware()

2016-01-02 Thread Arend van Spriel
On 01/01/2016 08:26 PM, SF Markus Elfring wrote: From: Markus Elfring Date: Fri, 1 Jan 2016 20:20:15 +0100 I think it has been said over and over, but please use driver name only as prefix. I don't see value to prepend it with 'net-'. Omit explicit initialisation at the beginning for one l

Re: net-libertas: Better exception handling in if_spi_host_to_card_worker()

2016-01-02 Thread SF Markus Elfring
>> I assume that a software development taste can evolve, can't it? > > So far, you have gotten several down votes for this kind of change, I am curious when more contributors will share corresponding opinions. > and no enthusiasm. How many software designers and developers can become enthusia

Re: [PATCH v3 RESEND 0/2] WM8505/WM8650 DT fixes for SD card controller

2016-01-02 Thread Roman Volkov
В Fri, 01 Jan 2016 22:53:33 +0100 Arnd Bergmann пишет: > On Friday 01 January 2016 20:32:30 Roman Volkov wrote: > > > Applied both to next/dt, thanks a lot for following up! > > > > > > Let me know if you think this should go into stable backports as > > > well, I did not apply it to the fixes b

Re: [PATCH v2] crypto: af_alg - Disallow bind/setkey/... after accept(2)

2016-01-02 Thread Stephan Mueller
Am Freitag, 1. Januar 2016, 21:12:40 schrieb Stephan Mueller: Hi Herbert, > Am Mittwoch, 30. Dezember 2015, 11:47:53 schrieb Herbert Xu: > > Hi Herbert, > > > On Tue, Dec 29, 2015 at 07:36:14PM +0100, Dmitry Vyukov wrote: > > > Hello, > > > > > > On commit 8513342170278468bac126640a5d2d12ffbff

Re: [PATCH] ACPI / OSL: Add kerneldoc comments to memory mapping functions

2016-01-02 Thread Mathias Krause
On 2 January 2016 at 03:10, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > Add kerneldoc comments to acpi_os_map_iomem() and acpi_os_unmap_iomem() > and explain why the latter needs the __ref annotation in one of them > (as suggested by Mathias Krause). > > Signed-off-by: Rafael J. Wysock

Re: net-libertas: Better exception handling in if_spi_host_to_card_worker()

2016-01-02 Thread Arend van Spriel
On 02-01-16 10:08, SF Markus Elfring wrote: >>> I assume that a software development taste can evolve, can't it? >> >> So far, you have gotten several down votes for this kind of change, > > I am curious when more contributors will share corresponding opinions. Let's burn some cycles on this wh

[PATCH 3/5] nbd: Timeouts are not user requested disconnects

2016-01-02 Thread Markus Pargmann
It may be useful to know in the client that a connection timed out. The current code returns success for a timeout. This patch reports the error code -ETIMEDOUT for a timeout. Signed-off-by: Markus Pargmann --- drivers/block/nbd.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-)

[PULL] NBD changes

2016-01-02 Thread Markus Pargmann
Hi Jens, This pull request contains 5 patches which are mainly cleanups. Patch 1 fixes some unnecessarily complicated code I introduced some versions ago for debugfs. Patch 2 removes the criticised signal usage within NBD to kill the NBD threads after a timeout. This code was used for the last y

[PATCH 5/5] nbd: Move flag parsing to a function

2016-01-02 Thread Markus Pargmann
nbd changes properties of the blockdevice depending on flags that were received. This patch moves this flag parsing into a separate function nbd_parse_flags(). Signed-off-by: Markus Pargmann --- drivers/block/nbd.c | 22 +- 1 file changed, 13 insertions(+), 9 deletions(-) di

[PATCH 1/5] nbd: Fix debugfs error handling

2016-01-02 Thread Markus Pargmann
Static checker complains about the implemented error handling. It is indeed wrong. We don't care about the return values of created debugfs files. We only have to check the return values of created dirs for NULL pointer. If we use a null pointer as parent directory for files, this may lead to debu

[PATCH 4/5] nbd: Cleanup reset of nbd and bdev after a disconnect

2016-01-02 Thread Markus Pargmann
Group all variables that are reset after a disconnect into reset functions. This patch adds two of these functions, nbd_reset() and nbd_bdev_reset(). Signed-off-by: Markus Pargmann --- drivers/block/nbd.c | 40 +--- 1 file changed, 29 insertions(+), 11 deletio

[PATCH 2/5] nbd: Remove signal usage

2016-01-02 Thread Markus Pargmann
As discussed on the mailing list, the usage of signals for timeout handling has a lot of potential issues. The nbd driver used for some time signals for timeouts. These signals where able to get the threads out of the blocking socket operations. This patch removes all signal usage and uses a socke

Re: [PATCH 2/4] irqchip: bcm2836: Add SMP support for the 2836

2016-01-02 Thread Russell King - ARM Linux
On Sat, Dec 26, 2015 at 01:47:22PM -0800, Eric Anholt wrote: > +int __init bcm2836_smp_boot_secondary(unsigned int cpu, > + struct task_struct *idle) > +{ > + unsigned long secondary_startup_phys = > + (unsigned long)virt_to_phys((void *)secondary_s

Re: [PATCH] arm: kernel: utilize hrtimer based broadcast

2016-01-02 Thread Russell King - ARM Linux
On Tue, Dec 29, 2015 at 02:54:10PM +0100, Thomas Gleixner wrote: > On Mon, 28 Dec 2015, Arnd Bergmann wrote: > > > On Monday 28 December 2015 07:18:58 Huan Wang wrote: > > > Hi, Arnd, > > > > > > Could you help to review the following patch? Thanks. > > > > > > > Hi Alison, > > > > I'm sorry

Re: [Question about DMA] Consistent memory?

2016-01-02 Thread Russell King - ARM Linux
On Thu, Dec 31, 2015 at 04:50:54PM +0900, Masahiro Yamada wrote: > Hi. > > I am new to the Linux DMA APIs. > > First, I started by reading Documentation/DMA-API.txt, > but I am confused with the term "consistent memory". Just read "coherent memory" instead - the documentation confusingly uses th

Re: [Question about DMA] Consistent memory?

2016-01-02 Thread Russell King - ARM Linux
On Thu, Dec 31, 2015 at 11:57:55PM +0900, Masahiro Yamada wrote: > [1] DMA-coherent buffers > > Allocate buffers with dma_alloc_coherent() > and just have access to the buffers without cache synchronization. > > There is no need to call dma_sync_single_for_*(). dma_sync_single_for_*() is part of

Re: [PATCH v2 08/32] arm: reuse asm-generic/barrier.h

2016-01-02 Thread Russell King - ARM Linux
On Thu, Dec 31, 2015 at 09:06:46PM +0200, Michael S. Tsirkin wrote: > On arm smp_store_mb, read_barrier_depends, smp_read_barrier_depends, > smp_store_release, smp_load_acquire, smp_mb__before_atomic and > smp_mb__after_atomic match the asm-generic variants exactly. Drop the > local definitions and

Re: net-libertas: Better exception handling in if_spi_host_to_card_worker()

2016-01-02 Thread SF Markus Elfring
> I have never seen much evolution going on in this area. I can get an other impression from a specific document for example. https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/log/Documentation/CodingStyle > What the patch tries to do is avoid the extra 'if (err)'. Yes. - I propo

Re: [PATCH v2 17/32] arm: define __smp_xxx

2016-01-02 Thread Russell King - ARM Linux
On Thu, Dec 31, 2015 at 09:07:59PM +0200, Michael S. Tsirkin wrote: > This defines __smp_xxx barriers for arm, > for use by virtualization. > > smp_xxx barriers are removed as they are > defined correctly by asm-generic/barriers.h > > This reduces the amount of arch-specific boiler-plate code. >

Re: GPF in shm_lock ipc

2016-01-02 Thread Manfred Spraul
Hi Dmitry, shm locking differs too much from msg/sem locking, I never looked at it in depth, so I'm not able to perform a proper review. Except for the obvious: Races that can be triggered from user space are inacceptable. Regardless if there is a BUG_ON, a WARN_ON or nothing at all. On 12/

Re: [PATCH] BTRFS: Adds the files and options needed for Hybrid Storage

2016-01-02 Thread Martin Steigerwald
Hello, Am Freitag, 1. Januar 2016, 22:08:32 CET schrieb Sanidhya Solanki: > This patch adds the file required for Hybrid Storage. It contains > the memory, time and size limits for the cache and the statistics that > will be provided while the cache is operating. > It also adds the Makefile change

Re: [PATCH v4 2/2] virtio_balloon: Use a workqueue instead of "vballoon" kthread

2016-01-02 Thread Tejun Heo
Hello, On Fri, Jan 01, 2016 at 12:18:17PM +0200, Michael S. Tsirkin wrote: > > My initial idea was to use a dedicated workqueue. Michael S. Tsirkin > > suggested using a system one. Tejun Heo confirmed that the system > > workqueue has a pretty high concurrency level (256) by default. > > Therefor

Re: [PATCH, RESEND] ipc/shm: handle removed segments gracefully in shm_mmap()

2016-01-02 Thread Manfred Spraul
On 11/13/2015 08:23 PM, Davidlohr Bueso wrote: So considering EINVAL, even your approach to bumping up nattach by calling _shm_open earlier isn't enough. Races exposed to user called rmid can still occur between dropping the lock and doing ->mmap(). Ultimately this leads to all ipc_valid_obje

[PATCH] nbd: fix ifnullfree.cocci warnings

2016-01-02 Thread kbuild test robot
drivers/block/nbd.c:937:2-26: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values. drivers/block/nbd.c:918:2-26: WARNING: NULL check before freeing f

Re: [PATCH 1/5] nbd: Fix debugfs error handling

2016-01-02 Thread kbuild test robot
-handling/20160102-182030 base: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next coccinelle warnings: (new ones prefixed by >>) >> drivers/block/nbd.c:937:2-26: WARNING: NULL check before freeing functions >> like kfree, debugfs_remove, debugf

Re: [PATCH v2] crypto: algif_skcipher - Require setkey before accept(2)

2016-01-02 Thread Milan Broz
On 12/25/2015 08:40 AM, Herbert Xu wrote: > Dmitry Vyukov wrote: >> >> I am testing with your two patches: >> crypto: algif_skcipher - Use new skcipher interface >> crypto: algif_skcipher - Require setkey before accept(2) >> on top of a88164345b81292b55a8d4829fdd35c8d611cd7d (Dec 23). > > You sen

Re: CGroup Namespaces (v8)

2016-01-02 Thread Tejun Heo
On Fri, Jan 01, 2016 at 11:14:14AM -0800, Dan Williams wrote: > On Fri, Jan 1, 2016 at 10:06 AM, Serge E. Hallyn > wrote: > > On Fri, Jan 01, 2016 at 01:42:57AM -0800, Dan Williams wrote: > >> Commit 54b39d263704 "cgroup: cgroup namespace setns support" not > >> booting is a separate issue. > > >

Re: cgroup: BUG: unable to handle kernel NULL pointer dereference

2016-01-02 Thread Tejun Heo
On Fri, Jan 01, 2016 at 03:40:28PM -0800, Jeremiah Mahler wrote: > all, > > When running the latest linux-next (20151231) two of my machines > hang early in the boot sequence. The initial message is for a > NULL pointer dereference. > > BUG: unable to handle kernel NULL pointer dereference at

Re: [PATCH] BTRFS: Adds the files and options needed for Hybrid Storage

2016-01-02 Thread Sanidhya Solanki
On Sat, 02 Jan 2016 12:40:46 +0100 Martin Steigerwald wrote: > Or is this something different? Yes, Martin this patch starts the implementation that I hope will lead to the implementation of a Hybrid Cache to the BTRFS. However, there is no need to limit ourselves to just Flash devices. Depending

[PATCH] ipc/sem.c: Fix complex_count vs. simple op race

2016-01-02 Thread Manfred Spraul
Commit 6d07b68ce16a ("ipc/sem.c: optimize sem_lock()") introduced a race: sem_lock has a fast path that allows parallel simple operations. There are two reasons why a simple operation cannot run in parallel: - a non-simple operations is ongoing (sma->sem_perm.lock held) - a complex operation is sl

Re: GPF in shm_lock ipc

2016-01-02 Thread Dmitry Vyukov
On Sat, Jan 2, 2016 at 12:33 PM, Manfred Spraul wrote: > Hi Dmitry, > > shm locking differs too much from msg/sem locking, I never looked at it in > depth, so I'm not able to perform a proper review. > > Except for the obvious: Races that can be triggered from user space are > inacceptable. > Rega

Re: [PATCH 1/1] video: ARM CLCD: Add the framebuffer parameters setting in probe

2016-01-02 Thread Russell King - ARM Linux
On Wed, Dec 30, 2015 at 08:38:48AM +0800, Rongjun Ying wrote: > This patch fixes the user space applications can't get the framebuffer > parameters, if disable the fb console feature. > > Signed-off-by: Rongjun Ying I think this behaviour is intentional: userspace is expected to set the initial

Nokia N900: twl4030-power different data in DTS and board code

2016-01-02 Thread Pali Rohár
Hello, now I'm looking at differences between legacy board code and DTS file for Nokia N900 and I see some inconsistency for twl4030-power driver. In board code are defined more twl4030 power scripts which override defaults defined in twl4030-power code. See: https://git.kernel.org/cgit/linux/ke

Re: [PATCH] ASoC: cs35l32: avoid uninitialized variable access

2016-01-02 Thread Mark Brown
On Sat, Jan 02, 2016 at 12:19:52AM +0100, Arnd Bergmann wrote: > - if (i2c_client->dev.of_node) { > + if (IS_ENABLED(CONFIG_OF) && i2c_client->dev.of_node) { This would be a lot nicer if there was an __always_null annotation we could put on of_node for !OF configurations,

Nokia N900: Proper C-states

2016-01-02 Thread Pali Rohár
Hello, due to this Daniel Lezcano commit (ARM: OMAP3: cpuidle - remove rx51 cpuidle parameters table) https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=231900afba52d6faddfb480cde4132d4edc089bc we need patch cpuidle34xx.c code to fix commit for Nokia N900. See: https://g

Nokia N900: Adjust MPU OPP values

2016-01-02 Thread Pali Rohár
Hello, MPU OPP table table (omap36xx_vddcore_volt_data) defined in opp3xxx_data.c does not match Nokia N900 phone. For a long time we have dirty patch in linux-n900 tree for it, see: https://github.com/pali/linux-n900/commit/4644c5801d7469e2be01d847c61df3d934dadd8c Now when doing transition to d

[PATCH 0/3] net-rsi: Fine-tuning for two function implementations

2016-01-02 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 2 Jan 2016 15:36:25 +0100 A few update suggestions were taken into account from static source code analysis. Markus Elfring (3): Delete unnecessary variable initialisations in rsi_send_mgmt_pkt() Delete unnecessary variable initialisations in rsi_send_data_pkt

Charity Donation

2016-01-02 Thread Jeff Skoll
Hi, My name is Jeffrey Skoll, a philanthropist and the founder of one of the largest private foundations in the world. I believe strongly in ‘giving while living.’ I had one idea that never changed in my mind — that you should use your wealth to help people and I have decided to secretly give US

Re: [PATCH v2] crypto: algif_skcipher - Require setkey before accept(2)

2016-01-02 Thread Milan Broz
On 01/02/2016 12:52 PM, Milan Broz wrote: > On 12/25/2015 08:40 AM, Herbert Xu wrote: >> Dmitry Vyukov wrote: >>> >>> I am testing with your two patches: >>> crypto: algif_skcipher - Use new skcipher interface >>> crypto: algif_skcipher - Require setkey before accept(2) >>> on top of a88164345b812

[PATCH 1/3] rsi: Delete unnecessary variable initialisations in rsi_send_mgmt_pkt()

2016-01-02 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 2 Jan 2016 14:54:30 +0100 Omit explicit initialisation at the beginning for five local variables which are redefined before their first use. Signed-off-by: Markus Elfring --- drivers/net/wireless/rsi/rsi_91x_pkt.c | 10 +- 1 file changed, 5 insertions(+)

[PATCH 2/3] rsi: Delete unnecessary variable initialisations in rsi_send_data_pkt()

2016-01-02 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 2 Jan 2016 15:15:12 +0100 Omit explicit initialisation at the beginning for four local variables which are redefined before their first use. Signed-off-by: Markus Elfring --- drivers/net/wireless/rsi/rsi_91x_pkt.c | 8 1 file changed, 4 insertions(+), 4

[PATCH 3/3] rsi: Replace variable initialisations by assignments in rsi_send_data_pkt()

2016-01-02 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 2 Jan 2016 15:25:34 +0100 Replace explicit initialisation for two local variables at the beginning by assignments. Signed-off-by: Markus Elfring --- drivers/net/wireless/rsi/rsi_91x_pkt.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --g

Nokia N900: Broken lirc ir-rx51 driver

2016-01-02 Thread Pali Rohár
Hello, due to this commit (ARM: OMAP2+: Disable code that currently does not work with multiplaform) https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/drivers/media/rc/Kconfig?id=a62a6e98c370ccca37d353a5f763b532411a4c14 lirc driver for Nokia N900 (ir-rx51) cannot be enabled

Charity Donation

2016-01-02 Thread Jeff Skoll
Hi, My name is Jeffrey Skoll, a philanthropist and the founder of one of the largest private foundations in the world. I believe strongly in ‘giving while living.’ I had one idea that never changed in my mind — that you should use your wealth to help people and I have decided to secretly give US

Charity Donation

2016-01-02 Thread Jeff Skoll
Hi, My name is Jeffrey Skoll, a philanthropist and the founder of one of the largest private foundations in the world. I believe strongly in ‘giving while living.’ I had one idea that never changed in my mind — that you should use your wealth to help people and I have decided to secretly give US

Re: [PATCH 3/3] rsi: Replace variable initialisations by assignments in rsi_send_data_pkt()

2016-01-02 Thread Francois Romieu
SF Markus Elfring : > From: Markus Elfring > Date: Sat, 2 Jan 2016 15:25:34 +0100 > > Replace explicit initialisation for two local variables at the beginning > by assignments. It makes no sense for the 'adapter' variable. -- Ueimor -- To unsubscribe from this list: send the line "unsubscribe

net-rsi: Reconsider usage of variable "vap_id" in rsi_send_mgmt_pkt()

2016-01-02 Thread SF Markus Elfring
Hello, I have taken another look at the implementation of the function "rsi_send_mgmt_pkt". https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/tree/drivers/net/wireless/rsi/rsi_91x_pkt.c?id=e8c58e7a5a106c3d557fccd01cd4d1128f9bab38#n114 I find the following statement combination int

Re: [PATCH 1/2] mmc: omap_hsmmc: Add support for slot-name property in DT

2016-01-02 Thread Pali Rohár
On Monday 28 December 2015 15:55:28 Arnd Bergmann wrote: > On Monday 28 December 2015 15:54:35 Pali Rohár wrote: > > On Monday 28 December 2015 15:41:01 Arnd Bergmann wrote: > > > On Monday 28 December 2015 15:28:48 Pali Rohár wrote: > > > > On Monday 28 December 2015 15:14:50 Arnd Bergmann wrote:

Re: [PATCH 0/3] OOM detection rework v4

2016-01-02 Thread Tetsuo Handa
Tetsuo Handa wrote: > Michal Hocko wrote: > > On Mon 28-12-15 21:08:56, Tetsuo Handa wrote: > > > Tetsuo Handa wrote: > > > > I got OOM killers while running heavy disk I/O (extracting kernel > > > > source, > > > > running lxr's genxref command). (Environ: 4 CPUs / 2048MB RAM / no swap > > > > /

Re: [PATCH] power_suply: isp1704_charger: Fix isp1704_write() definition

2016-01-02 Thread Pali Rohár
On Friday 01 January 2016 12:33:03 Ivaylo Dimitrov wrote: > Hi Pali, > > On 1.01.2016 13:26, Pali Rohár wrote: > > On Friday 01 January 2016 12:03:29 Ivaylo Dimitrov wrote: > >> All calls to isp1704_write() are using parameter sequence of > >> isp1704_write(isp, reg, val) but the function is defi

Re: GPF in shm_lock ipc

2016-01-02 Thread Manfred Spraul
Hi Dmitry, On 01/02/2016 01:19 PM, Dmitry Vyukov wrote: On Sat, Jan 2, 2016 at 12:33 PM, Manfred Spraul wrote: Hi Dmitry, shm locking differs too much from msg/sem locking, I never looked at it in depth, so I'm not able to perform a proper review. Except for the obvious: Races that can be tr

Re: [PATCH 2/4] irqchip: bcm2836: Add SMP support for the 2836

2016-01-02 Thread Andrea Merello
Agreed. This probably comes from the downstream code, I think.. But I agree it's actually redundant. Thank you for pointing this out. On Sat, Jan 2, 2016 at 11:27 AM, Russell King - ARM Linux wrote: > On Sat, Dec 26, 2015 at 01:47:22PM -0800, Eric Anholt wrote: >> +int __init bcm2836_smp_boot_se

Re: [Question about DMA] Consistent memory?

2016-01-02 Thread James Bottomley
On Sat, 2016-01-02 at 10:39 +, Russell King - ARM Linux wrote: > On Thu, Dec 31, 2015 at 04:50:54PM +0900, Masahiro Yamada wrote: > > Hi. > > > > I am new to the Linux DMA APIs. > > > > First, I started by reading Documentation/DMA-API.txt, > > but I am confused with the term "consistent memo

Re: [PATCH 1/3] rsi: Delete unnecessary variable initialisations in rsi_send_mgmt_pkt()

2016-01-02 Thread kbuild test robot
-rsi-Fine-tuning-for-two-function-implementations/20160102-224740 base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master config: x86_64-randconfig-s2-01030012 (attached as .config) reproduce: # save the attached .config to linux build tree make

Re: [PATCH 7/8] xfs: Support for transparent PUD pages

2016-01-02 Thread Matthew Wilcox
On Thu, Dec 31, 2015 at 10:30:27AM +1100, Dave Chinner wrote: > > @@ -1637,6 +1669,7 @@ xfs_filemap_pfn_mkwrite( > > static const struct vm_operations_struct xfs_file_vm_ops = { > > .fault = xfs_filemap_fault, > > .pmd_fault = xfs_filemap_pmd_fault, > > + .pud_fault =

Re: Nokia N900: Broken lirc ir-rx51 driver

2016-01-02 Thread Tony Lindgren
Hi, * Pali Rohár [160102 06:46]: > --- a/drivers/media/rc/ir-rx51.c > +++ b/drivers/media/rc/ir-rx51.c > @@ -25,9 +25,9 @@ > #include > #include > #include > +#include > > -#include > -#include > +#include "../../../arch/arm/plat-omap/include/plat/dmtimer.h" Well we don't want to expo

Re: [PATCH 1/8] mm: Add optional support for PUD-sized transparent hugepages

2016-01-02 Thread Matthew Wilcox
On Mon, Dec 28, 2015 at 12:05:51PM +0200, Kirill A. Shutemov wrote: > On Thu, Dec 24, 2015 at 11:20:30AM -0500, Matthew Wilcox wrote: > > diff --git a/include/linux/mm.h b/include/linux/mm.h > > index 4bf3811..e14634f 100644 > > --- a/include/linux/mm.h > > +++ b/include/linux/mm.h > > @@ -1958,6 +

Re: Nokia N900: twl4030-power different data in DTS and board code

2016-01-02 Thread Tony Lindgren
* Pali Rohár [160102 06:14]: > Hello, > > now I'm looking at differences between legacy board code and DTS file > for Nokia N900 and I see some inconsistency for twl4030-power driver. > > In board code are defined more twl4030 power scripts which override > defaults defined in twl4030-power code

Re: Nokia N900: Adjust MPU OPP values

2016-01-02 Thread Tony Lindgren
* Pali Rohár [160102 06:31]: > Hello, > > MPU OPP table table (omap36xx_vddcore_volt_data) defined in > opp3xxx_data.c does not match Nokia N900 phone. For a long time we have > dirty patch in linux-n900 tree for it, see: > > https://github.com/pali/linux-n900/commit/4644c5801d7469e2be01d847c61d

[PATCH 0/5] xen-netback: Fine-tuning for three function implementations

2016-01-02 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 2 Jan 2016 18:46:45 +0100 A few update suggestions were taken into account from static source code analysis. Markus Elfring (5): Delete an unnecessary assignment in connect_rings() Delete an unnecessary goto statement in connect_rings() Replace a variable in

[PATCH 1/5] xen-netback: Delete an unnecessary assignment in connect_rings()

2016-01-02 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 2 Jan 2016 17:32:40 +0100 Remove the assignment for a local variable because its value is not changed compared to the one from a previous function call. Signed-off-by: Markus Elfring --- drivers/net/xen-netback/xenbus.c | 1 - 1 file changed, 1 deletion(-) diff

[PATCH 2/5] xen-netback: Delete an unnecessary goto statement in connect_rings()

2016-01-02 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 2 Jan 2016 17:50:21 +0100 One goto statement referred to a source code position directly behind it. Thus omit such an unnecessary jump. Signed-off-by: Markus Elfring --- drivers/net/xen-netback/xenbus.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) d

[PATCH 3/5] xen-netback: Replace a variable initialisation by an assignment in read_xenbus_vif_flags()

2016-01-02 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 2 Jan 2016 18:01:57 +0100 Replace an explicit initialisation for one local variable at the beginning by an assignment. Signed-off-by: Markus Elfring --- drivers/net/xen-netback/xenbus.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/d

[PATCH 4/5] xen-netback: Replace a variable initialisation by an assignment in xen_register_watchers()

2016-01-02 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 2 Jan 2016 18:23:16 +0100 Replace an explicit initialisation for one local variable at the beginning by an assignment. Signed-off-by: Markus Elfring --- drivers/net/xen-netback/xenbus.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/driver

[PATCH 5/5] xen-netback: Delete an unnecessary variable initialisation in xen_register_watchers()

2016-01-02 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 2 Jan 2016 18:28:26 +0100 Omit explicit initialisation at the beginning for one local variable that is redefined before its first use. Signed-off-by: Markus Elfring --- drivers/net/xen-netback/xenbus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [Question about DMA] Consistent memory?

2016-01-02 Thread Russell King - ARM Linux
On Sat, Jan 02, 2016 at 08:17:51AM -0800, James Bottomley wrote: > On Sat, 2016-01-02 at 10:39 +, Russell King - ARM Linux wrote: > > On Thu, Dec 31, 2015 at 04:50:54PM +0900, Masahiro Yamada wrote: > > > Hi. > > > > > > I am new to the Linux DMA APIs. > > > > > > First, I started by reading

Re: [PATCH v2 1/3] clk: bcm2835: Add bindings for the auxiliary peripheral clock gates.

2016-01-02 Thread Eric Anholt
Michael Turquette writes: > Hi Arnd, > > Quoting Arnd Bergmann (2015-12-30 01:29:02) >> It's also ok to merge the header file and binding with either the dts file >> changes or the driver and then do the other part the following release. >> >> In the past, we've worked around the issue by mergin

Re: [PATCH 3/3] net-iwlegacy: Another refactoring for il_eeprom_init()

2016-01-02 Thread Souptick Joarder
On Sat, Jan 2, 2016 at 2:02 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Fri, 1 Jan 2016 21:16:01 +0100 > > Rename a jump label according to the current Linux coding style convention. > > Signed-off-by: Markus Elfring > --- > drivers/net/wireless/intel/iwlegacy/common.c | 4 ++--

Re: cgroup: BUG: unable to handle kernel NULL pointer dereference

2016-01-02 Thread Serge E. Hallyn
On Sat, Jan 02, 2016 at 06:54:37AM -0500, Tejun Heo wrote: > On Fri, Jan 01, 2016 at 03:40:28PM -0800, Jeremiah Mahler wrote: > > all, > > > > When running the latest linux-next (20151231) two of my machines > > hang early in the boot sequence. The initial message is for a > > NULL pointer derefe

[PATCH v2 1/3] rsi: Delete unnecessary variable initialisations in rsi_send_mgmt_pkt()

2016-01-02 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 2 Jan 2016 19:22:36 +0100 Omit explicit initialisation at the beginning for four local variables which are redefined before their first use. Signed-off-by: Markus Elfring --- drivers/net/wireless/rsi/rsi_91x_pkt.c | 8 1 file changed, 4 insertions(+), 4

Re: [PATCH] iio: qcom-spmi-vadc: One check less in vadc_measure_ref_points() after error detection

2016-01-02 Thread Jonathan Cameron
On 26/12/15 13:04, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 26 Dec 2015 13:53:15 +0100 > > This issue was detected by using the Coccinelle software. > > Move the jump label directly before the desired log statement > so that the variable "ret" does not need to be checked once

Re: [Question about DMA] Consistent memory?

2016-01-02 Thread Mike Looijmans
On 2-1-2016 11:39, Russell King - ARM Linux wrote: On Thu, Dec 31, 2015 at 04:50:54PM +0900, Masahiro Yamada wrote: Hi. I am new to the Linux DMA APIs. First, I started by reading Documentation/DMA-API.txt, but I am confused with the term "consistent memory". Just read "coherent memory" inst

Charity Donation

2016-01-02 Thread Jeff Skoll
Hi, My name is Jeffrey Skoll, a philanthropist and the founder of one of the largest private foundations in the world. I believe strongly in ‘giving while living.’ I had one idea that never changed in my mind — that you should use your wealth to help people and I have decided to secretly give US

[PATCH] staging: most: add __iomem for io_base and registers

2016-01-02 Thread Hugo Camboulive
This removes a few Sparse warnings. Signed-off-by: Hugo Camboulive --- drivers/staging/most/hdm-dim2/dim2_hal.c | 6 +++--- drivers/staging/most/hdm-dim2/dim2_hal.h | 6 +++--- drivers/staging/most/hdm-dim2/dim2_hdm.c | 6 +++--- drivers/staging/most/hdm-dim2/dim2_hdm.h | 2 +- 4 files changed,

[PATCH] ext4: disable retry logic in ext4_set_encrypted_filename

2016-01-02 Thread Arnd Bergmann
gcc correctly warns that the ctx variable in ext4_set_encrypted_filename has gone out of scope in ext4_set_encrypted_filename if we enter the retry path and a 'goto' into the previous code block can not guarantee to get the contents back: fs/ext4/namei.c: In function 'ext4_set_encrypted_filename':

[PATCH] ARM: pxa: add defconfig covering all the boards

2016-01-02 Thread Robert Jarzmik
Add a defconfig covering all known pxa board, ie. all selectable machine files in arch/arm/mach-pxa/*.c. This defconfig was built by doing : - aggregation of all known defconfigs by cat am200epdkit_defconfig cm_x2xx_defconfig cm_x300_defconfig colibri_pxa270_defcon

Re: [PATCH v2] crypto: algif_skcipher - Require setkey before accept(2)

2016-01-02 Thread Stephan Mueller
Am Samstag, 2. Januar 2016, 15:41:34 schrieb Milan Broz: Hi Milan, > On 01/02/2016 12:52 PM, Milan Broz wrote: > > On 12/25/2015 08:40 AM, Herbert Xu wrote: > >> Dmitry Vyukov wrote: > >>> I am testing with your two patches: > >>> crypto: algif_skcipher - Use new skcipher interface > >>> crypto:

Re: [Question about DMA] Consistent memory?

2016-01-02 Thread James Bottomley
On Sat, 2016-01-02 at 19:35 +0100, Mike Looijmans wrote: > On 2-1-2016 11:39, Russell King - ARM Linux wrote: > > On Thu, Dec 31, 2015 at 04:50:54PM +0900, Masahiro Yamada wrote: > > > Hi. > > > > > > I am new to the Linux DMA APIs. > > > > > > First, I started by reading Documentation/DMA-API.tx

Re: [PATCH v2] crypto: algif_skcipher - Require setkey before accept(2)

2016-01-02 Thread Milan Broz
On 01/02/2016 09:03 PM, Stephan Mueller wrote: > Am Samstag, 2. Januar 2016, 15:41:34 schrieb Milan Broz: > > Hi Milan, > ... >>> Hi Herbert, >>> >>> this patch breaks userspace in cryptsetup... >>> >>> We use algif_skcipher in cryptsetup (for years, even before >>> there was Stephan's library)

Re: [PATCH] staging: most: add __iomem for io_base and registers

2016-01-02 Thread Al Viro
On Sat, Jan 02, 2016 at 08:30:21PM +, Hugo Camboulive wrote: > This removes a few Sparse warnings. > + g.dim2 = (struct dim2_regs __iomem *)dim_base_address; > -u8 dim_startup(void *dim_base_address, u32 mlb_clock); > +u8 dim_startup(void __iomem *dim_base_address, u32 mlb_clock); Umm...

Re: Nokia N900: Adjust MPU OPP values

2016-01-02 Thread Nishanth Menon
On 01/02/2016 11:16 AM, Tony Lindgren wrote: > * Pali Rohár [160102 06:31]: >> Hello, >> >> MPU OPP table table (omap36xx_vddcore_volt_data) defined in >> opp3xxx_data.c does not match Nokia N900 phone. For a long time we have >> dirty patch in linux-n900 tree for it, see: >> >> https://github.com

Re: [RESEND PATCH v2 0/9] eeprom: at24: at24cs series serial number read

2016-01-02 Thread Wolfram Sang
On Fri, Dec 11, 2015 at 02:55:10PM +0100, Bartosz Golaszewski wrote: > 2015-12-11 13:08 GMT+01:00 Wolfram Sang : > > On Wed, Dec 02, 2015 at 11:25:17AM +0100, Bartosz Golaszewski wrote: > >> Chips from the at24cs EEPROM series have an additional read-only memory > >> area > >> containing a factory

[PATCH 0/3] NFC-mei_phy: Fine-tuning for two function implementations

2016-01-02 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 2 Jan 2016 21:47:30 +0100 A few update suggestions were taken into account from static source code analysis. Markus Elfring (3): Refactoring for mei_nfc_connect() Refactoring for mei_nfc_if_version() Delete an unnecessary variable initialisation in mei_nfc_i

[PATCH 1/3] NFC-mei_phy: Refactoring for mei_nfc_connect()

2016-01-02 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 2 Jan 2016 21:21:24 +0100 This issue was detected by using the Coccinelle software. Adjust jump targets according to the current Linux coding style convention. Signed-off-by: Markus Elfring --- drivers/nfc/mei_phy.c | 13 ++--- 1 file changed, 6 inserti

[PATCH 2/3] NFC-mei_phy: Refactoring for mei_nfc_if_version()

2016-01-02 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 2 Jan 2016 21:33:04 +0100 Rename a jump label according to the current Linux coding style convention. Signed-off-by: Markus Elfring --- drivers/nfc/mei_phy.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/nfc/mei_phy.c b/drivers

[PATCH 3/3] NFC-mei_phy: Delete an unnecessary variable initialisation in mei_nfc_if_version()

2016-01-02 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 2 Jan 2016 21:40:10 +0100 Omit explicit initialisation at the beginning for one local variable that is redefined before its first use. Signed-off-by: Markus Elfring --- drivers/nfc/mei_phy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dri

Re: [PATCH] staging: most: add __iomem for io_base and registers

2016-01-02 Thread Hugo Camboulive
On Saturday 02 Jan 2016 20:33:23 (+), Al Viro wrote: > On Sat, Jan 02, 2016 at 08:30:21PM +, Hugo Camboulive wrote: > > This removes a few Sparse warnings. > > > + g.dim2 = (struct dim2_regs __iomem *)dim_base_address; > > > -u8 dim_startup(void *dim_base_address, u32 mlb_clock); > > +u

Re: [PATCH] DT: i2c: Add Epson RX8010 to list of trivial devices

2016-01-02 Thread Wolfram Sang
On Sun, Dec 27, 2015 at 05:02:48PM +0200, Andy Shevchenko wrote: > On Wed, Dec 23, 2015 at 8:38 PM, Akshay Bhat wrote: > > This adds devicetree documentation for the bindings of rtc-rx8010 > > driver. > > > > Signed-off-by: Akshay Bhat > > --- > > Documentation/devicetree/bindings/i2c/trivial-de

Re: [PATCH] DT: i2c: Update vendor prefix for 24c00

2016-01-02 Thread Wolfram Sang
On Sun, Dec 27, 2015 at 04:57:48PM +0200, Andy Shevchenko wrote: > On Wed, Dec 23, 2015 at 9:18 PM, Akshay Bhat wrote: > > "at" is not a valid vendor prefix, correcting the same to "atmel" > > > > I'm afraid you can't just do this change alone as it's used in some > DTS. Though you may deprecated

Re: [PATCH 2/2] net-qmi_wwan: Delete an unnecessary variable initialisation in qmi_wwan_register_subdriver()

2016-01-02 Thread Bjørn Mork
SF Markus Elfring writes: > From: Markus Elfring > Date: Fri, 1 Jan 2016 17:35:03 +0100 > > Omit explicit initialisation at the beginning for one local variable > that is redefined before its first use. This patch is unnecessary. The variable initialisation is redundant. See the difference? S

[PATCH v2] staging: most: add __iomem for io_base and registers

2016-01-02 Thread Hugo Camboulive
This removes a few Sparse warnings. Signed-off-by: Hugo Camboulive --- drivers/staging/most/hdm-dim2/dim2_hal.c | 4 ++-- drivers/staging/most/hdm-dim2/dim2_hal.h | 7 --- drivers/staging/most/hdm-dim2/dim2_hdm.c | 6 +++--- drivers/staging/most/hdm-dim2/dim2_hdm.h | 2 +- 4 files changed, 1

Re: [PATCH v4 2/2] virtio_balloon: Use a workqueue instead of "vballoon" kthread

2016-01-02 Thread Michael S. Tsirkin
On Sat, Jan 02, 2016 at 06:43:16AM -0500, Tejun Heo wrote: > Hello, > > On Fri, Jan 01, 2016 at 12:18:17PM +0200, Michael S. Tsirkin wrote: > > > My initial idea was to use a dedicated workqueue. Michael S. Tsirkin > > > suggested using a system one. Tejun Heo confirmed that the system > > > workq

Re: [PATCH 1/2] net-qmi_wwan: Refactoring for qmi_wwan_bind()

2016-01-02 Thread Bjørn Mork
SF Markus Elfring writes: > From: Markus Elfring > Date: Fri, 1 Jan 2016 17:32:07 +0100 > > Reduce the scope for the local variable "desc" to one branch > of an if statement. This patch is harmless. But is also pointless. You could at least try to explain why this must be changed. I'm not in

Re: Nokia N900: twl4030-power different data in DTS and board code

2016-01-02 Thread Pali Rohár
On Saturday 02 January 2016 18:14:31 Tony Lindgren wrote: > * Pali Rohár [160102 06:14]: > > Hello, > > > > now I'm looking at differences between legacy board code and DTS > > file for Nokia N900 and I see some inconsistency for twl4030-power > > driver. > > > > In board code are defined more t

Re: [PATCH] [BUG] clk: rockchip: don't mark clock names as initconst

2016-01-02 Thread Michael Turquette
Quoting Heiko Stübner (2016-01-01 14:05:10) > Am Freitag, 1. Januar 2016, 22:50:43 schrieb Arnd Bergmann: > > On Friday 01 January 2016 18:06:30 Heiko Stübner wrote: > > > "[PATCH] clk: rockchip: fix section mismatches with new child-clocks" [0] > > > > > > should be in Mike's + Stephen's inbox si

Re: cgroup: BUG: unable to handle kernel NULL pointer dereference

2016-01-02 Thread Jeremiah Mahler
Serge, On Sat, Jan 02, 2016 at 12:24:16PM -0600, Serge E. Hallyn wrote: [...] > > Tried to reproduce with setting CONFIG_CFQ_GROUP_IOSCHED=y, but did not > succeed. Could you send me the .config? Also, if someone could send > the objdump -d output that might help. Though really, it seems clear

Re: Nokia N900: Proper C-states

2016-01-02 Thread Daniel Lezcano
On 01/02/2016 03:26 PM, Pali Rohár wrote: Hello, due to this Daniel Lezcano commit (ARM: OMAP3: cpuidle - remove rx51 cpuidle parameters table) https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=231900afba52d6faddfb480cde4132d4edc089bc we need patch cpuidle34xx.c code t

Charity Donation

2016-01-02 Thread Jeff Skoll
Hi, My name is Jeffrey Skoll, a philanthropist and the founder of one of the largest private foundations in the world. I believe strongly in ‘giving while living.’ I had one idea that never changed in my mind — that you should use your wealth to help people and I have decided to secretly give US

  1   2   3   >