On Friday 01 January 2016 12:33:03 Ivaylo Dimitrov wrote: > Hi Pali, > > On 1.01.2016 13:26, Pali Rohár wrote: > > On Friday 01 January 2016 12:03:29 Ivaylo Dimitrov wrote: > >> All calls to isp1704_write() are using parameter sequence of > >> isp1704_write(isp, reg, val) but the function is defined as > >> isp1704_write(isp, val, reg). Fix isp1704_write function > >> definition so that the driver to be functional. > >> > >> Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov...@gmail.com> > > > > Reviewed-by: Pali Rohár <pali.ro...@gmail.com> > > > > This problem is there since inclusion of driver itself. No idea why > > that driver could work... I remember that it detected correctly > > type of charger. > > > > I will test this patch on real N900 HW in one or two weeks to check > > how it behave after patching... > > Well, I tested in on real HW, wall charger as well as USB were > correctly detected. No idea what else needs to be tested, but I guess > if you guide me, I can test whatever is needed. > > Ivo
I think nothing more is needed to test. But I want to see how driver behave with and without this patch. -- Pali Rohár pali.ro...@gmail.com
signature.asc
Description: This is a digitally signed message part.
