Re: [RESEND PATCH nouveau 2/3] volt: allow non-bios voltage scaling

2014-11-29 Thread Alexandre Courbot
On Fri, Nov 28, 2014 at 8:12 PM, Vince Hsu wrote: > Signed-off-by: Vince Hsu Make sure you always write a short summary for your patches, even if the title sounds sufficient. At the very least this patch makes the code easier to read, so: Acked-by: Alexandre Courbot -- To unsubscribe from thi

Re: [PATCH] drivers:net:wireless: Add mutex locking for function, b43_op_beacon_set_time in main.c

2014-11-29 Thread Rafał Miłecki
On 29 November 2014 at 04:32, nick wrote: > I don't have hardware for this driver on me, so I didn't test it. However > this seems to > be correct from my reading of the code around this function and other locking > related > to this driver. So do you say it's not executed in an atomic? >From

Re: [PATCH] drivers:net:wireless: Add mutex locking for function, b43_op_beacon_set_time in main.c

2014-11-29 Thread Michael Büsch
On Fri, 28 Nov 2014 22:32:30 -0500 nick wrote: > I don't have hardware for this driver on me, so I didn't test it. However > this seems to > be correct from my reading of the code around this function and other locking > related > to this driver. From the current docs: > * @set_tim: Set TIM

Re: [PATCH] drivers:net:wireless: Add mutex locking for function, b43_op_beacon_set_time in main.c

2014-11-29 Thread Rafał Miłecki
On 29 November 2014 at 09:56, Michael Büsch wrote: > On Fri, 28 Nov 2014 22:32:30 -0500 > nick wrote: > >> I don't have hardware for this driver on me, so I didn't test it. However >> this seems to >> be correct from my reading of the code around this function and other >> locking related >> to

[PATCH 1/1] urandom: handle signals immediately

2014-11-29 Thread Heinrich Schuchardt
Without the patch device /dev/urandom only considers signals when a rescheduling of the thread is requested. This may imply that signals will not be handled for time intervals in excess of 30s. With the patch signals are handled in every round copying 10 bytes if more than 256 bytes have been coll

Re: [BUG] linux-next: 20141127 boot hang

2014-11-29 Thread Jeremiah Mahler
all, On Fri, Nov 28, 2014 at 03:32:50PM -0800, Jeremiah Mahler wrote: > On Thu, Nov 27, 2014 at 03:16:19PM -0800, Jeremiah Mahler wrote: > > > > I just tried the latest linux-next 20141127 (commit 3bcf494d225fd19) and > > it hangs very early in the boot sequence, after decompressing the kernel >

Re: [patch v2] adjtimex.2: add explanation about ADJ_TAI action

2014-11-29 Thread Michael Kerrisk (man-pages)
Hello Laurent, Thanks for working on this. I have one question; see below. On 11/29/2014 12:02 AM, Laurent Georget wrote: > Le 28/11/2014 22:00, Richard Cochran a écrit : >> On Fri, Nov 28, 2014 at 02:40:44PM +0100, Laurent Georget wrote: >>> @@ -101,7 +99,19 @@ combination of zero or more of the

Re: [patch v2] adjtimex.2: add explanation about ADJ_TAI action

2014-11-29 Thread Richard Cochran
On Sat, Nov 29, 2014 at 12:02:33AM +0100, Laurent Georget wrote: > > Thank you for your comments. Below is a new version of the patch. Less > unrelevant chit-chat, more useful information (hopefully). Looks better to me. Thanks, Richard -- To unsubscribe from this list: send the line "unsubscrib

RE: [tracecompass-dev] Support for Perf CTF traces now in master (was Re: FW: [RFC 0/5] perf tools: Add perf data CTF conversion)

2014-11-29 Thread Jerome CORRENOZ
Hi Alexandre, Catching with this thread of email: could you please share some links to documentation/screenshot about perf support with trace compass ? Regards, Jerome -Original Message- From: tracecompass-dev-boun...@eclipse.org [mailto:tracecompass-dev-boun...@eclipse.org] On Behal

Out-of-bounds write in driver_override_show

2014-11-29 Thread Dmitry Vyukov
Hello, I am working on Kernel AddressSanitizer, a fast memory error detector for kernel: https://code.google.com/p/address-sanitizer/wiki/AddressSanitizerForKernel Here is an error report that I got while running trinity: BUG: AddressSanitizer: out of bounds access in vsnprintf+0xd0/0x890 at add

Re: [PATCH] tty: serial: serial-omap: depend on !8250_omap

2014-11-29 Thread Sebastian Andrzej Siewior
* Sebastian Andrzej Siewior | 2014-11-26 23:01:46 [+0100]: >Technically speaking this is not required. If both are enabled then the >Maikefile order says that 8250 one wins, the second is never probed. > >If we choose to enable 8250_omap via defconfig then one might get supprised >that his console

[GIT PULL] irq updates for 3.18

2014-11-29 Thread Thomas Gleixner
Linus, please pull the latest irq-urgent-for-linus git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git irq-urgent-for-linus Three fixlets from the ARM SoC camp: - Correct irqdomain initialization for atmel-aic - Correct error handling for device tree parsing in bcm con

Re: [patch v2] adjtimex.2: add explanation about ADJ_TAI action

2014-11-29 Thread Laurent Georget
Hello, Le 29/11/2014 10:27, Michael Kerrisk (man-pages) a écrit : > Hello Laurent, > > Thanks for working on this. I have one question; see below. > >> >> diff --git a/man2/adjtimex.2 b/man2/adjtimex.2 >> index 20a2f0b..871e607 100644 >> --- a/man2/adjtimex.2 >> +++ b/man2/adjtimex.2 >> @@ -26,9

Re: linux-next: manual merge of the block tree with the ext4 tree

2014-11-29 Thread Sabrina Dubroca
Hello, [adding Jeremiah Mahler to CC] 2014-11-27, 14:53:47 +1100, Stephen Rothwell wrote: > Hi Jens, > > Today's linux-next merge of the block tree got a conflict in > fs/fs-writeback.c between commit ef7fdf5e8c87 ("vfs: add support for a > lazytime mount option") from the ext4 tree and commit 9

[PATCH] Fixed type id

2014-11-29 Thread Ren Kimura
From: RKX1209 Signed-off-by: RKX1209 --- arch/x86/mm/init_32.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/x86/mm/init_32.c b/arch/x86/mm/init_32.c index c8140e1..957f7f0 100644 --- a/arch/x86/mm/init_32.c +++ b/arch/x86/mm/init_32.c @@ -304,14 +304,14 @@ repeat

Re: [PATCH] Fixed type id

2014-11-29 Thread Richard Weinberger
On Sat, Nov 29, 2014 at 11:13 AM, Ren Kimura wrote: > From: RKX1209 > > Signed-off-by: RKX1209 What issue does this fix? On 32bit an address should fit into an integer. > --- > arch/x86/mm/init_32.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/x86/mm/init_

Re: [PATCH] drm: i2c: tda998x: Retry fetching the EDID if it fails first time.

2014-11-29 Thread Jean-Francois Moine
On Fri, 28 Nov 2014 09:02:39 + Andrew Jackson wrote: > > It seems that your patch is deprecated by Laurent Pinchart's > > [PATCH] drm: tda998x: Use drm_do_get_edid() > > http://lists.freedesktop.org/archives/dri-devel/2014-November/072906.html > > > > Thank you for the heads-up, I'd n

Re: [PATCH v2] fs-fat: Less function calls in fat_fill_super() after error detection

2014-11-29 Thread OGAWA Hirofumi
SF Markus Elfring writes: > From: Markus Elfring > Date: Sat, 29 Nov 2014 07:37:34 +0100 > > The iput() function was called in an inefficient way by the implementation > of the fat_fill_super() function in case of an allocation failure. > The corresponding source code was improved by deletion of

Re: [BUG] linux-next: 20141127 boot hang

2014-11-29 Thread Stephen Rothwell
Hi Jeremiah, On Sat, 29 Nov 2014 01:15:10 -0800 Jeremiah Mahler wrote: > > all, > > On Fri, Nov 28, 2014 at 03:32:50PM -0800, Jeremiah Mahler wrote: > > On Thu, Nov 27, 2014 at 03:16:19PM -0800, Jeremiah Mahler wrote: > > > > > > I just tried the latest linux-next 20141127 (commit 3bcf494d225fd

Re: [PATCH] e1000: remove unused variables

2014-11-29 Thread Lino Sanfilippo
On 29.11.2014 00:28, Florian Fainelli wrote: > Also, if you do a read that is not stored in any return value, the > compiler is now free to remove that actual read, This does not apply to reads from iomem (see "volatile" specifier in readl()). Regards, Lino -- To unsubscribe from this list: se

[RFC PATCH] mm/zsmalloc: allocate exactly size of struct zs_pool

2014-11-29 Thread Ganesh Mahendran
In zs_create_pool(), we allocate memory more then sizeof(struct zs_pool) ovhd_size = roundup(sizeof(*pool), PAGE_SIZE); This patch allocate memory of exactly needed size. Signed-off-by: Ganesh Mahendran --- mm/zsmalloc.c |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --gi

Re: [PATCH 1/2] ASoC: rt5677: Add ACPI device probing

2014-11-29 Thread Mark Brown
On Sat, Nov 29, 2014 at 12:51:59AM +0100, Rafael J. Wysocki wrote: > On Friday, November 28, 2014 04:00:36 PM Mark Brown wrote: > > OK, we probably should have one to aid discoverability since as far as I > > can tell what's happening is that people (hi Intel!) are allocating > > their own identif

[PATCH] Drivers:staging:clocking-wizard: Added a newline

2014-11-29 Thread Athira S
Fixed checkpatch warning: Missing a newline after declarations Signed-off-by: Athira S --- drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c b/drivers/staging/clocking-wizard/clk-xl

Re: [PATCH v2] fs-fat: Less function calls in fat_fill_super() after error detection

2014-11-29 Thread Julia Lawall
On Sat, 29 Nov 2014, OGAWA Hirofumi wrote: > SF Markus Elfring writes: > > > From: Markus Elfring > > Date: Sat, 29 Nov 2014 07:37:34 +0100 > > > > The iput() function was called in an inefficient way by the implementation > > of the fat_fill_super() function in case of an allocation failure. >

Re: [tip:irq/irqdomain] irqdomain: Introduce helper function irq_domain_add_hierarchy()

2014-11-29 Thread Borislav Petkov
On Sun, Nov 23, 2014 at 10:11:44AM -0800, tip-bot for Jiang Liu wrote: > Commit-ID: afb7da83b9f476728623130703acb553d7c7c4d9 > Gitweb: http://git.kernel.org/tip/afb7da83b9f476728623130703acb553d7c7c4d9 > Author: Jiang Liu > AuthorDate: Sat, 15 Nov 2014 22:24:02 +0800 > Committer: Thomas

[PATCH] staging:drivers:staging:clocking-wizard:clk-xlnx-clock-wizard.c: Added a line after declaration

2014-11-29 Thread Anjana Sasindran
This patch fix the checkpatch.pl warning WARNING:Missing a blank line after declaration Signed-off-by: Anjana Sasindran --- drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c b/driv

Re: [PATCH/RFC v8 02/14] Documentation: leds: Add description of LED Flash class extension

2014-11-29 Thread Pavel Machek
Hi! > +Flash LED handling under Linux > +== > + > +Some LED devices support two modes - torch and flash. The modes are > +supported by the LED class (see Documentation/leds/leds-class.txt) > +and LED Flash class respectively. > + > +In order to enable support for flash

Re: [PATCH/RFC v8 04/14] v4l2-async: change custom.match callback argument type

2014-11-29 Thread Pavel Machek
On Fri 2014-11-28 10:17:56, Jacek Anaszewski wrote: > It is useful to have an access to the async sub-device > being matched, not only to the related struct device. > Change match callback argument from struct device > to struct v4l2_subdev. It will allow e.g. for matching > a sub-device by its "na

Re: [PATCH] ACPI / video: check _DOD list when creating backlight device

2014-11-29 Thread Aaron Lu
On 11/29/2014 01:18 AM, Brian Norris wrote: > On Fri, Nov 28, 2014 at 07:55:00PM +0800, Aaron Lu wrote: >> On 11/28/2014 05:59 PM, Brian Norris wrote: >>> And indeed, there is a regression! My Dell Latituded E6410's backlight >>> control no longer works after this commit, and I get messages like th

Re: [PATCH/RFC v8 07/14] exynos4-is: Add support for v4l2-flash subdevs

2014-11-29 Thread Pavel Machek
On Fri 2014-11-28 10:17:59, Jacek Anaszewski wrote: > This patch adds suppport for external v4l2-flash devices. > The support includes parsing "flashes" Device Tree property > and asynchronous subdevice registration. > > Signed-off-by: Jacek Anaszewski > Acked-by: Kyungmin Park > Cc: Sylwester N

[PATCH] staging:drivers:staging:ft1000:ft1000_pcmcia:ft1000_hw.c:Added a blank line after declaration

2014-11-29 Thread Anjana Sasindran
This patch fix the checkpatch.pl warning WARNING: Missing a blank line after declaration Signed-off-by: Anjana Sasindran --- drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c b/drivers/staging/f

Re: [PATCH] staging:drivers:staging:ft1000:ft1000_pcmcia:ft1000_hw.c:Added a blank line after declaration

2014-11-29 Thread Belisko Marek
Hi Anjana, please update subject to something like staging: ft1000: Marek On Sat, Nov 29, 2014 at 2:34 PM, Anjana Sasindran wrote: > This patch fix the checkpatch.pl warning > > WARNING: Missing a blank line after declaration > > Signed-off-by: Anjana Sasindran > --- > drivers/staging/f

[PATCH 1/1] HID: Wacom: Deletion of an unnecessary check before the function call "vfree"

2014-11-29 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 29 Nov 2014 14:34:59 +0100 The vfree() function performs also input parameter validation. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/net/ethernet/sun/cassini.c

Re: [PATCH] Staging: ft1000 : ft1000-pcmcia: replace __attribute ((__packed__) with __packed macro per coding style guidelines in ft1000_dnld.c

2014-11-29 Thread Belisko Marek
Please use shorter summary phrase (which appear an subject) + split commit message to more line (not one long line). marek On Sat, Nov 29, 2014 at 3:49 AM, Geoff Darst wrote: > Replace two instances of __attribute ((__packed__) with __packed macro to > address the warning found by the checkpatc

[PATCH] staging:ft1000:ft1000_pcmcia:ft1000_hw.c:Added a blank line after declaration

2014-11-29 Thread Anjana Sasindran
This patch fix the checkpatch.pl warning WARNING: Missing a blank line after declaration Signed-off-by: Anjana Sasindran --- drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c b/drivers/staging/f

Re: [PATCH v2] fs-fat: Less function calls in fat_fill_super() after error detection

2014-11-29 Thread OGAWA Hirofumi
Julia Lawall writes: >> iput() checks NULL of inode. What is wrong just remove NULL check, >> instead of adding new jump labels? > > Personally, I prefer that code that can be statically determined not to > need to be executed not to be executed. It can make the code easier to > understand, beca

[PATCH 1/1] net: cassini: Deletion of an unnecessary check before the function call "vfree"

2014-11-29 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 29 Nov 2014 14:34:59 +0100 The vfree() function performs also input parameter validation. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/net/ethernet/sun/cassini.c

Re: [tip:irq/irqdomain] irqdomain: Introduce helper function irq_domain_add_hierarchy()

2014-11-29 Thread Jiang Liu
On 2014/11/29 20:53, Borislav Petkov wrote: > On Sun, Nov 23, 2014 at 10:11:44AM -0800, tip-bot for Jiang Liu wrote: >> Commit-ID: afb7da83b9f476728623130703acb553d7c7c4d9 >> Gitweb: >> http://git.kernel.org/tip/afb7da83b9f476728623130703acb553d7c7c4d9 >> Author: Jiang Liu >> AuthorDate:

[PATCH 1/1] HID: Wacom: Deletion of unnecessary checks before the function call "input_free_device"

2014-11-29 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 29 Nov 2014 15:16:01 +0100 The input_free_device() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

Re: fs-fat: Less function calls in fat_fill_super() after error detection

2014-11-29 Thread SF Markus Elfring
> More labels are more chances of bug (and we don't care micro optimize > on this error path), isn't it? I would prefer that a few jump targets can be redirected so that unnecessary function calls (and corresponding checks) can be avoided. > Increasing the chance of bugs and bothers developers f

Re: [tip:irq/irqdomain] irqdomain: Introduce helper function irq_domain_add_hierarchy()

2014-11-29 Thread Borislav Petkov
On Sat, Nov 29, 2014 at 10:29:33PM +0800, Jiang Liu wrote: > Thanks for reporting and fixing this. How about using GFP_ATOMIC > here? Well, I don't see the need to use GFP_ATOMIC if we absolutely don't have to. And in this case lockdep is, AFAICT, correct in saying that we still can do allocation

Re: [RFC v2 1/2] compiler: use compiler to detect integer overflows

2014-11-29 Thread Sasha Levin
On 11/26/2014 10:13 PM, Linus Torvalds wrote: > .. which I didn't actually validate. And I suspect gcc won't be good > enough to optimize, so it probably generates horrendous code. That's correct. It's pretty bad. > And the thing is, I think it's just *wrong* to do "overflow in signed > type". Th

[PATCH] staging:ft1000_pcmcia:Added a blank line after declaration

2014-11-29 Thread Anjana Sasindran
This patch fix the checkpatch.pl warning WARNING: Missing a blank line after declaration Signed-off-by: Anjana Sasindran --- drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c b/drivers/staging/f

Re: [RFC PATCH] proc, pidns: Add highpid

2014-11-29 Thread Andy Lutomirski
On Nov 28, 2014 9:24 PM, "Greg KH" wrote: > > On Fri, Nov 28, 2014 at 03:05:01PM -0800, Andy Lutomirski wrote: > > Pid reuse is common, which means that it's difficult or impossible > > to read information about a pid from /proc without races. > > > > This introduces a second number associated wit

Re: [tip:irq/irqdomain] irqdomain: Introduce helper function irq_domain_add_hierarchy()

2014-11-29 Thread Jiang Liu
On 2014/11/29 22:56, Borislav Petkov wrote: > On Sat, Nov 29, 2014 at 10:29:33PM +0800, Jiang Liu wrote: >> Thanks for reporting and fixing this. How about using GFP_ATOMIC >> here? > > Well, I don't see the need to use GFP_ATOMIC if we absolutely don't have > to. And in this case lockdep is, AFA

[PATCH 1/1] net-ipvlan: Deletion of an unnecessary check before the function call "free_percpu"

2014-11-29 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 29 Nov 2014 16:23:20 +0100 The free_percpu() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drive

Re: [RFC PATCH] proc, pidns: Add highpid

2014-11-29 Thread Andy Lutomirski
On Fri, Nov 28, 2014 at 7:34 PM, Eric W. Biederman wrote: > Andy Lutomirski writes: > >> Pid reuse is common, which means that it's difficult or impossible >> to read information about a pid from /proc without races. > > Sigh. > > What we need are not race free pids, but a file descriptor based p

Re: [tip:irq/irqdomain] irqdomain: Introduce helper function irq_domain_add_hierarchy()

2014-11-29 Thread Borislav Petkov
On Sat, Nov 29, 2014 at 11:21:11PM +0800, Jiang Liu wrote: > Thanks for the info about GFP_ATOMIC, originally I have an impression > that we should use GFP_ATOMIC when interrupt is disabled:( Hmm, that's actually a good point. GFP_NOFS has __GFP_WAIT which means that we can wait and resched when t

[PATCH] Drivers:input:mousedev.c: Fixed trailing statement on the next line

2014-11-29 Thread Athira S
Fixed checkpatch error: trailing statements should be on next line Signed-off-by: Athira S --- drivers/input/mousedev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/input/mousedev.c b/drivers/input/mousedev.c index b604564..be2cc5c 100644 --- a/drivers/input/mous

[PATCH 1/1] fs-notify: Deletion of an unnecessary check before the function call "iput"

2014-11-29 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 29 Nov 2014 16:42:50 +0100 The iput() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- fs/notify/in

Re: [RFC PATCH] userns: Disallow setgroups unless the gid_map writer is privileged

2014-11-29 Thread serge
iiuc this should be ok for lxc since it always has a privileged map writer. (sorry I'm pretty much afk until dec 10) Thanks, - sergeOn 11/28/14 16:53 Andy Lutomirski wrote: Classic unix permission checks have an interesting feature. The group permissions for a file can be set to less than the o

Re: [PATCH] Drivers:input:mousedev.c: Fixed trailing statement on the next line

2014-11-29 Thread Belisko Marek
On Sat, Nov 29, 2014 at 4:39 PM, Athira S wrote: > Fixed checkpatch error: > trailing statements should be on next line > > Signed-off-by: Athira S > --- > drivers/input/mousedev.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/input/mousedev.c b/drivers/input

[PATCH 1/1] fs-namei: Deletion of an unnecessary check before the function call "iput"

2014-11-29 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 29 Nov 2014 17:00:21 +0100 The iput() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- fs/namei.c |

[PATCH] i8k: Add support for temperature sensor labels

2014-11-29 Thread Pali Rohár
This patch adds labels for temperature sensors if SMM function with EAX register 0x11a3 reports it. These informations was taken from DOS binary NBSVC.MDM. Signed-off-by: Pali Rohár --- drivers/char/i8k.c | 110 +--- 1 file changed, 88 insertions(

Re: [RFC PATCH] proc, pidns: Add highpid

2014-11-29 Thread Cyrill Gorcunov
On Fri, Nov 28, 2014 at 03:05:01PM -0800, Andy Lutomirski wrote: > Pid reuse is common, which means that it's difficult or impossible > to read information about a pid from /proc without races. > > This introduces a second number associated with each (task, pidns) > pair called highpid. Highpid i

Re: fs-fat: Less function calls in fat_fill_super() after error detection

2014-11-29 Thread OGAWA Hirofumi
SF Markus Elfring writes: >> More labels are more chances of bug (and we don't care micro optimize >> on this error path), isn't it? > > I would prefer that a few jump targets can be redirected so that unnecessary > function calls (and corresponding checks) can be avoided. It is from real bugs i

Re: [PATCH] i8k: Add support for temperature sensor labels

2014-11-29 Thread Pali Rohár
On Saturday 29 November 2014 17:04:07 Pali Rohár wrote: > This patch adds labels for temperature sensors if SMM function > with EAX register 0x11a3 reports it. These informations was > taken from DOS binary NBSVC.MDM. > > Signed-off-by: Pali Rohár > --- > drivers/char/i8k.c | 110 >

[PATCH urgent v2] sched: Add missing rcu protection to wake_up_all_idle_cpus

2014-11-29 Thread Andy Lutomirski
Locklessly doing is_idle_task(rq->curr) is only okay because of RCU protection. The older variant of the broken code checked rq->curr == rq->idle instead and therefore didn't need RCU. Fixes: f6be8af1c95d sched: Add new API wake_up_if_idle() to wake up the idle cpu Cc: Chuansheng Liu Signed-off-

Re: [RFC PATCH] userns: Disallow setgroups unless the gid_map writer is privileged

2014-11-29 Thread Eric W. Biederman
Andy Lutomirski writes: The patch is buggy. Nacked-by: "Eric W. Biederman" > --- > > Eric, this is an alternative to your patch. I think it will cause > less breakage, and it will keep unprivileged user namespaces > more or less fully functional. > > Kenton, I think that neither run-bundle no

Re: [PATCH 2/7] KVM: arm: guest debug, define API headers

2014-11-29 Thread Christoffer Dall
On Tue, Nov 25, 2014 at 04:10:00PM +, Alex Bennée wrote: > This commit defines the API headers for guest debugging. There are two > architecture specific debug structures: > > - kvm_guest_debug_arch, allows us to pass in HW debug registers > - kvm_debug_exit_arch, signals the exact debug e

Re: [PATCH 2/7] KVM: arm: guest debug, define API headers

2014-11-29 Thread Christoffer Dall
On Wed, Nov 26, 2014 at 03:04:10PM +, Alex Bennée wrote: > > Peter Maydell writes: > > > On 25 November 2014 at 16:10, Alex Bennée wrote: > >> +/* Exit types which define why we did a debug exit */ > >> +#define KVM_DEBUG_EXIT_ERROR 0x0 > >> +#define KVM_DEBUG_EXIT_SINGLE_STEP

Re: [PATCH 3/7] KVM: arm: guest debug, add stub KVM_SET_GUEST_DEBUG ioctl

2014-11-29 Thread Christoffer Dall
On Tue, Nov 25, 2014 at 04:10:01PM +, Alex Bennée wrote: > This commit adds a stub function to support the KVM_SET_GUEST_DEBUG > ioctl. Currently any operation flag will return EINVAL. Actual > functionality will be added with further patches. > > Signed-off-by: Alex Bennée . > > diff --git a

Re: [PATCH 4/7] KVM: arm64: guest debug, add SW break point support

2014-11-29 Thread Christoffer Dall
On Wed, Nov 26, 2014 at 05:07:20PM +0100, Andrew Jones wrote: > On Tue, Nov 25, 2014 at 04:10:02PM +, Alex Bennée wrote: > > This adds support for SW breakpoints inserted by userspace. > > > > First we need to trap all BKPT exceptions in the hypervisor (ELS). This > > in controlled through the

[PATCH] Drivers:input:mousedev.c: Fixed trailing statement on the next line

2014-11-29 Thread Athira S
Fixed checkpatch error: trailing statements should be on next line signed-off-by: Athira S --- drivers/input/mousedev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/input/mousedev.c b/drivers/input/mousedev.c index be2cc5c..28988f5 100644 --- a/drivers/input/mo

Re: [PATCH 4/7] KVM: arm64: guest debug, add SW break point support

2014-11-29 Thread Christoffer Dall
On Tue, Nov 25, 2014 at 04:10:02PM +, Alex Bennée wrote: > This adds support for SW breakpoints inserted by userspace. > > First we need to trap all BKPT exceptions in the hypervisor (ELS). This > in controlled through the MDCR_EL2 register. I've added a new field to this is ? > the vcpu str

Re: [PATCH] i8k: Add support for temperature sensor labels

2014-11-29 Thread Guenter Roeck
On 11/29/2014 08:04 AM, Pali Rohár wrote: This patch adds labels for temperature sensors if SMM function with EAX register 0x11a3 reports it. These informations was taken from DOS binary NBSVC.MDM. Signed-off-by: Pali Rohár --- drivers/char/i8k.c | 110 +++

Re: [PATCH] i8k: Add support for temperature sensor labels

2014-11-29 Thread Guenter Roeck
On 11/29/2014 08:09 AM, Pali Rohár wrote: On Saturday 29 November 2014 17:04:07 Pali Rohár wrote: This patch adds labels for temperature sensors if SMM function with EAX register 0x11a3 reports it. These informations was taken from DOS binary NBSVC.MDM. Signed-off-by: Pali Rohár --- drivers/

Re: [RFC PATCH] userns: Disallow setgroups unless the gid_map writer is privileged

2014-11-29 Thread Andy Lutomirski
On Sat, Nov 29, 2014 at 8:16 AM, Eric W. Biederman wrote: > Andy Lutomirski writes: > > The patch is buggy. > > Nacked-by: "Eric W. Biederman" > >> --- >> >> Eric, this is an alternative to your patch. I think it will cause >> less breakage, and it will keep unprivileged user namespaces >> more

Re: [PATCH] i8k: Add support for temperature sensor labels

2014-11-29 Thread Pali Rohár
On Saturday 29 November 2014 17:24:08 Guenter Roeck wrote: > On 11/29/2014 08:04 AM, Pali Rohár wrote: > > +static bool __init i8k_check_temp(int sensor) > > +{ > > + int err; > > + > > + /* > > +* Check if temperature sensor type is valid. > > +* > > +* If it is valid then sensor s

iwlwifi intel 6300 slow

2014-11-29 Thread Jurriaan
I had a Lenovo W700 laptop with Intel 5300 wireless card, running Debian Testing. Speed to and from my NAS via a Western Digital N900 router was about 16 megabyte/s - limited by the NAS. After updating to a W701 with an Intel 6300 wireless card, speed is down to 1-2 megabyte/s. Replacing the card

Re: [PATCH] i8k: Add support for temperature sensor labels

2014-11-29 Thread Pali Rohár
On Saturday 29 November 2014 17:24:56 Guenter Roeck wrote: > On 11/29/2014 08:09 AM, Pali Rohár wrote: > > On Saturday 29 November 2014 17:04:07 Pali Rohár wrote: > >> This patch adds labels for temperature sensors if SMM > >> function with EAX register 0x11a3 reports it. These > >> informations wa

Re: [PATCH] i8k: Add support for temperature sensor labels

2014-11-29 Thread Steven Honeyman
On 29 November 2014 at 16:09, Pali Rohár wrote: > On Saturday 29 November 2014 17:04:07 Pali Rohár wrote: >> This patch adds labels for temperature sensors if SMM function >> with EAX register 0x11a3 reports it. These informations was >> taken from DOS binary NBSVC.MDM. >> >> Signed-off-by: Pali R

Re: [PATCH/RFC v8 04/14] v4l2-async: change custom.match callback argument type

2014-11-29 Thread Laurent Pinchart
Hi Jacek, Thank you for the patch. On Friday 28 November 2014 10:17:56 Jacek Anaszewski wrote: > It is useful to have an access to the async sub-device > being matched, not only to the related struct device. > Change match callback argument from struct device > to struct v4l2_subdev. It will allo

[PATCH 1/1] XFS: Deletion of unnecessary checks before two function calls

2014-11-29 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 29 Nov 2014 17:40:22 +0100 The functions xfs_blkdev_put() and xfs_qm_dqrele() test whether their argument is NULL and then return immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Ma

Re: [GIT PULL] namespace updates for v3.17-rc1

2014-11-29 Thread Richard Weinberger
Am 26.11.2014 um 00:15 schrieb Richard Weinberger: > Eric, > > On Thu, Aug 21, 2014 at 4:09 PM, Eric W. Biederman > wrote: >> Richard Weinberger writes: >> >>> Am 21.08.2014 15:12, schrieb Christoph Hellwig: On Wed, Aug 20, 2014 at 09:53:49PM -0700, Eric W. Biederman wrote: > Richard We

[PATCH 1/1] fs-DLM: Deletion of unnecessary checks before the function call "kfree"

2014-11-29 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 29 Nov 2014 17:55:39 +0100 The kfree() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- fs/dlm/lock

Re: [PATCH] i8k: Add support for temperature sensor labels

2014-11-29 Thread Gabriele Mazzotta
On Saturday 29 November 2014 17:09:35 Pali Rohár wrote: > On Saturday 29 November 2014 17:04:07 Pali Rohár wrote: > > This patch adds labels for temperature sensors if SMM function > > with EAX register 0x11a3 reports it. These informations was > > taken from DOS binary NBSVC.MDM. > > > > Signed-o

Re: [PATCH] i8k: Add support for temperature sensor labels

2014-11-29 Thread Pali Rohár
On Saturday 29 November 2014 18:07:19 Gabriele Mazzotta wrote: > On Saturday 29 November 2014 17:09:35 Pali Rohár wrote: > > On Saturday 29 November 2014 17:04:07 Pali Rohár wrote: > > > This patch adds labels for temperature sensors if SMM > > > function with EAX register 0x11a3 reports it. These

Re: [PATCH v6 37/46] tun: move internal flag defines out of uapi

2014-11-29 Thread Michael S. Tsirkin
On Fri, Nov 28, 2014 at 08:15:32AM +0008, Jason Wang wrote: > > > On Fri, Nov 28, 2014 at 4:10 AM, Michael S. Tsirkin wrote: > >TUN_ flags are internal and never exposed > >to userspace. Any application using it is almost > >certainly buggy. > > > >Move them out to tun.c, we'll remove them in fo

Disable input device

2014-11-29 Thread Pali Rohár
Hello, there is request to introduce some option (via sysfs) to disable one input device. Originally it was for tsc2005 touchscreen found on Nokia N900 cellphone. Use case is to completely disable touchscreen when phone is in pocket or when screen is locked via slide switch (to prevent random

Re: [PATCH v6 38/46] tun: drop most type defines

2014-11-29 Thread Michael S. Tsirkin
On Fri, Nov 28, 2014 at 08:17:48AM +0008, Jason Wang wrote: > > > On Fri, Nov 28, 2014 at 4:11 AM, Michael S. Tsirkin wrote: > >It's just as easy to use IFF_ flags directly, > >there's no point in adding our own defines. > > > >Signed-off-by: Michael S. Tsirkin > >--- > > drivers/net/tun.c | 62

[PATCH v2] userns: Disallow setgroups unless the gid_map writer is privileged

2014-11-29 Thread Andy Lutomirski
Classic unix permission checks have an interesting feature. The group permissions for a file can be set to less than the other permissions on a file. Occasionally this is used deliberately to give a certain group of users fewer permissions than the default. User namespaces break this usage. Gro

Re: [PATCH v6 34/46] virtio_net: disable mac write for virtio 1.0

2014-11-29 Thread Michael S. Tsirkin
On Fri, Nov 28, 2014 at 08:48:24AM +0008, Jason Wang wrote: > > > On Fri, Nov 28, 2014 at 4:10 AM, Michael S. Tsirkin wrote: > >The spec states that mac in config space is only driver-writable in the > >legacy case. Fence writing it in virtnet_set_mac_address() in the > >virtio 1.0 case. > > >

Re: [PATCH v6 01/46] virtio: add low-level APIs for feature bits

2014-11-29 Thread Michael S. Tsirkin
On Fri, Nov 28, 2014 at 11:02:20AM +0100, Cornelia Huck wrote: > On Thu, 27 Nov 2014 22:07:36 +0200 > "Michael S. Tsirkin" wrote: > > > Add low level APIs to test/set/clear feature bits. > > For use by transports, to make it easier to > > write code independent of feature bit array format. > > >

Re: [PATCH v6 20/46] KVM: s390: enable virtio-ccw revision 1

2014-11-29 Thread Michael S. Tsirkin
On Fri, Nov 28, 2014 at 11:09:10AM +0100, Cornelia Huck wrote: > On Thu, 27 Nov 2014 22:09:30 +0200 > "Michael S. Tsirkin" wrote: > > > From: Cornelia Huck > > > > Now that virtio-ccw has everything needed to support virtio 1.0 in > > place, try to enable it if the host supports it. > > > > MS

Re: [PATCH v6 01/46] virtio: add low-level APIs for feature bits

2014-11-29 Thread Michael S. Tsirkin
On Fri, Nov 28, 2014 at 01:10:57PM +0100, David Hildenbrand wrote: > > Add low level APIs to test/set/clear feature bits. > > For use by transports, to make it easier to > > write code independent of feature bit array format. > > > > Signed-off-by: Michael S. Tsirkin > > --- > > include/linux/vi

Re: [Update][PATCH] USB / PM: Drop CONFIG_PM_RUNTIME from the USB core

2014-11-29 Thread Alan Stern
On Sat, 29 Nov 2014, Rafael J. Wysocki wrote: > > There are also one or two places in Documentation/usb that mention > > CONFIG_PM_RUNTIME. > > I found this in Documentation/usb/power-management.txt: > > "Note: Dynamic PM support for USB is present only if the kernel was > built with CONFIG_US

Re: [PATCH v6 02/46] virtio: use u32, not bitmap for features

2014-11-29 Thread Michael S. Tsirkin
On Fri, Nov 28, 2014 at 01:44:57PM +0100, Cornelia Huck wrote: > On Thu, 27 Nov 2014 22:07:41 +0200 > "Michael S. Tsirkin" wrote: > > > It seemed like a good idea to use bitmap for features > > in struct virtio_device, but it's actually a pain, > > and seems to become even more painful when we ge

Re: [PATCH] ACPI / video: check _DOD list when creating backlight device

2014-11-29 Thread Brian Norris
On Sat, Nov 29, 2014 at 09:01:47PM +0800, Aaron Lu wrote: > On 11/29/2014 01:18 AM, Brian Norris wrote: > > On Fri, Nov 28, 2014 at 07:55:00PM +0800, Aaron Lu wrote: > >> On 11/28/2014 05:59 PM, Brian Norris wrote: > >>> Do you need any additional info to handle the regression, or should we > >>> j

Re: [PATCH] tty: serial: serial-omap: depend on !8250_omap

2014-11-29 Thread Tony Lindgren
* Sebastian Andrzej Siewior [141129 01:50]: > * Sebastian Andrzej Siewior | 2014-11-26 23:01:46 [+0100]: > > >Technically speaking this is not required. If both are enabled then the > >Maikefile order says that 8250 one wins, the second is never probed. > > > >If we choose to enable 8250_omap via

Re: linux-next: manual merge of the block tree with the ext4 tree

2014-11-29 Thread Theodore Ts'o
Note the relevant changes from the ext4 tree were dropped from the dev branch, so this shouldn't be an issue moving forward. - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel

[PATCH 1/1] SPI-txx9: Deletion of an unnecessary check before the function call "clk_disable"

2014-11-29 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 29 Nov 2014 18:34:20 +0100 The clk_disable() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drive

Re: [PATCH v8 2/4] ARM: mediatek: Add sysirq interrupt polarity support

2014-11-29 Thread Beniamino Galvani
On Tue, Nov 25, 2014 at 04:04:20PM +0800, Yingjoe Chen wrote: > Mediatek SoCs have interrupt polarity support in sysirq which > allows to invert polarity for given interrupt. Add this support > using hierarchy irq domain. > > [...] > > +static int __init mtk_sysirq_of_init(struct device_node *node

Re: [PATCH] i8k: Add support for temperature sensor labels

2014-11-29 Thread Greg Kroah-Hartman
On Sat, Nov 29, 2014 at 05:04:07PM +0100, Pali Rohár wrote: > This patch adds labels for temperature sensors if SMM function with EAX > register > 0x11a3 reports it. These informations was taken from DOS binary NBSVC.MDM. > > Signed-off-by: Pali Rohár > --- > drivers/char/i8k.c | 110 > ++

Re: [PATCH] Drivers:staging:clocking-wizard: Added a newline

2014-11-29 Thread Greg KH
On Sat, Nov 29, 2014 at 06:03:06PM +0530, Athira S wrote: > Fixed checkpatch warning: > Missing a newline after declarations > > Signed-off-by: Athira S Is "Athira S" what you use to sign legal documents? If not, please fix and resend. -- To unsubscribe from this list: send the line "unsubscrib

Re: [PATCH] i8k: Add support for temperature sensor labels

2014-11-29 Thread Pali Rohár
On Saturday 29 November 2014 18:43:15 Greg Kroah-Hartman wrote: > On Sat, Nov 29, 2014 at 05:04:07PM +0100, Pali Rohár wrote: > > This patch adds labels for temperature sensors if SMM > > function with EAX register 0x11a3 reports it. These > > informations was taken from DOS binary NBSVC.MDM. > >

Re: [PATCH] ext4: fix suboptimal seek_{data,hole} extents traversial

2014-11-29 Thread Theodore Ts'o
On Fri, Nov 28, 2014 at 06:02:02PM +0300, Dmitry Monakhov wrote: > FYI: inline_data feature is fatally broken Thanks for finding the bugs! > 2) ext4_inline_data_fiemap(0 ignores start and len arguments from > ext4_filemap() >which obviously result in endless loop for anyone who want to use >

Re: [PATCH] i8k: Add support for temperature sensor labels

2014-11-29 Thread Greg Kroah-Hartman
On Sat, Nov 29, 2014 at 06:49:43PM +0100, Pali Rohár wrote: > On Saturday 29 November 2014 18:43:15 Greg Kroah-Hartman wrote: > > On Sat, Nov 29, 2014 at 05:04:07PM +0100, Pali Rohár wrote: > > > This patch adds labels for temperature sensors if SMM > > > function with EAX register 0x11a3 reports i

Re: [PATCH] Drivers:input:mousedev.c: Fixed trailing statement on the next line

2014-11-29 Thread Joe Perches
On Sat, 2014-11-29 at 21:50 +0530, Athira S wrote: > Fixed checkpatch error: > trailing statements should be on next line > > signed-off-by: Athira S > --- > drivers/input/mousedev.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/input/mousedev.c b/drivers/

[PATCH 1/1] net-PA Semi: Deletion of unnecessary checks before the function call "pci_dev_put"

2014-11-29 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 29 Nov 2014 18:55:40 +0100 The pci_dev_put() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drive

  1   2   >