On Sat, May 17, 2014 at 3:32 AM, Julia Lawall wrote:
> From: Julia Lawall
>
> Platform_get_drvdata is an accessor function, and has no purpose if its
> result is not used.
>
> The semantic patch that fixes this problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> //
> @@
> identifier x;
> t
On Fri, 16 May 2014, Steven Rostedt wrote:
> Why I still favor the stop_machine approach, is because the method of
> patching is a bit simpler that way. A "lazy" approach will be more
> complex and more likely to be buggy. The thing I'm arguing here is not
> the end result being a problem, but the
On Sat, 17 May 2014, Fabio Estevam wrote:
> On Sat, May 17, 2014 at 3:32 AM, Julia Lawall wrote:
> > From: Julia Lawall
> >
> > Platform_get_drvdata is an accessor function, and has no purpose if its
> > result is not used.
> >
> > The semantic patch that fixes this problem is as follows:
> >
Linus,
here are some I2C bugfixes for 3.15. Typical stuff, I'd say. Please
pull.
Thanks,
Wolfram
The following changes since commit d6d211db37e75de2ddc3a4f979038c40df7cc79c:
Linux 3.15-rc5 (2014-05-09 13:10:52 -0700)
are available in the git repository at:
git://git.kernel.org/pub/sc
On Sat, May 17, 2014 at 12:46:43AM +, Son P. Nguyen wrote:
> From: "Son P. Nguyen"
>
> Fixed reporting_keystroke type to int instead of bool to quiet sparse
> complaints of error cannot size expression.
>
> This is a part of eudyptula-challenge.
>
This is a bug in Sparse. The original cod
On Fri, 16 May 2014 14:23:18 +0200, Thierry Reding wrote:
> From: Thierry Reding
>
> This commit introduces a generic device tree binding for IOMMU devices.
> Only a very minimal subset is described here, but it is enough to cover
> the requirements of both the Exynos System MMU and Tegra SMMU as
Hi Andi.
On Fri, May 16, 2014 at 02:43:15PM -0700, Andi Kleen wrote:
> From: Andi Kleen
>
> Add a tool to hunt for inline bloat. It uses objdump -S to account
> inlines.
I tried this on my sparc32 build - but it failed with:
objdump: can't disassemble for architecture UNKNOWN!
It looks simple t
based on
febdbfe8a91ce0
"arch: Prepare for smp_mb__{before,after}_atomic()"
Cc: Jeff Layton
Cc: Steve French
Cc: Andrew Morton
Signed-off-by: Fabian Frederick
---
fs/cifs/inode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/cifs/inode.c b/fs/cifs/inode.c
index 9ff8df
This patch is just used to remove a useless global variable mce_entry
and relative operations in mce.c.
Signed-off-by: Chen Yucong
---
arch/x86/include/asm/mce.h |2 --
arch/x86/kernel/cpu/mcheck/mce.c |5 -
2 files changed, 7 deletions(-)
diff --git a/arch/x86/include/asm/mce
On Fri, May 16, 2014 at 01:55:46PM +0100, Russell King - ARM Linux wrote:
> There was a CPU called the ARM710, it was ARMv3 and it had no Thumb support.
>
> There is also a CPU called the ARM710T, which is ARMv4 and has Thumb support.
>
> These are two completely different CPUs, the former was re
Hi Oren,
On Thu, May 15, 2014 at 10:05:05AM +0300, Oren Twaig wrote:
>
> On 05/15/2014 08:00 PM, Anthony Iliopoulos wrote:
> > I have dismissed this case, since I assume that there are many more
> > cycles spent in servicing the TLB invalidation IPI, walking the pgtable
> > plus other related ove
On Sat, May 17, 2014 at 10:31:44AM +0200, Sam Ravnborg wrote:
> Hi Andi.
>
> On Fri, May 16, 2014 at 02:43:15PM -0700, Andi Kleen wrote:
> > From: Andi Kleen
> >
> > Add a tool to hunt for inline bloat. It uses objdump -S to account
> > inlines.
> I tried this on my sparc32 build - but it failed
On Mon, Apr 28, 2014 at 10:27:44PM +0800, Lan Tianyu wrote:
> Add i2c_smbus_quick_write/read() helper function. These will be used
> in the implementation of i2c ACPI address space handler.
>
> Reviewed-by: Mika Westerberg
> Signed-off-by: Lan Tianyu
We had such a function once but removed beca
On Fri, 16 May 2014 21:23:02 +0200, Pali Rohár wrote:
> So is not there any documentation? I think that Dell released
> some SMM/BIOS code... But I'm not sure about it.
I don't know either. But even with some SMM/BIOS code, it doesn't tell
you which sensors are present on which machines, nor what
On Sat, May 17, 2014 at 10:23:37AM +0100, Catalin Marinas wrote:
> On Fri, May 16, 2014 at 01:55:46PM +0100, Russell King - ARM Linux wrote:
> > There was a CPU called the ARM710, it was ARMv3 and it had no Thumb support.
> >
> > There is also a CPU called the ARM710T, which is ARMv4 and has Thumb
On 17 May 2014, at 10:46, Russell King - ARM Linux
wrote:
> On Sat, May 17, 2014 at 10:23:37AM +0100, Catalin Marinas wrote:
>> On Fri, May 16, 2014 at 01:55:46PM +0100, Russell King - ARM Linux wrote:
>>> There was a CPU called the ARM710, it was ARMv3 and it had no Thumb support.
>>>
>>> There
On Sat, May 17, 2014 at 04:45:24PM +0800, Chen Yucong wrote:
> This patch is just used to remove a useless global variable mce_entry
> and relative operations in mce.c.
Well, I can see from the diff below what you're saying here but a commit
message should contain information which explains *why*
On 05/05/2014 07:27 AM, Antoine Ténart wrote:
> The Marvell Berlin boards have a group based pinmuxing mechanism. This
> adds the core driver support. We actually do not need any information
> about the pins here and only have the definition of the groups.
>
> Let's take the example of the uart0 p
On Mon, Apr 28, 2014 at 10:27:45PM +0800, Lan Tianyu wrote:
> Add i2c_smbus_word/block_proc_call() helper function. These will be used
> in the implementation of i2c ACPI address space handler.
>
> Reviewed-by: Mika Westerberg
> Signed-off-by: Lan Tianyu
> ---
> drivers/i2c/i2c-core.c | 56
> +
On Sat, May 17, 2014 at 10:56:02AM +0100, Catalin Marinas wrote:
> > The difference between what you're proposing and what happened to ARMv3
> > is that ARMv3 was broken for quite some time (we read from some of the
> > CP15 registers which are read-only in ARMv3) and no one ever raised a
> > probl
This addresses two issues currently reported by static analysis for function
rtw_drv_init() in drivers/staging/rtl8188eu/os_dep/usb_intf.c.
CID 1077553 - Logically dead code
CID 1077832 - Uninitialized scalar variable
Compile tested only. Applies against branch staging-next of tree
git.kern
(status != _SUCCESS) immediately after 'status = _SUCCESS' will never evaluate
true. Thus remove the logically dead code. Detected by Coverity - CID 1077553.
Signed-off-by: Christian Engelmayer
---
drivers/staging/rtl8188eu/os_dep/usb_intf.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/d
Function rtw_drv_init() is written in a way that assumes 'status' != _SUCCESS
as long as not explicitly set. Thus initialize 'status' to FAIL, in order to
prevent undefined behaviour if going through the exit paths. Detected by
Coverity - CID 1077832.
Signed-off-by: Christian Engelmayer
---
driv
I'm announcing the release of the 3.12.20 kernel.
All users of the 3.12 kernel series must upgrade.
The updated 3.12.y git tree can be found at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git
linux-3.12.y
and can be browsed at the normal kernel.org git web browser:
On each processed XCOPY command, two "kmalloc-512" memory objects are
leaked. These represent two allocations of struct xcopy_pt_cmd in
target_core_xcopy.c.
The reason for the memory leak is that the cmd_kref field is not
initialized (thus, it is zero because the allocations were done with
kzalloc
I found a memory leak in iSCSI target that was caused by kref initialized
to zero (the memory object was allocated with kzalloc, kref_init was not
called and kref_put_spinlock_irqsave was called which changed "0" to "-1"
and didn't free the object).
Similar bugs may exist in other kernel areas, so
On Sat, May 17, 2014 at 06:53:17AM -0400, Mikulas Patocka wrote:
> I found a memory leak in iSCSI target that was caused by kref initialized
> to zero (the memory object was allocated with kzalloc, kref_init was not
> called and kref_put_spinlock_irqsave was called which changed "0" to "-1"
> and d
Christian Engelmayer writes:
> This addresses two issues currently reported by static analysis for function
> rtw_drv_init() in drivers/staging/rtl8188eu/os_dep/usb_intf.c.
>
>CID 1077553 - Logically dead code
>CID 1077832 - Uninitialized scalar variable
>
> Compile tested only. Applies ag
There's been a check for CONFIG_COMET_EARLY_UART_DEBUG ever since
Hexagon was added in v3.2. But the related Kconfig symbol has never been
added to the tree. Remove this check.
Signed-off-by: Paul Bolle
---
Not tested.
arch/hexagon/kernel/vm_init_segtable.S | 5 -
1 file changed, 5 deletion
>From 7a2ed4e9c91864736ce5ad89489fd5862d59542e Mon Sep 17 00:00:00 2001
From: Tetsuo Handa
Date: Sat, 17 May 2014 20:56:38 +0900
Subject: [PATCH] fs: Fix theoretical division by 0 in super_cache_scan().
total_objects could be 0 and is used as a denom.
While total_objects is a "long", total_objec
The mce_entry, which was defined as a global variable in mce.c, was
used in nmi_watchdog_tick().But nmi_watchdog_tick() has been discarded
in the new generic nmi_watchdog implementation - commit 1fb9d6ad2766.
So, of course, there is no need for the mce_entry.
This patch is just used to remove a
Before commit 297e0da (IB/mlx4: Handle Ethernet L2 parameters for IP based GID
addressing) local variable 'is_mcast' in function create_iboe_ah() was
guaranteed to be set after calling mlx4_ib_resolve_grh(). Since 297e0da
'is_mcast' is set in case of rdma_is_multicast_addr(), but otherwise left
uni
Hi Alexander,
On 12.05.2014 18:47, Alexander Holler wrote:
> During the step from .dts to .dtb the information about dependcies contained
> in the .dts through phandle references is lost. This makes it impossible to
> use the binary blob to create a dependency graph without knowing the semantic
>
Signed-off-by: Eli Billauer
---
Documentation/driver-model/devres.txt |2 ++
include/asm-generic/pci-dma-compat.h | 17 +
2 files changed, 19 insertions(+), 0 deletions(-)
diff --git a/Documentation/driver-model/devres.txt
b/Documentation/driver-model/devres.txt
index 21
dmam_map_single_attrs() and dmam_unmap_single_attrs() replace the non-*_attrs
functions, which are implemented as defines instead.
The case of a non-NULL @attrs parameter has not been tested.
Suggested-by: Tejun Heo
Signed-off-by: Eli Billauer
---
Documentation/driver-model/devres.txt|
dmam_map_single() and dmam_unmap_single() are the managed counterparts
for the respective dma_* functions.
Note that dmam_map_single() returns zero on failure, and not a value to
be handled by dma_mapping_error(): The error check is done by
dmam_map_single() to avoid the registration of a mapping
Initializations like 'char *foo = "bar"' will create two variables: a static
string and a pointer (foo) to that static string. Instead 'char foo[] = "bar"'
will allocate only a declare a single variable and will end up in shorter
assembly (according to Jeff Garzik on the KernelJanitor's TODO list).
Hello Tejun,
On 17/05/14 00:08, Tejun Heo wrote:
Don't we wanna map the underlying operation - dma_map_single_attrs() -
instead?
I'll resubmit this patch promptly, with a follow-up patch for the diff
to implement dmam_map_single_attrs() instead. Plus a define-statement
for dmam_map_sing
On Sat, 17 May 2014, Mateusz Guzik wrote:
> On Sat, May 17, 2014 at 06:53:17AM -0400, Mikulas Patocka wrote:
> > I found a memory leak in iSCSI target that was caused by kref initialized
> > to zero (the memory object was allocated with kzalloc, kref_init was not
> > called and kref_put_spinlock
I found a memory leak in iSCSI target that was caused by kref initialized
to zero (the memory object was allocated with kzalloc, kref_init was not
called and kref_put_spinlock_irqsave was called which changed "0" to "-1"
and didn't free the object).
Similar bugs may exist in other kernel areas, so
On Thu, 2014-05-15 at 21:35 -0700, Greg Kroah-Hartman wrote:
> On Fri, May 16, 2014 at 01:49:59AM +, Serge Hallyn wrote:
> > > I think having to pick and choose what device nodes you want in a
> > > container is a good thing. Becides, you would have to do the same thing
> > > in the kernel any
On 05/17/2014 05:41 PM, Wolfram Sang wrote:
On Mon, Apr 28, 2014 at 10:27:44PM +0800, Lan Tianyu wrote:
Add i2c_smbus_quick_write/read() helper function. These will be used
in the implementation of i2c ACPI address space handler.
Reviewed-by: Mika Westerberg
Signed-off-by: Lan Tianyu
We had
don't reinvent dev_dbg(). use the common kernel coding style.
Signed-off-by: Martin Kepplinger
---
this applies to next-20140516.
drivers/staging/media/as102/as102_drv.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/media/as102/as102_drv.c
b/
Okay, everyone agrees with Dan..?
I have made a new patch, which does not check if hnode is NULL.
Best regards
Rickard Strandqvist
2014-05-16 0:43 GMT+02:00 Dan Carpenter :
> On Thu, May 15, 2014 at 11:53:53PM +0200, Rickard Strandqvist wrote:
>> There is otherwise a risk of a possible null p
On Mon, May 05, 2014 at 05:10:03PM +0200, Krzysztof Kozlowski wrote:
> S2MPA01 supports enabling/disabling ramp delay only for buck[1234].
> Other bucks have ramp delay enabled always.
Applied, thanks.
signature.asc
Description: Digital signature
On Mon, May 05, 2014 at 05:10:02PM +0200, Krzysztof Kozlowski wrote:
> S2MPS11 supports enabling/disabling ramp delay only for buck[2346].
> Other bucks have ramp delay enabled always.
Applied, thanks.
signature.asc
Description: Digital signature
On Tue, May 06, 2014 at 08:37:38AM +0200, Krzysztof Kozlowski wrote:
> Use regulator API rdev_get_id() to access id of regulator.
Applied, thanks (I did actually apply the v2 of the first two, I just
replied to the wrong version in my mailbox).
signature.asc
Description: Digital signature
The config macro CONFIG_IA64_FW_EMU briefly appeared in the v2.3
development cycle. It would apparently have allowed to emulate
"PAL/SAL/EFI firmware". It was abandoned before v2.4.0. Finally remove
its last traces.
Signed-off-by: Paul Bolle
---
Untested.
arch/ia64/kernel/head.S | 5 -
1 fi
On Fri, May 16, 2014 at 04:12:25PM -0400, Tejun Heo wrote:
> Hello,
>
> On Fri, May 16, 2014 at 06:16:51PM +0200, Frederic Weisbecker wrote:
> > From: Lai Jiangshan
> >
> > Changing the attributions of a workqueue imply the addition of new pwqs
> > to replace the old ones. But the current implem
On 05/17/14 14:38, Mikulas Patocka wrote:
> I found a memory leak in iSCSI target that was caused by kref initialized
> to zero (the memory object was allocated with kzalloc, kref_init was not
> called and kref_put_spinlock_irqsave was called which changed "0" to "-1"
> and didn't free the object).
On 05/17/2014 06:21 PM, Wolfram Sang wrote:
On Mon, Apr 28, 2014 at 10:27:45PM +0800, Lan Tianyu wrote:
Add i2c_smbus_word/block_proc_call() helper function. These will be used
in the implementation of i2c ACPI address space handler.
Reviewed-by: Mika Westerberg
Signed-off-by: Lan Tianyu
---
you forget to remove debug parameter itself.
Antti
On 05/17/2014 04:16 PM, Martin Kepplinger wrote:
don't reinvent dev_dbg(). use the common kernel coding style.
Signed-off-by: Martin Kepplinger
---
this applies to next-20140516.
drivers/staging/media/as102/as102_drv.c | 11 +++
Hi,
On 14.05.2014 16:05, Grant Likely wrote:
> On Mon, 12 May 2014 18:47:53 +0200, Alexander Holler
> wrote:
>> Use the properties named 'dependencies' in binary device tree blobs to build
>> a dependency based initialization order for platform devices and drivers.
>>
>> This is done by building
On Thu, May 15, 2014 at 12:44 AM, Zhu, Lejun wrote:
> Devices based on Intel SoC products such as Baytrail have a Power
> Management IC. In the PMIC there are subsystems for voltage regulation,
> A/D conversion, GPIO and PWMs. The PMIC in Baytrail-T platform is called
> Crystal Cove.
>
> This patc
Initializations like 'char *foo = "bar"' will create two variables: a static
string and a pointer (foo) to that static string. Instead 'char foo[] = "bar"'
will declare a single variable and will end up in shorter
assembly (according to Jeff Garzik on the KernelJanitor's TODO list).
Signed-off-by:
Hi DM Guys,
I will share the latest progress report about Writeboost.
1. Where we are working on now
Kernel code
---
First of all, Writeboost is now merged into
thin-dev branch in Joe's tree.
URL: https://github.com/jthornber/linux-2.6
Testing
---
Testing for Writeboost is merged in
This patch series add support for Fn key combinations to dell-wmi driver.
I tested this patch series on laptop Dell Latitude E6440.
Here is Bios DMI table which contains scancode to keycode mapping:
Handle 0xB200, DMI type 178, 80 bytes
OEM-specific Type
Header and Data:
B
On Sat, May 17, 2014 at 12:38:57PM +0200, Christian Engelmayer wrote:
> Function rtw_drv_init() is written in a way that assumes 'status' != _SUCCESS
> as long as not explicitly set. Thus initialize 'status' to FAIL, in order to
> prevent undefined behaviour if going through the exit paths. Detecte
Bios DMI table contains scancodes for some Fn key combinations. But
corresponding keycodes in DMI table have same value 255. And dell-wmi driver
map value 255 to KEY_PROG3. This means that it is not possible to distinguish
between Fn key combinations (e.g Fn+Q and Fn+W), because kernel reports for
There are already defined some Fn key combinations, but not all.
This patch adds missing combinations for support in dell-wmi driver.
Signed-off-by: Pali Rohár
---
include/uapi/linux/input.h |6 ++
1 file changed, 6 insertions(+)
diff --git a/include/uapi/linux/input.h b/include/uapi/li
Initializations like 'char *foo = "bar"' will create two variables: a static
string and a pointer (foo) to that static string. Instead 'char foo[] = "bar"'
will declare a single variable and will end up in shorter
assembly (according to Jeff Garzik on the KernelJanitor's TODO list).
Signed-off-by:
Initializations like 'char *foo = "bar"' will create two variables: a static
string and a pointer (foo) to that static string. Instead 'char foo[] = "bar"'
will declare a single variable and will end up in shorter
assembly (according to Jeff Garzik on the KernelJanitor's TODO list).
Signed-off-by:
2014-05-17 8:09 GMT+09:00, Greg KH :
> On Fri, Apr 25, 2014 at 04:04:59PM +0900, Daeseok Youn wrote:
>> - alloc_tty_driver() is deprecated so it is changed to
>> tty_alloc_driver()
>> - Pointers which are allocated by alloc_tty_driver() and kzalloc()
>> can be NULL so it need to check NULL for them
[ +0.018677] general protection fault: [#1] PREEMPT SMP
[ +0.68] Modules linked in: usb_storage tun raid1 md_mod loop fuse
joydev coretemp hwmon arc4 intel_rapl x86_pkg_temp_thermal
intel_powerclamp kvm_intel nls_iso8859_1 nls_cp437 iTCO_wdt kvm vfat fat
iTCO_vendor_support iwldvm uvcvid
On 05/16/2014 12:11 PM, Jean Delvare wrote:
Hi Pali,
On Fri, 16 May 2014 20:37:41 +0200, Pali Rohár wrote:
Hello,
on Dell Latitude E6440 driver i8k reporting total nonsense values
That's kind of excessive wording, the output isn't that bad.
$ sensors
i8k-virtual-0
Adapter: Virtual device
R
On 05/16/2014 12:23 PM, Pali Rohár wrote:
On Friday 16 May 2014 21:11:17 Jean Delvare wrote:
Hi Pali,
On Fri, 16 May 2014 20:37:41 +0200, Pali Rohár wrote:
Hello,
on Dell Latitude E6440 driver i8k reporting total nonsense
values
That's kind of excessive wording, the output isn't that bad.
Hello Uwe,
On Fri, May 16, 2014 at 09:31:39PM +0200, Uwe Kleine-König wrote:
> Hello Walter,
>
> On Fri, May 16, 2014 at 01:49:10PM +0200, walter harms wrote:
> > Am 16.05.2014 13:16, schrieb Emil Goode:
> > > Hello Walter,
> > >
> > > On Fri, May 16, 2014 at 12:40:19PM +0200, walter harms wrote
Hello,
Sorry for the late reply,
On Wed, May 14, 2014 at 4:15 AM, David Ahern wrote:
> On 5/13/14, 4:02 PM, Alexis Berlemont wrote:
>>
>> Hello,
>>
>> A few months ago, I tried to make a proposal to introduce Kconfig in
>> perf's generation procedure.
>> (cf. https://lkml.org/lkml/2013/12/20/511
On Sat, May 17, 2014 at 05:00:18PM +0200, Manuel Schölling wrote:
> Initializations like 'char *foo = "bar"' will create two variables: a static
> string and a pointer (foo) to that static string. Instead 'char foo[] = "bar"'
> will declare a single variable and will end up in shorter
> assembly (a
Manuel Schölling writes:
> Initializations like 'char *foo = "bar"' will create two variables: a static
> string and a pointer (foo) to that static string. Instead 'char foo[] = "bar"'
> will declare a single variable and will end up in shorter
> assembly (according to Jeff Garzik on the KernelJa
On 05/16/2014 03:55 PM, Greg Kroah-Hartman wrote:
This is the start of the stable review cycle for the 3.4.91 release.
There are 9 patches in this series, all will be posted as a response
to this one. If anyone has any issues with these being applied, please
let me know.
Responses should be mad
On 05/16/2014 09:37 AM, Andreas Werner wrote:
The MEN 14F021P00 Board Management Controller provides an
I2C interface to the host to access the feature implemented in the BMC.
The BMC is a PIC Microntroller assembled on CPCI Card from MEN Mikroelektronik
and on a few Box/Display Computer.
Added
On 05/16/2014 09:37 AM, Andreas Werner wrote:
Added driver to support the 14F021P00 BMC Watchdog.
The BMC is a Board Management Controller including watchdog functionality.
This driver use the I2C interface to the BMC using the menf21bmc MFD Core
driver.
Signed-off-by: Andreas Werner
---
dr
(2014/05/17 3:34), Denys Vlasenko wrote:
> Before this patch, users need to do this to fetch vex.:
>
> if (insn->vex_prefix.nbytes == 2) {
> vex_ = ((insn->vex_prefix.bytes[1] >> 3) & 0xf) ^ 0xf;
> }
> if (insn->vex_prefix.nbytes == 3) {
>
(2014/05/17 3:34), Denys Vlasenko wrote:
> Since xop and evex prefixes are extensions of vex mechanism,
> they have similar bit layouts, and they can never be combined
> (an instruction can have only one of them),
> (ab)use insn->vex_prefix to store data of xop and evex too.
>
> Users will need to
On Fri, May 16, 2014 at 09:31:37PM -0700, Eric W. Biederman wrote:
> Greg Kroah-Hartman writes:
>
> > On Fri, May 16, 2014 at 01:49:59AM +, Serge Hallyn wrote:
> >> > I think having to pick and choose what device nodes you want in a
> >> > container is a good thing. Becides, you would have t
don't reinvent dev_dbg(). remove dprintk() in as102_drv.c.
use the common kernel coding style.
Signed-off-by: Martin Kepplinger
---
this applies to next-20140516. any more suggestions?
more cleanup can be done when dprintk() is completely gone.
drivers/staging/media/as102/as102_drv.c | 15 +++
On 05/16/2014 10:18 PM, Theodore Ts'o wrote:
> On Fri, May 16, 2014 at 05:46:22PM -0700, Hannes Frederic Sowa wrote:
>> > This should do the trick:
>> > dd if=/dev/urandom of=/dev/zero bs=67108707
>> >
>> > I suspect ee1de406ba6eb1 ("random: simplify accounting logic") as the
>> > culprit.
> Yep,
The following pateches fix the errors and warnings in
dgnc_neo.c and dgnc_tty.c to meet kernel coding style.
ERROR: else should follow close brace '}'
ERROR: that open brace { should be on the previous line
WARNING: line over 80 characters
WARNING: braces {} are not necessary for single statement
Fix indenting of if-else statement in dgnc_neo.c and dgnc_tty.c
so that following else-if or else statement meets coding style.
Signed-off-by: Masaru Nomura
---
drivers/staging/dgnc/dgnc_neo.c | 48 +--
drivers/staging/dgnc/dgnc_tty.c | 36 ++--
Fix indenting of if statement in dgnc_neo.c so that an open brace
follows if-condition part to meet kernel coding style.
Signed-off-by: Masaru Nomura
---
drivers/staging/dgnc/dgnc_neo.c |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_neo.c b/dri
Remove unnecessary braces of if-else statements in dgnc_neo.c and
dgnc_tty.c to meet kernel coding style.
Signed-off-by: Masaru Nomura
---
drivers/staging/dgnc/dgnc_neo.c | 20
drivers/staging/dgnc/dgnc_tty.c | 10 --
2 files changed, 12 insertions(+), 18 deletio
Fix line over 80 characters of if-condition part and also
indent the lines to tell the difference between the condition and
body of the if statement.
Then I think we can keep the readability and meet coding style
with this change.
Signed-off-by: Masaru Nomura
---
drivers/staging/dgnc/dgnc_neo.c
Hi
I have made a new patch according Sergei specification.
But there remains Tronds question though.
Best regards
Rickard Strandqvist
2014-05-16 14:19 GMT+02:00 Sergei Shtylyov :
> Hello.
>
>
> On 16-05-2014 1:56, Rickard Strandqvist wrote:
>
>> There is otherwise a risk of a possible null poi
> Patched the calls to nm and objdump - but it gave no output
> when I ran the script.
You have to compile with debug info on.
-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger
On Sat, May 17, 2014 at 05:00:18PM +0200, Manuel Schölling wrote:
> Initializations like 'char *foo = "bar"' will create two variables: a static
> string and a pointer (foo) to that static string. Instead 'char foo[] = "bar"'
> will declare a single variable and will end up in shorter
> assembly (a
They are all (except commented printks) rather serious filesystem errors,
so you should use at least pr_err.
Mikulas
On Thu, 15 May 2014, Fabian Frederick wrote:
> -No level printk in hptfs_error converted to pr_err
> (others to pr_warn or pr_info)
>
> This patch also fixes if/then/else check
On 05/16, Hugh Dickins wrote:
>
> On Fri, 16 May 2014, Hugh Dickins wrote:
> > On Fri, 16 May 2014, Oleg Nesterov wrote:
> > > shmem_getpage_gfp(). But, is there any way to figure out that this
> > > inode/mapping/aops/whatever is actually shmem?
> >
> > On 3.15 and later, you're in luck: Hannes ad
On Sat, May 17, 2014 at 12:24:32PM -0400, Sasha Levin wrote:
> On 05/16/2014 10:18 PM, Theodore Ts'o wrote:
> > On Fri, May 16, 2014 at 05:46:22PM -0700, Hannes Frederic Sowa wrote:
> >> > This should do the trick:
> >> > dd if=/dev/urandom of=/dev/zero bs=67108707
> >> >
> >> > I suspect ee1de406
Remove support for building against ancient WIRELESS_EXT versions,
only leaving support for the current version: 22
Signed-off-by: Joel Pelaez Jorge
---
drivers/staging/rtl8192u/ieee80211/ieee80211.h| 14 -
drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c | 5 +--
drivers/staging/r
There is otherwise a risk of a possible null pointer dereference.
Was largely found by using a static code analysis program called cppcheck.
Signed-off-by: Rickard Strandqvist
---
drivers/i2c/busses/i2c-pxa.c |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/i2c/
There is otherwise a risk of a possible null pointer dereference.
Was largely found by using a static code analysis program called cppcheck.
Signed-off-by: Rickard Strandqvist
---
drivers/infiniband/hw/ehca/ehca_mrmw.c |8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git
> >2) It uses a parameter for the r/w bit. Make sense to me, since this bit
> >is the information we send to the device. quick_read doesn't make sense
> >to me. We don't receive a bit from the device.
> >
>
> Hi Wolfram:
> Great thanks for your review. Ok. I will follow commit 67c2e665 to
>
There is otherwise a risk of a possible null pointer dereference.
Was largely found by using a static code analysis program called cppcheck.
Signed-off-by: Rickard Strandqvist
---
drivers/iommu/fsl_pamu.c |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/iommu/fsl
On Sat, May 17, 2014 at 12:36 PM, Rickard Strandqvist
wrote:
> Hi
>
> I have made a new patch according Sergei specification.
>
I'll be happy to apply this patch once someone explains to me why we
can't just remove that check for cred != NULL, however I'm not
applying a patch purely in order to s
There is otherwise a risk of a possible null pointer dereference.
Was largely found by using a static code analysis program called cppcheck.
Signed-off-by: Rickard Strandqvist
---
drivers/isdn/hisax/l3dss1.c |8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/
> >BTW what were your test scenarios for these functions and smbus quick?
> >
>
> From ACPI spec, Read/Write quick and Word/Block process call
> protocol will be used by Bios ACPI code. But so far, I don't find
> such machines. So these functions has not been tested.
Uh oh, I have some trouble a
There is otherwise a risk of a possible null pointer dereference.
Was largely found by using a static code analysis program called cppcheck.
Signed-off-by: Rickard Strandqvist
---
drivers/isdn/hisax/l3ni1.c |8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/i
On Sat, May 17, 2014 at 07:14:08PM +0200, Rickard Strandqvist wrote:
> There is otherwise a risk of a possible null pointer dereference.
>
> Was largely found by using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist
> ---
> drivers/i2c/busses/i2c-pxa.c |
There is otherwise a risk of a possible null pointer dereference.
Was largely found by using a static code analysis program called cppcheck.
Signed-off-by: Rickard Strandqvist
---
drivers/macintosh/windfarm_pm121.c | 16 +---
1 file changed, 13 insertions(+), 3 deletions(-)
diff
1 - 100 of 204 matches
Mail list logo
