Manuel Schölling <manuel.schoell...@gmx.de> writes:
> Initializations like 'char *foo = "bar"' will create two variables: a static
> string and a pointer (foo) to that static string. Instead 'char foo[] = "bar"'
> will declare a single variable and will end up in shorter
> assembly (according to Jeff Garzik on the KernelJanitor's TODO list).
>
> Signed-off-by: Manuel Schölling <manuel.schoell...@gmx.de>
Looks good.
Acked-by: OGAWA Hirofumi <hirof...@mail.parknet.co.jp>
> ---
> fs/fat/inode.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/fat/inode.c b/fs/fat/inode.c
> index b3361fe..8b7d00e 100644
> --- a/fs/fat/inode.c
> +++ b/fs/fat/inode.c
> @@ -359,7 +359,7 @@ struct inode *fat_iget(struct super_block *sb, loff_t
> i_pos)
>
> static int is_exec(unsigned char *extension)
> {
> - unsigned char *exe_extensions = "EXECOMBAT", *walk;
> + unsigned char exe_extensions[] = "EXECOMBAT", *walk;
>
> for (walk = exe_extensions; *walk; walk += 3)
> if (!strncmp(extension, walk, 3))
--
OGAWA Hirofumi <hirof...@mail.parknet.co.jp>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
