Re: Performance regression in v3.14

2014-05-06 Thread Viresh Kumar
Cc'ing Dirk who is taking care of intel-pstate driver. On 6 May 2014 22:05, Johan Hovold wrote: > After updating my main system from v3.13 to v3.14.2, I found that the > git bash-completion was extremely sluggish. Completing a file name would > take roughly six rather than one second on this Hasw

Re: IMA & truncate

2014-05-06 Thread Dmitry Kasatkin
On 6 May 2014 19:59, Al Viro wrote: > On Tue, May 06, 2014 at 04:32:27PM +0300, Dmitry Kasatkin wrote: >> Hi, >> >> I have discovered one IMA related issue. >> >> IMA file hash is re-calculate if needed on file close. >> >> It works with ftruncate(fd, length) syscall, because it operates on >> "op

Re: IMA & truncate

2014-05-06 Thread Dmitry Kasatkin
On 6 May 2014 22:11, Al Viro wrote: > On Tue, May 06, 2014 at 02:39:17PM -0400, Mimi Zohar wrote: > >> Al, you're not going to like this, but ima_calc_file_hash() calls >> ima_calc_file_hash_tfm(), which already sets/unsets FMODE_READ in order >> to calculate the file hash. > > And if it happens t

[PATCH] ARM: remove redundant code in machine_halt

2014-05-06 Thread Neil Zhang
There is no need to call local_irq_disable twice. Signed-off-by: Neil Zhang --- arch/arm/kernel/process.c |1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm/kernel/process.c b/arch/arm/kernel/process.c index 81ef686..18cfce4 100644 --- a/arch/arm/kernel/process.c +++ b/arch/arm/kerne

Re: [PATCH v5 6/6] arm64: KVM: Implement 4 levels of translation tables for HYP and stage2

2014-05-06 Thread Jungseok Lee
On Tuesday, May 06, 2014 7:49 PM, Christoffer Dall wrote: > On Thu, May 01, 2014 at 11:34:19AM +0900, Jungseok Lee wrote: > > This patch adds 4 levels of translation tables implementation for both > > HYP and stage2. > > > > Both symmetric and asymmetric configurations for page size and > > transla

Re: [PATCH] kmod: Pass usermodehelper "-b" to use blacklist commands

2014-05-06 Thread Rusty Russell
Andrew Morton writes: > On Tue, 6 May 2014 19:31:36 +0200 Oleg Nesterov wrote: > >> On 05/06, Kirill Tkhai wrote: >> > >> > User may want to prohibit autoloading of some modules, >> > which happens when someone in kernel calls request_module(). >> > >> > For comparison, udev considers blacklist e

[PATCH] staging: bcm: use kzalloc instead of kmalloc/memset

2014-05-06 Thread Daeseok Youn
Signed-off-by: Daeseok Youn --- drivers/staging/bcm/InterfaceDld.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/bcm/InterfaceDld.c b/drivers/staging/bcm/InterfaceDld.c index 005e460..e1925bd 100644 --- a/drivers/staging/bcm/InterfaceDld.c +++ b/dr

Re: [PATCH 1/3] PM / OPP: Add support for descending order for cpufreq table

2014-05-06 Thread Viresh Kumar
On 7 May 2014 06:30, Nishanth Menon wrote: > So, we could do [2] as default as well, if it is determined to impact > no one else making any form of assumptions on table ordering - but it > might be preferable for drivers not to depend on framework ordering of > data as things could change in the f

[PATCH v2 08/10] slab: destroy a slab without holding any alien cache lock

2014-05-06 Thread Joonsoo Kim
I haven't heard that this alien cache lock is contended, but to reduce chance of contention would be better generally. And with this change, we can simplify complex lockdep annotation in slab code. In the following patch, it will be implemented. Acked-by: Christoph Lameter Signed-off-by: Joonsoo

[PATCH v2 10/10] slab: remove BAD_ALIEN_MAGIC

2014-05-06 Thread Joonsoo Kim
BAD_ALIEN_MAGIC value isn't used anymore. So remove it. Signed-off-by: Joonsoo Kim diff --git a/mm/slab.c b/mm/slab.c index 4030a89..8476ffc 100644 --- a/mm/slab.c +++ b/mm/slab.c @@ -437,8 +437,6 @@ static struct kmem_cache kmem_cache_boot = { .name = "kmem_cache", }; -#define BAD_AL

[PATCH v2 02/10] slab: makes clear_obj_pfmemalloc() just return masked value

2014-05-06 Thread Joonsoo Kim
clear_obj_pfmemalloc() takes the pointer to pointer to store masked value back into this address. But this is useless, since we don't use this stored value anymore. All we need is just masked value so makes clear_obj_pfmemalloc() just return masked value. v2: simplify commit description. direc

[PATCH v2 03/10] slab: move up code to get kmem_cache_node in free_block()

2014-05-06 Thread Joonsoo Kim
node isn't changed, so we don't need to retreive this structure everytime we move the object. Maybe compiler do this optimization, but making it explicitly is better. Acked-by: Christoph Lameter Signed-off-by: Joonsoo Kim diff --git a/mm/slab.c b/mm/slab.c index e2c80df..92d08e3 100644 --- a/mm

[PATCH v2 04/10] slab: defer slab_destroy in free_block()

2014-05-06 Thread Joonsoo Kim
In free_block(), if freeing object makes new free slab and number of free_objects exceeds free_limit, we start to destroy this new free slab with holding the kmem_cache node lock. Holding the lock is useless and, generally, holding a lock as least as possible is good thing. I never measure performa

[PATCH v2 01/10] slab: add unlikely macro to help compiler

2014-05-06 Thread Joonsoo Kim
slab_should_failslab() is called on every allocation, so to optimize it is reasonable. We normally don't allocate from kmem_cache. It is just used when new kmem_cache is created, so it's very rare case. Therefore, add unlikely macro to help compiler optimization. Acked-by: David Rientjes Signed-o

[PATCH v2 05/10] slab: factor out initialization of arracy cache

2014-05-06 Thread Joonsoo Kim
Factor out initialization of array cache to use it in following patch. Acked-by: Christoph Lameter Signed-off-by: Joonsoo Kim diff --git a/mm/slab.c b/mm/slab.c index 7647728..755fb57 100644 --- a/mm/slab.c +++ b/mm/slab.c @@ -741,13 +741,8 @@ static void start_cpu_timer(int cpu) } }

[PATCH v2 06/10] slab: introduce alien_cache

2014-05-06 Thread Joonsoo Kim
Currently, we use array_cache for alien_cache. Although they are mostly similar, there is one difference, that is, need for spinlock. We don't need spinlock for array_cache itself, but to use array_cache for alien_cache, array_cache structure should have spinlock. This is needless overhead, so remo

[PATCH v2 07/10] slab: use the lock on alien_cache, instead of the lock on array_cache

2014-05-06 Thread Joonsoo Kim
Now, we have separate alien_cache structure, so it'd be better to hold the lock on alien_cache while manipulating alien_cache. After that, we don't need the lock on array_cache, so remove it. Acked-by: Christoph Lameter Signed-off-by: Joonsoo Kim diff --git a/mm/slab.c b/mm/slab.c index 41b7651

[PATCH v1 1/1] iommu/amd: fix enabling exclusion range for an exact device

2014-05-06 Thread Su, Friendy
From: Su Friendy set_device_exclusion_range(u16 devid, struct ivmd_header *m) enables exclusion range for ONE device. IOMMU does not translate the access to the exclusion range from the device. The device is specified by input argument 'devid'. But 'devid' is not passed to the actual set functi

Re: [PATCH] pwm: spear: fix check on pwmchip_add() return value

2014-05-06 Thread Viresh Kumar
On Tue, May 6, 2014 at 2:59 AM, Beniamino Galvani wrote: > pwmchip_add() returns zero on success and a negative value on error, > so the condition of the check must be inverted. > > Signed-off-by: Beniamino Galvani > --- > drivers/pwm/pwm-spear.c |2 +- > 1 file changed, 1 insertion(+), 1 de

[PATCH v2 09/10] slab: remove a useless lockdep annotation

2014-05-06 Thread Joonsoo Kim
Now, there is no code to hold two lock simultaneously, since we don't call slab_destroy() with holding any lock. So, lockdep annotation is useless now. Remove it. v2: don't remove BAD_ALIEN_MAGIC in this patch. It will be removed in the following patch. Signed-off-by: Joonsoo Kim diff --git

[PATCH v2 00/10] clean-up and remove lockdep annotation in SLAB

2014-05-06 Thread Joonsoo Kim
This patchset does some clean-up and tries to remove lockdep annotation. Patches 1~3 are just for really really minor improvement. Patches 4~10 are for clean-up and removing lockdep annotation. There are two cases that lockdep annotation is needed in SLAB. 1) holding two node locks 2) holding two

[PATCH 1/2] staging: lustre: fix sparse warning "should it be static"

2014-05-06 Thread Toby Smith
Fix the following warning in lib-eq.c warning: symbol 'lnet_eq_dequeue_event' was not declared. Should it be static? Signed-off-by: Toby Smith --- drivers/staging/lustre/lnet/lnet/lib-eq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lnet/lnet/lib-eq

[PATCH 2/2] staging: lustre: fix sparse warning "unexpected unlock"

2014-05-06 Thread Toby Smith
Fix the following warning in lib-eq.c warning: context imbalance in 'lnet_eq_wait_locked' - unexpected unlock Signed-off-by: Toby Smith --- drivers/staging/lustre/lnet/lnet/lib-eq.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/lustre/lnet/lnet/lib-eq.c b/drivers/staging/l

[PATCH 0/2] staging: lustre: fix sparse warnings in lib-eq.c

2014-05-06 Thread Toby Smith
Fix warnings from sparse in lib-eq.c Toby Smith (2): staging: lustre: fix sparse warning "should it be static" staging: lustre: fix sparse warning "unexpected unlock" drivers/staging/lustre/lnet/lnet/lib-eq.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 1.9.1 -- To unsubscri

Re: [PATCH v1 0/3] Tegra DMA residue improvements

2014-05-06 Thread Lars-Peter Clausen
On 05/06/2014 11:22 PM, Christopher Freeman wrote: A collection of patches to improve Tegra's DMA residual reporting It would be nice if you could, while you are at it, also implement the device_salve_caps callback. This will allow clients to automatically pick up things like the supported g

[PATCH] mm, highmem: clean up the comment

2014-05-06 Thread Xiubo Li
Signed-off-by: Xiubo Li --- mm/highmem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/highmem.c b/mm/highmem.c index b32b70c..d062c89 100644 --- a/mm/highmem.c +++ b/mm/highmem.c @@ -421,4 +421,4 @@ void __init page_address_init(void) } } -#endif /* defined(CO

Re: [linux-sunxi] [PATCH 7/7] ARM: sunxi: dt: add APP4-EVB1 board support

2014-05-06 Thread Hans de Goede
Hi, On 05/07/2014 07:10 AM, Koen Kooi wrote: > > Op 7 mei 2014, om 05:50 heeft Maxime Ripard > het volgende geschreven: > >> From: Boris BREZILLON >> >> The APP4 EVB1 development boards embeds an A31, together with some NAND, one >> SD >> card slot, and one SDIO + UART WiFi and Bluetooth chi

Re: Fwd: [crypto:master 60/60] arch/x86/crypto/ghash-clmulni-intel_glue.c:71:25: sparse: cast to restricted __be64

2014-05-06 Thread Ard Biesheuvel
On 7 May 2014 00:42, gre...@linuxfoundation.org wrote: > On Fri, Apr 11, 2014 at 09:48:42PM +0200, Ard Biesheuvel wrote: >> On 11 April 2014 18:03, gre...@linuxfoundation.org >> wrote: >> > On Fri, Apr 04, 2014 at 10:11:19AM +0200, Ard Biesheuvel wrote: >> >> Greg, >> >> >> >> This pertains to co

Re: [PATCH] staging: rtl8712: fix potential leak in r871x_wx_set_enc_ext()

2014-05-06 Thread Andy Shevchenko
On Thu, 2014-05-01 at 11:45 +0200, Christian Engelmayer wrote: > Fix a potential leak in the error path of r871x_wx_set_enc_ext(). In case the > requested algorithm is not supported by the driver, the function returns > without freeing the already allocated 'param' struct. Move the input > verifica

<    4   5   6   7   8   9