[PATCH] firewire net: Use LL_RESERVED_SPACE(), HH_DATA_OFF().

2013-01-20 Thread YOSHIFUJI Hideaki
Signed-off-by: YOSHIFUJI Hideaki --- drivers/firewire/net.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/firewire/net.c b/drivers/firewire/net.c index df6a1ca..2b27bff 100644 --- a/drivers/firewire/net.c +++ b/drivers/firewire/net.c @@ -270,7 +270,7 @

Re: [ 00/16] 3.0.60-stable review

2013-01-20 Thread Satoru Takeuchi
At Fri, 18 Jan 2013 17:21:38 -0800, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 3.0.60 release. > There are 16 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. T

Re: 3.7.3, ttyUSB0 serial problem - devices stop working and only reboot helps (Inappropriate ioctl for device)

2013-01-20 Thread Arkadiusz Miskiewicz
On Sunday 20 of January 2013, Woody Suwalski wrote: > Arkadiusz Miskiewicz wrote: > > On Saturday 19 of January 2013, Arkadiusz Miskiewicz wrote: > >> On Saturday 19 of January 2013, Greg Kroah-Hartman wrote: > >>> On Fri, Jan 18, 2013 at 11:28:43PM +0100, Arkadiusz Miskiewicz wrote: > Hi. > >

Re: [ 00/21] 3.4.27-stable review

2013-01-20 Thread Satoru Takeuchi
At Fri, 18 Jan 2013 17:19:18 -0800, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 3.4.27 release. > There are 21 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. T

Re: [ 00/33] 3.7.4-stable review

2013-01-20 Thread Satoru Takeuchi
At Fri, 18 Jan 2013 17:16:25 -0800, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 3.7.4 release. > There are 33 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. Th

[PATCH]xfs: Fix xfs_swap_extents() after removal of xfs_flushinval_pages()

2013-01-20 Thread Torsten Kaiser
From: Torsten Kaiser Commit fb59581404ab7ec5075299065c22cb211a9262a9 removed xfs_flushinval_pages() and changed its callers to use filemap_write_and_wait() and truncate_pagecache_range() directly. But in xfs_swap_extents() this change accidental switched the argument for 'tip' to 'ip'. This pat

Re: [PATCH] usb: gadget: nokia: Add mass storage driver to g_nokia

2013-01-20 Thread Felipe Balbi
On Sun, Jan 20, 2013 at 03:58:13AM +0100, Pali Rohár wrote: > Signed-off-by: Pali Rohár NAK for two reasons: a) the original Nokia kernel used a separate g_file_storage gadget to use Mass Storage mode, use that b) there is no commit log -- balbi signature.asc Description: Digital si

Re: USB: storage: optimize the matching rules and support new switch command for Huawei USB storage devices

2013-01-20 Thread Felipe Balbi
Hi, On Fri, Jan 18, 2013 at 03:43:59PM -0800, Greg KH wrote: > On Mon, Jan 14, 2013 at 10:55:48AM +0800, fangxiaozhi 00110321 wrote: > > > > From: fangxiaozhi > > > > 1. Optimize the matching rules with new macro for Huawei USB storage > >devices, to avoid to load USB storage driver for the

Re: [PATCH] firewire net: Ensure checksumming in upper layer.

2013-01-20 Thread Stefan Richter
On Jan 20 YOSHIFUJI Hideaki wrote: > It is wrong to set skb->ip_summed to CHECKSUM_UNNECESSARY unless > the device has already checked it. > > Signed-off-by: YOSHIFUJI Hideaki > --- > drivers/firewire/net.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/fire

Re: [PATCH] power: bq27x00_battery: Export all battery registers via sysfs

2013-01-20 Thread Lars-Peter Clausen
On 01/19/2013 03:01 PM, Pali Rohár wrote: > bq27xxx batteries have a lot of properties, more than power_supply interface. > Some of them can be usefull for userspace applications (like CI bit) but > does not make sense to add bq specified property to power_supply interface. > When bq27x00_battery i

Re: [PATCH] tty: serial/crisv10.c: remove unnecessary null pointer check

2013-01-20 Thread Jiri Slaby
On 01/18/2013 02:38 PM, Jesper Nilsson wrote: > On Wed, Jan 16, 2013 at 11:30:44PM +0100, Cong Ding wrote: >> The pointer tty is dereferened in line 3135, so it is not necessary to check >> null again in line 3140. > > I don't know if we actually need to check the parameter tty from being null, >

Re: [PATCH] usb: gadget: nokia: Add mass storage driver to g_nokia

2013-01-20 Thread Pali Rohár
On Sunday 20 January 2013 10:25:37 Felipe Balbi wrote: > On Sun, Jan 20, 2013 at 03:58:13AM +0100, Pali Rohár wrote: > > Signed-off-by: Pali Rohár > > NAK for two reasons: > > a) the original Nokia kernel used a separate g_file_storage > gadget to use Mass Storage mode, use that > > b) there is

Re: [PATCH] serial: lpc32xx: Fix fallout from tty_port conversion

2013-01-20 Thread Jiri Slaby
On 01/18/2013 08:25 AM, Thierry Reding wrote: > A duplicate definition of the port variable was introduced in the > interrupt handler, which causes the build to break. The fix is to > rename the variable to tport, which is already properly used in > subsequent code. > > Signed-off-by: Thierry Redi

[PATCH 4/6] cpufreq: Add a get_current_driver helper

2013-01-20 Thread Borislav Petkov
From: Borislav Petkov Add a helper function to return cpufreq_driver->name. Signed-off-by: Borislav Petkov --- drivers/cpufreq/cpufreq.c | 14 ++ include/linux/cpufreq.h | 1 + 2 files changed, 15 insertions(+) diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c

[PATCH 1/6] powernow-k8: Add a kconfig dependency on acpi-cpufreq

2013-01-20 Thread Borislav Petkov
From: Borislav Petkov Andreas reports in https://bugzilla.kernel.org/show_bug.cgi?id=51741 that with his Gentoo config, acpi-cpufreq wasn't enabled and powernow-k8 couldn't handoff properly to acpi-cpufreq leading to running without P-state support (i.e., cores are constantly in P0). To alleavia

[PATCH 3/6] cpufreq: Make acpi-cpufreq link first

2013-01-20 Thread Borislav Petkov
From: Borislav Petkov Now that the majority of x86 CPUs out there are supported by acpi-cpufreq, we want it to load first and, in the AMD case, drop to powernow-k8 only on K8s. If, however, both powernow-k8 and acpi-cpufreq are built-in, the link order matters. Correct that. Signed-off-by: Boris

[PATCH 6/6] powernow-k8: Cleanup init function

2013-01-20 Thread Borislav Petkov
From: Borislav Petkov Make it hotplug-safe and cleanup formatting. Signed-off-by: Borislav Petkov --- drivers/cpufreq/powernow-k8.c | 25 ++--- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/drivers/cpufreq/powernow-k8.c b/drivers/cpufreq/powernow-k8.c inde

[PATCH 5/6] powernow-k8: Cleanup module request

2013-01-20 Thread Borislav Petkov
From: Borislav Petkov Check whether we've actually already loaded acpi-cpufreq before requesting it. Signed-off-by: Borislav Petkov --- drivers/cpufreq/powernow-k8.c | 21 +++-- 1 file changed, 19 insertions(+), 2 deletions(-) diff --git a/drivers/cpufreq/powernow-k8.c b/drive

[PATCH 2/6] acpi-cpufreq: Do not load on K8

2013-01-20 Thread Borislav Petkov
From: Matthew Garrett de3ed81d746d ("[CPUFREQ] Change link order of x86 cpufreq modules") changed cpufreq drivers link order so that powernow-k8 gets loaded first due to earlier K8s having BIOS bugs. However, now that acpi-cpufreq supports both AMD and Intel CPUs with HW P-states, we want to loa

[PATCH 0/6] acpi-cpufreq and powernow-k8 fixes

2013-01-20 Thread Borislav Petkov
From: Borislav Petkov Hi all, here are a couple of patches fixing acpi-cpufreq and powernow-k8 loading sequence and handoff. Patch 0001 should be in Rafael's tree already but I'm adding it here for the sake of completeness. Basically, we want to address all possible cases of powernow-k8 and acp

Re: IPsec AH use of ahash

2013-01-20 Thread Borislav Petkov
On Sun, Jan 20, 2013 at 06:06:21AM +0100, Mike Galbraith wrote: > Sounds as though any patches you submit land on your dinner plate just > like potatoes. Hand the cook a pot of half peeled potatoes, he/she may > say try again. And how he/she would say it! I've seen serious fights spring up from ha

3.6.11 AMD-Vi: Completion-Wait loop timed out

2013-01-20 Thread Udo van den Heuvel
Hello, See below for a part of the logging on this F2A85X-UP4 with AMD a10-5800k. Box was raid checking I guess. Jan 20 03:42:08 s3 rsyslogd: [origin software="rsyslogd" swVersion="5.8.10" x-pid="3031" x-info="http://www.rsyslog.com";] rsyslogd was HUPed Jan 20 04:11:17 s3 kernel: AMD-Vi: Compl

Re: 3.6.11 AMD-Vi: Completion-Wait loop timed out

2013-01-20 Thread Borislav Petkov
I know just the guy, CCed. :-) On Sun, Jan 20, 2013 at 11:33:19AM +0100, Udo van den Heuvel wrote: > > Hello, > > See below for a part of the logging on this F2A85X-UP4 with AMD > a10-5800k. Box was raid checking I guess. > > > Jan 20 03:42:08 s3 rsyslogd: [origin software="rsyslogd" > swVersi

Re: [PATCH] firewire net: Ensure checksumming in upper layer.

2013-01-20 Thread YOSHIFUJI Hideaki
Stefan Richter wrote: > On Jan 20 YOSHIFUJI Hideaki wrote: >> It is wrong to set skb->ip_summed to CHECKSUM_UNNECESSARY unless >> the device has already checked it. >> >> Signed-off-by: YOSHIFUJI Hideaki >> --- >> drivers/firewire/net.c |2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-)

Re: 3.6.11 AMD-Vi: Completion-Wait loop timed out

2013-01-20 Thread Udo van den Heuvel
Hello, On 2013-01-20 11:36, Borislav Petkov wrote: > I know just the guy, CCed. :-) Thanks for the quick response! I found this similar case: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1073384 Kind regards, Udo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel"

more cpufreq funsies

2013-01-20 Thread Borislav Petkov
Hi, anyone seen this already? I've got this this morning when resuming and this is -rc4+ (+ tip/master) but without any other cpufreq and powernow-k8 patches. It says below "[last unloaded: acpi_cpufreq]" because I played with loading and unloading powernow-k8 and acpi-cpufreq yesterday but ...

Re: [PATCH] fat: eliminate iterations in fat_search_long in case of EOD

2013-01-20 Thread OGAWA Hirofumi
Namjae Jeon writes: > From: Namjae Jeon > > When searching a directory for names, we can stop checking for further > entries if we detect End of Directory, i.e. if (de->name[0] == 0x00).The > current code traverses the cluster chain of a directory until a hit is > found or till the last cluster

Re: [PATCH v5 7/8] fat (exportfs): rebuild directory-inode if fat_dget() fails

2013-01-20 Thread OGAWA Hirofumi
Namjae Jeon writes: > We rewrite patch as your suggestion using dummy inode. Would please > you review below patch code ? Looks like good as initial. Clean and shorter. Next is, we have to think about race. I.e. if real inode was made, what happens? Is there no race? Thanks. > Subject: [PATCH

Re: 3.6.11 AMD-Vi: Completion-Wait loop timed out

2013-01-20 Thread Jörg Rödel
On Sun, Jan 20, 2013 at 11:40:20AM +0100, Udo van den Heuvel wrote: > Hello, > > On 2013-01-20 11:36, Borislav Petkov wrote: > > I know just the guy, CCed. :-) > > Thanks for the quick response! > I found this similar case: > https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1073384 Yes, this

Kernel 3.7.* Problerm

2013-01-20 Thread Suho Park
I used the following method since 2.4 version 1. copy .config from the old kernel 2. make oldconfig (2-1. make dep) 3. make && make modules && make modules_install && make install and then change the symbolic link of kernel header in /usr/include to the compiled kernel header. Works well from 2.4.0

Re: 3.6.11 AMD-Vi: Completion-Wait loop timed out

2013-01-20 Thread Udo van den Heuvel
Hello Jörg, On 2013-01-20 12:19, Jörg Rödel wrote: > On Sun, Jan 20, 2013 at 11:40:20AM +0100, Udo van den Heuvel wrote: >> Hello, >> >> On 2013-01-20 11:36, Borislav Petkov wrote: >>> I know just the guy, CCed. :-) >> >> Thanks for the quick response! >> I found this similar case: >> https://bugs

[PATCH v1] mmc: core: move the cache disabling operation to mmc_suspend

2013-01-20 Thread Maya Erez
Cache control is an eMMC feature and in therefore should be part of MMC's bus resume operations, performed in mmc_suspend, rather than in the generic mmc_suspend_host(). Signed-off-by: Maya Erez diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c index aaed768..b438bb2 100644 --- a/dr

Re: 3.6.11 AMD-Vi: Completion-Wait loop timed out

2013-01-20 Thread Jörg Rödel
On Sun, Jan 20, 2013 at 12:25:07PM +0100, Udo van den Heuvel wrote: > Hello Jörg, > > Hardware issue? What is wrong c.q. happening? I think it falls under Erratum 455 (which does not mention IOMMU specifically). Point is, there is a hardware workaround for this to make the IOMMU work, but your BI

Re: 3.6.11 AMD-Vi: Completion-Wait loop timed out

2013-01-20 Thread Borislav Petkov
On Sun, Jan 20, 2013 at 12:40:11PM +0100, Jörg Rödel wrote: > Yes, the BIOS vendor can fix this issue. They need to disable NB clock > gating for the IOMMU. Right, Udo, you can try Gigabyte first. Btw, can't we add a quirk to disable NB clock gating? Maybe Boris and Jacob could help. CCed. Guys,

Re: 3.6.11 AMD-Vi: Completion-Wait loop timed out

2013-01-20 Thread Borislav Petkov
On Sun, Jan 20, 2013 at 12:48:28PM +0100, Borislav Petkov wrote: > On Sun, Jan 20, 2013 at 12:40:11PM +0100, Jörg Rödel wrote: > > Yes, the BIOS vendor can fix this issue. They need to disable NB clock > > gating for the IOMMU. > > Right, Udo, you can try Gigabyte first. Btw, you're running the l

Re: 3.6.11 AMD-Vi: Completion-Wait loop timed out

2013-01-20 Thread Udo van den Heuvel
On 2013-01-20 12:48, Borislav Petkov wrote: > On Sun, Jan 20, 2013 at 12:40:11PM +0100, Jörg Rödel wrote: >> Yes, the BIOS vendor can fix this issue. They need to disable NB clock >> gating for the IOMMU. > > Right, Udo, you can try Gigabyte first. I just did so and referred to the kernel.org bug

Re: 3.6.11 AMD-Vi: Completion-Wait loop timed out

2013-01-20 Thread Jörg Rödel
On Sun, Jan 20, 2013 at 12:48:28PM +0100, Borislav Petkov wrote: > On Sun, Jan 20, 2013 at 12:40:11PM +0100, Jörg Rödel wrote: > > Yes, the BIOS vendor can fix this issue. They need to disable NB clock > > gating for the IOMMU. > > Right, Udo, you can try Gigabyte first. > > Btw, can't we add a q

Re: 3.6.11 AMD-Vi: Completion-Wait loop timed out

2013-01-20 Thread Udo van den Heuvel
On 2013-01-20 12:50, Borislav Petkov wrote: >> Right, Udo, you can try Gigabyte first. > > Btw, you're running the latest BIOS from them, I assume? Nope. But I am beyond their first released BIOS, I am running one of their beta BIOSes. I am two beta updates behind current with F3g. They list as d

Re: [PATCH] rtc: hid-sensor-time: Add missing spin_lock_init

2013-01-20 Thread Jonathan Cameron
On 01/17/2013 12:47 PM, Alexander Holler wrote: > Am 17.01.2013 02:49, schrieb Axel Lin: > > Thanks, yes, I missed it the initialization of the spinlock. > > Below is my ack. > > Regards, > > Alexander > >> Signed-off-by: Axel Lin > > Acked-by: Alexander Holler Applied to togreg branch of i

Re: 3.6.11 AMD-Vi: Completion-Wait loop timed out

2013-01-20 Thread Borislav Petkov
On Sun, Jan 20, 2013 at 12:59:59PM +0100, Udo van den Heuvel wrote: > On 2013-01-20 12:50, Borislav Petkov wrote: > >> Right, Udo, you can try Gigabyte first. > > > > Btw, you're running the latest BIOS from them, I assume? > > Nope. But I am beyond their first released BIOS, I am running one of

[3.8-rc4 arm] SCSI_SYM53C8XX_2 module cannot register IRQ

2013-01-20 Thread Tetsuo Handa
Hello. I'm experiencing two regressions in 3.8-rcX. Regression: (1) Console shows nothing, which makes it impossible to determine whether the system is working or not. (2) SCSI_SYM53C8XX_2 cannot register IRQ, showing below messages upon load. PCI: enabling device :00:0c.0

Re: 3.7.3, ttyUSB0 serial problem - devices stop working and only reboot helps (Inappropriate ioctl for device)

2013-01-20 Thread Arkadiusz Miskiewicz
On Sunday 20 of January 2013, Arkadiusz Miskiewicz wrote: > On Sunday 20 of January 2013, Woody Suwalski wrote: > > Arkadiusz Miskiewicz wrote: > > > On Saturday 19 of January 2013, Arkadiusz Miskiewicz wrote: > > >> On Saturday 19 of January 2013, Greg Kroah-Hartman wrote: > > >>> On Fri, Jan 18,

Re: [RESEND][PATCH] dma: edma: fix slave config dependency on direction

2013-01-20 Thread Vinod Koul
On Thu, Jan 10, 2013 at 01:41:04PM -0500, Matt Porter wrote: > The edma_slave_config() implementation depends on the > direction field such that it will not properly configure > a slave channel when called without direction set. > > This fixes the implementation so that the slave config > is copie

Re: [PATCH V3 2/3] thermal: exynos: Miscellaneous fixes to support falling threshold interrupt

2013-01-20 Thread Shubhrajyoti Datta
On 1/17/13, Amit Daniel Kachhap wrote: > Below fixes are done to support falling threshold interrupt, > * Falling interrupt status macro corrected according to exynos5 data sheet. > * The get trend function modified to calculate trip temperature correctly. > * The clearing of interrupt status in t

Re: IPsec AH use of ahash

2013-01-20 Thread Tom St Denis
- Original Message - > From: "Mike Galbraith" > To: "Tom St Denis" > Cc: "Eric Dumazet" , "Waskiewicz Jr, Peter P" > , "David Miller" > , "steffen klassert" , > herb...@gondor.apana.org.au, > linux-kernel@vger.kernel.org, net...@vger.kernel.org, "Michal Kubecek" > > Sent: Sunday, 20

Re: IPsec AH use of ahash

2013-01-20 Thread Tom St Denis
- Original Message - > From: "Borislav Petkov" > To: "Mike Galbraith" > Cc: "Tom St Denis" , "Eric Dumazet" > , "Waskiewicz Jr, Peter P" > , "David Miller" , > "steffen klassert" > , herb...@gondor.apana.org.au, > linux-kernel@vger.kernel.org, net...@vger.kernel.org, > "Michal Kubece

Re: [PATCH v2 0/3] dmaengine: add per channel capabilities api

2013-01-20 Thread Vinod Koul
On Thu, Jan 10, 2013 at 02:07:03PM -0500, Matt Porter wrote: > The call is implemented as follows: > > struct dmaengine_chan_caps > *dma_get_channel_caps(struct dma_chan *chan, > enum dma_transfer_direction dir); > > The dma transfer direction parameter may

Re: [PATCH v2 1/3] dmaengine: add dma_get_channel_caps()

2013-01-20 Thread Vinod Koul
On Thu, Jan 10, 2013 at 02:07:04PM -0500, Matt Porter wrote: > +/* struct dmaengine_chan_caps - expose capability of a channel > + * Note: each channel can have same or different capabilities > + * > + * This primarily classifies capabilities into > + * a) APIs/ops supported > + * b) channel physic

Re: [PATCH v1] mmc: core: move the cache disabling operation to mmc_suspend

2013-01-20 Thread Ulf Hansson
On 20 January 2013 12:29, Maya Erez wrote: > Cache control is an eMMC feature and in therefore should be > part of MMC's bus resume operations, performed in mmc_suspend, > rather than in the generic mmc_suspend_host(). > > Signed-off-by: Maya Erez > > diff --git a/drivers/mmc/core/core.c b/driver

Re: [PATCH v2 2/3] dma: edma: add device_channel_caps() support

2013-01-20 Thread Vinod Koul
On Thu, Jan 10, 2013 at 02:07:05PM -0500, Matt Porter wrote: > Implement device_channel_caps(). > > EDMA has a finite set of PaRAM slots available for linking > a multi-segment SG transfer. In order to prevent any one > channel from consuming all PaRAM slots to fulfill a large SG > transfer, the d

Re: IPsec AH use of ahash

2013-01-20 Thread Alexander Holler
Am 20.01.2013 13:56, schrieb Tom St Denis: You should really try running checkpatch.pl over code that's already in the kernel before you call out new contributors on it. How is this supposed to not be adversarial when I can't even use the Kernel source itself as a reference? In case of the

Re: Comparing linux kernel trees.

2013-01-20 Thread Clemens Ladisch
James Courtier-Dutton wrote: > I have been given a linux kernel sources tar file. > It contains a modified version of the linux kernel. > It is just source files, without any "git" history. > What I would like to do is compare this with the mainline linux kernel > git tree, and find the tag from th

Re: IPsec AH use of ahash

2013-01-20 Thread Tom St Denis
- Original Message - > From: "Alexander Holler" > To: "Tom St Denis" > Cc: "Borislav Petkov" , "Eric Dumazet" , > "Waskiewicz Jr, Peter P" > , "David Miller" , > "steffen klassert" > , herb...@gondor.apana.org.au, > linux-kernel@vger.kernel.org, net...@vger.kernel.org, > "Michal Kube

Re: [PATCH 05/29] perf, kvm: Support the intx/intx_cp modifiers in KVM arch perfmon emulation v4

2013-01-20 Thread Gleb Natapov
On Thu, Jan 17, 2013 at 12:36:28PM -0800, Andi Kleen wrote: > From: Andi Kleen > > This is not arch perfmon, but older CPUs will just ignore it. This makes > it possible to do at least some TSX measurements from a KVM guest > > Cc: a...@redhat.com > Cc: g...@redhat.com > v2: Various fixes to add

Re: [PATCH 0/6] acpi-cpufreq and powernow-k8 fixes

2013-01-20 Thread Rafael J. Wysocki
On Sunday, January 20, 2013 11:24:24 AM Borislav Petkov wrote: > From: Borislav Petkov > > Hi all, > > here are a couple of patches fixing acpi-cpufreq and powernow-k8 loading > sequence and handoff. > > Patch 0001 should be in Rafael's tree already but I'm adding it here for > the sake of comp

Re: IPsec AH use of ahash

2013-01-20 Thread Mike Galbraith
On Sun, 2013-01-20 at 07:55 -0500, Tom St Denis wrote: > > - Original Message - > > From: "Mike Galbraith" > > To: "Tom St Denis" > > Cc: "Eric Dumazet" , "Waskiewicz Jr, Peter P" > > , "David Miller" > > , "steffen klassert" , > > herb...@gondor.apana.org.au, > > linux-kernel@vger.ke

Re: [PATCH] dma: remove unnecessary null pointer check in mmp_pdma.c

2013-01-20 Thread Vinod Koul
On Tue, Jan 15, 2013 at 01:19:48AM +0100, Cong Ding wrote: > the pointer cfg is dereferenced in line 594, so it's no reason to check null > again in line 620. > > Signed-off-by: Cong Ding > --- > drivers/dma/mmp_pdma.c |6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --

Re: [PATCH] dma: sh/shdma-base.c: remove unnecessary null pointer check

2013-01-20 Thread Vinod Koul
On Tue, Jan 15, 2013 at 01:23:48AM +0100, Cong Ding wrote: > the variable chan is dereferenced in line 635, so it is no reason to check > null again in line 641. > > Signed-off-by: Cong Ding > --- > drivers/dma/sh/shdma-base.c |3 --- > 1 file changed, 3 deletions(-) > > diff --git a/driver

Re: [PATCH] firewire net: Ensure checksumming in upper layer.

2013-01-20 Thread Stephan Gatzka
Indeed neither the device nor the lower drivers check protocol checksums. But the CRCs of the encapsulating 1394 packets are checked in hardware. Shall protocol checksums be verified regardless? Yes, because packets may come from off-link source. Hm, I can't see any off-link packets coming

[RFC][PATCH 3/3] ACPI / PM: Expose lists of device power resources to user space

2013-01-20 Thread Rafael J. Wysocki
From: Rafael J. Wysocki Since ACPI power resources are going to be used more extensively on new hardware platforms, it is necessary to allow user space (powertop in particular) to look at the lists of power resources corresponding to different power states of devices for diagnostics and control p

[RFC][PATCH 0/3] ACPI / PM: Export power resources information to user space

2013-01-20 Thread Rafael J. Wysocki
Hi Greg, The following patch series is about exporting ACPI power resources to user space that will be necessary for PM diagnostics on new platforms (powertop is the target). Still, existing systems can also benefit from that, like my oldish HP nx6325 on which the patches have been tested. Patch

[RFC][PATCH 1/3] ACPI / PM: Expose reference count values of ACPI power resources

2013-01-20 Thread Rafael J. Wysocki
From: Rafael J. Wysocki Since ACPI power resources are going to be used more extensively on new hardware platforms, it becomes necessary for user space (powertop in particular) to observe some properties of those resources for diagnostics purposes. For this reason, export the reference counts of

[RFC][PATCH 2/3] sysfs: Functions for adding/removing symlinks to/from attribute groups

2013-01-20 Thread Rafael J. Wysocki
From: Rafael J. Wysocki The most convenient way to expose ACPI power resources lists of a device is to put symbolic links to sysfs directories representing those resources into special attribute groups in the device's sysfs directory. For this purpose, it is necessary to be able to add symbolic

[patch] f2fs: use _safe() version of list_for_each

2013-01-20 Thread Dan Carpenter
This is calling list_del() inside a loop which is a problem when we try move to the next item on the list. I've converted it to use the _safe version. And also, as a cleanup, I've converted it to use list_for_each_entry instead of list_for_each. Signed-off-by: Dan Carpenter --- Static analysis

Re: IPsec AH use of ahash

2013-01-20 Thread Tom St Denis
- Original Message - > From: "Mike Galbraith" > To: "Tom St Denis" > Cc: "Eric Dumazet" , "Waskiewicz Jr, Peter P" > , "David Miller" > , "steffen klassert" , > herb...@gondor.apana.org.au, > linux-kernel@vger.kernel.org, net...@vger.kernel.org, "Michal Kubecek" > > Sent: Sunday, 20 J

Re: [PATCH] firewire net: Ensure checksumming in upper layer.

2013-01-20 Thread YOSHIFUJI Hideaki
Stephan Gatzka wrote: > >>> Indeed neither the device nor the lower drivers check protocol checksums. >>> But the CRCs of the encapsulating 1394 packets are checked in hardware. >>> Shall protocol checksums be verified regardless? >> >> Yes, because packets may come from off-link source. >> > > H

Re: [PATCH] firewire net: Ensure checksumming in upper layer.

2013-01-20 Thread Stephan Gatzka
"Off-link source" means the source exists on the different L2 network. In other words, source is connected via router(s). ethernet firewire Host -- Router Host O.k., understood. But the receiving router verifies the checksum of incoming pack

[PATCH 1/2] wlan-ng/prism2mgmt.c: added parantheses to macro

2013-01-20 Thread Sebastian Wankerl
From: Sebastian Wankerl Enclose the macro into braces so that it can be closed by a semicolon Signed-off-by: Sebastian Wankerl Signed-off-by: Sebastian Ehrenfels --- drivers/staging/wlan-ng/prism2mgmt.c | 25 +++-- 1 file changed, 15 insertions(+), 10 deletions(-) dif

[PATCH 2/2] wlan-ng/prism2mgmt.c: formated too long lines

2013-01-20 Thread Sebastian Wankerl
From: Sebastian Wankerl Formated pr_debug() calls Signed-off-by: Sebastian Wankerl Signed-off-by: Sebastian Ehrenfels --- drivers/staging/wlan-ng/prism2mgmt.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/drivers/staging/wlan-ng/prism2mgmt.c b/driver

Re: sched: Consequences of integrating the Per Entity Load Tracking Metric into the Load Balancer

2013-01-20 Thread Alex Shi
On 01/09/2013 11:14 AM, Preeti U Murthy wrote: > Here comes the point of making both load balancing and wake up > balance(select_idle_sibling) co operative. How about we always schedule > the woken up task on the prev_cpu? This seems more sensible considering > load balancing consid

[PULL] kms locking rework

2013-01-20 Thread Daniel Vetter
Hi Dave, I've figured a pull request is easier ;-) Changes since the patchbomb on dri-devel: - Added a patch to adjust the new omapdrm code in 3.8-rc4, reviewed by Rob Clark on irc (hence also why the baseline of this pull is 3.8-rc4). - Slightly fixed/clarified some commit messages and fixed o

Re: thoughts on requiring multi-arch support for arm drm drivers?

2013-01-20 Thread Daniel Vetter
On Sun, Jan 20, 2013 at 4:08 PM, Rob Clark wrote: > One thing I've run into in the past when trying to make changes in drm > core, and Daniel Vetter has mentioned the same, is that it is a bit of > a pain to compile test things for the arm drivers that do not support > CONFIG_ARCH_MULTIPLATFORM.

Re: [PATCH] firewire net: Ensure checksumming in upper layer.

2013-01-20 Thread YOSHIFUJI Hideaki
Stephan Gatzka wrote: > >> "Off-link source" means the source exists on the different L2 >> network. In other words, source is connected via router(s). >> >> ethernet firewire >> Host -- Router Host >> > > O.k., understood. But the receiving route

Re: sched: Consequences of integrating the Per Entity Load Tracking Metric into the Load Balancer

2013-01-20 Thread Alex Shi
>>> The blocked load of a cluster will be high if the blocked tasks have >>> run recently. The contribution of a blocked task will be divided by 2 >>> each 32ms, so it means that a high blocked load will be made of recent >>> running tasks and the long sleeping tasks will not influence the load >>>

Re: Introducing Aggressive Low Memory Booster [1]

2013-01-20 Thread PINTU KUMAR
Hi, Can anybody provide any inputs/suggestions/improvements on the following. According to my experiments these proved to be a useful utility during low memory condition on the embedded devices. Is there something wrong I am doing? Please provide your suggestions. Thanks, Pintu >___

Re: Comparing linux kernel trees.

2013-01-20 Thread James Courtier-Dutton
On 20 January 2013 13:27, Clemens Ladisch wrote: > James Courtier-Dutton wrote: >> I have been given a linux kernel sources tar file. >> It contains a modified version of the linux kernel. >> It is just source files, without any "git" history. >> What I would like to do is compare this with the ma

Re: [PATCH 2/3] binfmt_elf: Verify signature of signed elf binary

2013-01-20 Thread H. Peter Anvin
You then get into issues like: do we have to ban prelink as a result? Mimi Zohar wrote: >On Thu, 2013-01-17 at 10:51 -0500, Vivek Goyal wrote: >> On Thu, Jan 17, 2013 at 10:37:01AM -0500, Mimi Zohar wrote: >> > On Tue, 2013-01-15 at 16:34 -0500, Vivek Goyal wrote: >> > > If a binary is signed, v

[patch v3] b43: N-PHY: fix gain in b43_nphy_get_gain_ctl_workaround_ent()

2013-01-20 Thread Dan Carpenter
There were no break statements in this switch statement so everything used the default settings. Per Walter Harms's suggestion, I've replaced the switch statement and done a little cleanup. Signed-off-by: Dan Carpenter --- v2: Make additional style fixes as well while we're messing with the

Re: [PATCH v2 0/3] dmaengine: add per channel capabilities api

2013-01-20 Thread Matt Porter
On Sun, Jan 20, 2013 at 12:37:34PM +, Vinod Koul wrote: > On Thu, Jan 10, 2013 at 02:07:03PM -0500, Matt Porter wrote: > > The call is implemented as follows: > > > > struct dmaengine_chan_caps > > *dma_get_channel_caps(struct dma_chan *chan, > > enum dma_tran

Re: [PATCH v2 1/3] dmaengine: add dma_get_channel_caps()

2013-01-20 Thread Matt Porter
On Sun, Jan 20, 2013 at 12:52:43PM +, Vinod Koul wrote: > On Thu, Jan 10, 2013 at 02:07:04PM -0500, Matt Porter wrote: > > +/* struct dmaengine_chan_caps - expose capability of a channel > > + * Note: each channel can have same or different capabilities > > + * > > + * This primarily classifies

Re: [PATCH 2/3] binfmt_elf: Verify signature of signed elf binary

2013-01-20 Thread Mimi Zohar
On Thu, 2013-01-17 at 16:52 -0500, Vivek Goyal wrote: > On Thu, Jan 17, 2013 at 11:46:57PM +0200, Kasatkin, Dmitry wrote: > > On Thu, Jan 17, 2013 at 10:55 PM, Vivek Goyal wrote: > > > On Thu, Jan 17, 2013 at 03:33:47PM -0500, Frank Ch. Eigler wrote: > > >> Vivek Goyal writes: > > >> > > >> > [..

Re: [PATCH v2 2/3] dma: edma: add device_channel_caps() support

2013-01-20 Thread Matt Porter
On Sun, Jan 20, 2013 at 01:03:21PM +, Vinod Koul wrote: > On Thu, Jan 10, 2013 at 02:07:05PM -0500, Matt Porter wrote: > > Implement device_channel_caps(). > > > > EDMA has a finite set of PaRAM slots available for linking > > a multi-segment SG transfer. In order to prevent any one > > channe

Re: [PATCH 2/3] binfmt_elf: Verify signature of signed elf binary

2013-01-20 Thread Mimi Zohar
On Sun, 2013-01-20 at 08:17 -0800, H. Peter Anvin wrote: > You then get into issues like: do we have to ban prelink as a result? Once you change a file, the original signature shouldn't match. If you really trust prelink, then make prelink a trusted application that can resign the modified file.

Re: [PATCH 2/3] binfmt_elf: Verify signature of signed elf binary

2013-01-20 Thread H. Peter Anvin
On 01/20/2013 08:55 AM, Mimi Zohar wrote: > On Sun, 2013-01-20 at 08:17 -0800, H. Peter Anvin wrote: >> You then get into issues like: do we have to ban prelink as a result? > > Once you change a file, the original signature shouldn't match. If you > really trust prelink, then make prelink a trus

Re: IPsec AH use of ahash

2013-01-20 Thread H. Peter Anvin
On 01/20/2013 07:07 AM, Tom St Denis wrote: In all likelihood I will submit a revised CMAC patch but it'll take time before I can get business hours to work on it. So instead of having a maintainer just touch it up we're all going to lose out because of pride? It's not about pride. It is ab

Re: [PATCH 2/3] binfmt_elf: Verify signature of signed elf binary

2013-01-20 Thread Mimi Zohar
On Thu, 2013-01-17 at 12:36 -0500, Vivek Goyal wrote: > On Thu, Jan 17, 2013 at 11:32:45AM -0500, Mimi Zohar wrote: > > [..] > > > > At this point, why would you want yet another method for signing files? > > > > > > Are you saying that append signature instead of putting them in a section > > >

Re: IPsec AH use of ahash

2013-01-20 Thread Tom St Denis
- Original Message - > From: "H. Peter Anvin" > To: "Tom St Denis" > Cc: "Mike Galbraith" , "Eric Dumazet" > , "Waskiewicz Jr, Peter P" > , "David Miller" , > "steffen klassert" > , herb...@gondor.hengli.com.au, > linux-kernel@vger.kernel.org, net...@vger.kernel.org, > "Michal Kubecek"

Re: IPsec AH use of ahash

2013-01-20 Thread David Dillow
On Sun, 2013-01-20 at 10:07 -0500, Tom St Denis wrote: > In all likelihood I will submit a revised CMAC patch but it'll take > time before I can get business hours to work on it. So instead of > having a maintainer just touch it up we're all going to lose out > because of pride? Yes -- but it wou

Re: IPsec AH use of ahash

2013-01-20 Thread Tom St Denis
- Original Message - > From: "David Dillow" > To: "Tom St Denis" > Cc: linux-kernel@vger.kernel.org, net...@vger.kernel.org > Sent: Sunday, 20 January, 2013 11:34:52 AM > Subject: Re: IPsec AH use of ahash > > On Sun, 2013-01-20 at 10:07 -0500, Tom St Denis wrote: > > In all likelihood I

Re: [CRIU] [PATCH 2/3] signalfd: add ability to return siginfo in a raw format (v2)

2013-01-20 Thread Andrew Vagin
> > signalfd is a special descriptor, so I think it > > is not a big deal, that it works a bit strange. > > Sure, but the more we special case things, the uglier the ABI as a > whole becomes. So special casing should be avoided as far as we can. > > > If all other would > > decides, that a new s

Re: IPsec AH use of ahash

2013-01-20 Thread David Dillow
On Sun, 2013-01-20 at 12:40 -0500, Tom St Denis wrote: > > On Sun, 2013-01-20 at 10:07 -0500, Tom St Denis wrote: > > > In all likelihood I will submit a revised CMAC patch but it'll take > > > time before I can get business hours to work on it. So instead of > > > having a maintainer just touch i

Re: [CRIU] [PATCH 2/3] signalfd: add ability to return siginfo in a raw format (v2)

2013-01-20 Thread Michael Kerrisk (man-pages)
Hi Andrey, On Sun, Jan 20, 2013 at 6:41 PM, Andrew Vagin wrote: > >> > signalfd is a special descriptor, so I think it >> > is not a big deal, that it works a bit strange. >> >> Sure, but the more we special case things, the uglier the ABI as a >> whole becomes. So special casing should be avoide

Re: IPsec AH use of ahash

2013-01-20 Thread Tom St Denis
- Original Message - > From: "David Dillow" > To: "Tom St Denis" > Cc: linux-kernel@vger.kernel.org, net...@vger.kernel.org > Sent: Sunday, 20 January, 2013 1:11:11 PM > Subject: Re: IPsec AH use of ahash > > On Sun, 2013-01-20 at 12:40 -0500, Tom St Denis wrote: > > > On Sun, 2013-01-

Re: Kernel 3.7.* Problerm

2013-01-20 Thread Josh Boyer
On Sun, Jan 20, 2013 at 6:20 AM, Suho Park wrote: > I used the following method since 2.4 version > 1. copy .config from the old kernel > 2. make oldconfig > (2-1. make dep) > 3. make && make modules && make modules_install && make install > and then change the symbolic link of kernel header in /u

[PATCH 0/4] (Was: ptrace: prevent PTRACE_SETREGS from corrupting stack)

2013-01-20 Thread Oleg Nesterov
add lkml/cc's. On 01/18, Linus Torvalds wrote: > > On Fri, Jan 18, 2013 at 10:55 AM, Oleg Nesterov wrote: > > > > Or we can do this after wait_task_inactive() but then we need to take > > ->siglock again. > > Yes. We absolutely need siglock, since that would be exactly what > would protect us aga

[PATCH 1/4] ptrace: introduce signal_wake_up_state() and ptrace_signal_wake_up()

2013-01-20 Thread Oleg Nesterov
Cleanup and preparation for the next change. signal_wake_up(resume => true) is overused. None of ptrace/jctl callers actually want to wakeup a TASK_WAKEKILL task, but they can't specify the necessary mask. Turn signal_wake_up() into signal_wake_up_state(state), reintroduce signal_wake_up() as a t

[PATCH 2/4] ptrace: ensure arch_ptrace/ptrace_request can never race with SIGKILL

2013-01-20 Thread Oleg Nesterov
putreg() assumes that the tracee is not running and pt_regs_access() can safely play with its stack. However a killed tracee can return from ptrace_stop() to the low-level asm code and do RESTORE_REST, this means that debugger can actually read/modify the kernel stack until the tracee does SAVE_RES

[PATCH 3/4] ia64: kill thread_matches(), unexport ptrace_check_attach()

2013-01-20 Thread Oleg Nesterov
arch/ia64/kernel/ptrace.c:thread_matches() has no users since e868a55c "[IA64] remove find_thread_for_addr()", remove it. And this allows us to unexport ptrace_check_attach(). Signed-off-by: Oleg Nesterov --- arch/ia64/kernel/ptrace.c | 27 --- include/linux/ptrace.h

[PATCH 4/4] wake_up_process() should be never used to wakeup a TASK_STOPPED/TRACED task

2013-01-20 Thread Oleg Nesterov
wake_up_process() should never wakeup a TASK_STOPPED/TRACED task. Change it to use TASK_NORMAL and add the WARN_ON(). TASK_ALL has no other users, probably can be killed. Signed-off-by: Oleg Nesterov --- kernel/sched/core.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --gi

Re: [PATCH 0/4] (Was: ptrace: prevent PTRACE_SETREGS from corrupting stack)

2013-01-20 Thread Oleg Nesterov
On 01/20, Oleg Nesterov wrote: > > > And we'd need to make sure to re-set the WAKEKILL flag not just in all > > the callers of ptrace_check_attach(), but also in the failure case of > > wait_task_inactive(). I'm not sure it can actually fail if we cleared > > WAKEKILL, but it's all pretty subtle. >

  1   2   3   4   >