Re: Linux 2.6.25-rc2

2008-02-19 Thread Zhang, Yanmin
On Tue, 2008-02-19 at 17:52 +0200, Pekka Enberg wrote: > Ingo Molnar wrote: > > * Pekka Enberg <[EMAIL PROTECTED]> wrote: > > > >>> Yes, this can happen. Are you saying it is not safe to be in the > >>> lockless path when an IRQ triggers? > >> Hmm. The barrier() in slab_free() looks fishy. The co

Re: [discuss] pci_get_device_reverse(), why does Calgary need this?

2008-02-19 Thread Greg KH
On Thu, Feb 14, 2008 at 01:11:42PM +0100, Bartlomiej Zolnierkiewicz wrote: > On Thursday 14 February 2008, Andreas Jaeger wrote: > > Greg KH <[EMAIL PROTECTED]> writes: > > > > > How does the patch below look? I didn't want to remove the whole config > > > option, as there is more to the logic th

Re: [RFC] [PATCH] Fix b43 driver build for arm

2008-02-19 Thread Gordon Farquharson
Hi Michael On Feb 19, 2008 3:41 AM, Michael Buesch <[EMAIL PROTECTED]> wrote: > > [2] > > http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=7492d4a416d68ab4bd254b36ffcc4e0138daa8ff > > > > That doesn't cause me to magically sign off this sort of patches, too. > The

[2.6 patch] infiniband/hw/nes/nes_cm.c: fix a memory leak

2008-02-19 Thread Adrian Bunk
This patch fixes a memory leak spotted by the Coverity checker. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- 2d899a9f01001b2210972b199b951b67ed51 diff --git a/drivers/infiniband/hw/nes/nes_cm.c b/drivers/infiniband/hw/nes/nes_cm.c index bd5cfea..78e845c 100644 --- a/drivers/infiniband/

[PATCH 1/2] ide-mpc8xx: make m8xx_ide_init_ports() return an error value

2008-02-19 Thread Bartlomiej Zolnierkiewicz
* Make m8xx_ide_init_ports() return an error value. * Update mpc8xx_ide_probe() to setup/probe only ports for which m8xx_ide_init_ports() succedded. Cc: Vitaly Bordug <[EMAIL PROTECTED]> Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- drivers/ide/ppc/mpc8xx.c | 40 ++

Re: [2.6 patch] sony-laptop.c: fix off-by-one

2008-02-19 Thread Mattia Dongili
On Wed, Feb 20, 2008 at 12:59:03AM +0200, Adrian Bunk wrote: > This patch fixes an off-by-one spotted by the Coverity checker. > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Acked-by: Mattia Dongili <[EMAIL PROTECTED]> > --- > --- linux-2.6/drivers/misc/sony-laptop.c.old 2008-02-20 00:26:21

[2.6 patch] net/phy/mdio_bus.c: fix a check-after-use

2008-02-19 Thread Adrian Bunk
This patch fixes a check-after-use spotted by the Coverity checker. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- 6beeb3ac577d74d72b2f91bd654eecb904c3c17e diff --git a/drivers/net/phy/mdio_bus.c b/drivers/net/phy/mdio_bus.c index 6e9f619..963630c 100644 --- a/drivers/net/phy/mdio_bus.c +++

Re: [PATCH 1/2] bluetooth : put hci dev after del conn

2008-02-19 Thread Dave Young
On Feb 19, 2008 12:44 PM, David Miller <[EMAIL PROTECTED]> wrote: > From: Dave Young <[EMAIL PROTECTED]> > Date: Mon, 18 Feb 2008 15:55:55 +0800 > > > Move hci_dev_put to del_conn to avoid hci dev going away before hci conn. > > This looks correct so I have applied it. > > > Signed-off-by: Dave You

[2.6 patch] drivers/thermal/thermal.c: fix a check-after-use

2008-02-19 Thread Adrian Bunk
This patch fixes a check-after-use spotted by the Coverity checker. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- 570462ca4441d8d63dfd46efe6e5b2b1c251a611 diff --git a/drivers/thermal/thermal.c b/drivers/thermal/thermal.c index e782b3e..958654b 100644 --- a/drivers/thermal/thermal.c +++ b/d

[PATCH] ide_platform: fix resources handling

2008-02-19 Thread Bartlomiej Zolnierkiewicz
Tell IDE layer to not manage resources by always setting hwif->mmio flag (resources are handled by a platform device). Cc: Anton Vorontsov <[EMAIL PROTECTED]> Cc: Vitaly Bordug <[EMAIL PROTECTED]> Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- drivers/ide/legacy/ide_platform.c |

Re: [patch] my mmu notifiers

2008-02-19 Thread Andrea Arcangeli
On Tue, Feb 19, 2008 at 11:59:23PM +0100, Nick Piggin wrote: > That's why I don't understand the need for the pairs: it should be > done like this. Yes, except it can't be done like this for xpmem. > OK, I didn't see the invalidate_pages call... See the last patch I posted to Andrew, you've prob

Re: [Linux-fbdev-devel] [PATCH 1/2] fb: add support for foreign endianness

2008-02-19 Thread Valdis . Kletnieks
On Tue, 19 Feb 2008 04:05:30 PST, Andrew Morton said: > On Tue, 19 Feb 2008 12:27:54 +0100 Clemens Koller <[EMAIL PROTECTED] > wrote: > > That's not an issue in my case. The SM50x can be connected to > > either an PCI or some Local/CPU-whateverbus IF. > > I.e. on the MPC85xx PowerPC, PCI and LocalB

[PATCH] bast-ide: fix resources reservation

2008-02-19 Thread Bartlomiej Zolnierkiewicz
* Tell IDE layer to not manage resources by setting hwif->mmio flag and request resources in bastide_init(). * Use request_mem_region() for resources reservation. * Use driver name for resources reservation. Cc: Ben Dooks <[EMAIL PROTECTED]> Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PRO

[PATCH] falconide: fix resources reservation

2008-02-19 Thread Bartlomiej Zolnierkiewicz
* Tell IDE layer to not manage resources by setting hwif->mmio flag and request resources in falconide_init(). * Use request_mem_region() for resources reservation. * Use driver name for resources reservation. Cc: Geert Uytterhoeven <[EMAIL PROTECTED]> Cc: Michael Schmitz <[EMAIL PROTECTED]> S

[2.6 patch] infiniband/hw/nes/nes.c: fix a check-after-use

2008-02-19 Thread Adrian Bunk
This patch fixes a check-after-use spotted by the Coverity checker. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- e9468c7fb623f63582f5522493f6a43ab904e061 diff --git a/drivers/infiniband/hw/nes/nes.c b/drivers/infiniband/hw/nes/nes.c index 7f8853b..b2112f5 100644 --- a/drivers/infiniband/hw

[PATCH 2/2] ide-mpc8xx: fix resources reservation

2008-02-19 Thread Bartlomiej Zolnierkiewicz
* Tell IDE layer to not manage resources by setting hwif->mmio flag and request resources in m8xx_ide_init_ports(). * Use request_mem_region() for resources reservation. * Use driver name for resources reservation. Cc: Vitaly Bordug <[EMAIL PROTECTED]> Signed-off-by: Bartlomiej Zolnierkiewicz

Re: [patch] move wakeup code to .c

2008-02-19 Thread Rafael J. Wysocki
On Monday, 18 of February 2008, Rafael J. Wysocki wrote: > On Saturday, 16 of February 2008, Len Brown wrote: > > On Friday 15 February 2008 17:22, Rafael J. Wysocki wrote: > > > > > Ok, below is the version that survives checkpatch.pl, compiles on x86-32 > > > and has been successfully tested on

Re: tsc breaks atkbd suspend

2008-02-19 Thread Len Brown
On Tuesday 19 February 2008 11:51, Thomas Gleixner wrote: > On Tue, 19 Feb 2008, Ingo Molnar wrote: > > * Pavel Machek <[EMAIL PROTECTED]> wrote: > > > > > TSC is used even on machines when CONFIG_X86_TSC is not set (X86_TSC > > > means _require_ TSC), but it is not properly disabled when it is

[2.6 patch] message/fusion/mptbase.c: fix use-after-free's

2008-02-19 Thread Adrian Bunk
This patch fixes two use-after-free's introduced by commit e78d5b8f1e73ab82f3fd041d05824cfee7d83a2c and spotted by the Coverity checker. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- drivers/message/fusion/mptbase.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) 901baeee449

Re: Kernel oops with bluetooth usb dongle

2008-02-19 Thread Thomas Gleixner
On Tue, 19 Feb 2008, Marcel Holtmann wrote: > > > hci_cmd_task: hci0 command tx timeout > > > BUG: unable to handle kernel paging request at 6b6b6b6b > > > > We got some more info --- > > #define POISON_FREE 0x6b/* for use-after-free poisoning */ > > > > S

[PATCH] delkin_cb: fix resources handling

2008-02-19 Thread Bartlomiej Zolnierkiewicz
Tell IDE layer to not manage resources by setting hwif->mmio flag. Cc: Mark Lord <[EMAIL PROTECTED]> Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- drivers/ide/pci/delkin_cb.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) Index: b/drivers/ide/pci/delkin_cb.c =

Re: USB OOPS 2.6.25-rc2-git1

2008-02-19 Thread David Brownell
On Tuesday 19 February 2008, David Miller wrote: > From: Andre Tomt <[EMAIL PROTECTED]> > Date: Tue, 19 Feb 2008 16:19:08 +0100 > > > Got this on a serial console today, using 2.6.25-rc2-git1. Machine was > > not doing anything interesting at the time, but has its / and kernel on > > a usb-stora

[2.6 patch] net/9p/trans_virtio.c: kmalloc() enough memory

2008-02-19 Thread Adrian Bunk
The Coverity checker spotted that less memory than required was allocated. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- c9a5f66eca8484c302f848bb117b0bdb57e9ec42 diff --git a/net/9p/trans_virtio.c b/net/9p/trans_virtio.c index 9e3d81c..de7a9f5 100644 --- a/net/9p/trans_virtio.c +++ b/net/9p

Re: [PATCH 1/5] signal(x86_32): Improve the signal stack overflow check

2008-02-19 Thread Shi Weihua
Roland McGrath wrote:: > This change looks bogus to me. Before I get to the content, there is a nit > that annoys me. You changed the punctuation in my comment so that it no > longer means what it did, and now the comment is nonsensical. I don't > demand decent English from hackers of any lingui

Re: [patch] my mmu notifiers

2008-02-19 Thread Andrea Arcangeli
On Wed, Feb 20, 2008 at 12:04:27AM +0100, Nick Piggin wrote: > On Tue, Feb 19, 2008 at 08:27:25AM -0600, Jack Steiner wrote: > > > On Tue, Feb 19, 2008 at 02:58:51PM +0100, Andrea Arcangeli wrote: > > > > understand the need for invalidate_begin/invalidate_end pairs at all. > > > > > > The need of

Re: [Linux-fbdev-devel] [PATCH 1/2] fb: add support for foreign endianness

2008-02-19 Thread Benjamin Herrenschmidt
On Tue, 2008-02-19 at 19:47 -0500, [EMAIL PROTECTED] wrote: > On Tue, 19 Feb 2008 04:05:30 PST, Andrew Morton said: > > On Tue, 19 Feb 2008 12:27:54 +0100 Clemens Koller <[EMAIL PROTECTED] > > wrote: > > > That's not an issue in my case. The SM50x can be connected to > > > either an PCI or some Lo

2.6.25-rc2 System no longer powers off after suspend-to-disk. Screen becomes green.

2008-02-19 Thread Jeff Chua
On Feb 16, 2008 5:00 AM, Greg KH <[EMAIL PROTECTED]> wrote: > > Also, I've tried CONFIG_DETECT_SOFTLOCKUP=n, but this doesn't fix it either. > > Ok, this looks to be something else. > > > Here's the last dmesg after suspend-to-disk and hang there... > > > > CPU 1 is now offline > > SMP alternative

Re: [Linux-fbdev-devel] [PATCH 1/2] fb: add support for foreign endianness

2008-02-19 Thread Paul Mackerras
Andrew Morton writes: > Bizarrely, the original author of the patch (Anton) has fallen off the cc. > Could whoever did that please thwap himself? > > Anyway, my head is now officially spinning. Did anyone actually have a > reason why we shouldn't proceed with Anton's patch? I was wondering if

[git pull] agp patches for 2.6.25-rc3

2008-02-19 Thread Dave Airlie
Hi Linus, Please pull the 'agp-patches' branch from ssh://master.kernel.org/pub/scm/linux/kernel/git/airlied/agp-2.6.git agp-patches This contains a patch from Arjan to avoid ioremap stupidities in agp, and adds a warning to catch any others. It also contains an update for the SiS chipset driv

infiniband/hw/nes/nes_cm.c: use-after-free

2008-02-19 Thread Adrian Bunk
Spotted by the Coverity checker. <-- snip --> ... static int mini_cm_dec_refcnt_listen(struct nes_cm_core *cm_core, struct nes_cm_listener *listener, int free_hanging_nodes) { int ret = 1; unsigned long flags; spin_lock_irqsave(&cm_core->listen_list_lock,

[PATCH] PM: Remove unbalanced mutex_unlock() from dpm_resume()

2008-02-19 Thread Rafael J. Wysocki
Hi Greg, Please consider taking the following fix for 2.6.25. Thanks, Rafael --- From: Rafael J. Wysocki <[EMAIL PROTECTED]> Remove an unnecessary unlocking of dpm_list_mtx in the error path in drivers/base/power/main.c:dpm_suspend() . Signed-off-by: Rafael J. Wysocki <[EMAIL PROTECTED]> ---

Re: inode leak in 2.6.24?

2008-02-19 Thread David Chinner
On Tue, Feb 19, 2008 at 05:57:08PM +0100, Ferenc Wagner wrote: > David Chinner <[EMAIL PROTECTED]> writes: > > On Sat, Feb 16, 2008 at 12:18:58AM +0100, Ferenc Wagner wrote: > So, I loaded the same kernel on a different machine, but that seems to > exhibit a very similar behaviour. The machine is

Re: 2.6.25-rc2 System no longer powers off after suspend-to-disk. Screen becomes green.

2008-02-19 Thread Rafael J. Wysocki
On Wednesday, 20 of February 2008, Jesse Barnes wrote: > I found the same poweroff issue on my T61. It turned out to be related to > the > C state code disabling interrupts when it shouldn't iirc. Booting > with 'idle=poll' seems to work around the problem. However, this issue is supposed to

[2.6 patch] infiniband/hw/nes/nes_verbs.c: fix use-after-free

2008-02-19 Thread Adrian Bunk
This patch fixes a use-after-free spotted by the Coverity checker. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- drivers/infiniband/hw/nes/nes_verbs.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) --- linux-2.6/drivers/infiniband/hw/nes/nes_verbs.c.old 2008-02-20 03:02:1

Re: [patch] my mmu notifiers

2008-02-19 Thread Andrea Arcangeli
On Wed, Feb 20, 2008 at 12:11:57AM +0100, Nick Piggin wrote: > Sorry, I realise I still didn't get this through my head yet (and also > have not seen your patch recently). So I don't know exactly what you > are doing... The last version was posted here: http://marc.info/?l=kvm-devel&m=12032173252

[git pull] drm patches for 2.6.25-rc3

2008-02-19 Thread Dave Airlie
Hi Linus, Please pull the 'drm-patches' branch from ssh://master.kernel.org/pub/scm/linux/kernel/git/airlied/drm-2.6.git drm-patches Mainly fixes for i915 suspend/resume issues, sis/radeon pci id addition, and initial support for the GART on the AMD rs690 chipsets, along with the final nopage r

[PATCH][BLUETOOTH] CONWISE Technology based adapters with buggy SCO support (bugzilla #9027)

2008-02-19 Thread SDiZ
Hi, The attached patch (against current git head) fix the CONWISE Technology based adapters with buggy SCO support issue (bugzilla #9027) Regrads, Daniel Cheng (SDiZ) conwise-buggy-sco-support.patch Description: Binary data

Re: 2.6.25-rc2 System no longer powers off after suspend-to-disk. Screen becomes green.

2008-02-19 Thread Jesse Barnes
I found the same poweroff issue on my T61. It turned out to be related to the C state code disabling interrupts when it shouldn't iirc. Booting with 'idle=poll' seems to work around the problem. The "green screen" problem should be fixed (see the DRM git tree for details). Jesse On Tuesday,

Re: [patch 2/6] mmu_notifier: Callbacks to invalidate address ranges

2008-02-19 Thread Andrea Arcangeli
On Wed, Feb 20, 2008 at 10:08:49AM +1100, Nick Piggin wrote: > You can't sleep inside rcu_read_lock()! > > I must say that for a patch that is up to v8 or whatever and is > posted twice a week to such a big cc list, it is kind of slack to > not even test it and expect other people to review it. W

Re: [PATCH 1/5] signal(x86_32): Improve the signal stack overflow check

2008-02-19 Thread Roland McGrath
> > Please elaborate on the rationale that justifies this change. > > I don't see it at all. > > I have corrected the comment in the latest patch which has been apllied by > Ingo. > Please refer to http://lkml.org/lkml/2008/2/18/575 and > http://lkml.org/lkml/2008/2/19/119 . You have yet to say

Re: [bootup crash, -git] Re: patch pci-pcie-aspm-support.patchadded to gregkh-2.6 tree

2008-02-19 Thread Shaohua Li
On Tue, 2008-02-19 at 15:45 -0800, Greg KH wrote: > On Tue, Feb 19, 2008 at 01:45:45PM +0800, Shaohua Li wrote: > > Sorry for the long delay, I just back from vocation. I fixed all the > > issues I found in the list (except one hang issue, which should be fixed > > in specific driver, I'll reply t

Re: [PATCH 1/5] signal(x86_32): Improve the signal stack overflow check

2008-02-19 Thread Shi Weihua
Roland McGrath wrote:: >>> Please elaborate on the rationale that justifies this change. >>> I don't see it at all. >> I have corrected the comment in the latest patch which has been apllied by >> Ingo. >> Please refer to http://lkml.org/lkml/2008/2/18/575 and >> http://lkml.org/lkml/2008/2/19/11

[patch] sysfs: small header file cleanup

2008-02-19 Thread David Rientjes
Convert sysfs_remove_bin_file() to have a return type of 'void' for !CONFIG_SYSFS configurations. Also removes unnecessary colons from empty void functions. Cc: Randy Dunlap <[EMAIL PROTECTED]> Signed-off-by: David Rientjes <[EMAIL PROTECTED]> --- include/linux/sysfs.h |9 ++--- 1 files

Re: USB OOPS 2.6.25-rc2-git1

2008-02-19 Thread David Miller
From: David Brownell <[EMAIL PROTECTED]> Date: Tue, 19 Feb 2008 16:19:54 -0800 > On Tuesday 19 February 2008, David Miller wrote: > > From: Andre Tomt <[EMAIL PROTECTED]> > > Date: Tue, 19 Feb 2008 16:19:08 +0100 > > > > > Got this on a serial console today, using 2.6.25-rc2-git1. Machine was >

Re: TG3 network data corruption regression 2.6.24/2.6.23.4

2008-02-19 Thread Matt Carlson
On Tue, Feb 19, 2008 at 05:14:26PM -0500, Tony Battersby wrote: > Michael Chan wrote: > > On Tue, 2008-02-19 at 11:16 -0500, Tony Battersby wrote: > > > >> iSCSI > >> performance drops to 6 - 15 MB/s when the 3Com NIC is doing heavy rx > >> with light tx, > >> > > > > That's strange. The p

ftrace causing panics.

2008-02-19 Thread Dhaval Giani
Hi Ingo, ftrace-cmd in -w option when being run for sometime cause this. llm11.in.ibm.com login: [ 1002.937490] BUG: unable to handle kernel paging request at 285b0010 [ 1002.947087] IP: [] find_next_entry+0x4f/0x84 [ 1002.955091] *pdpt = 2d589001 *pde = [ 1002.963651]

Re: [PATCH] correct inconsistent ntp interval/tick_length usage

2008-02-19 Thread john stultz
On Tue, 2008-02-19 at 05:04 +0100, Roman Zippel wrote: > Hi, > > On Mon, 18 Feb 2008, john stultz wrote: > > > If we are building a train station, and each train car is 60ft, it > > doesn't make much sense to build 1000ft stations, right? Instead you'll > > do better if you build a 1020ft statio

Re: [PATCH 1/5] signal(x86_32): Improve the signal stack overflow check

2008-02-19 Thread Roland McGrath
> You mean the comment? No, that is trivial and already corrected. I mean the substance of your most recent patch. I described why I think it is wrong. You did not respond. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] M

Re: [PATCH 0/8][for -mm] mem_notify v6

2008-02-19 Thread Paul Jackson
Pavel, responding to pj: > > There is not much my customers HPC jobs can do with notification before > > swap. Their jobs either have the main memory they need to perform the > > requested calculations with the desired performance, or their job is > > useless and should be killed. Unlike the appl

Re: vfat32 Free Cluster Count Update

2008-02-19 Thread OGAWA Hirofumi
[EMAIL PROTECTED] writes: > (Or is 'df' simply a known way to force execution of a code path that ends up > fixing the counts as a side-effect?) Yes. df calls statfs(2), and FAT counts free clusters for ->f_ffree for it. Then, the free clusters count is fixed as a side-effect. -- OGAWA Hirofumi

Re: [2.6 patch] scsi/qla4xxx/ql4_isr.c: remove dead code

2008-02-19 Thread James Bottomley
On Tue, 2008-02-19 at 21:29 +0200, Adrian Bunk wrote: > This patch removes dead code spotted by the Coverity checker. > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> > > --- > > drivers/scsi/qla4xxx/ql4_isr.c | 18 +- > 1 file changed, 1 insertion(+), 17 deletions(-) > > -

Re: [PATCH] Provide u64 version of jiffies_to_usecs() in kernel/tsacct.c

2008-02-19 Thread Jonathan Lim
It's possible that the values used in and returned from jiffies_to_usecs() are incorrect because of truncation when variables of type u64 are involved. So a function specific to that type is used instead. This version implements a correction to jiffies_64_to_usecs() based on feedback from Randy D

Re: [PATCH 0/8][for -mm] mem_notify v6

2008-02-19 Thread Rik van Riel
On Tue, 19 Feb 2008 23:28:28 +0100 Pavel Machek <[EMAIL PROTECTED]> wrote: > Sounds like a job for memory limits (ulimit?), not for OOM > notification, right? I suspect one problem could be that an HPC job scheduling program does not know exactly how much memory each job can take, so it can somet

Re: Linux 2.6.25-rc2

2008-02-19 Thread Zhang, Yanmin
On Wed, 2008-02-20 at 08:36 +0800, Zhang, Yanmin wrote: > On Tue, 2008-02-19 at 17:52 +0200, Pekka Enberg wrote: > > Ingo Molnar wrote: > > > * Pekka Enberg <[EMAIL PROTECTED]> wrote: > > > > > >>> Yes, this can happen. Are you saying it is not safe to be in the > > >>> lockless path when an IRQ

Re: Improve init/Kconfig help descriptions [PATCH 6/9]

2008-02-19 Thread Paul Menage
On Feb 19, 2008 7:12 AM, Nick Andrew <[EMAIL PROTECTED]> wrote: > config CGROUPS > bool "Control Group support" > help > - This option will let you use process cgroup subsystems > - such as Cpusets > + Control Groups enables processes to be tracked and group

Re: [PATCH 1/5] signal(x86_32): Improve the signal stack overflow check

2008-02-19 Thread Shi Weihua
Roland McGrath wrote:: >> You mean the comment? > > No, that is trivial and already corrected. I mean the substance of your > most recent patch. I described why I think it is wrong. You did not respond. I spent some time read you mail carefully and dig into the code again. And yes, you are ri

Re: 2.6.25-rc2 System no longer powers off after suspend-to-disk. Screen becomes green.

2008-02-19 Thread Linus Torvalds
On Tue, 19 Feb 2008, Jesse Barnes wrote: > > I found the same poweroff issue on my T61. It turned out to be related to > the > C state code disabling interrupts when it shouldn't iirc. Booting > with 'idle=poll' seems to work around the problem. > > The "green screen" problem should be fixe

Re: [2.6 patch] scsi/qla4xxx/ql4_isr.c: remove dead code

2008-02-19 Thread Andrew Vasquez
On Tue, 19 Feb 2008, James Bottomley wrote: > On Tue, 2008-02-19 at 21:29 +0200, Adrian Bunk wrote: > > This patch removes dead code spotted by the Coverity checker. > > > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> > > > > --- > > > > drivers/scsi/qla4xxx/ql4_isr.c | 18 +--

[PATCH] mm: fix dma_poor_create

2008-02-19 Thread Yinghai Lu
dev_to_node could return node that without RAM. So check it before use it in kmalloc_node Signed-off-by: Yinghai Lu <[EMAIL PROTECTED]> diff --git a/mm/dmapool.c b/mm/dmapool.c index 34aaac4..6be5b5a 100644 --- a/mm/dmapool.c +++ b/mm/dmapool.c @@ -128,6 +128,7 @@ struct dma_pool *dma_pool_crea

Re: [PATCH] do_signal_stop: use signal_group_exit()

2008-02-19 Thread Eric W. Biederman
Oleg Nesterov <[EMAIL PROTECTED]> writes: > >>From 2.6.25-rc2-mm1.bz2 patch: >> >> - .ioctl = tty_ioctl, >> + .unlocked_ioctl = tty_ioctl, > > and this is why this didn't happen before, I guess. Right. Does anyone know what kind of audit was made of the tty code to ensure ev

Re: [2.6 patch] scsi/qla4xxx/ql4_isr.c: remove dead code

2008-02-19 Thread James Bottomley
On Tue, 2008-02-19 at 18:35 -0800, Andrew Vasquez wrote: > On Tue, 19 Feb 2008, James Bottomley wrote: > > > On Tue, 2008-02-19 at 21:29 +0200, Adrian Bunk wrote: > > > This patch removes dead code spotted by the Coverity checker. > > > > > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> > > >

Re: [patch] my mmu notifiers

2008-02-19 Thread Robin Holt
On Wed, Feb 20, 2008 at 01:52:06AM +0100, Andrea Arcangeli wrote: > On Wed, Feb 20, 2008 at 12:04:27AM +0100, Nick Piggin wrote: > > OK (thanks to Robin as well). Now I understand why you are using it, > > but I don't understand why you don't defer new TLBs after the point > > where the linux pte c

Re: [patch] my mmu notifiers

2008-02-19 Thread Robin Holt
On Wed, Feb 20, 2008 at 12:11:57AM +0100, Nick Piggin wrote: > On Tue, Feb 19, 2008 at 02:58:51PM +0100, Andrea Arcangeli wrote: > > On Tue, Feb 19, 2008 at 09:43:57AM +0100, Nick Piggin wrote: > > > anything when changing the pte to be _more_ permissive, and I don't > > > > Note that in my patch

Re: [PATCH 1/5] signal(x86_32): Improve the signal stack overflow check

2008-02-19 Thread Roland McGrath
> I spent some time read you mail carefully and dig into the code again. > > And yes, you are right. It's possible that SA_ONSTACK has been cleared > before the second signal on the same stack comes. It's not necessary for SA_ONSTACK to have "been cleared", by which I assume you mean a sigaction

Re: [PATCH 0/8][for -mm] mem_notify v6

2008-02-19 Thread KOSAKI Motohiro
Hi Rik > > Sounds like a job for memory limits (ulimit?), not for OOM > > notification, right? > > I suspect one problem could be that an HPC job scheduling program > does not know exactly how much memory each job can take, so it can > sometimes end up making a mistake and overcommitting the memo

Re: [RFC][PATCH 1/7] CGroup API: Add cgroup.api control file

2008-02-19 Thread Paul Menage
On Feb 19, 2008 1:57 PM, Paul Jackson <[EMAIL PROTECTED]> wrote: > > Finally, it goes against the one thingie per file (at most, one scalar > vector) that has worked well for us when tried. Right, I like the idea of keeping things simple. But if you're going to accept that a vector is useful, then

Re: [RFC][PATCH 1/7] CGroup API: Add cgroup.api control file

2008-02-19 Thread Paul Menage
On Feb 18, 2008 1:45 AM, Li Zefan <[EMAIL PROTECTED]> wrote: > > > > But we don't have /proc/proc.api or /sys/sysfs.api ... True. And /proc is a bit of a mess. Having a similar API file for sysfs sounds like a good idea to me. > > And is it better to describe the debug subsystem too? > Yes, prob

Re: [PATCH 3/7] cgroup: clean up cgroup.h

2008-02-19 Thread Paul Menage
On Feb 17, 2008 9:49 PM, Li Zefan <[EMAIL PROTECTED]> wrote: > - replace old name 'cont' with 'cgrp' (Paul Menage did this cleanup for > cgroup.c in commit bd89aabc6761de1c35b154fe6f914a445d301510) > - remove a duplicate declaration of cgroup_path() > > Signed-off-by: Li Zefan <[EMAIL PROTECTED]>

Re: Improve init/Kconfig help descriptions [PATCH 6/9]

2008-02-19 Thread Nick Andrew
On Tue, Feb 19, 2008 at 06:04:57PM -0800, Paul Menage wrote: > On Feb 19, 2008 7:12 AM, Nick Andrew <[EMAIL PROTECTED]> wrote: > > config CGROUPS > > [...] > > + When enabled, a new filesystem type "cgroup" is available > > + and can be mounted to control cpusets. > How about: > ..

Re: [2.6 patch] scsi/qla4xxx/ql4_isr.c: remove dead code

2008-02-19 Thread Andrew Vasquez
On Tue, 19 Feb 2008, James Bottomley wrote: > On Tue, 2008-02-19 at 18:35 -0800, Andrew Vasquez wrote: > > On Tue, 19 Feb 2008, James Bottomley wrote: > > > > > On Tue, 2008-02-19 at 21:29 +0200, Adrian Bunk wrote: > > > > This patch removes dead code spotted by the Coverity checker. > > > > > >

Re: [PATCH 5/7] cgroup: fix subsys bitops

2008-02-19 Thread Paul Menage
On Feb 17, 2008 9:49 PM, Li Zefan <[EMAIL PROTECTED]> wrote: > Cgroup uses unsigned long for subsys bitops, not unsigned long long. > > Signed-off-by: Li Zefan <[EMAIL PROTECTED]> Acked-by: Paul Menage <[EMAIL PROTECTED]> > --- > kernel/cgroup.c |4 ++-- > 1 files changed, 2 insertions(+), 2

Re: [PATCH 4/7] cgroup: fix memory leak in cgroup_get_sb()

2008-02-19 Thread Paul Menage
On Feb 17, 2008 9:49 PM, Li Zefan <[EMAIL PROTECTED]> wrote: > opts.release_agent is not kfree()ed in all necessary places. > > Signed-off-by: Li Zefan <[EMAIL PROTECTED]> Acked-by: Paul Menage <[EMAIL PROTECTED]> Good catch, although hopefully something that would be extremely rare in practice.

Re: [PATCH 1/7] cgroup: fix and update documentation

2008-02-19 Thread Paul Menage
On Feb 18, 2008 12:39 AM, Li Zefan <[EMAIL PROTECTED]> wrote: > Misc fixes and updates, make the doc consistent with current > cgroup implementation. > > Signed-off-by: Li Zefan <[EMAIL PROTECTED]> Acked-by: Paul Menage <[EMAIL PROTECTED]> Thanks for these cleanups. Paul > --- > Documentation/

[PATCH] (linus git 02/19/08) Smack update for file capabilities

2008-02-19 Thread Casey Schaufler
From: Casey Schaufler <[EMAIL PROTECTED]> Update the Smack LSM to allow the registration of the capability "module" as a secondary LSM. Integrate the new hooks required for file based capabilities. Signed-off-by: Casey Schaufler <[EMAIL PROTECTED]> --- security/smack/smack_lsm.c | 87 +++

Re: Improve init/Kconfig help descriptions [PATCH 6/9]

2008-02-19 Thread Paul Menage
On Feb 19, 2008 6:54 PM, Nick Andrew <[EMAIL PROTECTED]> wrote: > > config CGROUPS > bool "Control Group support" > help > Control Groups enables processes to be tracked and grouped > into "cgroups". This enables you, for example, to associate > cgroups

Re: [patch 5/6] mmu_notifier: Support for drivers with revers maps (f.e. for XPmem)

2008-02-19 Thread Robin Holt
On Wed, Feb 20, 2008 at 10:55:20AM +1100, Nick Piggin wrote: > On Friday 15 February 2008 17:49, Christoph Lameter wrote: > > These special additional callbacks are required because XPmem (and likely > > other mechanisms) do use their own rmap (multiple processes on a series > > of remote Linux ins

Re: [patch 2/6] mmu_notifier: Callbacks to invalidate address ranges

2008-02-19 Thread Nick Piggin
On Wednesday 20 February 2008 14:00, Robin Holt wrote: > On Wed, Feb 20, 2008 at 02:00:38AM +0100, Andrea Arcangeli wrote: > > On Wed, Feb 20, 2008 at 10:08:49AM +1100, Nick Piggin wrote: > > > Also, how to you resolve the case where you are not allowed to sleep? > > > I would have thought either

Re: [PATCH 6/7] cgroup: remove duplicate code in find_css_set()

2008-02-19 Thread Paul Menage
On Feb 17, 2008 9:49 PM, Li Zefan <[EMAIL PROTECTED]> wrote: > The list head res->tasks gets initialized twice in find_css_set(). > > Signed-off-by: Li Zefan <[EMAIL PROTECTED]> Acked-by: Paul Menage <[EMAIL PROTECTED]> > --- > kernel/cgroup.c |1 - > 1 files changed, 0 insertions(+), 1 dele

Re: [PATCH v2][POWERPC] Fix initial lmb add region with a non-zero base

2008-02-19 Thread Kumar Gala
On Feb 19, 2008, at 6:30 PM, David Miller wrote: From: Kumar Gala <[EMAIL PROTECTED]> Date: Tue, 19 Feb 2008 13:51:37 -0600 (CST) If we add to an empty lmb region with a non-zero base we will not coalesce the number of regions down to one. This causes problems on ppc32 for the memory reg

Re: [PATCH 2/7] cgroup: fix comments

2008-02-19 Thread Paul Menage
On Feb 17, 2008 9:49 PM, Li Zefan <[EMAIL PROTECTED]> wrote: > fix: > - comments about need_forkexit_callback > - comments about release agent > - typo and comment style, etc. > > Signed-off-by: Li Zefan <[EMAIL PROTECTED]> > --- > include/linux/cgroup.h |2 +- > kernel/cgroup.c| 44

Re: [PATCH 1/5] signal(x86_32): Improve the signal stack overflow check

2008-02-19 Thread Shi Weihua
Roland McGrath wrote:: >> I spent some time read you mail carefully and dig into the code again. >> >> And yes, you are right. It's possible that SA_ONSTACK has been cleared >> before the second signal on the same stack comes. > > It's not necessary for SA_ONSTACK to have "been cleared", by which

Re: [patch 2/6] mmu_notifier: Callbacks to invalidate address ranges

2008-02-19 Thread Robin Holt
On Wed, Feb 20, 2008 at 02:00:38AM +0100, Andrea Arcangeli wrote: > On Wed, Feb 20, 2008 at 10:08:49AM +1100, Nick Piggin wrote: > > You can't sleep inside rcu_read_lock()! > > > > I must say that for a patch that is up to v8 or whatever and is > > posted twice a week to such a big cc list, it is

Re: [PATCH v2][POWERPC] Fix initial lmb add region with a non-zero base

2008-02-19 Thread David Miller
From: Kumar Gala <[EMAIL PROTECTED]> Date: Tue, 19 Feb 2008 21:02:04 -0600 > np. Are we trying to get this into 2.6.25 or .26? I'm ambivalent but I would obviously prefer 2.6.25 because it would allow me to proceed more easily with my sparc64 NUMA work as well as get your bug fixes in more smoot

Re: [PATCH] Provide u64 version of jiffies_to_usecs() in kernel/tsacct.c

2008-02-19 Thread Randy Dunlap
Jonathan Lim wrote: It's possible that the values used in and returned from jiffies_to_usecs() are incorrect because of truncation when variables of type u64 are involved. So a function specific to that type is used instead. This version implements a correction to jiffies_64_to_usecs() based on

Re: [PATCH] procfs task exe symlink

2008-02-19 Thread Mike Frysinger
On Feb 19, 2008 4:54 PM, Matt Helsley <[EMAIL PROTECTED]> wrote: > On Sat, 2008-02-16 at 07:12 -0500, Mike Frysinger wrote: > > On Feb 6, 2008 8:44 PM, Matt Helsley <[EMAIL PROTECTED]> wrote: > > > The kernel implements readlink of /proc/pid/exe by getting the file from > > > the > > > first execu

Re: [bootup crash, -git] Re: patch pci-pcie-aspm-support.patchadded to gregkh-2.6 tree

2008-02-19 Thread Greg KH
On Wed, Feb 20, 2008 at 09:36:07AM +0800, Shaohua Li wrote: > --- linux.orig/include/linux/pci-acpi.h 2008-02-19 11:03:51.0 > +0800 > +++ linux/include/linux/pci-acpi.h2008-02-20 09:19:15.0 +0800 > @@ -47,6 +47,7 @@ > OSC_PCI_EXPRESS_CAP_STRU

[BUG] next-20080219 - ide oops while bootup at ide_device_add_all ()

2008-02-19 Thread Kamalesh Babulal
Hi, The next-20080219 kernel oops while booting up on x86_64 box. This bug was fixed in the 2.6.24-git(s) with the patch posted at http://lkml.org/lkml/2008/2/11/350 ide0 at 0x1f0-0x1f7,0x3f6 on irq 14 BUG: unable to handle kernel paging request at 80a37b8d IP: [] ide_device_add_all

Re: [patch 2/6] mmu_notifier: Callbacks to invalidate address ranges

2008-02-19 Thread Robin Holt
On Wed, Feb 20, 2008 at 02:11:41PM +1100, Nick Piggin wrote: > On Wednesday 20 February 2008 14:00, Robin Holt wrote: > > On Wed, Feb 20, 2008 at 02:00:38AM +0100, Andrea Arcangeli wrote: > > > On Wed, Feb 20, 2008 at 10:08:49AM +1100, Nick Piggin wrote: > > > > > Also, how to you resolve the case

Re: [patch 5/6] mmu_notifier: Support for drivers with revers maps (f.e. for XPmem)

2008-02-19 Thread Nick Piggin
On Wednesday 20 February 2008 14:12, Robin Holt wrote: > For XPMEM, we do not currently allow file backed > mapping pages from being exported so we should never reach this condition. > It has been an issue since day 1. We have operated with that assumption > for 6 years and have not had issues wit

Re: Improve init/Kconfig help descriptions [PATCH 4/9]

2008-02-19 Thread Valdis . Kletnieks
On Wed, 20 Feb 2008 01:38:55 +1100, Nick Andrew said: > + Enable an auditing infrastructure that can be used with another > + kernel subsystem, such as Security-Enhanced Linux (SELinux), > + which requires this option for logging of AVC messages output. > + > + AVC refers t

Re: [patch] sysfs: small header file cleanup

2008-02-19 Thread Randy Dunlap
David Rientjes wrote: Convert sysfs_remove_bin_file() to have a return type of 'void' for !CONFIG_SYSFS configurations. Also removes unnecessary colons from empty void functions. Cc: Randy Dunlap <[EMAIL PROTECTED]> Reviewed-by: Randy Dunlap <[EMAIL PROTECTED]> Thanks, David. Signed-off-by

Please pull powerpc.git merge branch

2008-02-19 Thread Paul Mackerras
Linus, Please do git pull \ git://git.kernel.org/pub/scm/linux/kernel/git/paulus/powerpc.git merge to get a few more bug and warning fixes for powerpc. The diffstat is bloated by the defconfig updates -- the actual code changes are only a few dozen lines. Thanks, Paul. arch/powerpc/boot/Make

Re: TG3 network data corruption regression 2.6.24/2.6.23.4

2008-02-19 Thread Herbert Xu
On Tue, Feb 19, 2008 at 05:14:26PM -0500, Tony Battersby wrote: > > Update: when I revert Herbert's patch in addition to applying your > patch, the iSCSI performance goes back up to 115 MB/s again in both > directions. So it looks like turning off SG for TX didn't itself cause > the performance dr

Re: Where to put adapters, /proc is cool

2008-02-19 Thread Valdis . Kletnieks
On Tue, 19 Feb 2008 14:39:45 EST, Karl Dahlke said: > Really, /proc is the only place for these virtual files that interact > directly with the kernel and/or its modules; > I just wanted a fixed place under /proc for adapters to live, > like sys ttys scsi net, and so on. There's an awful lot of s

Re: [PATCH 0/8][for -mm] mem_notify v6

2008-02-19 Thread Paul Jackson
Rik wrote: > In that case the user is better off having that job killed and > restarted elsewhere, than having all of the jobs on that node > crawl to a halt due to swapping. > > Paul, is this guess correct? :) Not for the loads I focus on. Each job gets exclusive use of its own dedicated set of

[PATCH] exporting capability code/name pairs (try #6)

2008-02-19 Thread Kohei KaiGai
>> If we can have a private member in kobj_attribute, we can found the content >> to be returned in a single step. > > Ok, again, just send me a patch that adds this functionality and we will > be very glad to consider it. [1/2] Add a private data field within kobj_attribute structure. This patc

[PATCH] exporting capability code/name pairs (try #6)

2008-02-19 Thread Kohei KaiGai
Greg KH wrote: On Mon, Feb 18, 2008 at 05:45:46PM +0900, Kohei KaiGai wrote: Greg KH wrote: Also, this code can be cleaned up a lot by just using the basic kobject attributes, and not rolling your own types here. I replaced my own defined capability_attribute by kobj_attribute. It made the pa

[PATCH] [LMB]: Fix lmb_add_region if region should be added at the head

2008-02-19 Thread Kumar Gala
We introduced a bug in fixing lmb_add_region to handle an initial region being non-zero. Before that fix it was impossible to insert a region at the head of the list since the first region always started at zero. Now that its possible for the first region to be non-zero we need to check to see if

Re: 2.6.25-rc2 System no longer powers off after suspend-to-disk. Screen becomes green.

2008-02-19 Thread Jesse Barnes
On Tuesday, February 19, 2008 6:28 pm Linus Torvalds wrote: > On Tue, 19 Feb 2008, Jesse Barnes wrote: > > I found the same poweroff issue on my T61. It turned out to be related > > to the C state code disabling interrupts when it shouldn't iirc. Booting > > with 'idle=poll' seems to work around

Re: [ofa-general] [2.6 patch] infiniband/hw/nes/nes_verbs.c: fix off-by-one

2008-02-19 Thread Roland Dreier
Thanks, this is already upstream as 51af33e8 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

<    1   2   3   4   5   6   7   >