On Mon, 14 Jan 2008 20:57:49 +0100
"Oliver Pinter (Pintér Olivér)" <[EMAIL PROTECTED]> wrote:
> Hi All!
>
> It is fully reproductable under 2.6.22.15, 2.6.23.13 (all tainted and
> not tainted [4 different kernel] ) and 2 different PC:
>
> [BUG] skge :02:05: read data parity error
> [BUG] skg
On Mon, Jan 14, 2008 at 05:43:24PM +0100, Ingo Molnar wrote:
>
> * Pallipadi, Venkatesh <[EMAIL PROTECTED]> wrote:
>
> > Also, relying on MTRR, is like giving more importance to BIOS writer
> > than required :-). I think the best way to deal with MTRR is just to
> > not touch it. Leave it as it
This preserves the parts of my change that mattered, is correctly more
conservative than my change was, and is fine with me.
Thanks,
Roland
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.k
The JMPRS register on Malta boards keeps a 32-bit CPU-endian
value. The readw() function assumes that the value it reads is a
little-endian 16-bit number. Therefore, using readw() to obtain
the value of the JMPRS register is a mistake. This error leads
to incorrect reading of the PCI clock frequenc
> Time to resurrect Jesse's old patches
> i386-trim-memory-not-covered-by-wb-mtrrs.patch(which was in -mm sometime back)
They broke booting on my AMD QuadCore system here. Never quite figured
out what the problem was unfortunately.
-Andi
--
To unsubscribe from this list: send the line "unsubscri
On Mon, 10 Dec 2007 17:34:44 +0530 (IST)
Poonam_Aggrwal-b10812 <[EMAIL PROTECTED]> wrote:
> From: Poonam Aggrwal <[EMAIL PROTECTED]>
>
> The UCC TDM driver basically multiplexes and demultiplexes data from
> different channels. It can interface with for example SLIC kind of devices
> to receive
diff --git a/Makefile b/Makefile
index 55edf2f..5c31700 100644
--- a/Makefile
+++ b/Makefile
@@ -1,7 +1,7 @@
VERSION = 2
PATCHLEVEL = 6
SUBLEVEL = 23
-EXTRAVERSION = .13
+EXTRAVERSION = .14
NAME = Arr Matey! A Hairy Bilge Rat!
# *DOCUMENTATION*
diff --git a/fs/namei.c b/fs/namei.c
index a831
We (the -stable team) are announcing the release of the 2.6.23.14
kernel.
It contains a single fix for a problem that could cause a local user to
cause file system corruption on some types of filesystems.
All users of the 2.6.23 series are encouraged to upgrade.
I'll also be replying to this mes
diff --git a/Makefile b/Makefile
index a8bdcc6..99c0237 100644
--- a/Makefile
+++ b/Makefile
@@ -1,7 +1,7 @@
VERSION = 2
PATCHLEVEL = 6
SUBLEVEL = 22
-EXTRAVERSION = .15
+EXTRAVERSION = .16
NAME = Holy Dancing Manatees, Batman!
# *DOCUMENTATION*
diff --git a/fs/namei.c b/fs/namei.c
index 5e2
Commit 9b8e8de7e59b3a2dab3113d620b52dc8ba890fb3 did:
--- a/drivers/ata/libata-scsi.c
+++ b/drivers/ata/libata-scsi.c
@@ -872,7 +872,8 @@ int ata_scsi_slave_config(struct scsi_device *sdev)
ata_scsi_sdev_config(sdev);
- sdev->manage_start_stop = 1;
+ if (dev->class == ATA_D
On Mon, Jan 14, 2008 at 12:52:00PM -0800, Stephen Hemminger wrote:
> On Mon, 14 Jan 2008 20:57:49 +0100
> "Oliver Pinter (Pintér Olivér)" <[EMAIL PROTECTED]> wrote:
>
> > Hi All!
> >
> > It is fully reproductable under 2.6.22.15, 2.6.23.13 (all tainted and
> > not tainted [4 different kernel] ) a
Hi Linus,
Please pull the i2c subsystem fixes for Linux 2.6.24 from:
git://jdelvare.pck.nerim.net/jdelvare-2.6 i2c-for-linus
drivers/i2c/busses/i2c-at91.c |2 +-
drivers/i2c/busses/i2c-omap.c |2 +-
drivers/i2c/busses/i2c-powermac.c |2 +-
drivers/i2c/busses/i2c-sibyte.c
The commit 84427eaef1fb91704c7112bdb598c810003b99f3 (remove task_ppid_nr_ns)
moves the task_tgid_nr_ns(task->real_parent) outside of lock_task_sighand().
This is wrong, ->real_parent could be freed/reused.
Both ->parent/real_parent point to nothnig after __exit_signal() because we
remove the child
We (the -stable team) are announcing the release of the 2.6.22.16
kernel.
It contains a single fix for a problem that could cause a local user to
cause file system corruption on some types of filesystems.
All users of the 2.6.22 series are encouraged to upgrade.
I'll also be replying to this mes
The Coverity checker spotted the following NULL dereference introduced
by commit cf0594625083111ae522496dc1c256f7476939c2:
<-- snip -->
...
struct hfs_btree *hfs_btree_open(struct super_block *sb, u32 id, btree_keycmp
keycmp)
{
...
if (!tree->inode)
goto free_tree;
...
Ralf Baechle on Atlas board support in the linux-mips mailing list:
Maciej is promising to fix it up since a few years ;-) Aside of that it's
safe to say the Atlas is dead like a coffin nail.
Signed-off-by: Dmitri Vorobiev <[EMAIL PROTECTED]>
---
Documentation/feature-removal-schedule.txt |
Address Roman's review comments for the previously sent on-disk
corruption hfs robustness patch.
I still owe a patch for hfsplus.
Signed-off-by: Eric Sandeen <[EMAIL PROTECTED]>
---
Index: linux-2.6.24-rc6-mm1/fs/hfs/bfind.c
===
On Mon, 14 Jan 2008 12:00:51 -0600
Kim Phillips <[EMAIL PROTECTED]> wrote:
> On Thu, 10 Jan 2008 21:41:20 -0700
> "Aggrwal Poonam" <[EMAIL PROTECTED]> wrote:
>
> > Hello All
> >
> > I am waiting for more feedback on the patches.
> >
> > If there are no objections please consider them for 2.6.2
[PATCH 3/3] x86_64: set cfg_size for AMD Family 10h in case MMCONFIG is used.
reuse pci_cfg_space_size but skip check pci express and pci-x CAP ID.
Signed-off-by: Yinghai Lu <[EMAIL PROTECTED]>
===
Index: linux-2.6/arch/x86/pci/fixu
[PATCH 2/3] x86_64: check MSR to get MMCONFIG for AMD Family 10h Opteron
So even MCFG is not there, we still can use MMCONFIG.
Signed-off-by: Yinghai Lu <[EMAIL PROTECTED]>
Index: linux-2.6/arch/x86/pci/mmconfig-shared.c
===
--- lin
[PATCH 1/3] x86_64: check and enable MMCONFIG for AMD Family 10h Opteron v2
So we can use MMCONF when MMCONF is not set BIOS or booting kernel with acpi=off
using TOP_MEM2 msr to get memory top, and try to scan fam10h mmio routing to
make sure the range is not conflicted with some prefetch MMIO t
please check the updated version, so we will not rely on MCFG setting
it is against to x86.git
these three patches can be applied seperately.
if you think 1/3 is too complicated, you can apply 2 and 3
Thanks
YH
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the b
On Mon, Jan 14, 2008 at 10:31:03PM +0100, Oliver Pinter (Pintér Olivér) wrote:
> I think, it is a potential security breakpoint, when applications with
> root permission its read, then a machine is freezed, or only i thin
> it's?
When you are root there are infinite ways to kill your machine, so
Adrian Bunk wrote:
> The Coverity checker spotted the following NULL dereference introduced
> by commit cf0594625083111ae522496dc1c256f7476939c2:
Oops. Thanks, Adrian.
Patch sent on a different thread, following another fixup patch for
Roman - you're cc'd.
Thanks,
-Eric
--
To unsubscribe from
On Mon, Jan 14, 2008 at 10:31:03PM +0100, Oliver Pinter (Pint?r Oliv?r) wrote:
> I think, it is a potential security breakpoint, when applications with
> root permission its read, then a machine is freezed, or only i thin
> it's?
I'm sorry, I don't quite understand what you are trying to say here.
Fix potential null deref introduced by commit
cf0594625083111ae522496dc1c256f7476939c2
http://bugzilla.kernel.org/show_bug.cgi?id=9748
Signed-off-by: Eric Sandeen <[EMAIL PROTECTED]>
---
Index: linux-2.6.24-rc6-mm1/fs/hfs/btree.c
==
On Saturday, 5 of January 2008, David Smith wrote:
> > On Fri 2008-01-04 14:09:01, Kent Yoder wrote:
> > > On Jan 4, 2008 10:39 AM, Pavel Machek <[EMAIL PROTECTED]> wrote:
> > > > On Thu 2008-01-03 21:44:15, Marcel Selhorst wrote:
> > > > > Dear list,
> > > > >
> > > > > this patch fixes a bug, tha
Hi,
On Sunday 13 January 2008, Borislav Petkov wrote:
> Hi Bart,
>
> here are the remaining patches which had issues to be worked out. I decided
> to keep the Flexible Disk Page and Capacity Descriptor in
> idefloppy_floppy_t for the sake of the two printk calls for which they are
> used. Otherw
On Sunday 13 January 2008, Borislav Petkov wrote:
> We merge idefloppy_{input,output}_buffers() into idefloppy_io_buffers() by
> introducing a 4th arg. called direction. According to its value
> we atapi_input_bytes() or atapi_output_bytes(). Also, this simplifies the
> interrupt handler logic a bi
On Sunday 13 January 2008, Borislav Petkov wrote:
> ..and replace them with flag enums.
>
> Signed-off-by: Borislav Petkov <[EMAIL PROTECTED]>
> ---
> drivers/ide/ide-floppy.c | 132 +
> 1 files changed, 73 insertions(+), 59 deletions(-)
[...]
> @@ -
On 1/14/08, Greg KH <[EMAIL PROTECTED]> wrote:
> On Mon, Jan 14, 2008 at 10:31:03PM +0100, Oliver Pinter (Pint?r Oliv?r)
> wrote:
> > I think, it is a potential security breakpoint, when applications with
> > root permission its read, then a machine is freezed, or only i thinK
> > it's?
>
> I'm sor
On Sunday 13 January 2008, Borislav Petkov wrote:
[...]
> - printk(KERN_ERR "ide-floppy: Packet size is not 12 bytes
> long\n");
> + printk(KERN_ERR "ide-floppy: Packet size is not 12 bytes "
> + "long\n");
I added dumping 'gcw.packet_size' fo
On Mon, 14 Jan 2008 22:40:58 +0100
"Rafael J. Wysocki" <[EMAIL PROTECTED]> wrote:
> > >
> > > Yep, but please fix the whitespace.
> > > Pavel
> >
> > OK, attached.
>
> Is anyone taking care of this patch or should I do that?
Linu
Quoting Miklos Szeredi ([EMAIL PROTECTED]):
> From: Miklos Szeredi <[EMAIL PROTECTED]>
>
> Add sysctl variables for accounting and limiting the number of user
> mounts.
>
> The maximum number of user mounts is set to 1024 by default. This
> won't in itself enable user mounts, setting a mount to
Quoting Miklos Szeredi ([EMAIL PROTECTED]):
> From: Miklos Szeredi <[EMAIL PROTECTED]>
>
> The owner doesn't need sysadmin capabilities to call umount().
>
> Similar behavior as umount(8) on mounts having "user=UID" option in /etc/mtab.
> The difference is that umount also checks /etc/fstab, pres
Quoting Miklos Szeredi ([EMAIL PROTECTED]):
> From: Miklos Szeredi <[EMAIL PROTECTED]>
>
> This patchset adds support for keeping mount ownership information in the
> kernel, and allow unprivileged mount(2) and umount(2) in certain cases.
>
> The mount owner has the following privileges:
>
> -
On 1/14/08, Adrian Bunk <[EMAIL PROTECTED]> wrote:
> On Mon, Jan 14, 2008 at 10:31:03PM +0100, Oliver Pinter (Pintér Olivér)
> wrote:
> > I think, it is a potential security breakpoint, when applications with
> > root permission its read, then a machine is freezed, or only i thin
> > it's?
>
> When
I think, it is a potential security breakpoint, when applications with
root permission its read, then a machine is freezed, or only i thin
it's?
--
Thanks,
Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordo
On Mon, Jan 14, 2008 at 11:01:05PM +0200, Adrian Bunk wrote:
> On Mon, Jan 14, 2008 at 12:52:00PM -0800, Stephen Hemminger wrote:
> > On Mon, 14 Jan 2008 20:57:49 +0100
> > "Oliver Pinter (Pint??r Oliv??r)" <[EMAIL PROTECTED]> wrote:
> >
> > > Hi All!
> > >
> > > It is fully reproductable under 2
On Fri, 2008-01-11 at 09:35 -0500, David P. Reed wrote:
> Using any "unused port" for a delay means that the machine check
> feature is wasted and utterly unusable.
Not entirely unusable. You can recover silently from the machine check
if it was one of the known accesses to the 'unused port'. I
I "tested" other devices resources file, and only with skge freezed
the system. from this think, that is skge driver bug
--
Thanks,
Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.k
> 200Mb had been filled when it had been umounted from /mnt/bootf8
> repartitioned, mke2fs'd, a journal added and a new label written and then
> mounted to /amandatapes.
>
> Something it seems to me, should have forced the re-init, but didn't. So is
Something I stumbled across just a few days ago
On 01/13, Peter Zijlstra wrote:
>
> On Mon, 2008-01-07 at 20:49 +0300, Oleg Nesterov wrote:
>
> > On 01/07, Oleg Nesterov wrote:
> > >
> > > Consider this "just for illustration" patch,
> > >
> > > --- t/kernel/lockdep.c2007-11-09 12:57:31.0 +0300
> > > +++ t/kernel/lockdep.c2008-
On Mon, Jan 14, 2008 at 10:41:52PM +0100, Oliver Pinter (Pint?r Oliv?r) wrote:
> On 1/14/08, Adrian Bunk <[EMAIL PROTECTED]> wrote:
> > On Mon, Jan 14, 2008 at 10:31:03PM +0100, Oliver Pinter (Pint?r Oliv?r)
> > wrote:
> > > I think, it is a potential security breakpoint, when applications with
> >
On Mon, Jan 14, 2008 at 10:41:52PM +0100, Oliver Pinter (Pintér Olivér) wrote:
> On 1/14/08, Adrian Bunk <[EMAIL PROTECTED]> wrote:
> > On Mon, Jan 14, 2008 at 10:31:03PM +0100, Oliver Pinter (Pintér Olivér)
> > wrote:
> > > I think, it is a potential security breakpoint, when applications with
> >
On Monday, 14 of January 2008, Andrew Morton wrote:
> On Mon, 14 Jan 2008 22:40:58 +0100
> "Rafael J. Wysocki" <[EMAIL PROTECTED]> wrote:
>
> > > >
> > > > Yep, but please fix the whitespace.
> > > >
> > > > Pavel
> > >
> >
On a fresh object dir I get for a 32bit build:
make -C /home/lsrc/quilt/linux O=/home/lsrc/quilt/obj32
GEN /home/lsrc/quilt/obj32/Makefile
CHK include/linux/version.h
CHK include/linux/utsrelease.h
Using /home/lsrc/quilt/linux as source for kernel
CALL/home/lsrc/quilt/l
Lots of improvements to change_page_attr(). Make it a lot more
efficient and fix various bugs.
Changes against earlier version
- Fixed some checkpatch.pl complaints
- Improved self test suite
- Fixed more reference bugs
- Fix NX handling on 32bit
- Remove some useless code there
- Few other ran
Andi Kleen wrote:
On Mon, Jan 14, 2008 at 02:06:20PM +0100, Ingo Molnar wrote:
* Andi Kleen <[EMAIL PROTECTED]> wrote:
Subject was wrong of course -- it was a recursive oops, not a double
fault. Sorry for the inaccuracy.
Hopefully it can be fixed soon because it inhibits further test
__FUNCTION__ is gcc specific, __func__ is C99
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
---
scripts/checkpatch.pl |5 +
1 file changed, 5 insertions(+)
Index: b/scripts/checkpatch.pl
===
--- a/scripts/che
On Jan 14, 2008 6:30 PM, Andy Whitcroft <[EMAIL PROTECTED]> wrote:
> On Sun, Jan 13, 2008 at 11:34:05PM +0100, Paolo Ciarrocchi wrote:
> > With the patch applied the output of checkpatch.pl is as follow:
> > ./arch/arm/mach-footbridge/ebsa285-pci.c
> > total: 1 errors, 0 warnings, 48 lines checked
No need to make it 64bit there.
Signed-off-by: Andi Kleen <[EMAIL PROTECTED]>
---
arch/x86/mm/init_32.c |4 ++--
include/asm-x86/pgtable.h |2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
Index: linux/arch/x86/mm/init_32.c
When CONFIG_DEBUG_RODATA is enabled undo the ro mapping and redo it again.
This gives some simple testing for change_page_attr()
Optional patch, but I find it useful.
Signed-off-by: Andi Kleen <[EMAIL PROTECTED]>
---
arch/x86/Kconfig.debug |5 +
arch/x86/mm/init_32.c | 26 ++
Needed for some test code.
Signed-off-by: Andi Kleen <[EMAIL PROTECTED]>
---
include/asm-x86/pgtable.h |3 +++
1 file changed, 3 insertions(+)
Index: linux/include/asm-x86/pgtable.h
===
--- linux.orig/include/asm-x86/pgtable.h
64bit already had it.
Needed for later patches.
Signed-off-by: Andi Kleen <[EMAIL PROTECTED]>
---
include/asm-x86/pgtable-2level.h |2 ++
include/asm-x86/pgtable-3level.h |2 ++
2 files changed, 4 insertions(+)
Index: linux/include/asm-x86/pgtable-2level.h
The pte_* modifier functions that cleared bits dropped the NX bit on 32bit
PAE because they only worked in int, but NX is in bit 63. Fix that
by adding appropiate casts so that the arithmetic happens as long long
on PAE kernels.
I decided to just use 64bit arithmetic instead of open coding like
p
Undo random white space changes. This reverts
ddb53b5735793a19dc17bcd98b050f672f28f1ea
I simply don't have the nerves to port a 20+ patch series to the
reformatted version. And the patch series changes most lines
anyways and drops the trailing white spaces there.
And since this was a nop losi
Intel recommends to first flush the TLBs and then the caches
on caching attribute changes. c_p_a() previously did it the
other way round. Reorder that.
The procedure is still not fully compliant to the Intel documentation
because Intel recommends a all CPU synchronization step between
the TLB flu
When the self-snoop CPUID bit is set change_page_attr() only needs to flush
TLBs, but not the caches.
The description of self-snoop in the Intel manuals is a bit vague
but I got confirmation that this is what SS really means.
This should improve c_p_a() performance significantly on newer
Intel C
Use the page table level instead of the PSE bit to check if the PTE
is for a 4K page or not. This makes the code more robust when the PAT
bit is changed because the PAT bit on 4K pages is in the same position as the
PSE bit.
Signed-off-by: Andi Kleen <[EMAIL PROTECTED]>
---
arch/x86/mm/pageatt
Hello,
> We are pleased to announce the 2.6.24-rc7-rt2 tree, which can be
> downloaded from the location:
>
> http://rt.et.redhat.com/download/
Compiles fine but I run into another problem. On startup kernel oopses
early and this 'oops' loops over and over again on the screen until you
shut do
Previously change_page_attr always flushed caches even for
pages that only change a non caching related attribute (like RO for
read/write protection).
This changes the flush code to only flush the cache when the
caching attributes actually change.
I made some effort to already handle reprogram
When c_p_a() detects a inconsistency in the kernel page tables
it BUGs. When this happens dump the page table first to avoid one
bug reporting round trip.
Signed-off-by: Andi Kleen <[EMAIL PROTECTED]>
---
arch/x86/mm/pageattr_32.c | 11 ++-
arch/x86/mm/pageattr_64.c | 11 +
Quoting Miklos Szeredi ([EMAIL PROTECTED]):
> From: Miklos Szeredi <[EMAIL PROTECTED]>
>
> Allow clone_mnt() to return errors other than ENOMEM. This will be used for
> returning a different error value when the number of user mounts goes over the
> limit.
>
> Fix copy_tree() to return EPERM for
Add a filename option (default to 0)
in order to get the following summary output:
./scripts/checkpatch.pl --filename --file ./arch/sparc/kernel/apc.c
...
...
...
./arch/sparc/kernel/apc.c --> total: 18 errors, 3 warnings, 186 lines checked
---
Andy,
I wonder why checkpatch doesn't show all the
David Woodhouse wrote:
On Fri, 2008-01-11 at 09:35 -0500, David P. Reed wrote:
Using any "unused port" for a delay means that the machine check
feature is wasted and utterly unusable.
Not entirely unusable. You can recover silently from the machine check
if it was one of the known ac
On Saturday 12 January 2008 11:13:35 pm Rene Herman wrote:
> ... And, now that I have your attention, while it's
> not important to the issue anymore with the tests removed as the submitted
> patch did, do you have an opinion on (include/linux/pnp.h):
>
> /* pnp driver flags */
> #define PNP_DRI
> As far as I know boolean parameters take values 0 and 1, not N and Y.
Not on the systems I am testing on (2.6.24-rc6) - the sysfs interface
displays boolean parameters as Y/N, and will accept boot parameters as
either Y/N or 0/1. Below is a snippet from a test proving this point :
[EMAIL PROT
Hi Andy,
When I started using checkpatch I was confused by the following WARN message:
no space between function name and open parenthesis
I thought the problem was that a space was missing while the truth is the
opposite.
How about the following patch?
--- checkpatch.pl.old 2008-01
On Mon, 14 Jan 2008, Mariusz Kozlowski wrote:
> Hello,
>
> > We are pleased to announce the 2.6.24-rc7-rt2 tree, which can be
> > downloaded from the location:
> >
> > http://rt.et.redhat.com/download/
>
> Compiles fine but I run into another problem. On startup kernel oopses
> early and this '
On Sun, Jan 13, 2008 at 09:01:08AM -0800, Arjan van de Ven wrote:
> would be nice the "reg > 256 && raw_pci_Ext_ops==NULL" case would just
> call the raw_pci_ops-> pointer, to give that a chance of refusal
> (but I guess that shouldn't really happen)
We don't have a situation where that can happen
On Mon, 14 Jan 2008 23:17:00 +0100 (CET) Andi Kleen wrote:
>
> And clarify description a bit.
>
> Only for 64bit, but the interfaces are identical for 32bit and kerneldoc
> should
> merge them (?)
I doubt that kernel-doc will merge them.
Normally we just import (like with !I, !E, !F, etc.) o
Andi Kleen wrote:
OK, I see the problem. The problem is that the _PAGE_X defines are
defined with _AC(UL, 1 << _PAGE_BIT_X), which has unsigned long type.
This means that ~_PAGE_X also has unsigned long type, and so when cast
to 64-bit in pte_mkX, it ends up &ing the pte with 0xff
Hi Ingo, thanks for the reply.
Modifying /proc/sys/kernel/sched_latency_ns to be double may have in
fact made things slightly worse. I used 24-rc7
Your script was only written to run for 15 seconds, so I ran it so it
multiple times so it covered most of the benchmark.
Other issues with these data
Quoting Miklos Szeredi ([EMAIL PROTECTED]):
> From: Miklos Szeredi <[EMAIL PROTECTED]>
>
> Allow bind mounts to unprivileged users if the following conditions are met:
>
> - mountpoint is not a symlink
> - parent mount is owned by the user
> - the number of user mounts is below the maximum
Tuomo Valkonen wrote:
On 2008-01-13 18:11 -0500, Theodore Tso wrote:
It's much more likely that this early in your boot cycle, your clock is
sometimes incorrect.
I doubt it. I get this nearly _always_ when the system crashes, which
accounts for the vast majority of the times I boot it. (I wish
> OK, I see the problem. The problem is that the _PAGE_X defines are
> defined with _AC(UL, 1 << _PAGE_BIT_X), which has unsigned long type.
> This means that ~_PAGE_X also has unsigned long type, and so when cast
> to 64-bit in pte_mkX, it ends up &ing the pte with 0xffxxx,
> wit
On Monday 14 January 2008, Bartlomiej Zolnierkiewicz wrote:
> On Sunday 13 January 2008, Borislav Petkov wrote:
> > ..and replace them with flag enums.
> >
> > Signed-off-by: Borislav Petkov <[EMAIL PROTECTED]>
small update:
PC_ABORT is never set and may as well be removed in a pre-patch
--
To u
- Rename it to pte_exec() from pte_exec_kernel(). There is nothing
kernel specific in there.
- Move it into the common file because _PAGE_NX is 0 on !PAE and then
pte_exec() will be always evaluate to true.
Signed-off-by: Andi Kleen <[EMAIL PROTECTED]>
---
arch/x86/mm/fault_32.c |
The boot direct mapping initialization used a different test to check if a
page was part of the kernel mapping than c_p_a(). Make them use
a common function.
Also round up to a large page size to be sure and check for the beginning
of the kernel address to handle highly loaded kernels better.
And clarify description a bit.
Only for 64bit, but the interfaces are identical for 32bit and kerneldoc should
merge them (?)
Signed-off-by: Andi Kleen <[EMAIL PROTECTED]>
---
Documentation/DocBook/kernel-api.tmpl |8 +
arch/x86/mm/pageattr_64.c | 46
On Jan 14 2008 22:29, Olaf Titz wrote:
>> 200Mb had been filled when it had been umounted from /mnt/bootf8
>> repartitioned, mke2fs'd, a journal added and a new label written and then
>> mounted to /amandatapes.
>>
>> Something it seems to me, should have forced the re-init, but didn't. So is
>
>
Various CPUs have errata when using INVLPG to flush large pages.
This includes Intel Penryn (AV2) and AMD K7 (#16 in Athlon 4)
While these happen only in specific circumstances it is still
a little risky and it's not clear the kernel can avoid them all.
Avoid this can of worms by always flushing
virt_to_page does not care about the bits below the page granuality.
So don't mask them.
Signed-off-by: Andi Kleen <[EMAIL PROTECTED]>
---
arch/x86/mm/pageattr_64.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux/arch/x86/mm/pageattr_64.c
=
No code changes.
Signed-off-by: Andi Kleen <[EMAIL PROTECTED]>
---
arch/x86/mm/pageattr_64.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Index: linux/arch/x86/mm/pageattr_64.c
===
--- linux.orig/arch/x86/mm/pageatt
Signed-off-by: Andi Kleen <[EMAIL PROTECTED]>
---
arch/x86/mm/pageattr_64.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux/arch/x86/mm/pageattr_64.c
===
--- linux.orig/arch/x86/mm/pageattr_64.c
+++ linux/arch
Queue individual data pages for flushing with CLFLUSH in change_page_attr(),
instead of doing global WBINVDs. WBINVD is a very painful operation
for the CPU (can take msecs) and quite slow too. Worse it is not interruptible
and can cause long latencies on hypervisors on older Intel VT systems.
On January 14, 2008, Ingo Molnar wrote:
>
> * Matthew <[EMAIL PROTECTED]> wrote:
>
> > > FYI, latest x86.git should have this fix included. So if your box
> > > still hangs there must be some other bug lurking as well.
> >
> >
> > the fix from Roland ?: http://lkml.org/lkml/2008/1/11/108
> > h
Since change_page_attr() is tricky code it is good to have some regression
test code. This patch maps and unmaps some random pages in the direct mapping
at boot and then dumps the state and does some simple sanity checks.
Add it with a CONFIG option.
Optional patch, but I find it useful.
Signed
Needed for the next change.
And change all the callers.
Signed-off-by: Andi Kleen <[EMAIL PROTECTED]>
---
arch/x86/mm/fault_32.c |3 ++-
arch/x86/mm/init_32.c|3 ++-
arch/x86/mm/pageattr_32.c|7 +--
arch/x86/mm/pageattr_64.c|7 +--
arch/x86/xen/mmu
Similar to x86-64. This is useful in other situations where we want
the page table dumped too.
Besides anything that makes i386 do_page_fault shorter is good.
Signed-off-by: Andi Kleen <[EMAIL PROTECTED]>
---
arch/x86/mm/fault_32.c | 72 ++---
1 fi
CONFIG_DEBUG_PAGEALLOC uses change_page_attr to map/unmap mappings for catching
stray kernel mappings. But standard c_p_a() does a lot of unnecessary work for
this simple case with pre-split mappings.
Change kernel_map_pages to just access the page table directly which
is simpler and faster.
I a
Now that debug pagealloc uses a separate function it is better
to change standard change_page_attr back to init_mm semaphore locking like
64bit.
Various things are simpler when sleeping is allowed.
Signed-off-by: Andi Kleen <[EMAIL PROTECTED]>
---
arch/x86/mm/pageattr_32.c | 14 +
Instead of open coding the bit accesses uses standard style
*PageDeferred* macros.
Signed-off-by: Andi Kleen <[EMAIL PROTECTED]>
---
arch/x86/mm/pageattr_32.c | 14 ++
arch/x86/mm/pageattr_64.c | 11 +--
2 files changed, 19 insertions(+), 6 deletions(-)
Index: linux/ar
With the infrastructure added for CLFLUSH it is possible
to only TLB flush the actually changed pages in change_page_attr()
Take care of old Athlon K7 Errata on the 32bit version
Signed-off-by: Andi Kleen <[EMAIL PROTECTED]>
---
arch/x86/mm/pageattr_32.c | 15 ---
arch/x86/mm/pag
With the separate data structure added for flush earlier it is only
needed to call save_page() now on pte pages that have been already reverted.
Also move all freeing checks into the caller.
Signed-off-by: Andi Kleen <[EMAIL PROTECTED]>
---
arch/x86/mm/pageattr_32.c |4 +---
arch/x86/mm/pa
Otherwise the kernel will likely always run with 4K pages instead of 2MB pages,
which is costly in terms of TLBs.
Also optimize it a little bit by using only a single change_page_attr() calls.
This is particularly useful if debugging is enabled inside it because it spams
the logs much less.
Sign
When changing a page that has already been modified to non standard attributes
before don't change the reference count. And when changing back a page
only decrease the ref count if the old attributes were non standard.
Signed-off-by: Andi Kleen <[EMAIL PROTECTED]>
---
arch/x86/mm/pageattr_32.c
Someone setting NX on the kernel text tends to result in nasty failures
and triple faults, so BUG_ON early for that.
Does not cover __inittext.
Signed-off-by: Andi Kleen <[EMAIL PROTECTED]>
---
arch/x86/mm/pageattr_32.c |8
1 file changed, 8 insertions(+)
Index: linux/arch/x86/mm
The SMP trampoline always runs in real mode, so making it executable
in the page tables doesn't make much sense because it executes
before page tables are set up. That was the only user of
set_kernel_exec(). Remove set_kernel_exec().
Signed-off-by: Andi Kleen <[EMAIL PROTECTED]>
---
arch/x86/k
301 - 400 of 509 matches
Mail list logo
