Re: [PATCH] x86: clean up apic_32/64.c

2008-01-02 Thread Hiroshi Shimamoto
Ingo Molnar wrote: > * Hiroshi Shimamoto <[EMAIL PROTECTED]> wrote: > >> White space and coding style clean up. Make apic_32/64.c similar. > > thanks, applied. FYI, there's still a bit left in apic_32.c: > > total: 5 errors, 1 warnings, 1566 lines checked > > we might as well go for all of the

[PATCH] ide: delete filenames/versions from comments

2008-01-02 Thread Bartlomiej Zolnierkiewicz
Delete filenames/versions from comments. I'm leaving decisions about adding DRV_VERSION defines and MODULE_VERSION()-s to maintainers of the respective drivers. While at it: * Remove unused VERSION define from ide.c. * Remove unused/stale DRV_VERSION define from au1xxx-ide.c. Signed-off-by: B

tty + BKL [Was: 2.6.24-rc6-mm1]

2008-01-02 Thread Jiri Slaby
On 01/02/2008 11:49 PM, Alan Cox wrote: > Almost all the serial drivers clone the same open and release methods (or > worse older versions of it) so that also needs doing. Lots to do, so > little time. Could you be more specific here please, maybe somebody could help. -- To unsubscribe from this l

Re: [patch] scsi: revert "[SCSI] Get rid of scsi_cmnd->done"

2008-01-02 Thread James Bottomley
On Wed, 2008-01-02 at 12:45 -0800, Linus Torvalds wrote: > > On Wed, 2 Jan 2008, James Bottomley wrote: > > > > OK ... I'll revert it. However, I still think it's the wrong course of > > action, because as far as my analysis goes, this code is functionally > > equivalent to what went before wit

Re: [patch 02/20] make the inode i_mmap_lock a reader/writer lock

2008-01-02 Thread Mike Travis
Hi Nick, Have you done anything more with allowing > 256 CPUS in this spinlock patch? We've been testing with 1k cpus and to verify with -mm kernel, we need to "unpatch" these spinlock changes. Thanks, Mike Nick Piggin wrote: > On Thursday 20 December 2007 18:04, Christoph Lameter wrote: >>> Th

Re: [PATCHv2] i2c: adds support for i2c bus on Frescale CPM1/CPM2 controllers

2008-01-02 Thread Stephen Rothwell
Hi Jochen, Just a few trivial things. On Wed, 02 Jan 2008 20:52:00 +0100 Jochen Friedrich <[EMAIL PROTECTED]> wrote: > > +++ b/drivers/i2c/busses/i2c-cpm.c > + > +static irqreturn_t cpm_i2c_interrupt(int irq, void *dev_id) > +{ > + struct i2c_adapter *adap; > + struct cpm_i2c *cpm; > +

Re: [Suspend2-devel] Reboot problem

2008-01-02 Thread Christian Hesse
On Wednesday 02 January 2008, Rafael J. Wysocki wrote: > On Wednesday, 2 of January 2008, Christian Hesse wrote: > > On Wednesday 02 January 2008, Nigel Cunningham wrote: > > > Hi Christian. > > > > > > Christian Hesse wrote: > > > > On Tuesday 01 January 2008, Nigel Cunningham wrote: > > > >> Thir

Re: + restore-missing-sysfs-max_cstate-attr.patch added to -mm tree

2008-01-02 Thread Mark Lord
Arjan van de Ven wrote: On Fri, 30 Nov 2007 22:31:17 -0500 Mark Lord <[EMAIL PROTECTED]> wrote: Arjan van de Ven wrote: On Fri, 30 Nov 2007 22:14:08 -0500 Mark Lord <[EMAIL PROTECTED]> wrote: in -mm there is.. the QoS stuff allows you to set maximum tolerable .. That's encouraging, I think

Re: forcedeth: MAC-address reversed on resume from suspend

2008-01-02 Thread Adrian Bunk
[ original bug report: http://lkml.org/lkml/2008/1/2/253 ] On Wed, Jan 02, 2008 at 10:48:43PM +0100, Andreas Mohr wrote: > Hi, > > On Wed, Jan 02, 2008 at 10:04:49PM +0100, Richard Jonsson wrote: > > Bugreport regarding forcedeth driver. > > > > When returning from suspend-to-RAM the MAC-address

Re: [PATCH 2/2] Markers Implementation for Preempt RCU Boost Tracing

2008-01-02 Thread Nicholas Miell
On Wed, 2008-01-02 at 11:33 -0500, Frank Ch. Eigler wrote: > Hi - > > On Wed, Jan 02, 2008 at 01:47:34PM +0100, Ingo Molnar wrote: > > [...] > > > FWIW, I'm not keen about the format strings either, but they don't > > > constitute a performance hit beyond an additional parameter. It does > > >

[PATCH] bw-qcam: Adds module parameter 'aggressive' to skip polite auto-detection prior to direct initialization.

2008-01-02 Thread Brett T. Warden
Setting aggressive=1 bypasses the friendly auto-detection by polling the status register, and instead attempts to initialize the qcam directly. Not friendly to other parallel devices, but much more reliable than the auto-detection. Signed-off-by: Brett T. Warden <[EMAIL PROTECTED]> --- drivers/

[PATCH] bw-qcam: Rename parameter 'aggressive' to 'force_init'

2008-01-02 Thread Brett T. Warden
Changed new parameter name to 'force_init' for clarity, as per feedback. Signed-off-by: Brett T. Warden <[EMAIL PROTECTED]> --- drivers/media/video/bw-qcam.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/media/video/bw-qcam.c b/drivers/media/video/bw-qcam

Re: [PATCH] bw-qcam: Rename parameter 'aggressive' to 'force_init'

2008-01-02 Thread Alan Cox
On Wed, 2 Jan 2008 15:51:25 -0800 "Brett T. Warden" <[EMAIL PROTECTED]> wrote: > Changed new parameter name to 'force_init' for clarity, as per feedback. > > Signed-off-by: Brett T. Warden <[EMAIL PROTECTED]> Acked-by: Alan Cox <[EMAIL PROTECTED]> -- To unsubscribe from this list: send the line

Re: why do we call clear_active_flags in shrink_inactive_list ?

2008-01-02 Thread Rik van Riel
On Sun, 30 Dec 2007 16:32:42 +0900 "minchan Kim" <[EMAIL PROTECTED]> wrote: > In 2.6.23's shrink_inactive_list function, why do we have to call > clear_active_flags after isolate_lru_pages call ? > IMHO, If it call isolate_lru_pages with "zone->inactive_list", It can > be sure that it is not PG_ac

[PATCH] x86: Clean up k8topology.c

2008-01-02 Thread Carlos R. Mafra
x86: Cleanup k8topology.c This patch fixes all errors pointed out by checkpatch.pl. errors lines of code errors/KLOC arch/x86/mm/k8topology_64.c (before) 72 185 389.1 arch/x86/mm/k8topology_64.c (after)0 185

Re: [PATCH] depmod: sort output according to modules.order, take #2

2008-01-02 Thread Jon Masters
On Thu, 2008-01-03 at 10:12 +1100, Rusty Russell wrote: > Oh, sorry. Jon is now module-init-tools maintainer, and I've cc'd him and > forwarded your original patch. Ta. I was semi-offline last week due to holidays, but already saw the original mail and have another fix for debug sections - will

RE: + restore-missing-sysfs-max_cstate-attr.patch added to -mm tree

2008-01-02 Thread Pallipadi, Venkatesh
>-Original Message- >From: Mark Lord [mailto:[EMAIL PROTECTED] >Sent: Wednesday, January 02, 2008 3:42 PM >To: Arjan van de Ven >Cc: Pallipadi, Venkatesh; Andrew Morton; [EMAIL PROTECTED]; >[EMAIL PROTECTED]; Ingo Molnar; linux-kernel@vger.kernel.org; >[EMAIL PROTECTED] >Subject: Re:

git-x86 broken on 32bit

2008-01-02 Thread Andi Kleen
Current git-x86 seems to be totally broken on i386 commit a6f08929f0566f9d309ef5f6651371d8e20fc833 Author: Russell Leidich <[EMAIL PROTECTED]> Date: Wed Jan 2 22:46:22 2008 +0100 x86: AMD Thermal Interrupt Support -- after you got it to compile with Signed-off-by: Andi Kleen <[EMAIL PR

Re: Why is deleting (or reading) files not counted as IO-Wait in top?

2008-01-02 Thread Maxim Levitsky
On Wednesday, 2 January 2008 21:35:03 Matthias Schniedermeyer wrote: > Hi > > > Currently i'm deleting about 500.000 files on a XFS-filesystem which > takes a few minutes, as i had a top open i saw that 'wa' is shown as > 0.0% (Nothing else running currently) and everything except 'id' is near

Re: sata_nv + ADMA + Samsung disk problem

2008-01-02 Thread Robert Hancock
Allen Martin wrote: The software definitely provides that guarantee for all NCQ-capable controllers. Well if that's not it, it must be some problem entering ADMA legacy mode. Here's what the Windows driver does: ADMACtrl.aGO = 0 ADMACtrl.aEIEN = 0 poll { until ADMAStatus.aLGCY = 1 || tim

Re: [PATCH] Provide u64 version of jiffies_to_usecs() in kernel/tsacct.c

2008-01-02 Thread Andrew Morton
On Fri, 28 Dec 2007 13:26:07 -0800 (PST) Jonathan Lim <[EMAIL PROTECTED]> wrote: > It's possible that the values used in and returned from jiffies_to_usecs() are > incorrect because of truncation when variables of type u64 are involved. So a > function specific to that type is used instead. > >

Re: SATA kernel-buffered read VERY slow (not raid, Promise TX300 card); 2.6.23.1(vanilla)

2008-01-02 Thread Robert Hancock
Linda Walsh wrote: Alan Cox wrote: rate began falling; at 128k block-reads-at-a-time or larger, it drops below 20MB/s (only on buffered SATA). Try disabling NCQ - see if you've got a drive with the 'NCQ = no readahead' flaw. --- I'm not aware, off hand, how to disable NCQ. I haven't had a

Re: sata_nv + ADMA + Samsung disk problem

2008-01-02 Thread Robert Hancock
Tejun Heo wrote: Robert Hancock wrote: Jeff Garzik wrote: Tejun Heo wrote: Thanks a lot for the detailed explanation. Nvidia ppl, any ideas? FLUSH is used regularly. We really need to fix this. I reiterate my opinion :) ... We should remove ADMA support from sata_nv. It's only in a few

Re: [PATCH] Provide u64 version of jiffies_to_usecs() in kernel/tsacct.c

2008-01-02 Thread H. Peter Anvin
Andrew Morton wrote: On Fri, 28 Dec 2007 13:26:07 -0800 (PST) Jonathan Lim <[EMAIL PROTECTED]> wrote: It's possible that the values used in and returned from jiffies_to_usecs() are incorrect because of truncation when variables of type u64 are involved. So a function specific to that type is u

Re: PATCH] adding wistron_btns support for X86_64 systems.

2008-01-02 Thread Rémi Hérilier
Carlos Corbacho wrote: > (CC'ing linux-input, as that is the relevant subsystem list for wistron-btns). > > Rémi Hérilier wrote: >> To use my previous patch (wistron_btns support for fujitsu-siemens amilo >> pro edition v3505) with my laptop, I need to make the wistron module >> compile for x86_64

Re: [PATCH] ide: delete filenames/versions from comments

2008-01-02 Thread Robert Hancock
Bartlomiej Zolnierkiewicz wrote: Delete filenames/versions from comments. I'm leaving decisions about adding DRV_VERSION defines and MODULE_VERSION()-s to maintainers of the respective drivers. While at it: * Remove unused VERSION define from ide.c. * Remove unused/stale DRV_VERSION define fr

[PATCH] fix the sysfs_add_file_to_group interfaces

2008-01-02 Thread James Bottomley
I can't see a reason why these shouldn't work on every group. However, they only seem to work on named groups. This patch allows the group functions to work on anonymous groups (those with NULL names). Signed-off-by: James Bottomley <[EMAIL PROTECTED]> --- Again, this is something that's neede

[PATCH] attribute_container: update to use the group interface

2008-01-02 Thread James Bottomley
This patch is the beginning of moving the attribute_containers to use attribute groups exclusively. The attr element is now deprecated and will eventually be removed (along with all the hand rolled code for doing exactly what attribute groups do) when all the consumers are converted to attribute g

[PATCH] [1/20] x86: Make ptrace.h safe to include from assembler code

2008-01-02 Thread Andi Kleen
Signed-off-by: Andi Kleen <[EMAIL PROTECTED]> --- include/asm-x86/ptrace-abi.h |2 ++ 1 file changed, 2 insertions(+) Index: linux/include/asm-x86/ptrace-abi.h === --- linux.orig/include/asm-x86/ptrace-abi.h +++ linux/include/a

[PATCH] [2/20] x86: Implement support to synchronize RDTSC through MFENCE on AMD CPUs

2008-01-02 Thread Andi Kleen
According to AMD RDTSC can be synchronized through MFENCE. Implement the necessary CPUID bit for that. Cc: [EMAIL PROTECTED] Signed-off-by: Andi Kleen <[EMAIL PROTECTED]> --- arch/x86/kernel/cpu/amd.c|3 +++ arch/x86/kernel/setup_64.c |4 ++-- include/asm-x86/cpufeature.h |1

[PATCH] [3/20] x86: Implement support to synchronize RDTSC with LFENCE on Intel CPUs

2008-01-02 Thread Andi Kleen
According to Intel RDTSC can be always synchronized with LFENCE on all current CPUs. Implement the necessary CPUID bit for that. It is unclear yet if that is true for all future CPUs too, but if there's another way the kernel can be always updated. Cc: [EMAIL PROTECTED] Signed-off-by: Andi Klee

[PATCH] [4/20] x86: Move nop declarations into separate include file

2008-01-02 Thread Andi Kleen
Moving things out of processor.h is always a good thing. Also needed to avoid include loop in later patch. Signed-off-by: Andi Kleen <[EMAIL PROTECTED]> --- include/asm-x86/nops.h | 90 include/asm-x86/processor.h | 86 -

[PATCH] [5/20] x86: Introduce nsec_barrier()

2008-01-02 Thread Andi Kleen
nsec_barrier() is a new barrier primitive that stops RDTSC speculation to avoid races with timer interrupts on other CPUs. Add it to all architectures. Except for x86 it is a nop right now. I only tested x86, but it's a very simple change. On x86 it expands either to LFENCE (for Intel CPUs) or M

[PATCH] [6/20] x86: Remove get_cycles_sync

2008-01-02 Thread Andi Kleen
And replace with nsec_barrier() as needed which has the same effect of preventing unnecessary speculation around RDTSC. For the standard gtod() like calls the previous patch already added the necessary barriers Signed-off-by: Andi Kleen <[EMAIL PROTECTED]> --- arch/x86/kernel/time_64.c |

[PATCH] [7/20] x86: Remove the now unused X86_FEATURE_SYNC_RDTSC

2008-01-02 Thread Andi Kleen
Signed-off-by: Andi Kleen <[EMAIL PROTECTED]> --- include/asm-x86/cpufeature.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux/include/asm-x86/cpufeature.h === --- linux.orig/include/asm-x86/cpufeature.h +++ li

[PATCH] [8/20] x86: Make TIF_MCE_NOTIFY optional

2008-01-02 Thread Andi Kleen
So that we don't have to implement it on 32bit. I would actually like to remove it on 64bit too. Signed-off-by: Andi Kleen <[EMAIL PROTECTED]> --- arch/x86/Kconfig|5 + arch/x86/kernel/cpu/mcheck/mce_64.c | 16 ++-- 2 files changed, 19 insertions(+),

[PATCH] [9/20] x86: Don't use oops_begin in 64bit mce code

2008-01-02 Thread Andi Kleen
It is not really useful to lock machine checks against oopses. And machine checks normally don't nest, so they don't need their own locking. Just call bust_spinlock/console_verbose directly. Signed-off-by: Andi Kleen <[EMAIL PROTECTED]> --- arch/x86/kernel/cpu/mcheck/mce_64.c |3 ++- 1 fil

[PATCH] [10/20] i386: Move MWAIT idle check to generic CPU initialization

2008-01-02 Thread Andi Kleen
Previously it was only run for Intel CPUs, but AMD Fam10h implements MWAIT too. This matches 64bit behaviour. Signed-off-by: Andi Kleen <[EMAIL PROTECTED]> --- arch/x86/kernel/cpu/common.c |2 ++ arch/x86/kernel/cpu/intel.c |1 - 2 files changed, 2 insertions(+), 1 deletion(-) Index:

[PATCH] [11/20] x86: Use the correct cpuid method to detect MWAIT support for C states

2008-01-02 Thread Andi Kleen
Previously there was a AMD specific quirk to handle the case of AMD Fam10h MWAIT not supporting any C states. But it turns out that CPUID already has ways to detectly detect that without using special quirks. The new code simply checks if MWAIT supports at least C1 and doesn't use it if it doesn

[PATCH] [12/20] x86: Use a per cpu timer for correctable machine check checking

2008-01-02 Thread Andi Kleen
Previously the code used a single timer that then used smp_call_function to interrupt all CPUs while the original CPU was waiting for them. But it is better / more real time and more power friendly to simply run individual timers on each CPU so they all do this independently. This way no singl

[PATCH] [13/20] x86: Use a deferrable timer for the correctable machine check poller

2008-01-02 Thread Andi Kleen
They are not time critical and delaying them a little for the next regular wakeup is no problem. Also when a CPU is idle then it is unlikely to generate errors anyways, so it is ok to check only when the CPU is actually doing something. Signed-off-by: Andi Kleen <[EMAIL PROTECTED]> --- arch/x8

[PATCH] [14/20] x86: Add per cpu counters for machine check polls / machine check events

2008-01-02 Thread Andi Kleen
.. and report them in /proc/interrupts Signed-off-by: Andi Kleen <[EMAIL PROTECTED]> --- arch/x86/kernel/cpu/mcheck/mce_64.c |6 ++ arch/x86/kernel/irq_32.c| 10 ++ arch/x86/kernel/irq_64.c|9 + include/asm-x86/mce.h |3 +++

[PATCH] [15/20] x86: Move X86_FEATURE_CONSTANT_TSC into early cpu feature detection

2008-01-02 Thread Andi Kleen
Need this in the next patch in time_init and that happens early. This includes a minor fix on i386 where early_intel_workarounds() [which is now called early_init_intel] really executes early as the comments say. Signed-off-by: Andi Kleen <[EMAIL PROTECTED]> --- arch/x86/kernel/cpu/amd.c|

[PATCH] [16/20] x86: Allow TSC clock source on AMD Fam10h and some cleanup

2008-01-02 Thread Andi Kleen
After a lot of discussions with AMD it turns out that TSC on Fam10h CPUs is synchronized when the CONSTANT_TSC cpuid bit is set. Or rather that if there are ever systems where that is not true it would be their BIOS' task to disable the bit. So finally use TSC gettimeofday on Fam10h by default.

[PATCH] [17/20] x86: Remove explicit C3 TSC check on 64bit

2008-01-02 Thread Andi Kleen
Trust the ACPI code to disable TSC instead when C3 is used. AMD Fam10h does not disable TSC in any C states so the check was incorrect there anyways after the change to handle this like Intel on AMD too. This allows to use the TSC when C3 is disabled in software (acpi.max_c_state=2), but the BIO

[PATCH] [18/20] x86: Don't disable TSC in any C states on AMD Fam10h

2008-01-02 Thread Andi Kleen
The ACPI code currently disables TSC use in any C2 and C3 states. But the AMD Fam10h BKDG documents that the TSC will never stop in any C states when the CONSTANT_TSC bit is set. Make this disabling conditional on CONSTANT_TSC not set on AMD. I actually think this is true on Intel too for C2 st

[PATCH] [19/20] x86: Use shorter addresses in i386 segfault printks

2008-01-02 Thread Andi Kleen
Signed-off-by: Andi Kleen <[EMAIL PROTECTED]> --- arch/x86/mm/fault_32.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux/arch/x86/mm/fault_32.c === --- linux.orig/arch/x86/mm/fault_32.c +++ linux/arch/x86/mm/f

[PATCH] [20/20] x86: Print which shared library/executable faulted in segfault etc. messages

2008-01-02 Thread Andi Kleen
They now look like hal-resmgr[13791]: segfault at 3c rip 2b9c8caec182 rsp 7fff1e825d30 error 4 in libacl.so.1.1.0[2b9c8caea000+6000] This makes it easier to pinpoint bugs to specific libraries. And printing the offset into a mapping also always allows to find the correct fault point in a lib

[PATCH] pda-power: only register available psu

2008-01-02 Thread Dmitry Baryshkov
Currently pda-power adds both ac and usb power supply units. This patch fixes it so that psu are added only if they are enabled. Signed-off-by: Dmitry Baryshkov <[EMAIL PROTECTED]> diff --git a/drivers/power/pda_power.c b/drivers/power/pda_power.c index c058f28..42eac09 100644 --- a/drivers/power

Re: + restore-missing-sysfs-max_cstate-attr.patch added to -mm tree

2008-01-02 Thread Andrew Morton
On Wed, 2 Jan 2008 16:06:20 -0800 "Pallipadi, Venkatesh" <[EMAIL PROTECTED]> wrote: > > > >-Original Message- > >From: Mark Lord [mailto:[EMAIL PROTECTED] > >Sent: Wednesday, January 02, 2008 3:42 PM > >To: Arjan van de Ven > >Cc: Pallipadi, Venkatesh; Andrew Morton; [EMAIL PROTECTED]

Make checkpatch.pl's quiet option not print the summary on no errors

2008-01-02 Thread Arjan van de Ven
Subject: Make checkpatch.pl's quiet option not print the summary on no errors From: Arjan van de Ven <[EMAIL PROTECTED]> CC: [EMAIL PROTECTED] Right now, in quiet mode, checkpatch.pl still prints a summary line even if the patch is 100% clean. IMO, "quiet mode" should mean "no output if clean", t

Re: [PATCH -mm] EFI : Split EFI tables parsing code from EFI runtime service support code

2008-01-02 Thread Huang, Ying
On Sun, 2007-12-30 at 15:28 +0100, Ingo Molnar wrote: > * Huang, Ying <[EMAIL PROTECTED]> wrote: > > > +struct efi_tables efi_tables; > > +EXPORT_SYMBOL(efi_tables); > > > +enum bios_type bios_type = BIOS_LEGACY; > > +EXPORT_SYMBOL(bios_type); > > please make all the new exports EXPORT_SYMBOL_GP

[patch 1/3] move WARN_ON() out of line

2008-01-02 Thread Arjan van de Ven
Subject: move WARN_ON() out of line From: Arjan van de Ven <[EMAIL PROTECTED]> CC: Ingo Molnar <[EMAIL PROTECTED]> CC: Andrew Morton <[EMAIL PROTECTED]> A quick grep shows that there are currently 1145 instances of WARN_ON in the kernel. Currently, WARN_ON is pretty much entirely inlined, which m

[patch 2/3] Add the end-of-trace marker and the module list to WARN_ON()

2008-01-02 Thread Arjan van de Ven
Subject: Add the end-of-trace marker and the module list to WARN_ON() From: Arjan van de Ven <[EMAIL PROTECTED]> CC: Ingo Molnar <[EMAIL PROTECTED]> CC: Andrew Morton <[EMAIL PROTECTED]> Unlike oopses, WARN_ON() currently does't print the loaded modules list. This makes it harder to take action o

Re: [PATCH 01/12] Use mutex instead of semaphore in driver core

2008-01-02 Thread Dave Young
On Jan 3, 2008 12:08 AM, Alan Stern <[EMAIL PROTECTED]> wrote: > On Tue, 1 Jan 2008, Greg KH wrote: > > > For most cases, yes, I agree with this, but due to the lockdep issues > > that occur here, and the whole mess with the suspend path and locking > > the device tree, that has been hashed out man

[patch 3/3] consolidate oops end/ID printing code in panic.c

2008-01-02 Thread Arjan van de Ven
Subject: consolidate oops end/ID printing code in panic.c From: Arjan van de Ven <[EMAIL PROTECTED]> CC: Ingo Molnar <[EMAIL PROTECTED]> CC: Andrew Morton <[EMAIL PROTECTED]> This patch consolidates the 2 places that print an oops end marker and ID into a single function; this patch follows the W

Re: [PATCH] Provide u64 version of jiffies_to_usecs() in kernel/tsacct.c

2008-01-02 Thread Jonathan Lim
On Wed Jan 2 16:36:47 2008, [EMAIL PROTECTED] wrote: > > Andrew Morton wrote: > > On Fri, 28 Dec 2007 13:26:07 -0800 (PST) Jonathan Lim <[EMAIL PROTECTED]> > > wrote: > > > >> It's possible that the values used in and returned from jiffies_to_usecs() > >> are incorrect because of truncation whe

[PATCH] x86: fault_{32|64}.c unify do_page_fault

2008-01-02 Thread Harvey Harrison
Begin to unify do_page_fault(), easy code movement first. Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- Ingo, similar to the kprobes unification patches I did, it gets a bit uglier before it gets better ;-) arch/x86/mm/fault_32.c | 38 +- arch/x86/m

[PATCH] x86: Use is_kprobe_fault to better match usage

2008-01-02 Thread Harvey Harrison
Currently the notify_page_fault helper is used to test it the page fault was caused by a kprobe causing an early return from do_page_fault. Change the name of the helper to is_kprobe_fault to match the usage and remove the preempt_disable/enable pair around kprobe_running() with an explicit test f

[ANNOUNCE] ebizzy 0.3 released

2008-01-02 Thread Rodrigo Rubira Branco (BSDaemon)
ebizzy is designed to generate a workload resembling common web application server workloads. It is especially useful for testing changes to memory management, and whenever a highly threaded application with a large working set and many vmas is needed. This is release 0.3 of ebizzy. It reports a

RE: + restore-missing-sysfs-max_cstate-attr.patch added to -mm tree

2008-01-02 Thread Pallipadi, Venkatesh
>-Original Message- >From: Andrew Morton [mailto:[EMAIL PROTECTED] >Sent: Wednesday, January 02, 2008 4:52 PM >To: Pallipadi, Venkatesh >Cc: Mark Lord; Arjan van de Ven; [EMAIL PROTECTED]; >[EMAIL PROTECTED]; Ingo Molnar; linux-kernel@vger.kernel.org; >[EMAIL PROTECTED] >Subject: Re:

Re: [PATCH] Provide u64 version of jiffies_to_usecs() in kernel/tsacct.c

2008-01-02 Thread H. Peter Anvin
Jonathan Lim wrote: Peter, Would you be willing to include the u64 function as part of your patch to make it available kernel-wide? It just needs: u64 inline jiffies_to_usecs_u64(const u64 j) and for the symbol to be exported. Thanks. It should be a separate patch (new functionality ve

Re: Linux 2.6.23.12

2008-01-02 Thread Shaohua Li
On Wed, 2008-01-02 at 13:42 -0700, Bjorn Helgaas wrote: > The patch below was put in 2.6.23.12 as a fix for > http://bugzilla.kernel.org/show_bug.cgi?id=9514. It apparently > does make 9514 go away, but only by coincidence. There are a > couple other ideas about fixing 9514. My proposed patch i

[PATCH] x86_64: not clear empty_zero_page again

2008-01-02 Thread Yinghai Lu
[PATCH] x86_64: not clear empty_zero_page again empty_zero_page is in .bss section, and it is cleared in clear_bss by x86_64_start_kernel. So don't clear that again in mem_init Signed-off-by: Yinghai Lu <[EMAIL PROTECTED]> Index: linux-2.6/arch/x86/mm/init_64.c =

Re: [PATCH] x86: fault_{32|64}.c unify do_page_fault

2008-01-02 Thread Alexey Dobriyan
On Wed, Jan 02, 2008 at 05:01:02PM -0800, Harvey Harrison wrote: > Begin to unify do_page_fault(), easy code movement first. > > Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> > --- > Ingo, similar to the kprobes unification patches I did, it gets a bit > uglier before it gets better ;-) > >

Re: [PATCH] Exporting capability code/name pairs

2008-01-02 Thread Andrew Morgan
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 There is also the issue of compiled code which explicitly raises and lowers capabilities around critical code sections (ie., as they were intended to be used) is also not well served by this change. That is, unless the code was compiled with things li

[GIT PATCH] SCSI bug fix for 2.6.24-rc6

2008-01-02 Thread James Bottomley
This is the bug fix for http://bugzilla.kernel.org/show_bug.cgi?id=9674 It's available here: master.kernel.org:/pub/scm/linux/kernel/git/jejb/scsi-rc-fixes-2.6.git I've just attached it below as well. James --- >From 751bf4d7865e4ced406be93b04c7436d866d3684 Mon Sep 17 00:00:00 2001 From: Jam

Re: [patch] scsi: revert "[SCSI] Get rid of scsi_cmnd->done"

2008-01-02 Thread Linus Torvalds
On Wed, 2 Jan 2008, James Bottomley wrote: > > > > To say that another way: > > > > "the code is functionally equivalent, EXCEPT IT ISN'T, and it's > > known to be broken". > > > > wouldn't you say my version is more honest and correct? > > No. Just because a bug appears when a particula

Re: [patch 1/3] move WARN_ON() out of line

2008-01-02 Thread Matt Mackall
On Thu, 2008-01-03 at 01:56 +0100, Arjan van de Ven wrote: > Subject: move WARN_ON() out of line > From: Arjan van de Ven <[EMAIL PROTECTED]> > CC: Ingo Molnar <[EMAIL PROTECTED]> > CC: Andrew Morton <[EMAIL PROTECTED]> > > A quick grep shows that there are currently 1145 instances of WARN_ON > i

Re: [PATCH linux-acpi] Correct wakeup set error and append a new column PCI ID

2008-01-02 Thread Yi Yang
On Wed, 2008-01-02 at 17:09 +0100, Pavel Machek wrote: > On Wed 2008-01-02 10:03:59, Yi Yang wrote: > > On Wed, 2008-01-02 at 00:20 +0100, Pavel Machek wrote: > > > Hi! > > > > > > > /proc/acpi/wakeup is also case-sensitive, case-insensitive is better. > > > > > > Why? > > A user uses device bus

Re: [PATCH] x86: fault_{32|64}.c unify do_page_fault

2008-01-02 Thread Harvey Harrison
On Thu, 2008-01-03 at 04:45 +0300, Alexey Dobriyan wrote: > On Wed, Jan 02, 2008 at 05:01:02PM -0800, Harvey Harrison wrote: > > Begin to unify do_page_fault(), easy code movement first. > > > > Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> > > --- > > Ingo, similar to the kprobes unification

Re: [PATCH linux-acpi] Correct wakeup set error and append a new column PCI ID

2008-01-02 Thread Yi Yang
On Wed, 2008-01-02 at 17:09 +0100, Pavel Machek wrote: > On Wed 2008-01-02 10:03:59, Yi Yang wrote: > > On Wed, 2008-01-02 at 00:20 +0100, Pavel Machek wrote: > > > Hi! > > > > > > > /proc/acpi/wakeup is also case-sensitive, case-insensitive is better. > > > > > > Why? > > A user uses device bus

Re: [patch] powerpc systbl.h broken

2008-01-02 Thread Stephen Rothwell
Hi Clifford, Thanks for the report. PowerPC problems should be reported to [EMAIL PROTECTED] This has been fixed in the current (approaching 2.6.24) kernel. It should be fixed in 2.6.23.xx, so I have cc'd this to [EMAIL PROTECTED] (and linuxppc-dev, of course). (Also, please post patches inlin

[PATCHv2] x86: fault_{32|64}.c unify do_page_fault

2008-01-02 Thread Harvey Harrison
Begin to unify do_page_fault(), easy code movement first. Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- Ingo, Alexey Dobriyan noticed an obvious typo CONFIG_x86_64 in the previous version, this is a fixed patch. arch/x86/mm/fault_32.c | 38 +- arch/

Re: [PATCH] x86: fault_{32|64}.c unify do_page_fault

2008-01-02 Thread H. Peter Anvin
Harvey Harrison wrote: There is no such thing as CONFIG_x86_64 . My apologies, testing/compiling on X86_32 here. Please also compile for x86-64, even if you can't easily test it (although you can always boot under qemu, even if it's slow.) Unification patches especially. -hpa -- T

Re: [PATCH] x86: Use is_kprobe_fault to better match usage

2008-01-02 Thread Masami Hiramatsu
Hi Harvey, Harvey Harrison wrote: > Currently the notify_page_fault helper is used to test it the page > fault was caused by a kprobe causing an early return from do_page_fault. > > Change the name of the helper to is_kprobe_fault to match the usage and > remove the preempt_disable/enable pair ar

Re: [patch] powerpc systbl.h broken

2008-01-02 Thread Stephen Rothwell
On Thu, 3 Jan 2008 13:16:24 +1100 Stephen Rothwell <[EMAIL PROTECTED]> wrote: > > This has been fixed in the current (approaching 2.6.24) kernel. It > should be fixed in 2.6.23.xx, so I have cc'd this to > [EMAIL PROTECTED] (and linuxppc-dev, of course). Should have been [EMAIL PROTECTED] (where

Re: [PATCH] x86: Use is_kprobe_fault to better match usage

2008-01-02 Thread Harvey Harrison
On Wed, 2008-01-02 at 21:36 -0500, Masami Hiramatsu wrote: > Hi Harvey, > > Harvey Harrison wrote: > > Currently the notify_page_fault helper is used to test it the page > > fault was caused by a kprobe causing an early return from do_page_fault. > > > > Change the name of the helper to is_kprobe

Re: [linux-usb-devel] [PATCH] : Allow embedded developers USB options normally reserved for OTG

2008-01-02 Thread Robin Getz
On Wed 2 Jan 2008 13:47, David Brownell pondered: > On Wednesday 02 January 2008, Robin Getz wrote: > > From: Robin Getz <[EMAIL PROTECTED]> > > > > Allow embedded developers to turn support for USB Hubs off even if > > they have a full root hub. This saves the overhead (RAM and Flash size). > >

[GIT] More NFS client fixes for 2.6.24-rc6

2008-01-02 Thread Trond Myklebust
Hi Linus, Please pull from the repository at git pull git://git.linux-nfs.org/pub/linux/nfs-2.6.git This will update the following files through the appended changesets. Cheers, Trond fs/nfs/nfs4proc.c | 34 -- fs/nfs/nfs4renewd.c

Re: [PATCH] x86: Use is_kprobe_fault to better match usage

2008-01-02 Thread Masami Hiramatsu
Harvey Harrison wrote: > On Wed, 2008-01-02 at 21:36 -0500, Masami Hiramatsu wrote: >> Hi Harvey, >> >> Harvey Harrison wrote: >>> Currently the notify_page_fault helper is used to test it the page >>> fault was caused by a kprobe causing an early return from do_page_fault. >>> >>> Change the name

Re: [linux-usb-devel] [PATCH] : Allow embedded developers USB options normally reserved for OTG

2008-01-02 Thread Bryan Wu
On Jan 3, 2008 2:47 AM, David Brownell <[EMAIL PROTECTED]> wrote: > On Wednesday 02 January 2008, Robin Getz wrote: > > From: Robin Getz <[EMAIL PROTECTED]> > > > > Allow embedded developers to turn support for USB Hubs off even if they > > have a > > full root hub. This saves the overhead (RAM an

Re: [linux-usb-devel] [PATCH] : Allow embedded developers USB options normally reserved for OTG

2008-01-02 Thread David Brownell
On Wednesday 02 January 2008, Robin Getz wrote: > On Wed 2 Jan 2008 13:47, David Brownell pondered: > > On Wednesday 02 January 2008, Robin Getz wrote: > > > From: Robin Getz <[EMAIL PROTECTED]> > > > > > > Allow embedded developers to turn support for USB Hubs off even if > > > they have a full r

Re: [linux-usb-devel] [PATCH] : Allow embedded developers USB options normally reserved for OTG

2008-01-02 Thread David Brownell
On Wednesday 02 January 2008, Alan Stern wrote: > > > The transaction translators in external high speed hubs require > > hosts to issue particular USB transactions.  If the host controller > > doesn't implement the that split transaction support, then it won't > > be supporting external hubs. >

Re: [PATCH] x86: fault_{32|64}.c unify do_page_fault

2008-01-02 Thread H. Peter Anvin
Harvey Harrison wrote: My apologies, testing/compiling on X86_32 here. Do you seriously think code is getting better and more readable because of this liberal #ifdef sprinkling in every possible direction? Well, this of course is not the end of the road, but it makes it obvious where the di

Re: [linux-usb-devel] [PATCH] : Allow embedded developers USB options normally reserved for OTG

2008-01-02 Thread Bryan Wu
On Jan 3, 2008 4:58 AM, Alan Stern <[EMAIL PROTECTED]> wrote: > On Wed, 2 Jan 2008, David Brownell wrote: > > > On Wednesday 02 January 2008, Alan Stern wrote: > > > On Wed, 2 Jan 2008, Mike Frysinger wrote: > > > > > > > perhaps the code size is arguable as to whether it really matters. > > > > th

FW: [PATCH -rt] Preemption problem in kernel RT Patch

2008-01-02 Thread mbeauch
Here's the updated patch: Changed the real-time patch code to detect recursive calls to dev_queue_xmit and drop the packet when detected. Signed-off-by: Mark Beauchemin <[EMAIL PROTECTED]> diff -ru linux-2.6.24-rc5-rt1/include/linux/netdevice.h linux-2.6.24-rc5-rt1-mark/include/linux/netde

Re: [PATCH] track number of mnts writing to superblocks

2008-01-02 Thread Serge E. Hallyn
Quoting Dave Hansen ([EMAIL PROTECTED]): > > One of the benefits of the r/o bind mount patches is that they > make it explicit when a write to a superblock might occur. > We currently search sb->s_files when remounting rw->ro to look > for writable files. But, that search is not comprehensive, an

[PATCH] kprobes: Introduce is_kprobe_fault()

2008-01-02 Thread Harvey Harrison
Use a central is_kprobe_fault() inline in kprobes.h to remove all of the arch-dependant, practically identical implementations in avr32, ia64, powerpc, s390, sparc64, and x86. avr32 was the only arch without the preempt_disable/enable pair in its notify_page_fault implementation. This should be c

Re: sata_nv + ADMA + Samsung disk problem

2008-01-02 Thread Mark Lord
Robert Hancock wrote: What we're doing to enter legacy mode is essentially: -wait until ADMA status indicates IDLE bit set (max wait of 1 microsecond) -clear GO bit in control register -wait until status indicates LEGACY bit set (max wait of 1 microsecond) and to enter ADMA mode: -set GO bit

Re: 2.6.22-stable causes oomkiller to be invoked

2008-01-02 Thread Dhaval Giani
On Thu, Jan 03, 2008 at 09:29:42AM +0530, Dhaval Giani wrote: > On Wed, Jan 02, 2008 at 01:54:12PM -0800, Christoph Lameter wrote: > > Just traced it again on my system: It is okay for the number of pages on > > the quicklist to reach the high count that we see (although the 16 bit > > limits are

Re: sata_nv + ADMA + Samsung disk problem

2008-01-02 Thread Mark Lord
Robert Hancock wrote: .. From some of the traces I took previously (posted on LKML as "sata_nv ADMA controller lockup investigation" way back in Feb 07), what seems to occur is that when the second command is issued very rapidly (within less than 20 microseconds, or potentially longer) after t

Re: + restore-missing-sysfs-max_cstate-attr.patch added to -mm tree

2008-01-02 Thread Mark Lord
Pallipadi, Venkatesh wrote: -Original Message- From: Mark Lord [mailto:[EMAIL PROTECTED] Sent: Wednesday, January 02, 2008 3:42 PM To: Arjan van de Ven Cc: Pallipadi, Venkatesh; Andrew Morton; [EMAIL PROTECTED]; [EMAIL PROTECTED]; Ingo Molnar; linux-kernel@vger.kernel.org; [EMAIL P

Re: + restore-missing-sysfs-max_cstate-attr.patch added to -mm tree

2008-01-02 Thread Mark Lord
Pallipadi, Venkatesh wrote: -Original Message- From: Andrew Morton [mailto:[EMAIL PROTECTED] Sent: Wednesday, January 02, 2008 4:52 PM To: Pallipadi, Venkatesh Cc: Mark Lord; Arjan van de Ven; [EMAIL PROTECTED]; [EMAIL PROTECTED]; Ingo Molnar; linux-kernel@vger.kernel.org; [EMAIL P

Re: SATA kernel-buffered read VERY slow (not raid, Promise TX300 card); 2.6.23.1(vanilla)

2008-01-02 Thread Linda Walsh
Robert Hancock wrote: Linda Walsh wrote: Alan Cox wrote: rate began falling; at 128k block-reads-at-a-time or larger, it drops below 20MB/s (only on buffered SATA). Try disabling NCQ - see if you've got a drive with the 'NCQ = no readahead' flaw. http://linux-ata.org/faq.html#ncq --- Whe

Re: 2.6.22-stable causes oomkiller to be invoked

2008-01-02 Thread Dhaval Giani
On Wed, Jan 02, 2008 at 01:54:12PM -0800, Christoph Lameter wrote: > Just traced it again on my system: It is okay for the number of pages on > the quicklist to reach the high count that we see (although the 16 bit > limits are weird. You have around 4GB of memory in the system?). Up to > 1/16th

Re: [Patch 0/8] Remove 'TOPDIR' from Makefiles

2008-01-02 Thread WANG Cong
>Hi Wang. > >You a heads up. I will most likely apply >the remaining of the patches tonight, except the UM stuff >which I hope Jeff to take and the final removal of TOPDIR >may wait a bit. >I want the s390, xfs and um changes to hit -mm at least >and we have several external modules that uses TOPD

Re: [linux-usb-devel] [PATCH] : Allow embedded developers USB options normally reserved for OTG

2008-01-02 Thread Bryan Wu
On Jan 3, 2008 11:43 AM, David Brownell <[EMAIL PROTECTED]> wrote: > On Wednesday 02 January 2008, Robin Getz wrote: > > On Wed 2 Jan 2008 13:47, David Brownell pondered: > > > On Wednesday 02 January 2008, Robin Getz wrote: > > > > From: Robin Getz <[EMAIL PROTECTED]> > > > > > > > > Allow embedde

Re: [patch 1/3] move WARN_ON() out of line

2008-01-02 Thread Olof Johansson
On Thu, Jan 03, 2008 at 01:56:58AM +0100, Arjan van de Ven wrote: > Subject: move WARN_ON() out of line > From: Arjan van de Ven <[EMAIL PROTECTED]> > CC: Ingo Molnar <[EMAIL PROTECTED]> > CC: Andrew Morton <[EMAIL PROTECTED]> > > A quick grep shows that there are currently 1145 instances of WARN_O

Re: [PATCH] kprobes: Introduce is_kprobe_fault()

2008-01-02 Thread Masami Hiramatsu
Hi Harvey, Thank you for greate work! This seems including all of what I've expected. I'll try to test. Please send this to all of kprobe maintainers, Because this involves all of the architectures which kprobes supports. Maintainers; could you help reviewing this? Thank you, Best Regards, Ha

<    1   2   3   4   5   >