Re: [RFC 12/13] Char: nozomi, remove void acc char2 char3 more mp mp.c mp.yy m1 nozomi2 proto rej slock1 casts

2007-11-10 Thread Frank Seidel
On Samstag 10 November 2007 00:50:53, you (Jiri Slaby) wrote: > nozomi, remove void * casts Yes, they are of course pointless. Applied your patch without changes. Thanks, Frank - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED]

Re: [RFC 13/13] Char: nozomi, cleanup read and write

2007-11-10 Thread Frank Seidel
On Samstag 10 November 2007 00:51:33, you (Jiri Slaby) wrote: > nozomi, cleanup read and write > > - remove macros testing for endianness, le*_to_cpu and complements will do > it > - pointers cleanup (no need to have different pointers for be and le) > - put unlikely into reading/writing while l

Re: [RFC 4/13] Char: nozomi, tty index cleanup

2007-11-10 Thread Jiri Slaby
On 11/10/2007 04:41 PM, Frank Seidel wrote: > On Samstag 10 November 2007 00:45:30, you (Jiri Slaby) wrote: >> nozomi, tty index cleanup >> >> - don't store unneeded copy of tty->index into port structure, tty->index >> is available everywhere >> - mod tty->index by MAX_PORT where expected (other

Re: nozomi version 2.1c for review

2007-11-10 Thread Frank Seidel
On Samstag 10 November 2007 00:27:03, you (Frank Seidel) wrote: > I really appreciated any feedback or hint were to dig further or what > should be done and fixed. Thanks to the great patches from Jiri Slaby <[EMAIL PROTECTED]> this is now again a probably big step forward for the nozomi driver. B

Re: [PATCH 0/11 v3] enable "make ARCH=x86"

2007-11-10 Thread Christoph Hellwig
On Sat, Nov 10, 2007 at 12:08:12AM +0100, Sam Ravnborg wrote: > With this patchset the former ARCH=i386 / ARCH=x86_64 are > replaced by ARCH=x86. > The rationale behind the patchset are that with a > unified x86 architecture this should be reflected in > the build commands. > > With this patch set

Re: [RFC 1/13] Char: nozomi, remove unneded stuff

2007-11-10 Thread Jiri Slaby
On 11/10/2007 04:41 PM, Frank Seidel wrote: > I also added you to the header of the complete patch > (also with your Signed-off-by), is that ok? No problem here. thanks, -- Jiri Slaby ([EMAIL PROTECTED]) Faculty of Informatics, Masaryk University - To unsubscribe from this list: send the line "u

Re: [PATCH] Include header required for INT_MAX

2007-11-10 Thread Christoph Hellwig
On Sat, Nov 10, 2007 at 03:55:15PM +0100, Thomas Koeller wrote: > cdrom.h uses INT_MAX, so it must include kernel.h or > limits.h (userspace) for a definition. Nack, we shoiuld never include userspace headers in kernel headers, an even more never add !__KERNEL__ ifdefs. Just make sure your progra

Re: OOM killer problem - how to read the kernel log?

2007-11-10 Thread Tobias Brox
[Tobias Brox] > > We're running 32 bits linux, maybe it would help to upgrade to 64 bits? [Johannes Weiner] > Although you can address up to 64GB of RAM with PAE, the address space > of directly accessible memory is still at 32bit (4GB) and access to > higher memory costs low memory and processing

Re: Initrd problem with AMD opteron dual core

2007-11-10 Thread Andi Kleen
jean-francois simon <[EMAIL PROTECTED]> writes: > i don't know where to start to try solving this problem. why would the > dual core CPUs cause a problem? i fear that just disabling the initrd > could just mask a more serious problem. Most likely. > also i don't understand why /proc/meminfo only

Re: [RFC 13/13] Char: nozomi, cleanup read and write

2007-11-10 Thread Adrian Bunk
On Fri, Nov 09, 2007 at 06:51:35PM -0500, Jiri Slaby wrote: >... > --- a/drivers/char/nozomi.c > +++ b/drivers/char/nozomi.c >... > - if (size_bytes - i == 2) { > + if (unlikely(size_bytes - i == 2)) { >... Please don't add likely/unlikely in drivers unless it brings a mea

[PATCH] drivers/video/s1d13xxxfb.c as module with dbg

2007-11-10 Thread Stanislav Brabec
Attached patch fixes two compilation problems of s1d13xxxfb.c: - Fixes outdated dbg() message to fix compilation error with debugging enabled. - Do not read kernel command line options when compiled as module. Signed-off-by: Stanislav Brabec <[EMAIL PROTECTED]> --- linux-2.6.23/drivers/video/s1d1

Re: Coding Style: indenting with tabs vs. spaces

2007-11-10 Thread DervishD
Bonjour Xavier :) * Xavier Bestel <[EMAIL PROTECTED]> dixit: > Le samedi 10 novembre 2007 à 13:04 +0100, DervishD a écrit : > > * Benny Halevy <[EMAIL PROTECTED]> dixit: > > > I would like to hear peoples opinion about the indentation convention > > > described below that I personally found

Re: [PATCH] Include header required for INT_MAX

2007-11-10 Thread Alexander E. Patrakov
Thomas Koeller wrote: cdrom.h uses INT_MAX, so it must include kernel.h or limits.h (userspace) for a definition. No, it must be fixed so that it doesn't use this #defined constant. Debian has this: /* Special codes used when specifying changer slots. */ #define CDSL_NONE ((int)

Re: [PATCH] make ds1wm driver to check ds1wm_platform_data pointer against NULL

2007-11-10 Thread Evgeniy Polyakov
On Fri, Nov 09, 2007 at 05:02:38PM -0800, Andrew Morton ([EMAIL PROTECTED]) wrote: > > @@ -351,6 +351,10 @@ static int ds1wm_probe(struct platform_device *pdev) > > goto err0; > > } > > plat = pdev->dev.platform_data; > > + if (!plat) { > > + ret = -ENXIO; > > +

Re: [PATCH] Smackv10: Smack rules grammar + their stateful parser(2)

2007-11-10 Thread Jakob Oestergaard
... > I've double-checked the code for any possible off-by-one/overflow > errors. ... Two things caught my eye. ... > + case bol: > + case subject: > + if (*label_len >= SMK_MAXLEN) > + goto out; > + subj

[PATCH] ACPI: add documentation for deprecated /proc/acpi/battery in ACPI_PROCFS

2007-11-10 Thread Jerome Pinot
From: Jerome Pinot <[EMAIL PROTECTED]> Add documentation in Kconfig help about the move of /proc/acpi/battery to /sys/class/power_supply when selecting ACPI_PROCFS. This will impact a lot of users and should be documented. Signed-off-by: Jerome Pinot <[EMAIL PROTECTED]> --- diff --git a/drivers/

Re: [PATCH] Add quirk to set AHCI mode on ICH boards

2007-11-10 Thread Mark Lord
Matthias Schniedermeyer wrote: .. My computer/mainboard @work has such a "broken" BIOS. Of the 5 SATA-Ports this MB has only 1 (and 1 "missing" that is reported by linux but i can't find on the MB) is configured as AHCI which means that with .. I have a P5B-VM here (very similar). The "missi

Re: [PATCH] Add quirk to set AHCI mode on ICH boards

2007-11-10 Thread Matthias Schniedermeyer
On 10.11.2007 13:01, Mark Lord wrote: > Matthias Schniedermeyer wrote: >> .. >> My computer/mainboard @work has such a "broken" BIOS. Of the 5 SATA-Ports >> this MB has only 1 (and 1 "missing" that is reported by linux but i can't >> find on the MB) is configured as AHCI which means that with >

[PATCH] 2.6.24-rc2: fix oops in ACPI battery removal

2007-11-10 Thread Andrey Borzenkov
Alexey, this fixes my patch that went into -rc2. Sorry for Oops. Subject: [PATCH] 2.6.24-rc2: do not unregister power_supply in sysfs ->show method From: Andrey Borzenkov <[EMAIL PROTECTED]> Currently unplugging battery oopses with call stack: [ 2245.375393] [] show_trace_log_lvl+0x1a/0x30 [ 2

RE: [PATCH] Add quirk to set AHCI mode on ICH boards

2007-11-10 Thread Allen Martin
> Alan Cox wrote: > > On Thu, 8 Nov 2007 22:46:22 -0500 > > Jeff Garzik <[EMAIL PROTECTED]> wrote: > > > >> On Thu, Nov 08, 2007 at 10:29:37PM -0500, Mark Lord wrote: > >>> And I might even privately patch my own kernels to map > the ACHI BAR > >>> in the cases where the BIOS didn't... > >> The

Re: [PATCH] 2.6.24-rc2: fix oops in ACPI battery removal

2007-11-10 Thread Alexey Starikovskiy
Andrey, Fix already exists. It already went up to Len's tree. Regards, Alex. Andrey Borzenkov wrote: Alexey, this fixes my patch that went into -rc2. Sorry for Oops. Subject: [PATCH] 2.6.24-rc2: do not unregister power_supply in sysfs ->show method From: Andrey Borzenkov <[EMAIL PROTECTED]>

Repost - NetLabel: Introduce a new kernel configuration API for NetLabel

2007-11-10 Thread Casey Schaufler
From: Paul Moore <[EMAIL PROTECTED]> Add a new set of configuration functions to the NetLabel/LSM API so that LSMs can perform their own configuration of the NetLabel subsystem without relying on assistance from userspace. Signed-off-by: Paul Moore <[EMAIL PROTECTED]> Signed-off-by: Casey Schaufl

Re: [PATCH] sata_nv,ahci: add the ahci legacy mode support to sata_nv

2007-11-10 Thread Robert Hancock
Jeff Garzik wrote: Jeff Garzik wrote: The proposed sata_nv patch does the opposite -- guarantees we must support the continually problematic legacy IDE interface ad infinitum. Such patches are OK for the test lab, but in this specific case users /suffer/ when not running AHCI mode. Just to r

Re: [PATCH] Add quirk to set AHCI mode on ICH boards

2007-11-10 Thread Jeff Garzik
Allen Martin wrote: At least for NVIDIA controllers, loading the AHCI driver when the BIOS is set to IDE mode is not recommended by NVIDIA. Any AHCI workarounds in the BIOS are likely to be disabled when set to IDE mode. In practice What workarounds, if any, are needed? We need those in the

Re: x86_64 SATA DVD drive + libata trouble

2007-11-10 Thread Robert Hancock
Bernd Strieder wrote: Hello, please CC me, I'm not subscribed. If any kernel developer is interested in more specific information please mail me, I can build kernels, I can apply patches, though have not done it regularly. I'd like to get the DVD drive working somehow. I have googled a lot

Re: [PATCH 5/6] MN10300: Add the MN10300/AM33 architecture to the kernel [try #5]

2007-11-10 Thread Andrew Morton
On Sat, 10 Nov 2007 12:18:50 + David Howells <[EMAIL PROTECTED]> wrote: > Andrew Morton <[EMAIL PROTECTED]> wrote: > > > ho hum, I've seen worse-looking code ;). There's quite a bit of the usual > > stuff in there: use of SPIN_LOCK_UNLOCKED, a forest of fishy-looking > > volatiles > > The v

Re: [PATCH] Smackv10: Smack rules grammar + their stateful parser(2)

2007-11-10 Thread Ahmed S. Darwish
On Nov 10, 2007 7:05 PM, Jakob Oestergaard <[EMAIL PROTECTED]> wrote: > ... > > I've double-checked the code for any possible off-by-one/overflow > > errors. > ... > > Two things caught my eye. > > ... > > + case bol: > > + case subject: > > + if (*label_

[PATCH] iwlwifi: Remove unnecessary code in iwl3945 and iwl4965 drivers

2007-11-10 Thread Miguel Botón
Remove unnecesary code in iwl3945 and iwl4965 drivers. "final_mode" variable is already initialized with the value of the "mode" variable. Signed-off-by: Miguel Boton <[EMAIL PROTECTED]> Index: linux-2.6.24-rc2/drivers/net/wireless/iwlwifi/iwl3945-base.c

Temporary lockup on loopback block device

2007-11-10 Thread Mikulas Patocka
Hi I am experiencing a transient lockup in 'D' state with loopback device. It happens when process writes to a filesystem in loopback with command like dd if=/dev/zero of=/s/fill bs=4k CPU is idle, disk is idle too, yet the dd process is waiting in 'D' in congestion_wait called from balance_di

Re: cannot "hibernate" if program being debugged in gdb is paused after SIGABRT in linux 2.6.23 (but can in 2.6.22.7)

2007-11-10 Thread CSights
Hi Rafael, > Can you please check if you are able to reproduce the problem with > 2.6.24-rc2? I am not able to reproduce the problem with 2.6.24-rc2. I am able to suspend to disk successfully. Thank for the prompt fix! :) C. - To unsubscribe from this list: send the line "unsu

Re: Fw: Buffer overflow in CIFS VFS.

2007-11-10 Thread Steve French
On Nov 10, 2007 7:03 AM, Przemyslaw Wegrzyn <[EMAIL PROTECTED]> wrote: > Steve French wrote: > > That might be better, although without memory pools, this would perform > > much worse > > > Why ? I don't get your point here. > > Przemyslaw > What I meant is that two fixed size memory pools rather

Re: [PATCH 5/6] MN10300: Add the MN10300/AM33 architecture to the kernel [try #5]

2007-11-10 Thread Alan Cox
> If it is indeed the case that this architecture is used internally by a > single organisation then perhaps it doesn't make sense for us to merge it. Disagree, as does history. We merged the AP1000 ... > distribution: to get it into the hands of people who need it. But in this > situation ther

Re: [PATCH 5/6] MN10300: Add the MN10300/AM33 architecture to the kernel [try #5]

2007-11-10 Thread Alan Cox
> The vast majority of which are either memory-mapped hardware registers or > interrupt-routine-filled ring buffers. memory mapped registers should be read with readw and friends and that should contain the volatile not the public code. Similarly spin_lock/unlock are store barriers so for ring bu

Re: Module init call vs symbols exporting race?

2007-11-10 Thread Andi Kleen
Jan Glauber <[EMAIL PROTECTED]> writes: > I've seen a symbol-resolving race on s390. The qeth module uses symbols > from qdio and although the loading order seems correct and the qdio > symbols should be available the following error appears: FWIW i see such messages all the time with usb serial

Re: Laptop's HDD

2007-11-10 Thread Stephen Clark
Maciej W. Rozycki wrote: On Sun, 4 Nov 2007, Alberto Gonzalez wrote: The problem comes from a very high rate of load/unload cycles of the heads that reaches the 300.000-600.000 limit in 2-3 years (with smartmontools it can checked it with "smartctl -A /dev/sda") . There are reports of HDD

Re: [PATCH] fix up perfmon to build on -mm

2007-11-10 Thread Andi Kleen
Greg KH <[EMAIL PROTECTED]> writes: [dropped perfmon list because gmane messed it up and it's apparently closed anyways] > Is there any way to just provide a basic framework that everyone can > agree on and then add on more stuff as time goes on? Do we have to have > every different processor/ar

Re: [PATCH 0/11 v3] enable "make ARCH=x86"

2007-11-10 Thread H. Peter Anvin
Paul Mundt wrote: Indeed, that's what I was intending on keeping around as a convention, and simply overloading SRCARCH for the sh64 case. i386/x86_64 potentially has the same issue though, and if the intent is to have a single ARCH for both of them, I don't see how that would possibly work witho

[PATCH 0/5] introduce K64BIT=y and backward compatibility ARCH={i386,x86_64} for x86

2007-11-10 Thread Sam Ravnborg
As discussed in another thread the right thing is to add a generic solution to select between 32 and 64 bit - useable for powerpc, s390, ppc et al. First step was to teach kconfig how to force 64BIT to a specific value. The x86 Kconfig file needed a small twist to use 64BIT as the symbol to seelct

[PATCH] x86: Use CONFIG_64BIT to select between 32 and 64 bit in Kconfig

2007-11-10 Thread Sam Ravnborg
This change allow us to use the new syntax: make K64BIT={n,y} to select between 32 and 64 bit. Signed-off-by: Sam Ravnborg <[EMAIL PROTECTED]> --- arch/x86/Kconfig | 26 -- 1 files changed, 8 insertions(+), 18 deletions(-) diff --git a/arch/x86/Kconfig b/arch/x86/Kconfi

[PATCH] kconfig: factor out code in confdata.c

2007-11-10 Thread Sam Ravnborg
This patch introduce no functional changes. Signed-off-by: Sam Ravnborg <[EMAIL PROTECTED]> Cc: Roman Zippel <[EMAIL PROTECTED]> --- scripts/kconfig/confdata.c | 119 +++ 1 files changed, 64 insertions(+), 55 deletions(-) diff --git a/scripts/kconfig/conf

[PATCH] x86: introduce ARCH=i386,ARCH=x86_64 to select 32/64 bit

2007-11-10 Thread Sam Ravnborg
Using the newly added infrastructure is is now simple to add addition ARCH= symbols to select between 32 and 64 bit. Do this for x86. Signed-off-by: Sam Ravnborg <[EMAIL PROTECTED]> --- Makefile | 16 +--- arch/x86/Makefile| 10 +++--- scripts/kconfig/M

[PATCH] kconfig: document make K64BIT=y in README

2007-11-10 Thread Sam Ravnborg
Signed-off-by: Sam Ravnborg <[EMAIL PROTECTED]> --- README |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/README b/README index 159912c..6622ba1 100644 --- a/README +++ b/README @@ -194,6 +194,8 @@ CONFIGURING the kernel: "make *config" checks for a file named "all{y

[PATCH] kconfig: use $K64BIT to set 64BIT with all*config targets

2007-11-10 Thread Sam Ravnborg
The variable K64BIT can now be used to select the value of CONFIG_64BIT. This is for example useful for powerpc to generate allmodconfig for both bit sizes - like this: make ARCH=powerpc K64BIT=y make ARCH=powerpc K64BIT=n To use this the Kconfig file must use "64BIT" as the config value to selec

Re: [PATCH 0/11 v3] enable "make ARCH=x86"

2007-11-10 Thread Sam Ravnborg
On Sat, Nov 10, 2007 at 12:35:01PM -0800, H. Peter Anvin wrote: > > HOWEVER, I think the right thing for allyesconfig, allmodconfig, > randconfig, etc. is to be able to override specific variables. Right > now, one has to use indirection via a file, which is a bit clumsy; it > would be better

Re: [PATCH] kconfig: use $K64BIT to set 64BIT with all*config targets

2007-11-10 Thread Guillaume Chazarain
Hi, On 11/10/07, Sam Ravnborg <[EMAIL PROTECTED]> wrote: > The variable K64BIT can now be used to select the > value of CONFIG_64BIT. Why not calling the environment variable CONFIG_64BIT, in preparation of the day when all CONFIG_ variables can be passed by environment variables? -- Guillaume

[PATCH] [POWERPC] Fix CONFIG_SMP=n build error on ppc64

2007-11-10 Thread Olof Johansson
[POWERPC] Fix CONFIG_SMP=n build error The patch "KVM: fix !SMP build error" change the way smp_call_function() actually uses the passed in function names on non-SMP builds. So previously it was never caught that the function passed in was never actually defined. This causes a build error on ppc6

Re: AppArmor Security Goal

2007-11-10 Thread Andi Kleen
Crispin Cowan <[EMAIL PROTECTED]> writes: The document should be a good base for a merge. > * A confined process can operate on a file descriptor passed to it > by an unconfined process, even if it manipulates a file not in the > confined process's profile. To block this attack, c

USB storage: corrupted data transfers

2007-11-10 Thread Mark Lord
Something may be broken in USB / usb-storage land. I've got a 2GB USB stick here. I want to copy it to an image file on my hard drive: cat /dev/sdb > usbkey.image1 Make a second copy, with or without unplugging/replugging the stick: cat /dev/sdb > usbkey.image2 After doing this, the two

2.6.24-rc2 STD with s2disk fails to activate suspended system after loading

2007-11-10 Thread Chris Friedhoff
please cc me, I'm not not subscribed to LKML Hello, with kernel 2.6.24-rc2 STD with s2disk suspends the system to disk, but when I start the system and the suspended systemimage is loaded, it fails to "activate" this suspended systemimage and continues after some time with following the normal bo

Re: AppArmor Security Goal

2007-11-10 Thread david
On Sat, 10 Nov 2007, Andi Kleen wrote: Crispin Cowan <[EMAIL PROTECTED]> writes: The document should be a good base for a merge. * A confined process can operate on a file descriptor passed to it by an unconfined process, even if it manipulates a file not in the confined proce

Re: [Linux-usb-users] USB storage: corrupted data transfers

2007-11-10 Thread Alan Stern
On Sat, 10 Nov 2007, Mark Lord wrote: > Something may be broken in USB / usb-storage land. > > I've got a 2GB USB stick here. > I want to copy it to an image file on my hard drive: > > cat /dev/sdb > usbkey.image1 > > Make a second copy, with or without unplugging/replugging the stick: > >

Re: AppArmor Security Goal

2007-11-10 Thread Crispin Cowan
Andi Kleen wrote: > Crispin Cowan <[EMAIL PROTECTED]> writes: > > The document should be a good base for a merge. > > >> * A confined process can operate on a file descriptor passed to it >> by an unconfined process, even if it manipulates a file not in the >> confined process's

Re: [PATCH 0/11 v3] enable "make ARCH=x86"

2007-11-10 Thread Theodore Tso
On Sat, Nov 10, 2007 at 12:35:01PM -0800, H. Peter Anvin wrote: > In fact, we should be able to get rid of ARCH entirely; CONFIG_ options > have the huge advantage that they're saved in a file, and you don't have to > type them on every make run. The only option that I can't see us getting > ri

Re: USB storage: corrupted data transfers

2007-11-10 Thread Mark Lord
Mark Lord wrote: Something may be broken in USB / usb-storage land. I've got a 2GB USB stick here. I want to copy it to an image file on my hard drive: cat /dev/sdb > usbkey.image1 Make a second copy, with or without unplugging/replugging the stick: cat /dev/sdb > usbkey.image2 After d

Re: [RFC 13/13] Char: nozomi, cleanup read and write

2007-11-10 Thread Jiri Slaby
On 11/10/2007 05:15 PM, Adrian Bunk wrote: > On Fri, Nov 09, 2007 at 06:51:35PM -0500, Jiri Slaby wrote: >> ... >> --- a/drivers/char/nozomi.c >> +++ b/drivers/char/nozomi.c >> ... >> -if (size_bytes - i == 2) { >> +if (unlikely(size_bytes - i == 2)) { >> ... > > Please don

Re: [PATCH] virtio config_ops refactoring

2007-11-10 Thread Anthony Liguori
Rusty Russell wrote: On Saturday 10 November 2007 10:45:38 Anthony Liguori wrote: The problem is the ABI. We can either require that PCI configuration values are accessed with natural instructions, or it makes very little sense to use the PCI configuration space for virtio configuration info

Re: AppArmor Security Goal

2007-11-10 Thread Crispin Cowan
Dr. David Alan Gilbert wrote: > * Crispin Cowan ([EMAIL PROTECTED]) wrote: > > * Manipulating AppArmor policy requires being both root privileged >> and not being confined by AppArmor, thus there is explicitly no >> capability for non-privileged users to change AppArmor policy. >>

[git patches] net driver fixes

2007-11-10 Thread Jeff Garzik
Please pull from 'upstream-linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git upstream-linus to receive the following updates: MAINTAINERS | 10 ++- drivers/net/Kconfig |2 +- drivers/net/bonding/bond_main.

Re: [PATCH] kconfig: use $K64BIT to set 64BIT with all*config targets

2007-11-10 Thread Randy Dunlap
On Sat, 10 Nov 2007 21:43:26 +0100 Sam Ravnborg wrote: > The variable K64BIT can now be used to select the > value of CONFIG_64BIT. > > This is for example useful for powerpc to generate > allmodconfig for both bit sizes - like this: > make ARCH=powerpc K64BIT=y > make ARCH=powerpc K64BIT=n > >

Re: [PATCH] x86: Use CONFIG_64BIT to select between 32 and 64 bit in Kconfig

2007-11-10 Thread Randy Dunlap
On Sat, 10 Nov 2007 21:43:27 +0100 Sam Ravnborg wrote: > This change allow us to use the new syntax: > make K64BIT={n,y} to select between 32 and 64 bit. > > Signed-off-by: Sam Ravnborg <[EMAIL PROTECTED]> > --- > arch/x86/Kconfig | 26 -- > 1 files changed, 8 insertion

Re: [PATCH] kconfig: document make K64BIT=y in README

2007-11-10 Thread Randy Dunlap
On Sat, 10 Nov 2007 21:43:28 +0100 Sam Ravnborg wrote: > Signed-off-by: Sam Ravnborg <[EMAIL PROTECTED]> > --- > README |2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/README b/README > index 159912c..6622ba1 100644 > --- a/README > +++ b/README > @@ -194,6 +194,8

Re: AppArmor Security Goal

2007-11-10 Thread Dr. David Alan Gilbert
* Crispin Cowan ([EMAIL PROTECTED]) wrote: > Dr. David Alan Gilbert wrote: > > * Crispin Cowan ([EMAIL PROTECTED]) wrote: > > >> * Manipulating AppArmor policy requires being both root privileged > >> and not being confined by AppArmor, thus there is explicitly no > >> capability f

Re: dib7000m_i2c_enumeration() is unused

2007-11-10 Thread Patrick Boettcher
Hi all, This is another story of "the chip-vendor provides driver support and is waiting for device to hit the market". DiBcom knows that there are devices out there that are using the dib7000m in way that they need the dib7000m_i2c_enumeration to work properly. But it is impossible to know t

Re: [PATCH] kconfig: use $K64BIT to set 64BIT with all*config targets

2007-11-10 Thread Sam Ravnborg
On Sat, Nov 10, 2007 at 02:16:19PM -0800, Randy Dunlap wrote: > On Sat, 10 Nov 2007 21:43:26 +0100 Sam Ravnborg wrote: > > > The variable K64BIT can now be used to select the > > value of CONFIG_64BIT. > > > > This is for example useful for powerpc to generate > > allmodconfig for both bit sizes

Re: [PATCH 0/5] introduce K64BIT=y and backward compatibility ARCH={i386,x86_64} for x86

2007-11-10 Thread Randy Dunlap
On Sat, 10 Nov 2007 21:40:38 +0100 Sam Ravnborg wrote: > As discussed in another thread the right thing is to add a generic solution > to select between 32 and 64 bit - useable for powerpc, s390, ppc et al. > > First step was to teach kconfig how to force 64BIT to a specific value. > The x86 Kcon

Re: AppArmor Security Goal

2007-11-10 Thread Dr. David Alan Gilbert
* Crispin Cowan ([EMAIL PROTECTED]) wrote: > * Manipulating AppArmor policy requires being both root privileged > and not being confined by AppArmor, thus there is explicitly no > capability for non-privileged users to change AppArmor policy. It's a pity that there is no way to

Re: AppArmor Security Goal

2007-11-10 Thread Crispin Cowan
Dr. David Alan Gilbert wrote: > * Crispin Cowan ([EMAIL PROTECTED]) wrote: > >> I don't get the problem: if you want your web browser to be able to >> access where you commonly store your documents, then give it that >> permission. The above rule says that your web browser doesn't get to go >> c

Re: [PATCH 0/5] introduce K64BIT=y and backward compatibility ARCH={i386,x86_64} for x86

2007-11-10 Thread Sam Ravnborg
On Sat, Nov 10, 2007 at 02:33:02PM -0800, Randy Dunlap wrote: > On Sat, 10 Nov 2007 21:40:38 +0100 Sam Ravnborg wrote: > > > As discussed in another thread the right thing is to add a generic solution > > to select between 32 and 64 bit - useable for powerpc, s390, ppc et al. > > > > First step w

Re: cd/dvd inaccessible in 2.6.24-rc2

2007-11-10 Thread Andrew Morton
On Sat, 10 Nov 2007 15:27:11 +1100 Will Trives <[EMAIL PROTECTED]> wrote: > > Hello, > > Motherboard: Gigabyte GA-P35-DS4 (rev. 1.1) > Chipset: Intel P35 + ICH9R > PATA port runs off JMicron controller > CD/DVD Device: BENQ DW1640 16X > > I cannot access my dvd burner under 2.6.24-rc2, I have

Re: Temporary lockup on loopback block device

2007-11-10 Thread Andrew Morton
On Sat, 10 Nov 2007 20:51:31 +0100 (CET) Mikulas Patocka <[EMAIL PROTECTED]> wrote: > Hi > > I am experiencing a transient lockup in 'D' state with loopback device. It > happens when process writes to a filesystem in loopback with command like > dd if=/dev/zero of=/s/fill bs=4k > > CPU is idl

Re: WARNING: at lib/kref.c:33 kref_get() (-mm 2007-11-06-02-32++)

2007-11-10 Thread Andrew Morton
On Fri, 9 Nov 2007 21:12:47 -0500 Erez Zadok <[EMAIL PROTECTED]> wrote: > Setup: FC6 system with MM snapshot broken-out-2007-11-06-02-32 That's a bit old. > and these two > patches added: > > r-o-bind-mounts-track-number-of-mount-writer-fix-buggy-loop.patch > r-o-bind-mounts-track-number-of-mou

Re: AppArmor Security Goal

2007-11-10 Thread Alan Cox
> Can you explain why you want a non-privileged user to be able to edit > policy? I would like to better understand the problem here. Because root doesn't trust users who in turn may not trust apps they run or wish to control things. I don't see a problem with that viewpoint in terms of forbidding

Re: Temporary lockup on loopback block device

2007-11-10 Thread Peter Zijlstra
On Sat, 2007-11-10 at 14:54 -0800, Andrew Morton wrote: > On Sat, 10 Nov 2007 20:51:31 +0100 (CET) Mikulas Patocka <[EMAIL PROTECTED]> > wrote: > > > Hi > > > > I am experiencing a transient lockup in 'D' state with loopback device. It > > happens when process writes to a filesystem in loopbac

[PATCH] NFS: Fix the ustat() regression

2007-11-10 Thread Kumar Gala
From: Trond Myklebust <[EMAIL PROTECTED]> Since 2.6.18, the superblock sb->s_root has been a dummy dentry with a dummy inode. This breaks ustat(), which actually uses sb->s_root in a vfstat() call. Fix this by making the s_root a dummy alias to the directory inode that was used when creating the

Re: cd/dvd inaccessible in 2.6.24-rc2

2007-11-10 Thread Alan Cox
On Sat, 10 Nov 2007 14:49:23 -0800 Andrew Morton <[EMAIL PROTECTED]> wrote: > On Sat, 10 Nov 2007 15:27:11 +1100 Will Trives <[EMAIL PROTECTED]> wrote: > > > > > Hello, > > > > Motherboard: Gigabyte GA-P35-DS4 (rev. 1.1) > > Chipset: Intel P35 + ICH9R > > PATA port runs off JMicron controller

Re: [BUG]: Crash with CONFIG_FAIR_CGROUP_SCHED=y

2007-11-10 Thread sukadev
Serge E. Hallyn [EMAIL PROTECTED] wrote: | Quoting Srivatsa Vaddagiri ([EMAIL PROTECTED]): | > On Fri, Nov 09, 2007 at 09:45:21AM +0100, Dmitry Adamushko wrote: | > > Humm... the 'current' is not kept within the tree but | > > current->se.on_rq is supposed to be '1' , | > > so the old code looks ok

Re: AppArmor Security Goal

2007-11-10 Thread Crispin Cowan
Alan Cox wrote: >> Can you explain why you want a non-privileged user to be able to edit >> policy? I would like to better understand the problem here. >> > Because root doesn't trust users who in turn may not trust apps they run > or wish to control things. I don't see a problem with that vie

Re: AppArmor Security Goal

2007-11-10 Thread Dr. David Alan Gilbert
* Crispin Cowan ([EMAIL PROTECTED]) wrote: > Dr. David Alan Gilbert wrote: > > * Crispin Cowan ([EMAIL PROTECTED]) wrote: > > > >> I don't get the problem: if you want your web browser to be able to > >> access where you commonly store your documents, then give it that > >> permission. The above

Re: cd/dvd inaccessible in 2.6.24-rc2

2007-11-10 Thread Jeff Garzik
Alan Cox wrote: ata9.00: qc timeout (cmd 0xa0) ata9.00: exception Emask 0x0 SAct 0x0 SErr 0x0 action 0x2 frozen ata9.00: cmd a0/00:00:00:02:00/00:00:00:00:00/a0 tag 0 cdb 0x5a data 2 in res 51/54:03:00:02:00/00:00:00:00:00/a0 Emask 0x5 (timeout) ata9.00: status: { DRDY ERR } Could be a

Re: [PATCH] drivers/video/s1d13xxxfb.c as module with dbg

2007-11-10 Thread dave chung
On 11/10/07, Stanislav Brabec <[EMAIL PROTECTED]> wrote: > Attached patch fixes two compilation problems of s1d13xxxfb.c: > - Fixes outdated dbg() message to fix compilation error with debugging > enabled. > - Do not read kernel command line options when compiled as module. > > Signed-off-by: Stan

Re: cd/dvd inaccessible in 2.6.24-rc2

2007-11-10 Thread Jeff Garzik
Will Trives wrote: Hello, Motherboard: Gigabyte GA-P35-DS4 (rev. 1.1) Chipset: Intel P35 + ICH9R PATA port runs off JMicron controller CD/DVD Device: BENQ DW1640 16X I cannot access my dvd burner under 2.6.24-rc2, I have no problems under 2.6.23. Basically the drive is detected OK, everything

Re: AppArmor Security Goal

2007-11-10 Thread david
On Sat, 10 Nov 2007, Dr. David Alan Gilbert wrote: Can you explain why you want a non-privileged user to be able to edit policy? I would like to better understand the problem here. I think it might depend on how strict the users starting point is; you could say: 1 This document editor can re

Re: AppArmor Security Goal

2007-11-10 Thread Dr. David Alan Gilbert
* [EMAIL PROTECTED] ([EMAIL PROTECTED]) wrote: That I wrote: > >If the adminisrator set something up with (2) as the starting point it > >would seem reasonable for the user to be able to add the ability to edit > >documents in extra directories for their style of organising documents > >they work

Re: AppArmor Security Goal

2007-11-10 Thread Alan Cox
> I submit that the AppArmor model is valid, even if it totally failed all > of David Gilbert's questions (I think AppArmor can actually provide > about half of what he asked for). The model looks valid. I have difficulty constructing many scenarios where its useful but it appears valid providing

problems with spi interface & ads 784X under 2.6.23

2007-11-10 Thread dave chung
on kernel 2.6.23 , with an Arm AT91rm9200 sometimes when i "pen-down" on the touch screen,I'm seeing ads7846 spi0.0: touchscreen, irq 75 input: ADS784x Touchscreen as /devices/platform/atmel_spi.0/spi0.0/input/input0 at91_rtc at91_rtc: rtc core: registered at91_rtc as rtc0 atmel_spi atmel_spi

Re: USB storage: corrupted data transfers

2007-11-10 Thread Mark Lord
Mark Lord wrote: Mark Lord wrote: Something may be broken in USB / usb-storage land. I've got a 2GB USB stick here. I want to copy it to an image file on my hard drive: cat /dev/sdb > usbkey.image1 Make a second copy, with or without unplugging/replugging the stick: cat /dev/sdb > usbk

Re: AppArmor Security Goal

2007-11-10 Thread Alan Cox
> but how can the system know if the directory the user wants to add is > reasonable or not? what if the user says they want to store their > documents in /etc? A more clear example is wanting to wrap a specific tool with temporary rules. Those rules would depend on the exact file being edited a

Re: cd/dvd inaccessible in 2.6.24-rc2

2007-11-10 Thread Andrew Morton
On Sat, 10 Nov 2007 23:05:53 + Alan Cox <[EMAIL PROTECTED]> wrote: > > > ata9.00: qc timeout (cmd 0xa0) > > > ata9.00: exception Emask 0x0 SAct 0x0 SErr 0x0 action 0x2 frozen > > > ata9.00: cmd a0/00:00:00:02:00/00:00:00:00:00/a0 tag 0 cdb 0x5a data 2 > > > in > > > res 51/54:03:00:02

Re: Fw: Buffer overflow in CIFS VFS.

2007-11-10 Thread Przemyslaw Wegrzyn
Steve French wrote: > On Nov 10, 2007 7:03 AM, Przemyslaw Wegrzyn <[EMAIL PROTECTED]> wrote: > >> Steve French wrote: >> >>> That might be better, although without memory pools, this would perform >>> much worse >>> >>> >> Why ? I don't get your point here. >> > What I meant is

Re: WARNING: at lib/kref.c:33 kref_get() (-mm 2007-11-06-02-32++)

2007-11-10 Thread Erez Zadok
In message <[EMAIL PROTECTED]>, Andrew Morton writes: > On Fri, 9 Nov 2007 21:12:47 -0500 Erez Zadok <[EMAIL PROTECTED]> wrote: > > > Setup: FC6 system with MM snapshot broken-out-2007-11-06-02-32 > > That's a bit old. > > > and these two > > patches added: > > > > r-o-bind-mounts-track-number-

Warning: commit message does not conform to UTF-8. (mmotm "10-Nov-2007 22:46")

2007-11-10 Thread Erez Zadok
Andrew, I'm getting minor warnings when applying two patches from It's probably not serious but I wonder if checkpatch catches this. Applying patch..git-net.patch Warning: commit message does not conform to UTF-8. You may want to amend it after fixing the

Re: Temporary lockup on loopback block device

2007-11-10 Thread Mikulas Patocka
> > Arguably we just have the wrong backing-device here, and what we should do > > is to propagate the real backing device's pointer through up into the > > filesystem. There's machinery for this which things like DM stacks use. > > > > I wonder if the post-2.6.23 changes happened to make this pr

Re: Temporary lockup on loopback block device

2007-11-10 Thread Mikulas Patocka
On Sat, 10 Nov 2007, Andrew Morton wrote: > On Sat, 10 Nov 2007 20:51:31 +0100 (CET) Mikulas Patocka <[EMAIL PROTECTED]> > wrote: > > > Hi > > > > I am experiencing a transient lockup in 'D' state with loopback device. It > > happens when process writes to a filesystem in loopback with comma

[PATCH 1/2] [VLAN] Don't drop an unclassfied vlan packet as PACKET_OTHERHOST

2007-11-10 Thread Joonwoo Park
IMHO linux should not drop unclassified vlan packets to pass these to sniffers. isn't it? But, since the __vlan_hwaccel_rx drops unclassified vlan packets, sniffers cannot see them. This make the __vlan_hwaccel_rx receive and process an unclassified vlan packet as a PACKET_OTHERHOST. Any check,

[PATCH 2/2] [e1000 VLAN] Disable vlan hw accel when promiscuous mode

2007-11-10 Thread Joonwoo Park
IMHO even though netdevice is in the promiscuous mode, we should receive all of ingress packets. This disable the vlan filtering feature when a vlan hw accel configured e1000 device goes into promiscuous mode. This make packets visible to sniffers though it's not vlan id of itself. Any check, com

[PATCH] mm/memory.c follow_hugetlb_page compiler error (MMOTM)

2007-11-10 Thread Erez Zadok
Using http://userweb.kernel.org/~akpm/mmotm/ timestamped "10-Nov-2007 22:46". CONFIG_HUGETLB_PAGE not set. $ make CC mm/memory.o mm/memory.c:1040:29: error: macro "follow_hugetlb_page" passed 8 arguments, but takes just 7 mm/memory.c: In function 'get_user_pages': mm/memory.c:1039: error:

[PATCH] kernel/capability.c get_task_comm compile error (MMOTM)

2007-11-10 Thread Erez Zadok
Using http://userweb.kernel.org/~akpm/mmotm/ timestamped "10-Nov-2007 22:46". $ make CC kernel/capability.o kernel/capability.c: In function 'sys_capset': kernel/capability.c:231: warning: passing argument 1 of 'get_task_comm' from incompatible pointer type kernel/capability.c:231: error:

patch conflicts (MMOTM "10-Nov-2007 22:46")

2007-11-10 Thread Erez Zadok
Andrew, I'm using http://userweb.kernel.org/~akpm/mmotm/ timestamped "10-Nov-2007 22:46". 1. I was getting a bunch of patch conflicts, until I realized that this latest set of patches was to be applied against 2.6.24-rc2 (your mm.patch gave it away :-) The last snapshot was against 2.6.24-r

Re: [PATCH] Include header required for INT_MAX

2007-11-10 Thread Thomas Koeller
On Samstag, 10. November 2007, Christoph Hellwig wrote: > On Sat, Nov 10, 2007 at 03:55:15PM +0100, Thomas Koeller wrote: > > cdrom.h uses INT_MAX, so it must include kernel.h or > > limits.h (userspace) for a definition. > > Nack, we shoiuld never include userspace headers in kernel headers, > an

Re: AppArmor Security Goal

2007-11-10 Thread david
On Sat, 10 Nov 2007, Alan Cox wrote: but how can the system know if the directory the user wants to add is reasonable or not? what if the user says they want to store their documents in /etc? A more clear example is wanting to wrap a specific tool with temporary rules. Those rules would depend

  1   2   >