Re: Issue building kernel driver

2007-11-01 Thread Frans Pop
Chris Holvenstot wrote: > Since I try to be slightly useful and build as many of the "test" kernel > images I can I end up rebuilding the VirtualBox kernel driver (open > source) on an almost daily basis. > > I attempted to rebuild the driver today and got the following error > messages running 2.

Re: 100% iowait on one of cpus in current -git

2007-11-01 Thread Torsten Kaiser
On 11/1/07, Fengguang Wu <[EMAIL PROTECTED]> wrote: > On Wed, Oct 31, 2007 at 04:22:10PM +0100, Torsten Kaiser wrote: > > Since 2.6.23-mm1 I also experience strange hangs during heavy writeouts. > > Each time I noticed this I was using emerge (package util from the > > gentoo distribution) to insta

[PATCH v2] x86: show cpuinfo only for online CPUs

2007-11-01 Thread Andreas Herrmann
New version of the fix. Now it works also in the non-SMP case. Tested on x86_64. Regards, Andreas -- [PATCH] x86: show cpuinfo only for online CPUs Fix regressions introduced with 92cb7612aee39642d109b8d935ad265e602c0563. It can happen that cpuinfo is displayed for CPUs that are not online or

Re: [PATCH] audit: clear thread flag for new children

2007-11-01 Thread Steve Grubb
On Thursday 01 November 2007 01:23:24 pm Tony Jones wrote: > > We are looking into this - at one time it did. Someone should follow up > > with a path correcting this soon. But I doubt the audit system will work > > correctly if the flag gets removed as there is no good way to add it > > again late

Re: per-bdi-throttling: synchronous writepage doesn't work correctly

2007-11-01 Thread Peter Zijlstra
On Thu, 2007-11-01 at 18:16 +0100, Peter Zijlstra wrote: > On Thu, 2007-11-01 at 18:09 +0100, Peter Zijlstra wrote: > > On Thu, 2007-11-01 at 18:00 +0100, Miklos Szeredi wrote: > > > > > Hi, > > > > > > > > > > It looks like bdi_thresh will always be zero if filesystem does > > > > > synchronous w

2.6.24 breaks nvidia and amd/ati binary drivers, by exporting paravirt symbols as GPL

2007-11-01 Thread Tobias Powalowski
Hi commit to .24 tree: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=93b1eab3d29e7ea32ee583de3362da84db06ded8 introduces: +EXPORT_SYMBOL_GPL(pv_mmu_ops); +EXPORT_SYMBOL_GPL(pv_cpu_ops); pv_cpu_ops is for nvidia pv_mmu_ops' is for amd(ati) which will break 32bit syst

Re: [PATCH] x86: show cpuinfo only for online CPUs

2007-11-01 Thread Andreas Herrmann3
On Thu, Nov 01, 2007 at 06:35:43PM +0100, Andreas Herrmann3 wrote: > On Thu, Nov 01, 2007 at 03:12:25PM -0200, Glauber de Oliveira Costa wrote: > > So it could even work, but as accident. Unless I'm wrong about it, I'd > > prefer to see an explicit attribution of cpu_index = 0 somewhere for the > >

Re: [IDE] Fix build bug

2007-11-01 Thread Denys Vlasenko
On Tuesday 30 October 2007 12:41, Ralf Baechle wrote: > On Tue, Oct 30, 2007 at 11:34:29AM +, Denys Vlasenko wrote: > > > On Thursday 25 October 2007 22:41, Bartlomiej Zolnierkiewicz wrote: > > > > -static const struct ide_port_info generic_chipsets[] __devinitdata = { > > > > +static struct i

Re: [PATCH] PCMCIA: prevent auto insert during resume.

2007-11-01 Thread Russell King
On Thu, Nov 01, 2007 at 03:53:59PM +0100, Rodolfo Giometti wrote: > On Mon, Oct 29, 2007 at 07:24:15PM +, Pavel Machek wrote: > > On Fri 2007-10-26 19:18:57, Rodolfo Giometti wrote: > > > On Fri, Oct 26, 2007 at 06:00:31PM +0100, Russell King wrote: > > > > > > > > > > Also if you didn't eject

Re: [2.6.24-rc1 regression] AC adapter state does not change after resume

2007-11-01 Thread Andrey Borzenkov
On Wednesday 31 October 2007, Alexey Starikovskiy wrote: > Andrey Borzenkov wrote: > > On Wednesday 31 October 2007, Alexey Starikovskiy wrote: > >> Andrey Borzenkov wrote: > >>> I suspect new ACPI AC adapter code but have to add some printk's to be > >>> sure. > >>> > >>> To reproduce - plug in AC

Re: [PATCH] x86: show cpuinfo only for online CPUs

2007-11-01 Thread Glauber de Oliveira Costa
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Andreas Herrmann3 escreveu: > On Thu, Nov 01, 2007 at 06:35:43PM +0100, Andreas Herrmann3 wrote: >> On Thu, Nov 01, 2007 at 03:12:25PM -0200, Glauber de Oliveira Costa wrote: >>> So it could even work, but as accident. Unless I'm wrong about it, I'd >>

Re: 2.6.24 breaks nvidia and amd/ati binary drivers, by exporting paravirt symbols as GPL

2007-11-01 Thread Jan Engelhardt
On Nov 1 2007 19:36, Tobias Powalowski wrote: >Hi >commit to .24 tree: >http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=93b1eab3d29e7ea32ee583de3362da84db06ded8 > >introduces: >+EXPORT_SYMBOL_GPL(pv_mmu_ops); >+EXPORT_SYMBOL_GPL(pv_cpu_ops); > >pv_cpu_ops is for nvidia

Re: [PATCH] e1000, e1000e valid-addr fixes

2007-11-01 Thread Jeff Garzik
Kok, Auke wrote: David Miller wrote: From: Jeff Garzik <[EMAIL PROTECTED]> Date: Tue, 23 Oct 2007 22:20:30 -0400 David Miller wrote: From: Jeff Garzik <[EMAIL PROTECTED]> Date: Tue, 23 Oct 2007 21:03:36 -0400 I'm wondering if there is a way to avoid adding if (!is_valid_ether_addr(

Re: [PATCH 1/2] usb_gigaset: suspend support [v2]

2007-11-01 Thread Andrew Morton
On Thu, 01 Nov 2007 19:20:07 +0100 Tilman Schmidt <[EMAIL PROTECTED]> wrote: > >> +static int gigaset_suspend(struct usb_interface *intf, pm_message_t > >> message) > >> +{ > >> + struct cardstate *cs; > >> + struct usb_cardstate *ucs; > >> + > >> + if ((cs = usb_get_intfdata(intf)) == NULL ||

Re: [RFC] cpuset relative memory policies - second choice

2007-11-01 Thread David Rientjes
On Wed, 31 Oct 2007, Paul Jackson wrote: > The basic reason that I went with an additional per-task modal > state, rather than a modal flag for each mbind, set_mempolicy and > get_mempolicy call was to reduce the likely rate of bugs in user > level C code using this API. > I think it may be more

Re: [patch] PID namespace design bug, workaround

2007-11-01 Thread Theodore Tso
On Thu, Nov 01, 2007 at 04:05:37PM +0100, Ingo Molnar wrote: > + if (clone_flags & CLONE_NEWPID) > + return -ENOSYS; I'd use EINVAL instead of ENOSYS... - Ted - To unsubscribe from this list: send the line "unsubscribe linux-kernel"

Re: [PATCH] [sysfs]: make readlink result shorter when the symlink and its target shared some base sysfs subdirectory

2007-11-01 Thread Kay Sievers
On Oct 31, 2007 3:34 PM, Greg KH <[EMAIL PROTECTED]> wrote: > On Wed, Oct 31, 2007 at 06:34:20PM +0800, Denis Cheng wrote: > > this is especially useful after /sys/slab introduced, for example: > > > > $ ls -l /sys/slab/mm_struct > > lrwxrwxrwx 1 root root 0 2007-10-31 17:40 /sys/slab/mm_struct ->

Re: 100% iowait on one of cpus in current -git

2007-11-01 Thread Torsten Kaiser
On 11/1/07, Torsten Kaiser <[EMAIL PROTECTED]> wrote: > On 11/1/07, Fengguang Wu <[EMAIL PROTECTED]> wrote: > > Thank you. Maybe we can start by the applied debug patch :-) > > Will applied it and try to recreate this. Patch applied, used emerge to install a 2.6.24-rc1 kernel. I had no complete s

Re: [RFC] cpuset relative memory policies - second choice

2007-11-01 Thread David Rientjes
On Wed, 31 Oct 2007, Paul Jackson wrote: > With the mode bit as in my patch, there are fewer places in the user > code that have to be gotten just right. With your way, each and > every mbind and *_mempolicy call has to be hacked with the new flag > if one is going to use the new nodemask bit num

Re: [PATCH] PCMCIA: prevent auto insert during resume.

2007-11-01 Thread Russell King
On Thu, Nov 01, 2007 at 06:37:41PM +, Russell King wrote: > On Thu, Nov 01, 2007 at 03:53:59PM +0100, Rodolfo Giometti wrote: > > On Mon, Oct 29, 2007 at 07:24:15PM +, Pavel Machek wrote: > > > On Fri 2007-10-26 19:18:57, Rodolfo Giometti wrote: > > > > On Fri, Oct 26, 2007 at 06:00:31PM +0

Re: [RFC] cpuset relative memory policies - second choice

2007-11-01 Thread David Rientjes
On Thu, 1 Nov 2007, Paul Jackson wrote: > We were discussing libnuma here, not glibc. The system call wrappers > are in glibc. System call wrappers should not be setting optional > flags. They should just make the system call -- do whatever magic it > takes to get the provided arguments into th

Re: [RFC] cpuset relative memory policies - second choice

2007-11-01 Thread David Rientjes
On Thu, 1 Nov 2007, Paul Jackson wrote: > A library such as libnuma can set them, yes, but not everyone uses > libnuma. Basically everyone uses the standard C library, glibc, which > has the system call wrappers, but these wrappers should not be setting > optional flags. > I think what would en

Re: [PATCH] x86: check boundary in count/setup_resource called by get_current_resources

2007-11-01 Thread Gary Hade
On Thu, Nov 01, 2007 at 01:32:39AM -0700, Andrew Morton wrote: > On Thu, 01 Nov 2007 01:20:29 -0700 Yinghai Lu <[EMAIL PROTECTED]> wrote: > > > [PATCH] x86: check boundary in count/setup_resource called by > > get_current_resources > > > > need to check info->res_num less than PCI_BUS_NUM_RESOUR

Re: [PATCH] x86: show cpuinfo only for online CPUs

2007-11-01 Thread H. Peter Anvin
Glauber de Oliveira Costa wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Andreas Herrmann3 escreveu: On Thu, Nov 01, 2007 at 06:35:43PM +0100, Andreas Herrmann3 wrote: On Thu, Nov 01, 2007 at 03:12:25PM -0200, Glauber de Oliveira Costa wrote: So it could even work, but as accident. Unle

Re: per-bdi-throttling: synchronous writepage doesn't work correctly

2007-11-01 Thread Miklos Szeredi
> > > > See the file "Locking" for more details. > > > > > > The "should set PG_Writeback" bit threw me off I guess. > > Hmm, set_page_writeback() is also the one clearing the radix tree dirty > tag. So if that is not called, we get in a bit of a mess, no? > > Which makes me think hostfs

Re: [PATCH] [sysfs]: make readlink result shorter when the symlink and its target shared some base sysfs subdirectory

2007-11-01 Thread Kay Sievers
On Thu, 2007-11-01 at 19:59 +0100, Kay Sievers wrote: > On Oct 31, 2007 3:34 PM, Greg KH <[EMAIL PROTECTED]> wrote: > > On Wed, Oct 31, 2007 at 06:34:20PM +0800, Denis Cheng wrote: > > > this is especially useful after /sys/slab introduced, for example: > > > > > > $ ls -l /sys/slab/mm_struct > > >

Re: [RFC][PATCH 1/3] [RFC][PATCH] Fix procfs task exe symlinks

2007-11-01 Thread Andrew Morton
On Wed, 31 Oct 2007 20:35:09 -0700 Matt Helsley <[EMAIL PROTECTED]> wrote: > +++ linux-2.6.23/include/linux/sched.h > @@ -430,10 +430,13 @@ struct mm_struct { > struct completion *core_startup_done, core_done; > > /* aio bits */ > rwlock_tioctx_list_lock; >

Re: [PATCH] e1000, e1000e valid-addr fixes

2007-11-01 Thread Jeff Garzik
Stephen Hemminger wrote: How about: static int eth_validate_addr(const struct net_device *dev) { return is_valid_ether_addr(dev->dev_addr) ? 0 : -EINVAL; } hmmm -- its a slow path, so I don't see the value of marking the argument 'const' -- right now this implementation merely reads t

Re: [linux-usb-devel] [PATCH 1/2] usb_gigaset: suspend support [v2]

2007-11-01 Thread Alan Stern
On Thu, 1 Nov 2007, Tilman Schmidt wrote: > Anyway, to be sure these checks aren't needed, I would need the > assurance that the suspend and resume methods are serialized with > the probe and disconnect methods. Are they? Yes. See Documentation/usb/power-management.txt. Alan Stern - To unsubsc

Re: [PATCH] 2.6.23: Filesystem capabilities 0.17

2007-11-01 Thread Olaf Dietsche
Jan Kara <[EMAIL PROTECTED]> writes: >> This patch implements filesystem capabilities. It allows to >> run privileged executables without the need for suid root. > Hmm, is there some "design document" so that one does not have to poke > through the code and find out what it's actually trying to

Re: [PATCH] libata ATAPI transfer size cleanups

2007-11-01 Thread Torsten Kaiser
On 11/1/07, Jeff Garzik <[EMAIL PROTECTED]> wrote: > + lo = tf->lbam; > + hi = tf->lbam; > + ibyte = (hi << 8) | lo; > + > + lo = result_tf->lbam; > + hi = result_tf->lbam; That doesn't look right. I suspect this was intended: lo = tf->lbam; hi = tf->lbah; Torsten -

Re: [RFC][PATCH 1/3] [RFC][PATCH] Fix procfs task exe symlinks

2007-11-01 Thread Matt Helsley
On Thu, 2007-11-01 at 12:25 -0700, Andrew Morton wrote: > On Wed, 31 Oct 2007 20:35:09 -0700 > Matt Helsley <[EMAIL PROTECTED]> wrote: > > > +++ linux-2.6.23/include/linux/sched.h > > @@ -430,10 +430,13 @@ struct mm_struct { > > struct completion *core_startup_done, core_done; > > > > /*

[PATCH 3/4] UML - stop using libc asm/user.h

2007-11-01 Thread Jeff Dike
commit 08b37a8744252a58766905f29b354a0e611dbdf4 Author: Jeff Dike <[EMAIL PROTECTED]> Date: Tue Oct 16 01:27:14 2007 -0700 uml: don't use glibc asm/user.h Stop including asm/user.h from libc - it seems to be disappearing from distros. It's replaced with sys/user.h which defines

[PATCH 4/4] UML - kill subprocesses on exit

2007-11-01 Thread Jeff Dike
commit 5161a303c94d812dc854278b58faa1885a669a48 Author: Lepton Wu <[EMAIL PROTECTED]> Date: Tue Oct 16 01:27:35 2007 -0700 uml: definitively kill subprocesses on panic In a stock 2.6.22.6 kernel, poweroff a user mode linux guest (2.6.22.6 running in skas0 mode) will halt the ho

[PATCH 1/4] UML - Stop using libc asm/page.h

2007-11-01 Thread Jeff Dike
commit cd56e0945db8a5cd3176dcff2319f9e0c96bcb50 Author: Jeff Dike <[EMAIL PROTECTED]> Date: Tue Oct 16 01:26:44 2007 -0700 uml: stop using libc asm/page.h Remove includes of asm/page.h from libc code. This header seems to be disappearing, and UML doesn't make much use of it any

[PATCH 2/4] UML - Fix kernel vs libc symbols clash

2007-11-01 Thread Jeff Dike
commit 2a772652c3971745228a2e40e6575ae594c88365 Author: Jeff Dike <[EMAIL PROTECTED]> Date: Tue Oct 16 01:26:45 2007 -0700 uml: fix an IPV6 libc vs kernel symbol clash On some systems, with IPV6 configured, there is a clash between the kernel's in6addr_any and the one in libc.

Re: [patch] PID namespace design bug, workaround

2007-11-01 Thread Ingo Molnar
* Theodore Tso <[EMAIL PROTECTED]> wrote: > On Thu, Nov 01, 2007 at 04:05:37PM +0100, Ingo Molnar wrote: > > + if (clone_flags & CLONE_NEWPID) > > + return -ENOSYS; > > I'd use EINVAL instead of ENOSYS... ok, updated patch below. Ingo > From: Ingo Molnar <[

Re: [PATCH] 2.6.23: Filesystem capabilities 0.17

2007-11-01 Thread Olaf Dietsche
"Serge E. Hallyn" <[EMAIL PROTECTED]> writes: > Quoting Olaf Dietsche ([EMAIL PROTECTED]): >> This patch implements filesystem capabilities. It allows to >> run privileged executables without the need for suid root. >> >> Changes: >> - updated to 2.6.23 >> - fix const correctness >> - fix securee

Re: per-bdi-throttling: synchronous writepage doesn't work correctly

2007-11-01 Thread Peter Zijlstra
On Thu, 2007-11-01 at 20:19 +0100, Miklos Szeredi wrote: > > > > > > See the file "Locking" for more details. > > > > > > > > > The "should set PG_Writeback" bit threw me off I guess. > > > > Hmm, set_page_writeback() is also the one clearing the radix tree dirty > > tag. So if that is n

Re: [PATCH resend] proc: Fix proc_kill_inodes to kill dentries on all proc superblocks

2007-11-01 Thread sukadev
Pavel Emelianov [EMAIL PROTECTED] wrote: | Eric W. Biederman wrote: | > It appears we overlooked support for removing generic proc files | > when we added support for multiple proc super blocks. Handle | > that now. | > | > Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> | | AFAIS this is j

Re: [patch 1/4] x86: FIFO ticket spinlocks

2007-11-01 Thread Chuck Ebbert
On 11/01/2007 10:03 AM, Nick Piggin wrote: [edited to show the resulting code] > + __asm__ __volatile__ ( > + LOCK_PREFIX "xaddw %w0, %1\n" > + "1:\t" > + "cmpb %h0, %b0\n\t" > + "je 2f\n\t" > + "rep ; nop\n\t" > + "movb

[git patches] net driver fixes

2007-11-01 Thread Jeff Garzik
Please pull from 'upstream-linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git upstream-linus to receive the following updates: drivers/net/Kconfig |4 +--- drivers/net/fec_mpc52xx.c |4 ++-- drivers/net/myri10ge/myri10ge.c |6 +++--

Re: [linux-usb-devel] ti_usb_3410_5052 breakage in 2.6.24-rc1

2007-11-01 Thread Alan Stern
On Thu, 1 Nov 2007, Steven King wrote: > > The real question is why 2.6.24-rc1 doesn't like the second > > configuration descriptor. To answer it, you should see what shows up > > in the dmesg log when you first plug in the device on a kernel with > > CONFIG_USB_DEBUG enabled. > > ?!? As I wrote

Re: [PATCH] x86: check boundary in count/setup_resource called by get_current_resources

2007-11-01 Thread Gary Hade
On Thu, Nov 01, 2007 at 11:06:18AM -0700, Yinghai Lu wrote: > Andrew Morton wrote: > >On Thu, 01 Nov 2007 01:20:29 -0700 Yinghai Lu <[EMAIL PROTECTED]> wrote: > > > >>[PATCH] x86: check boundary in count/setup_resource called by > >>get_current_resources > >> > >>need to check info->res_num less t

Re: [PATCH] file capabilities: allow sigcont within session (v2)

2007-11-01 Thread Theodore Tso
On Thu, Nov 01, 2007 at 08:47:01AM -0500, Serge E. Hallyn wrote: > Egads. I knew I should've just kept that part out of it for the first > patch... > > New patch on top of previous one is appended. I assume you'll just collapse the two patches together before you submit them? I've been distract

Re: [linux-usb-devel] [PATCH 1/2] usb_gigaset: suspend support

2007-11-01 Thread Tilman Schmidt
Am 30.10.2007 09:52 schrieb Oliver Neukum: > Am Montag 29 Oktober 2007 schrieb Tilman Schmidt: >> --- a/drivers/isdn/gigaset/usb-gigaset.c 2007-10-23 01:48:12.0 >> +0200 >> +++ b/drivers/isdn/gigaset/usb-gigaset.c 2007-10-24 00:47:32.0 >> +0200 >> @@ -847,6 +859,63 @@ sta

Re: sata_nv: ata2 errors

2007-11-01 Thread Andrew Morton
On Thu, 25 Oct 2007 13:18:50 +0530 "Amit Shah" <[EMAIL PROTECTED]> wrote: > On 2.6.24-rc1 (AMD Opteron 1216), my sata_nv driver produces this > output on bootup: > > ata2: EH in SWNCQ mode,QC:qc_active 0x1 sactive 0x1 > ata2: SWNCQ:qc_active 0x1 defer_bits 0x0 last_issue_tag 0x0 > ata2: ATA_REG 0

Re: irq 21: nobody cared 2.6.24-rc1

2007-11-01 Thread Andrew Morton
On Thu, 25 Oct 2007 10:45:36 +0200 Bongani Hlope <[EMAIL PROTECTED]> wrote: > Booting with irqpoll works > > ls /proc/irq/21/ (with irqpoll) > ehci_hcd:usb1/ smp_affinity uhci_hcd:usb2/ uhci_hcd:usb3/ uhci_hcd:usb4/ > > irq 21: nobody cared (try booting with the "irqpoll" option) > > Call

Re: Quad core CPU detected but shows as single core in 2.6.23.1

2007-11-01 Thread Andrew Morton
On Thu, 25 Oct 2007 10:50:50 -0400 "Zurk Tech" <[EMAIL PROTECTED]> wrote: > duh. never mind. i had an attack of the stupids and enabled GART error > reporting in the bios menu when i installed the motherboard. fixed > now. shows all 4 and 8 on the other one. Confused. Why should that cause the k

asus-laptop module

2007-11-01 Thread Stephen Clark
Hi List, When the asus-laptop module is loaded it automatically turns on my wireless led light irregardless of the whether or not the my wireless is up or not. I had previously been using the out of kernel asus-laptop module, which no longer compiles because of missing some structure definitio

Re: SPI doesn't detect first dataflash (CS0) on a AT91rm9200ek with kernel 2.6.23.1

2007-11-01 Thread David Brownell
> Could you help me ? Several people sent suggestions on this topic when you asked this question on linux-arm-kernel last week (which was BTW a far more appropriate list for this). I notice you didn't follow up on those suggestions in any way. Before you ask again, it'd be polite to try followin

Re: sata_nv: ata2 errors

2007-11-01 Thread Jeff Garzik
Andrew Morton wrote: On Thu, 25 Oct 2007 13:18:50 +0530 "Amit Shah" <[EMAIL PROTECTED]> wrote: On 2.6.24-rc1 (AMD Opteron 1216), my sata_nv driver produces this output on bootup: ata2: EH in SWNCQ mode,QC:qc_active 0x1 sactive 0x1 ata2: SWNCQ:qc_active 0x1 defer_bits 0x0 last_issue_tag 0x0 ata

2.6.23: IPv6 router advertisments missed by kernel

2007-11-01 Thread Bruno Prémont
I'm seeing unexpected behavior on my laptop since I updated kernel to 2.6.23.1 from 2.6.22.1. My setup: Cisco Router <--- [2 vlans] -> Laptop On the link two VLANs are active, native vlan is not used. Laptop nic is: Tigon3 [partno(BCM95751m) rev 4201 PHY(5750)] (PCI Express) 10/100/1

Re: IRQ off latency of printk is very high

2007-11-01 Thread Pavel Machek
Hi! > > > It seems draconian to drain the entire buffer with ints disabled. > > > Is it possible to break this up and send out smaller chunks > > > at a time? Maybe by putting a chunk loop in release_console_sem()? > > > > Well, I believe someone got > > > > DDetetccctted ed 113223 HHzz CPUCPU

Re: [PATCH/RFC] x86: unify Kconfig files

2007-11-01 Thread Sam Ravnborg
On Wed, Oct 31, 2007 at 10:55:01PM +0100, Sam Ravnborg wrote: > It has been requested that we should let x86 behave like > other architectures so we at config time decide for 32 or 64 bit. > The challenge here is to mere the Kconfig files and I have done > an attempt to do so. Just a heads up... I

Re: build #337 failed for 2.6.24-rc1-gb1d08ac In function `usbnet_set_settings':

2007-11-01 Thread Randy Dunlap
On Thu, 1 Nov 2007 20:24:54 +0100 Toralf Förster wrote: [adding netdev] > Hello, > > the build with the attached .config failed, make ends with: > ... > CC arch/x86/lib/usercopy_32.o > AR arch/x86/lib/lib.a > GEN .version > CHK include/linux/compile.h > UPD includ

Re: [patch] kvm: fix !SMP build error

2007-11-01 Thread Avi Kivity
Ingo Molnar wrote: * Avi Kivity <[EMAIL PROTECTED]> wrote: I thought you were handling it, as they aren't part of kvm proper. But I can send them, sure. i've got them in my queue already so i'll send them in the next scheduler batch, ok? Thanks. -- Any sufficiently difficult b

Re: [PATCH/RFC] x86: unify Kconfig files

2007-11-01 Thread H. Peter Anvin
Sam Ravnborg wrote: On Wed, Oct 31, 2007 at 10:55:01PM +0100, Sam Ravnborg wrote: It has been requested that we should let x86 behave like other architectures so we at config time decide for 32 or 64 bit. The challenge here is to mere the Kconfig files and I have done an attempt to do so. Just

Re: [patch 0/7] [RFC] SLUB: Improve allocpercpu to reduce per cpu access overhead

2007-11-01 Thread David Miller
From: Christoph Lameter <[EMAIL PROTECTED]> Date: Thu, 1 Nov 2007 06:01:14 -0700 (PDT) > On Thu, 1 Nov 2007, David Miller wrote: > > > IA64 seems to use it universally for every __get_cpu_var() > > access, so maybe it works out somehow :-))) > > IA64 does not do that. It addds the local cpu offs

Re: irq 21: nobody cared 2.6.24-rc1

2007-11-01 Thread Theodore Tso
On Thu, Nov 01, 2007 at 01:32:38PM -0700, Andrew Morton wrote: > On Thu, 25 Oct 2007 10:45:36 +0200 > Bongani Hlope <[EMAIL PROTECTED]> wrote: > > > Booting with irqpoll works > > > > ls /proc/irq/21/ (with irqpoll) > > ehci_hcd:usb1/ smp_affinity uhci_hcd:usb2/ uhci_hcd:usb3/ uhci_hcd:usb4/

Re: [patch 0/7] [RFC] SLUB: Improve allocpercpu to reduce per cpu access overhead

2007-11-01 Thread David Miller
From: Christoph Lameter <[EMAIL PROTECTED]> Date: Thu, 1 Nov 2007 05:57:12 -0700 (PDT) > That is basically what IA64 is doing but it not usable because you would > have addresses that mean different things on different cpus. List head > for example require back pointers. If you put a listhead int

Re: [patch 0/7] [RFC] SLUB: Improve allocpercpu to reduce per cpu access overhead

2007-11-01 Thread David Miller
From: Christoph Lameter <[EMAIL PROTECTED]> Date: Thu, 1 Nov 2007 06:03:44 -0700 (PDT) > In order to make it truly dynamic we would have to virtually map the > area. vmap? But that reduces performance. But it would still be faster than the double-indirection we do now, right? - To unsubscribe fr

Re: expected behavior of PF_PACKET on NETIF_F_HW_VLAN_RX device?

2007-11-01 Thread David Miller
From: Ben Greear <[EMAIL PROTECTED]> Date: Thu, 01 Nov 2007 08:04:31 -0700 > David Miller wrote: > > The hardware has stripped the VLAN header completely and has not > > provided it to us at all. > > > Do the NICs not save the QoS bits in the VLAN header anywhere that we could > use to reconsti

[PATCH 2/7] d_path: kerneldoc cleanup

2007-11-01 Thread Jan Blunck
Move and update d_path() kernel API documentation. Signed-off-by: Jan Blunck <[EMAIL PROTECTED]> --- fs/dcache.c | 35 --- 1 file changed, 16 insertions(+), 19 deletions(-) Index: b/fs/dcache.c ===

[PATCH 1/7] One less parameter to __d_path

2007-11-01 Thread Jan Blunck
All callers to __d_path pass the dentry and vfsmount of a struct path to __d_path. Pass the struct path directly, instead. Signed-off-by: Andreas Gruenbacher <[EMAIL PROTECTED]> Signed-off-by: Jan Blunck <[EMAIL PROTECTED]> --- fs/dcache.c | 12 +--- 1 file changed, 5 insertions(+), 7 d

[PATCH 0/7] struct path related cleanups of d_path() code

2007-11-01 Thread Jan Blunck
Here are some more struct path cleanups. This patch series changes d_path() to take a struct path argument. The existing users are changed to give struct path more deeply into the call chain. In some structures I need to replace existing pairs and embed a struct path instead. Andreas, since JJ j

[PATCH 4/7] d_path: Make proc_get_link() use a struct path argument

2007-11-01 Thread Jan Blunck
proc_get_link() is always called with a dentry and a vfsmount from a struct path. Make proc_get_link() take it directly as an argument. Signed-off-by: Jan Blunck <[EMAIL PROTECTED]> --- fs/proc/base.c | 60 fs/proc/internal.h |2

[PATCH 6/7] d_path: Make d_path() use a struct path

2007-11-01 Thread Jan Blunck
d_path() is used on a pair. Lets use a struct path to reflect this. Signed-off-by: Jan Blunck <[EMAIL PROTECTED]> --- drivers/md/bitmap.c |8 +--- drivers/usb/gadget/file_storage.c |3 +-- fs/compat_ioctl.c |2 +- fs/dcache.c |

[PATCH 5/7] d_path: Make get_dcookie() use a struct path argument

2007-11-01 Thread Jan Blunck
get_dcookie() is always called with a dentry and a vfsmount from a struct path. Make get_dcookie() take it directly as an argument. Signed-off-by: Jan Blunck <[EMAIL PROTECTED]> --- arch/powerpc/oprofile/cell/spu_task_sync.c | 15 +- drivers/oprofile/buffer_sync.c | 21

[PATCH 3/7] d_path: Use struct path in struct avc_audit_data

2007-11-01 Thread Jan Blunck
audit_log_d_path() is a d_path() wrapper that is used by the audit code. To use a struct path in audit_log_d_path() I need to embed it into struct avc_audit_data. Signed-off-by: Jan Blunck <[EMAIL PROTECTED]> --- include/linux/audit.h |5 ++--- kernel/audit.c | 12 +

[PATCH 7/7] Use struct path in struct svc_export

2007-11-01 Thread Jan Blunck
I'm embedding struct path into struct svc_export. Signed-off-by: Jan Blunck <[EMAIL PROTECTED]> --- fs/nfsd/export.c| 69 +--- fs/nfsd/nfs3proc.c |2 - fs/nfsd/nfs3xdr.c |4 +- fs/nfsd/nfs4proc.c |4 +-

Re: expected behavior of PF_PACKET on NETIF_F_HW_VLAN_RX device?

2007-11-01 Thread Dave Johnson
Ben Greear writes: > We should also define what a NIC should do with VLANs it doesn't > explicitly know about. I think it should pass them up the stack > with VLAN tag intact, but again, perhaps there are reasons not to do > that? Unless the device also supports NETIF_F_HW_VLAN_FILTER, it has no

Re: [PATCH 7/7] Use struct path in struct svc_export

2007-11-01 Thread J. Bruce Fields
On Mon, Oct 29, 2007 at 01:41:27PM +0100, Jan Blunck wrote: > I'm embedding struct path into struct svc_export. Fine by me (For what it's worth: Acked-by: J. Bruce Fields <[EMAIL PROTECTED]> ) --b. > > Signed-off-by: Jan Blunck <[EMAIL PROTECTED]> > --- > fs/nfsd/export.c|

SC1200 failure in 2.6.23 and 2.6.24-rc1-git10

2007-11-01 Thread Denys
Hi I tried to run WRAP board (exact model PC Engines WRAP.2C) with kernels 2.6.23 and 2.6.24. But seems driver is not functional with some old CF cards, and seems have some issues even with new. As soon as i never had running system here, i have only grub and kernel there, so not much things i

Re: expected behavior of PF_PACKET on NETIF_F_HW_VLAN_RX device?

2007-11-01 Thread Rick Jones
The code in AF_PACKET should fix the skb before passing to user space so that there is no difference between accel and non-accel hardware. Internal choices shouldn't leak to user space. Ditto, the receive checksum offload should be fixed up as well. yep. bad csum on tx packets as reported by

Re: Abit F-190HD Onboard rlt8169 Ethernet Controller

2007-11-01 Thread Francois Romieu
Josh Logan <[EMAIL PROTECTED]> : [...] > I have had this board for a few months as well and I have needed to > patch the driver to use 0x0001 as well. Ok. Can people give the patch below a try before I submit it to Jeff ? From: Ciaran McCreesh <[EMAIL PROTECTED]> Date: Thu, 1 Nov 2007 22:48:15

Re: [PATCH] 2.6.23: Filesystem capabilities 0.17

2007-11-01 Thread Jan Kara
On Thu 01-11-07 20:49:32, Olaf Dietsche wrote: > Jan Kara <[EMAIL PROTECTED]> writes: > > >> This patch implements filesystem capabilities. It allows to > >> run privileged executables without the need for suid root. > > Hmm, is there some "design document" so that one does not have to poke > >

Re: expected behavior of PF_PACKET on NETIF_F_HW_VLAN_RX device?

2007-11-01 Thread David Miller
From: Dave Johnson <[EMAIL PROTECTED]> Date: Thu, 1 Nov 2007 17:36:22 -0400 > bad csum on tx packets as reported by tcpdump is also an issue. We provide a tag to userspace that tcpdump should use to see that the HW is going to checksum the packet, and therefore it should elide trying to verify th

Re: expected behavior of PF_PACKET on NETIF_F_HW_VLAN_RX device?

2007-11-01 Thread David Miller
From: Rick Jones <[EMAIL PROTECTED]> Date: Thu, 01 Nov 2007 14:48:45 -0700 > One could I suppose try to ammend the information passed to allow > tcpdump to say "oh, this was a tx packet on the same machine on > which I am tracing so don't worry about checksum mismatch" We do this already! - To u

Re: expected behavior of PF_PACKET on NETIF_F_HW_VLAN_RX device?

2007-11-01 Thread Rick Jones
David Miller wrote: From: Rick Jones <[EMAIL PROTECTED]> Date: Thu, 01 Nov 2007 14:48:45 -0700 One could I suppose try to ammend the information passed to allow tcpdump to say "oh, this was a tx packet on the same machine on which I am tracing so don't worry about checksum mismatch" We do t

SC1200 failure in 2.6.23 and 2.6.24-rc1-git10

2007-11-01 Thread Denys
Finally i got full DMESG with 1GB card till end. Seems not readable too. Linux version 2.6.24-rc1-git10-embedded ([EMAIL PROTECTED]) (gcc version 4.1.2 (Gentoo 4.1.2 p1.0.1)) #1 Thu Nov 1 23:12:53 EET 2007 BIOS-provided physical RAM map: BIOS-e801: - 0009f000 (usable) B

Re: expected behavior of PF_PACKET on NETIF_F_HW_VLAN_RX device?

2007-11-01 Thread David Miller
From: Rick Jones <[EMAIL PROTECTED]> Date: Thu, 01 Nov 2007 15:04:12 -0700 > David Miller wrote: > > From: Rick Jones <[EMAIL PROTECTED]> > > Date: Thu, 01 Nov 2007 14:48:45 -0700 > > > > > >>One could I suppose try to ammend the information passed to allow > >>tcpdump to say "oh, this was a tx

Re: [patch 0/7] [RFC] SLUB: Improve allocpercpu to reduce per cpu access overhead

2007-11-01 Thread Christoph Lameter
On Thu, 1 Nov 2007, David Miller wrote: > The remaining issue with accessing per-cpu areas at multiple virtual > addresses is D-cache aliasing. But that is not an issue for physicallly mapped caches. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a messa

Re: [patch 0/7] [RFC] SLUB: Improve allocpercpu to reduce per cpu access overhead

2007-11-01 Thread David Miller
From: Christoph Lameter <[EMAIL PROTECTED]> Date: Thu, 1 Nov 2007 15:11:41 -0700 (PDT) > On Thu, 1 Nov 2007, David Miller wrote: > > > The remaining issue with accessing per-cpu areas at multiple virtual > > addresses is D-cache aliasing. > > But that is not an issue for physicallly mapped cache

Re: [PATCH 1/3] debloat aic7xxx and aic79xx drivers

2007-11-01 Thread Matthew Wilcox
On Sun, Oct 14, 2007 at 04:00:10PM +0100, Denys Vlasenko wrote: > Deinlines and moves big functions from .h to .c files. > Adds prototypes for ahc_lookup_scb and ahd_lookup_scb to .h files. Adds trailing whitespace. .dotest/patch:216: * We also set the full residual flag which the Adds trai

Re: [patch 0/7] [RFC] SLUB: Improve allocpercpu to reduce per cpu access overhead

2007-11-01 Thread Christoph Lameter
On Thu, 1 Nov 2007, David Miller wrote: > From: Christoph Lameter <[EMAIL PROTECTED]> > Date: Thu, 1 Nov 2007 06:03:44 -0700 (PDT) > > > In order to make it truly dynamic we would have to virtually map the > > area. vmap? But that reduces performance. > > But it would still be faster than the d

Re: [PATCH 3/3] debloat aic7xxx and aic79xx drivers

2007-11-01 Thread Matthew Wilcox
On Sun, Oct 14, 2007 at 04:02:15PM +0100, Denys Vlasenko wrote: > Adds more consts error: patch failed: drivers/scsi/aic7xxx/aic79xx.h:1328 error: drivers/scsi/aic7xxx/aic79xx.h: patch does not apply error: patch failed: drivers/scsi/aic7xxx/aic7xxx.h:1145 error: drivers/scsi/aic7xxx/aic7xxx.h: pa

Re: [PATCH/RFC] eradicate bashisms in scripts/patch-kernel

2007-11-01 Thread Andreas Mohr
Hi, On Thu, Nov 01, 2007 at 08:24:57AM -0700, Randy Dunlap wrote: > On Thu, 1 Nov 2007 13:11:33 +0100 Andreas Mohr wrote: > > I'll think a bit more about these couple changed places (and whether > > this still truly works as intended) and mail a patch then. > > > > (and a big NOTE: I'm no POSIX v

Re: [patch 0/7] [RFC] SLUB: Improve allocpercpu to reduce per cpu access overhead

2007-11-01 Thread Christoph Lameter
On Thu, 1 Nov 2007, David Miller wrote: > From: Christoph Lameter <[EMAIL PROTECTED]> > Date: Thu, 1 Nov 2007 15:11:41 -0700 (PDT) > > > On Thu, 1 Nov 2007, David Miller wrote: > > > > > The remaining issue with accessing per-cpu areas at multiple virtual > > > addresses is D-cache aliasing. > >

Re: [2.6 patch] video/sis/: fix negative array index

2007-11-01 Thread Andrew Morton
On Sat, 27 Oct 2007 16:19:46 +0200 Adrian Bunk <[EMAIL PROTECTED]> wrote: > This patch fixes the possible usage of a negative value as an array > index spotted by the Coverity checker. > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> > > --- > > drivers/video/sis/sis_main.c |3 ++- > 1

Re: IRQ off latency of printk is very high

2007-11-01 Thread Mathieu Desnoyers
* Pavel Machek ([EMAIL PROTECTED]) wrote: > Hi! > > > > > It seems draconian to drain the entire buffer with ints disabled. > > > > Is it possible to break this up and send out smaller chunks > > > > at a time? Maybe by putting a chunk loop in release_console_sem()? > > > > > > Well, I believe s

Re: [2.6 patch] video/sis/: fix negative array index

2007-11-01 Thread Andrew Morton
On Sat, 27 Oct 2007 16:19:46 +0200 Adrian Bunk <[EMAIL PROTECTED]> wrote: > --- a/drivers/video/sis/sis_main.c > +++ b/drivers/video/sis/sis_main.c > @@ -1245,24 +1245,25 @@ sisfb_do_set_var(struct fb_var_screeninfo *var, int > isactive, struct fb_info *in > ivideo->sisfb_mode_idx++

Re: [PATCH] 2.6.23: Filesystem capabilities 0.17

2007-11-01 Thread Olaf Dietsche
Jan Kara <[EMAIL PROTECTED]> writes: > On Thu 01-11-07 20:49:32, Olaf Dietsche wrote: >> Jan Kara <[EMAIL PROTECTED]> writes: >> >> >> This patch implements filesystem capabilities. It allows to >> >> run privileged executables without the need for suid root. >> > Hmm, is there some "design doc

Differences in bitops argument types

2007-11-01 Thread Jan Kara
Hello, I've just found out that operations like constant_test_bit() take pointer of different types on different architectures. In particular, x86_64, blackfin and frv take void * while i386, s390 and m68k take unsigned long *. Is this intended difference? Wouldn't using void * everywhere be m

Re: [PATCH 3/3] debloat aic7xxx and aic79xx drivers

2007-11-01 Thread Randy Dunlap
On Thu, 1 Nov 2007 16:16:04 -0600 Matthew Wilcox wrote: > On Sun, Oct 14, 2007 at 04:02:15PM +0100, Denys Vlasenko wrote: > > Adds more consts > > error: patch failed: drivers/scsi/aic7xxx/aic79xx.h:1328 > error: drivers/scsi/aic7xxx/aic79xx.h: patch does not apply > error: patch failed: drivers/

[2.6 patch] let USB_USBNET always select MII

2007-11-01 Thread Adrian Bunk
All this USB_USBNET_MII trickery is simply not worth it considering how few code it saves. As a side effect, this also fixes the following compile error reported by Toralf Förster: <-- snip --> ... LD .tmp_vmlinux1 drivers/built-in.o: In function `usbnet_set_settings': (.text+0xf1876)

Re: [PATCH] PCMCIA: prevent auto insert during resume.

2007-11-01 Thread Rafael J. Wysocki
On Thursday, 1 November 2007 19:56, Russell King wrote: > On Thu, Nov 01, 2007 at 06:37:41PM +, Russell King wrote: > > On Thu, Nov 01, 2007 at 03:53:59PM +0100, Rodolfo Giometti wrote: > > > On Mon, Oct 29, 2007 at 07:24:15PM +, Pavel Machek wrote: > > > > On Fri 2007-10-26 19:18:57, Rodol

Re: [IRDA] IRNET: Fix build when TCGETS2 is defined.

2007-11-01 Thread Alan Cox
On Thu, 1 Nov 2007 19:59:25 GMT Linux Kernel Mailing List wrote: > Gitweb: > http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=49259d34c52df6be482fefca946debe28ba9a2f6 > Commit: 49259d34c52df6be482fefca946debe28ba9a2f6 > Parent: 3b582cc14c50f71eabf1c3cad

[PATCH] Hibernation: Add PM_RESTORE_PREPARE and PM_POST_RESTORE notifiers

2007-11-01 Thread Rafael J. Wysocki
[Len, please add to the suspend branch.] --- From: Alan Stern <[EMAIL PROTECTED]> This patch (as1006) adds PM_RESTORE_PREPARE and PM_POST_RESTORE notifiers to the PM core, to be used in analogy with the existing PM_HIBERNATION_PREPARE and PM_POST_HIBERNATION notifiers. Signed-off-by: Alan Stern <

Re: + x86-show-cpuinfo-only-for-online-cpus.patch added to -mm tree

2007-11-01 Thread Yinghai Lu
On Nov 1, 2007 12:39 PM, <[EMAIL PROTECTED]> wrote: > > The patch titled > x86: show cpuinfo only for online CPUs > has been added to the -mm tree. Its filename is > x86-show-cpuinfo-only-for-online-cpus.patch > > *** Remember to use Documentation/SubmitChecklist when testing your code

<    1   2   3   4   5   >