[AppArmor 32/45] Enable LSM hooks to distinguish operations on file descriptors from operations on pathnames

2007-10-26 Thread jjohansen
Struct iattr already contains ia_file since commit cc4e69de from Miklos (which is related to commit befc649c). Use this to pass struct file down the setattr hooks. This allows LSMs to distinguish operations on file descriptors from operations on paths. Signed-off-by: Andreas Gruenbacher <[EMAIL P

[AppArmor 33/45] Pass struct file down the inode_*xattr security LSM hooks

2007-10-26 Thread jjohansen
This allows LSMs to also distinguish between file descriptor and path access for the xattr operations. (The other relevant operations are covered by the setattr hook.) Signed-off-by: Andreas Gruenbacher <[EMAIL PROTECTED]> Signed-off-by: John Johansen <[EMAIL PROTECTED]> --- fs/xattr.c

[AppArmor 34/45] Factor out sysctl pathname code

2007-10-26 Thread jjohansen
Convert the selinux sysctl pathname computation code into a standalone function. Signed-off-by: Andreas Gruenbacher <[EMAIL PROTECTED]> Signed-off-by: John Johansen <[EMAIL PROTECTED]> --- include/linux/sysctl.h |2 ++ kernel/sysctl.c | 27 +++ security/s

Re: Linux Security *Module* Framework (Was: LSM conversion to static interface)

2007-10-26 Thread Jan Engelhardt
On Oct 25 2007 19:56, Greg KH wrote: > >I'm trying to compile a list of all known external modules and drivers >and work to get them included in the main kernel tree to help prevent >these kinds of things. If you know of any that are not on the list at: > http://linuxdriverproject.org/twiki

[AppArmor 02/45] Pass struct path down to remove_suid and children

2007-10-26 Thread jjohansen
Required by a later patch that adds a struct vfsmount parameter to notify_change(). Signed-off-by: Tony Jones <[EMAIL PROTECTED]> Signed-off-by: Andreas Gruenbacher <[EMAIL PROTECTED]> Signed-off-by: John Johansen <[EMAIL PROTECTED]> --- fs/ntfs/file.c |2 +- fs/splice.c

[AppArmor 20/45] Pass struct vfsmount to the inode_rename LSM hook

2007-10-26 Thread jjohansen
This is needed for computing pathnames in the AppArmor LSM. Signed-off-by: Tony Jones <[EMAIL PROTECTED]> Signed-off-by: Andreas Gruenbacher <[EMAIL PROTECTED]> Signed-off-by: John Johansen <[EMAIL PROTECTED]> --- fs/namei.c |6 -- include/linux/security.h | 13 ++

[AppArmor 19/45] Add struct vfsmount parameters to vfs_rename()

2007-10-26 Thread jjohansen
The vfsmount will be passed down to the LSM hook so that LSMs can compute pathnames. Signed-off-by: Tony Jones <[EMAIL PROTECTED]> Signed-off-by: Andreas Gruenbacher <[EMAIL PROTECTED]> Signed-off-by: John Johansen <[EMAIL PROTECTED]> --- fs/ecryptfs/inode.c |7 ++- fs/namei.c |

[AppArmor 17/45] Add a struct vfsmount parameter to vfs_unlink()

2007-10-26 Thread jjohansen
The vfsmount will be passed down to the LSM hook so that LSMs can compute pathnames. Signed-off-by: Tony Jones <[EMAIL PROTECTED]> Signed-off-by: Andreas Gruenbacher <[EMAIL PROTECTED]> Signed-off-by: John Johansen <[EMAIL PROTECTED]> --- fs/ecryptfs/inode.c |3 ++- fs/namei.c|

[AppArmor 12/45] Add struct vfsmount parameters to vfs_link()

2007-10-26 Thread jjohansen
The vfsmount will be passed down to the LSM hook so that LSMs can compute pathnames. Signed-off-by: Tony Jones <[EMAIL PROTECTED]> Signed-off-by: Andreas Gruenbacher <[EMAIL PROTECTED]> Signed-off-by: John Johansen <[EMAIL PROTECTED]> --- fs/ecryptfs/inode.c |9 +++-- fs/namei.c

[AppArmor 11/45] Pass struct vfsmount to the inode_readlink LSM hook

2007-10-26 Thread jjohansen
This is needed for computing pathnames in the AppArmor LSM. Signed-off-by: Tony Jones <[EMAIL PROTECTED]> Signed-off-by: Andreas Gruenbacher <[EMAIL PROTECTED]> Signed-off-by: John Johansen <[EMAIL PROTECTED]> --- fs/stat.c|2 +- include/linux/security.h |8 +--- secu

[AppArmor 10/45] Pass struct vfsmount to the inode_symlink LSM hook

2007-10-26 Thread jjohansen
This is needed for computing pathnames in the AppArmor LSM. Signed-off-by: Tony Jones <[EMAIL PROTECTED]> Signed-off-by: Andreas Gruenbacher <[EMAIL PROTECTED]> Signed-off-by: John Johansen <[EMAIL PROTECTED]> --- fs/namei.c |2 +- include/linux/security.h |8 +--- secu

[AppArmor 06/45] Pass struct vfsmount to the inode_mkdir LSM hook

2007-10-26 Thread jjohansen
This is needed for computing pathnames in the AppArmor LSM. Signed-off-by: Tony Jones <[EMAIL PROTECTED]> Signed-off-by: Andreas Gruenbacher <[EMAIL PROTECTED]> Signed-off-by: John Johansen <[EMAIL PROTECTED]> --- fs/namei.c |2 +- include/linux/security.h |8 ++-- secu

[AppArmor 05/45] Add struct vfsmount parameter to vfs_mkdir()

2007-10-26 Thread jjohansen
The vfsmount will be passed down to the LSM hook so that LSMs can compute pathnames. Signed-off-by: Tony Jones <[EMAIL PROTECTED]> Signed-off-by: Andreas Gruenbacher <[EMAIL PROTECTED]> Signed-off-by: John Johansen <[EMAIL PROTECTED]> --- fs/ecryptfs/inode.c |5 - fs/namei.c

[AppArmor 03/45] Add a vfsmount parameter to notify_change()

2007-10-26 Thread jjohansen
The vfsmount parameter must be set appropriately for files visibile outside the kernel. Files that are only used in a filesystem (e.g., reiserfs xattr files) will have a NULL vfsmount. Signed-off-by: Tony Jones <[EMAIL PROTECTED]> Signed-off-by: Andreas Gruenbacher <[EMAIL PROTECTED]> Signed-off-b

[AppArmor 04/45] Pass struct vfsmount to the inode_setattr LSM hook

2007-10-26 Thread jjohansen
This is needed for computing pathnames in the AppArmor LSM. Signed-off-by: Tony Jones <[EMAIL PROTECTED]> Signed-off-by: Andreas Gruenbacher <[EMAIL PROTECTED]> Signed-off-by: John Johansen <[EMAIL PROTECTED]> --- fs/attr.c|4 ++-- include/linux/security.h |8 ++-- se

[AppArmor 07/45] Add a struct vfsmount parameter to vfs_mknod()

2007-10-26 Thread jjohansen
The vfsmount will be passed down to the LSM hook so that LSMs can compute pathnames. Signed-off-by: Tony Jones <[EMAIL PROTECTED]> Signed-off-by: Andreas Gruenbacher <[EMAIL PROTECTED]> Signed-off-by: John Johansen <[EMAIL PROTECTED]> --- fs/ecryptfs/inode.c |5 - fs/namei.c |

Re: [PATCH 5/6] x86: move i386 and x86_64 Kconfig files to x86 directory

2007-10-26 Thread Sam Ravnborg
> > BTW: > why not using Kconfig.x86_32 instead of Kconfig.i386? See scripts/kconfig/Makefile: Here we use (in the x86 case): Kconfig := arch/$(SRCARCH)/Kconfig.$(ARCH) So the "i386" comes from ARCH equals to i386. The advantage is that the patch to kconfig is generic so other arch's can use SR

[AppArmor 08/45] Pass struct vfsmount to the inode_mknod LSM hook

2007-10-26 Thread jjohansen
This is needed for computing pathnames in the AppArmor LSM. Signed-off-by: Tony Jones <[EMAIL PROTECTED]> Signed-off-by: Andreas Gruenbacher <[EMAIL PROTECTED]> Signed-off-by: John Johansen <[EMAIL PROTECTED]> --- fs/namei.c |2 +- include/linux/security.h |7 +-- secur

[AppArmor 09/45] Add a struct vfsmount parameter to vfs_symlink()

2007-10-26 Thread jjohansen
The vfsmount will be passed down to the LSM hook so that LSMs can compute pathnames. Signed-off-by: Tony Jones <[EMAIL PROTECTED]> Signed-off-by: Andreas Gruenbacher <[EMAIL PROTECTED]> Signed-off-by: John Johansen <[EMAIL PROTECTED]> --- fs/ecryptfs/inode.c |4 +++- fs/namei.c |

[AppArmor 13/45] Pass the struct vfsmounts to the inode_link LSM hook

2007-10-26 Thread jjohansen
This is needed for computing pathnames in the AppArmor LSM. Signed-off-by: Tony Jones <[EMAIL PROTECTED]> Signed-off-by: Andreas Gruenbacher <[EMAIL PROTECTED]> Signed-off-by: John Johansen <[EMAIL PROTECTED]> --- fs/namei.c |3 ++- include/linux/security.h | 16 +++--

[AppArmor 14/45] Add a struct vfsmount parameter to vfs_rmdir()

2007-10-26 Thread jjohansen
The vfsmount will be passed down to the LSM hook so that LSMs can compute pathnames. Signed-off-by: Tony Jones <[EMAIL PROTECTED]> Signed-off-by: Andreas Gruenbacher <[EMAIL PROTECTED]> Signed-off-by: John Johansen <[EMAIL PROTECTED]> --- fs/ecryptfs/inode.c |4 +++- fs/namei.c

[AppArmor 15/45] Pass struct vfsmount to the inode_rmdir LSM hook

2007-10-26 Thread jjohansen
This is needed for computing pathnames in the AppArmor LSM. Signed-off-by: Tony Jones <[EMAIL PROTECTED]> Signed-off-by: Andreas Gruenbacher <[EMAIL PROTECTED]> Signed-off-by: John Johansen <[EMAIL PROTECTED]> --- fs/namei.c |2 +- include/linux/security.h | 10 +++--- se

[AppArmor 16/45] Call lsm hook before unhashing dentry in vfs_rmdir()

2007-10-26 Thread jjohansen
If we unhash the dentry before calling the security_inode_rmdir hook, we cannot compute the file's pathname in the hook anymore. AppArmor needs to know the filename in order to decide whether a file may be deleted, though. Signed-off-by: John Johansen <[EMAIL PROTECTED]> Signed-off-by: Andreas Gru

[AppArmor 18/45] Pass struct vfsmount to the inode_unlink LSM hook

2007-10-26 Thread jjohansen
This is needed for computing pathnames in the AppArmor LSM. Signed-off-by: Tony Jones <[EMAIL PROTECTED]> Signed-off-by: Andreas Gruenbacher <[EMAIL PROTECTED]> Signed-off-by: John Johansen <[EMAIL PROTECTED]> --- fs/namei.c |2 +- include/linux/security.h | 10 +++--- se

[AppArmor 21/45] Add a struct vfsmount parameter to vfs_setxattr()

2007-10-26 Thread jjohansen
The vfsmount will be passed down to the LSM hook so that LSMs can compute pathnames. Signed-off-by: Tony Jones <[EMAIL PROTECTED]> Signed-off-by: Andreas Gruenbacher <[EMAIL PROTECTED]> Signed-off-by: John Johansen <[EMAIL PROTECTED]> --- fs/nfsd/vfs.c | 16 +++- fs/xattr.c

[AppArmor 22/45] Pass struct vfsmount to the inode_setxattr LSM hook

2007-10-26 Thread jjohansen
This is needed for computing pathnames in the AppArmor LSM. Signed-off-by: Tony Jones <[EMAIL PROTECTED]> Signed-off-by: Andreas Gruenbacher <[EMAIL PROTECTED]> Signed-off-by: John Johansen <[EMAIL PROTECTED]> --- fs/xattr.c |4 ++-- include/linux/security.h | 35

[AppArmor 23/45] Add a struct vfsmount parameter to vfs_getxattr()

2007-10-26 Thread jjohansen
The vfsmount will be passed down to the LSM hook so that LSMs can compute pathnames. Signed-off-by: Tony Jones <[EMAIL PROTECTED]> Signed-off-by: Andreas Gruenbacher <[EMAIL PROTECTED]> Signed-off-by: John Johansen <[EMAIL PROTECTED]> --- fs/nfsd/nfs4xdr.c |2 +- fs/nfsd/vfs.c

[AppArmor 24/45] Pass struct vfsmount to the inode_getxattr LSM hook

2007-10-26 Thread jjohansen
This is needed for computing pathnames in the AppArmor LSM. Signed-off-by: Tony Jones <[EMAIL PROTECTED]> Signed-off-by: Andreas Gruenbacher <[EMAIL PROTECTED]> Signed-off-by: John Johansen <[EMAIL PROTECTED]> --- fs/xattr.c |2 +- include/linux/security.h | 11 +++ s

[AppArmor 25/45] Add a struct vfsmount parameter to vfs_listxattr()

2007-10-26 Thread jjohansen
The vfsmount will be passed down to the LSM hook so that LSMs can compute pathnames. Signed-off-by: Tony Jones <[EMAIL PROTECTED]> Signed-off-by: Andreas Gruenbacher <[EMAIL PROTECTED]> Signed-off-by: John Johansen <[EMAIL PROTECTED]> --- fs/xattr.c| 25 ++--- i

[AppArmor 28/45] Pass struct vfsmount to the inode_removexattr LSM hook

2007-10-26 Thread jjohansen
This is needed for computing pathnames in the AppArmor LSM. Signed-off-by: Tony Jones <[EMAIL PROTECTED]> Signed-off-by: Andreas Gruenbacher <[EMAIL PROTECTED]> Signed-off-by: John Johansen <[EMAIL PROTECTED]> --- fs/xattr.c |2 +- include/linux/security.h | 14 +-

[AppArmor 31/45] Add d_namespace_path() to compute namespace relative pathnames

2007-10-26 Thread jjohansen
In AppArmor, we are interested in pathnames relative to the namespace root. This is the same as d_path() except for the root where the search ends. Add a function for computing the namespace-relative path. Signed-off-by: Andreas Gruenbacher <[EMAIL PROTECTED]> Signed-off-by: John Johansen <[EMAIL

Re: [PATCH 2/2] add SubmittingPatches to Documentation/ja_JP

2007-10-26 Thread YOSHIFUJI Hideaki / 吉藤英明
Hello. Basically okay, but please refer to the original DCO document. Your mailer is broken. You should include "charset" parameter in your multipart. Maybe it is better to prepare a git repository, or attach it as a binary (application/octet-stream). --yoshfuji In article <[EMAIL PROTECTED]>

sysfs: WARNING: at fs/sysfs/dir.c:424 sysfs_add_one()

2007-10-26 Thread Amit Shah
On 2.6.24-rc1, I get this for all my eth interfaces: [ 150.389821] sysfs: duplicate filename 'eth1_rename' can not be created [ 150.389824] WARNING: at fs/sysfs/dir.c:424 sysfs_add_one() [ 150.389826] [ 150.389826] Call Trace: [ 150.389840] [] sysfs_add_one+0xaf/0xf0 [ 150.389844] [] sysfs

sata_nv: MCP51: SWNCQ messages

2007-10-26 Thread Amit Shah
This is what I get even with your libata-dev tree, upstream-linus branch pulled on top of 2.6.24-rc1 [ 22.427990] NFORCE-MCP51: IDE controller (0x10de:0x0265 rev 0xa1) at PCI slot :00:0d.0 [ 22.428006] NFORCE-MCP51: not 100% native mode: will probe irqs later [ 22.428011] NFORCE-MCP51:

[build bug, 2.6.24-rc1] CONFIG_VIDEO_DEV=m & CONFIG_VIDEO_SAA7146_VV=y

2007-10-26 Thread Ingo Molnar
the attached config (generated via make randconfig) fails to build due to the combination of these config entries: CONFIG_VIDEO_DEV=m CONFIG_VIDEO_SAA7146_VV=y i found no obvious Kconfig way to force VIDEO_SAA7146_VV to be modular when VIDEO_DEV is modular - is there a good solution for th

Re: [AppArmor 00/45] AppArmor security module overview

2007-10-26 Thread John Johansen
On Thu, Oct 25, 2007 at 11:40:24PM -0700, [EMAIL PROTECTED] wrote: Sorry this got dropped some how. This submission of the AppArmor security module is based against -mm. Any comments and feedback to improve implementation are appreciated. The patch series consists of five areas: (1) Pass struc

[BUG] panic after umount (biscted)

2007-10-26 Thread Sebastian Siewior
After umount of /dev/md/1 on /mnt/sec type xfs (rw,nosuid,nodev,noatime,nodiratime) I end up with [1] on v2.6.24-rc1. It worked fine with v2.6.23. Bisec came to conclusion that |fd5d806266935179deda1502101624832eacd01f is first bad commit |commit fd5d806266935179deda1502101624832eacd01f |Author

[AppArmor 45/45] Fix file_permission()

2007-10-26 Thread jjohansen
We cannot easily switch from file_permission() to vfs_permission() everywhere, so fix file_permission() to not use a NULL nameidata for the remaining users. Signed-off-by: Andreas Gruenbacher <[EMAIL PROTECTED]> Signed-off-by: John Johansen <[EMAIL PROTECTED]> --- fs/namei.c |8 +++- 1 f

[AppArmor 44/45] Switch to vfs_permission() in sys_fchdir()

2007-10-26 Thread jjohansen
Switch from file_permission() to vfs_permission() in sys_fchdir(): this avoids calling permission() with a NULL nameidata here. Signed-off-by: Andreas Gruenbacher <[EMAIL PROTECTED]> Signed-off-by: John Johansen <[EMAIL PROTECTED]> --- fs/open.c | 16 +++- 1 file changed, 7 inserti

[AppArmor 43/45] Switch to vfs_permission() in do_path_lookup()

2007-10-26 Thread jjohansen
Switch from file_permission() to vfs_permission() in do_path_lookup(): this avoids calling permission() with a NULL nameidata here. Signed-off-by: Andreas Gruenbacher <[EMAIL PROTECTED]> Signed-off-by: John Johansen <[EMAIL PROTECTED]> --- fs/namei.c | 13 ++--- 1 file changed, 6 inser

[AppArmor 41/45] add simple network toggles to apparmor

2007-10-26 Thread jjohansen
Signed-off-by: John Johansen <[EMAIL PROTECTED]> Signed-off-by: Jesse Michael <[EMAIL PROTECTED]> --- security/apparmor/Makefile |7 + security/apparmor/apparmor.h |7 + security/apparmor/lsm.c | 147 ++- security/apparmor/ma

[AppArmor 39/45] AppArmor: Profile loading and manipulation, pathname matching

2007-10-26 Thread jjohansen
Pathname matching, transition table loading, profile loading and manipulation. Signed-off-by: John Johansen <[EMAIL PROTECTED]> Signed-off-by: Andreas Gruenbacher <[EMAIL PROTECTED]> --- security/apparmor/match.c| 273 +++ security/apparmor/match.h| 85 +++ sec

[AppArmor 38/45] AppArmor: Module and LSM hooks

2007-10-26 Thread jjohansen
Module parameters, LSM hooks, initialization and teardown. Signed-off-by: John Johansen <[EMAIL PROTECTED]> Signed-off-by: Andreas Gruenbacher <[EMAIL PROTECTED]> --- security/apparmor/lsm.c | 816 1 file changed, 816 insertions(+) --- /dev/null

[AppArmor 37/45] AppArmor: Main Part

2007-10-26 Thread jjohansen
The underlying functions by which the AppArmor LSM hooks are implemented. Signed-off-by: John Johansen <[EMAIL PROTECTED]> Signed-off-by: Andreas Gruenbacher <[EMAIL PROTECTED]> --- security/apparmor/main.c | 1361 +++ 1 file changed, 1361 insertions(+

[AppArmor 36/45] Export audit subsystem for use by modules

2007-10-26 Thread jjohansen
Update kenel audit range comments to show AppArmor's registered range of 1500-1599. This range used to be reserved for LSPP but LSPP uses the SE Linux range and the range was given to AppArmor. Adds necessary export symbols for audit subsystem routines. Changes audit_log_vformat to be externally v

[AppArmor 35/45] Allow permission functions to tell between parent and leaf checks

2007-10-26 Thread jjohansen
Set the LOOKUP_CONTINUE flag when checking parent permissions. This allows permission functions to tell between parent and leaf checks. Signed-off-by: Andreas Gruenbacher <[EMAIL PROTECTED]> Signed-off-by: John Johansen <[EMAIL PROTECTED]> --- fs/namei.c |6 ++ 1 file changed, 6 insertio

[AppArmor 26/45] Pass struct vfsmount to the inode_listxattr LSM hook

2007-10-26 Thread jjohansen
This is needed for computing pathnames in the AppArmor LSM. Signed-off-by: Tony Jones <[EMAIL PROTECTED]> Signed-off-by: Andreas Gruenbacher <[EMAIL PROTECTED]> Signed-off-by: John Johansen <[EMAIL PROTECTED]> --- fs/xattr.c |2 +- include/linux/security.h |9 + sec

[AppArmor 27/45] Add a struct vfsmount parameter to vfs_removexattr()

2007-10-26 Thread jjohansen
The vfsmount will be passed down to the LSM hook so that LSMs can compute pathnames. Signed-off-by: Tony Jones <[EMAIL PROTECTED]> Signed-off-by: Andreas Gruenbacher <[EMAIL PROTECTED]> Signed-off-by: John Johansen <[EMAIL PROTECTED]> --- fs/nfsd/vfs.c |7 --- fs/xattr.c

[AppArmor 30/45] Make d_path() consistent across mount operations

2007-10-26 Thread jjohansen
The path that __d_path() computes can become slightly inconsistent when it races with mount operations: it grabs the vfsmount_lock when traversing mount points but immediately drops it again, only to re-grab it when it reaches the next mount point. The result is that the filename computed is not a

[AppArmor 29/45] Fix __d_path() for lazy unmounts and make it unambiguous

2007-10-26 Thread jjohansen
First, when __d_path() hits a lazily unmounted mount point, it tries to prepend the name of the lazily unmounted dentry to the path name. It gets this wrong, and also overwrites the slash that separates the name from the following pathname component. This patch fixes that; if a process was in dire

[AppArmor 40/45] AppArmor: all the rest

2007-10-26 Thread jjohansen
All the things that didn't nicely fit in a category on their own: kbuild code, declararions and inline functions, /sys/kernel/security/apparmor filesystem for controlling apparmor from user space, profile list functions, locking documentation, /proc/$pid/task/$tid/attr/current access. Signed-off-b

[AppArmor 42/45] Add AppArmor LSM to security/Makefile

2007-10-26 Thread jjohansen
Signed-off-by: John Johansen <[EMAIL PROTECTED]> Signed-off-by: Andreas Gruenbacher <[EMAIL PROTECTED]> --- security/Kconfig |1 + security/Makefile |1 + security/apparmor/Kconfig | 21 +++-- 3 files changed, 21 insertions(+), 2 deletions(-) --- a/secu

Re: kernel 2.6.23 CFS problem?

2007-10-26 Thread Wang, Baojun
On Friday 26 October 2007 14:47:02, you wrote: > On Fri, 2007-10-26 at 12:45 +0800, WANG Cong wrote: > > On Fri, Oct 26, 2007 at 10:57:45AM +0800, Wang, Baojun wrote: > > >hi, list > > > > > > I've upgraded my kernel from 2.6.22.9 to 2.6.23 when it was out, After > > > that I can't install ELDK 4.

Re: [AppArmor 19/45] Add struct vfsmount parameters to vfs_rename()

2007-10-26 Thread Al Viro
On Thu, Oct 25, 2007 at 11:40:43PM -0700, [EMAIL PROTECTED] wrote: > The vfsmount will be passed down to the LSM hook so that LSMs can compute > pathnames. You know, you really are supposed to understand the code you are modifying... Quiz: what are those vfsmounts and how are they related? Al, ca

Bad TCP checksum error

2007-10-26 Thread Gaurav Aggarwal
Hi, I wrote a program where I am using the nfnetlink and netfilter_queue model to capture the packet. After that I just change the destination address of the packet and insert it back into the ip stack. But after inserting the packet I am getting a bad TCP checksum error. Even I am getting the sam

Re: msync(2) bug(?), returns AOP_WRITEPAGE_ACTIVATE to userland

2007-10-26 Thread Pekka Enberg
Hi, On 10/26/07, Neil Brown <[EMAIL PROTECTED]> wrote: > It seems that the new requirement is that if the address_space > chooses not to write out the page, it should now call SetPageActive(). > If that is the case, I think it should be explicit in the > documentation - please? Agreed. - To unsub

Re: msync(2) bug(?), returns AOP_WRITEPAGE_ACTIVATE to userland

2007-10-26 Thread Pekka Enberg
Hi Hugh, On 10/25/07, Hugh Dickins <[EMAIL PROTECTED]> wrote: > @@ -349,10 +349,6 @@ static pageout_t pageout(struct page *pa > res = mapping->a_ops->writepage(page, &wbc); > if (res < 0) > handle_write_error(mapping, page, res); > -

[PATCH] De-constify sched.h

2007-10-26 Thread Alexey Dobriyan
Linus, please revert commit a8972ccf00b7184a743eb6cd9bc7f3443357910c aka "sched: constify sched.h" or apply the following patch instead. [PATCH] De-constify sched.h 1) Patch doesn't change any code here, so gcc is already smart enough to "feel" constness in such simple functions. 2) There is n

[patch] raid6: generate raid6tables.c with proper style

2007-10-26 Thread Ingo Molnar
Subject: raid6: generate raid6tables.c with proper style From: Ingo Molnar <[EMAIL PROTECTED]> nitpicking from the coding style police: generate a raid6tables.c that does not show up in my editor all red ;-) this also improves the code quality metric of drivers/md/ by a factor of 10:

Re: [lm-sensors] hwmon/f75375s.c: buggy if()

2007-10-26 Thread Jean Delvare
Hi Riku, On Thu, 25 Oct 2007 14:48:14 +0300, Riku Voipio wrote: > On Wed, Oct 24, 2007 at 10:25:29PM -0400, Mark M. Hoffman wrote: > > * Riku Voipio <[EMAIL PROTECTED]> [2007-10-24 14:50:34 +0300]: > > > On Fri, Oct 19, 2007 at 02:37:54PM +0200, Jean Delvare wrote: > > > > Riku, can you please sub

Re: Opteron box and 4Gb memory

2007-10-26 Thread Arne Georg Gleditsch
"J.A. Magallón" <[EMAIL PROTECTED]> writes: > Software Memory Hole > When "Enabled", allows software memory remapping around the memory > hole. Options are Enabled and Disabled. > > Hardware Memory Hole > When "Enabled", allows software memory remapping around the memory > hole. Options are Enabled

Re: [PATCH 1/3 -v4] x86_64 EFI runtime service support: EFI basic runtime service support

2007-10-26 Thread Thomas Gleixner
On Fri, 26 Oct 2007, Huang, Ying wrote: > On Thu, 2007-10-25 at 18:09 +0200, Thomas Gleixner wrote: > > > EFI runtime > > > services initialization are implemented in efi.c. Some x86_64 > > > specifics are worth noting here. On x86_64, parameters passed to UEFI > > > firmware services need to foll

Re: [PATCH 1/3 -v4] x86_64 EFI runtime service support: EFI basic runtime service support

2007-10-26 Thread Thomas Gleixner
On Fri, 26 Oct 2007, Huang, Ying wrote: > On Fri, 2007-10-26 at 10:48 +0200, Thomas Gleixner wrote: > > > EFI uses the Windows x86_64 calling convention. The lin2win may be a > > > more general naming convention that can be used for some other code (the > > > NDISwrapper?) in the future. Do you ag

Re: [PATCH 1/?] Unlock when sn_oemdata can't be extended

2007-10-26 Thread David Miller
From: Roel Kluin <[EMAIL PROTECTED]> Date: Wed, 24 Oct 2007 12:19:52 +0200 > Several unlocking issues > Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> Some of these are wrong, for example: > diff --git a/net/bridge/netfilter/ebtables.c b/net/bridge/netfilter/ebtables.c > index 817169e..

[PATCH] PCMCIA: prevent auto insert during resume.

2007-10-26 Thread Rodolfo Giometti
If a socket has been ejected before sleeping, at resume time it shouldn't be awaked. Signed-off-by: Rodolfo Giometti <[EMAIL PROTECTED]> --- drivers/pcmcia/cs.c |7 +++ 1 files changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/pcmcia/cs.c b/drivers/pcmcia/cs.c index 729e37d..

Re: LSM conversion to static interface

2007-10-26 Thread Samir Bellabes
Jan Engelhardt <[EMAIL PROTECTED]> writes: > Which reminded me of the TuxGuardian LSM[1] - another of the real-world > uses to meet Linus's criteria? ("had examples of their real-world use to > step forward and explain their use") > > In this specific project, LSM is used to collect up calls to

Re: Distributed storage. Move away from char device ioctls.

2007-10-26 Thread Evgeniy Polyakov
Returning back to this, since block based storage, which can act as a shared storage/transport layer, is ready with 5'th release of the DST. My couple of notes on proposed data distribution algorithm in FS. On Sun, Sep 16, 2007 at 03:07:11AM -0400, Kyle Moffett ([EMAIL PROTECTED]) wrote: > >I ac

Re: [PATCH 0/5] Detect hwmon and i2c bus drivers interfering with ACPI Operation Region resources

2007-10-26 Thread Thomas Renninger
On Thu, 2007-10-25 at 21:59 -0600, Bjorn Helgaas wrote: > On Thursday 25 October 2007 4:55:07 pm Thomas Renninger wrote: > > On Thu, 2007-10-25 at 09:06 -0600, Bjorn Helgaas wrote: > > > Isn't the real problem that we have a bunch of drivers that use some of > > > the same resources, and if ACPI re

Re: Possibility of adding -march=native to x86

2007-10-26 Thread Pádraig Brady
Adrian Bunk wrote: > On Thu, Oct 25, 2007 at 09:12:45PM +0100, Michael Lothian wrote: >>> The MPENTIUM4 option does not only set -march=pentium4, it also enables >>> several other options in arch/i386/Kconfig.cpu resulting in better >>> performance. >> How about an autodetect to set the right optio

Re: Disk spindown on rmmod sd_mod

2007-10-26 Thread Tejun Heo
Jan Engelhardt wrote: > I am using 2.6.23-rc9 with pata_sis. `modprobe -r sd_mod`, which I ran > from initramfs, caused all my disks to spindown - sd even told me so. > > I recall there has been talk a while back about whether to spin down > disks on shutdown or not, but I do not think it touche

Re: Linux Security *Module* Framework (Was: LSM conversion to static interface)

2007-10-26 Thread Tilman Schmidt
On Thu, 25 Oct 2007 19:56:47 -0700, Greg KH wrote: > On Fri, Oct 26, 2007 at 01:09:14AM +0200, Tilman Schmidt wrote: >> Am 25.10.2007 00:31 schrieb Adrian Bunk: >> > Generally, the goal is to get external modules included into the kernel. >> > [...] even though it might sound harsh breaking >> > ex

Re: USB: FIx locks and urb->status in adutux

2007-10-26 Thread Vitaliy Ivanov
Greg, On 10/25/07, Greg KH <[EMAIL PROTECTED]> wrote: > Hm, I think I'll wait for Pete and you to agree and send me a final > version before applying anything here :) I'm testing the final patch Pete created with all the notes. Will let you know if there are issues with it. If not it can be appli

Re: history of extratext sections?

2007-10-26 Thread Robin Getz
On Wed 24 Oct 2007 08:36, Robin Getz pondered: > Paul: > > I noticed that when passing a zero address to kallsyms_lookup(), the > kernel thought it was a valid kernel address, even if it was not for the > specific architecture it was running on. > > This was because is_kernel_extratext() was chec

Re: aim7 -30% regression in 2.6.24-rc1

2007-10-26 Thread Peter Zijlstra
On Fri, 2007-10-26 at 17:43 +0800, Zhang, Yanmin wrote: > I tested 2.6.24-rc1 on my x86_64 machine which has 2 quad-core processors. > > Comparing with 2.6.23, aim7 has about -30% regression. I did a bisect and > found > patch > http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=

Re: [PATCH] De-constify sched.h

2007-10-26 Thread David Miller
From: David Rientjes <[EMAIL PROTECTED]> Date: Fri, 26 Oct 2007 02:42:30 -0700 (PDT) > On Fri, 26 Oct 2007, Alexey Dobriyan wrote: > > > 2) There is no such thing as const task_struct. Anyone who think otherwise > >deserves compiler warning. > > > > A 'const struct task_struct *' can be use

Re: [PATCH] IA64, PPC, SPARC: minor irq handler cleanups

2007-10-26 Thread Jeff Garzik
Kumar Gala wrote: On Oct 26, 2007, at 4:40 AM, Jeff Garzik wrote: ia64/sn/kernel/huberror.c: - remove pointless void* cast - add KERN_xxx prefix ia64/sn/pci/tioce_provider.c: start functions at column zero ppc/8xx_io/fec.c: kill prototype, remove extra whitespace ppc/platforms/85xx/

Re: [PATCH] De-constify sched.h

2007-10-26 Thread David Rientjes
On Fri, 26 Oct 2007, Alexey Dobriyan wrote: > 2) There is no such thing as const task_struct. Anyone who think otherwise >deserves compiler warning. > A 'const struct task_struct *' can be used as an annotation to mean that no member of the struct is modified through that pointer, so it's

[PATCH v2] ISDN/capidrv: address two longstanding warnings

2007-10-26 Thread Jeff Garzik
* change #warning to a code comment * add comment and special ifdef'd 64-bit code for a situation where we must store a pointer into a CAPI field 'Data', which is fixed by the interface at 32 bits. Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]> --- drivers/isdn/capi/capidrv.c | 25

[PATCH] SCSI/sym53c416: kill pointless irq handler loop and test

2007-10-26 Thread Jeff Garzik
- kill pointless irq handler loop to find base address, it is already passed to irq handler via Scsi_Host. - kill now-pointless !base test. Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]> --- drivers/scsi/sym53c416.c | 16 +--- 1 files changed, 1 insertions(+), 15 deletions(-) di

[PATCH] drivers/net/irda/au1k_ir: fix obvious irq handler bugs

2007-10-26 Thread Jeff Garzik
interrupt handlers return a return value these days. Also, kill always-true test and unneeded void* cast. Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]> --- drivers/net/irda/au1k_ir.c | 11 --- 1 files changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/net/irda/au1k_ir.c b/

[PATCH] media/video/planb: fix obvious interrupt handling bugs

2007-10-26 Thread Jeff Garzik
irq handlers have returned a return value for years now... catch up with the times. Also, ditch unneeded prototype. Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]> --- drivers/media/video/planb.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/media/video/p

[PATCH] ARM: Misc minor interrupt handler cleanups

2007-10-26 Thread Jeff Garzik
mach-integrator/pci_v3.c: no need to reference 'irq' arg, its constant mach-omap1/pm.c: remove extra whitespace arch/arm/mach-sa1100/ssp.c: remove braces around single C stmt arch/arm/plat-omap/mcbsp.c: - remove pointless casts from void* - make longer lines more readable Signed

[PATCH] Remove pointless casts from void pointers,

2007-10-26 Thread Jeff Garzik
mostly in and around irq handlers. Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]> --- arch/arm/mach-pxa/ssp.c|2 +- arch/arm/mach-s3c2410/usb-simtec.c |2 +- arch/arm/plat-omap/mailbox.c |2 +- arch/ia64/sn/pci/pcibr/pcibr_provider.c|6

Re: [BUG] panic after umount (biscted)

2007-10-26 Thread Jens Axboe
On Fri, Oct 26 2007, Jens Axboe wrote: > On Fri, Oct 26 2007, Sebastian Siewior wrote: > > After umount of > > /dev/md/1 on /mnt/sec type xfs (rw,nosuid,nodev,noatime,nodiratime) > > > > I end up with [1] on v2.6.24-rc1. It worked fine with v2.6.23. Bisec > > came to conclusion that > > > > |fd

Re: [PATCH 1/3 -v4] x86_64 EFI runtime service support: EFI basic runtime service support

2007-10-26 Thread Huang, Ying
On Fri, 2007-10-26 at 10:48 +0200, Thomas Gleixner wrote: > > EFI uses the Windows x86_64 calling convention. The lin2win may be a > > more general naming convention that can be used for some other code (the > > NDISwrapper?) in the future. Do you agree? > > I agree not at all. I do not care wheth

Re: [AppArmor 34/45] Factor out sysctl pathname code

2007-10-26 Thread James Morris
On Thu, 25 Oct 2007, [EMAIL PROTECTED] wrote: > Convert the selinux sysctl pathname computation code into a standalone > function. > > Signed-off-by: Andreas Gruenbacher <[EMAIL PROTECTED]> > Signed-off-by: John Johansen <[EMAIL PROTECTED]> Reviewed-by: James Morris <[EMAIL PROTECTED]> -- Ja

Re: Upcomming CRIS patches

2007-10-26 Thread Piero Ottuzzi
2007/10/26, Piero Ottuzzi <[EMAIL PROTECTED]>: > 2007/10/26, Mikael Starvik <[EMAIL PROTECTED]>: > > >Are there access to a cross-compile chain for i386 somewhere? > > > > Sure, that's the only way we do it (CRIS has typically too low performance > > and memory to compile anything although it has b

Re: Possibility of adding -march=native to x86

2007-10-26 Thread Thomas Gleixner
On Thu, 25 Oct 2007, Michael Lothian wrote: > Hi > > I was wondering if it was possible to add -march=native support to the > processor options of the new x86 architecture if gcc 4.2 or greater is being > used. > > I'm not suggesting this should be a default at all, merely an extra option > sim

Re: kernel 2.6.23 CFS problem?

2007-10-26 Thread Mike Galbraith
On Fri, 2007-10-26 at 15:32 +0800, Wang, Baojun wrote: > > Perhaps he has any tasks stuck in 'D' state? If so, SysRq-t output for > > these would be a good thing to collect. What leads him to suspect the > > process scheduler, etc. More details are needed. > The task is S+ state, please see in

Re: [2.6 patch] make ircomm_tty static

2007-10-26 Thread David Miller
From: Adrian Bunk <[EMAIL PROTECTED]> Date: Wed, 24 Oct 2007 18:23:55 +0200 > ircomm_tty can now become static. > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Applied. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More

Re: [PATCH 5/5]: [PCI]: Remove 3 incorrect MSI quirks.

2007-10-26 Thread David Gaarenstroom
2007/10/25, David Miller <[EMAIL PROTECTED]>: > > Now that we have dealt with the real issue, in that some ATI SATA and > USB controllers needed the INTX_DISABLE quirk, we can remove these AMD > chipset global MSI disabling quirks. IMHO we should remove *all* former ATI "AMD" chipset global MSI di

Re: [2.6 patch] make tcp_match_skb_to_sack() static

2007-10-26 Thread David Miller
From: "Ilpo_Järvinen" <[EMAIL PROTECTED]> Date: Thu, 25 Oct 2007 00:39:23 +0300 (EEST) > On Wed, 24 Oct 2007, Adrian Bunk wrote: > > > tcp_match_skb_to_sack() can become static. > > > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> > > > [...snip...] > > Thanks, I should have noticed that righ

Re: Upcomming CRIS patches

2007-10-26 Thread Piero Ottuzzi
2007/10/26, Mikael Starvik <[EMAIL PROTECTED]>: > >Are there access to a cross-compile chain for i386 somewhere? > > Sure, that's the only way we do it (CRIS has typically too low performance > and memory to compile anything although it has been shown that it is > possible) > > You can find the com

Re: [2.6 patch] unexport icmpmsg_statistics

2007-10-26 Thread David Miller
From: David Stevens <[EMAIL PROTECTED]> Date: Wed, 24 Oct 2007 13:43:14 -0700 > So, I stand corrected, and sorry about the histrionics. Since > these are arguably ICMP errors, and since errors is the only > thing being MIB-counted in DCCP and SCTP, then it now looks > ok to me as-is, and also ok t

Re: [2.6 patch] #if 0 sctp_update_copy_cksum()

2007-10-26 Thread David Miller
From: Vlad Yasevich <[EMAIL PROTECTED]> Date: Wed, 24 Oct 2007 16:30:34 -0400 > Adrian Bunk wrote: > > sctp_update_copy_cksum() is no longer used. > > > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> > > ACK. Applied, thanks! - To unsubscribe from this list: send the line "unsubscribe linux-k

[no subject]

2007-10-26 Thread Madhur Ahuja
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: sysfs: WARNING: at fs/sysfs/dir.c:424 sysfs_add_one() - with ALSA

2007-10-26 Thread Kamalesh Babulal
On Fri, Oct 26, 2007 at 12:44:38PM +0530, Amit Shah wrote: > On 2.6.24-rc1, I get this for all my eth interfaces: > > [ 150.389821] sysfs: duplicate filename 'eth1_rename' can not be created > [ 150.389824] WARNING: at fs/sysfs/dir.c:424 sysfs_add_one() > [ 150.389826] > [ 150.389826] Call Tra

Re: [patch 3/3] cpusets: add memory_spread_user option

2007-10-26 Thread David Rientjes
On Thu, 25 Oct 2007, Paul Jackson wrote: > I'm figuring that when someone looks at the cpuset flag: > > memory_spread_user > > they will expect that turning it on will cause user space memory to be > spread over the nodes of the cpuset. Sure makes sense that it would > mean that. > > But

Re: [BUG] panic after umount (biscted)

2007-10-26 Thread Jens Axboe
On Fri, Oct 26 2007, Sebastian Siewior wrote: > After umount of > /dev/md/1 on /mnt/sec type xfs (rw,nosuid,nodev,noatime,nodiratime) > > I end up with [1] on v2.6.24-rc1. It worked fine with v2.6.23. Bisec > came to conclusion that > > |fd5d806266935179deda1502101624832eacd01f is first bad com

Re: [PATCH] VFS: new fgetattr() file operation

2007-10-26 Thread Miklos Szeredi
> On Fri, Oct 26, 2007 at 01:10:14AM +0200, Miklos Szeredi wrote: > > > On Wed, Oct 24, 2007 at 05:27:04PM +0200, Miklos Szeredi wrote: > > > > > >> Wouldn't you be better off by attempting to implement an "open > > > > > >> by ino" operation and an operation to get the generation count > > > > > >

  1   2   3   4   5   6   >