Re: [PATCH 3/5] Net: ath5k, use int as retval

2007-09-02 Thread Nick Kossifidis
2007/9/1, Jiri Slaby <[EMAIL PROTECTED]>: > John W. Linville napsal(a): > > On Tue, Aug 28, 2007 at 12:00:09PM -0400, Jiri Slaby wrote: > >> ath5k, use int as retval > >> > >> Convert some functions to return int and proper negative return value on > >> error as we are used to. > > > > Since I didn

Re: Fwd: That whole "Linux stealing our code" thing

2007-09-02 Thread Igor Sobrado
On Sun, 2 Sep 2007, Jeff Garzik wrote: Krzysztof Halasa wrote: WRT Atheros driver I'd probably leave the thing as is (i.e., BSD/GPL = in fact BSD), unless something like 50+% of the code is rewritten - it's mostly their hard work after all, isn't it? Not legal requirement, though. Yes. T

RTNL: assertion failed at net/core/dev.c

2007-09-02 Thread Christian Kujau
Wow, I should really update more often. Skipping the last -rc versions AND adding a new device (zd1211rw) to the box turns out to be quite interesting ([0],[1]). However, this time loading of a (proprietary) module is involved. Knowing that lkml cannot really help here (and I should contact vmw

Re: RTNL: assertion failed at net/core/dev.c

2007-09-02 Thread Johannes Berg
On Sun, 2007-09-02 at 18:05 +0200, Christian Kujau wrote: > but given the amount of changes currently > going into net/ I thought this might be interesting: > > [15604.137408] RTNL: assertion failed at net/core/dev.c (2595) > [15604.138807] [] __dev_set_promiscuity+0xc2/0xd0 > [15604.139163] [

Re: RTNL: assertion failed at net/core/dev.c

2007-09-02 Thread Stephen Hemminger
On Sun, 2 Sep 2007 18:05:33 +0200 (CEST) Christian Kujau <[EMAIL PROTECTED]> wrote: > Wow, I should really update more often. Skipping the last -rc versions > AND adding a new device (zd1211rw) to the box turns out to be quite > interesting ([0],[1]). > > However, this time loading of a (propri

Re: [jffs2] [rfc] fix write deadlock regression

2007-09-02 Thread David Woodhouse
On Sun, 2007-09-02 at 16:17 +0200, Nick Piggin wrote: > On Sun, Sep 02, 2007 at 02:48:04PM +0100, David Woodhouse wrote: > > On Sun, 2007-09-02 at 15:20 +0200, Nick Piggin wrote: > > > OK, but then hasn't the patch just made the deadlock harder to hit, > > > or is there some invariant that says tha

GPL weasels and the atheros stink

2007-09-02 Thread Marc Espie
Hi. My name may not ring a bell for lots of lklm members. I am a long time OpenBSD developer, and I've contributed little bits to a lot of opensource projects, to the extent that I've got commit rights to gcc, binutils, kde. I've probably sent hundreds of patches and tweaks to various projects ove

Re: GPL weasels and the atheros stink

2007-09-02 Thread Alan Cox
> as git, this is no longer as cumbersome as this used to be. So, instead > of new gcc code sent to the FSF (and given to the FSF), we could explicitly > keep patches under the ISC licence, and explain loudly why this is so. I think you need to learn about derivative works. That aside I'm not awar

Re: [PATCH] x86/x86-64 PCI domain support

2007-09-02 Thread Randy Dunlap
On Sat, 01 Sep 2007 18:40:27 -0400 Jeff Garzik wrote: > Andi Kleen wrote: > >>> The second function is redundant? > >> No, it's a hook we must implement, when CONFIG_PCI_DOMAINS is enabled. > > > > Then the other function is redundant. > > No, both functions are required by the interface. by w

Re: GPL weasels and the atheros stink

2007-09-02 Thread Kyle Moffett
On Sep 02, 2007, at 10:03:07, Marc Espie wrote: Do you really think he's going to keep his work under a dual- licence, seeing how a bunch of rabid linux zealots are all but intent on stealing his code whenever they can. [...snip...] Oh god, not another Linux/*BSD month-long flamewar chewing

Re: [PATCH] x86/x86-64 PCI domain support

2007-09-02 Thread Jeff Garzik
Randy Dunlap wrote: On Sat, 01 Sep 2007 18:40:27 -0400 Jeff Garzik wrote: Andi Kleen wrote: The second function is redundant? No, it's a hook we must implement, when CONFIG_PCI_DOMAINS is enabled. Then the other function is redundant. No, both functions are required by the interface. by w

Re: GPL weasels and the atheros stink

2007-09-02 Thread Oleg Verych
* Sun, 2 Sep 2007 16:03:07 +0200 > > Hi. My name may not ring a bell for lots of lklm members. Hallo, Marc. It's OK; shit happens, calm down, please. [] > Well, if that's truely the case, I may reconsider my good faith for future > contributions. Heck, instead of giving away my code under the GPL

Re: [ANNOUNCE/RFC] Really Fair Scheduler

2007-09-02 Thread Roman Zippel
Hi, On Sat, 1 Sep 2007, Bill Davidsen wrote: > > I'd expect Ingo to know better, but the more he refuses to answer my > > questions, the more I doubt it, at least than it comes to the math part. > > > The "math part" is important if you're doing a thesis defense, but > demonstrating better behav

Re: [2.6.22] circular lock detected

2007-09-02 Thread Folkert van Heusden
> > 2.6.22 kernel with hyperthreading enabled only ext3 filesystems (2). > > > > [ 346.314640] === ... > > [ 346.349869][] 0x > > [ 346.350438] > > [ 346.350440] other info that might help us debug this: > > [ 346.350442] >

Re: [PATCH] x86/x86-64 PCI domain support

2007-09-02 Thread Randy Dunlap
Jeff Garzik wrote: Randy Dunlap wrote: On Sat, 01 Sep 2007 18:40:27 -0400 Jeff Garzik wrote: Andi Kleen wrote: The second function is redundant? No, it's a hook we must implement, when CONFIG_PCI_DOMAINS is enabled. Then the other function is redundant. No, both functions are required by t

Re: [ANNOUNCE/RFC] Really Fair Scheduler

2007-09-02 Thread Roman Zippel
Hi, On Sun, 2 Sep 2007, Ingo Molnar wrote: > so i thought you must be aware of the problem - at least considering how > much you've criticised CFS's "complexity" both in your initial review of > CFS (which included object size comparisons) and in this patch > submission of yours (which did not

Re: [lm-sensors] [PATCH] drivers/firmware: const-ify DMI API and internals

2007-09-02 Thread Jean Delvare
On Sat, 1 Sep 2007 10:27:19 -0400, Jeff Garzik wrote: > > commit 457b6eb3bf3341d2e143518a0bb99ffbb8d754c4 > Author: Jeff Garzik <[EMAIL PROTECTED]> > Date: Sat Sep 1 10:16:45 2007 -0400 > > drivers/firmware: const-ify DMI API and internals > > Three main sets of changes: > >

Re: GPL weasels and the atheros stink

2007-09-02 Thread Michael Tharp
Marc Espie wrote: > Let's extend the story a wee little bit. It seems that these days, some > parts of the opensource community have gotten confident enough that they > do not need the other part. We all know the situation is already fairly > disymetric. The GPL is less free than the ISC licence fo

Re: [ANNOUNCE] GIT 1.5.3

2007-09-02 Thread Sean
On Sun, 02 Sep 2007 10:57:03 +0100 "H. Peter Anvin" <[EMAIL PROTECTED]> wrote: > From the looks of it, there is still a git-p4, it just moved to contrib > and uses fast-import, so removing its rpm package was probably broken in > the first place. Hi Peter, Items in contrib aren't officially s

[PATCH] use VM_READ/WRITE/EXEC to set vm_page_prot

2007-09-02 Thread Coly Li
When setup vm_page_prot, some code use 0x7 instead of (VM_READ|VM_WRITE|VM_EXEC). It does works well, but it will be better if we use the VM_READ/WRITE/EXEC MACRO :-) This patch uses (VM_READ|VM_WRITE|VM_EXEC) to replace 0x7 in vm_page_prot setup. Signed-Off-By: Coly Li <[EMAIL PROTECTED]> dif

Linux, 2.6.23-rc5, powersaving degradation, (time spend in C0 goes up after a while)

2007-09-02 Thread Christian Leber
Hello, I have observed some oddness in the powersaving behavior in rc5 and the rcs before and i suspect this may be scheduler related. After booting or resuming from drisk or ram(!) the wakeups are about 45 per second (about 1% C0 (cpu runng)) and after about half an hour to hours of doing nothin

Re: "GPL weasels and the atheros stink"

2007-09-02 Thread Jonathan A. George
While the title of Marc's email might be construed as flame bait, it is disappointing to see that the generally very valid points he has made (as both a BSD _and_ _GPL_ developer) are being ignored. To make it simple try answering these two questions: Question #1: Is it _ethical_ (legalit

[PATCH][Trivial] CIFS: Use ssleep() instead of msleep() when sleeping multiple seconds

2007-09-02 Thread Jesper Juhl
Hi, A little trivial thing... When sleeping for multiple seconds the function to use is ssleep() not msleep() - especially when there's a comment above reading "... wait at least 45 seconds ...", then ssleep() best describes what is wanted. Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]> ---

Re: GPL weasels and the atheros stink

2007-09-02 Thread Jeff Garzik
(more serious reply now ensues) Marc Espie wrote: After reading the current email exchanges, I've become convinced there is something VERY fishy going on, and some people there have hidden agendas. Look at the situation: Reyk Floeter writes some code, puts it under a dual licence, and goes o

Re: RTNL: assertion failed at net/core/dev.c

2007-09-02 Thread Christian Kujau
On Sun, 2 Sep 2007, Stephen Hemminger wrote: Vendor module calls kernel api incorrectly. dev_set_promiscuity requires that the calling thread hold rtnl mutex (ie call rtnl_lock). It's their bug, netdev doesn't want to hear about it. OK, that's all I needed to know. Thank you both for your comme

Re: the Linux kernel, testsuites, and maybe *you*

2007-09-02 Thread Håvard Skinnemoen
On 9/2/07, Andi Kleen <[EMAIL PROTECTED]> wrote: > The other issue to test some of them properly you need unmapped pages > etc. That gets much easier to do in user space. There are some other > issues. vmalloc, vmap, etc. always put a guard page after the allocation. So if you test string operatio

Re: Fwd: That whole "Linux stealing our code" thing

2007-09-02 Thread Al Viro
On Sun, Sep 02, 2007 at 03:00:46PM +0200, Igor Sobrado wrote: > >Not strictly true. They can either agree to a change and issue one or > >they can convey to other parties the right to change the terms. The GPL > >for example does this for version selection. > > So, under a dual-licensed BSD/GPL co

Re: Fwd: That whole "Linux stealing our code" thing

2007-09-02 Thread Matthew Jacob
This has been pretty interesting for me to watch as I distribute my isp driver under a dual license (at least the portions of it which are common with the *BSD and Solaris ports) that is almost identical to Sam's verbiage. I'll admit that I hadn't thought about whether redistribution included the

[rfc][patch] dynamic data structure switching

2007-09-02 Thread Nick Piggin
Hi, This is my "data structure switch" algorithm that can convert one data structure into another, with just a single unlikely branch in fastpaths and no locking or atomic operations (the branch is only triggered when the data structure is in the process of being converted). A pointer indirection

Re: "GPL weasels and the atheros stink"

2007-09-02 Thread Matthew Jacob
> Question #1: Is it _ethical_ (legality aside) to take someone else's > actively maintained work (for example an OpenBSD driver) and make > changes which can not be shared/used by the original developer/maintainer? > > Answer #1: Considering that the whole reason I personally choose the GPL > for

Re: [rfc][patch] dynamic data structure switching

2007-09-02 Thread Nick Piggin
Dumb, slightly incomplete, dynamic pidhash resizing. I'm just sending this as a reference and testing tool. While the pid-hash might be the least problematic one we have, RAM saving / collision minimisation aren't the only reasons to size a hash optimally: in a really lookup intensive workload, a s

Re: Linux, 2.6.23-rc5, powersaving degradation, (time spend in C0 goes up after a while)

2007-09-02 Thread Arjan van de Ven
On Sun, 2 Sep 2007 19:40:38 +0200 Christian Leber <[EMAIL PROTECTED]> wrote: > Hello, > > I have observed some oddness in the powersaving behavior in rc5 and > the rcs before and i suspect this may be scheduler related. > > After booting or resuming from drisk or ram(!) the wakeups are about > 4

Hang in 2.6.23-rc5

2007-09-02 Thread daryll q
Upgraded my kernel from 2.6.23-rc2 to 2.6.23-rc5. System hangs (caps lock and scroll lock leds are both flashing). It *randomly* happens but most of the time during after login to KDE. I have not investigated it yet because I have not tried doing it before. Also the system is really no

Re: "GPL weasels and the atheros stink"

2007-09-02 Thread Jeff Garzik
Jonathan A. George wrote: Question #1: Is it _ethical_ (legality aside) to take someone else's actively maintained work (for example an OpenBSD driver) and make changes which can not be shared/used by the original developer/maintainer? This happens all the time. It's called a fork. Forks hap

Re: [PATCH] hwmon coretemp: Remove bogus __cpuinitdata etc cleanup

2007-09-02 Thread Rudolf Marek
>> [ Rudolf, Mark, would it be acceptable to you to remove all the open >> #ifdef HOTPLUG_CPU from this file and replace them with __cpuinit{data} >> instead? That could increase size of modular builds, but would remain >> consistent with rest of kernel, and make the file #ifdef-clean ... ]

Re: 2.6.23-rc4-mm1: broke pata_via cable detection

2007-09-02 Thread Laurent Riffard
Le 01.09.2007 06:58, Andrew Morton a écrit : > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.23-rc4/2.6.23-rc4-mm1/ [...] > +libata-correct-handling-of-srst-reset-sequences.patch [...] Alan, libata-correct-handling-of-srst-reset-sequences.patch broke 80-wire cable detection on

[PATCH 3/4] ide: make ide_rate_filter() also respect PIO and SW/MW DMA mode masks

2007-09-02 Thread Sergei Shtylyov
Make ide_rate_filter() also respect PIO/SWDMA/MWDMA mode masks. While at it, make the udma_filter() method calls take precedence over using the mode masks. --- This version doesn't use explicit UltraDMA masks, so converting them to the ATA_UDMA* is left for another, global patch. This patch agai

Re: "GPL weasels and the atheros stink"

2007-09-02 Thread Jonathan A. George
Matthew Jacob wrote: > Question #1: Is it _ethical_ (legality aside) to take someone else's actively maintained work (for example an OpenBSD driver) and make changes which can not be shared/used by the original developer/maintainer? Answer #1: Considering that the whole reason I personally cho

Re: Hang in 2.6.23-rc5

2007-09-02 Thread charles gagalac
On 9/2/07, daryll q wrote: > Upgraded my kernel from 2.6.23-rc2 to 2.6.23-rc5. > > System hangs (caps lock and scroll lock leds are both > flashing). > > It *randomly* happens but most of the time during > after login to KDE. > > I have not investigated it yet because I have not > tried doing it

Re: [PATCH 3/4] ide: make ide_rate_filter() also respect PIO and SW/MW DMA mode masks

2007-09-02 Thread Sergei Shtylyov
Hello, I wrote: Make ide_rate_filter() also respect PIO/SWDMA/MWDMA mode masks. While at it, make the udma_filter() method calls take precedence over using the mode masks. --- This version doesn't use explicit UltraDMA masks, so converting them to the ATA_UDMA* is left for another, global patc

Re: 2.6.23-rc4-mm1: broke pata_via cable detection

2007-09-02 Thread Alan Cox
> via_do_set_mode overwrites 80-wire cable detection bits. Let's > preserve them. Agreed, on a reset case we may otherwise get confused and misdetect the cable. Change agrees with the data sheet > > Signed-off-by: Laurent Riffard <[EMAIL PROTECTED]> Acked-by: Alan Cox <[EMAIL PROTECTED]> Than

Re: [ANNOUNCE/RFC] Really Simple Really Fair Scheduler

2007-09-02 Thread Tong Li
I like this patch since it's really simple. CFS does provide a nice infrastructure to enable new algorithmic changes/extensions. My only concern was the O(log N) complexity under heavy load, but I'm willing to agree that it's OK in the common case. Some comments on the code: * Ingo Molnar <[E

BUG: scheduling while atomic: ifconfig/0x00000002/4170

2007-09-02 Thread Florian Lohoff
Hi, with current git i got this when "ifconfig eth1" down. eth1 had a mac address which looked really like an eth1394 ethernet although the module was not loaded. Something is really broken in 2.6.23-currentgit. I always get the sysfs rename issues which are discussed to be an udev issue. Then i

Re: [ANNOUNCE/RFC] Really Fair Scheduler

2007-09-02 Thread Ingo Molnar
* Roman Zippel <[EMAIL PROTECTED]> wrote: > > > > so unmodified CFS is 4.6% faster on this box than with Roman's > > > > patch and it's also more consistent/stable (10 times lower > > > > fluctuations). > > > > > > Was SCHED_DEBUG enabled or disabled for these runs? > > > > debugging disabled

Re: "GPL weasels and the atheros stink"

2007-09-02 Thread Jeff Garzik
Jonathan A. George wrote: ... But is it _ethical_ (as opposed to legal) to violate the expressed intent of the original author ... The author expresses his intent primarily by choice of license text, and it's very important to all of us that we follow the rules set forth by the author in tha

Re: [lm-sensors] [PATCH] hwmon: Add power meters to Documentation/hwmon/sysfs-interface

2007-09-02 Thread Jean Delvare
On Sat, 1 Sep 2007 16:44:17 -0300, Henrique de Moraes Holschuh wrote: > On Sat, 01 Sep 2007, Shem Multinymous wrote: > > > Should we add power?_10sec_avg_input? IIRC thinkpads export that, > > > too. > > I'd say it is enough to know it is an average, you don't need to specify HOW > it is averaged.

Hint needed : how to debug sempahore's problem

2007-09-02 Thread Philippe De Muyter
Hi all, Can someone give me some hint or link for the following question : I have several processes blocked in 'D' state, and I surmise they are waiting for a semaphore (in the `down' routine). How is it possible : - to verify the processes are really blocked on a semaphore, - to see which semap

[PATCH 3/4] ide: make ide_rate_filter() also respect PIO and SW/MW DMA mode masks (take 2)

2007-09-02 Thread Sergei Shtylyov
Make ide_rate_filter() also respect PIO/SWDMA/MWDMA mode masks. While at it, make the udma_filter() method calls take precedence over using the mode masks. Signed-off-by: Sergei Shtylyov <[EMAIL PROTECTED]> --- Alas, the previous version of the patch wasn't even worth signing it off -- the code

Re: [ANNOUNCE/RFC] Really Simple Really Fair Scheduler

2007-09-02 Thread Ingo Molnar
* Tong Li <[EMAIL PROTECTED]> wrote: > I like this patch since it's really simple. CFS does provide a nice > infrastructure to enable new algorithmic changes/extensions. My only > concern was the O(log N) complexity under heavy load, but I'm willing > to agree that it's OK in the common case.

Re: Hint needed : how to debug sempahore's problem

2007-09-02 Thread Alexander Shishkin
On 9/2/07, Philippe De Muyter <[EMAIL PROTECTED]> wrote: > Hi all, Hi, > Can someone give me some hint or link for the following question : > > I have several processes blocked in 'D' state, and I surmise they are > waiting for a semaphore (in the `down' routine). How is it possible : > - to veri

[-mm patchset] War on warnings

2007-09-02 Thread Satyam Sharma
I decided to ruin my Sunday with an utterly pointless activity -- waging war on -mm build warnings. Some of the code I touched belonged to grotty, unused, dying drivers, but still, the end result was that I can now only see 5 warnings remaining on my typical .config (those have to do with pci_{fin

[PATCH -mm] sisusbvga: Fix bug and build warnings

2007-09-02 Thread Satyam Sharma
drivers/usb/misc/sisusbvga/sisusb.c: In function ‘usb_sisusb_init’: drivers/usb/misc/sisusbvga/sisusb.c:3321: warning: unused variable ‘sisusb’ drivers/usb/misc/sisusbvga/sisusb.c:3320: warning: unused variable ‘retval’ are trivially solved by getting rid of the unused variables. drivers/usb/mis

[PATCH -mm] sunrpc svc: Shut up bogus uninitialized variable warning

2007-09-02 Thread Satyam Sharma
net/sunrpc/svc.c: In function ‘__svc_create_thread’: net/sunrpc/svc.c:550: warning: ‘oldmask.bits[0u]’ may be used uninitialized in this function is a bogus warning, but gcc isn't smart enough to see why. We cannot just reorganize the code in the function, because we want the set_cpus_allowed()

Re: [PATCH] sysctl: Deprecate sys_sysctl in a user space visible fashion.

2007-09-02 Thread Eric W. Biederman
Rob Landley <[EMAIL PROTECTED]> writes: > > If you're going to add a new api, you might as well go with the > sysctl-by-name > patch above, which looks reasonably small and simple to me from a very quick > glance at a 2.6.0-era patch. > > The advantage of breaking /proc/sys into a separate files

[PATCH -mm] net/wireless/sysfs.c: Shut up build warning

2007-09-02 Thread Satyam Sharma
net/wireless/sysfs.c:108: warning: ‘wiphy_uevent’ defined but not used when CONFIG_HOTPLUG=n is because the only usage site of this function is #ifdef'ed as such, so let's #ifdef the definition also. Signed-off-by: Satyam Sharma <[EMAIL PROTECTED]> --- net/wireless/sysfs.c |2 ++ 1 file c

[PATCH -mm] drivers/usb/serial/bus.c: Fix incompatible pointer type warning

2007-09-02 Thread Satyam Sharma
drivers/usb/serial/bus.c: In function ‘usb_serial_bus_deregister’: drivers/usb/serial/bus.c:185: warning: passing argument 1 of ‘free_dynids’ from incompatible pointer type Above build warning comes when CONFIG_HOTPLUG=n because argument of free_dynids() in serial/bus.c is a struct usb_serial_dri

[PATCH -mm] IPS SCSI driver: Check return of scsi_add_host()

2007-09-02 Thread Satyam Sharma
drivers/scsi/ips.c: In function ‘ips_register_scsi’: drivers/scsi/ips.c:6869: warning: ignoring return value of ‘scsi_add_host’, declared with attribute warn_unused_result scsi_add_host() is __must_check, so let's check it's return and cleanup appropriately on errors. Signed-off-by: Satyam Shar

Re: [PATCH] sysctl: Deprecate sys_sysctl in a user space visible fashion.

2007-09-02 Thread Al Viro
On Sun, Sep 02, 2007 at 01:56:33PM -0600, Eric W. Biederman wrote: > - I think all that is left is superblock handling and some backward > compatibility magic. (Using the follow_link trick to automatically > mount /proc/sys) NAK. Let's explicitly mount this stuff in init scripts; it won't bre

[PATCH -mm] sb16: Shut up uninitialized var build warning

2007-09-02 Thread Satyam Sharma
sound/isa/sb16/sb16.c: In function ‘snd_sb16_isa_probe’: sound/isa/sb16/sb16.c:559: warning: ‘err’ may be used uninitialized in this function is a bogus warning, so let's shut it up. Signed-off-by: Satyam Sharma <[EMAIL PROTECTED]> --- sound/isa/sb/sb16.c |3 ++- 1 file changed, 2 insert

[PATCH -mm] drivers/mmc/core/bus.c: Fix unused var warning

2007-09-02 Thread Satyam Sharma
drivers/mmc/core/bus.c: In function ‘mmc_bus_uevent’: drivers/mmc/core/bus.c:77: warning: unused variable ‘length’ drivers/mmc/core/bus.c:77: warning: unused variable ‘i’ Signed-off-by: Satyam Sharma <[EMAIL PROTECTED]> --- drivers/mmc/core/bus.c |1 - 1 file changed, 1 deletion(-) --- li

Re: [-mm patchset] War on warnings

2007-09-02 Thread Jesper Juhl
On 02/09/07, Satyam Sharma <[EMAIL PROTECTED]> wrote: > > I decided to ruin my Sunday with an utterly pointless activity -- > waging war on -mm build warnings. Some of the code I touched belonged > to grotty, unused, dying drivers, but still, the end result was that > I can now only see 5 warnings

[PATCH -mm] I2O: Fix "defined but not used" build warnings

2007-09-02 Thread Satyam Sharma
drivers/message/i2o/exec-osm.c:539: warning: ‘i2o_exec_lct_notify’ defined but not used comes when CONFIG_I2O_LCT_NOTIFY_ON_CHANGES=n, because its only callsite is #ifdef'ed as such. So let's #ifdef the function definition also. Also move the definition to before the callsite, to get rid of forw

[PATCH -mm] mpt fusion: Shut up uninitialized variable warnings

2007-09-02 Thread Satyam Sharma
drivers/message/fusion/mptctl.c: In function ‘mptctl_mpt_command’: drivers/message/fusion/mptctl.c:1764: warning: ‘bufIn.len’ may be used uninitialized in this function drivers/message/fusion/mptctl.c:1765: warning: ‘bufOut.len’ may be used uninitialized in this function come because gcc gets c

Re: [PATCH -mm] IPS SCSI driver: Check return of scsi_add_host()

2007-09-02 Thread Jesper Juhl
On Sunday 02 September 2007 22:13:49 Satyam Sharma wrote: > > drivers/scsi/ips.c: In function ‘ips_register_scsi’: > drivers/scsi/ips.c:6869: > warning: ignoring return value of ‘scsi_add_host’, declared with attribute > warn_unused_result > > scsi_add_host() is __must_check, so let's check it's

[PATCH -mm] es18xx: Shut up uninitialized var build warning

2007-09-02 Thread Satyam Sharma
sound/isa/es18xx.c: In function ‘snd_es18xx_isa_probe’: sound/isa/es18xx.c:2251: warning: ‘err’ may be used uninitialized in this function gcc is a sad, sad compiler. This warning is bogus so let's shut it up. Signed-off-by: Satyam Sharma <[EMAIL PROTECTED]> --- sound/isa/es18xx.c |3 ++-

[PATCH -mm] drivers/md/: Shut up uninitialized variable warnings

2007-09-02 Thread Satyam Sharma
drivers/md/dm-exception-store.c: In function ‘persistent_read_metadata’: drivers/md/dm-exception-store.c:452: warning: ‘new_snapshot’ may be used uninitialized in this function drivers/md/dm-ioctl.c: In function ‘ctl_ioctl’: drivers/md/dm-ioctl.c:1407: warning: ‘param’ may be used uninitialized

[PATCH -mm] DC395x SCSI driver: Shut up uninitialized variable build warning

2007-09-02 Thread Satyam Sharma
drivers/scsi/dc395x.c: In function ‘dc395x_init_one’: drivers/scsi/dc395x.c:4272: warning: ‘ptr’ may be used uninitialized in this function has been verified to be a bogus warning. Let's shut it up. Signed-off-by: Satyam Sharma <[EMAIL PROTECTED]> --- drivers/scsi/dc395x.c |2 +- 1 file

[PATCH -mm] i386 cpuid_count: Fix argument signedness warnings

2007-09-02 Thread Satyam Sharma
These build warnings: In file included from include/asm/thread_info.h:16, from include/linux/thread_info.h:21, from include/linux/preempt.h:9, from include/linux/spinlock.h:49, from include/linux/vmalloc.h:4, from arch/i386/boot/compressed/misc.c:14: include/asm/processor.h: In function ‘cpuid_co

Re: [PATCH -mm] sisusbvga: Fix bug and build warnings

2007-09-02 Thread Jesper Juhl
On 02/09/07, Satyam Sharma <[EMAIL PROTECTED]> wrote: > > drivers/usb/misc/sisusbvga/sisusb.c: In function 'usb_sisusb_init': > drivers/usb/misc/sisusbvga/sisusb.c:3321: warning: unused variable 'sisusb' > drivers/usb/misc/sisusbvga/sisusb.c:3320: warning: unused variable 'retval' > > are trivially

[PATCH 2/4] hpt366: MWDMA filter for SATA cards

2007-09-02 Thread Sergei Shtylyov
The Marvell bridge chips used on HighPoint SATA cards do not seem to support the MWDMA modes (at least that caould be seen in their so-called drivers :-), so the driver needs to account for this -- to achieve this: - add mdma_filter() method from the original patch by Bartlomiej Zolnierkewicz wi

Re: [PATCH -mm] sisusbvga: Fix bug and build warnings

2007-09-02 Thread Satyam Sharma
Hi Jesper, On Sun, 2 Sep 2007, Jesper Juhl wrote: > > > - if (!(interface = usb_find_interface(&sisusb_driver, subminor))) { > > - dev_err(&sisusb->sisusb_dev->dev, "Failed to find > > interface¥n"); > > Odd how in your patch the line ends with "¥n" but if I look in my >

Re: GPL weasels and the atheros stink

2007-09-02 Thread Bernd Petrovitsch
On Sun, 2007-09-02 at 16:03 +0200, Marc Espie wrote: [...] > So, now, it's down to dirty fighting. Absorbing and `relicensing' and > evolving code. Have you all been bitten my RMS paranoia (that leads to > this `interesting GPLv3) ? Do you intend to keep grabbing BSD code and > putting it exclusi

Re: [PATCH 2/4] hpt366: MWDMA filter for SATA cards

2007-09-02 Thread Sergei Shtylyov
Hello, I wrote: The patch was 4/4 of course. :-< Probably I was too esctatic about the code. ;-) The Marvell bridge chips used on HighPoint SATA cards do not seem to support the MWDMA modes (at least that caould be seen in their so-called drivers :-), so the driver needs to account for t

Re: [PATCH -mm] net/wireless/sysfs.c: Shut up build warning

2007-09-02 Thread Johannes Berg
On Mon, 2007-09-03 at 01:41 +0530, Satyam Sharma wrote: > net/wireless/sysfs.c:108: warning: ‘wiphy_uevent’ defined but not used > > when CONFIG_HOTPLUG=n is because the only usage site of this function > is #ifdef'ed as such, so let's #ifdef the definition also. > > Signed-off-by: Satyam Sharma

Re: [PATCH -mm] sisusbvga: Fix bug and build warnings

2007-09-02 Thread Jesper Juhl
On 02/09/07, Satyam Sharma <[EMAIL PROTECTED]> wrote: > Hi Jesper, > > > On Sun, 2 Sep 2007, Jesper Juhl wrote: > > > > > - if (!(interface = usb_find_interface(&sisusb_driver, subminor))) { > > > - dev_err(&sisusb->sisusb_dev->dev, "Failed to find > > > interface¥n"); > > > >

Re: [PATCH -mm] DC395x SCSI driver: Shut up uninitialized variable build warning

2007-09-02 Thread Jeff Garzik
Satyam Sharma wrote: drivers/scsi/dc395x.c: In function ‘dc395x_init_one’: drivers/scsi/dc395x.c:4272: warning: ‘ptr’ may be used uninitialized in this function has been verified to be a bogus warning. Let's shut it up. Signed-off-by: Satyam Sharma <[EMAIL PROTECTED]> --- drivers/scsi/dc395

Re: [-mm patchset] War on warnings

2007-09-02 Thread Satyam Sharma
On Sun, 2 Sep 2007, Jesper Juhl wrote: > > Thank you for doing this, I hope some of your patches get merged. > > Btw; it would be easier to see if one has got all the patches if you > numbered your patch series with the usual "[PATCH XX/YY]". Hey, thanks ;-) There are 13 in all, I just felt la

Re: 2.6.23-rc4-mm1: boot failure on HPC nx6325

2007-09-02 Thread Rafael J. Wysocki
On Saturday, 1 September 2007 06:58, Andrew Morton wrote: > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.23-rc4/2.6.23-rc4-mm1/ > > - git-kbuild is broken and has been dropped > > - git-ixgb is broken by git-net and has been dropped > > - git-md-accel is broken by MD fixe

Re: [PATCH] i386 and x86_64: randomize brk()

2007-09-02 Thread Andrew Morton
> On Sat, 01 Sep 2007 22:19:01 +0200 Franck Bui-Huu <[EMAIL PROTECTED]> wrote: > Hello Andrew, > > Andrew Morton wrote: > > On Thu, 30 Aug 2007 17:10:03 +0200 (CEST) Jiri Kosina <[EMAIL PROTECTED]> > > wrote: > >> Andrew, do you still strongly oppose to having ARCH_HAS_RANDOMIZE_BRK > >> macro i

Re: [-mm patchset] War on warnings

2007-09-02 Thread Jesper Juhl
On 02/09/07, Satyam Sharma <[EMAIL PROTECTED]> wrote: > > > On Sun, 2 Sep 2007, Jesper Juhl wrote: > > > > Thank you for doing this, I hope some of your patches get merged. > > > > Btw; it would be easier to see if one has got all the patches if you > > numbered your patch series with the usual "[P

Re: [PATCH -mm] IPS SCSI driver: Check return of scsi_add_host()

2007-09-02 Thread Jeff Garzik
Satyam Sharma wrote: drivers/scsi/ips.c: In function ‘ips_register_scsi’: drivers/scsi/ips.c:6869: warning: ignoring return value of ‘scsi_add_host’, declared with attribute warn_unused_result scsi_add_host() is __must_check, so let's check it's return and cleanup appropriately on errors. Sign

Re: [PATCH -mm] drivers/md/: Shut up uninitialized variable warnings

2007-09-02 Thread Jeff Garzik
Satyam Sharma wrote: drivers/md/dm-exception-store.c: In function ‘persistent_read_metadata’: drivers/md/dm-exception-store.c:452: warning: ‘new_snapshot’ may be used uninitialized in this function drivers/md/dm-ioctl.c: In function ‘ctl_ioctl’: drivers/md/dm-ioctl.c:1407: warning: ‘param’ may

Re: [PATCH -mm] DC395x SCSI driver: Shut up uninitialized variable build warning

2007-09-02 Thread Satyam Sharma
On Sun, 2 Sep 2007, Jeff Garzik wrote: > > Satyam Sharma wrote: > > drivers/scsi/dc395x.c: In function ‘dc395x_init_one’: > > drivers/scsi/dc395x.c:4272: warning: ‘ptr’ may be used uninitialized in this > > function > > > > has been verified to be a bogus warning. Let's shut it up. > > > > Sig

Re: Hang in 2.6.23-rc5

2007-09-02 Thread Alessandro Suardi
On 9/2/07, charles gagalac <[EMAIL PROTECTED]> wrote: > On 9/2/07, daryll q wrote: > > Upgraded my kernel from 2.6.23-rc2 to 2.6.23-rc5. > > > > System hangs (caps lock and scroll lock leds are both flashing). > > > > It *randomly* happens but most of the time during after login to KDE. > > > >

Re: Linux, 2.6.23-rc5, powersaving degradation, (time spend in C0 goes up after a while)

2007-09-02 Thread Rene Treffer
Hi, Same problem here, lspci output attached, I can also pm you a lshw output. Arjan van de Ven wrote: On Sun, 2 Sep 2007 19:40:38 +0200 Christian Leber <[EMAIL PROTECTED]> wrote: Hello, I have observed some oddness in the powersaving behavior in rc5 and the rcs before and i suspect this

Re: [PATCH -mm] DC395x SCSI driver: Shut up uninitialized variable build warning

2007-09-02 Thread Jeff Garzik
Satyam Sharma wrote: I'll post the info as a reply to the first mail in this series. I have fairly recent gcc (4.1.1) and I don't see us dropping support for it in the next few years. What's important is not support lifetime, but whether or not the warning persists through version 4.1.2, 4.1.3

Re: [PATCH -mm] drivers/md/: Shut up uninitialized variable warnings

2007-09-02 Thread Satyam Sharma
On Sun, 2 Sep 2007, Jeff Garzik wrote: > Satyam Sharma wrote: > > drivers/md/dm-exception-store.c: In function ‘persistent_read_metadata’: > > drivers/md/dm-exception-store.c:452: warning: ‘new_snapshot’ may be used > > uninitialized in this function > > > > drivers/md/dm-ioctl.c: In function ‘

Re: 2.6.23-rc4-mm1: unpingable box and NULL dereference at tcp_rto_min()

2007-09-02 Thread Andrew Morton
> On Sun, 2 Sep 2007 06:36:19 +0400 Alexey Dobriyan <[EMAIL PROTECTED]> wrote: > On Fri, Aug 31, 2007 at 09:58:22PM -0700, Andrew Morton wrote: > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.23-rc4/2.6.23-rc4-mm1/ > > - dynticks-for-x86_64 has returned > > Good news is that,

Re: Hang in 2.6.23-rc5

2007-09-02 Thread Andrew
Confirmed, same scenario here. Here's my config (x86_64), hope it helps. I will bring up a netconsole and try and catch it the next time it happens. [EMAIL PROTECTED] ~ $ cat /usr/src/linux/.config # # Automatically generated make config: don't edit # Linux kernel version: 2.6.23-rc5 # Sun Sep 2

Re: Fw: 2.6.23-rc3-mm1 UnionFS "BUG: atomic counter underflow"

2007-09-02 Thread Andrew Morton
> On Sun, 2 Sep 2007 12:48:35 -0400 "Josef 'Jeff' Sipek" <[EMAIL PROTECTED]> > wrote: > On Sun, Sep 02, 2007 at 04:56:34AM -0700, Andrew Morton wrote: > > > > fyi.. > > I got a bunch of patches queued up that should fix a few things - quite > possibly this one too. > > I want to push the patch

Re: ipv4_get_l4proto: Frag of proto 17

2007-09-02 Thread Luca
On 9/2/07, Prakash Punnoor <[EMAIL PROTECTED]> wrote: > Hi, > > since 2.6.23-rc1 my log gets cluttered with > > ipv4_get_l4proto: Frag of proto 17 > > What is the reason? netfilter conntrack code. See: http://article.gmane.org/gmane.linux.network/70824 Luca - To unsubscribe from this list: send t

Re: Hang in 2.6.23-rc5

2007-09-02 Thread Satyam Sharma
On Sun, 2 Sep 2007, Alessandro Suardi wrote: > > On 9/2/07, charles gagalac <[EMAIL PROTECTED]> wrote: > > On 9/2/07, daryll q wrote: > > > Upgraded my kernel from 2.6.23-rc2 to 2.6.23-rc5. > > > > > > System hangs (caps lock and scroll lock leds are both flashing). > > > > > > It *randomly* h

Re: [PATCH -mm] sisusbvga: Fix bug and build warnings

2007-09-02 Thread Alistair John Strachan
On Sunday 02 September 2007 21:23:16 Jesper Juhl wrote: > On 02/09/07, Satyam Sharma <[EMAIL PROTECTED]> wrote: > > Hi Jesper, > > > > On Sun, 2 Sep 2007, Jesper Juhl wrote: > > > > - if (!(interface = usb_find_interface(&sisusb_driver, > > > > subminor))) { - dev_err(&sisusb->s

Re: 2.6.23-rc4-mm1: unpingable box and NULL dereference at tcp_rto_min()

2007-09-02 Thread Alexey Dobriyan
On Sun, Sep 02, 2007 at 01:52:45PM -0700, Andrew Morton wrote: > > On Sun, 2 Sep 2007 06:36:19 +0400 Alexey Dobriyan <[EMAIL PROTECTED]> wrote: > > The bad news is something knocked off box from the net, then panicked it: > > Yeah, the net tree has been quite bad lately. Unusually bad - it's usua

Re: [PATCH -mm] sisusbvga: Fix bug and build warnings

2007-09-02 Thread Satyam Sharma
On Sun, 2 Sep 2007, Alistair John Strachan wrote: > On Sunday 02 September 2007 21:23:16 Jesper Juhl wrote: > > On 02/09/07, Satyam Sharma <[EMAIL PROTECTED]> wrote: > > > Hi Jesper, > > > > > > On Sun, 2 Sep 2007, Jesper Juhl wrote: > > > > > - if (!(interface = usb_find_interface(&sisusb

Re: Hang in 2.6.23-rc5

2007-09-02 Thread FD Cami
On Sun, 2 Sep 2007 22:38:28 +0200 "Alessandro Suardi" <[EMAIL PROTECTED]> wrote: > On 9/2/07, charles gagalac <[EMAIL PROTECTED]> wrote: > > On 9/2/07, daryll q wrote: > > > Upgraded my kernel from 2.6.23-rc2 to 2.6.23-rc5. > > > > > > System hangs (caps lock and scroll lock leds are both flashin

Re: Hang in 2.6.23-rc5

2007-09-02 Thread Alexey Dobriyan
On Sun, Sep 02, 2007 at 11:29:39PM +0200, FD Cami wrote: > On Sun, 2 Sep 2007 22:38:28 +0200 > "Alessandro Suardi" <[EMAIL PROTECTED]> wrote: > > > On 9/2/07, charles gagalac <[EMAIL PROTECTED]> wrote: > > > On 9/2/07, daryll q wrote: > > > > Upgraded my kernel from 2.6.23-rc2 to 2.6.23-rc5. > > >

Re: [PATCH] sysctl: Deprecate sys_sysctl in a user space visible fashion.

2007-09-02 Thread Eric W. Biederman
Al Viro <[EMAIL PROTECTED]> writes: > On Sun, Sep 02, 2007 at 01:56:33PM -0600, Eric W. Biederman wrote: >> - I think all that is left is superblock handling and some backward >> compatibility magic. (Using the follow_link trick to automatically >> mount /proc/sys) > > NAK. Let's explicitly m

Re: Fw: 2.6.23-rc3-mm1 UnionFS "BUG: atomic counter underflow"

2007-09-02 Thread Josef 'Jeff' Sipek
On Sun, Sep 02, 2007 at 01:59:57PM -0700, Andrew Morton wrote: > > On Sun, 2 Sep 2007 12:48:35 -0400 "Josef 'Jeff' Sipek" <[EMAIL PROTECTED]> > > wrote: > > On Sun, Sep 02, 2007 at 04:56:34AM -0700, Andrew Morton wrote: > > > > > > fyi.. > > > > I got a bunch of patches queued up that should fi

Re: Hang in 2.6.23-rc5

2007-09-02 Thread Richard Mittendorfer
Also sprach "Alessandro Suardi" <[EMAIL PROTECTED]> (Sun, 2 Sep 2007 22:38:28 +0200): > On 9/2/07, charles gagalac <[EMAIL PROTECTED]> wrote: > > On 9/2/07, daryll q wrote: > > > Upgraded my kernel from 2.6.23-rc2 to 2.6.23-rc5. > > > > > > System hangs (caps lock and scroll lock leds are both fl

<    1   2   3   >