Re: [PATCH][RFC] Create a top-level "Space-critical features" menu.

2007-05-08 Thread Robert P. J. Day
On Tue, 8 May 2007, Matt Mackall wrote: > On Tue, May 08, 2007 at 04:06:30AM -0400, Robert P. J. Day wrote: > > > > i've always hated that lower-level menu under "General setup": > > > > Configure standard kernel features (for small systems) ---> > > > > which buries the choice of de-selecting

Re: Please revert 5adc55da4a7758021bcc374904b0f8b076508a11 (PCI_MULTITHREAD_PROBE)

2007-05-08 Thread Cornelia Huck
On Tue, 8 May 2007 12:31:22 -0700 (PDT), Linus Torvalds <[EMAIL PROTECTED]> wrote: > > What if two devices become hotplugged at the same time? Does this imply > > that the bus _always_ needs to do some serializing there? > > You want to test it? Be my guest. It was more a rhetorical question. I

Re: [PATCH] change zonelist order v5 [1/3] implements zonelist order selection

2007-05-08 Thread Lee Schermerhorn
On Tue, 2007-05-08 at 11:05 -0700, Christoph Lameter wrote: > On Tue, 8 May 2007, Lee Schermerhorn wrote: > > > > So far testing is IA64 only? > > Yes, so far. I will test on an Opteron platform this pm. > > Assume that no news is good news. > > A better assumption: no news -> no testing. Be

Re: Bogus section mismatch errors?

2007-05-08 Thread David Miller
From: Sam Ravnborg <[EMAIL PROTECTED]> Date: Tue, 8 May 2007 13:52:20 +0200 > There are in slab a function that is not marked __init that refer to a > function marked > __init. But the logic surrounding makes it OK. > > I have no fix/workaround for this. > Andres has suggested that we should mar

[PATCH -mm] swsusp: Use reasonable default for hibernation_mode

2007-05-08 Thread Rafael J. Wysocki
From: Rafael J. Wysocki <[EMAIL PROTECTED]> Make sure that hibernation_mode is set to a reasonable value by default. Signed-off-by: Rafael J. Wysocki <[EMAIL PROTECTED]> --- kernel/power/disk.c |9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) Index: linux-2.6.21/kernel/power/di

Slow usb-storage detection prevents RAID autodetection

2007-05-08 Thread Lasse Karkkainen
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On boot, it takes a while until USB disks are detected, and before this the kernel may have already reached the RAID autodetection stage (in which case RAID arrays from USB storage will not be detected at all), and may even have tried mounting the root

[GIT PULL] MMC updates

2007-05-08 Thread Pierre Ossman
Linus, please pull from git://git.kernel.org/pub/scm/linux/kernel/git/drzeus/mmc.git for-linus to receive the following updates: drivers/misc/tifm_7xx1.c | 27 --- drivers/mmc/Kconfig| 10 +- drivers/mmc/card/Kconfig |3 +-- drivers/mm

Re: Lockup after logging out of X

2007-05-08 Thread Ken Moffat
On Tue, May 08, 2007 at 04:21:51PM -0400, [EMAIL PROTECTED] wrote: > On Tue, 08 May 2007 20:51:42 BST, Ken Moffat said: > > > After trying git-bisect, it tells me: > > 0dbf7028c0c1f266c9631139450a1502d3cd457e is first bad commit > > commit 0dbf7028c0c1f266c9631139450a1502d3cd457e > > Author: Vive

[PATCH] swsusp: Fix comment it register_nosave_region

2007-05-08 Thread Rafael J. Wysocki
From: Rafael J. Wysocki <[EMAIL PROTECTED]> Fix a typo in the comment before register_nosave_region(). Signed-off-by: Rafael J. Wysocki <[EMAIL PROTECTED]> --- kernel/power/snapshot.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux-2.6.21/kernel/power/snapshot.c ==

Re: Please revert 5adc55da4a7758021bcc374904b0f8b076508a11 (PCI_MULTITHREAD_PROBE)

2007-05-08 Thread Cornelia Huck
On Tue, 8 May 2007 13:01:21 -0700 (PDT), Linus Torvalds <[EMAIL PROTECTED]> wrote: > Instead of changing existign probe functionality to be asynchronous, we > could *add* a new and asynchronous part to it. For example, we could make > the rule for PCI - or other bus - devices be: > > - the bus

[PATCH 2/4] v9fs: move non-vfs related headers to include/net/9p

2007-05-08 Thread Latchesar Ionkov
This patchset moves non-filesystem interfaces of v9fs from fs/9p to net/9p. It moves the transport, packet marshalling and connection layers to net/9p leaving only the VFS related files in fs/9p. This patch: Moves the non-VFS related header files from fs/9p to include/net/9p. Signed-off-by: Lat

[PATCH] doc: what a patch series is

2007-05-08 Thread Randy Dunlap
Andrew, Jeff: would you update tpp.txt and patch-format.html respectively to clarify this? (I can send patches if you prefer that.) From: Randy Dunlap <[EMAIL PROTECTED]> It seems that we need to clarify that a patch series is a series of related patches rather than "here are some of my patche

Re: [PATCH 1/2] LogFS proper

2007-05-08 Thread Thomas Gleixner
On Tue, 2007-05-08 at 22:25 +0200, Jörn Engel wrote: > > > > Please comment the structure with kernel doc comments and avoid the tail > > > > comments. > > > > > > I'd like to hear your rationale. > > > > Kernel doc comments as: > > > > /** > > * struct hrtimer - the basic hrtimer structure > >

Re: Please pull 'revert-libertas' branch of wireless-2.6

2007-05-08 Thread Jeff Garzik
David Miller wrote: From: "Pekka Enberg" <[EMAIL PROTECTED]> On 5/7/07, Jeff Garzik <[EMAIL PROTECTED]> wrote: Open source is about release early, release often. Not "hide code in a dark corner until Christoph thinks it is perfect." We have high standards for upstream merged code, but that st

Re: Please revert 5adc55da4a7758021bcc374904b0f8b076508a11 (PCI_MULTITHREAD_PROBE)

2007-05-08 Thread David Miller
From: Greg KH <[EMAIL PROTECTED]> Date: Tue, 8 May 2007 07:07:53 -0700 > Only if it ends up working properly. The commit you reference above > (which removed the PCI_MULTITHREAD_PROBE option), is fine, pci > multi-threaded probing is still broken as it is a model that PCI drivers > are not yet re

Re: [PATCH 2/2] file capabilities: accomodate >32 bit capabilities

2007-05-08 Thread Andreas Dilger
On May 08, 2007 14:17 -0500, Serge E. Hallyn wrote: > As the capability set changes and distributions start tagging > binaries with capabilities, we would like for running an older > kernel to not necessarily make those binaries unusable. > > (0. Enable the CONFIG_SECURITY_FS_CAPABILITIES o

Re: Please pull 'revert-libertas' branch of wireless-2.6 (was Re: Please pull 'libertas' branch of wireless-2.6)

2007-05-08 Thread Jeff Garzik
Nick Piggin wrote: Two things on top of a lot of people's pet peeves list are lack of good review bandwidth, and poor driver code! So it is sad this was merged without Christoph's comments being addressed. "it works for me, we can fix it later" is probably a big reason for quality problems of som

Re: gmail

2007-05-08 Thread David Miller
From: Gene Heskett <[EMAIL PROTECTED]> Date: Tue, 8 May 2007 10:35:03 -0400 > verizon forced me over to a gmail account by refusing this mailing list. > Now lkml seems to be refusing posts from my gmail account. > > Is there a reason? I just forwarded to you a copy of a bounce so you can try to

Re: [PATCH 1/2] LogFS proper

2007-05-08 Thread Jörn Engel
On Tue, 8 May 2007 22:15:18 +0300, Pekka Enberg wrote: > On 5/8/07, Jörn Engel <[EMAIL PROTECTED]> wrote: > >> > +typedef __be16 be16; > >> > +typedef __be32 be32; > >> > +typedef __be64 be64; > >> > >> Why are those typedefs necessary ? > > > >Not strictly. I tend to use the be* types fairly ofte

Re: [RFC/PATCH] doc: volatile considered evil

2007-05-08 Thread Jeremy Fitzhardinge
Krzysztof Halasa wrote: > David Rientjes <[EMAIL PROTECTED]> writes: > > >> Since 'volatile' has two different semantics depending on the context in >> which it is used, this warning should be appended to include the fact that >> it is legitimate to use for inline assembly. >> > > I think

Preempt of BKL and with tickless systems

2007-05-08 Thread Bill Davidsen
I think I have a reasonable grip on the voluntary and full preempt models, can anyone give me any wisdom on the preempt of the BKL? I know what it does, the question is where it might make a difference under normal loads. Define normal as servers and desktops. I've been running some sched test

Re: [PATCH 1/8] Restructuring hpet timer generic clock interfaces

2007-05-08 Thread S.Çağlar Onur
08 May 2007 Sal tarihinde, Pallipadi, Venkatesh şunları yazmıştı: > Hmm. Looks like timer was somehow not set correctly. > Can you try only the first 5 patches in the patchset and leave out the last > three and check whether it works. Yep, first 5 patches works fine, [EMAIL PROTECTED]> dmesg | g

Re: [RFC/PATCH] doc: volatile considered evil

2007-05-08 Thread Krzysztof Halasa
Jeremy Fitzhardinge <[EMAIL PROTECTED]> writes: > No, David means that "asm volatile (...)" is meaningful and OK to use. Ok, I mistook that. -- Krzysztof Halasa - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo

[patch 0/4] A series of cleanup patches

2007-05-08 Thread Jeremy Fitzhardinge
Hi Andi, Andrew, Here's a series of cleanup patches: 1. add kstrndup, which is needed by 2. add argv_split, a helper for splitting a string into an argv array, 3. a restructuring of the call_usermodehelper set of functions, to make them more flexible, needed by 4. a common orderly_poweroff() f

[patch 2/4] add argv_split()

2007-05-08 Thread Jeremy Fitzhardinge
argv_split() is a helper function which takes a string, splits it at whitespace, and returns a NULL-terminated argv vector. This is deliberately simple - it does no quote processing of any kind. [ Seems to me that this is something which is already being done in the kernel, but I couldn't find

[patch 4/4] Add common orderly_poweroff()

2007-05-08 Thread Jeremy Fitzhardinge
Various pieces of code around the kernel want to be able to trigger an orderly poweroff. This pulls them together into a single implementation. By default the poweroff command is /sbin/poweroff, but it can be set via sysctl: kernel/poweroff_cmd. This is split at whitespace, so it can include com

[patch 3/4] split usermodehelper setup from execution

2007-05-08 Thread Jeremy Fitzhardinge
Rather than having hundreds of variations of call_usermodehelper for various pieces of usermode state which could be set up, split the info allocation and initialization from the actual process execution. This means the general pattern becomes: info = call_usermodehelper_setup(path, argv, envp);

[patch 1/4] add kstrndup

2007-05-08 Thread Jeremy Fitzhardinge
Add a kstrndup function, modelled on strndup. Like strndup this returns a string copied into its own allocated memory, but it copies no more than the specified number of bytes from the source. Remove private strndup() from irda code. Signed-off-by: Jeremy Fitzhardinge <[EMAIL PROTECTED]> Cc: Chr

Re: [PATCH 1/4] v9fs: rename non-vfs related structs and functions to be moved to net/9p

2007-05-08 Thread Andrew Morton
On Tue, 8 May 2007 14:51:02 -0600 "Latchesar Ionkov" <[EMAIL PROTECTED]> wrote: > This patchset moves non-filesystem interfaces of v9fs from fs/9p to net/9p. > It moves the transport, packet marshalling and connection layers to net/9p > leaving only the VFS related files in fs/9p. (Please cc [EMA

Re: New Mitsumi legacy CD-ROM driver

2007-05-08 Thread Bob Tracy
Ondrej Zary wrote: > On Tuesday 08 May 2007 11:42:08 you wrote: > > Mitsumi (mcdx, this driver), panasonic (sbpcd) and sony (cdu31a) are > > somewhat of an exception in so far that controllers for those three are > > still around on a lot of old ISA soundcards though. Moreover, I have the > > drive

Re: [PATCH] synclink_gt add compat_ioctl

2007-05-08 Thread Paul Fulghum
On Sun, 2007-05-06 at 02:27 +0200, Arnd Bergmann wrote: > Now that you mention the duplication, this sounds wrong as well. The easiest > solution is probably to just put the definition of your data structure > inside of #ifdef CONFIG_COMPAT in the header file. The structure definition was already

Re: Please revert 5adc55da4a7758021bcc374904b0f8b076508a11 (PCI_MULTITHREAD_PROBE)

2007-05-08 Thread David Miller
From: Linus Torvalds <[EMAIL PROTECTED]> Date: Tue, 8 May 2007 08:27:34 -0700 (PDT) > Threading at the bus level just inevitably means things like random > numbers for devices depending on some timing/scheduling issue. That's > nasty. I hadn't considered this issue, so ignore the other reply I

Re: [PATCH 1/2] V4L: videodev, allow VIDIOCGMBUF

2007-05-08 Thread Mauro Carvalho Chehab
Hi Jiri, > if (_IOC_TYPE(cmd)=='v') > - return v4l_compat_translate_ioctl(inode,file,cmd,arg, > +#ifdef CONFIG_VIDEO_V4L1_COMPAT > + if (cmd != VIDIOCGMBUF) /* <-- handled below vvv */ > +#endif > + return v4l_compat_translate_ioctl(inode,file,cmd,

Re: "modularized" 2.4.34.4 -> ide-core "unresolved symbols"

2007-05-08 Thread Willy Tarreau
Hi Zbigniew, [first, please always keep people in CC when posting on LKML] On Tue, May 08, 2007 at 10:23:34PM +0200, Zbigniew Baniewski wrote: > On Sun, May 06, 2007 at 06:36:45AM +0200, Willy Tarreau wrote: > > > Could you please be a bit more precise : > > - config > > Below. Thanks, I cou

Re: [RFC/PATCH] doc: volatile considered evil

2007-05-08 Thread Jeff Garzik
Jeremy Fitzhardinge wrote: No, David means that "asm volatile (...)" is meaningful and OK to use. In a driver? Highly unlikey it is OK. In a filesystem? Even more unlikely it is OK to use. The set of circumstances where 'volatile' is acceptable is very limited. You will see it used prope

Re: [PATCH 1/3] [POWERPC] 8xx: mpc885ads pcmcia support

2007-05-08 Thread Vitaly Bordug
On Tue, 8 May 2007 09:04:22 -0500 Kumar Gala wrote: > > + device_type = "pcmcia"; > > + reg = <80 80>; > > + clock-frequency = <2faf080>; > > is the clock-freq fixed? As I see now, that field is not really required as never extracted or used

Re: CodingStyle: start flamewar about use of braces

2007-05-08 Thread Jeff Garzik
Randy Dunlap wrote: On Tue, 8 May 2007 19:03:10 GMT Linux Kernel Mailing List wrote: Gitweb: http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=e659ba4a0d2d471c0d73590f78e1a1b5a1eede48 Commit: e659ba4a0d2d471c0d73590f78e1a1b5a1eede48 Parent: 28be5abb400

Re: [RFC/PATCH] doc: volatile considered evil

2007-05-08 Thread Jeremy Fitzhardinge
David Rientjes wrote: > Since 'volatile' has two different semantics depending on the context in > which it is used, this warning should be appended to include the fact that > it is legitimate to use for inline assembly. > It's probably worth noting that "asm volatile (...)" doesn't mean wha

Re: [PATCH 2/2] V4L: v4l1-compat, fix VIDIOCSPICT for non-OVERLAY

2007-05-08 Thread Mauro Carvalho Chehab
Hi Jiri, Em Ter, 2007-05-08 às 20:25 +0200, Jiri Slaby escreveu: > v4l1-compat, fix VIDIOCSPICT for non-OVERLAY > > Do not return EINVAL for devices, which don't support overlay. The patch bellow also provides a proper fix for VIDIOCSPICT: http://git.kernel.org/?p=linux/kernel/git/mchehab/v4l-d

RE: [PATCH 1/8] Restructuring hpet timer generic clock interfaces

2007-05-08 Thread Pallipadi, Venkatesh
>-Original Message- >From: S.Çağlar Onur [mailto:[EMAIL PROTECTED] >Sent: Tuesday, May 08, 2007 2:08 PM >To: Pallipadi, Venkatesh >Cc: linux-kernel; Andrew Morton; Thomas Gleixner; Andi Kleen; >Ingo Molnar; Chris Wright >Subject: Re: [PATCH 1/8] Restructuring hpet timer generic >clock

Re: [rfc] lock bitops

2007-05-08 Thread Benjamin Herrenschmidt
On Tue, 2007-05-08 at 09:06 -0600, Matthew Wilcox wrote: > On Tue, May 08, 2007 at 01:37:09PM +0200, Nick Piggin wrote: > > -- > > Introduce test_and_set_bit_lock / clear_bit_unlock bitops with lock > > semantics. > > Add non-trivial for powerpc and ia64. Convert page lock, buffer lock, > > bit_sp

Re: [RFC/PATCH] doc: volatile considered evil

2007-05-08 Thread Randy Dunlap
Jeff Garzik wrote: Jeremy Fitzhardinge wrote: No, David means that "asm volatile (...)" is meaningful and OK to use. I thought it was OK in readl(), writel(), etc... (and in asm), but that's it. (and jiffies) In a driver? Highly unlikey it is OK. In a filesystem? Even more unlikely it is

Re: [RFC/PATCH] doc: volatile considered evil

2007-05-08 Thread Randy Dunlap
Jeremy Fitzhardinge wrote: David Rientjes wrote: Since 'volatile' has two different semantics depending on the context in which it is used, this warning should be appended to include the fact that it is legitimate to use for inline assembly. It's probably worth noting that "asm volatile (

Re: [RFC/PATCH] doc: volatile considered evil

2007-05-08 Thread Jeff Garzik
Randy Dunlap wrote: Jeff Garzik wrote: Jeremy Fitzhardinge wrote: No, David means that "asm volatile (...)" is meaningful and OK to use. I thought it was OK in readl(), writel(), etc... (and in asm), but that's it. (and jiffies) In a driver? Highly unlikey it is OK. In a filesystem? Even

Re: Please pull 'revert-libertas' branch of wireless-2.6

2007-05-08 Thread Dan Williams
On Tue, 2007-05-08 at 16:55 -0400, Jeff Garzik wrote: > David Miller wrote: > > From: "Pekka Enberg" <[EMAIL PROTECTED]> > >> On 5/7/07, Jeff Garzik <[EMAIL PROTECTED]> wrote: > >>> Open source is about release early, release often. Not "hide code in a > >>> dark corner until Christoph thinks it i

Re: [PATCH] [x86-64] Add getcpu and epoll_pwait system calls.

2007-05-08 Thread Chris Wedgwood
On Tue, May 08, 2007 at 11:37:26AM -0700, Chris Wedgwood wrote: > +#define __NR_getcpu 280 I see something was merged just now that uses 280. Should I resubmit this using 281 & 282? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EM

Re: [PATCH 1/8] Restructuring hpet timer generic clock interfaces

2007-05-08 Thread S.Çağlar Onur
09 May 2007 Çar tarihinde, Pallipadi, Venkatesh şunları yazmıştı: > That's good news :-). > > Can you send me the full dmesg with the 5 patches and also the config file > you are using. Also, did you try these patches against 2.6.21-vanilla or > recent git? I'm trying these on top of 2.6.21.1 + C

Re: [RFC/PATCH] doc: volatile considered evil

2007-05-08 Thread David Rientjes
On Tue, 8 May 2007, Jeremy Fitzhardinge wrote: > It's probably worth noting that "asm volatile (...)" doesn't mean what > many people think it means: specifically, it *does not* prevent the asm > from being reordered with respect to the surrounding code. It may not > even prevent it from being re

Re: [rfc] optimise unlock_page

2007-05-08 Thread Benjamin Herrenschmidt
On Tue, 2007-05-08 at 13:40 +0200, Nick Piggin wrote: > This patch trades a page flag for a significant improvement in the unlock_page > fastpath. Various problems in the previous version were spotted by Hugh and > Ben (and fixed in this one). > > Comments? > > -- > > Speed up unlock_page by int

Re: [PATCH 1/2] LogFS proper

2007-05-08 Thread Jörn Engel
On Tue, 8 May 2007 22:58:26 +0200, Thomas Gleixner wrote: > On Tue, 2007-05-08 at 22:25 +0200, Jörn Engel wrote: > > > > > > Kernel doc comments as: > > > > > > /** > > > * struct hrtimer - the basic hrtimer structure > > > * @node: red black tree node for time ordered insertion > > > *

Re: [RFC/PATCH] doc: volatile considered evil

2007-05-08 Thread Jeremy Fitzhardinge
David Rientjes wrote: > Ok, so let's take your second paragraph and my email of an hour ago: > > In an asm construct, if all your input operands are modified and > specified as output operands as well, volatile must be added so > that the entire construct is not optimized away.

Re: Please revert 5adc55da4a7758021bcc374904b0f8b076508a11 (PCI_MULTITHREAD_PROBE)

2007-05-08 Thread David Miller
From: Linus Torvalds <[EMAIL PROTECTED]> Date: Tue, 8 May 2007 13:01:21 -0700 (PDT) > In fact, there is nothing wrong with having *both* a synchronous part, and > an async part: > > .probe = mydriver_setup, > .probe_async = mydriver_spin_up_and_probe_devices, ... > Hmm? Would someth

kernel oops after ACPI dock initialization fails

2007-05-08 Thread Chuck Ebbert
In 2.6.21.1 when dock driver initialization fails it does a kfree() of dock_station. (Below, this is due to some error installing a notify handler.) Later when a bay is discovered it calls is_dock_device() which attempts to lock the (nonexistent) dock_station. Reason is this test in is_dock_device

Re: Please revert 5adc55da4a7758021bcc374904b0f8b076508a11 (PCI_MULTITHREAD_PROBE)

2007-05-08 Thread Stefan Richter
[EMAIL PROTECTED] wrote: > I have used userspace tools for managing multiple machines that spawn > tasks in parallel on multiple machines and then buffers them per-machine > to display the output of the commands in order, no matter which one > finished first. > > for example 'dsh m1,m2 ls /' would

Re: [patch 4/4] Add common orderly_poweroff()

2007-05-08 Thread Len Brown
On Tuesday 08 May 2007 16:51, Jeremy Fitzhardinge wrote: > Various pieces of code around the kernel want to be able to trigger an > orderly poweroff. This pulls them together into a single > implementation. > > By default the poweroff command is /sbin/poweroff, but it can be set > via sysctl: ker

Re: [PATCH 2/2] file capabilities: accomodate >32 bit capabilities

2007-05-08 Thread Serge E. Hallyn
Quoting Andreas Dilger ([EMAIL PROTECTED]): > On May 08, 2007 14:17 -0500, Serge E. Hallyn wrote: > > As the capability set changes and distributions start tagging > > binaries with capabilities, we would like for running an older > > kernel to not necessarily make those binaries unusable. > > >

RE: Regression with SLUB on Netperf and Volanomark

2007-05-08 Thread Tim Chen
On Mon, 2007-05-07 at 18:49 -0700, Christoph Lameter wrote: > On Mon, 7 May 2007, Tim Chen wrote: > > > However, the output from TCP_STREAM is quite stable. > > I am still seeing a 4% difference between the SLAB and SLUB kernel. > > Looking at the L2 cache miss rate with emon, I saw 6% more cach

Re: kernel oops after ACPI dock initialization fails

2007-05-08 Thread Chuck Ebbert
Chuck Ebbert wrote: > In 2.6.21.1 when dock driver initialization fails it does a kfree() > of dock_station. (Below, this is due to some error installing a > notify handler.) Later when a bay is discovered it calls > is_dock_device() which attempts to lock the (nonexistent) > dock_station. Reason

Re: [patch 1/4] add kstrndup

2007-05-08 Thread Randy Dunlap
On Tue, 08 May 2007 13:51:30 -0700 Jeremy Fitzhardinge wrote: > --- a/mm/util.c > +++ b/mm/util.c > @@ -18,7 +18,7 @@ void *__kzalloc(size_t size, gfp_t flags > } > EXPORT_SYMBOL(__kzalloc); > > -/* > +/** > * kstrdup - allocate space for and copy an existing string No blank ("*") line betw

Re: [patch 2/4] add argv_split()

2007-05-08 Thread Randy Dunlap
On Tue, 08 May 2007 13:51:31 -0700 Jeremy Fitzhardinge wrote: > --- /dev/null > +++ b/lib/argv_split.c > @@ -0,0 +1,160 @@ > + > +static const char *skip_sep(const char *cp) > +{ > + while(*cp && isspace(*cp)) Kernel style is space after "while", "for", "if"... > + cp++; > + > +

Re: [patch 3/4] split usermodehelper setup from execution

2007-05-08 Thread Randy Dunlap
On Tue, 08 May 2007 13:51:32 -0700 Jeremy Fitzhardinge wrote: > --- a/kernel/kmod.c > +++ b/kernel/kmod.c > @@ -253,11 +262,94 @@ static void __call_usermodehelper(struct > } > > /** > - * call_usermodehelper_keys - start a usermode application > - * @path: pathname for the application > - * @

Re: [patches] [PATCH] [21/22] x86_64: Extend bzImage protocol for relocatable bzImage

2007-05-08 Thread yhlu
On 5/8/07, Eric W. Biederman <[EMAIL PROTECTED]> wrote: You might try a git-bisect, or if it is just these patches walking through them one-by-one. f82af20e1a028e16b9bb11da081fa1148d40fa6a is first bad commit commit f82af20e1a028e16b9bb11da081fa1148d40fa6a Author: Gerd Hoffmann <[EMAIL PROTECTE

Re: [RFC/PATCH] doc: volatile considered evil

2007-05-08 Thread David Rientjes
On Tue, 8 May 2007, Jeremy Fitzhardinge wrote: > > In an asm construct, if all your input operands are modified and > > specified as output operands as well, volatile must be added so > > that the entire construct is not optimized away. Additionally, > > it must be added if you

Re: [patch 3/4] split usermodehelper setup from execution

2007-05-08 Thread Jeremy Fitzhardinge
Randy Dunlap wrote: > On Tue, 08 May 2007 13:51:32 -0700 Jeremy Fitzhardinge wrote: > > >> --- a/kernel/kmod.c >> +++ b/kernel/kmod.c >> @@ -253,11 +262,94 @@ static void __call_usermodehelper(struct >> } >> >> /** >> - * call_usermodehelper_keys - start a usermode application >> - * @path:

RE: Regression with SLUB on Netperf and Volanomark

2007-05-08 Thread Christoph Lameter
On Tue, 8 May 2007, Tim Chen wrote: > I tried the slub-patches and the avoid atomic overhead patch against > 2.6.21-mm1. It brings the TCP_STREAM performance for SLUB to the SLAB > level. The patches not mentioned in the "series" file did not apply > cleanly to 2.6.21-mm1 and I skipped most of t

Re: [patch 4/4] Add common orderly_poweroff()

2007-05-08 Thread Randy Dunlap
On Tue, 08 May 2007 13:51:33 -0700 Jeremy Fitzhardinge wrote: > diff -r 9eea40ea89b7 kernel/sys.c > --- a/kernel/sys.cTue May 08 12:59:41 2007 -0700 > +++ b/kernel/sys.cTue May 08 13:42:22 2007 -0700 > @@ -2208,3 +2208,58 @@ asmlinkage long sys_getcpu(unsigned __us > } > return

Re: [RFC/PATCH] doc: volatile considered evil

2007-05-08 Thread Jeremy Fitzhardinge
David Rientjes wrote: > Now if all such output operands are to specify that the input operands > were "modified", 'volatile' is required to ensure the side-effects are > preserved or, otherwise, gcc is free optimize the entire asm construct > away since it appears to be unused. > Yup. >> Ye

Re: 2.6.21-ext4-1

2007-05-08 Thread Mingming Cao
On Tue, 2007-05-08 at 12:50 +1000, David Chinner wrote: > On Mon, May 07, 2007 at 01:56:23PM -0700, Mingming Cao wrote: > > In any case, it would be useful to add a new set of testsuites for the > > new fallocate() syscall and fsstress in LTP testsuites to automatically > > the preallocation code i

Re: [V9fs-developer] [PATCH 1/4] v9fs: rename non-vfs related structs and functions to be moved to net/9p

2007-05-08 Thread Eric Van Hensbergen
On 5/8/07, Andrew Morton <[EMAIL PROTECTED]> wrote: On Tue, 8 May 2007 14:51:02 -0600 "Latchesar Ionkov" <[EMAIL PROTECTED]> wrote: > This patchset moves non-filesystem interfaces of v9fs from fs/9p to net/9p. > It moves the transport, packet marshalling and connection layers to net/9p > leaving

Re: [patch 3/4] split usermodehelper setup from execution

2007-05-08 Thread Randy Dunlap
On Tue, 08 May 2007 15:00:44 -0700 Jeremy Fitzhardinge wrote: > Randy Dunlap wrote: > > On Tue, 08 May 2007 13:51:32 -0700 Jeremy Fitzhardinge wrote: > > > > > >> --- a/kernel/kmod.c > >> +++ b/kernel/kmod.c > >> @@ -253,11 +262,94 @@ static void __call_usermodehelper(struct > >> } > >> > >>

Re: [patches] [PATCH] [21/22] x86_64: Extend bzImage protocol for relocatable bzImage

2007-05-08 Thread Jeremy Fitzhardinge
yhlu wrote: > On 5/8/07, Eric W. Biederman <[EMAIL PROTECTED]> wrote: >> You might try a git-bisect, or if it is just these patches >> walking through them one-by-one. > > f82af20e1a028e16b9bb11da081fa1148d40fa6a is first bad commit > commit f82af20e1a028e16b9bb11da081fa1148d40fa6a > Author: Gerd H

Re: [PATCH] synclink_gt add compat_ioctl

2007-05-08 Thread Arnd Bergmann
On Tuesday 08 May 2007, Paul Fulghum wrote: > make[3]: *** No rule to make target > `/usr/src/devel/usr/include/linux/.check.synclink.h', needed by > `__headerscheck'.  Stop. > > linux/kexec.h includes linux/compat.h without a similar error, > though that is inside of a #ifdef CONFIG_KEXEC > > Mo

Re: [PATCH 0/2] LogFS take two

2007-05-08 Thread Jörn Engel
On Tue, 8 May 2007 01:53:38 -0400, Albert Cahalan wrote: > > You seem to be missing the immutable bit. This is really useful > for dealing with buggy or badly-designed things running as root. > I've used to to protect /dev/null from becoming a normal file > filled with junk, and to protect /etc/re

Re: kmem_cache_init failure (was Re: 2.6.21-mm1)

2007-05-08 Thread Andi Kleen
On Tue, May 08, 2007 at 07:22:33PM +0200, Frederik Deweerdt wrote: > On Sat, May 05, 2007 at 01:49:55AM -0700, Andrew Morton wrote: > > > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.21/2.6.21-mm1/ > > > Hi all, > > My computer fails early at boot with a stack along the li

[PATCH] different values for OHCI_QUIRK_ZFMICRO

2007-05-08 Thread Randy Dunlap
On Thu, 29 Mar 2007 15:24:00 -0700 David Brownell wrote: > On Thursday 29 March 2007 3:06 pm, Randy Dunlap wrote: > > On Tue, 20 Feb 2007 01:06:54 +0100 Adrian Bunk wrote: > > > > > On Sun, Jan 14, 2007 at 06:36:10AM -0800, David Brownell wrote: > > > > On Sunday 14 January 2007 1:10 am, Adrian B

[uPATCH] a logitech mouse ID

2007-05-08 Thread Peter Samuelson
Adds the ID to recognise my PS/2 TrackMan Marble. This is purely cosmetic: this is standard 3-button, no wheel or other such features, so it already _worked_ just fine. This patch suppresses a warning about the unknown model, and changes the printk from "Mouse" to "TrackMan". Signed-Off-By: Pet

Re: [PATCH] [x86-64] Add getcpu and epoll_pwait system calls.

2007-05-08 Thread Andi Kleen
On Tue, May 08, 2007 at 11:37:26AM -0700, Chris Wedgwood wrote: > Signed-off-by: Chris Wedgwood <[EMAIL PROTECTED]> > --- > include/asm-x86_64/unistd.h |4 > 1 files changed, 4 insertions(+), 0 deletions(-) > diff --git a/include/asm-x86_64/unistd.h b/include/asm-x86_64/unistd.h > index 2

Re: [PATCH Resend] - SN: validate smp_affinity mask on intr

2007-05-08 Thread John Keller
> > On Tue, 8 May 2007 13:14:26 -0700 > "Luck, Tony" <[EMAIL PROTECTED]> wrote: > > > > It had a dopey little bug: > > > > > > -#define is_affinity_mask_valid() 1 > > > +#define is_affinity_mask_valid(val) 1 > > > > That would fix warnings on non-ia64 systems (which is > > a step in the right di

Re: "modularized" 2.4.34.4 -> ide-core "unresolved symbols"

2007-05-08 Thread Zbigniew Baniewski
On Tue, May 08, 2007 at 11:16:46PM +0200, Willy Tarreau wrote: > depmod: init_cmd640_vlb There wasn't such message. > > See also other similar reports, f.e.: > > > > http://linux.derkeiler.com/Mailing-Lists/Kernel/2006-05/msg07966.html > > http://www.unixadmintalk.com/f59/kernel-compile

Re: [PATCH] [x86-64] Add getcpu and epoll_pwait system calls.

2007-05-08 Thread Chris Wedgwood
On Wed, May 09, 2007 at 12:13:48AM +0200, Andi Kleen wrote: > Nope. There already is a getcpu vsyscall. This is not needed. The kbuild magic that checks for missing syscalls needs to be taught about this then I take it? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

Re: [RFC/PATCH] doc: volatile considered evil

2007-05-08 Thread David Rientjes
On Tue, 8 May 2007, Jeremy Fitzhardinge wrote: > > You're point about reordering "asm volatile" constructs differs depending > > on -mvolatile-asm-stop or -mno-volatile-asm-stop, however. > > > > Erm, that seems to be ia64 specific, and I have no idea what adding a > "stop bit" implies. Can

Re: Please revert 5adc55da4a7758021bcc374904b0f8b076508a11 (PCI_MULTITHREAD_PROBE)

2007-05-08 Thread Stefan Richter
David Miller wrote: [persistent unique device property -> persistent unique device name] > Those mappings should exist statically somewhere, not depend upon > something as frivolous as probe ordering. We do this all the time for hotpluggable hardware. And bus types without hotplugging capability

Re: [PATCH] synclink_gt add compat_ioctl

2007-05-08 Thread Paul Fulghum
Arnd Bergmann wrote: To solve this, you can to change include/linux/Kbuild to list synclink.h as unifdef-y instead of header-y, and put the parts that you don't want to be in user space inside of #ifdef __KERNEL__. Alternatively, you can put these kernel-internal definitions into a private heade

Re: [PATCH] [x86-64] Add getcpu and epoll_pwait system calls.

2007-05-08 Thread Andi Kleen
On Tue, May 08, 2007 at 03:16:56PM -0700, Chris Wedgwood wrote: > On Wed, May 09, 2007 at 12:13:48AM +0200, Andi Kleen wrote: > > > Nope. There already is a getcpu vsyscall. This is not needed. > > The kbuild magic that checks for missing syscalls needs to be taught > about this then I take it?

Re: CodingStyle: start flamewar about use of braces

2007-05-08 Thread Lennart Sorensen
On Tue, May 08, 2007 at 05:19:45PM -0400, Jeff Garzik wrote: > >>+Do not unnecessarily use braces where a single statement will do. > >>+ > >>+if (condition) > >>+ action(); > >>+ > >>+This does not apply if one branch of a conditional statement is a single > >>+statement. Use braces in both bran

Re: [PATCH] Make bootsector stub 16-bit-only (i386)

2007-05-08 Thread H. Peter Anvin
Alexander van Heukelum wrote: > On Tue, May 08, 2007 at 11:45:47AM -0700, H. Peter Anvin wrote: >> Alexander van Heukelum wrote: >>> Oh! A padding hole in a struct! That could be a problem. If the freeze >>> is after decompression, could you test if this makes it work again? >>> >> The correct fix

Re: [RFC/PATCH] doc: volatile considered evil

2007-05-08 Thread Jeremy Fitzhardinge
David Rientjes wrote: > It is analogous with a sequence point for ia64. But, as you mentioned, it > is ia64 specific so your comment about "asm volatile" constructs not being > reordered is always appropriate outside of ia64 specific code but may not > apply to ia64 if we ever compiled with -mv

Re: [rfc] lock bitops

2007-05-08 Thread Nick Piggin
On Tue, May 08, 2007 at 09:06:32AM -0600, Matthew Wilcox wrote: > On Tue, May 08, 2007 at 01:37:09PM +0200, Nick Piggin wrote: > > -- > > Introduce test_and_set_bit_lock / clear_bit_unlock bitops with lock > > semantics. > > Add non-trivial for powerpc and ia64. Convert page lock, buffer lock, > >

[PATCH 0/3] 8xx PCMCIA stuff && cleanup: take 4

2007-05-08 Thread Vitaly Bordug
Hopefully last round, with Kumar's notes addressed, and BSP mpc885_setup.c Lindented in 2-nd patch as well as PCMCIA driver. - Sincerely, Vitaly - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://v

Re: kernel oops after ACPI dock initialization fails

2007-05-08 Thread Kristen Carlson Accardi
On Tue, 08 May 2007 17:54:40 -0400 Chuck Ebbert <[EMAIL PROTECTED]> wrote: > Chuck Ebbert wrote: > > In 2.6.21.1 when dock driver initialization fails it does a kfree() > > of dock_station. (Below, this is due to some error installing a > > notify handler.) Later when a bay is discovered it calls

[PATCH 1/3] [POWERPC] 8xx: mpc885ads pcmcia support

2007-05-08 Thread Vitaly Bordug
Adds support for PowerQuicc on-chip PCMCIA. The driver is implemented as of_device, so only arch/powerpc stuff is capable to use it, which now implies only mpc885ads reference board. To cope with the code that should be hooked inside driver, but is really board specific (like set_voltage), global

[PATCH 3/3] [POWERPC] dts: kill hardcoded phandles

2007-05-08 Thread Vitaly Bordug
Removed explicit linux,phandle usage. Using references and labels now in PQ and PQ2 boards currently supported in arch/powerpc. Signed-off-by: Vitaly Bordug <[EMAIL PROTECTED]> --- arch/powerpc/boot/dts/mpc8272ads.dts | 42 +++- arch/powerpc/boot/dts/mpc866ads.dts

[PATCH 2/3] [POWERPC] 8xx: fix whitespace and indentation

2007-05-08 Thread Vitaly Bordug
Rolling forward PCMCIA driver, it was discovered that the indentation in existing one, as well as in BSP side are very odd. This patch is just result of Lindent run ontop of culprit files. Signed-off-by: Vitaly Bordug <[EMAIL PROTECTED]> --- arch/powerpc/platforms/8xx/mpc885ads_setup.c | 125

Re: [rfc] lock bitops

2007-05-08 Thread Nick Piggin
On Tue, May 08, 2007 at 01:22:56PM +0100, David Howells wrote: > Nick Piggin <[EMAIL PROTECTED]> wrote: > > > This patch (along with the subsequent one to optimise unlock_page) reduces > > the overhead of lock_page/unlock_page (measured with page faults and a patch > > to lock the page in the faul

Re: [PATCH] different values for OHCI_QUIRK_ZFMICRO

2007-05-08 Thread David Brownell
On Tuesday 08 May 2007, Randy Dunlap wrote: > On Thu, 29 Mar 2007 15:24:00 -0700 David Brownell wrote: > > > On Thursday 29 March 2007 3:06 pm, Randy Dunlap wrote: > > > On Tue, 20 Feb 2007 01:06:54 +0100 Adrian Bunk wrote: > > > > > > > On Sun, Jan 14, 2007 at 06:36:10AM -0800, David Brownell wr

Re: [patch 2/4] add argv_split()

2007-05-08 Thread Jan Engelhardt
On May 8 2007 13:51, Jeremy Fitzhardinge wrote: >+ >+static const char *skip_sep(const char *cp) These are so simple they could use an 'inline' tag. >+{ >+ while(*cp && isspace(*cp)) >+ cp++; >+ >+ return cp; >+} >+ >+#ifdef TEST But not in the end result. >+int main()

Re: [rfc] optimise unlock_page

2007-05-08 Thread Nick Piggin
On Tue, May 08, 2007 at 01:13:35PM +0100, David Howells wrote: > > Nick Piggin <[EMAIL PROTECTED]> wrote: > > > This patch trades a page flag for a significant improvement in the > > unlock_page > > fastpath. Various problems in the previous version were spotted by Hugh and > > Ben (and fixed in

Re: [PATCH] time locale in gen_initramfs_list.sh

2007-05-08 Thread Michael Mauch
Florian Fainelli wrote: > This is true. According to GNU fileutils changelog, the nearest Changelog > message regarding this option is : > > 2004-11-19 Alfred M. Szmidt <[EMAIL PROTECTED]> > >* src/ls.c (usage): Clarified description of --no-group (-G), >--human-readable (-h),

Re: [patches] [PATCH] [21/22] x86_64: Extend bzImage protocol for relocatable bzImage

2007-05-08 Thread H. Peter Anvin
Jeremy Fitzhardinge wrote: > > Interesting. I haven't really been following this thread, but doesn't > it mean something isn't being initialized properly if this patch makes a > difference? > Specifically boot_params.screen_info isn't being properly set up by the caller. -hpa - To unsu

Re: [RFC/PATCH] doc: volatile considered evil

2007-05-08 Thread David Rientjes
On Tue, 8 May 2007, Jeremy Fitzhardinge wrote: > Sounds like it's referring to micro-architectural reordering, which is > distinct from compiler reordering. In other words, even if you > specified "-mvolatile-asm-stop" I would assume that the compiler could > still reorder the asm statements. Am

<    1   2   3   4   5   6   7   >