Re: checkpatch and kernel/sched.c

2007-10-01 Thread Willy Tarreau
On Mon, Oct 01, 2007 at 12:30:07AM -0700, Andrew Morton wrote: > On Mon, 1 Oct 2007 08:44:48 +0200 Ingo Molnar <[EMAIL PROTECTED]> wrote: > > > > > (lkml Cc:-ed - this might be of interest to others too) > > > > * Andy Whitcroft <[EMAIL PROTECTED]> wrote: > > > > > WARNING: EXPORT_SYMBOL(foo);

Re: checkpatch and kernel/sched.c

2007-10-01 Thread Andy Whitcroft
On Mon, Oct 01, 2007 at 12:30:07AM -0700, Andrew Morton wrote: > On Mon, 1 Oct 2007 08:44:48 +0200 Ingo Molnar <[EMAIL PROTECTED]> wrote: > > > > > (lkml Cc:-ed - this might be of interest to others too) > > > > * Andy Whitcroft <[EMAIL PROTECTED]> wrote: > > > > > WARNING: EXPORT_SYMBOL(foo);

Re: checkpatch and kernel/sched.c

2007-10-01 Thread Ingo Molnar
* Andrew Morton <[EMAIL PROTECTED]> wrote: > > > WARNING: braces {} are not necessary for single statement blocks > > > #5706: FILE: home/apw/git/linux-2.6/kernel/sched.c:5703: > > > + if (parent->groups == parent->groups->next) { > > > + pflags &= ~(SD_LOAD_BALANCE | > > > +

Re: checkpatch and kernel/sched.c

2007-10-01 Thread Ingo Molnar
* Andrew Morton <[EMAIL PROTECTED]> wrote: > On Mon, 01 Oct 2007 09:48:25 +0200 Avi Kivity <[EMAIL PROTECTED]> wrote: > > > Andrew Morton wrote: > > >> this is actually a false positive - as the debug code constructs a > > >> printk output _without_ \n. So the script should check whether there'

Re: checkpatch and kernel/sched.c

2007-10-01 Thread Ingo Molnar
* Andrew Morton <[EMAIL PROTECTED]> wrote: > > > WARNING: EXPORT_SYMBOL(foo); should immediately follow its > > > function/variable > > > #411: FILE: home/apw/git/linux-2.6/kernel/sched.c:408: > > > +EXPORT_SYMBOL_GPL(cpu_clock); > > > > yes, this is a legit warning and i fix it every time i se

Re: checkpatch and kernel/sched.c

2007-10-01 Thread Sam Ravnborg
> > > > > WARNING: externs should be avoided in .c files > > > #6545: FILE: home/apw/git/linux-2.6/kernel/sched.c:6542: > > > + extern char __sched_text_start[], __sched_text_end[]; > > > > > > That one ... dunno. This check is a difficult one. Should it be a > > > CHECK? > > > > no, this is

Re: checkpatch and kernel/sched.c

2007-10-01 Thread Andrew Morton
On Mon, 01 Oct 2007 09:48:25 +0200 Avi Kivity <[EMAIL PROTECTED]> wrote: > Andrew Morton wrote: > >> this is actually a false positive - as the debug code constructs a > >> printk output _without_ \n. So the script should check whether there's > >> any \n in the printk string - if there is none,

Re: checkpatch and kernel/sched.c

2007-10-01 Thread Avi Kivity
Andrew Morton wrote: >> this is actually a false positive - as the debug code constructs a >> printk output _without_ \n. So the script should check whether there's >> any \n in the printk string - if there is none, do not emit a warning. >> (if you implement that then i think it can remain a wa

Re: checkpatch and kernel/sched.c

2007-10-01 Thread Andrew Morton
On Mon, 1 Oct 2007 08:44:48 +0200 Ingo Molnar <[EMAIL PROTECTED]> wrote: > > (lkml Cc:-ed - this might be of interest to others too) > > * Andy Whitcroft <[EMAIL PROTECTED]> wrote: > > > WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable > > #411: FILE: home/apw/git/li

Re: checkpatch and kernel/sched.c

2007-09-30 Thread Ingo Molnar
(lkml Cc:-ed - this might be of interest to others too) * Andy Whitcroft <[EMAIL PROTECTED]> wrote: > WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable > #411: FILE: home/apw/git/linux-2.6/kernel/sched.c:408: > +EXPORT_SYMBOL_GPL(cpu_clock); yes, this is a legit warni