ahc_lookup_scb() may return a null pointer and further lead to
null-pointer-dereference in case DATA_OVERRUN. Fix this by adding
a null check.
Signed-off-by: Dinghao Liu
---
drivers/scsi/aic7xxx/aic7xxx_core.c | 72 +++--
1 file changed, 37 insertions(+), 35 deletions
ahd_lookup_scb() may return a null pointer and further lead to
null pointer dereference in case DATA_OVERRUN. Fix this by adding
a null check.
Signed-off-by: Dinghao Liu
---
drivers/scsi/aic7xxx/aic79xx_core.c | 44 +++--
1 file changed, 23 insertions(+), 21 deletions
On Tue, 9 Feb 2021 20:01:46 +0530, Bhaskar Chowdhury wrote:
> s/verson/version/
Applied to 5.12/scsi-queue, thanks!
[1/1] drivers: scsi: aic7xxx: Fix the spelling verson to version in the file
aic79xx.h
https://git.kernel.org/mkp/scsi/c/1f9f22acbb5d
--
Martin K. Petersen Ora
On Mon, 15 Feb 2021 19:40:49 +0800, Chen Lin wrote:
> Remove the 'ahc_bus_suspend/resume_t' typedef as it is not used.
Applied to 5.12/scsi-queue, thanks!
[1/1] scsi: aic7xxx: Remove unused function pointer typedef
ahc_bus_suspend/resume_t
https://git.kernel.org/mkp/scsi/c
Chen,
> Remove the 'ahc_bus_suspend/resume_t' typedef as it is not used.
Applied to 5.12/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
Bhaskar,
> s/verson/version/
Applied to 5.12/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
From: Chen Lin
Remove the 'ahc_bus_suspend/resume_t' typedef as it is not used.
Signed-off-by: Chen Lin
---
drivers/scsi/aic7xxx/aic7xxx.h |2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/scsi/aic7xxx/aic7xxx.h b/drivers/scsi/aic7xxx/aic7xxx.h
index 11a0979..9bc7
On 2/9/21 6:31 AM, Bhaskar Chowdhury wrote:
>
> s/verson/version/
>
> Signed-off-by: Bhaskar Chowdhury
Acked-by: Randy Dunlap
> ---
> drivers/scsi/aic7xxx/aic79xx.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/aic7x
s/verson/version/
Signed-off-by: Bhaskar Chowdhury
---
drivers/scsi/aic7xxx/aic79xx.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/aic7xxx/aic79xx.h b/drivers/scsi/aic7xxx/aic79xx.h
index dd5dfd4f30a5..c31e48fcebc7 100644
--- a/drivers/scsi/aic7xxx
From: Tom Rix
The macro use will already have a semicolon.
Signed-off-by: Tom Rix
---
drivers/scsi/aic7xxx/aic79xx_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/aic7xxx/aic79xx_core.c
b/drivers/scsi/aic7xxx/aic79xx_core.c
index 98b02e7d38bb
replacing /* FALLTHROUGH */ comments with the new
pseudo-keyword macro fallthrough.
Link: https://github.com/KSPP/linux/issues/115
Signed-off-by: Gustavo A. R. Silva
---
drivers/scsi/aic7xxx/aic79xx_core.c | 4 +++-
drivers/scsi/aic7xxx/aic7xxx_core.c | 4 ++--
2 files changed, 5 insertions(+), 3
Signed-off-by: Vaibhav Gupta
---
drivers/scsi/aic7xxx/aic7xxx.h | 10 ++
drivers/scsi/aic7xxx/aic7xxx_core.c| 6 ++--
drivers/scsi/aic7xxx/aic7xxx_osm_pci.c | 46 ++
drivers/scsi/aic7xxx/aic7xxx_pci.c | 4 +--
4 files changed, 17 insertions(+), 49 dele
Fixes the following W=1 kernel build warning(s):
drivers/scsi/aic7xxx/aic79xx_osm.c: In function ‘ahd_linux_queue_abort_cmd’:
drivers/scsi/aic7xxx/aic79xx_osm.c:2143:9: warning: variable ‘saved_scsiid’
set but not used [-Wunused-but-set-variable]
Cc: Hannes Reinecke
Signed-off-by: Lee Jones
Fixes the following W=1 kernel build warning(s):
drivers/scsi/aic7xxx/aic79xx_osm.c: In function ‘ahd_linux_queue_abort_cmd’:
drivers/scsi/aic7xxx/aic79xx_osm.c:2143:9: warning: variable ‘saved_scsiid’
set but not used [-Wunused-but-set-variable]
Cc: Hannes Reinecke
Signed-off-by: Lee Jones
Signed-off-by: Vaibhav Gupta
---
drivers/scsi/aic7xxx/aic7xxx.h | 10 ++
drivers/scsi/aic7xxx/aic7xxx_core.c| 6 ++--
drivers/scsi/aic7xxx/aic7xxx_osm_pci.c | 46 ++
drivers/scsi/aic7xxx/aic7xxx_pci.c | 4 +--
4 files changed, 17 insertions(+), 49 dele
On Wed, 9 Sep 2020 19:58:55 +0100, Alex Dewar wrote:
> kmemdup can be used instead of kmalloc+memcpy. Replace two occurrences
> of this pattern.
>
> Issue identified with Coccinelle.
Applied to 5.10/scsi-queue, thanks!
[1/1] scsi: aic7xxx: Use kmemdup() in two places
Alex,
> kmemdup can be used instead of kmalloc+memcpy. Replace two occurrences
> of this pattern.
>
> Issue identified with Coccinelle.
Applied to 5.10/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
kmemdup can be used instead of kmalloc+memcpy. Replace two occurrences
of this pattern.
Issue identified with Coccinelle.
Signed-off-by: Alex Dewar
---
drivers/scsi/aic7xxx/aic79xx_core.c | 3 +--
drivers/scsi/aic7xxx/aic7xxx_core.c | 3 +--
2 files changed, 2 insertions(+), 4 deletions
; Also, .suspend() and .resume() are invoking other functions for PM, which
> were againg bounded by "#ifdef CONFIG_PM" directive. Remove the directive
> and mark those functions as "__maybe_unused".
>
> Compile-tested only.
>
> Signed-off-by: Vaibhav G
On Sun, 16 Aug 2020 03:02:42 -0400, Tong Zhang wrote:
> ahc_linux_queue_recovery_cmd returns SUCCESS(0x2002) or FAIL(0x2003),
> but the caller is checking error case using !=0
Applied to 5.10/scsi-queue, thanks!
[1/1] scsi: aic7xxx: Fix error code handling
https://git.kernel.org/mk
ahc_linux_queue_recovery_cmd returns SUCCESS(0x2002) or FAIL(0x2003),
but the caller is checking error case using !=0
Signed-off-by: Tong Zhang
---
drivers/scsi/aic7xxx/aic7xxx_osm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/aic7xxx/aic7xxx_osm.c
b
Add missing fclose() call to close "regdiagfile" in the function stop().
Signed-off-by: Youling Tang
---
drivers/scsi/aic7xxx/aicasm/aicasm.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/drivers/scsi/aic7xxx/aicasm/aicasm.c
b/drivers/scsi/aic7xxx/aicasm/aicasm.c
ind
, E3, E4)
@@ expression E1, E2; @@
- pci_dma_mapping_error(E1, E2)
+ dma_mapping_error(&E1->dev, E2)
@@ expression E1, E2; @@
- pci_set_consistent_dma_mask(E1, E2)
+ dma_set_coherent_mask(&E1->dev, E2)
@@ expression E1, E2; @@
- pci_set_dma_mask(E1, E2)
+ dma_set_mask(&E1->
@@
- pci_dma_mapping_error(E1, E2)
+ dma_mapping_error(&E1->dev, E2)
@@ expression E1, E2; @@
- pci_set_consistent_dma_mask(E1, E2)
+ dma_set_coherent_mask(&E1->dev, E2)
@@ expression E1, E2; @@
- pci_set_dma_mask(E1, E2)
+ dma_set_mask(&E1->dev, E2)
Signed-off-by: Suraj Upad
Question: Can 'ahd_inb(ahd, LQISTAT2);' also be safely removed?
Fixes the following W=1 kernel build warning(s):
drivers/scsi/aic7xxx/aic79xx_core.c: In function ‘ahd_dump_sglist’:
drivers/scsi/aic7xxx/aic79xx_core.c:1738:14: warning: variable ‘len’ set but
not used [-Wunused-but-se
Also remove 'tstate' which became unused after this patch.
Fixes the following W=1 kernel build warning(s):
drivers/scsi/aic7xxx/aic79xx_core.c: In function ‘ahd_handle_seqint’:
drivers/scsi/aic7xxx/aic79xx_core.c:1907:32: warning: variable ‘targ_info’ set
but not used [-Wunus
g W=1 kernel build warning(s):
drivers/scsi/aic7xxx/aic79xx_osm.c: In function
‘ahd_linux_queue_abort_cmd’:
drivers/scsi/aic7xxx/aic79xx_osm.c:2155:17: warning: variable
‘saved_modes’ set but not used [-Wunused-but-set-variable]
drivers/scsi/aic7xxx/aic79xx_osm.c:2148:9: warning: var
ot; directive. Remove the directive
and mark those functions as "__maybe_unused".
Compile-tested only.
Signed-off-by: Vaibhav Gupta
---
drivers/scsi/aic7xxx/aic7xxx.h | 10 ++
drivers/scsi/aic7xxx/aic7xxx_core.c| 6 ++--
drivers/scsi/aic7xxx/aic7xxx_osm_pci.c | 46 +
@@
- pci_dma_mapping_error(E1, E2)
+ dma_mapping_error(&E1->dev, E2)
@@ expression E1, E2; @@
- pci_set_consistent_dma_mask(E1, E2)
+ dma_set_coherent_mask(&E1->dev, E2)
@@ expression E1, E2; @@
- pci_set_dma_mask(E1, E2)
+ dma_set_mask(&E1->dev, E2)
Signed-off-by: Suraj Upad
ot; directive. Remove the directive
and mark those functions as "__maybe_unused".
Compile-tested only.
Signed-off-by: Vaibhav Gupta
---
drivers/scsi/aic7xxx/aic7xxx.h | 10 ++
drivers/scsi/aic7xxx/aic7xxx_core.c| 6 ++--
drivers/scsi/aic7xxx/aic7xxx_osm_pci.c | 46 +
t; > > > > Haven't been used since 2006.
> > > > >
> > > > > Fixes the following W=1 kernel build warning(s):
> > > > >
> > > > > drivers/scsi/aic7xxx/aic79xx_osm.c: In function
> > > > > ‘ahd_linux_queue_abort_cmd
e:
> > > > > Haven't been used since 2006.
> > > > >
> > > > > Fixes the following W=1 kernel build warning(s):
> > > > >
> > > > > drivers/scsi/aic7xxx/aic79xx_osm.c: In function
> > > > > ‘ahd_linux_
On 7/14/20 11:39 PM, Lee Jones wrote:
On Tue, 14 Jul 2020, James Bottomley wrote:
On Tue, 2020-07-14 at 09:46 +0200, Hannes Reinecke wrote:
On 7/13/20 10:00 AM, Lee Jones wrote:
Haven't been used since 2006.
Fixes the following W=1 kernel build warning(s):
drivers/scsi/ai
>
> > > > Fixes the following W=1 kernel build warning(s):
> > > >
> > > > drivers/scsi/aic7xxx/aic79xx_osm.c: In function
> > > > ‘ahd_linux_queue_abort_cmd’:
> > > > drivers/scsi/aic7xxx/aic79xx_osm.c:2155:17: warning: variable
On Tue, 14 Jul 2020, James Bottomley wrote:
> On Tue, 2020-07-14 at 09:46 +0200, Hannes Reinecke wrote:
> > On 7/13/20 10:00 AM, Lee Jones wrote:
> > > Haven't been used since 2006.
> > >
> > > Fixes the following W=1 kernel build warning(s):
> > &
On Tue, 14 Jul 2020, Doug Ledford wrote:
> On Mon, 2020-07-13 at 08:46 +0100, Lee Jones wrote:
> > Looks like none of the artifact from ahc_fetch_transinfo() are used
> > anymore.
> >
> > Fixes the following W=1 kernel build warning(s):
> >
> > drivers/
On Mon, 2020-07-13 at 08:46 +0100, Lee Jones wrote:
> Looks like none of the artifact from ahc_fetch_transinfo() are used
> anymore.
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/scsi/aic7xxx/aic7xxx_osm.c: In function
> ‘ahc_linux_target_alloc’:
&g
On Tue, 2020-07-14 at 09:46 +0200, Hannes Reinecke wrote:
> On 7/13/20 10:00 AM, Lee Jones wrote:
> > Haven't been used since 2006.
> >
> > Fixes the following W=1 kernel build warning(s):
> >
> > drivers/scsi/aic7xxx/aic79xx_osm.c: In function
> > ‘a
On 7/13/20 9:59 AM, Lee Jones wrote:
> Hasn't been used since 2005.
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/scsi/aic7xxx/aic79xx_osm.c: In function ‘ahd_linux_slave_configure’:
> drivers/scsi/aic7xxx/aic79xx_osm.c:703:20: warning: variable ‘a
On 7/13/20 9:59 AM, Lee Jones wrote:
> It looks like they have never actually been used.
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/scsi/aic7xxx/aic79xx_osm.c: In function ‘ahd_linux_dev_reset’:
> drivers/scsi/aic7xxx/aic79xx_osm.c:782:9: warning: varia
On 7/13/20 10:00 AM, Lee Jones wrote:
> Haven't been used since 2006.
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/scsi/aic7xxx/aic79xx_osm.c: In function ‘ahd_linux_queue_abort_cmd’:
> drivers/scsi/aic7xxx/aic79xx_osm.c:2155:17: warning: variable ‘
ordering semantics here.
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/scsi/aic7xxx/aic79xx_osm.c: In function ‘ahd_done’:
> drivers/scsi/aic7xxx/aic79xx_osm.c:1796:12: warning: variable
> ‘amount_xferred’ set but not used [-Wunused-but-set-vari
Fixes the following W=1 kernel build warning(s):
drivers/scsi/aic7xxx/aic7xxx_osm.c: In function ‘ahc_done’:
drivers/scsi/aic7xxx/aic7xxx_osm.c:1725:12: warning: variable
‘amount_xferred’ set but not used [-Wunused-but-set-variable]
1725 | uint32_t amount_xferred;
| ^~
On 7/13/20 9:46 AM, Lee Jones wrote:
Looks like checking the 'targ' was removed in 2005.
Fixes the following W=1 kernel build warning(s):
drivers/scsi/aic7xxx/aic7xxx_osm.c: In function ‘ahc_send_async’:
drivers/scsi/aic7xxx/aic7xxx_osm.c:1604:28: warning: variable ‘targ’ set but
On 7/13/20 9:46 AM, Lee Jones wrote:
Looks as though 'ahc' hasn't been used since 2005.
Fixes the following W=1 kernel build warning(s):
drivers/scsi/aic7xxx/aic7xxx_osm.c: In function ‘ahc_linux_slave_configure’:
drivers/scsi/aic7xxx/aic7xxx_osm.c:674:20: warning: variabl
Hasn't been used since 2005.
Fixes the following W=1 kernel build warning(s):
drivers/scsi/aic7xxx/aic79xx_osm.c: In function ‘ahd_linux_slave_configure’:
drivers/scsi/aic7xxx/aic79xx_osm.c:703:20: warning: variable ‘ahd’ set but not
used [-Wunused-but-set-variable]
Cc: Hannes Rei
ild warning(s):
drivers/scsi/aic7xxx/aic79xx_osm.c: In function ‘ahd_done’:
drivers/scsi/aic7xxx/aic79xx_osm.c:1796:12: warning: variable ‘amount_xferred’
set but not used [-Wunused-but-set-variable]
Cc: Hannes Reinecke
Signed-off-by: Lee Jones
---
drivers/scsi/aic7xxx/aic79xx_osm.c | 2 ++
1 f
It looks like they have never actually been used.
Fixes the following W=1 kernel build warning(s):
drivers/scsi/aic7xxx/aic79xx_osm.c: In function ‘ahd_linux_dev_reset’:
drivers/scsi/aic7xxx/aic79xx_osm.c:782:9: warning: variable ‘wait’ set but not
used [-Wunused-but-set-variable]
drivers
Haven't been used since 2006.
Fixes the following W=1 kernel build warning(s):
drivers/scsi/aic7xxx/aic79xx_osm.c: In function ‘ahd_linux_queue_abort_cmd’:
drivers/scsi/aic7xxx/aic79xx_osm.c:2155:17: warning: variable ‘saved_modes’
set but not used [-Wunused-but-set-variable]
drivers
Looks as though 'ahc' hasn't been used since 2005.
Fixes the following W=1 kernel build warning(s):
drivers/scsi/aic7xxx/aic7xxx_osm.c: In function ‘ahc_linux_slave_configure’:
drivers/scsi/aic7xxx/aic7xxx_osm.c:674:20: warning: variable ‘ahc’ set but not
used [-Wunused-but-set
ild warning(s):
drivers/scsi/aic7xxx/aic7xxx_osm.c: In function ‘ahc_done’:
drivers/scsi/aic7xxx/aic7xxx_osm.c:1725:12: warning: variable ‘amount_xferred’
set but not used [-Wunused-but-set-variable]
1725 | uint32_t amount_xferred;
| ^~
Cc: Hannes Reinecke
Cc: "Daniel M. Eisc
Looks like none of the artifact from ahc_fetch_transinfo() are used anymore.
Fixes the following W=1 kernel build warning(s):
drivers/scsi/aic7xxx/aic7xxx_osm.c: In function ‘ahc_linux_target_alloc’:
drivers/scsi/aic7xxx/aic7xxx_osm.c:567:30: warning: variable ‘tinfo’ set but
not used
Looks like checking the 'targ' was removed in 2005.
Fixes the following W=1 kernel build warning(s):
drivers/scsi/aic7xxx/aic7xxx_osm.c: In function ‘ahc_send_async’:
drivers/scsi/aic7xxx/aic7xxx_osm.c:1604:28: warning: variable ‘targ’ set but
not used [-Wunused-but-set-varia
On Thu, 09 Jul 2020, James Bottomley wrote:
> On Thu, 2020-07-09 at 18:45 +0100, Lee Jones wrote:
> > Haven't been used since 2006.
> >
> > Fixes the following W=1 kernel build warning(s):
> >
> > drivers/scsi/aic7xxx/aic79xx_osm.c: In function
> &g
On Thu, 2020-07-09 at 18:45 +0100, Lee Jones wrote:
> Haven't been used since 2006.
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/scsi/aic7xxx/aic79xx_osm.c: In function
> ‘ahd_linux_queue_abort_cmd’:
> drivers/scsi/aic7xxx/aic79xx_osm.c:
ild warning(s):
drivers/scsi/aic7xxx/aic79xx_osm.c: In function ‘ahd_done’:
drivers/scsi/aic7xxx/aic79xx_osm.c:1796:12: warning: variable ‘amount_xferred’
set but not used [-Wunused-but-set-variable]
Cc: Hannes Reinecke
Signed-off-by: Lee Jones
---
drivers/scsi/aic7xxx/aic79xx_osm.c | 2 ++
1 f
Hasn't been used since 2005.
Fixes the following W=1 kernel build warning(s):
drivers/scsi/aic7xxx/aic79xx_osm.c: In function ‘ahd_linux_slave_configure’:
drivers/scsi/aic7xxx/aic79xx_osm.c:703:20: warning: variable ‘ahd’ set but not
used [-Wunused-but-set-variable]
Cc: Hannes Rei
Haven't been used since 2006.
Fixes the following W=1 kernel build warning(s):
drivers/scsi/aic7xxx/aic79xx_osm.c: In function ‘ahd_linux_queue_abort_cmd’:
drivers/scsi/aic7xxx/aic79xx_osm.c:2155:17: warning: variable ‘saved_modes’
set but not used [-Wunused-but-set-variable]
drivers
It looks like they have never actually been used.
Fixes the following W=1 kernel build warning(s):
drivers/scsi/aic7xxx/aic79xx_osm.c: In function ‘ahd_linux_dev_reset’:
drivers/scsi/aic7xxx/aic79xx_osm.c:782:9: warning: variable ‘wait’ set but not
used [-Wunused-but-set-variable]
drivers
Looks like checking the 'targ' was removed in 2005.
Fixes the following W=1 kernel build warning(s):
drivers/scsi/aic7xxx/aic7xxx_osm.c: In function ‘ahc_send_async’:
drivers/scsi/aic7xxx/aic7xxx_osm.c:1604:28: warning: variable ‘targ’ set but
not used [-Wunused-but-set-varia
Looks like none of the artifact from ahc_fetch_transinfo() are used anymore.
Fixes the following W=1 kernel build warning(s):
drivers/scsi/aic7xxx/aic7xxx_osm.c: In function ‘ahc_linux_target_alloc’:
drivers/scsi/aic7xxx/aic7xxx_osm.c:567:30: warning: variable ‘tinfo’ set but
not used
ild warning(s):
drivers/scsi/aic7xxx/aic7xxx_osm.c: In function ‘ahc_done’:
drivers/scsi/aic7xxx/aic7xxx_osm.c:1725:12: warning: variable ‘amount_xferred’
set but not used [-Wunused-but-set-variable]
1725 | uint32_t amount_xferred;
| ^~
Cc: Hannes Reinecke
Cc: "Daniel M. Eisc
Looks as though 'ahc' hasn't been used since 2005.
Fixes the following W=1 kernel build warning(s):
drivers/scsi/aic7xxx/aic7xxx_osm.c: In function ‘ahc_linux_slave_configure’:
drivers/scsi/aic7xxx/aic7xxx_osm.c:674:20: warning: variable ‘ahc’ set but not
used [-Wunused-but-set
shift. The commit
this fixes is pre-git history.
Signed-off-by: Colin Ian King
---
drivers/scsi/aic7xxx/aic79xx_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/aic7xxx/aic79xx_core.c
b/drivers/scsi/aic7xxx/aic79xx_core.c
index 7e5044bf05c0..fa440c1b9baa
> A clear reason might be that it's impossible for aic7xxx ever to make
> use of IU and QAS because they're LVD parameters and it's a SE/HVD
> card, so the documentation in the code is actively wrong, but you'd
> need to research that.
I need to look further to come up with a clear reason.
cumentation for
this chip is lost in the mists of time, so code fragments like this are
the only way we know how it was supposed to work.
A clear reason might be that it's impossible for aic7xxx ever to make
use of IU and QAS because they're LVD parameters and it's a SE/HVD
card, s
These are dead code since 2.6.13. If there is no plan
to use it further, these can be removed forever.
Signed-off-by: Souptick Joarder
---
drivers/scsi/aic7xxx/aic7xxx_osm.c | 68 --
1 file changed, 68 deletions(-)
diff --git a/drivers/scsi/aic7xxx
kmemdup rather than using kmalloc/kzalloc + memcpy.
Signed-off-by: Fuqian Huang
---
Changes in v2:
- Fix a typo in commit message (memset -> memcpy)
drivers/scsi/aic7xxx/aic79xx_core.c | 3 +--
drivers/scsi/aic7xxx/aic7xxx_core.c | 3 +--
2 files changed, 2 insertions(+), 4 deletions(-)
d
Geert,
Applied to 5.3/scsi-queue. Thanks.
--
Martin K. Petersen Oracle Linux Engineering
On 6/7/19 1:27 PM, Geert Uytterhoeven wrote:
> Signed-off-by: Geert Uytterhoeven
> ---
> drivers/scsi/aic7xxx/aic7xxx.reg | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/aic7xxx/aic7xxx.reg
> b/drivers/scsi/aic7xxx/aic7xxx.reg
>
Signed-off-by: Geert Uytterhoeven
---
drivers/scsi/aic7xxx/aic7xxx.reg | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/aic7xxx/aic7xxx.reg b/drivers/scsi/aic7xxx/aic7xxx.reg
index ba0b411d03e2e1fa..00fde2243e486cbd 100644
--- a/drivers/scsi/aic7xxx/aic7xxx.reg
A API")
Reported-by: Matthew Whitehead
Signed-off-by: Christoph Hellwig
Tested-by: Matthew Whitehead
Signed-off-by: Martin K. Petersen
Signed-off-by: Sasha Levin
---
drivers/scsi/aic7xxx/aic7770_osm.c | 1 +
drivers/scsi/aic7xxx/aic7xxx.h | 1 +
drivers/scsi/aic7xxx/aic7xxx_osm.
A API")
Reported-by: Matthew Whitehead
Signed-off-by: Christoph Hellwig
Tested-by: Matthew Whitehead
Signed-off-by: Martin K. Petersen
Signed-off-by: Sasha Levin
---
drivers/scsi/aic7xxx/aic7770_osm.c | 1 +
drivers/scsi/aic7xxx/aic7xxx.h | 1 +
drivers/scsi/aic7xxx/aic7xxx_osm.
Fix the following coccinelle warning by removing NULL check before
calling kfree():
NULL check before some freeing functions in not needed.
Signed-off-by: Quentin Deslandes
---
drivers/scsi/aic7xxx/aic7xxx_core.c | 16 +---
1 file changed, 5 insertions(+), 11 deletions(-)
diff
evice handling from PCI DMA API")
Reported-by: Matthew Whitehead
Signed-off-by: Christoph Hellwig
Tested-by: Matthew Whitehead
Signed-off-by: Martin K. Petersen
Signed-off-by: Sasha Levin
---
drivers/scsi/aic7xxx/aic7770_osm.c | 1 +
drivers/scsi/aic7xxx/aic7xxx.h | 1 +
dr
Hannes,
>> Friendly ping (second one):
>>
>> Who can ack/review/take this patch, please?
Applied to 5.1/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
t;Missing break in switch")
Signed-off-by: Gustavo A. R. Silva
---
drivers/scsi/aic7xxx/aic79xx_core.c | 14 +-
1 file changed, 9 insertions(+), 5 deletions(-)
Sorry, I thought I'd done so already.
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
--
Dr. Hannes Re
to find.
Addresses-Coverity-ID: 114961 ("Missing break in switch")
Addresses-Coverity-ID: 114962 ("Missing break in switch")
Addresses-Coverity-ID: 114963 ("Missing break in switch")
Addresses-Coverity-ID: 114964 ("Missing break in switch")
Signed-off-by: Gu
find.
Signed-off-by: Gustavo A. R. Silva
---
drivers/scsi/aic7xxx/aic7xxx_core.c | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/aic7xxx/aic7xxx_core.c
b/drivers/scsi/aic7xxx/aic7xxx_core.c
index f3362f4ab16e..d4a7263e4b8f 100644
--- a/
ROUGH" with a "fall through"
annotation and then placed it at the bottom of the corresponding switch
case, which is what GCC is expecting to find.
Signed-off-by: Gustavo A. R. Silva
---
drivers/scsi/aic7xxx/aic7xxx_core.c | 12 +---
1 file changed, 9 insertions(+), 3 deleti
Addresses-Coverity-ID: 114963 ("Missing break in switch")
Addresses-Coverity-ID: 114964 ("Missing break in switch")
Signed-off-by: Gustavo A. R. Silva
---
drivers/scsi/aic7xxx/aic79xx_core.c | 14 +-
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a
n"
CC: linux-s...@vger.kernel.org
CC: linux-kernel@vger.kernel.org
---
drivers/scsi/aic7xxx/aic79xx_core.c | 4 ++--
drivers/scsi/aic7xxx/aic7xxx_core.c | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/scsi/aic7xxx/aic79xx_core.c
b/drivers/scsi/aic7xxx/aic79xx_core.
n"
CC: linux-s...@vger.kernel.org
CC: linux-kernel@vger.kernel.org
---
drivers/scsi/aic7xxx/aic79xx_core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/aic7xxx/aic79xx_core.c
b/drivers/scsi/aic7xxx/aic79xx_core.c
index 9ee75c9a9aa1..3e72fac6d248 100644
--- a/
On Thu, 2018-10-25 at 16:13 +0100, Colin King wrote:
> From: Colin Ian King
>
> In the expression "ahc_inb(ahc, port+3) << 24", the initial value is
> a u8, but is promoted to a signed int, then sign-extended to
> uint64_t.
Why is this, that's highly non intuitive? The compiler is supposed to
p
Stephen,
> In preparation to enabling -Wvla, remove VLAs and replace them with
> fixed-length arrays instead.
>
> The arrays fixed here, using the number of constant sections, aren't
> really VLAs, but they appear so to the compiler. Replace the array
> sizes with a pre-processor-level constant i
On Thu, 8 Mar 2018 11:52:25 -0800, Kees Cook wrote:
> On Thu, Mar 8, 2018 at 5:22 AM, Stephen Kitt wrote:
> > -static const int num_critical_sections = sizeof(critical_sections)
> > - / sizeof(*critical_sections);
> > +#define NUM_CRITICAL_SECTIONS 14
>
> T
r. Replace the array
> sizes with a pre-processor-level constant instead using ARRAY_SIZE.
>
> This was prompted by https://lkml.org/lkml/2018/3/7/621
>
> Signed-off-by: Stephen Kitt
Thanks!
Reviewed-by: Kees Cook
-Kees
> ---
> drivers/scsi/aic7xxx/aic79xx_core.c
using ARRAY_SIZE.
This was prompted by https://lkml.org/lkml/2018/3/7/621
Signed-off-by: Stephen Kitt
---
drivers/scsi/aic7xxx/aic79xx_core.c| 8
drivers/scsi/aic7xxx/aic79xx_seq.h_shipped | 3 +--
drivers/scsi/aic7xxx/aic7xxx_core.c| 8
drivers/scsi/ai
er. Since we know at
> build-time how many critical sections there are, we might as well use
> a pre-processor-level constant instead.
>
> This was prompted by https://lkml.org/lkml/2018/3/7/621
>
> Signed-off-by: Stephen Kitt
> ---
> drivers/scsi/aic7xxx/aic79xx_core.c
well use
a pre-processor-level constant instead.
This was prompted by https://lkml.org/lkml/2018/3/7/621
Signed-off-by: Stephen Kitt
---
drivers/scsi/aic7xxx/aic79xx_core.c| 8
drivers/scsi/aic7xxx/aic79xx_seq.h_shipped | 3 +--
drivers/scsi/aic7xxx/aic7xxx_core.c
Corentin,
> aiclib.c is unused (and contain no code) since commit 1ff927306e08
> ("[SCSI] aic7xxx: remove aiclib.c")
> 13 years later, finish the cleaning by remove it from tree.
Applied to 4.16/scsi-fixes, thanks!
--
Martin K. Petersen Oracle Linux Engineering
aiclib.c is unused (and contain no code) since commit 1ff927306e08 ("[SCSI]
aic7xxx: remove aiclib.c")
13 years later, finish the cleaning by remove it from tree.
Signed-off-by: Corentin Labbe
---
drivers/scsi/aic7xxx/aiclib.c | 34 --
1 file c
Kees,
> stat_timer only ever assigns the same function and data, so
> consolidate to using timer_setup(), adjust callback, drop everything
> else used to pass things around, and remove needless typedefs.
Reviewed-by: Martin K. Petersen
--
Martin K. Petersen Oracle Linux Engineering
"Martin K. Petersen"
Cc: linux-s...@vger.kernel.org
Signed-off-by: Kees Cook
---
drivers/scsi/aic7xxx/aic79xx.h | 5 +
drivers/scsi/aic7xxx/aic79xx_core.c | 29 -
drivers/scsi/aic7xxx/aic79xx_osm.h | 7 ---
3 files changed, 9 insertions(+), 32 deleti
Colin,
> Functions ahc_devlimited_syncrate and ahc_linux_initialize_scsi_bus
> are declared static in their prototypes but are missing in their
> definitions, so add the missing static.
Applied to 4.15/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
"Martin K. Petersen"
Cc: Thomas Gleixner
Signed-off-by: Kees Cook
---
This requires commit 686fef928bba ("timer: Prepare to change timer
callback argument type") in v4.14-rc3, but should be otherwise
stand-alone.
---
drivers/scsi/aic7xxx/aic79xx.h | 5 +
drivers/sc
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG
be static?
symbol 'ahc_linux_initialize_scsi_bus' was not declared. Should it
be static?
Signed-off-by: Colin Ian King
---
drivers/scsi/aic7xxx/aic7xxx_core.c | 2 +-
drivers/scsi/aic7xxx/aic7xxx_osm.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/ai
ames E.J. Bottomley"
> Cc: "Martin K. Petersen"
> Cc: linux-s...@vger.kernel.org
> Signed-off-by: Kees Cook
> ---
> drivers/scsi/aic7xxx/aic79xx.h | 5 +
> drivers/scsi/aic7xxx/aic79xx_core.c | 29 -
> 2 files changed, 9
er.kernel.org
Signed-off-by: Kees Cook
---
drivers/scsi/aic7xxx/aic79xx.h | 5 +
drivers/scsi/aic7xxx/aic79xx_core.c | 29 -
2 files changed, 9 insertions(+), 25 deletions(-)
diff --git a/drivers/scsi/aic7xxx/aic79xx.h b/drivers/scsi/aic7xxx/aic79xx.
1 - 100 of 671 matches
Mail list logo
