Re: do_remount_sb(RDONLY) race? (was: XFS oops under 2.6.23.9)

2008-01-23 Thread Christoph Hellwig
On Wed, Jan 23, 2008 at 04:34:12PM +1100, David Chinner wrote: > I've had suspicions of a race in the remount-ro code in > do_remount_sb() w.r.t to the fs_may_remount_ro() check. That is, we > do an unlocked check to see if we can remount readonly and then fail > to check again once we've locked t

Re: do_remount_sb(RDONLY) race? (was: XFS oops under 2.6.23.9)

2008-01-22 Thread David Chinner
On Wed, Jan 23, 2008 at 04:24:33PM +1030, Jonathan Woithe wrote: > > On Wed, Jan 23, 2008 at 03:00:48PM +1030, Jonathan Woithe wrote: > > > Last night my laptop suffered an oops during closedown. The full oops > > > reports can be downloaded from > > > > > > http://www.atrad.com.au/~jwoithe/xfs

Re: do_remount_sb(RDONLY) race? (was: XFS oops under 2.6.23.9)

2008-01-22 Thread Jonathan Woithe
Hi Dave > On Wed, Jan 23, 2008 at 03:00:48PM +1030, Jonathan Woithe wrote: > > Last night my laptop suffered an oops during closedown. The full oops > > reports can be downloaded from > > > > http://www.atrad.com.au/~jwoithe/xfs_oops/ > > Assertion failed: atomic_read(&mp->m_active_trans) ==

do_remount_sb(RDONLY) race? (was: XFS oops under 2.6.23.9)

2008-01-22 Thread David Chinner
On Wed, Jan 23, 2008 at 03:00:48PM +1030, Jonathan Woithe wrote: > Last night my laptop suffered an oops during closedown. The full oops > reports can be downloaded from > > http://www.atrad.com.au/~jwoithe/xfs_oops/ Assertion failed: atomic_read(&mp->m_active_trans) == 0, file: fs/xfs/xfs_vfs

XFS oops under 2.6.23.9

2008-01-22 Thread Jonathan Woithe
Last night my laptop suffered an oops during closedown. The full oops reports can be downloaded from http://www.atrad.com.au/~jwoithe/xfs_oops/ as photos of the screen. Since the laptop was unusable at this point I wasn't able to cut and paste the details, and they weren't in the logs when th