Re: Wireless regression in workqueue: use mod_delayed_work() instead of __cancel + queue

2012-12-01 Thread Anders Kaseorg
On Sat, 1 Dec 2012, Tejun Heo wrote: > Can you please test this one too? Thanks! > > […] > + if (!delay) { > + __queue_work(cpu, wq, &dwork->work); > + return; > + } > + > […] > - if (!delay) > - return queue_work_on(cpu, wq, &dwork->work); > - Yes

Re: Wireless regression in workqueue: use mod_delayed_work() instead of __cancel + queue

2012-12-01 Thread Tejun Heo
Hey, Anders. On Fri, Nov 30, 2012 at 11:15:50PM -0500, Anders Kaseorg wrote: > Yes. I tested that both directly on top of the bad commit, and on > v3.7-rc7, and it fixes the bug in both cases. Can you please test this one too? Thanks! diff --git a/kernel/workqueue.c b/kernel/workqueue.c index

Re: Wireless regression in workqueue: use mod_delayed_work() instead of __cancel + queue

2012-11-30 Thread Anders Kaseorg
On Fri, 30 Nov 2012, Tejun Heo wrote: > Hey, again. > > Can you please test whether the following patch makes any difference? > > Thanks! > > diff --git a/kernel/workqueue.c b/kernel/workqueue.c > index 042d221..26368ef 100644 > --- a/kernel/workqueue.c > +++ b/kernel/workqueue.c > @@ -1477,7 +1

Re: Wireless regression in workqueue: use mod_delayed_work() instead of __cancel + queue

2012-11-30 Thread Tejun Heo
Hey, again. Can you please test whether the following patch makes any difference? Thanks! diff --git a/kernel/workqueue.c b/kernel/workqueue.c index 042d221..26368ef 100644 --- a/kernel/workqueue.c +++ b/kernel/workqueue.c @@ -1477,7 +1477,10 @@ bool mod_delayed_work_on(int cpu, struct workqueu

Re: Wireless regression in workqueue: use mod_delayed_work() instead of __cancel + queue

2012-11-30 Thread Tejun Heo
Hello, Anders. Sorry about the delay. On Wed, Nov 28, 2012 at 10:17:28AM -0500, Anders Kaseorg wrote: > On Wed, 28 Nov 2012, Anders Kaseorg wrote: > > My Intel 6250 wireless card (iwldvm) can no longer associate with a > > WPA-Enterprise network (PEAP-MSCHAPv2). To my surprise, I bisected this

Re: Wireless regression in workqueue: use mod_delayed_work() instead of __cancel + queue

2012-11-28 Thread Anders Kaseorg
On Wed, 28 Nov 2012, Anders Kaseorg wrote: > My Intel 6250 wireless card (iwldvm) can no longer associate with a > WPA-Enterprise network (PEAP-MSCHAPv2). To my surprise, I bisected this > regression to commit e7c2f967445dd2041f0f8e3179cca22bb8bb7f79, > workqueue: use mod_delayed_work() instead