Re: WTF: driver-core-next contains recursive directory removal!

2013-10-31 Thread Tejun Heo
Hello, Eric. On Wed, Oct 30, 2013 at 06:19:27PM -0700, Eric W. Biederman wrote: > The biggest and worst issue is the semantics are total unmaintable > garbage and there has never been a single counter argument to that. > > Recursive delete is WRONG. > > Further there was no follow up converstion

Re: WTF: driver-core-next contains recursive directory removal!

2013-10-31 Thread Tejun Heo
(cc'ing Al, hi!) Hey, again. On Wed, Oct 30, 2013 at 03:57:37PM -0700, Eric W. Biederman wrote: > Greg Kroah-Hartman writes: > > > I don't think there's an issue here, otherwise both Tejun and I would > > have found some issues during testing, same for all of the other > > linux-next users for

Re: WTF: driver-core-next contains recursive directory removal!

2013-10-31 Thread Tejun Heo
Hey, Eric. On Wed, Oct 30, 2013 at 03:38:58PM -0700, Eric W. Biederman wrote: > Please pull out that crap it has no business ever going into a stable > kernel. Can you please calm down a bit? It's becoming pretty difficult to take your opinions as technical especially as all the points you're ra

Re: WTF: driver-core-next contains recursive directory removal!

2013-10-31 Thread Bjorn Helgaas
[+cc linux-pci] On Wed, Oct 30, 2013 at 4:38 PM, Eric W. Biederman wrote: > > Greg what is going on? I just looked and Tejuns ill-conceived recursive > directory deletion code has been merged into your driver-core-next tree. > > That code is semantically broken. I reviewed it and I gave the re

Re: WTF: driver-core-next contains recursive directory removal!

2013-10-30 Thread Eric W. Biederman
Greg Kroah-Hartman writes: > On Wed, Oct 30, 2013 at 03:38:58PM -0700, Eric W. Biederman wrote: >> >> Greg what is going on? I just looked and Tejuns ill-conceived recursive >> directory deletion code has been merged into your driver-core-next tree. >> >> That code is semantically broken. I

Re: WTF: driver-core-next contains recursive directory removal!

2013-10-30 Thread Eric W. Biederman
Greg Kroah-Hartman writes: > I don't think there's an issue here, otherwise both Tejun and I would > have found some issues during testing, same for all of the other > linux-next users for the past few weeks. There issues were subtle and hard to detect especially without instrumenting the code d

Re: WTF: driver-core-next contains recursive directory removal!

2013-10-30 Thread Greg Kroah-Hartman
On Wed, Oct 30, 2013 at 03:38:58PM -0700, Eric W. Biederman wrote: > > Greg what is going on? I just looked and Tejuns ill-conceived recursive > directory deletion code has been merged into your driver-core-next tree. > > That code is semantically broken. I reviewed it and I gave the reasons >

WTF: driver-core-next contains recursive directory removal!

2013-10-30 Thread Eric W. Biederman
Greg what is going on? I just looked and Tejuns ill-conceived recursive directory deletion code has been merged into your driver-core-next tree. That code is semantically broken. I reviewed it and I gave the reasons why it was wrong. You came up to me and mentioned at LPC that you agreed with