On Wed, Oct 30, 2013 at 03:38:58PM -0700, Eric W. Biederman wrote: > > Greg what is going on? I just looked and Tejuns ill-conceived recursive > directory deletion code has been merged into your driver-core-next tree. > > That code is semantically broken. I reviewed it and I gave the reasons > why it was wrong. You came up to me and mentioned at LPC that you > agreed with my reasons. And yet I just looked in driver-core-next and > there the code is in all of it's broken glory.
Because I tested it out, and there were no such problems. > Please pull out that crap it has no business ever going into a stable > kernel. Really? It seems to survive my testing here just fine. > The short version is unless someone has drastically changed pci hotplug > since last time I looked the code is dramatically wrong as pci hotplug > removes directories in the wrong order remove the parent first. That should still work here, and I'm pretty sure I tested it, but will do so before I send it to Linus. I don't think there's an issue here, otherwise both Tejun and I would have found some issues during testing, same for all of the other linux-next users for the past few weeks. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
