Re: kernel/workqueue.c:4435:61: sparse: expression using sizeof bool

2013-06-07 Thread Fengguang Wu
// CC sparse people. On Fri, Jun 07, 2013 at 07:05:49PM -0700, Tejun Heo wrote: > Hello, Andrew. > > On Fri, Jun 07, 2013 at 06:46:14PM -0700, Andrew Morton wrote: > > I believe sizeof(bool) can vary between compilers (on gcc it's 1) but > > that doesn't matter here. > > Looking at the warning,

Re: kernel/workqueue.c:4435:61: sparse: expression using sizeof bool

2013-06-07 Thread Fengguang Wu
On Fri, Jun 07, 2013 at 03:03:51PM -0700, Tejun Heo wrote: > On Fri, Jun 07, 2013 at 02:15:21PM -0700, Andrew Morton wrote: > > > 4434/* copy worker description */ > > > > 4435probe_kernel_read(&desc_valid, &worker->desc_valid, > > > > sizeof(desc_valid)); > > > > I don'