Re: Performance Stats: Kernel patch

2007-04-16 Thread Maxim Uvarov
William Lee Irwin III wrote: On Sun 2007-04-15 03:21:57, William Lee Irwin III wrote: nvcsw and nivcsw are conventional variable names for these quantities. On Sun, Apr 15, 2007 at 08:10:24PM +, Pavel Machek wrote: I can't decipher them and would not want users see them in /

Re: Performance Stats: Kernel patch

2007-04-15 Thread William Lee Irwin III
On Sun 2007-04-15 03:21:57, William Lee Irwin III wrote: >> nvcsw and nivcsw are conventional variable names for these quantities. On Sun, Apr 15, 2007 at 08:10:24PM +, Pavel Machek wrote: > I can't decipher them and would not want users see them in /proc. > Would nonvoluntary_ctxt_switch be t

Re: Performance Stats: Kernel patch

2007-04-15 Thread Pavel Machek
Hi! On Sun 2007-04-15 03:21:57, William Lee Irwin III wrote: > At some point in the past, someone's attribution was stripped from: Maxim's. > >> + return buffer + sprintf(buffer, "Nvcsw:\t%lu\n" > >> + "Nivcsw:\t%lu\n", > >> + p->nvcsw, >

Re: Performance Stats: Kernel patch

2007-04-15 Thread William Lee Irwin III
At some point in the past, someone's attribution was stripped from: >> + return buffer + sprintf(buffer, "Nvcsw:\t%lu\n" >> + "Nivcsw:\t%lu\n", >> + p->nvcsw, >> + p->nivcsw); On Sun, Apr 15, 2007 at 09:47:07AM +00

Re: Performance Stats: Kernel patch

2007-04-15 Thread Pavel Machek
Hi! > + return buffer + sprintf(buffer, "Nvcsw:\t%lu\n" > + "Nivcsw:\t%lu\n", > + p->nvcsw, > + p->nivcsw); We don't encrypt variable names like this. Pavel

Re: Performance Stats: Kernel patch

2007-04-12 Thread Maxim Uvarov
Eric Dumazet wrote: [snip] What I meant is : You falsely speak of 'PROCESS performance statistics'. Your implementation only cares about threads, not processes. There is a slight difference, that getrusage() can do. So if you do "cat /proc/PID/status", you'll get counters not for the PROCESS,

Re: Performance Stats: Kernel patch

2007-04-11 Thread Eric Dumazet
Maxim Uvarov a écrit : Eric Dumazet wrote: >Please check kernel/sys.c:k_getrusage() to see how getrusage() has to sum *lot* of individual fields to get precise process numbers (even counting stats for dead threads) Thanks for helping me and for this link. But it is not enough clear for m

Re: Performance Stats: Kernel patch

2007-04-11 Thread Maxim Uvarov
Bill Davidsen wrote: [snip] Your description is not very clear about the semantic of your stats. You currently returns stats only for thread(s) (not process as you claimed) I'm not sure if you were confused by his use of thread in parenthesis, but isn't the whole point of this to see

Re: Performance Stats: Kernel patch

2007-04-11 Thread Maxim Uvarov
Eric Dumazet wrote: >Please check kernel/sys.c:k_getrusage() to see how getrusage() has to sum *lot* of individual fields to get precise process numbers (even counting stats for dead threads) Thanks for helping me and for this link. But it is not enough clear for me what do you mean at thi

Re: Performance Stats: Kernel patch

2007-04-11 Thread Bill Davidsen
Eric Dumazet wrote: On Wed, 11 Apr 2007 15:59:16 +0400 Maxim Uvarov <[EMAIL PROTECTED]> wrote: Patch adds Process Performance Statistics. It make available to the user the following new per-process (thread) performance statistics: * Involuntary Context Switches * Voluntary Context Sw

Re: Performance Stats: Kernel patch

2007-04-11 Thread Eric Dumazet
On Wed, 11 Apr 2007 15:59:16 +0400 Maxim Uvarov <[EMAIL PROTECTED]> wrote: > Patch adds Process Performance Statistics. > It make available to the user the following > new per-process (thread) performance statistics: >* Involuntary Context Switches >* Voluntary Context Switches >* Num

Re: Performance Stats: Kernel patch

2007-04-11 Thread Maxim Uvarov
Eric Dumazet wrote: sysc_cnt being an 'unsigned long', its a 64 bits long integer... So you probably need ld/std instructions instead of lwz/stw Seems you are right again :( - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECT

Re: Performance Stats: Kernel patch

2007-04-11 Thread Eric Dumazet
On Wed, 11 Apr 2007 15:59:16 +0400 Maxim Uvarov <[EMAIL PROTECTED]> wrote: > Thanks Eric, I's really better. I have done changes. Do you have any > others objections now? > All is in attached perf_stat.patch. Hi Maxim I know *nothing* about powerpc assembly, but I think there is a problem : In

Re: Performance Stats: Kernel patch

2007-04-11 Thread Maxim Uvarov
Eric Dumazet wrote: [snip] Please reorganize the code so that you dont duplicate GET_THREAD_INFO() stuff Thanks Eric, I's really better. I have done changes. Do you have any others objections now? All is in attached perf_stat.patch. Best regards, Maxim Uvarov. Patch adds Process Performanc

Re: Performance Stats: Kernel patch

2007-04-10 Thread Pavel Machek
Hi! > Yes I have tested it on PPC, X86, X86_64, Mips targets. > It works. > >>+ cap_t(p->nvcsw), > >>+ cap_t(p->nivcsw), Nvcsw? W dn't s ncrptd dntfrs lk nvcsw n krnl. (:-) Pavel -- (english) ht

Re: Performance Stats: Kernel patch

2007-04-10 Thread Eric Dumazet
On Mon, 09 Apr 2007 18:22:22 +0400 Maxim Uvarov <[EMAIL PROTECTED]> wrote: > --- linux-2.6.21-rc5.orig/arch/x86_64/kernel/entry.S > +++ linux-2.6.21-rc5/arch/x86_64/kernel/entry.S > @@ -236,6 +236,11 @@ ENTRY(system_call) > movq %r10,%rcx > call *sys_call_table(,%rax,8) # XXX:ri

Re: Performance Stats: Kernel patch

2007-04-06 Thread Bill Davidsen
[EMAIL PROTECTED] wrote: 2) It arrived here with some line-wrapping damage, most likely to the fact that you posted it with Thunderbird. There's a mystic Thunderbird incantation to make it not do that, but I have no idea what it is - it's in the list archives someplace. I don't use TBird (sea

Re: Performance Stats: Kernel patch

2007-04-04 Thread Randy Dunlap
On Wed, 04 Apr 2007 17:50:50 -0400 [EMAIL PROTECTED] wrote: > Other random comments: > > 1) You probably want to rebase against something more recent > (2.6.21-rc > or the final .21 when it's released). > > 2) It arrived here with some line-wrapping damage, most likely to the fact > that you po

Re: Performance Stats: Kernel patch

2007-04-04 Thread Valdis . Kletnieks
On Wed, 04 Apr 2007 15:46:24 +0200, Eric Dumazet said: > On Wed, 04 Apr 2007 17:15:43 +0400 > Maxim Uvarov <[EMAIL PROTECTED]> wrote: > > +#ifdef CONFIG_THREAD_PERF_STAT_SYSC > > + call inc_syscallcnt # Increment syscalls counter > > current->sysc_cnt > > +#endif /* CONFIG_THREA

Re: Performance Stats: Kernel patch

2007-04-04 Thread Valdis . Kletnieks
On Wed, 04 Apr 2007 17:15:43 +0400, Maxim Uvarov said: > New version of this patch. Please flay it. > > > Signed-off-by: Max Uvarov <[EMAIL PROTECTED]> > Index: linux-2.6.18/fs/proc/array.c > === > --- linux-2.6.18.orig/fs/proc/arr

Re: Performance Stats: Kernel patch

2007-04-04 Thread Eric Dumazet
On Wed, 04 Apr 2007 20:52:34 +0400 Maxim Uvarov <[EMAIL PROTECTED]> wrote: > Index: linux-2.6.18/include/asm/thread_info.h > === > --- linux-2.6.18.orig/include/asm/thread_info.h > +++ linux-2.6.18/include/asm/thread_info.h > @@ -44,

Re: Performance Stats: Kernel patch

2007-04-04 Thread Maxim Uvarov
Hello Eric, I changed patch according to your comments. Could you please take a look at it? Eric Dumazet wrote: On Wed, 04 Apr 2007 17:15:43 +0400 Maxim Uvarov <[EMAIL PROTECTED]> wrote: --- linux-2.6.18.orig/arch/i386/kernel/entry.S +++ linux-2.6.18/arch/i386/kernel/entry.S @@ -394,6 +39

Re: Performance Stats: Kernel patch

2007-04-04 Thread Jesper Juhl
On 04/04/07, Maxim Uvarov <[EMAIL PROTECTED]> wrote: Hello again, [snip] New version of this patch. Please flay it. A few small comments below. +config THREAD_PERF_STAT + bool "Per-process (thread) performance statistics" + depends on (X86 || PPC || MIPS) + help +

Re: Performance Stats: Kernel patch

2007-04-04 Thread Eric Dumazet
On Wed, 04 Apr 2007 17:15:43 +0400 Maxim Uvarov <[EMAIL PROTECTED]> wrote: > > --- linux-2.6.18.orig/arch/i386/kernel/entry.S > +++ linux-2.6.18/arch/i386/kernel/entry.S > @@ -394,6 +394,9 @@ syscall_exit: > cli # make sure we don't miss an > interrupt >

Re: Performance Stats: Kernel patch

2007-04-04 Thread Maxim Uvarov
Hello again, Please see my answers bellow: [EMAIL PROTECTED] wrote: On Tue, 03 Apr 2007 16:54:43 +0400, Maxim Uvarov said: What do you think about it? Patch is bellow. Was this patch actually compile and run tested? Yes I have tested it on PPC, X86, X86_64, Mips targets. It wor

Re: Performance Stats: Kernel patch

2007-04-03 Thread Valdis . Kletnieks
On Tue, 03 Apr 2007 16:54:43 +0400, Maxim Uvarov said: > What do you think about it? Patch is bellow. Was this patch actually compile and run tested? > Index: linux-2.6.18/fs/proc/array.c > === > --- linux-2.6.18.orig/fs/proc/array.