On Mon, Jul 13 2015 at 1:01pm -0400,
Milan Broz wrote:
> (sorry, resending again, not sure if it was sent correctly)
>
> On 07/13/2015 06:33 PM, Joseph Salisbury wrote:
> > Hi Milan,
> >
> > The Ubuntu kernel has been carrying this patch since the discussion[0]
> > we were having about the bug
(sorry, resending again, not sure if it was sent correctly)
On 07/13/2015 06:33 PM, Joseph Salisbury wrote:
> Hi Milan,
>
> The Ubuntu kernel has been carrying this patch since the discussion[0]
> we were having about the bug. I don't see that patch was ever included
> in mainline. Do you happe
On 07/13/2015 06:33 PM, Joseph Salisbury wrote:
> Hi Milan,
>
> The Ubuntu kernel has been carrying this patch since the discussion[0]
> we were having about the bug. I don't see that patch was ever included
> in mainline. Do you happen to know if this patch is still needed or was
> the bug we w
On 12/19/2012 05:20 PM, Joseph Salisbury wrote:
> On 12/19/2012 04:07 PM, Milan Broz wrote:
>> Does this help?
>>
>> dm-crypt: never use write same
>>
>> Ciphertext device is not compatible with WRITE SAME,
>> disable it for all dmcrypt devices.
>>
>> Signed-off-by: Milan Broz
>>
>> --- a/drivers/
On Wed, Dec 19 2012 at 7:11pm -0500,
Martin K. Petersen wrote:
> > "Milan" == Milan Broz writes:
>
> Milan> dm-crypt: never use write same
>
> Milan> Ciphertext device is not compatible with WRITE SAME, disable it
> Milan> for all dmcrypt devices.
>
> Milan> Signed-off-by: Milan Broz
>
> "Milan" == Milan Broz writes:
Milan> dm-crypt: never use write same
Milan> Ciphertext device is not compatible with WRITE SAME, disable it
Milan> for all dmcrypt devices.
Milan> Signed-off-by: Milan Broz
Acked-by: Martin K. Petersen
--
Martin K. Petersen Oracle Linux Engineering
On 12/19/2012 11:20 PM, Joseph Salisbury wrote:
> Great work, Milan. Your patch fixes the bug, stops the panic and allows
> dm-crypt to function properly.
Thanks.
>
> Will you be requesting this in v3.8 ?
This should go into 3.7 stable as well, I am talking with Alasdair already
how to handle
On 12/19/2012 04:07 PM, Milan Broz wrote:
Does this help?
dm-crypt: never use write same
Ciphertext device is not compatible with WRITE SAME,
disable it for all dmcrypt devices.
Signed-off-by: Milan Broz
--- a/drivers/md/dm-crypt.c
+++ b/drivers/md/dm-crypt.c
@@ -1844,6 +1844,12 @@ static in
On 12/19/2012 04:07 PM, Milan Broz wrote:
Does this help?
dm-crypt: never use write same
Ciphertext device is not compatible with WRITE SAME,
disable it for all dmcrypt devices.
Signed-off-by: Milan Broz
--- a/drivers/md/dm-crypt.c
+++ b/drivers/md/dm-crypt.c
@@ -1844,6 +1844,12 @@ static in
Does this help?
dm-crypt: never use write same
Ciphertext device is not compatible with WRITE SAME,
disable it for all dmcrypt devices.
Signed-off-by: Milan Broz
--- a/drivers/md/dm-crypt.c
+++ b/drivers/md/dm-crypt.c
@@ -1844,6 +1844,12 @@ static int crypt_iterate_devices(struct dm_target *ti
On 12/19/2012 08:58 PM, Mike Snitzer wrote:
> On Wed, Dec 19 2012 at 11:58am -0500,
> Martin K. Petersen wrote:
>
>>> "Joseph" == Joseph Salisbury writes:
>>
>> Joseph> I captured the netconsole output from boot until I reproduced
>> Joseph> the bug. The RIP points to kcryptd_crypt_write_io_
> "Joseph" == Joseph Salisbury writes:
Joseph> Martin, were you using the scsi_debug module, or a real scsi
Joseph> device(s)?
I used scsi_debug for the test.
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
t
> "Mike" == Mike Snitzer writes:
Mike> But do we know mount to somwhow be issuing WRITE SAME requests?
I'm assuming that ext4 is somehow calling sb_issue_zeroout().
Mike> Martin, why is it you weren't able to reproduce (I haven't
Mike> attempted yet)?
Dunno.
But regardless of any bugs, W
On 12/19/2012 02:58 PM, Mike Snitzer wrote:
On Wed, Dec 19 2012 at 11:58am -0500,
Martin K. Petersen wrote:
"Joseph" == Joseph Salisbury writes:
Joseph> I captured the netconsole output from boot until I reproduced
Joseph> the bug. The RIP points to kcryptd_crypt_write_io_submit() in
Joseph>
On Wed, Dec 19 2012 at 11:58am -0500,
Martin K. Petersen wrote:
> > "Joseph" == Joseph Salisbury writes:
>
> Joseph> I captured the netconsole output from boot until I reproduced
> Joseph> the bug. The RIP points to kcryptd_crypt_write_io_submit() in
> Joseph> ~/drivers/md/dm-crypt.c. The
> "Joseph" == Joseph Salisbury writes:
Joseph> I captured the netconsole output from boot until I reproduced
Joseph> the bug. The RIP points to kcryptd_crypt_write_io_submit() in
Joseph> ~/drivers/md/dm-crypt.c. The output can be seen at:
I'm thinking that dm-crypt should probably set max_w
On 12/14/2012 05:35 PM, Martin K. Petersen wrote:
"Joseph" == Joseph Salisbury writes:
Joseph> I see that you are the author of this patch, so I wanted to run
Joseph> this by you. I was thinking of requesting a revert for v3.7,
Joseph> but I wanted to get your feedback first.
I copied luksfor
On 12/14/2012 05:35 PM, Martin K. Petersen wrote:
"Joseph" == Joseph Salisbury writes:
Joseph> I see that you are the author of this patch, so I wanted to run
Joseph> this by you. I was thinking of requesting a revert for v3.7,
Joseph> but I wanted to get your feedback first.
I copied luksfor
On 12/14/2012 04:11 PM, Mike Snitzer wrote:
On Fri, Dec 14 2012 at 3:30pm -0500,
Joseph Salisbury wrote:
Hi Martin,
A bug was opened against the Ubuntu kernel[0]. After a kernel
bisect, it was found that reverting the following commit resolved
this bug:
commit 5db44863b6ebbb400c5e61d56ebe8
> "Joseph" == Joseph Salisbury writes:
Joseph> I see that you are the author of this patch, so I wanted to run
Joseph> this by you. I was thinking of requesting a revert for v3.7,
Joseph> but I wanted to get your feedback first.
I copied luksformat from a Debian box so I could try to reprod
On Fri, Dec 14 2012 at 3:30pm -0500,
Joseph Salisbury wrote:
> Hi Martin,
>
> A bug was opened against the Ubuntu kernel[0]. After a kernel
> bisect, it was found that reverting the following commit resolved
> this bug:
>
> commit 5db44863b6ebbb400c5e61d56ebe8f21ef48b1bd
> Author: Martin K. P
21 matches
Mail list logo
