On 12/19/2012 08:58 PM, Mike Snitzer wrote: > On Wed, Dec 19 2012 at 11:58am -0500, > Martin K. Petersen <martin.peter...@oracle.com> wrote: > >>>>>>> "Joseph" == Joseph Salisbury <joseph.salisb...@canonical.com> writes: >> >> Joseph> I captured the netconsole output from boot until I reproduced >> Joseph> the bug. The RIP points to kcryptd_crypt_write_io_submit() in >> Joseph> ~/drivers/md/dm-crypt.c. The output can be seen at: >> >> I'm thinking that dm-crypt should probably set max_write_same_sectors to >> 0. It doesn't really make much sense for a crypto driver to pass that >> command through.
IMHO WRITE_SAME doesn't not make sense in encrypted storage. The same sectors in plaintext are _not_ the same in ciphertext. NEVER. (If so, you have a security problem.) It must be disabled in dmcrypt explicitly then (max_write_same_sectors?). Is it only dmcrypt, or encrypted fs are affected too? Milan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
