Re: [i2c] i2c module aliases

2007-06-15 Thread Jean Delvare
On Thu, 14 Jun 2007 12:14:24 -0700, Greg KH wrote: > On Sat, Jun 09, 2007 at 12:52:21PM +0200, Jean Delvare wrote: > > OK, no problem. I gave it a try myself. Greg, is it OK or did I miss > > other parts which can be removed? > > Looks good to me. Want me to take this through my tree or through >

Re: [i2c] i2c module aliases

2007-06-14 Thread Greg KH
On Sat, Jun 09, 2007 at 12:52:21PM +0200, Jean Delvare wrote: > On Fri, 8 Jun 2007 16:48:45 +0200 (CEST), Geert Uytterhoeven wrote: > > On Fri, 8 Jun 2007, Jean Delvare wrote: > > > OK. Geert, care to submit a new patch removing struct i2c_device_id > > > altogether? > > > > Sorry, probably not...

Re: [i2c] i2c module aliases

2007-06-09 Thread Jean Delvare
On Fri, 8 Jun 2007 16:48:45 +0200 (CEST), Geert Uytterhoeven wrote: > On Fri, 8 Jun 2007, Jean Delvare wrote: > > OK. Geert, care to submit a new patch removing struct i2c_device_id > > altogether? > > Sorry, probably not... > > I just thought I found a grave bug while looking into adding zorro >

Re: [i2c] i2c module aliases

2007-06-08 Thread Geert Uytterhoeven
On Fri, 8 Jun 2007, Jean Delvare wrote: > On Thu, 7 Jun 2007 09:02:14 -0700, Greg KH wrote: > > On Thu, Jun 07, 2007 at 05:53:42PM +0200, Jean Delvare wrote: > > > Looks correct. However I am curious what this "i2c->id" is supposed to > > > represent, given that I2C devices do not have any form of

Re: [i2c] i2c module aliases

2007-06-08 Thread Jean Delvare
On Thu, 7 Jun 2007 09:02:14 -0700, Greg KH wrote: > On Thu, Jun 07, 2007 at 05:53:42PM +0200, Jean Delvare wrote: > > Looks correct. However I am curious what this "i2c->id" is supposed to > > represent, given that I2C devices do not have any form of ID as PCI or > > USB devices have. No driver use

Re: [i2c] i2c module aliases

2007-06-07 Thread Greg KH
On Thu, Jun 07, 2007 at 05:53:42PM +0200, Jean Delvare wrote: > Hi Geert, > > On Wed, 6 Jun 2007 23:32:38 +0200 (CEST), Geert Uytterhoeven wrote: > > >From browsing through file2alias.c, I have the impression there's a > > missing TO_NATIVE() conversion in the handling of 16-bit (hence, > > endian

Re: [i2c] i2c module aliases

2007-06-07 Thread Jean Delvare
Hi Geert, On Wed, 6 Jun 2007 23:32:38 +0200 (CEST), Geert Uytterhoeven wrote: > >From browsing through file2alias.c, I have the impression there's a > missing TO_NATIVE() conversion in the handling of 16-bit (hence, > endian-affected) i2c IDs. > This will cause the module aliases to be incorrect w