On Sat, 9 Feb 2008 00:25:36 +0100
Ingo Molnar <[EMAIL PROTECTED]> wrote:
>
> * Dmitry Torokhov <[EMAIL PROTECTED]> wrote:
>
> > Stephen Hemminger (2):
> > Input: add driver for Fujitsu application buttons
>
> this change broke the build on x86 in randconfig testing:
>
> drivers/built-i
* Dmitry Torokhov <[EMAIL PROTECTED]> wrote:
> Stephen Hemminger (2):
> Input: add driver for Fujitsu application buttons
this change broke the build on x86 in randconfig testing:
drivers/built-in.o: In function `apanel_detach_client':
apanel.c:(.text+0x15c120): undefined reference to
On Thu, 7 Feb 2008 15:05:57 -0500
Dmitry Torokhov <[EMAIL PROTECTED]> wrote:
> On Tue, Feb 05, 2008 at 10:32:42PM -0800, Andrew Morton wrote:
> >
> > Looks OK. Minorish things from a quick scan:
> >
>
> *ping*
>
> Linus,
>
> Do you want me to redo the pull or is it still acceptable as is?
>
On Tue, Feb 05, 2008 at 10:32:42PM -0800, Andrew Morton wrote:
>
> Looks OK. Minorish things from a quick scan:
>
*ping*
Linus,
Do you want me to redo the pull or is it still acceptable as is?
I am hesitant touching the tree after sending a pull request...
Thanks,
Dmitry
--
Dmitry
--
To un
On Wed, Feb 06, 2008 at 08:56:35AM +0100, Sam Ravnborg wrote:
> >
> > >
> > >
> > >
> > > i8042_platform_init():
> > >
> > > +#if defined(__i386__) || defined(__x86_64__)
> > >
> > > use #ifdef CONFIG_X86?
> > >
> >
> > I considered it but above was tested and in line with the style of the
>
> >
> >
> >
> > i8042_platform_init():
> >
> > +#if defined(__i386__) || defined(__x86_64__)
> >
> > use #ifdef CONFIG_X86?
> >
>
> I considered it but above was tested and in line with the style of the
> rest of the file...
Then please change the rest of the file so it is consistent
wit
On Wed, 6 Feb 2008 01:08:30 -0500 Dmitry Torokhov <[EMAIL PROTECTED]> wrote:
> Andrew Morton (1):
> Input: i8042 - non-x86 build fix
Also, please prefer to fold patches like this into the patch which they
fix, to avoid breaking git-bisect, thanks.
(I add a little one-line mention in the ch
On Wednesday 06 February 2008 01:32, Andrew Morton wrote:
>
> Looks OK. Minorish things from a quick scan:
>
>
>
> tosakbd_scankeyboard() looks like it'll spend a perfectly wicked amount of
> time under spin_lock_irqsave().
>
I think you are right. I will check with Dmitry if it can be relaxe
Looks OK. Minorish things from a quick scan:
tosakbd_scankeyboard() looks like it'll spend a perfectly wicked amount of
time under spin_lock_irqsave().
This code, in tosakbd_probe():
+fail2:
+ while (--i >= 0)
+ gpio_free(TOSA_GPIO_KEY_STROBE(i));
+
+ i = TOSA_KEY
9 matches
Mail list logo