Re: [RFC][PATCH] tree-wide: Remove __inline__ and __inline usage

2018-11-06 Thread Peter Zijlstra
On Tue, Nov 06, 2018 at 11:51:35AM -0800, Linus Torvalds wrote: > On Tue, Nov 6, 2018 at 11:42 AM Peter Zijlstra wrote: > > > > Do you want me to do that patch, or have you already just done it? > > I'd rather see it go through something like -tip than doing it myself > directly, and get at least

Re: [RFC][PATCH] tree-wide: Remove __inline__ and __inline usage

2018-11-06 Thread Linus Torvalds
On Tue, Nov 6, 2018 at 11:42 AM Peter Zijlstra wrote: > > Do you want me to do that patch, or have you already just done it? I'd rather see it go through something like -tip than doing it myself directly, and get at least some of the automated testing before unleashing it on an unsuspecting world

Re: [RFC][PATCH] tree-wide: Remove __inline__ and __inline usage

2018-11-06 Thread Peter Zijlstra
On Tue, Nov 06, 2018 at 11:18:59AM -0800, Linus Torvalds wrote: > On Tue, Nov 6, 2018 at 2:02 AM Peter Zijlstra wrote: > > > > Therefore I'm proposing to run: > > > > git grep -l "\<__inline\(\|__\)\>" | while read file > > do > > sed -i -e 's/\<__inline\(\|__\)\>/inline/g' $file > >

Re: [RFC][PATCH] tree-wide: Remove __inline__ and __inline usage

2018-11-06 Thread Linus Torvalds
On Tue, Nov 6, 2018 at 2:02 AM Peter Zijlstra wrote: > > Therefore I'm proposing to run: > > git grep -l "\<__inline\(\|__\)\>" | while read file > do > sed -i -e 's/\<__inline\(\|__\)\>/inline/g' $file > done > > On your current tree, and apply the below fixup patch on top of that >

Re: [RFC][PATCH] tree-wide: Remove __inline__ and __inline usage

2018-11-06 Thread Miguel Ojeda
On Tue, Nov 6, 2018 at 3:46 PM Peter Zijlstra wrote: > > If you actually read what I wrote: You got me, I did read very quickly :) > Dunno, but that is a far more difficult patch. The proposed one is an > obvious identify. I would say they are orthogonal, even if both would solve the problem. I

Re: [RFC][PATCH] tree-wide: Remove __inline__ and __inline usage

2018-11-06 Thread Peter Zijlstra
On Tue, Nov 06, 2018 at 03:09:37PM +0100, Miguel Ojeda wrote: > On Tue, Nov 6, 2018 at 11:02 AM Peter Zijlstra wrote: > > > > allows adding the "inline" keyword to 'asm ("")' statements. The > > problem is that we're possibly redefining "inline" to > > "inline __attribute__((__always_inline__))" w

Re: [RFC][PATCH] tree-wide: Remove __inline__ and __inline usage

2018-11-06 Thread Miguel Ojeda
On Tue, Nov 6, 2018 at 11:02 AM Peter Zijlstra wrote: > > allows adding the "inline" keyword to 'asm ("")' statements. The > problem is that we're possibly redefining "inline" to > "inline __attribute__((__always_inline__))" which makes the proposed: > > asm volatile inline ("") > > (...) > > -#