Re: [PATCHv2] perf test: Disable breakpoint signal tests for powerpc

2017-06-04 Thread Jiri Olsa
On Fri, Jun 02, 2017 at 11:31:12AM -0300, Arnaldo Carvalho de Melo wrote: > Em Thu, Jun 01, 2017 at 10:54:50PM +0200, Jiri Olsa escreveu: > > > > > +bool test__bp_signal_is_on(void) > > > > > > > > Can you please rename this "_is_on()" thing to "_supported()"? > > > > v2 attached, > > jirka > >

Re: [PATCHv2] perf test: Disable breakpoint signal tests for powerpc

2017-06-02 Thread Arnaldo Carvalho de Melo
Em Thu, Jun 01, 2017 at 10:54:50PM +0200, Jiri Olsa escreveu: > > > > +bool test__bp_signal_is_on(void) > > > > > > Can you please rename this "_is_on()" thing to "_supported()"? > > v2 attached, > jirka Thanks, applied. - Arnaldo

Re: [PATCHv2] perf test: Disable breakpoint signal tests for powerpc

2017-06-02 Thread Arnaldo Carvalho de Melo
Em Fri, Jun 02, 2017 at 11:04:33AM -0300, Arnaldo Carvalho de Melo escreveu: > Em Thu, Jun 01, 2017 at 10:54:50PM +0200, Jiri Olsa escreveu: > > > > + if (t->is_supported && !t->is_supported()) { > > + pr_debug("%2d: %-*s: Disabled\n", i, width, t->desc); > > This isn

Re: [PATCHv2] perf test: Disable breakpoint signal tests for powerpc

2017-06-02 Thread Arnaldo Carvalho de Melo
Em Thu, Jun 01, 2017 at 10:54:50PM +0200, Jiri Olsa escreveu: > > + if (t->is_supported && !t->is_supported()) { > + pr_debug("%2d: %-*s: Disabled\n", i, width, t->desc); This isn't clear, I'll change this to leave the pr_debug up to the ->is_supported() code (tha