Re: [PATCH v6 1/6] perf report: properly handle branch count in match_chain

2017-10-22 Thread Namhyung Kim
Hi Arnaldo and Milian, On Fri, Oct 20, 2017 at 10:39:35AM -0300, Arnaldo Carvalho de Melo wrote: > Em Fri, Oct 20, 2017 at 01:38:23PM +0200, Milian Wolff escreveu: > > On Freitag, 20. Oktober 2017 12:21:35 CEST Milian Wolff wrote: > > > On Donnerstag, 19. Oktober 2017 17:01:08 CEST Namhyung Kim wr

Re: [PATCH v6 1/6] perf report: properly handle branch count in match_chain

2017-10-20 Thread Milian Wolff
On Freitag, 20. Oktober 2017 17:22:22 CEST Arnaldo Carvalho de Melo wrote: > Em Wed, Oct 18, 2017 at 08:53:45PM +0200, Milian Wolff escreveu: > > Some of the code paths I introduced before returned too early > > without running the code to handle a node's branch count. > > By refactoring match_chai

Re: [PATCH v6 1/6] perf report: properly handle branch count in match_chain

2017-10-20 Thread Arnaldo Carvalho de Melo
Em Wed, Oct 18, 2017 at 08:53:45PM +0200, Milian Wolff escreveu: > Some of the code paths I introduced before returned too early > without running the code to handle a node's branch count. > By refactoring match_chain to only have one exit point, this > can be remedied. > + case CCKEY_FUNCTION:

Re: [PATCH v6 1/6] perf report: properly handle branch count in match_chain

2017-10-20 Thread Arnaldo Carvalho de Melo
Em Fri, Oct 20, 2017 at 01:38:23PM +0200, Milian Wolff escreveu: > On Freitag, 20. Oktober 2017 12:21:35 CEST Milian Wolff wrote: > > On Donnerstag, 19. Oktober 2017 17:01:08 CEST Namhyung Kim wrote: > > > Hi Andi, > > > > > > On Thu, Oct 19, 2017 at 06:55:19AM -0700, Andi Kleen wrote: > > > > On

Re: [PATCH v6 1/6] perf report: properly handle branch count in match_chain

2017-10-20 Thread Milian Wolff
On Freitag, 20. Oktober 2017 12:21:35 CEST Milian Wolff wrote: > On Donnerstag, 19. Oktober 2017 17:01:08 CEST Namhyung Kim wrote: > > Hi Andi, > > > > On Thu, Oct 19, 2017 at 06:55:19AM -0700, Andi Kleen wrote: > > > On Thu, Oct 19, 2017 at 12:59:14PM +0200, Milian Wolff wrote: > > > > On Donners

Re: [PATCH v6 1/6] perf report: properly handle branch count in match_chain

2017-10-20 Thread Milian Wolff
On Donnerstag, 19. Oktober 2017 17:01:08 CEST Namhyung Kim wrote: > Hi Andi, > > On Thu, Oct 19, 2017 at 06:55:19AM -0700, Andi Kleen wrote: > > On Thu, Oct 19, 2017 at 12:59:14PM +0200, Milian Wolff wrote: > > > On Donnerstag, 19. Oktober 2017 00:41:04 CEST Andi Kleen wrote: > > > > Milian Wolff

Re: [PATCH v6 1/6] perf report: properly handle branch count in match_chain

2017-10-19 Thread Namhyung Kim
Hi Andi, On Thu, Oct 19, 2017 at 06:55:19AM -0700, Andi Kleen wrote: > On Thu, Oct 19, 2017 at 12:59:14PM +0200, Milian Wolff wrote: > > On Donnerstag, 19. Oktober 2017 00:41:04 CEST Andi Kleen wrote: > > > Milian Wolff writes: > > > > +static enum match_result match_address_dso(struct dso *left_

Re: [PATCH v6 1/6] perf report: properly handle branch count in match_chain

2017-10-19 Thread Andi Kleen
On Thu, Oct 19, 2017 at 12:59:14PM +0200, Milian Wolff wrote: > On Donnerstag, 19. Oktober 2017 00:41:04 CEST Andi Kleen wrote: > > Milian Wolff writes: > > > +static enum match_result match_address_dso(struct dso *left_dso, u64 > > > left_ip, + struct dso

Re: [PATCH v6 1/6] perf report: properly handle branch count in match_chain

2017-10-19 Thread Milian Wolff
On Donnerstag, 19. Oktober 2017 00:41:04 CEST Andi Kleen wrote: > Milian Wolff writes: > > +static enum match_result match_address_dso(struct dso *left_dso, u64 > > left_ip, + struct dso *right_dso, u64 > > right_ip) > > +{ > > + if (left_dso == right_dso &&

Re: [PATCH v6 1/6] perf report: properly handle branch count in match_chain

2017-10-18 Thread Andi Kleen
Milian Wolff writes: > > +static enum match_result match_address_dso(struct dso *left_dso, u64 left_ip, > +struct dso *right_dso, u64 right_ip) > +{ > + if (left_dso == right_dso && left_ip == right_ip) > + return MATCH_EQ; > + else if