Re: [PATCH v4 3/5] xen: Put EFI machinery in place

2014-05-20 Thread David Vrabel
On 20/05/14 12:29, Daniel Kiper wrote: > >>> + if (!xen_initial_domain() || HYPERVISOR_dom0_op(&op)) >>> + return NULL; >> >> if (!xen_initial_domain()) >> return NULL; >> >> if (HYPERVISOR_dom0_op(&op) < 0) >> return NULL; > > What is wrong with my

Re: [PATCH v4 3/5] xen: Put EFI machinery in place

2014-05-20 Thread Jan Beulich
>>> On 20.05.14 at 13:29, wrote: > On Tue, May 20, 2014 at 10:47:00AM +0100, David Vrabel wrote: >> On 16/05/14 21:41, Daniel Kiper wrote: >> > @@ -1714,6 +1725,21 @@ asmlinkage __visible void __init >> > xen_start_kernel(void) >> > >> >xen_setup_runstate_info(0); >> > >> > + efi_systab_xen

Re: [PATCH v4 3/5] xen: Put EFI machinery in place

2014-05-20 Thread Daniel Kiper
On Tue, May 20, 2014 at 10:47:00AM +0100, David Vrabel wrote: > On 16/05/14 21:41, Daniel Kiper wrote: > > Put EFI machinery for Xen in place. > > Put what machinery to do what? > > > @@ -1714,6 +1725,21 @@ asmlinkage __visible void __init > > xen_start_kernel(void) > > > > xen_setup_runstate_

Re: [PATCH v4 3/5] xen: Put EFI machinery in place

2014-05-20 Thread David Vrabel
On 16/05/14 21:41, Daniel Kiper wrote: > Put EFI machinery for Xen in place. Put what machinery to do what? > @@ -1714,6 +1725,21 @@ asmlinkage __visible void __init xen_start_kernel(void) > > xen_setup_runstate_info(0); > > + efi_systab_xen = xen_efi_probe(); > + > + if (efi_sy

Re: [PATCH v4 3/5] xen: Put EFI machinery in place

2014-05-19 Thread Jan Beulich
>>> On 16.05.14 at 22:41, wrote: > --- a/drivers/xen/Kconfig > +++ b/drivers/xen/Kconfig > @@ -240,4 +240,7 @@ config XEN_MCE_LOG > config XEN_HAVE_PVMMU > bool > > +config XEN_EFI > + def_bool X86_64 && EFI Constructs like this are bogus - they needlessly add a line to .config whe