On 20/05/14 12:29, Daniel Kiper wrote:
>
>>> + if (!xen_initial_domain() || HYPERVISOR_dom0_op(&op))
>>> + return NULL;
>>
>> if (!xen_initial_domain())
>> return NULL;
>>
>> if (HYPERVISOR_dom0_op(&op) < 0)
>> return NULL;
>
> What is wrong with my if?
Style. The function returns -ve on error not a boolean success/fail.
>>> +
>>> + /* Here we know that Xen runs on EFI platform. */
>>> +
>>> + efi = efi_xen;
>>> +
>>> + op.cmd = XENPF_firmware_info;
>>> + op.u.firmware_info.type = XEN_FW_EFI_INFO;
>>> + op.u.firmware_info.index = XEN_FW_EFI_VENDOR;
>>> + info->vendor.bufsz = sizeof(vendor);
>>> + set_xen_guest_handle(info->vendor.name, vendor);
>>> +
>>> + if (!HYPERVISOR_dom0_op(&op)) {
>>
>> if (HYPERVISOR_dom0_op(&op) == 0)
>
> Ditto?
Again, style.
David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
