Re: [PATCH v4 1/3] tracing: Add array printing helpers

2015-01-28 Thread Javi Merino
On Wed, Jan 28, 2015 at 11:26:09AM +, Javi Merino wrote: > On Wed, Jan 28, 2015 at 03:35:57AM +, Steven Rostedt wrote: > > On Mon, 26 Jan 2015 12:11:49 + > > Javi Merino wrote: > > > > > From: Dave Martin > > > > > > If a trace event contains an array, there is currently no standard

Re: [PATCH v4 1/3] tracing: Add array printing helpers

2015-01-28 Thread Steven Rostedt
On Wed, 28 Jan 2015 12:24:03 + Javi Merino wrote: > > > el_size should not be based on bits, it should be based on bytes. I > > > passed in "sizeof()" which doesn't work with bits. > > Ugh. If you use sizeof() in print_array() then trace-cmd won't be > able to parse it since it doesn't have

Re: [PATCH v4 1/3] tracing: Add array printing helpers

2015-01-28 Thread Javi Merino
On Wed, Jan 28, 2015 at 03:35:57AM +, Steven Rostedt wrote: > On Mon, 26 Jan 2015 12:11:49 + > Javi Merino wrote: > > > From: Dave Martin > > > > If a trace event contains an array, there is currently no standard > > way to format this for text output. Drivers are currently hacking > >

Re: [PATCH v4 1/3] tracing: Add array printing helpers

2015-01-27 Thread Steven Rostedt
On Mon, 26 Jan 2015 12:11:49 + Javi Merino wrote: > From: Dave Martin > > If a trace event contains an array, there is currently no standard > way to format this for text output. Drivers are currently hacking > around this by a) local hacks that use the trace_seq functionailty > directly,