Re: [PATCH v3 net-next 1/4] net: implement support for low latency socket polling

2013-05-21 Thread Pekka Riikonen
On Tue, 21 May 2013, David Miller wrote: From: Pekka Riikonen Date: Tue, 21 May 2013 19:02:19 +0200 (CEST) On Tue, 21 May 2013, Eric Dumazet wrote: : > > Alternatively, use a napi_id instead of a pointer. : > : > I'm not sure I understand what you propose. : : Oh well. : : To get a pointer t

Re: [PATCH v3 net-next 1/4] net: implement support for low latency socket polling

2013-05-21 Thread Eric Dumazet
On Tue, 2013-05-21 at 22:25 +0300, Eliezer Tamir wrote: > On 21/05/2013 20:51, Eric Dumazet wrote: > > On Tue, 2013-05-21 at 10:48 -0700, Eric Dumazet wrote: > > > >> We do not keep skb->dev information once a packet leaves the rcu > >> protected region. > >> > >> Once packet is queued to tcp input

Re: [PATCH v3 net-next 1/4] net: implement support for low latency socket polling

2013-05-21 Thread Eliezer Tamir
On 21/05/2013 20:51, Eric Dumazet wrote: On Tue, 2013-05-21 at 10:48 -0700, Eric Dumazet wrote: We do not keep skb->dev information once a packet leaves the rcu protected region. Once packet is queued to tcp input queues, skb->dev is NULL. This is done in tcp_v4_rcv() & tcp_v6_rcv() So if

Re: [PATCH v3 net-next 1/4] net: implement support for low latency socket polling

2013-05-21 Thread David Miller
From: Pekka Riikonen Date: Tue, 21 May 2013 19:02:19 +0200 (CEST) > On Tue, 21 May 2013, Eric Dumazet wrote: > > : > > Alternatively, use a napi_id instead of a pointer. > : > > : > I'm not sure I understand what you propose. > : > : Oh well. > : > : To get a pointer to a struct net_device, w

Re: [PATCH v3 net-next 1/4] net: implement support for low latency socket polling

2013-05-21 Thread Eric Dumazet
On Tue, 2013-05-21 at 10:48 -0700, Eric Dumazet wrote: > We do not keep skb->dev information once a packet leaves the rcu > protected region. > > Once packet is queued to tcp input queues, skb->dev is NULL. This is done in tcp_v4_rcv() & tcp_v6_rcv() -- To unsubscribe from this list: send the

Re: [PATCH v3 net-next 1/4] net: implement support for low latency socket polling

2013-05-21 Thread Eric Dumazet
On Tue, 2013-05-21 at 19:02 +0200, Pekka Riikonen wrote: > Maybe even that's not needed. Couldn't skb->queue_mapping give the > correct NAPI instance in multiqueue nics? The NAPI instance could be made > easily available from skb->dev. In any case an index is much better than > a new pointer

Re: [PATCH v3 net-next 1/4] net: implement support for low latency socket polling

2013-05-21 Thread Pekka Riikonen
On Tue, 21 May 2013, Eric Dumazet wrote: : > > Alternatively, use a napi_id instead of a pointer. : > : > I'm not sure I understand what you propose. : : Oh well. : : To get a pointer to a struct net_device, we can use ifindex, and do a : rcu lookup into a hash table to get the net_device. We d

Re: [PATCH v3 net-next 1/4] net: implement support for low latency socket polling

2013-05-21 Thread Eric Dumazet
On Tue, 2013-05-21 at 10:28 +0300, Eliezer Tamir wrote: > On 20/05/2013 18:29, Eric Dumazet wrote: > > On Mon, 2013-05-20 at 13:16 +0300, Eliezer Tamir wrote: > --- > >> +static inline void skb_mark_ll(struct sk_buff *skb, struct napi_struct > >> *napi) > >> +{ > >> + skb->dev_ref = napi; > >> +}

Re: [PATCH v3 net-next 1/4] net: implement support for low latency socket polling

2013-05-21 Thread Eliezer Tamir
On 20/05/2013 18:29, Eric Dumazet wrote: On Mon, 2013-05-20 at 13:16 +0300, Eliezer Tamir wrote: --- +static inline void skb_mark_ll(struct sk_buff *skb, struct napi_struct *napi) +{ + skb->dev_ref = napi; +} + +static inline void sk_mark_ll(struct sock *sk, struct sk_buff *skb) +{ +

Re: [PATCH v3 net-next 1/4] net: implement support for low latency socket polling

2013-05-20 Thread David Miller
From: Eric Dumazet Date: Mon, 20 May 2013 08:29:24 -0700 > Part of this information was in your 0/4 text, but it wont be included > in the git tree. Yes it will, in the merge commit I make when I merge this stuff in. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in t

Re: [PATCH v3 net-next 1/4] net: implement support for low latency socket polling

2013-05-20 Thread Eric Dumazet
On Mon, 2013-05-20 at 13:16 +0300, Eliezer Tamir wrote: > Adds a new ndo_ll_poll method and the code that supports and uses it. > This method can be used by low latency applications to busy poll ethernet > device queues directly from the socket code. The ip_low_latency_poll sysctl > entry controls