On Mon, 2013-05-20 at 13:16 +0300, Eliezer Tamir wrote:
> Adds a new ndo_ll_poll method and the code that supports and uses it.
> This method can be used by low latency applications to busy poll ethernet
> device queues directly from the socket code. The ip_low_latency_poll sysctl
> entry controls how many cycles to poll. Set to zero to disable.
>
This changelog lacks a lot of information, see below.
Part of this information was in your 0/4 text, but it wont be included
in the git tree.
> Signed-off-by: Alexander Duyck <alexander.h.du...@intel.com>
> Signed-off-by: Jesse Brandeburg <jesse.brandeb...@intel.com>
> Tested-by: Willem de Bruijn <will...@google.com>
> Signed-off-by: Eliezer Tamir <eliezer.ta...@linux.intel.com>
> ---
>
> +
> +static inline void skb_mark_ll(struct sk_buff *skb, struct napi_struct *napi)
> +{
> + skb->dev_ref = napi;
> +}
> +
> +static inline void sk_mark_ll(struct sock *sk, struct sk_buff *skb)
> +{
> + sk->dev_ref = skb->dev_ref;
> +}
I do not see why it's safe to keep a pointer to a napi object without
taking a reference, or something to prevent object being removed.
Using a genid might be enough. (some counter incremented every time a
napi is dismantled)
Alternatively, use a napi_id instead of a pointer.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
