Re: [PATCH v3] modpost: check for static EXPORT_SYMBOL* functions

2019-07-30 Thread Masahiro Yamada
On Wed, Jul 31, 2019 at 1:44 AM Denis Efremov wrote: > > On 30.07.2019 19:29, Masahiro Yamada wrote: > > I prefer this, but why do you need to check type? > > > > Doesn't this work? > > > > for (sym = info.symtab_start; sym < info.symtab_stop; sym++) { > > unsigned char bind = ELF_ST_BIND

Re: [PATCH v3] modpost: check for static EXPORT_SYMBOL* functions

2019-07-30 Thread Denis Efremov
On 30.07.2019 19:29, Masahiro Yamada wrote: I prefer this, but why do you need to check type? Doesn't this work? for (sym = info.symtab_start; sym < info.symtab_stop; sym++) { unsigned char bind = ELF_ST_BIND(sym->st_info); struct symbol *s = find_symbol(remove_dot(info.strta

Re: [PATCH v3] modpost: check for static EXPORT_SYMBOL* functions

2019-07-30 Thread Masahiro Yamada
On Tue, Jul 30, 2019 at 4:00 PM Denis Efremov wrote: > > On 30.07.2019 01:26, Stephen Rothwell wrote: > > Hi Denis, > > > > On Mon, 29 Jul 2019 17:18:01 +0300 Denis Efremov wrote: > >> > >> This patch adds a check to warn about static EXPORT_SYMBOL* functions > >> during the modpost. In most of t

Re: [PATCH v3] modpost: check for static EXPORT_SYMBOL* functions

2019-07-30 Thread Denis Efremov
On 30.07.2019 01:26, Stephen Rothwell wrote: Hi Denis, On Mon, 29 Jul 2019 17:18:01 +0300 Denis Efremov wrote: This patch adds a check to warn about static EXPORT_SYMBOL* functions during the modpost. In most of the cases, a static symbol marked for exporting is an odd combination that should

Re: [PATCH v3] modpost: check for static EXPORT_SYMBOL* functions

2019-07-29 Thread Stephen Rothwell
Hi Denis, On Mon, 29 Jul 2019 17:18:01 +0300 Denis Efremov wrote: > > This patch adds a check to warn about static EXPORT_SYMBOL* functions > during the modpost. In most of the cases, a static symbol marked for > exporting is an odd combination that should be fixed either by deleting > the export