Re: [PATCH v3] ANDROID: binder: change down_write to down_read

2018-03-29 Thread Fengguang Wu
On Fri, Mar 30, 2018 at 09:37:36AM +0900, Minchan Kim wrote: On Fri, Mar 30, 2018 at 07:42:37AM +0800, kbuild test robot wrote: Hi Minchan, I love your patch! Yet something to improve: Glad to hear. It's first time someone loves my patch. ;-) FYI, that message originates from Linus. :-) [

Re: [PATCH v3] ANDROID: binder: change down_write to down_read

2018-03-29 Thread Minchan Kim
On Fri, Mar 30, 2018 at 07:42:37AM +0800, kbuild test robot wrote: > Hi Minchan, > > I love your patch! Yet something to improve: Glad to hear. It's first time someone loves my patch. ;-) > > [auto build test ERROR on staging/staging-testing] > [also build test ERROR on v4.16-rc7 next-20180329]

Re: [PATCH v3] ANDROID: binder: change down_write to down_read

2018-03-29 Thread kbuild test robot
Hi Minchan, I love your patch! Yet something to improve: [auto build test ERROR on staging/staging-testing] [also build test ERROR on v4.16-rc7 next-20180329] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/l

Re: [PATCH v3] ANDROID: binder: change down_write to down_read

2018-03-28 Thread Greg Kroah-Hartman
On Thu, Mar 29, 2018 at 11:42:04AM +0900, Minchan Kim wrote: > > On Thu, Mar 29, 2018 at 11:37:12AM +0900, Minchan Kim wrote: > > binder_update_page_range needs down_write of mmap_sem because > > vm_insert_page need to change vma->vm_flags to VM_MIXEDMAP unless > > it is set. However, when I profi

Re: [PATCH v3] ANDROID: binder: change down_write to down_read

2018-03-28 Thread Minchan Kim
On Thu, Mar 29, 2018 at 11:37:12AM +0900, Minchan Kim wrote: > binder_update_page_range needs down_write of mmap_sem because > vm_insert_page need to change vma->vm_flags to VM_MIXEDMAP unless > it is set. However, when I profile binder working, it seems > every binder buffers should be mapped in