Hi Minchan, I love your patch! Yet something to improve:
[auto build test ERROR on staging/staging-testing] [also build test ERROR on v4.16-rc7 next-20180329] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Minchan-Kim/ANDROID-binder-change-down_write-to-down_read/20180330-043057 config: x86_64-randconfig-x014-201812 (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All errors (new ones prefixed by >>): drivers//android/binder.c: In function 'binder_mmap': >> drivers//android/binder.c:4725:24: error: 'struct vm_area_struct' has no >> member named 'flags'; did you mean 'vm_flags'? vma->vm_flags = (vma->flags | VM_DONTCOPY | VM_MIXEDMAP) & ^~~~~ vm_flags vim +4725 drivers//android/binder.c 4701 4702 static int binder_mmap(struct file *filp, struct vm_area_struct *vma) 4703 { 4704 int ret; 4705 struct binder_proc *proc = filp->private_data; 4706 const char *failure_string; 4707 4708 if (proc->tsk != current->group_leader) 4709 return -EINVAL; 4710 4711 if ((vma->vm_end - vma->vm_start) > SZ_4M) 4712 vma->vm_end = vma->vm_start + SZ_4M; 4713 4714 binder_debug(BINDER_DEBUG_OPEN_CLOSE, 4715 "%s: %d %lx-%lx (%ld K) vma %lx pagep %lx\n", 4716 __func__, proc->pid, vma->vm_start, vma->vm_end, 4717 (vma->vm_end - vma->vm_start) / SZ_1K, vma->vm_flags, 4718 (unsigned long)pgprot_val(vma->vm_page_prot)); 4719 4720 if (vma->vm_flags & FORBIDDEN_MMAP_FLAGS) { 4721 ret = -EPERM; 4722 failure_string = "bad vm_flags"; 4723 goto err_bad_arg; 4724 } > 4725 vma->vm_flags = (vma->flags | VM_DONTCOPY | VM_MIXEDMAP) & 4726 ~VM_MAYWRITE; 4727 vma->vm_ops = &binder_vm_ops; 4728 vma->vm_private_data = proc; 4729 4730 ret = binder_alloc_mmap_handler(&proc->alloc, vma); 4731 if (ret) 4732 return ret; 4733 mutex_lock(&proc->files_lock); 4734 proc->files = get_files_struct(current); 4735 mutex_unlock(&proc->files_lock); 4736 return 0; 4737 4738 err_bad_arg: 4739 pr_err("%s: %d %lx-%lx %s failed %d\n", __func__, 4740 proc->pid, vma->vm_start, vma->vm_end, failure_string, ret); 4741 return ret; 4742 } 4743 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
