Re: [PATCH v2 4/5] locking/lockdep: Make class->ops a percpu counter

2018-10-04 Thread Waiman Long
On 10/04/2018 06:14 AM, Ingo Molnar wrote: > * Waiman Long wrote: > >> diff --git a/include/linux/lockdep.h b/include/linux/lockdep.h >> index b0d0b51c4d85..1fd82ff99c65 100644 >> --- a/include/linux/lockdep.h >> +++ b/include/linux/lockdep.h >> @@ -99,13 +99,8 @@ struct lock_class { >> */ >

Re: [PATCH v2 4/5] locking/lockdep: Make class->ops a percpu counter

2018-10-04 Thread Ingo Molnar
* Waiman Long wrote: > diff --git a/include/linux/lockdep.h b/include/linux/lockdep.h > index b0d0b51c4d85..1fd82ff99c65 100644 > --- a/include/linux/lockdep.h > +++ b/include/linux/lockdep.h > @@ -99,13 +99,8 @@ struct lock_class { >*/ > unsigned intversion; >

Re: [PATCH v2 4/5] locking/lockdep: Make class->ops a percpu counter

2018-10-03 Thread Waiman Long
On 10/03/2018 09:57 AM, Waiman Long wrote: > On 10/03/2018 03:48 AM, Peter Zijlstra wrote: >> On Tue, Oct 02, 2018 at 04:19:19PM -0400, Waiman Long wrote: >>> +DEFINE_PER_CPU(unsigned long [MAX_LOCKDEP_KEYS], lock_class_ops); >>> @@ -179,9 +181,30 @@ DECLARE_PER_CPU(struct lockdep_stats, lockdep_st

Re: [PATCH v2 4/5] locking/lockdep: Make class->ops a percpu counter

2018-10-03 Thread Waiman Long
On 10/03/2018 03:48 AM, Peter Zijlstra wrote: > On Tue, Oct 02, 2018 at 04:19:19PM -0400, Waiman Long wrote: >> +DEFINE_PER_CPU(unsigned long [MAX_LOCKDEP_KEYS], lock_class_ops); >> @@ -179,9 +181,30 @@ DECLARE_PER_CPU(struct lockdep_stats, lockdep_stats); >> }

Re: [PATCH v2 4/5] locking/lockdep: Make class->ops a percpu counter

2018-10-03 Thread Peter Zijlstra
On Wed, Oct 03, 2018 at 09:54:46AM +0200, Ingo Molnar wrote: > > * Peter Zijlstra wrote: > > > On Tue, Oct 02, 2018 at 04:19:19PM -0400, Waiman Long wrote: > > > +DEFINE_PER_CPU(unsigned long [MAX_LOCKDEP_KEYS], lock_class_ops); > > > > > @@ -179,9 +181,30 @@ DECLARE_PER_CPU(struct lockdep_stat

Re: [PATCH v2 4/5] locking/lockdep: Make class->ops a percpu counter

2018-10-03 Thread Ingo Molnar
* Peter Zijlstra wrote: > On Tue, Oct 02, 2018 at 04:19:19PM -0400, Waiman Long wrote: > > +DEFINE_PER_CPU(unsigned long [MAX_LOCKDEP_KEYS], lock_class_ops); > > > @@ -179,9 +181,30 @@ DECLARE_PER_CPU(struct lockdep_stats, lockdep_stats); > > }

Re: [PATCH v2 4/5] locking/lockdep: Make class->ops a percpu counter

2018-10-03 Thread Peter Zijlstra
On Tue, Oct 02, 2018 at 04:19:19PM -0400, Waiman Long wrote: > +DEFINE_PER_CPU(unsigned long [MAX_LOCKDEP_KEYS], lock_class_ops); > @@ -179,9 +181,30 @@ DECLARE_PER_CPU(struct lockdep_stats, lockdep_stats); > } \ > __total;