Re: [PATCH v2 1/2] ASoC: SOF: Add Comet Lake PCI IDs

On Wed, May 8, 2019 at 10:00 AM Pierre-Louis Bossart wrote: > > > > On 5/8/19 11:42 AM, Evan Green wrote: > > On Tue, May 7, 2019 at 3:14 PM Pierre-Louis Bossart > > wrote: > >> > >> Minor nit-picks below. The Kconfig would work but select CANNONLAKE even > >> if you don't want it. > >> > >>> > >

Re: [PATCH v2 1/2] ASoC: SOF: Add Comet Lake PCI IDs

On 5/8/19 11:42 AM, Evan Green wrote: On Tue, May 7, 2019 at 3:14 PM Pierre-Louis Bossart wrote: Minor nit-picks below. The Kconfig would work but select CANNONLAKE even if you don't want it. +config SND_SOC_SOF_COMETLAKE_LP + tristate + select SND_SOC_SOF_CANNONLAKE This shoul

Re: [PATCH v2 1/2] ASoC: SOF: Add Comet Lake PCI IDs

On Tue, May 7, 2019 at 3:14 PM Pierre-Louis Bossart wrote: > > Minor nit-picks below. The Kconfig would work but select CANNONLAKE even > if you don't want it. > > > > > +config SND_SOC_SOF_COMETLAKE_LP > > + tristate > > + select SND_SOC_SOF_CANNONLAKE > > This should be > select SND_SOF_

Re: [PATCH v2 1/2] ASoC: SOF: Add Comet Lake PCI IDs

Minor nit-picks below. The Kconfig would work but select CANNONLAKE even if you don't want it. +config SND_SOC_SOF_COMETLAKE_LP + tristate + select SND_SOC_SOF_CANNONLAKE This should be select SND_SOF_SOF_HDA_COMMON + help + This option is not user-selectable bu